RE: Publishing to Maven Central
OK I have tried using the 2.6-SNAPSHOT at https://repository.apache.org/content/repositories/snapshots/ and I get the following dependency issues: [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Failed to resolve artifact. Missing: -- 1) org.bouncycastle:bcmail-jdk15:jar:$(bcmail.version} Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=org.bouncycastle -DartifactId=bcmail-jdk15 -Dversion=$(bcmail.version} -Dpackaging=jar -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=org.bouncycastle -DartifactId=bcmail-jdk15 -Dversion=$(bcmail.version} -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.bouncycastle:bcmail-jdk15:jar:$(bcmail.version} 2) maven-plugins:maven-cobertura-plugin:plugin:1.3 Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=maven-plugins -DartifactId=maven-cobertura-plugin -Dversion=1.3 -Dpackaging=plugin -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=maven-plugins -DartifactId=maven-cobertura-plugin -Dversion=1.3 -Dpackaging=plugin -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.jdom:jdom:jar:1.1.2 4) jaxen:jaxen:jar:1.1.3 5) maven-plugins:maven-cobertura-plugin:plugin:1.3 3) maven-plugins:maven-findbugs-plugin:plugin:1.3.1 Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=maven-plugins -DartifactId=maven-findbugs-plugin -Dversion=1.3.1 -Dpackaging=plugin -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=maven-plugins -DartifactId=maven-findbugs-plugin -Dversion=1.3.1 -Dpackaging=plugin -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.jdom:jdom:jar:1.1.2 4) jaxen:jaxen:jar:1.1.3 5) maven-plugins:maven-findbugs-plugin:plugin:1.3.1 4) org.apache.jmeter:ApacheJMeter_mail:jar:2.6-SNAPSHOT Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=org.apache.jmeter -DartifactId=ApacheJMeter_mail -Dversion=2.6-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=org.apache.jmeter -DartifactId=ApacheJMeter_mail -Dversion=2.6-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_mail:jar:2.6-SNAPSHOT -- 4 required artifacts are missing. for artifact: org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT from the specified remote repositories: central (http://repo1.maven.org/maven2), Java maven repo (https://repository.apache.org/content/repositories/snapshots/), Maven JMeter Repo (http://ardesco.github.com/jmeter-maven-plugin/repository) [INFO] Regards Mark Sebb, There is a transitive dependency issue with JDOM pulling in jaxen which by default tries to pull in some plugins that are not available: http://blog.cedarsoft.com/2011/12/fixing-maven-artifact-jaxen/ http://jira.codehaus.org/browse/JAXEN-217 This is fixed in the package I supplied yesterday by adding an exclusion for jaxen. I have also added in a repo that has jchart 0.75 available, and one for beanshell 2.0b5 (although checking just now I have missed the dependency block for beanshell in the parent POM so it isn't actually pulling beanshell down). I'll look at it in a bit more anger in a couple of hours to provide some more useful feedback. Ant-contrib is used in the patch I have supplied to loop through a couple of lists and add in an if/else block that will allow you to choose if you want to add sources and javadoc jars when deploying, if you don't want to do these things it isn't needed. Regards
RE: Publishing to Maven Central
Oh this has highlighted another difference between the implementation I supplied and your one, I have a POM named ApacheJMeter_reports and you have one named ApacheJMeter_report. If you do want to use the one I supplied you'll need to take the s off the name to make it match your current POM. -Original Message- From: Mark Collin [mailto:m...@ardescosolutions.com] Sent: 19 January 2012 09:09 To: dev@jmeter.apache.org Subject: RE: Publishing to Maven Central OK I have tried using the 2.6-SNAPSHOT at https://repository.apache.org/content/repositories/snapshots/ and I get the following dependency issues: [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Failed to resolve artifact. Missing: -- 1) org.bouncycastle:bcmail-jdk15:jar:$(bcmail.version} Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=org.bouncycastle -DartifactId=bcmail-jdk15 -Dversion=$(bcmail.version} -Dpackaging=jar -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=org.bouncycastle -DartifactId=bcmail-jdk15 -Dversion=$(bcmail.version} -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.bouncycastle:bcmail-jdk15:jar:$(bcmail.version} 2) maven-plugins:maven-cobertura-plugin:plugin:1.3 Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=maven-plugins -DartifactId=maven-cobertura-plugin -Dversion=1.3 -Dpackaging=plugin -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=maven-plugins -DartifactId=maven-cobertura-plugin -Dversion=1.3 -Dpackaging=plugin -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.jdom:jdom:jar:1.1.2 4) jaxen:jaxen:jar:1.1.3 5) maven-plugins:maven-cobertura-plugin:plugin:1.3 3) maven-plugins:maven-findbugs-plugin:plugin:1.3.1 Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=maven-plugins -DartifactId=maven-findbugs-plugin -Dversion=1.3.1 -Dpackaging=plugin -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=maven-plugins -DartifactId=maven-findbugs-plugin -Dversion=1.3.1 -Dpackaging=plugin -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.jdom:jdom:jar:1.1.2 4) jaxen:jaxen:jar:1.1.3 5) maven-plugins:maven-findbugs-plugin:plugin:1.3.1 4) org.apache.jmeter:ApacheJMeter_mail:jar:2.6-SNAPSHOT Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=org.apache.jmeter -DartifactId=ApacheJMeter_mail -Dversion=2.6-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=org.apache.jmeter -DartifactId=ApacheJMeter_mail -Dversion=2.6-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_mail:jar:2.6-SNAPSHOT -- 4 required artifacts are missing. for artifact: org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT from the specified remote repositories: central (http://repo1.maven.org/maven2), Java maven repo (https://repository.apache.org/content/repositories/snapshots/), Maven JMeter Repo (http://ardesco.github.com/jmeter-maven-plugin/repository) [INFO] Regards Mark Sebb, There is a transitive dependency issue with JDOM pulling in jaxen which by default tries to pull in some plugins that are not available: http://blog.cedarsoft.com/2011/12/fixing-maven-artifact-jaxen/ http://jira.codehaus.org/browse/JAXEN-217 This is fixed in the package I supplied yesterday by adding an exclusion for jaxen. I have also added in a repo that has jchart 0.75 available, and one for beanshell 2.0b5 (although checking just now I have
Re: Publishing to Maven Central
On 19 January 2012 09:13, Mark Collin m...@ardescosolutions.com wrote: Oh this has highlighted another difference between the implementation I supplied and your one, I have a POM named ApacheJMeter_reports and you have one named ApacheJMeter_report. If you do want to use the one I supplied you'll need to take the s off the name to make it match your current POM. I changed that so the pom matches the jar name, makes the Ant file simpler. -Original Message- From: Mark Collin [mailto:m...@ardescosolutions.com] Sent: 19 January 2012 09:09 To: dev@jmeter.apache.org Subject: RE: Publishing to Maven Central OK I have tried using the 2.6-SNAPSHOT at https://repository.apache.org/content/repositories/snapshots/ and I get the following dependency issues: [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Failed to resolve artifact. Missing: -- 1) org.bouncycastle:bcmail-jdk15:jar:$(bcmail.version} Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=org.bouncycastle -DartifactId=bcmail-jdk15 -Dversion=$(bcmail.version} -Dpackaging=jar -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=org.bouncycastle -DartifactId=bcmail-jdk15 -Dversion=$(bcmail.version} -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.bouncycastle:bcmail-jdk15:jar:$(bcmail.version} 2) maven-plugins:maven-cobertura-plugin:plugin:1.3 Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=maven-plugins -DartifactId=maven-cobertura-plugin -Dversion=1.3 -Dpackaging=plugin -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=maven-plugins -DartifactId=maven-cobertura-plugin -Dversion=1.3 -Dpackaging=plugin -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.jdom:jdom:jar:1.1.2 4) jaxen:jaxen:jar:1.1.3 5) maven-plugins:maven-cobertura-plugin:plugin:1.3 3) maven-plugins:maven-findbugs-plugin:plugin:1.3.1 Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=maven-plugins -DartifactId=maven-findbugs-plugin -Dversion=1.3.1 -Dpackaging=plugin -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=maven-plugins -DartifactId=maven-findbugs-plugin -Dversion=1.3.1 -Dpackaging=plugin -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.jdom:jdom:jar:1.1.2 4) jaxen:jaxen:jar:1.1.3 5) maven-plugins:maven-findbugs-plugin:plugin:1.3.1 4) org.apache.jmeter:ApacheJMeter_mail:jar:2.6-SNAPSHOT Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=org.apache.jmeter -DartifactId=ApacheJMeter_mail -Dversion=2.6-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=org.apache.jmeter -DartifactId=ApacheJMeter_mail -Dversion=2.6-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_mail:jar:2.6-SNAPSHOT -- 4 required artifacts are missing. for artifact: org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT from the specified remote repositories: central (http://repo1.maven.org/maven2), Java maven repo (https://repository.apache.org/content/repositories/snapshots/), Maven JMeter Repo (http://ardesco.github.com/jmeter-maven-plugin/repository) [INFO] Regards Mark Sebb, There is a transitive dependency issue with JDOM pulling in jaxen which by default tries to pull in some plugins that are not available: http://blog.cedarsoft.com/2011/12/fixing-maven-artifact-jaxen/ http://jira.codehaus.org/browse/JAXEN-217 This is fixed in
Re: Time for a release?
I have to finish 2 things (mirror server documentation and default to 2.5.1 behaviour) and commit another patch . I think I will do it this week end. Sebb, Milamber, when do you plan the release ? Regards Philippe On Thu, Jan 19, 2012 at 8:49 AM, Milamber milam...@apache.org wrote: Hello, I can act as a release manager for the 2.6 version. Milamber Le 15/01/2012 14:27, Milamber a ecrit : Le 15/01/2012 12:58, Rainer Jung a ecrit : Hello everyone, at the beginning of December 2011 we discussed, whether we should have a release soon. I think the overall opinion was yes but it seems the project is still busy with fixing things and adding enhancements. Nevertheless I have the impression there are now enough changes to warrant the next release and get all the nice new stuff out in users hands. I don't know whether it should be a 2.5.2 or 2.6 though. +1 to release a new version 2.6 Milamber Kudos to all the effort you put into JMeter! Regards, Rainer -- Cordialement. Philippe Mouawad.
Re: svn commit: r1233097 - in /jmeter/trunk: docs/images/screenshots/changes/ xdocs/ xdocs/images/screenshots/changes/
Hello, Regarding New and noteworthy, should'nt we also have: - JMS improvements (51419 and 52088) - And ignore failed for embedded resources (like Remote Batching support) Milamber, I can add them if you tell me which software you use for your highlights ? Thanks. Regards Philippe On Thu, Jan 19, 2012 at 7:36 AM, Philippe Mouawad philippe.moua...@gmail.com wrote: Yes, very good indeed ! Thanks On Thu, Jan 19, 2012 at 2:47 AM, sebb seb...@gmail.com wrote: On 18 January 2012 22:29, milam...@apache.org wrote: Author: milamber Date: Wed Jan 18 22:29:54 2012 New Revision: 1233097 URL: http://svn.apache.org/viewvc?rev=1233097view=rev Log: Add New and Noteworthy for next version (2.6) Looks very good, thanks! -- Cordialement. Philippe Mouawad. -- Cordialement. Philippe Mouawad.
HTTP Requests, content encoding and recording
Hello, when recording HTTP data with JMeter, I'd assume that the request is sent to the server just like the browser would send it. This is not the case in two examples I've run across. As you'll know, when recording with HTTP Proxy Server, JMeter will be creating HTTP Samplers and then using their sample method to realize the request, returning the return value to the browser. So we need to create a HTTP Sampler which produces the same request as the browser would have. When looking at HttpRequestHdrExt.populateSampler, I see that ConversionUtils,getEncodingFromContentType is called. In case the encoding is not supported (returns null) we look in the pageEncodings and formEncodings maps (when are they populated??) and if we find nothing here, we use: postData = new String(rawPostData); meaning we convert the bytes to a string based on the platform-specific default encoding. In my examples this breaks the communication, so not only replay but record does not work. In one case I have no Content-Type header in the request, and new String(rawPostData) seems to break it, in the other case, I have a Content-Type: application/soap+msbin1 header, where getEncodingFromContentType returns null. We really should make sure JMeter sends exactly what it received to the server when acting as proxy, and even better would be if this would work when executing the test. What do you think? Regards, Jens
Re: svn commit: r1233097 - in /jmeter/trunk: docs/images/screenshots/changes/ xdocs/ xdocs/images/screenshots/changes/
On Thu, Jan 19, 2012 at 12:20 PM, Philippe Mouawad philippe.moua...@gmail.com wrote: Hello, Regarding New and noteworthy, should'nt we also have: - JMS improvements (51419 and 52088) - And ignore failed for embedded resources (like Remote Batching support) Milamber, I can add them if you tell me which software you use for your highlights ? I use : Shutter for screen-shots and annotation (http://shutter-project.org/) (Debian packages) And The GIMP for add a black border (2pix) I can make the resizing and integrating in changes.xml if you send me the full screenshots. Milamber Thanks. Regards Philippe On Thu, Jan 19, 2012 at 7:36 AM, Philippe Mouawad philippe.moua...@gmail.com wrote: Yes, very good indeed ! Thanks On Thu, Jan 19, 2012 at 2:47 AM, sebb seb...@gmail.com wrote: On 18 January 2012 22:29, milam...@apache.org wrote: Author: milamber Date: Wed Jan 18 22:29:54 2012 New Revision: 1233097 URL: http://svn.apache.org/viewvc?rev=1233097view=rev Log: Add New and Noteworthy for next version (2.6) Looks very good, thanks! -- Cordialement. Philippe Mouawad. -- Cordialement. Philippe Mouawad.
RE: Publishing to Maven Central
Just tried the latest snapshot and everything looks good now. :) Is the plan to push this up to the maven central repo when 2.6 final is released? -Original Message- From: sebb [mailto:seb...@gmail.com] Sent: 19 January 2012 10:59 To: dev@jmeter.apache.org Subject: Re: Publishing to Maven Central On 19 January 2012 09:13, Mark Collin m...@ardescosolutions.com wrote: Oh this has highlighted another difference between the implementation I supplied and your one, I have a POM named ApacheJMeter_reports and you have one named ApacheJMeter_report. If you do want to use the one I supplied you'll need to take the s off the name to make it match your current POM. I changed that so the pom matches the jar name, makes the Ant file simpler. -Original Message- From: Mark Collin [mailto:m...@ardescosolutions.com] Sent: 19 January 2012 09:09 To: dev@jmeter.apache.org Subject: RE: Publishing to Maven Central OK I have tried using the 2.6-SNAPSHOT at https://repository.apache.org/content/repositories/snapshots/ and I get the following dependency issues: [INFO] -- -- [ERROR] BUILD ERROR [INFO] -- -- [INFO] Failed to resolve artifact. Missing: -- 1) org.bouncycastle:bcmail-jdk15:jar:$(bcmail.version} Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=org.bouncycastle -DartifactId=bcmail-jdk15 -Dversion=$(bcmail.version} -Dpackaging=jar -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=org.bouncycastle -DartifactId=bcmail-jdk15 -Dversion=$(bcmail.version} -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.bouncycastle:bcmail-jdk15:jar:$(bcmail.version} 2) maven-plugins:maven-cobertura-plugin:plugin:1.3 Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=maven-plugins -DartifactId=maven-cobertura-plugin -Dversion=1.3 -Dpackaging=plugin -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=maven-plugins -DartifactId=maven-cobertura-plugin -Dversion=1.3 -Dpackaging=plugin -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.jdom:jdom:jar:1.1.2 4) jaxen:jaxen:jar:1.1.3 5) maven-plugins:maven-cobertura-plugin:plugin:1.3 3) maven-plugins:maven-findbugs-plugin:plugin:1.3.1 Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=maven-plugins -DartifactId=maven-findbugs-plugin -Dversion=1.3.1 -Dpackaging=plugin -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=maven-plugins -DartifactId=maven-findbugs-plugin -Dversion=1.3.1 -Dpackaging=plugin -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.jdom:jdom:jar:1.1.2 4) jaxen:jaxen:jar:1.1.3 5) maven-plugins:maven-findbugs-plugin:plugin:1.3.1 4) org.apache.jmeter:ApacheJMeter_mail:jar:2.6-SNAPSHOT Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=org.apache.jmeter -DartifactId=ApacheJMeter_mail -Dversion=2.6-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=org.apache.jmeter -DartifactId=ApacheJMeter_mail -Dversion=2.6-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_mail:jar:2.6-SNAPSHOT -- 4 required artifacts are missing. for artifact: org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT from the specified remote repositories: central (http://repo1.maven.org/maven2), Java maven repo (https://repository.apache.org/content/repositories/snapshots/), Maven JMeter Repo (http://ardesco.github.com/jmeter-maven-plugin/repository) [INFO]
Re: Publishing to Maven Central
On 19 January 2012 15:04, Mark Collin m...@ardescosolutions.com wrote: Just tried the latest snapshot and everything looks good now. :) OK, thanks. Is the plan to push this up to the maven central repo when 2.6 final is released? Yes, that was the plan. -Original Message- From: sebb [mailto:seb...@gmail.com] Sent: 19 January 2012 10:59 To: dev@jmeter.apache.org Subject: Re: Publishing to Maven Central On 19 January 2012 09:13, Mark Collin m...@ardescosolutions.com wrote: Oh this has highlighted another difference between the implementation I supplied and your one, I have a POM named ApacheJMeter_reports and you have one named ApacheJMeter_report. If you do want to use the one I supplied you'll need to take the s off the name to make it match your current POM. I changed that so the pom matches the jar name, makes the Ant file simpler. -Original Message- From: Mark Collin [mailto:m...@ardescosolutions.com] Sent: 19 January 2012 09:09 To: dev@jmeter.apache.org Subject: RE: Publishing to Maven Central OK I have tried using the 2.6-SNAPSHOT at https://repository.apache.org/content/repositories/snapshots/ and I get the following dependency issues: [INFO] -- -- [ERROR] BUILD ERROR [INFO] -- -- [INFO] Failed to resolve artifact. Missing: -- 1) org.bouncycastle:bcmail-jdk15:jar:$(bcmail.version} Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=org.bouncycastle -DartifactId=bcmail-jdk15 -Dversion=$(bcmail.version} -Dpackaging=jar -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=org.bouncycastle -DartifactId=bcmail-jdk15 -Dversion=$(bcmail.version} -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.bouncycastle:bcmail-jdk15:jar:$(bcmail.version} 2) maven-plugins:maven-cobertura-plugin:plugin:1.3 Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=maven-plugins -DartifactId=maven-cobertura-plugin -Dversion=1.3 -Dpackaging=plugin -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=maven-plugins -DartifactId=maven-cobertura-plugin -Dversion=1.3 -Dpackaging=plugin -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.jdom:jdom:jar:1.1.2 4) jaxen:jaxen:jar:1.1.3 5) maven-plugins:maven-cobertura-plugin:plugin:1.3 3) maven-plugins:maven-findbugs-plugin:plugin:1.3.1 Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=maven-plugins -DartifactId=maven-findbugs-plugin -Dversion=1.3.1 -Dpackaging=plugin -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=maven-plugins -DartifactId=maven-findbugs-plugin -Dversion=1.3.1 -Dpackaging=plugin -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_core:jar:2.6-SNAPSHOT 3) org.jdom:jdom:jar:1.1.2 4) jaxen:jaxen:jar:1.1.3 5) maven-plugins:maven-findbugs-plugin:plugin:1.3.1 4) org.apache.jmeter:ApacheJMeter_mail:jar:2.6-SNAPSHOT Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=org.apache.jmeter -DartifactId=ApacheJMeter_mail -Dversion=2.6-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=org.apache.jmeter -DartifactId=ApacheJMeter_mail -Dversion=2.6-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT 2) org.apache.jmeter:ApacheJMeter_mail:jar:2.6-SNAPSHOT -- 4 required artifacts are missing. for artifact: org.apache.jmeter:maven-jmeter-plugin:maven-plugin:SNAPSHOT from the specified remote repositories: central (http://repo1.maven.org/maven2), Java maven repo (https://repository.apache.org/content/repositories/snapshots/), Maven JMeter
Re: Toolbar Polish
On 19 January 2012 16:36, Anthony Johnson ans...@gmail.com wrote: Hi Milamber, I will debug the Search button issues and file a bug if they still occur today(OSX 10.7.2/JDK 1.6.0_29) Since no work is occurring on this area, I will work on some of my improvements and submit via patches. For the icons, I can't help(no graphic skills:-(, but they are the focal point when the GUI is first launched and I don't think they give a good first impression to the user. Could we re-use icons from something like the Open Icon Library?(http://sourceforge.net/projects/openiconlibrary/) Depends on the license for the particular icons. Thanks, Anthony On Thu, Jan 19, 2012 at 2:44 AM, Milamber milam...@apache.org wrote: Hello, Le 19/01/2012 04:56, Anthony Johnson a ecrit : Hey Guys, I just built trunk for the first time in awhile and the on-by-default toolbar could use some work. -- icons are kinda 8-bit windowish Yes, icons comes from src/core/org/apache/jmeter/images, which are a old set of icons. If you have a new set of icons with better design/quality, we are interested. -- Reset Search doesn't work Works for me. (Debian 6 with JDK 5/6, Windows XP with JDK 6) -- Search button doesn't work again until Reset Search is called. Works too. -- Why do we have a close and a new? They seem to do the same thing? Yes same action. I think that have a New and Close allow a better user friendly for JMeter users (particular for new users). Theses icons are traditional in a toolbar and permit to new people to have some marks -- Some buttons/Actions could be simplified(merge Start/Stop icons) Yes, possibly. Is this feature still being worked or should I be opening bugs for these items? Currently, no works planned. Milamber Thanks, Anthony
Re: Toolbar Polish
On Thu, Jan 19, 2012 at 5:47 PM, sebb seb...@gmail.com wrote: On 19 January 2012 16:36, Anthony Johnson ans...@gmail.com wrote: Hi Milamber, I will debug the Search button issues and file a bug if they still occur today(OSX 10.7.2/JDK 1.6.0_29) Since no work is occurring on this area, I will work on some of my improvements and submit via patches. For the icons, I can't help(no graphic skills:-(, but they are the focal point when the GUI is first launched and I don't think they give a good first impression to the user. Could we re-use icons from something like the Open Icon Library?(http://sourceforge.net/projects/openiconlibrary/) Depends on the license for the particular icons. I think the icons set open_icon_library-CC can be used for changes toolbar icons. http://openiconlibrary.sourceforge.net/LICENSES.html open_icon_library-CC (Creative Commons and Public Domain only) List of licenses used in these packages: Creative Commons Attribution Creative Commons Attribution-Share Alike Public Domain In : http://www.apache.org/legal/resolved.html#category-a Creative Commons Attribution (CC-A) and : http://www.apache.org/legal/resolved.html#can_works_placed_in_the_public_domain_be_included_in_apache_products Works in the public domain (or covered by a license treated similarly) may be included within Apache products. Attribution is required (in a similar fashion to permissive licenses). Seb, can you confirm my reading? I will try to use some icons from open_icon_library-CC/icons/png/32x32/actions to improve toolbar icon Milamber Thanks, Anthony On Thu, Jan 19, 2012 at 2:44 AM, Milamber milam...@apache.org wrote: Hello, Le 19/01/2012 04:56, Anthony Johnson a ecrit : Hey Guys, I just built trunk for the first time in awhile and the on-by-default toolbar could use some work. -- icons are kinda 8-bit windowish Yes, icons comes from src/core/org/apache/jmeter/images, which are a old set of icons. If you have a new set of icons with better design/quality, we are interested. -- Reset Search doesn't work Works for me. (Debian 6 with JDK 5/6, Windows XP with JDK 6) -- Search button doesn't work again until Reset Search is called. Works too. -- Why do we have a close and a new? They seem to do the same thing? Yes same action. I think that have a New and Close allow a better user friendly for JMeter users (particular for new users). Theses icons are traditional in a toolbar and permit to new people to have some marks -- Some buttons/Actions could be simplified(merge Start/Stop icons) Yes, possibly. Is this feature still being worked or should I be opening bugs for these items? Currently, no works planned. Milamber Thanks, Anthony
Re: Toolbar Polish
On Thu, Jan 19, 2012 at 4:36 PM, Anthony Johnson ans...@gmail.com wrote: Hi Milamber, I will debug the Search button issues and file a bug if they still occur today(OSX 10.7.2/JDK 1.6.0_29) I don't have access to a similar platform. (Perhaps Philippe can help us?) Since no work is occurring on this area, I will work on some of my improvements and submit via patches. For the icons, I can't help(no graphic skills:-(, but they are the focal point when the GUI is first launched and I don't think they give a good first impression to the user. Could we re-use icons from something like the Open Icon Library?(http://sourceforge.net/projects/openiconlibrary/) Thanks for this link. I check the licenses compatibility with Apache License and I try to replace icons set in toolbar Milamber Thanks, Anthony On Thu, Jan 19, 2012 at 2:44 AM, Milamber milam...@apache.org wrote: Hello, Le 19/01/2012 04:56, Anthony Johnson a ecrit : Hey Guys, I just built trunk for the first time in awhile and the on-by-default toolbar could use some work. -- icons are kinda 8-bit windowish Yes, icons comes from src/core/org/apache/jmeter/images, which are a old set of icons. If you have a new set of icons with better design/quality, we are interested. -- Reset Search doesn't work Works for me. (Debian 6 with JDK 5/6, Windows XP with JDK 6) -- Search button doesn't work again until Reset Search is called. Works too. -- Why do we have a close and a new? They seem to do the same thing? Yes same action. I think that have a New and Close allow a better user friendly for JMeter users (particular for new users). Theses icons are traditional in a toolbar and permit to new people to have some marks -- Some buttons/Actions could be simplified(merge Start/Stop icons) Yes, possibly. Is this feature still being worked or should I be opening bugs for these items? Currently, no works planned. Milamber Thanks, Anthony
Re: Toolbar Polish
On 19 January 2012 17:54, Milamber milam...@apache.org wrote: On Thu, Jan 19, 2012 at 5:47 PM, sebb seb...@gmail.com wrote: On 19 January 2012 16:36, Anthony Johnson ans...@gmail.com wrote: Hi Milamber, I will debug the Search button issues and file a bug if they still occur today(OSX 10.7.2/JDK 1.6.0_29) Since no work is occurring on this area, I will work on some of my improvements and submit via patches. For the icons, I can't help(no graphic skills:-(, but they are the focal point when the GUI is first launched and I don't think they give a good first impression to the user. Could we re-use icons from something like the Open Icon Library?(http://sourceforge.net/projects/openiconlibrary/) Depends on the license for the particular icons. I think the icons set open_icon_library-CC can be used for changes toolbar icons. http://openiconlibrary.sourceforge.net/LICENSES.html open_icon_library-CC (Creative Commons and Public Domain only) List of licenses used in these packages: Creative Commons Attribution Creative Commons Attribution-Share Alike Public Domain In : http://www.apache.org/legal/resolved.html#category-a Creative Commons Attribution (CC-A) and : http://www.apache.org/legal/resolved.html#can_works_placed_in_the_public_domain_be_included_in_apache_products Works in the public domain (or covered by a license treated similarly) may be included within Apache products. Attribution is required (in a similar fashion to permissive licenses). Seb, can you confirm my reading? Yes, that set of licenses should be OK. I will try to use some icons from open_icon_library-CC/icons/png/32x32/actions to improve toolbar icon Milamber Thanks, Anthony On Thu, Jan 19, 2012 at 2:44 AM, Milamber milam...@apache.org wrote: Hello, Le 19/01/2012 04:56, Anthony Johnson a ecrit : Hey Guys, I just built trunk for the first time in awhile and the on-by-default toolbar could use some work. -- icons are kinda 8-bit windowish Yes, icons comes from src/core/org/apache/jmeter/images, which are a old set of icons. If you have a new set of icons with better design/quality, we are interested. -- Reset Search doesn't work Works for me. (Debian 6 with JDK 5/6, Windows XP with JDK 6) -- Search button doesn't work again until Reset Search is called. Works too. -- Why do we have a close and a new? They seem to do the same thing? Yes same action. I think that have a New and Close allow a better user friendly for JMeter users (particular for new users). Theses icons are traditional in a toolbar and permit to new people to have some marks -- Some buttons/Actions could be simplified(merge Start/Stop icons) Yes, possibly. Is this feature still being worked or should I be opening bugs for these items? Currently, no works planned. Milamber Thanks, Anthony
Re: Toolbar Polish
On Thu, Jan 19, 2012 at 6:10 PM, sebb seb...@gmail.com wrote: On 19 January 2012 17:54, Milamber milam...@apache.org wrote: On Thu, Jan 19, 2012 at 5:47 PM, sebb seb...@gmail.com wrote: On 19 January 2012 16:36, Anthony Johnson ans...@gmail.com wrote: Hi Milamber, I will debug the Search button issues and file a bug if they still occur today(OSX 10.7.2/JDK 1.6.0_29) Since no work is occurring on this area, I will work on some of my improvements and submit via patches. For the icons, I can't help(no graphic skills:-(, but they are the focal point when the GUI is first launched and I don't think they give a good first impression to the user. Could we re-use icons from something like the Open Icon Library?( http://sourceforge.net/projects/openiconlibrary/) Depends on the license for the particular icons. I think the icons set open_icon_library-CC can be used for changes toolbar icons. http://openiconlibrary.sourceforge.net/LICENSES.html open_icon_library-CC (Creative Commons and Public Domain only) List of licenses used in these packages: Creative Commons Attribution Creative Commons Attribution-Share Alike Public Domain In : http://www.apache.org/legal/resolved.html#category-a Creative Commons Attribution (CC-A) and : http://www.apache.org/legal/resolved.html#can_works_placed_in_the_public_domain_be_included_in_apache_products Works in the public domain (or covered by a license treated similarly) may be included within Apache products. Attribution is required (in a similar fashion to permissive licenses). Seb, can you confirm my reading? Yes, that set of licenses should be OK. Thanks. With this licenses, I think that I can modify a icon to create a new icon? (like add a broom on binoculars to symbolize clean search) Milamber I will try to use some icons from open_icon_library-CC/icons/png/32x32/actions to improve toolbar icon Milamber Thanks, Anthony On Thu, Jan 19, 2012 at 2:44 AM, Milamber milam...@apache.org wrote: Hello, Le 19/01/2012 04:56, Anthony Johnson a ecrit : Hey Guys, I just built trunk for the first time in awhile and the on-by-default toolbar could use some work. -- icons are kinda 8-bit windowish Yes, icons comes from src/core/org/apache/jmeter/images, which are a old set of icons. If you have a new set of icons with better design/quality, we are interested. -- Reset Search doesn't work Works for me. (Debian 6 with JDK 5/6, Windows XP with JDK 6) -- Search button doesn't work again until Reset Search is called. Works too. -- Why do we have a close and a new? They seem to do the same thing? Yes same action. I think that have a New and Close allow a better user friendly for JMeter users (particular for new users). Theses icons are traditional in a toolbar and permit to new people to have some marks -- Some buttons/Actions could be simplified(merge Start/Stop icons) Yes, possibly. Is this feature still being worked or should I be opening bugs for these items? Currently, no works planned. Milamber Thanks, Anthony
Re: Toolbar Polish
On 19 January 2012 18:28, Milamber milambersp...@gmail.com wrote: On Thu, Jan 19, 2012 at 6:10 PM, sebb seb...@gmail.com wrote: On 19 January 2012 17:54, Milamber milam...@apache.org wrote: On Thu, Jan 19, 2012 at 5:47 PM, sebb seb...@gmail.com wrote: On 19 January 2012 16:36, Anthony Johnson ans...@gmail.com wrote: Hi Milamber, I will debug the Search button issues and file a bug if they still occur today(OSX 10.7.2/JDK 1.6.0_29) Since no work is occurring on this area, I will work on some of my improvements and submit via patches. For the icons, I can't help(no graphic skills:-(, but they are the focal point when the GUI is first launched and I don't think they give a good first impression to the user. Could we re-use icons from something like the Open Icon Library?( http://sourceforge.net/projects/openiconlibrary/) Depends on the license for the particular icons. I think the icons set open_icon_library-CC can be used for changes toolbar icons. http://openiconlibrary.sourceforge.net/LICENSES.html open_icon_library-CC (Creative Commons and Public Domain only) List of licenses used in these packages: Creative Commons Attribution Creative Commons Attribution-Share Alike Public Domain In : http://www.apache.org/legal/resolved.html#category-a Creative Commons Attribution (CC-A) and : http://www.apache.org/legal/resolved.html#can_works_placed_in_the_public_domain_be_included_in_apache_products Works in the public domain (or covered by a license treated similarly) may be included within Apache products. Attribution is required (in a similar fashion to permissive licenses). Seb, can you confirm my reading? Yes, that set of licenses should be OK. Thanks. With this licenses, I think that I can modify a icon to create a new icon? (like add a broom on binoculars to symbolize clean search) Probably not: http://www.apache.org/legal/resolved.html#cc-sa Milamber I will try to use some icons from open_icon_library-CC/icons/png/32x32/actions to improve toolbar icon Milamber Thanks, Anthony On Thu, Jan 19, 2012 at 2:44 AM, Milamber milam...@apache.org wrote: Hello, Le 19/01/2012 04:56, Anthony Johnson a ecrit : Hey Guys, I just built trunk for the first time in awhile and the on-by-default toolbar could use some work. -- icons are kinda 8-bit windowish Yes, icons comes from src/core/org/apache/jmeter/images, which are a old set of icons. If you have a new set of icons with better design/quality, we are interested. -- Reset Search doesn't work Works for me. (Debian 6 with JDK 5/6, Windows XP with JDK 6) -- Search button doesn't work again until Reset Search is called. Works too. -- Why do we have a close and a new? They seem to do the same thing? Yes same action. I think that have a New and Close allow a better user friendly for JMeter users (particular for new users). Theses icons are traditional in a toolbar and permit to new people to have some marks -- Some buttons/Actions could be simplified(merge Start/Stop icons) Yes, possibly. Is this feature still being worked or should I be opening bugs for these items? Currently, no works planned. Milamber Thanks, Anthony
Re: Toolbar Polish
Perhaps we could modify the search box slightly to get rid of the need for the clear search results button? The following could be done: 1. Search box gets a Clear Results button. 2. On enter, Search box doesn't exit. 3. Clear Results button would be disabled until their are results to clear. This would also set us up for a possible future search enhancement to allow for previous/next buttons in the search box to shuffle through the search results interactively(instead of a simply highlight). Thoughts? Anthony On Thu, Jan 19, 2012 at 1:34 PM, sebb seb...@gmail.com wrote: On 19 January 2012 18:28, Milamber milambersp...@gmail.com wrote: On Thu, Jan 19, 2012 at 6:10 PM, sebb seb...@gmail.com wrote: On 19 January 2012 17:54, Milamber milam...@apache.org wrote: On Thu, Jan 19, 2012 at 5:47 PM, sebb seb...@gmail.com wrote: On 19 January 2012 16:36, Anthony Johnson ans...@gmail.com wrote: Hi Milamber, I will debug the Search button issues and file a bug if they still occur today(OSX 10.7.2/JDK 1.6.0_29) Since no work is occurring on this area, I will work on some of my improvements and submit via patches. For the icons, I can't help(no graphic skills:-(, but they are the focal point when the GUI is first launched and I don't think they give a good first impression to the user. Could we re-use icons from something like the Open Icon Library?( http://sourceforge.net/projects/openiconlibrary/) Depends on the license for the particular icons. I think the icons set open_icon_library-CC can be used for changes toolbar icons. http://openiconlibrary.sourceforge.net/LICENSES.html open_icon_library-CC (Creative Commons and Public Domain only) List of licenses used in these packages: Creative Commons Attribution Creative Commons Attribution-Share Alike Public Domain In : http://www.apache.org/legal/resolved.html#category-a Creative Commons Attribution (CC-A) and : http://www.apache.org/legal/resolved.html#can_works_placed_in_the_public_domain_be_included_in_apache_products Works in the public domain (or covered by a license treated similarly) may be included within Apache products. Attribution is required (in a similar fashion to permissive licenses). Seb, can you confirm my reading? Yes, that set of licenses should be OK. Thanks. With this licenses, I think that I can modify a icon to create a new icon? (like add a broom on binoculars to symbolize clean search) Probably not: http://www.apache.org/legal/resolved.html#cc-sa Milamber I will try to use some icons from open_icon_library-CC/icons/png/32x32/actions to improve toolbar icon Milamber Thanks, Anthony On Thu, Jan 19, 2012 at 2:44 AM, Milamber milam...@apache.org wrote: Hello, Le 19/01/2012 04:56, Anthony Johnson a ecrit : Hey Guys, I just built trunk for the first time in awhile and the on-by-default toolbar could use some work. -- icons are kinda 8-bit windowish Yes, icons comes from src/core/org/apache/jmeter/images, which are a old set of icons. If you have a new set of icons with better design/quality, we are interested. -- Reset Search doesn't work Works for me. (Debian 6 with JDK 5/6, Windows XP with JDK 6) -- Search button doesn't work again until Reset Search is called. Works too. -- Why do we have a close and a new? They seem to do the same thing? Yes same action. I think that have a New and Close allow a better user friendly for JMeter users (particular for new users). Theses icons are traditional in a toolbar and permit to new people to have some marks -- Some buttons/Actions could be simplified(merge Start/Stop icons) Yes, possibly. Is this feature still being worked or should I be opening bugs for these items? Currently, no works planned. Milamber Thanks, Anthony
Thoughts on adding Undo Functionality
Hey Guys, So, the user list shamed me into giving more time into adding the Undo feature to JMeter. I would appreciate some feedback if what I am thinking will work. I was first looking at the setProperty methods, but I found that it doesn't work well because those don't get called until you switch GUI Panels or Save the Test Plan. So, my thinking is to utilize an ActionListener for the TextFields, check boxes, etc so that I can be notified with the text has changed. I would use recursion to add this ActionListener inside one of the Abstract Gui classes's configure method to avoid touching all the TestElement Gui classes. From inside the ActionListener, I would capture the before and after value changes of the elements and update and Undo Manager. I was thinking to subclass UndoManager into a JMeterUndoManager and have it live/referenced from the GuiPackage class. Managing the TestPlan Tree for Adds and Deletes will be out of scope for my first patch. Does this sound workable? I don't think the extra recursion will hurt the Gui performance that much since the Gui classes are pretty small with a very specific scope. Thanks, Anthony
buildbot failure in ASF Buildbot on jmeter-trunk
The Buildbot has detected a new failure on builder jmeter-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/jmeter-trunk/builds/415 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: scheduler Build Source Stamp: [branch jmeter/trunk] 1233582 Blamelist: pmouawad BUILD FAILED: failed shell_3 sincerely, -The Buildbot
Re: Toolbar Polish
Hello, I am on Mac OSX 10.6.8 / JDK 1.6.0_29 I don't reproduce issue. Search button always work without calling reset. Same for reset. What is the exact scenario ? Thanks On Thu, Jan 19, 2012 at 9:05 PM, Anthony Johnson ans...@gmail.com wrote: Perhaps we could modify the search box slightly to get rid of the need for the clear search results button? The following could be done: 1. Search box gets a Clear Results button. 2. On enter, Search box doesn't exit. 3. Clear Results button would be disabled until their are results to clear. This would also set us up for a possible future search enhancement to allow for previous/next buttons in the search box to shuffle through the search results interactively(instead of a simply highlight). Thoughts? Anthony On Thu, Jan 19, 2012 at 1:34 PM, sebb seb...@gmail.com wrote: On 19 January 2012 18:28, Milamber milambersp...@gmail.com wrote: On Thu, Jan 19, 2012 at 6:10 PM, sebb seb...@gmail.com wrote: On 19 January 2012 17:54, Milamber milam...@apache.org wrote: On Thu, Jan 19, 2012 at 5:47 PM, sebb seb...@gmail.com wrote: On 19 January 2012 16:36, Anthony Johnson ans...@gmail.com wrote: Hi Milamber, I will debug the Search button issues and file a bug if they still occur today(OSX 10.7.2/JDK 1.6.0_29) Since no work is occurring on this area, I will work on some of my improvements and submit via patches. For the icons, I can't help(no graphic skills:-(, but they are the focal point when the GUI is first launched and I don't think they give a good first impression to the user. Could we re-use icons from something like the Open Icon Library?( http://sourceforge.net/projects/openiconlibrary/) Depends on the license for the particular icons. I think the icons set open_icon_library-CC can be used for changes toolbar icons. http://openiconlibrary.sourceforge.net/LICENSES.html open_icon_library-CC (Creative Commons and Public Domain only) List of licenses used in these packages: Creative Commons Attribution Creative Commons Attribution-Share Alike Public Domain In : http://www.apache.org/legal/resolved.html#category-a Creative Commons Attribution (CC-A) and : http://www.apache.org/legal/resolved.html#can_works_placed_in_the_public_domain_be_included_in_apache_products Works in the public domain (or covered by a license treated similarly) may be included within Apache products. Attribution is required (in a similar fashion to permissive licenses). Seb, can you confirm my reading? Yes, that set of licenses should be OK. Thanks. With this licenses, I think that I can modify a icon to create a new icon? (like add a broom on binoculars to symbolize clean search) Probably not: http://www.apache.org/legal/resolved.html#cc-sa Milamber I will try to use some icons from open_icon_library-CC/icons/png/32x32/actions to improve toolbar icon Milamber Thanks, Anthony On Thu, Jan 19, 2012 at 2:44 AM, Milamber milam...@apache.org wrote: Hello, Le 19/01/2012 04:56, Anthony Johnson a ecrit : Hey Guys, I just built trunk for the first time in awhile and the on-by-default toolbar could use some work. -- icons are kinda 8-bit windowish Yes, icons comes from src/core/org/apache/jmeter/images, which are a old set of icons. If you have a new set of icons with better design/quality, we are interested. -- Reset Search doesn't work Works for me. (Debian 6 with JDK 5/6, Windows XP with JDK 6) -- Search button doesn't work again until Reset Search is called. Works too. -- Why do we have a close and a new? They seem to do the same thing? Yes same action. I think that have a New and Close allow a better user friendly for JMeter users (particular for new users). Theses icons are traditional in a toolbar and permit to new people to have some marks -- Some buttons/Actions could be simplified(merge Start/Stop icons) Yes, possibly. Is this feature still being worked or should I be opening bugs for these items? Currently, no works planned. Milamber Thanks, Anthony -- Cordialement. Philippe Mouawad.
Build failed in Jenkins: JMeter-trunk #1923
See https://builds.apache.org/job/JMeter-trunk/1923/changes Changes: [pmouawad] Bug 52048 - BSFSampler, BSFPreProcessor and BSFPostProcessor should share the same GUI -- [...truncated 584 lines...] package-only: [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/bin/ApacheJMeter.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_core.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_components.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_functions.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_http.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_ftp.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_jdbc.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_java.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/bshclient.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_junit.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/junit/test.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_report.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_ldap.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_mail.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_tcp.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_monitors.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_jms.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/jorphan.jar package: check-anakia: report-old-velocity: report-anakia-missing: init-docs: [echo] eclipse.anakia = . docs-printable: [anakia] Transforming into: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs [anakia] Input: building.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/building.html [anakia] Input: changes.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/changes.html [anakia] Input: changes_history.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/changes_history.html [anakia] Input: download_jmeter.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/download_jmeter.html [anakia] Input: index.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/index.html [anakia] Input: issues.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/issues.html [anakia] Input: jmeter_irc.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/jmeter_irc.html [anakia] Input: localising/index.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/localising/index.html [anakia] Input: mail.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/mail.html [anakia] Input: mail2.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/mail2.html [anakia] Input: nightly.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/nightly.html [anakia] Input: svnindex.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/svnindex.html [anakia] Input: usermanual/best-practices.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/usermanual/best-practices.html [anakia] Input: usermanual/boss.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/usermanual/boss.html [anakia] Input: usermanual/build-adv-web-test-plan.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/usermanual/build-adv-web-test-plan.html [anakia] Input: usermanual/build-db-test-plan.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/usermanual/build-db-test-plan.html [anakia] Input: usermanual/build-ftp-test-plan.xml [anakia] Output:
buildbot success in ASF Buildbot on jmeter-trunk
The Buildbot has detected a restored build on builder jmeter-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/jmeter-trunk/builds/417 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: scheduler Build Source Stamp: [branch jmeter/trunk] 1233614 Blamelist: pmouawad Build succeeded! sincerely, -The Buildbot
RE: Toolbar Polish
Let me debug on my machine. Use-case: 1. Build trunk via ant 2. bash ./bin/jmeter.sh 3. Hit search button 4. Search for Test to get a result. 5. Hit clear search button. Expected Search results are cleared. On my machine, I have to use the menu item. I will debug it and report back. Sent from my Windows Phone From: Philippe Mouawad Sent: 1/19/2012 5:02 PM To: dev@jmeter.apache.org Subject: Re: Toolbar Polish Hello, I am on Mac OSX 10.6.8 / JDK 1.6.0_29 I don't reproduce issue. Search button always work without calling reset. Same for reset. What is the exact scenario ? Thanks On Thu, Jan 19, 2012 at 9:05 PM, Anthony Johnson ans...@gmail.com wrote: Perhaps we could modify the search box slightly to get rid of the need for the clear search results button? The following could be done: 1. Search box gets a Clear Results button. 2. On enter, Search box doesn't exit. 3. Clear Results button would be disabled until their are results to clear. This would also set us up for a possible future search enhancement to allow for previous/next buttons in the search box to shuffle through the search results interactively(instead of a simply highlight). Thoughts? Anthony On Thu, Jan 19, 2012 at 1:34 PM, sebb seb...@gmail.com wrote: On 19 January 2012 18:28, Milamber milambersp...@gmail.com wrote: On Thu, Jan 19, 2012 at 6:10 PM, sebb seb...@gmail.com wrote: On 19 January 2012 17:54, Milamber milam...@apache.org wrote: On Thu, Jan 19, 2012 at 5:47 PM, sebb seb...@gmail.com wrote: On 19 January 2012 16:36, Anthony Johnson ans...@gmail.com wrote: Hi Milamber, I will debug the Search button issues and file a bug if they still occur today(OSX 10.7.2/JDK 1.6.0_29) Since no work is occurring on this area, I will work on some of my improvements and submit via patches. For the icons, I can't help(no graphic skills:-(, but they are the focal point when the GUI is first launched and I don't think they give a good first impression to the user. Could we re-use icons from something like the Open Icon Library?( http://sourceforge.net/projects/openiconlibrary/) Depends on the license for the particular icons. I think the icons set open_icon_library-CC can be used for changes toolbar icons. http://openiconlibrary.sourceforge.net/LICENSES.html open_icon_library-CC (Creative Commons and Public Domain only) List of licenses used in these packages: Creative Commons Attribution Creative Commons Attribution-Share Alike Public Domain In : http://www.apache.org/legal/resolved.html#category-a Creative Commons Attribution (CC-A) and : http://www.apache.org/legal/resolved.html#can_works_placed_in_the_public_domain_be_included_in_apache_products Works in the public domain (or covered by a license treated similarly) may be included within Apache products. Attribution is required (in a similar fashion to permissive licenses). Seb, can you confirm my reading? Yes, that set of licenses should be OK. Thanks. With this licenses, I think that I can modify a icon to create a new icon? (like add a broom on binoculars to symbolize clean search) Probably not: http://www.apache.org/legal/resolved.html#cc-sa Milamber I will try to use some icons from open_icon_library-CC/icons/png/32x32/actions to improve toolbar icon Milamber Thanks, Anthony On Thu, Jan 19, 2012 at 2:44 AM, Milamber milam...@apache.org wrote: Hello, Le 19/01/2012 04:56, Anthony Johnson a ecrit : Hey Guys, I just built trunk for the first time in awhile and the on-by-default toolbar could use some work. -- icons are kinda 8-bit windowish Yes, icons comes from src/core/org/apache/jmeter/images, which are a old set of icons. If you have a new set of icons with better design/quality, we are interested. -- Reset Search doesn't work Works for me. (Debian 6 with JDK 5/6, Windows XP with JDK 6) -- Search button doesn't work again until Reset Search is called. Works too. -- Why do we have a close and a new? They seem to do the same thing? Yes same action. I think that have a New and Close allow a better user friendly for JMeter users (particular for new users). Theses icons are traditional in a toolbar and permit to new people to have some marks -- Some buttons/Actions could be simplified(merge Start/Stop icons) Yes, possibly. Is this feature still being worked or should I be opening bugs for these items?
Re: Toolbar Polish
Looks great:-) On Thu, Jan 19, 2012 at 6:08 PM, Milamber milam...@apache.org wrote: Le 19/01/2012 17:59, Milamber a ecrit : On Thu, Jan 19, 2012 at 4:36 PM, Anthony Johnson ans...@gmail.com mailto:ans...@gmail.com wrote: Hi Milamber, I will debug the Search button issues and file a bug if they still occur today(OSX 10.7.2/JDK 1.6.0_29) I don't have access to a similar platform. (Perhaps Philippe can help us?) Since no work is occurring on this area, I will work on some of my improvements and submit via patches. For the icons, I can't help(no graphic skills:-(, but they are the focal point when the GUI is first launched and I don't think they give a good first impression to the user. Could we re-use icons from something like the Open Icon Library?(http://sourceforge.net/projects/openiconlibrary/) Thanks for this link. I check the licenses compatibility with Apache License and I try to replace icons set in toolbar Done. https://issues.apache.org/bugzilla/show_bug.cgi?id=52040 Screenshot: https://issues.apache.org/bugzilla/attachment.cgi?id=28179 Thanks. Milamber Milamber Thanks, Anthony On Thu, Jan 19, 2012 at 2:44 AM, Milamber milam...@apache.org mailto:milam...@apache.org wrote: Hello, Le 19/01/2012 04:56, Anthony Johnson a ecrit : Hey Guys, I just built trunk for the first time in awhile and the on-by-default toolbar could use some work. -- icons are kinda 8-bit windowish Yes, icons comes from src/core/org/apache/jmeter/images, which are a old set of icons. If you have a new set of icons with better design/quality, we are interested. -- Reset Search doesn't work Works for me. (Debian 6 with JDK 5/6, Windows XP with JDK 6) -- Search button doesn't work again until Reset Search is called. Works too. -- Why do we have a close and a new? They seem to do the same thing? Yes same action. I think that have a New and Close allow a better user friendly for JMeter users (particular for new users). Theses icons are traditional in a toolbar and permit to new people to have some marks -- Some buttons/Actions could be simplified(merge Start/Stop icons) Yes, possibly. Is this feature still being worked or should I be opening bugs for these items? Currently, no works planned. Milamber Thanks, Anthony
Re: svn commit: r1233638 - in /jmeter/trunk: docs/images/screenshots/changes/ src/core/org/apache/jmeter/images/toolbar/ xdocs/ xdocs/images/screenshots/changes/
On 19 January 2012 23:02, milam...@apache.org wrote: Author: milamber Date: Thu Jan 19 23:02:37 2012 New Revision: 1233638 URL: http://svn.apache.org/viewvc?rev=1233638view=rev Log: Improve toolbar icons set with some icons from open_icon_library-CC (http://openiconlibrary.sourceforge.net/) I think the icons may require an entry in the LICENSE and NOTICE files. Where exactly did you get the files from? Also, were any of them modified?
Re: svn commit: r1233614 - /jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java
On 19 January 2012 22:38, pmoua...@apache.org wrote: Author: pmouawad Date: Thu Jan 19 22:38:44 2012 New Revision: 1233614 URL: http://svn.apache.org/viewvc?rev=1233614view=rev Log: Commenting test to avoid failure. TestLoadAndSave seems wrong as it does not take into account migration. -1 I don't think that's the correct fix. It would be better to update the test file to the new settings. Otherwise, other (incorrect) changes to JMeter might be missed. Modified: jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java Modified: jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java URL: http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java?rev=1233614r1=1233613r2=1233614view=diff == --- jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java (original) +++ jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java Thu Jan 19 22:38:44 2012 @@ -43,7 +43,7 @@ public class TestSaveService extends JMe ProxyServerTestPlan.jmx, SimpleTestPlan.jmx, GuiTest.jmx, - GuiTest231.jmx, + //GuiTest231.jmx, Commenting as testLoadAndSave will fails }; private static final boolean saveOut = JMeterUtils.getPropDefault(testsaveservice.saveout, false);
Build failed in Jenkins: JMeter-trunk #1926
See https://builds.apache.org/job/JMeter-trunk/1926/changes Changes: [sebb] Increase ramp-up slightly to avoid occasional thread overlap in testing -- [...truncated 565 lines...] [javac] Compiling 61 source files to /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/build/reports [javac] Note: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/src/reports/org/apache/jmeter/testelement/JTLData.java uses unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. compile: prepare-resources: [copy] Copying 2 files to /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/build/res/META-INF package-only: [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/bin/ApacheJMeter.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_core.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_components.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_functions.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_http.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_ftp.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_jdbc.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_java.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/bshclient.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_junit.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/junit/test.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_report.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_ldap.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_mail.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_tcp.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_monitors.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/ext/ApacheJMeter_jms.jar [jar] Building jar: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/lib/jorphan.jar package: check-anakia: report-old-velocity: report-anakia-missing: init-docs: [echo] eclipse.anakia = . docs-printable: [anakia] Transforming into: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs [anakia] Input: building.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/building.html [anakia] Input: changes.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/changes.html [anakia] Input: changes_history.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/changes_history.html [anakia] Input: download_jmeter.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/download_jmeter.html [anakia] Input: index.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/index.html [anakia] Input: issues.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/issues.html [anakia] Input: jmeter_irc.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/jmeter_irc.html [anakia] Input: localising/index.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/localising/index.html [anakia] Input: mail.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/mail.html [anakia] Input: mail2.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/mail2.html [anakia] Input: nightly.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/nightly.html [anakia] Input: svnindex.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/svnindex.html [anakia] Input: usermanual/best-practices.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/usermanual/best-practices.html [anakia] Input: usermanual/boss.xml [anakia] Output: /x1/jenkins/jenkins-slave/workspace/JMeter-trunk/trunk/printable_docs/usermanual/boss.html [anakia] Input: usermanual/build-adv-web-test-plan.xml
Re: svn commit: r1233614 - /jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java
Hello, I don't agree. Tests on loadAndSave seems wrong to me as it does not take into account upgrade procedure . Furthermore I don't understand the purpose of TestGUI23.jmx, from what I supposed it was to test 2.3 format but If I upgrade the format what's the use of the Test case ? Regards Philippe On Fri, Jan 20, 2012 at 1:35 AM, sebb seb...@gmail.com wrote: On 19 January 2012 22:38, pmoua...@apache.org wrote: Author: pmouawad Date: Thu Jan 19 22:38:44 2012 New Revision: 1233614 URL: http://svn.apache.org/viewvc?rev=1233614view=rev Log: Commenting test to avoid failure. TestLoadAndSave seems wrong as it does not take into account migration. -1 I don't think that's the correct fix. It would be better to update the test file to the new settings. Otherwise, other (incorrect) changes to JMeter might be missed. Modified: jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java Modified: jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java URL: http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java?rev=1233614r1=1233613r2=1233614view=diff == --- jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java (original) +++ jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java Thu Jan 19 22:38:44 2012 @@ -43,7 +43,7 @@ public class TestSaveService extends JMe ProxyServerTestPlan.jmx, SimpleTestPlan.jmx, GuiTest.jmx, -GuiTest231.jmx, +//GuiTest231.jmx, Commenting as testLoadAndSave will fails }; private static final boolean saveOut = JMeterUtils.getPropDefault(testsaveservice.saveout, false); -- Cordialement. Philippe Mouawad.
