Re: svn commit: r1233711 - in /jmeter/trunk: bin/saveservice.properties src/core/org/apache/jmeter/save/SaveService.java

2012-01-20 Thread sebb 
On 20 January 2012 06:24, Philippe Mouawad philippe.moua...@gmail.com wrote:
 In my underdstanding, entry should be deleted to avoir
 ClassNotFoundException (as currently tests are failing).

If that were the case, then all the other missing entries would need
to be deleted too.

 In my understanding, if I provide and upgrade then I can remove entry.

No.

 Maybe this part should be documented in a WIKI page.

It's already documented in the file itself that entries should not be removed.

 Regards
 Philippe


 On Fri, Jan 20, 2012 at 2:51 AM, s...@apache.org wrote:

 Author: sebb
 Date: Fri Jan 20 01:51:51 2012
 New Revision: 1233711

 URL: http://svn.apache.org/viewvc?rev=1233711view=rev
 Log:
 Revert deletion in r1233606; entries should never be deleted
 Also update property file version

 Modified:
    jmeter/trunk/bin/saveservice.properties
    jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java

 Modified: jmeter/trunk/bin/saveservice.properties
 URL:
 http://svn.apache.org/viewvc/jmeter/trunk/bin/saveservice.properties?rev=1233711r1=1233710r2=1233711view=diff

 ==
 --- jmeter/trunk/bin/saveservice.properties (original)
 +++ jmeter/trunk/bin/saveservice.properties Fri Jan 20 01:51:51 2012
 @@ -18,8 +18,9 @@
  ##   limitations under the License.

  #-
 -# N.B. To ensure backward compatibility, please do not
 -# change or delete any entries that have been used.
 +
 +# N.B. To ensure backward compatibility, please do NOT change or delete
 any entries
 +
  # New entries can be added as necessary.
  #
  # Note that keys starting with an underscore are special,
 @@ -39,8 +40,10 @@ _file_version=$Revision$
  # (Some version updates were missed here...)
  # 2.0 = 2.3.1
  # 2.1 = 2.3.2
 +# (Some version updates were missed here...)
 +# 2.2 = 2.6
  #
 -_version=2.1
 +_version=2.2
  #
  #
  # Character set encoding used to read and write JMeter XML files
 @@ -80,6 +83,7 @@ BSFListener=org.apache.jmeter.visualizer
  BSFPreProcessor=org.apache.jmeter.modifiers.BSFPreProcessor
  BSFPostProcessor=org.apache.jmeter.extractor.BSFPostProcessor
  BSFSampler=org.apache.jmeter.protocol.java.sampler.BSFSampler
 +BSFSamplerGui=org.apache.jmeter.protocol.java.control.gui.BSFSamplerGui
  BSFTimer=org.apache.jmeter.timers.BSFTimer
  CacheManager=org.apache.jmeter.protocol.http.control.CacheManager
  CacheManagerGui=org.apache.jmeter.protocol.http.gui.CacheManagerGui

 Modified: jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java
 URL:
 http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java?rev=1233711r1=1233710r2=1233711view=diff

 ==
 --- jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java
 (original)
 +++ jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java Fri Jan
 20 01:51:51 2012
 @@ -162,7 +162,7 @@ public class SaveService {

     // This is written to JMX files by ScriptWrapperConverter
     private static String propertiesVersion = ;// read from properties
 file; written to JMX files
 -    private static final String PROPVERSION = 2.1;// Expected version
 $NON-NLS-1$
 +    private static final String PROPVERSION = 2.2;// Expected version
 $NON-NLS-1$

     // Internal information only
     private static String fileVersion = ; // read from properties file//
 $NON-NLS-1$





 --
 Cordialement.
 Philippe Mouawad.

Re: svn commit: r1233614 - /jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java

2012-01-20 Thread sebb 
On 20 January 2012 06:25, Philippe Mouawad philippe.moua...@gmail.com wrote:
 Hello,
 I don't agree.
 Tests on loadAndSave seems wrong to me as it does not take into account
 upgrade procedure .
 Furthermore I don't understand the purpose of TestGUI23.jmx, from what I
 supposed it was to test 2.3 format but
 If I upgrade the format what's the use of the Test case ?

As I already wrote, at least it checks the other test elements.

Maybe there needs to be another test which specifically checks
upgrades, but I don't think the test is useless.
If there is another such test, then elements could be moved to it when
they are upgraded.

 Regards
 Philippe

 On Fri, Jan 20, 2012 at 1:35 AM, sebb seb...@gmail.com wrote:

 On 19 January 2012 22:38,  pmoua...@apache.org wrote:
  Author: pmouawad
  Date: Thu Jan 19 22:38:44 2012
  New Revision: 1233614
 
  URL: http://svn.apache.org/viewvc?rev=1233614view=rev
  Log:
  Commenting test to avoid failure.
  TestLoadAndSave seems wrong as it does not take into account migration.

 -1

 I don't think that's the correct fix.
 It would be better to update the test file to the new settings.
 Otherwise, other (incorrect) changes to JMeter might be missed.

  Modified:
     jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java
 
  Modified:
 jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java
  URL:
 http://svn.apache.org/viewvc/jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java?rev=1233614r1=1233613r2=1233614view=diff
 
 ==
  --- jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java
 (original)
  +++ jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java
 Thu Jan 19 22:38:44 2012
  @@ -43,7 +43,7 @@ public class TestSaveService extends JMe
          ProxyServerTestPlan.jmx,
          SimpleTestPlan.jmx,
          GuiTest.jmx,
  -        GuiTest231.jmx,
  +        //GuiTest231.jmx, Commenting as testLoadAndSave will fails
          };
 
      private static final boolean saveOut =
 JMeterUtils.getPropDefault(testsaveservice.saveout, false);
 
 




 --
 Cordialement.
 Philippe Mouawad.

Re: svn commit: r1233711 - in /jmeter/trunk: bin/saveservice.properties src/core/org/apache/jmeter/save/SaveService.java

2012-01-20 Thread sebb 
On 20 January 2012 11:43, sebb seb...@gmail.com wrote:
 On 20 January 2012 06:24, Philippe Mouawad philippe.moua...@gmail.com wrote:
 In my underdstanding, entry should be deleted to avoir
 ClassNotFoundException (as currently tests are failing).

 If that were the case, then all the other missing entries would need
 to be deleted too.

The problem is due to running headless:

2012/01/20 03:04:37 WARN  - jmeter.gui.action.ActionRouter:
java.awt.HeadlessException
2012/01/20 03:04:37 ERROR - jorphan.test.AllTests: error adding test :
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:592)
at org.apache.jorphan.test.AllTests.suite(AllTests.java:353)
at org.apache.jorphan.test.AllTests.main(AllTests.java:210)
Caused by: java.lang.ExceptionInInitializerError
at 
org.apache.jmeter.gui.util.JMeterMenuBar.makeFileMenu(JMeterMenuBar.java:440)
at 
org.apache.jmeter.gui.util.JMeterMenuBar.createMenuBar(JMeterMenuBar.java:230)
at 
org.apache.jmeter.gui.util.JMeterMenuBar.init(JMeterMenuBar.java:152)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
at java.lang.reflect.Constructor.newInstance(Constructor.java:501)
at java.lang.Class.newInstance0(Class.java:350)
at java.lang.Class.newInstance(Class.java:303)
at org.apache.jmeter.junit.JMeterTest.getObjects(JMeterTest.java:576)
at 
org.apache.jmeter.junit.JMeterTest.suiteSerializableElements(JMeterTest.java:475)
at org.apache.jmeter.junit.JMeterTest.suite(JMeterTest.java:142)
... 6 more
Caused by: java.awt.HeadlessException
at 
sun.awt.HeadlessToolkit.getMenuShortcutKeyMask(HeadlessToolkit.java:199)
at org.apache.jmeter.gui.action.KeyStrokes.clinit(KeyStrokes.java:36)
... 18 more

I'm not sure exactly what triggered the change in headless behaviour,
but it's nothing to do with updgrade.properties.

The tests work fine for me locally.
Don't they work for you?

 In my understanding, if I provide and upgrade then I can remove entry.

 No.

 Maybe this part should be documented in a WIKI page.

 It's already documented in the file itself that entries should not be removed.

 Regards
 Philippe


 On Fri, Jan 20, 2012 at 2:51 AM, s...@apache.org wrote:

 Author: sebb
 Date: Fri Jan 20 01:51:51 2012
 New Revision: 1233711

 URL: http://svn.apache.org/viewvc?rev=1233711view=rev
 Log:
 Revert deletion in r1233606; entries should never be deleted
 Also update property file version

 Modified:
    jmeter/trunk/bin/saveservice.properties
    jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java

 Modified: jmeter/trunk/bin/saveservice.properties
 URL:
 http://svn.apache.org/viewvc/jmeter/trunk/bin/saveservice.properties?rev=1233711r1=1233710r2=1233711view=diff

 ==
 --- jmeter/trunk/bin/saveservice.properties (original)
 +++ jmeter/trunk/bin/saveservice.properties Fri Jan 20 01:51:51 2012
 @@ -18,8 +18,9 @@
  ##   limitations under the License.

  #-
 -# N.B. To ensure backward compatibility, please do not
 -# change or delete any entries that have been used.
 +
 +# N.B. To ensure backward compatibility, please do NOT change or delete
 any entries
 +
  # New entries can be added as necessary.
  #
  # Note that keys starting with an underscore are special,
 @@ -39,8 +40,10 @@ _file_version=$Revision$
  # (Some version updates were missed here...)
  # 2.0 = 2.3.1
  # 2.1 = 2.3.2
 +# (Some version updates were missed here...)
 +# 2.2 = 2.6
  #
 -_version=2.1
 +_version=2.2
  #
  #
  # Character set encoding used to read and write JMeter XML files
 @@ -80,6 +83,7 @@ BSFListener=org.apache.jmeter.visualizer
  BSFPreProcessor=org.apache.jmeter.modifiers.BSFPreProcessor
  BSFPostProcessor=org.apache.jmeter.extractor.BSFPostProcessor
  BSFSampler=org.apache.jmeter.protocol.java.sampler.BSFSampler
 +BSFSamplerGui=org.apache.jmeter.protocol.java.control.gui.BSFSamplerGui
  BSFTimer=org.apache.jmeter.timers.BSFTimer
  CacheManager=org.apache.jmeter.protocol.http.control.CacheManager
  CacheManagerGui=org.apache.jmeter.protocol.http.gui.CacheManagerGui

 Modified: jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java
 URL:
 http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java?rev=1233711r1=1233710r2=1233711view=diff

buildbot success in ASF Buildbot on jmeter-trunk

2012-01-20 Thread buildbot 
The Buildbot has detected a restored build on builder jmeter-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/jmeter-trunk/builds/426

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: hemera_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch jmeter/trunk] 1233886
Blamelist: sebb

Build succeeded!

sincerely,
 -The Buildbot

Re: JMeter at Google

2012-01-20 Thread Havard Blok 
On 9 January 2012 20:46, sebb seb...@gmail.com wrote:

 Thanks! I saw a video of a presentation on JMeter recently; IIRC that
 was about JMeter use at Google.


Interesting, do you still have a link?

The only one I'm aware of is the rather old talk by Goranka Bjedov:
http://www.youtube.com/watch?v=k9h51BM2h4w

Then you of course have the Let's make the web faster initiative, however
AFAIK JMeter is not used there.
http://code.google.com/speed/index.html


 It would also be interesting to know if and where you need a helping hand.

Patches, unit tests, bug reports etc are always useful.
 Test cases and documentation especially.


I've been working on all aspects of testing (JUnit, TestNG, EasyMock,
JMock, etc.) the last couple of years, so I'd be happy to pick up things
there. Are there any particular itches to take care of right now?


Also, I wanted to ask: Do you have any meet-ups planned? Conferences, etc?
Are any of you going to ApacheCon; I guess there's one in the autumn?

As my signature suggests, I'm based in Zurich, Switzerland, but travel
frequently. In fact, I'll be in Mountain View, San Francisco the two first
weeks of February. If anybody are sitting next door, it would be great to
say hello.

Regards,
Havard

-- 
---Google Switzerland GmbH Identifikationsnummer: CH-020.4.028.116-1

runTest: synchronous vs. asynchronous

2012-01-20 Thread Havard Blok 
A common use case of JMeter within Google is to implement a custom sampler,
sub-classed from AbstractJavaSamplerClient, and handle the requests
relevant to the load test in the runTest() method (from JavaSamplerClient).
Typically, RPC requests over Protocol Buffers (
http://en.wikipedia.org/wiki/Protocol_Buffers) are constructed within
runTest(), executed, and the latency measurements stored in SampleResult.
The custom sampler is included in an auto-generated test plan, which
includes a few externalized options like thread count, duration, etc.

From JMeter's perspective, the call to runTest() is blocking, so to
generate higher load, we'll increase the thread count. So far, all good.
Until somebody asks for a specific QPS. In this case, we've used the
ConstantThroughputTimer, which delays threads to achieve an overall max
throughput. However, it might be that requests to the System Under Tests
hang or experience high latency, which means that the desired QPS will not
be reached. So you'll have to add more threads to achieve a constant QPS.

This leads to the frequently asked question: Well, since all these threads
are just waiting for a server response anyway, why can't the runTest() be
asynchronous? The load generation machine itself is not busy, it's just
sitting there waiting for replies from the System Under Test.

I was hoping some of you might shed some light on this, and possibly point
to related discussions or design decisions. Or maybe we've used the wrong
JMeter configuration. It would be great to have some definite answers when
this comes up.

Regards,
Havard

-- 
---Google Switzerland GmbH Identifikationsnummer: CH-020.4.028.116-1

Re: Toolbar Polish

2012-01-20 Thread Philippe Mouawad 
Yes , Beautiful !!!
Thanks Milamber

On Fri, Jan 20, 2012 at 1:12 AM, Anthony Johnson ans...@gmail.com wrote:

 Looks great:-)

 On Thu, Jan 19, 2012 at 6:08 PM, Milamber milam...@apache.org wrote:

 
 
  Le 19/01/2012 17:59, Milamber a ecrit :
  
  
   On Thu, Jan 19, 2012 at 4:36 PM, Anthony Johnson ans...@gmail.com
   mailto:ans...@gmail.com wrote:
  
   Hi Milamber,
 I will debug the Search button issues and file a bug if they
   still occur
   today(OSX 10.7.2/JDK 1.6.0_29)
  
  
  
   I don't have access to a similar platform. (Perhaps Philippe can help
  us?)
  
  
  
  
   Since no work is occurring on this area, I will work on some of my
   improvements and submit via patches.
  
   For the icons, I can't help(no graphic skills:-(, but they are the
   focal
   point when the GUI is first launched and I don't think they give a
   good
   first impression to the user.  Could we re-use icons from
   something like
   the Open Icon
   Library?(http://sourceforge.net/projects/openiconlibrary/)
  
  
  
   Thanks for this link. I check the licenses compatibility with Apache
   License and I try to replace icons set in toolbar
 
  Done.
 
  https://issues.apache.org/bugzilla/show_bug.cgi?id=52040
 
  Screenshot:
  https://issues.apache.org/bugzilla/attachment.cgi?id=28179
 
  Thanks.
 
  Milamber
 
 
 
 
  
   Milamber
  
  
   Thanks,
  
   Anthony
  
   On Thu, Jan 19, 2012 at 2:44 AM, Milamber milam...@apache.org
   mailto:milam...@apache.org wrote:
  
Hello,
   
Le 19/01/2012 04:56, Anthony Johnson a ecrit :
 Hey Guys,
 I just built trunk for the first time in awhile and the
   on-by-default
 toolbar could use some work.

 -- icons are kinda 8-bit windowish

   
Yes, icons comes from src/core/org/apache/jmeter/images, which
   are a old
set of icons.
If you have a new set of icons with better design/quality, we are
interested.
   
 -- Reset Search doesn't work

Works for me.
(Debian 6 with JDK 5/6, Windows XP with JDK 6)
   
 -- Search button doesn't work again until Reset Search is
 called.

   
Works too.
   
 -- Why do we have a close and a new?  They seem to do the same
   thing?

   
Yes same action. I think that have a New and Close allow a
   better user
friendly for JMeter users (particular for new users). Theses
   icons are
traditional in a toolbar and permit to new people to have some
   marks
   
 -- Some buttons/Actions could be simplified(merge Start/Stop
   icons)

   
Yes, possibly.
   
 Is this feature still being worked or should I be opening bugs
   for these
 items?

   
Currently, no works planned.
   
Milamber
   
 Thanks,

 Anthony


   
   
  
  
 
 




-- 
Cordialement.
Philippe Mouawad.

Re: svn commit: r1233097 - in /jmeter/trunk: docs/images/screenshots/changes/ xdocs/ xdocs/images/screenshots/changes/

2012-01-20 Thread Philippe Mouawad 
Hello Milamber,
you can find screenshots in:

   - jmssubscriber.png
   -

Hello Milamber,

   - I did screenshot for JMS.
   - I let you do gedit screenshot for ignore failed for embedded
   resources as I don't have this software on my machine.

Thank you
Regards
Philippe

On Thu, Jan 19, 2012 at 2:13 PM, Milamber milam...@apache.org wrote:

 On Thu, Jan 19, 2012 at 12:20 PM, Philippe Mouawad 
 philippe.moua...@gmail.com wrote:

  Hello,
  Regarding New and noteworthy, should'nt we also have:
 
- JMS improvements (51419 and 52088)
- And ignore failed for embedded resources (like Remote Batching
support)
 
  Milamber, I can add them if you tell me which software you use for your
  highlights ?
 


 I use : Shutter for screen-shots and annotation (
 http://shutter-project.org/)
 (Debian packages)
 And The GIMP for add a black border (2pix)

 I can make the resizing and integrating in changes.xml if you send me the
 full screenshots.

 Milamber



  Thanks.
  Regards
  Philippe
  On Thu, Jan 19, 2012 at 7:36 AM, Philippe Mouawad 
  philippe.moua...@gmail.com wrote:
 
   Yes, very good indeed !
   Thanks
  
  
   On Thu, Jan 19, 2012 at 2:47 AM, sebb seb...@gmail.com wrote:
  
   On 18 January 2012 22:29,  milam...@apache.org wrote:
Author: milamber
Date: Wed Jan 18 22:29:54 2012
New Revision: 1233097
   
URL: http://svn.apache.org/viewvc?rev=1233097view=rev
Log:
Add New and Noteworthy for next version (2.6)
  
   Looks very good, thanks!
  
  
  
  
   --
   Cordialement.
   Philippe Mouawad.
  
  
  
  
 
 
  --
  Cordialement.
  Philippe Mouawad.
 




-- 
Cordialement.
Philippe Mouawad.

Re: svn commit: r1234186 - /jmeter/trunk/xdocs/stylesheets/project.xml

2012-01-20 Thread Philippe Mouawad 
Hello Sebb, Milamber,Rainer,
I added 2 links at root of index to Component Reference and Functions
Reference.

This is a proposition, I personnaly always search for these for a while
before finding them , and in my opinion they are very useful .

But you can rollback if you think I am wrong.
Regards
Philippe

On Fri, Jan 20, 2012 at 11:20 PM, pmoua...@apache.org wrote:

 Author: pmouawad
 Date: Fri Jan 20 22:20:30 2012
 New Revision: 1234186

 URL: http://svn.apache.org/viewvc?rev=1234186view=rev
 Log:
 Added Component Reference and Functions reference at root of documentation

 Modified:
jmeter/trunk/xdocs/stylesheets/project.xml

 Modified: jmeter/trunk/xdocs/stylesheets/project.xml
 URL:
 http://svn.apache.org/viewvc/jmeter/trunk/xdocs/stylesheets/project.xml?rev=1234186r1=1234185r2=1234186view=diff

 ==
 --- jmeter/trunk/xdocs/stylesheets/project.xml (original)
 +++ jmeter/trunk/xdocs/stylesheets/project.xml Fri Jan 20 22:20:30 2012
 @@ -36,6 +36,8 @@
 /menu
 menu name=Documentation
item name=User Manual
 href=/usermanual/index.html/
 +item name=Component Reference
 href=/usermanual/component_reference.html/
 +item name=Functions Reference
 href=/usermanual/functions.html/
item name=Javadocs
  href=/api/index.html/
 item name=Localisation (Translator's Guide)
 href=/localising/index.html/item
item name=Building JMeter and Add-Ons
 href=/building.html/

Re: svn commit: r1234210 - in /jmeter/trunk: docs/localising/index.html xdocs/changes.xml xdocs/images/screenshots/changes/25_selector.png

2012-01-20 Thread sebb 
On 20 January 2012 23:50,  milam...@apache.org wrote:
 Author: milamber
 Date: Fri Jan 20 23:50:30 2012
 New Revision: 1234210

 URL: http://svn.apache.org/viewvc?rev=1234210view=rev
 Log:
 Add changes.xml: JMS improvements nuf 51419

 Modified:
    jmeter/trunk/docs/localising/index.html

The above looks like an accidental commit, though it does not matter
in this case.
Site docs will be sorted out later.

    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/images/screenshots/changes/25_selector.png

Re: svn commit: r1234210 - in /jmeter/trunk: docs/localising/index.html xdocs/changes.xml xdocs/images/screenshots/changes/25_selector.png

2012-01-20 Thread Milamber 


Le 21/01/2012 01:24, sebb a ecrit :
 On 20 January 2012 23:50,  milam...@apache.org wrote:
   
 Author: milamber
 Date: Fri Jan 20 23:50:30 2012
 New Revision: 1234210

 URL: http://svn.apache.org/viewvc?rev=1234210view=rev
 Log:
 Add changes.xml: JMS improvements nuf 51419

 Modified:
jmeter/trunk/docs/localising/index.html
 
 The above looks like an accidental commit, though it does not matter
 in this case.
 Site docs will be sorted out later.
   

Oups! Yes it's a accidental commit.

Milamber

   
jmeter/trunk/xdocs/changes.xml
jmeter/trunk/xdocs/images/screenshots/changes/25_selector.png