Re: Release a 3.2

2017-02-28 Thread Philippe Mouawad 
On Wed, Mar 1, 2017 at 12:23 AM, sebb  wrote:

> On 28 February 2017 at 23:15, Philippe Mouawad
>  wrote:
> > On Tuesday, February 28, 2017, sebb  wrote:
> >
> >> On 28 February 2017 at 22:40, Philippe Mouawad
> >> > wrote:
> >> > On Tue, Feb 28, 2017 at 11:25 PM, sebb  >
> >> wrote:
> >> >
> >> >> On 28 February 2017 at 22:06, Philippe Mouawad
> >> >> > wrote:
> >> >> > On Tue, Feb 28, 2017 at 11:01 PM, sebb  >> > wrote:
> >> >> >
> >> >> >> On 28 February 2017 at 21:54, Philippe Mouawad
> >> >> >> > wrote:
> >> >> >> > Hello,
> >> >> >> > We're now at:
> >> >> >> >
> >> >> >> >- 48 Enhancements
> >> >> >> >- 31 bug fixes
> >> >> >> >
> >> >> >> > Sebb has fixed Windows failures on Jenkins
> >> >> >> >
> >> >> >> >- Ensure the migrated docs (from PDF) do not contain old
> "Urban
> >> >> >> legends"
> >> >> >> >:-) nor bad practices. Those are the 4 Tutorial links in left
> >> >> menu. It
> >> >> >> >would be nice to review them. I've fixed some but not done
> the
> >> full
> >> >> >> work
> >> >> >> >
> >> >> >> > TODO
> >> >> >> >
> >> >> >> >- Fill in introduced properties in properties_reference.xml
> >> >> >>
> >> >> >> Remove obsolete references (e.g. some logging ones ?)
> >> >> >>
> >> >> >
> >> >> > Which ones ?
> >> >> > I made the cleanup.
> >> >> > Did I forget something ?
> >> >> >
> >> >> >>
> >> >> >> Add logging documentation.
> >> >> >>
> >> >> > It has been done in properties_reference.xml
> >> >>
> >> >> There is only some mention of HttpClient logging there.
> >> >>
> >> >> I could not find any description as to how to set the level for a
> >> >> specific JMeter class.
> >> >>
> >> >
> >> > I think this is pretty easy to find on internet knowing we use log4j2
> and
> >> > slf4j.
> >> > But if you think we should add some doc, feel free to do it.
> >>
> >> Sorry, but that is not good enough.
> >> I did not want the hassle of changing the logging. You did want the
> change.
> >
> >
> > It was an agreement from team. Not only me.
>
> You were the prime mover.
>
> > It's Apache way and boyscout rule :),  it's not enough feel free to
> improve
> > it.
> > Search engine results seem good enough for me:
> > https://lite.qwant.com/?q=log4j2%20configure%20log
> >
> >
> >
> >
> >
> >> The change was agreed to on the basis that updated documentation was
> >> essential.
> >>
> >> There do not need to be reams of docs, but there should be at least
> >> couple of sentences as to how to configure the logging that will be
> >> readily understandable to someone used to the old ways.
> >
> >
> > What is the best place for it in your opinion ?
>
> In the user manual (getting started has some references to logging)
> with a link from jmeter.properties.
>
> Woonsan has contributed a PR this night that I have merged.


> Also needs details in changes.xml for the plugin writers.
> Where appropriate that can also point to the user manual.
>

I'll update it unless you want to.

>
> > I am not saying I'll write it though, as I have contributed already
> > important time on this.
>
> Someone has to do it.
> If it's not done, then the release should not go ahead.
>
> I did say at the outset that changing logging was going to be a lot of
> work.
>


You indeed said it multiple times :-)


> >
> >
> >>
> >> And plugin writers need to be told how to update their plugins.
> >>
> >> >>
> >> >> jmeter.properties used to describe this in some detail.
> >> >> The updated description probably does not belong there, but there
> >> >> should at least be a pointer to where to find the new information.
> >> >>
> >> >> >>
> >> >> >> Remove remaining references to older logging API.
> >> >> >>
> >> >> >
> >> >> > Where ?
> >> >> > I thought I had done it
> >> >>
> >> >> The string log_level appears in quite a few places.
> >> >> AFAIK it is not used in the new scheme
> >> >>
> >> > I have removed them.
> >> > Let me know if I still missed something
> >>
> >> I don't know if there is anything else.
> >> I just happened to notice that reference.
> >>
> >> Thanks for pointing that
> >
> >
> >> >  Thanks
> >> >
> >> >>
> >> >> >>
> >> >> >> >
> >> >> >> > DONE
> >> >> >> >
> >> >> >> >- If possible add JUnits on the regression introduced in GET
> >> with
> >> >> no
> >> >> >> >body (see my mail)
> >> >> >> >
> >> >> >> > DONE
> >> >> >> >
> >> >> >> >- Fill in New and Noteworthy section
> >> >> >> >
> >> >> >> > TODO
> >> >> >> >
> >> >> >> >
> >> >> >> > Are you ok to start a release soon ?
> >> >> >> >
> >> >> >> > Thanks
> >> >> >> >
> >> >> >> > Regards
> >> >> >> >
> >> >> >> > On Tue, Feb 21, 2017 at 4:21 PM, sebb  >> > wrote:
> >> >> >> >
> >> >> >> >> I'm seeing some test failures on Windows.
> >> >> >>

[GitHub] jmeter issue #278: Documenting log4j2 related changes since 3.2.

2017-02-28 Thread ra0077 
Github user ra0077 commented on the issue:

https://github.com/apache/jmeter/pull/278
  
Hi,

get-started.html don't need to be in the patch because it's a generated file

Antonio


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request #278: Documenting log4j2 related changes since 3.2.

2017-02-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/278


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: svn commit: r1784829 - in /jmeter/trunk: extras/remote.bsh xdocs/usermanual/best-practices.xml

2017-02-28 Thread Woonsan Ko 
On Tue, Feb 28, 2017 at 6:16 PM, sebb  wrote:
> On 28 February 2017 at 22:39,   wrote:
>> Author: pmouawad
>> Date: Tue Feb 28 22:39:25 2017
>> New Revision: 1784829
>>
>> URL: http://svn.apache.org/viewvc?rev=1784829=rev
>> Log:
>> Remove log_level occurences
>>
>> Modified:
>> jmeter/trunk/extras/remote.bsh
>> jmeter/trunk/xdocs/usermanual/best-practices.xml
>>
>> Modified: jmeter/trunk/extras/remote.bsh
>> URL: 
>> http://svn.apache.org/viewvc/jmeter/trunk/extras/remote.bsh?rev=1784829=1784828=1784829=diff
>> ==
>> --- jmeter/trunk/extras/remote.bsh (original)
>> +++ jmeter/trunk/extras/remote.bsh Tue Feb 28 22:39:25 2017
>> @@ -34,9 +34,6 @@ print(args);
>>  printsysprop("user.home");
>>  printsysprop("user.dir");
>>
>> -printprop("log_level.jmeter");
>> -printprop("log_level.jorphan");
>> -
>>  // loglevel("DEBUG","jmeter");
>
> This should be a clue that there's a loglevel function somewhere.
> It needs to be found and updated to use the new style of logging.

The new way to set log level for a category or for root is here:
- 
https://github.com/apache/jmeter/blob/trunk/src/core/org/apache/jmeter/JMeter.java#L830-L852

Regards,

Woonsan

>
> And the printprop calls should ideally be replaced with something that
> displays the logging level.
>
>>
>>  for(i=0;i<10;i++){
>>
>> Modified: jmeter/trunk/xdocs/usermanual/best-practices.xml
>> URL: 
>> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/best-practices.xml?rev=1784829=1784828=1784829=diff
>> ==
>> --- jmeter/trunk/xdocs/usermanual/best-practices.xml (original)
>> +++ jmeter/trunk/xdocs/usermanual/best-practices.xml Tue Feb 28 22:39:25 2017
>> @@ -214,8 +214,6 @@ BeanShell 2.0b5 - by Pat Niemeyer (pat@p
>>  bsh % remote.bsh starting
>>  user.home = C:\Documents and Settings\User
>>  user.dir = D:\eclipseworkspaces\main\JMeter_trunk\bin
>> -log_level.jmeter = INFO
>> -log_level.jorphan = INFO
>>  Setting property 'EXAMPLE' to '0'.
>>  Setting property 'EXAMPLE' to '1'.
>>  Setting property 'EXAMPLE' to '2'.
>>
>>

[GitHub] jmeter pull request #278: Documenting log4j2 related changes since 3.2.

2017-02-28 Thread woonsan 
GitHub user woonsan opened a pull request:

https://github.com/apache/jmeter/pull/278

Documenting log4j2 related changes since 3.2.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/woonsan/jmeter feature/logging-docs-updates

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #278


commit 7d2a75f4ac5b459fedbe4d0af575453d586ce556
Author: Woonsan Ko 
Date:   2017-03-01T06:52:00Z

Updating log4j2.xml related topics

commit 3df44692fb993e2df64db0e5e9950fdff1feaf32
Author: Woonsan Ko 
Date:   2017-03-01T06:57:12Z

generating new get-started.html




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Possible Bug in Java 8 u 112 in javax.swing.JEditorPane.setText leads to stuck UI

2017-02-28 Thread Muneer Kolarkunnu 
Hi Philippe,

 

If you set the content type before setting text, it is not taking much time. It 
is just 2-5 seconds.

You can set the content type using 
javax.swing.JEditorPane.setContentType(String) API.

Eg: editor.setContentType("text/plain"); // or 
editor.setContentType("text/html");

 

I updated the test case which you shared along with bug and attached.

 

I hope it will resolve your issue.

 

Regards,

Muneer

 

From: Philippe Mouawad [mailto:pmoua...@apache.org] 
Sent: Wednesday, March 01, 2017 3:29 AM
To: Rory O'Donnell; Dalibor Topic
Cc: Muneer Kolarkunnu; Balchandra Vaidya; dev@jmeter.apache.org
Subject: Re: Possible Bug in Java 8 u 112 in javax.swing.JEditorPane.setText 
leads to stuck UI

 

Hello Guys,

Any chance that a P4 bug is fixed ?

It unfortunately affects us badly whenever some text (more than 700K which is 
frequent for HTML pages) is received in our tool.

 

For my information what does this mean:
ILW = MLH = P4 

Thanks

 

On Tue, Jan 31, 2017 at 12:26 PM, Rory O'Donnell mailto:rory.odonn...@oracle.com; \nrory.odonn...@oracle.com> wrote:

Hi Philippe,

It's marked P4 because it is seen as a corner case issue.

Rgds,Rory
On 30/01/2017 22:43, Philippe Mouawad wrote:

Hello,
Thanks.
Any chance issue gets fixed as I see it's P4 .

Thank you

On Monday, January 16, 2017, Muneer Kolarkunnu mailto:abdul.kolarku...@oracle.com; \nabdul.kolarku...@oracle.com>
wrote:

Hi Philippe,



Thanks for sharing standalone test case.

Issue is reproducible in all platforms(Windows, Linux and Osx) with all
JDK versions(7, 8, 9-ea).

I reopened the bug, You can see the updates in here:
https://bugs.openjdk.java.net/browse/JDK-8172336



Regards,

Muneer



*From:* Philippe Mouawad [mailto:HYPERLINK "mailto:pmoua...@apache.org; 
\npmoua...@apache.org
]
*Sent:* Sunday, January 15, 2017 4:33 AM
*To:* Muneer Kolarkunnu
*Cc:* Dalibor Topic; Balchandra Vaidya; HYPERLINK 
"mailto:dev@jmeter.apache.org; \n...@jmeter.apache.org
; Rory O'Donnell
*Subject:* Re: Possible Bug in Java 8 u 112 in javax.swing.JEditorPane.setText
leads to stuck UI



Hi,

Previous sample showed already very slow rendering when text contains
spaces.

Now for the text without space. Sample attached.

Regards



On Fri, Jan 13, 2017 at 2:20 PM, Philippe Mouawad mailto:pmoua...@apache.org; \npmoua...@apache.org
> wrote:

Hello Muneer,

Find attached  a simple program reproducing issue.

I see you closed the bug

Regards



On Fri, Jan 6, 2017 at 2:28 PM, Muneer Kolarkunnu <
HYPERLINK "mailto:abdul.kolarku...@oracle.com; \nabdul.kolarku...@oracle.com
> wrote:

Hi Philippe,

Your incident has moved to JDK-8172336: https://bugs.openjdk.java.net/
browse/JDK-8172336

I tried to reproduce the issue, but I could not reproduce this issue with
the information shared in the bug report. If you can provide a standalone
test case, it will be great. Also, please let us know if you observe the
same issue with JDK 8u122-ea and JDK 9-ea.
Have you observed the same issue with other OS(Other than Mac OSX) ?

8u122-ea is available here : https://jdk8.java.net/download.html
JDK 9-ea is available here : https://jdk9.java.net/download/

Regards,
Muneer


-Original Message-
From: Rory O'Donnell
Sent: Thursday, January 05, 2017 5:22 PM
To: HYPERLINK "mailto:dev@jmeter.apache.org; \n...@jmeter.apache.org

Cc: Rory O'Donnell; Dalibor Topic; Balchandra Vaidya; Muneer Kolarkunnu
Subject: Re: Possible Bug in Java 8 u 112 in javax.swing.JEditorPane.setText
leads to stuck UI

Thanks Philippe, we'll take a look.

Rgds,Rory


On 05/01/2017 10:30, Philippe Mouawad wrote:

Hello,
Done:9046713

Regards

On Thu, Jan 5, 2017 at 11:14 AM, Rory O'Donnell
mailto:rory.odonn...@oracle.com; \nrory.odonn...@oracle.com

>

 

wrote:

Hi Philippe,

Many happy returns!

Can you log a bug and send us the Java Incident id ?

Rgds,Rory




On 05/01/2017 10:12, Philippe Mouawad wrote:

Greetings,
First best wishes for 2017.

I'd like to report what seems to be a critical bug we face in JMeter
. I noticed it under Mac OSX El Capitan.

Calling javax.swing.JEditorPane.setText() from AWT Thread with some
long text (without spaces) leads to what seems to be either a very
long or infinite loop, I made thread dumps and I have always  such
(partial)
stacktrace:
"AWT-EventQueue-0" #20 prio=6 os_prio=31 tid=0x7fa7a8afc000
nid=0xf707 runnable [0x72202000]
     

Re: svn commit: r1784829 - in /jmeter/trunk: extras/remote.bsh xdocs/usermanual/best-practices.xml

2017-02-28 Thread sebb 
On 28 February 2017 at 23:20, Philippe Mouawad
 wrote:
> On Wednesday, March 1, 2017, sebb  wrote:
>
>> On 28 February 2017 at 22:39,  > wrote:
>> > Author: pmouawad
>> > Date: Tue Feb 28 22:39:25 2017
>> > New Revision: 1784829
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1784829=rev
>> > Log:
>> > Remove log_level occurences
>> >
>> > Modified:
>> > jmeter/trunk/extras/remote.bsh
>> > jmeter/trunk/xdocs/usermanual/best-practices.xml
>> >
>> > Modified: jmeter/trunk/extras/remote.bsh
>> > URL: http://svn.apache.org/viewvc/jmeter/trunk/extras/remote.
>> bsh?rev=1784829=1784828=1784829=diff
>> > 
>> ==
>> > --- jmeter/trunk/extras/remote.bsh (original)
>> > +++ jmeter/trunk/extras/remote.bsh Tue Feb 28 22:39:25 2017
>> > @@ -34,9 +34,6 @@ print(args);
>> >  printsysprop("user.home");
>> >  printsysprop("user.dir");
>> >
>> > -printprop("log_level.jmeter");
>> > -printprop("log_level.jorphan");
>> > -
>> >  // loglevel("DEBUG","jmeter");
>>
>> This should be a clue that there's a loglevel function somewhere.
>> It needs to be found and updated to use the new style of logging.
>>
>> And the printprop calls should ideally be replaced with something that
>> displays the logging level.
>
>
> I've never ever used this feature (and we advise using groovy now) so if
> you have an good view of what needs to be fixed,  please go ahead.
> Thanks

The startup.bsh script needs to be updated to use the new logging methods.

I don't know how to do it since the documentation does not exist, and
anyway I don't see why I should be the one to fix it.

>>
>> >
>> >  for(i=0;i<10;i++){
>> >
>> > Modified: jmeter/trunk/xdocs/usermanual/best-practices.xml
>> > URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/
>> best-practices.xml?rev=1784829=1784828=1784829=diff
>> > 
>> ==
>> > --- jmeter/trunk/xdocs/usermanual/best-practices.xml (original)
>> > +++ jmeter/trunk/xdocs/usermanual/best-practices.xml Tue Feb 28
>> 22:39:25 2017
>> > @@ -214,8 +214,6 @@ BeanShell 2.0b5 - by Pat Niemeyer (pat@p
>> >  bsh % remote.bsh starting
>> >  user.home = C:\Documents and Settings\User
>> >  user.dir = D:\eclipseworkspaces\main\JMeter_trunk\bin
>> > -log_level.jmeter = INFO
>> > -log_level.jorphan = INFO
>> >  Setting property 'EXAMPLE' to '0'.
>> >  Setting property 'EXAMPLE' to '1'.
>> >  Setting property 'EXAMPLE' to '2'.
>> >
>> >
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.

Re: svn commit: r1784829 - in /jmeter/trunk: extras/remote.bsh xdocs/usermanual/best-practices.xml

2017-02-28 Thread Philippe Mouawad 
On Wednesday, March 1, 2017, sebb  wrote:

> On 28 February 2017 at 22:39,  > wrote:
> > Author: pmouawad
> > Date: Tue Feb 28 22:39:25 2017
> > New Revision: 1784829
> >
> > URL: http://svn.apache.org/viewvc?rev=1784829=rev
> > Log:
> > Remove log_level occurences
> >
> > Modified:
> > jmeter/trunk/extras/remote.bsh
> > jmeter/trunk/xdocs/usermanual/best-practices.xml
> >
> > Modified: jmeter/trunk/extras/remote.bsh
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/extras/remote.
> bsh?rev=1784829=1784828=1784829=diff
> > 
> ==
> > --- jmeter/trunk/extras/remote.bsh (original)
> > +++ jmeter/trunk/extras/remote.bsh Tue Feb 28 22:39:25 2017
> > @@ -34,9 +34,6 @@ print(args);
> >  printsysprop("user.home");
> >  printsysprop("user.dir");
> >
> > -printprop("log_level.jmeter");
> > -printprop("log_level.jorphan");
> > -
> >  // loglevel("DEBUG","jmeter");
>
> This should be a clue that there's a loglevel function somewhere.
> It needs to be found and updated to use the new style of logging.
>
> And the printprop calls should ideally be replaced with something that
> displays the logging level.


I've never ever used this feature (and we advise using groovy now) so if
you have an good view of what needs to be fixed,  please go ahead.
Thanks

>
> >
> >  for(i=0;i<10;i++){
> >
> > Modified: jmeter/trunk/xdocs/usermanual/best-practices.xml
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/
> best-practices.xml?rev=1784829=1784828=1784829=diff
> > 
> ==
> > --- jmeter/trunk/xdocs/usermanual/best-practices.xml (original)
> > +++ jmeter/trunk/xdocs/usermanual/best-practices.xml Tue Feb 28
> 22:39:25 2017
> > @@ -214,8 +214,6 @@ BeanShell 2.0b5 - by Pat Niemeyer (pat@p
> >  bsh % remote.bsh starting
> >  user.home = C:\Documents and Settings\User
> >  user.dir = D:\eclipseworkspaces\main\JMeter_trunk\bin
> > -log_level.jmeter = INFO
> > -log_level.jorphan = INFO
> >  Setting property 'EXAMPLE' to '0'.
> >  Setting property 'EXAMPLE' to '1'.
> >  Setting property 'EXAMPLE' to '2'.
> >
> >
>


-- 
Cordialement.
Philippe Mouawad.

Re: svn commit: r1784829 - in /jmeter/trunk: extras/remote.bsh xdocs/usermanual/best-practices.xml

2017-02-28 Thread sebb 
On 28 February 2017 at 22:39,   wrote:
> Author: pmouawad
> Date: Tue Feb 28 22:39:25 2017
> New Revision: 1784829
>
> URL: http://svn.apache.org/viewvc?rev=1784829=rev
> Log:
> Remove log_level occurences
>
> Modified:
> jmeter/trunk/extras/remote.bsh
> jmeter/trunk/xdocs/usermanual/best-practices.xml
>
> Modified: jmeter/trunk/extras/remote.bsh
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/extras/remote.bsh?rev=1784829=1784828=1784829=diff
> ==
> --- jmeter/trunk/extras/remote.bsh (original)
> +++ jmeter/trunk/extras/remote.bsh Tue Feb 28 22:39:25 2017
> @@ -34,9 +34,6 @@ print(args);
>  printsysprop("user.home");
>  printsysprop("user.dir");
>
> -printprop("log_level.jmeter");
> -printprop("log_level.jorphan");
> -
>  // loglevel("DEBUG","jmeter");

This should be a clue that there's a loglevel function somewhere.
It needs to be found and updated to use the new style of logging.

And the printprop calls should ideally be replaced with something that
displays the logging level.

>
>  for(i=0;i<10;i++){
>
> Modified: jmeter/trunk/xdocs/usermanual/best-practices.xml
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/best-practices.xml?rev=1784829=1784828=1784829=diff
> ==
> --- jmeter/trunk/xdocs/usermanual/best-practices.xml (original)
> +++ jmeter/trunk/xdocs/usermanual/best-practices.xml Tue Feb 28 22:39:25 2017
> @@ -214,8 +214,6 @@ BeanShell 2.0b5 - by Pat Niemeyer (pat@p
>  bsh % remote.bsh starting
>  user.home = C:\Documents and Settings\User
>  user.dir = D:\eclipseworkspaces\main\JMeter_trunk\bin
> -log_level.jmeter = INFO
> -log_level.jorphan = INFO
>  Setting property 'EXAMPLE' to '0'.
>  Setting property 'EXAMPLE' to '1'.
>  Setting property 'EXAMPLE' to '2'.
>
>

Re: Release a 3.2

2017-02-28 Thread sebb 
On 28 February 2017 at 22:40, Philippe Mouawad
 wrote:
> On Tue, Feb 28, 2017 at 11:25 PM, sebb  wrote:
>
>> On 28 February 2017 at 22:06, Philippe Mouawad
>>  wrote:
>> > On Tue, Feb 28, 2017 at 11:01 PM, sebb  wrote:
>> >
>> >> On 28 February 2017 at 21:54, Philippe Mouawad
>> >>  wrote:
>> >> > Hello,
>> >> > We're now at:
>> >> >
>> >> >- 48 Enhancements
>> >> >- 31 bug fixes
>> >> >
>> >> > Sebb has fixed Windows failures on Jenkins
>> >> >
>> >> >- Ensure the migrated docs (from PDF) do not contain old "Urban
>> >> legends"
>> >> >:-) nor bad practices. Those are the 4 Tutorial links in left
>> menu. It
>> >> >would be nice to review them. I've fixed some but not done the full
>> >> work
>> >> >
>> >> > TODO
>> >> >
>> >> >- Fill in introduced properties in properties_reference.xml
>> >>
>> >> Remove obsolete references (e.g. some logging ones ?)
>> >>
>> >
>> > Which ones ?
>> > I made the cleanup.
>> > Did I forget something ?
>> >
>> >>
>> >> Add logging documentation.
>> >>
>> > It has been done in properties_reference.xml
>>
>> There is only some mention of HttpClient logging there.
>>
>> I could not find any description as to how to set the level for a
>> specific JMeter class.
>>
>
> I think this is pretty easy to find on internet knowing we use log4j2 and
> slf4j.
> But if you think we should add some doc, feel free to do it.

Sorry, but that is not good enough.
I did not want the hassle of changing the logging. You did want the change.
The change was agreed to on the basis that updated documentation was essential.

There do not need to be reams of docs, but there should be at least
couple of sentences as to how to configure the logging that will be
readily understandable to someone used to the old ways.

And plugin writers need to be told how to update their plugins.

>>
>> jmeter.properties used to describe this in some detail.
>> The updated description probably does not belong there, but there
>> should at least be a pointer to where to find the new information.
>>
>> >>
>> >> Remove remaining references to older logging API.
>> >>
>> >
>> > Where ?
>> > I thought I had done it
>>
>> The string log_level appears in quite a few places.
>> AFAIK it is not used in the new scheme
>>
> I have removed them.
> Let me know if I still missed something

I don't know if there is anything else.
I just happened to notice that reference.

>  Thanks
>
>>
>> >>
>> >> >
>> >> > DONE
>> >> >
>> >> >- If possible add JUnits on the regression introduced in GET with
>> no
>> >> >body (see my mail)
>> >> >
>> >> > DONE
>> >> >
>> >> >- Fill in New and Noteworthy section
>> >> >
>> >> > TODO
>> >> >
>> >> >
>> >> > Are you ok to start a release soon ?
>> >> >
>> >> > Thanks
>> >> >
>> >> > Regards
>> >> >
>> >> > On Tue, Feb 21, 2017 at 4:21 PM, sebb  wrote:
>> >> >
>> >> >> I'm seeing some test failures on Windows.
>> >> >>
>> >> >> I've started to set up a Jenkins build to be able to catch these.
>> >> >> (at present the failure mails are sent direct to me)
>> >> >>
>> >> >> Depending on the cause, the failures need to be fixed before the next
>> >> >> release.
>> >> >>
>> >> >> On 11 February 2017 at 10:22, Philippe Mouawad
>> >> >>  wrote:
>> >> >> > Hello,
>> >> >> > Since our discussion on "Release a 3.2 ?" , trunk has nicely
>> evolved:
>> >> >> >
>> >> >> >- 33 Enhancements
>> >> >> >- 25 bug fixes
>> >> >> >
>> >> >> > I think we can now plan a release.
>> >> >> >
>> >> >> > I see the following remaining work:
>> >> >> >
>> >> >> >- Ensure the migrated docs (from PDF) do not contain old "Urban
>> >> >> legends"
>> >> >> >:-) nor bad practices. Those are the 4 Tutorial links in left
>> >> menu. It
>> >> >> >would be nice to review them. I've fixed some but not done the
>> full
>> >> >> work
>> >> >> >- Fill in introduced properties in properties_reference.xml
>> >> >> >- If possible add JUnits on the regression introduced in GET
>> with
>> >> no
>> >> >> >body (see my mail)
>> >> >> >- Fill in New and Noteworthy section
>> >> >> >
>> >> >> >
>> >> >> >
>> >> >> > --
>> >> >> > Cordialement.
>> >> >> > Philippe Mouawad.
>> >> >>
>> >> >
>> >> >
>> >> >
>> >> > --
>> >> > Cordialement.
>> >> > Philippe Mouawad.
>> >>
>> >
>> >
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.

Re: Possible Bug in Java 8 u 112 in javax.swing.JEditorPane.setText leads to stuck UI

2017-02-28 Thread dalibor topic 



On 28.02.2017 22:59, Philippe Mouawad wrote:

Salut Philippe,


For my information what does this mean:
ILW = MLH = P4


Impact, Likelyhood and Workaround criteria are briefly described in 
https://blogs.oracle.com/java/a-bugs-life:-java-7-updates


cheers,
dalibor topic


Thanks

On Tue, Jan 31, 2017 at 12:26 PM, Rory O'Donnell
> wrote:

Hi Philippe,

It's marked P4 because it is seen as a corner case issue.

Rgds,Rory
On 30/01/2017 22:43, Philippe Mouawad wrote:

Hello,
Thanks.
Any chance issue gets fixed as I see it's P4 .

Thank you

On Monday, January 16, 2017, Muneer Kolarkunnu
>
wrote:

Hi Philippe,



Thanks for sharing standalone test case.

Issue is reproducible in all platforms(Windows, Linux and
Osx) with all
JDK versions(7, 8, 9-ea).

I reopened the bug, You can see the updates in here:
https://bugs.openjdk.java.net/browse/JDK-8172336




Regards,

Muneer



*From:* Philippe Mouawad [mailto:pmoua...@apache.org

');>]
*Sent:* Sunday, January 15, 2017 4:33 AM
*To:* Muneer Kolarkunnu
*Cc:* Dalibor Topic; Balchandra Vaidya;
dev@jmeter.apache.org 
');>; Rory O'Donnell
*Subject:* Re: Possible Bug in Java 8 u 112 in
javax.swing.JEditorPane.setText
leads to stuck UI



Hi,

Previous sample showed already very slow rendering when text
contains
spaces.

Now for the text without space. Sample attached.

Regards



On Fri, Jan 13, 2017 at 2:20 PM, Philippe Mouawad

');>> wrote:

Hello Muneer,

Find attached  a simple program reproducing issue.

I see you closed the bug

Regards



On Fri, Jan 6, 2017 at 2:28 PM, Muneer Kolarkunnu <
abdul.kolarku...@oracle.com 
');>> wrote:

Hi Philippe,

Your incident has moved to JDK-8172336:
https://bugs.openjdk.java.net/
browse/JDK-8172336

I tried to reproduce the issue, but I could not reproduce
this issue with
the information shared in the bug report. If you can provide
a standalone
test case, it will be great. Also, please let us know if you
observe the
same issue with JDK 8u122-ea and JDK 9-ea.
Have you observed the same issue with other OS(Other than
Mac OSX) ?

8u122-ea is available here :
https://jdk8.java.net/download.html

JDK 9-ea is available here : https://jdk9.java.net/download/


Regards,
Muneer


-Original Message-
From: Rory O'Donnell
Sent: Thursday, January 05, 2017 5:22 PM
To: dev@jmeter.apache.org 
');>
Cc: Rory O'Donnell; Dalibor Topic; Balchandra Vaidya; Muneer
Kolarkunnu
Subject: Re: Possible Bug in Java 8 u 112 in
javax.swing.JEditorPane.setText
leads to stuck UI

Thanks Philippe, we'll take a look.

Rgds,Rory


On 05/01/2017 10:30, Philippe Mouawad wrote:

Hello,
Done:9046713

Regards

On Thu, Jan 5, 2017 at 11:14 AM, Rory O'Donnell


');>>

wrote:

Hi Philippe,

Many happy returns!

Can you log a bug and send us the Java Incident id ?

Rgds,Rory




On 05/01/2017 10:12, Philippe Mouawad wrote:

Re: Release a 3.2

2017-02-28 Thread Philippe Mouawad 
On Tue, Feb 28, 2017 at 11:25 PM, sebb  wrote:

> On 28 February 2017 at 22:06, Philippe Mouawad
>  wrote:
> > On Tue, Feb 28, 2017 at 11:01 PM, sebb  wrote:
> >
> >> On 28 February 2017 at 21:54, Philippe Mouawad
> >>  wrote:
> >> > Hello,
> >> > We're now at:
> >> >
> >> >- 48 Enhancements
> >> >- 31 bug fixes
> >> >
> >> > Sebb has fixed Windows failures on Jenkins
> >> >
> >> >- Ensure the migrated docs (from PDF) do not contain old "Urban
> >> legends"
> >> >:-) nor bad practices. Those are the 4 Tutorial links in left
> menu. It
> >> >would be nice to review them. I've fixed some but not done the full
> >> work
> >> >
> >> > TODO
> >> >
> >> >- Fill in introduced properties in properties_reference.xml
> >>
> >> Remove obsolete references (e.g. some logging ones ?)
> >>
> >
> > Which ones ?
> > I made the cleanup.
> > Did I forget something ?
> >
> >>
> >> Add logging documentation.
> >>
> > It has been done in properties_reference.xml
>
> There is only some mention of HttpClient logging there.
>
> I could not find any description as to how to set the level for a
> specific JMeter class.
>

I think this is pretty easy to find on internet knowing we use log4j2 and
slf4j.
But if you think we should add some doc, feel free to do it.

>
> jmeter.properties used to describe this in some detail.
> The updated description probably does not belong there, but there
> should at least be a pointer to where to find the new information.
>
> >>
> >> Remove remaining references to older logging API.
> >>
> >
> > Where ?
> > I thought I had done it
>
> The string log_level appears in quite a few places.
> AFAIK it is not used in the new scheme
>
I have removed them.
Let me know if I still missed something
 Thanks

>
> >>
> >> >
> >> > DONE
> >> >
> >> >- If possible add JUnits on the regression introduced in GET with
> no
> >> >body (see my mail)
> >> >
> >> > DONE
> >> >
> >> >- Fill in New and Noteworthy section
> >> >
> >> > TODO
> >> >
> >> >
> >> > Are you ok to start a release soon ?
> >> >
> >> > Thanks
> >> >
> >> > Regards
> >> >
> >> > On Tue, Feb 21, 2017 at 4:21 PM, sebb  wrote:
> >> >
> >> >> I'm seeing some test failures on Windows.
> >> >>
> >> >> I've started to set up a Jenkins build to be able to catch these.
> >> >> (at present the failure mails are sent direct to me)
> >> >>
> >> >> Depending on the cause, the failures need to be fixed before the next
> >> >> release.
> >> >>
> >> >> On 11 February 2017 at 10:22, Philippe Mouawad
> >> >>  wrote:
> >> >> > Hello,
> >> >> > Since our discussion on "Release a 3.2 ?" , trunk has nicely
> evolved:
> >> >> >
> >> >> >- 33 Enhancements
> >> >> >- 25 bug fixes
> >> >> >
> >> >> > I think we can now plan a release.
> >> >> >
> >> >> > I see the following remaining work:
> >> >> >
> >> >> >- Ensure the migrated docs (from PDF) do not contain old "Urban
> >> >> legends"
> >> >> >:-) nor bad practices. Those are the 4 Tutorial links in left
> >> menu. It
> >> >> >would be nice to review them. I've fixed some but not done the
> full
> >> >> work
> >> >> >- Fill in introduced properties in properties_reference.xml
> >> >> >- If possible add JUnits on the regression introduced in GET
> with
> >> no
> >> >> >body (see my mail)
> >> >> >- Fill in New and Noteworthy section
> >> >> >
> >> >> >
> >> >> >
> >> >> > --
> >> >> > Cordialement.
> >> >> > Philippe Mouawad.
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > Cordialement.
> >> > Philippe Mouawad.
> >>
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>



-- 
Cordialement.
Philippe Mouawad.

Re: Release a 3.2

2017-02-28 Thread sebb 
On 28 February 2017 at 22:06, Philippe Mouawad
 wrote:
> On Tue, Feb 28, 2017 at 11:01 PM, sebb  wrote:
>
>> On 28 February 2017 at 21:54, Philippe Mouawad
>>  wrote:
>> > Hello,
>> > We're now at:
>> >
>> >- 48 Enhancements
>> >- 31 bug fixes
>> >
>> > Sebb has fixed Windows failures on Jenkins
>> >
>> >- Ensure the migrated docs (from PDF) do not contain old "Urban
>> legends"
>> >:-) nor bad practices. Those are the 4 Tutorial links in left menu. It
>> >would be nice to review them. I've fixed some but not done the full
>> work
>> >
>> > TODO
>> >
>> >- Fill in introduced properties in properties_reference.xml
>>
>> Remove obsolete references (e.g. some logging ones ?)
>>
>
> Which ones ?
> I made the cleanup.
> Did I forget something ?
>
>>
>> Add logging documentation.
>>
> It has been done in properties_reference.xml

There is only some mention of HttpClient logging there.

I could not find any description as to how to set the level for a
specific JMeter class.

jmeter.properties used to describe this in some detail.
The updated description probably does not belong there, but there
should at least be a pointer to where to find the new information.

>>
>> Remove remaining references to older logging API.
>>
>
> Where ?
> I thought I had done it

The string log_level appears in quite a few places.
AFAIK it is not used in the new scheme

>>
>> >
>> > DONE
>> >
>> >- If possible add JUnits on the regression introduced in GET with no
>> >body (see my mail)
>> >
>> > DONE
>> >
>> >- Fill in New and Noteworthy section
>> >
>> > TODO
>> >
>> >
>> > Are you ok to start a release soon ?
>> >
>> > Thanks
>> >
>> > Regards
>> >
>> > On Tue, Feb 21, 2017 at 4:21 PM, sebb  wrote:
>> >
>> >> I'm seeing some test failures on Windows.
>> >>
>> >> I've started to set up a Jenkins build to be able to catch these.
>> >> (at present the failure mails are sent direct to me)
>> >>
>> >> Depending on the cause, the failures need to be fixed before the next
>> >> release.
>> >>
>> >> On 11 February 2017 at 10:22, Philippe Mouawad
>> >>  wrote:
>> >> > Hello,
>> >> > Since our discussion on "Release a 3.2 ?" , trunk has nicely evolved:
>> >> >
>> >> >- 33 Enhancements
>> >> >- 25 bug fixes
>> >> >
>> >> > I think we can now plan a release.
>> >> >
>> >> > I see the following remaining work:
>> >> >
>> >> >- Ensure the migrated docs (from PDF) do not contain old "Urban
>> >> legends"
>> >> >:-) nor bad practices. Those are the 4 Tutorial links in left
>> menu. It
>> >> >would be nice to review them. I've fixed some but not done the full
>> >> work
>> >> >- Fill in introduced properties in properties_reference.xml
>> >> >- If possible add JUnits on the regression introduced in GET with
>> no
>> >> >body (see my mail)
>> >> >- Fill in New and Noteworthy section
>> >> >
>> >> >
>> >> >
>> >> > --
>> >> > Cordialement.
>> >> > Philippe Mouawad.
>> >>
>> >
>> >
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.

Differences between HC4 and JAVA Impl

2017-02-28 Thread Philippe Mouawad 
Hello,
Working yesterday on TEST_HTTP.jmx to add coverage for Java Impl, I noticed
the following additional difference.

Java Impl is not able to get in Request Headers the restricted values like:

   - User-Agent
   - Host
   - 


Am I missing something or is there a way ?
Thanks
-- 
Cordialement.
Philippe Mouawad.

Re: Release a 3.2

2017-02-28 Thread Philippe Mouawad 
On Tue, Feb 28, 2017 at 11:01 PM, sebb  wrote:

> On 28 February 2017 at 21:54, Philippe Mouawad
>  wrote:
> > Hello,
> > We're now at:
> >
> >- 48 Enhancements
> >- 31 bug fixes
> >
> > Sebb has fixed Windows failures on Jenkins
> >
> >- Ensure the migrated docs (from PDF) do not contain old "Urban
> legends"
> >:-) nor bad practices. Those are the 4 Tutorial links in left menu. It
> >would be nice to review them. I've fixed some but not done the full
> work
> >
> > TODO
> >
> >- Fill in introduced properties in properties_reference.xml
>
> Remove obsolete references (e.g. some logging ones ?)
>

Which ones ?
I made the cleanup.
Did I forget something ?

>
> Add logging documentation.
>
It has been done in properties_reference.xml

>
> Remove remaining references to older logging API.
>

Where ?
I thought I had done it

>
> >
> > DONE
> >
> >- If possible add JUnits on the regression introduced in GET with no
> >body (see my mail)
> >
> > DONE
> >
> >- Fill in New and Noteworthy section
> >
> > TODO
> >
> >
> > Are you ok to start a release soon ?
> >
> > Thanks
> >
> > Regards
> >
> > On Tue, Feb 21, 2017 at 4:21 PM, sebb  wrote:
> >
> >> I'm seeing some test failures on Windows.
> >>
> >> I've started to set up a Jenkins build to be able to catch these.
> >> (at present the failure mails are sent direct to me)
> >>
> >> Depending on the cause, the failures need to be fixed before the next
> >> release.
> >>
> >> On 11 February 2017 at 10:22, Philippe Mouawad
> >>  wrote:
> >> > Hello,
> >> > Since our discussion on "Release a 3.2 ?" , trunk has nicely evolved:
> >> >
> >> >- 33 Enhancements
> >> >- 25 bug fixes
> >> >
> >> > I think we can now plan a release.
> >> >
> >> > I see the following remaining work:
> >> >
> >> >- Ensure the migrated docs (from PDF) do not contain old "Urban
> >> legends"
> >> >:-) nor bad practices. Those are the 4 Tutorial links in left
> menu. It
> >> >would be nice to review them. I've fixed some but not done the full
> >> work
> >> >- Fill in introduced properties in properties_reference.xml
> >> >- If possible add JUnits on the regression introduced in GET with
> no
> >> >body (see my mail)
> >> >- Fill in New and Noteworthy section
> >> >
> >> >
> >> >
> >> > --
> >> > Cordialement.
> >> > Philippe Mouawad.
> >>
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>



-- 
Cordialement.
Philippe Mouawad.

Re: Release a 3.2

2017-02-28 Thread sebb 
On 28 February 2017 at 21:54, Philippe Mouawad
 wrote:
> Hello,
> We're now at:
>
>- 48 Enhancements
>- 31 bug fixes
>
> Sebb has fixed Windows failures on Jenkins
>
>- Ensure the migrated docs (from PDF) do not contain old "Urban legends"
>:-) nor bad practices. Those are the 4 Tutorial links in left menu. It
>would be nice to review them. I've fixed some but not done the full work
>
> TODO
>
>- Fill in introduced properties in properties_reference.xml

Remove obsolete references (e.g. some logging ones ?)

Add logging documentation.

Remove remaining references to older logging API.

>
> DONE
>
>- If possible add JUnits on the regression introduced in GET with no
>body (see my mail)
>
> DONE
>
>- Fill in New and Noteworthy section
>
> TODO
>
>
> Are you ok to start a release soon ?
>
> Thanks
>
> Regards
>
> On Tue, Feb 21, 2017 at 4:21 PM, sebb  wrote:
>
>> I'm seeing some test failures on Windows.
>>
>> I've started to set up a Jenkins build to be able to catch these.
>> (at present the failure mails are sent direct to me)
>>
>> Depending on the cause, the failures need to be fixed before the next
>> release.
>>
>> On 11 February 2017 at 10:22, Philippe Mouawad
>>  wrote:
>> > Hello,
>> > Since our discussion on "Release a 3.2 ?" , trunk has nicely evolved:
>> >
>> >- 33 Enhancements
>> >- 25 bug fixes
>> >
>> > I think we can now plan a release.
>> >
>> > I see the following remaining work:
>> >
>> >- Ensure the migrated docs (from PDF) do not contain old "Urban
>> legends"
>> >:-) nor bad practices. Those are the 4 Tutorial links in left menu. It
>> >would be nice to review them. I've fixed some but not done the full
>> work
>> >- Fill in introduced properties in properties_reference.xml
>> >- If possible add JUnits on the regression introduced in GET with no
>> >body (see my mail)
>> >- Fill in New and Noteworthy section
>> >
>> >
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.

Re: Possible Bug in Java 8 u 112 in javax.swing.JEditorPane.setText leads to stuck UI

2017-02-28 Thread Philippe Mouawad 
Hello Guys,
Any chance that a P4 bug is fixed ?
It unfortunately affects us badly whenever some text (more than 700K which
is frequent for HTML pages) is received in our tool.

For my information what does this mean:
ILW = MLH = P4

Thanks

On Tue, Jan 31, 2017 at 12:26 PM, Rory O'Donnell 
wrote:

> Hi Philippe,
>
> It's marked P4 because it is seen as a corner case issue.
>
> Rgds,Rory
> On 30/01/2017 22:43, Philippe Mouawad wrote:
>
>> Hello,
>> Thanks.
>> Any chance issue gets fixed as I see it's P4 .
>>
>> Thank you
>>
>> On Monday, January 16, 2017, Muneer Kolarkunnu <
>> abdul.kolarku...@oracle.com>
>> wrote:
>>
>> Hi Philippe,
>>>
>>>
>>>
>>> Thanks for sharing standalone test case.
>>>
>>> Issue is reproducible in all platforms(Windows, Linux and Osx) with all
>>> JDK versions(7, 8, 9-ea).
>>>
>>> I reopened the bug, You can see the updates in here:
>>> https://bugs.openjdk.java.net/browse/JDK-8172336
>>>
>>>
>>>
>>> Regards,
>>>
>>> Muneer
>>>
>>>
>>>
>>> *From:* Philippe Mouawad [mailto:pmoua...@apache.org
>>> ]
>>> *Sent:* Sunday, January 15, 2017 4:33 AM
>>> *To:* Muneer Kolarkunnu
>>> *Cc:* Dalibor Topic; Balchandra Vaidya; dev@jmeter.apache.org
>>> ; Rory O'Donnell
>>> *Subject:* Re: Possible Bug in Java 8 u 112 in
>>> javax.swing.JEditorPane.setText
>>> leads to stuck UI
>>>
>>>
>>>
>>> Hi,
>>>
>>> Previous sample showed already very slow rendering when text contains
>>> spaces.
>>>
>>> Now for the text without space. Sample attached.
>>>
>>> Regards
>>>
>>>
>>>
>>> On Fri, Jan 13, 2017 at 2:20 PM, Philippe Mouawad >> > wrote:
>>>
>>> Hello Muneer,
>>>
>>> Find attached  a simple program reproducing issue.
>>>
>>> I see you closed the bug
>>>
>>> Regards
>>>
>>>
>>>
>>> On Fri, Jan 6, 2017 at 2:28 PM, Muneer Kolarkunnu <
>>> abdul.kolarku...@oracle.com
>>> > wrote:
>>>
>>> Hi Philippe,
>>>
>>> Your incident has moved to JDK-8172336: https://bugs.openjdk.java.net/
>>> browse/JDK-8172336
>>>
>>> I tried to reproduce the issue, but I could not reproduce this issue with
>>> the information shared in the bug report. If you can provide a standalone
>>> test case, it will be great. Also, please let us know if you observe the
>>> same issue with JDK 8u122-ea and JDK 9-ea.
>>> Have you observed the same issue with other OS(Other than Mac OSX) ?
>>>
>>> 8u122-ea is available here : https://jdk8.java.net/download.html
>>> JDK 9-ea is available here : https://jdk9.java.net/download/
>>>
>>> Regards,
>>> Muneer
>>>
>>>
>>> -Original Message-
>>> From: Rory O'Donnell
>>> Sent: Thursday, January 05, 2017 5:22 PM
>>> To: dev@jmeter.apache.org
>>> 
>>> Cc: Rory O'Donnell; Dalibor Topic; Balchandra Vaidya; Muneer Kolarkunnu
>>> Subject: Re: Possible Bug in Java 8 u 112 in
>>> javax.swing.JEditorPane.setText
>>> leads to stuck UI
>>>
>>> Thanks Philippe, we'll take a look.
>>>
>>> Rgds,Rory
>>>
>>>
>>> On 05/01/2017 10:30, Philippe Mouawad wrote:
>>>
 Hello,
 Done:9046713

 Regards

 On Thu, Jan 5, 2017 at 11:14 AM, Rory O'Donnell
 >> >
>>>
>>> wrote:

 Hi Philippe,
>
> Many happy returns!
>
> Can you log a bug and send us the Java Incident id ?
>
> Rgds,Rory
>
>
>
>
> On 05/01/2017 10:12, Philippe Mouawad wrote:
>
> Greetings,
>> First best wishes for 2017.
>>
>> I'd like to report what seems to be a critical bug we face in JMeter
>> . I noticed it under Mac OSX El Capitan.
>>
>> Calling javax.swing.JEditorPane.setText() from AWT Thread with some
>> long text (without spaces) leads to what seems to be either a very
>> long or infinite loop, I made thread dumps and I have always  such
>> (partial)
>> stacktrace:
>> "AWT-EventQueue-0" #20 prio=6 os_prio=31 tid=0x7fa7a8afc000
>> nid=0xf707 runnable [0x72202000]
>>   java.lang.Thread.State: RUNNABLE
>>at sun.font.CStrike.getNativeGlyphOutline(Native Method)
>>at sun.font.CStrike.getGlyphOutline(CStrike.java:215)
>>at sun.font.CStrike.getGlyphOutlineBounds(CStrike.java:177)
>>at
>> sun.font.StandardGlyphVector$GlyphStrike.getGlyphOutlineBoun
>> ds(StandardGlyphVector.java:1792)
>>at
>> sun.font.StandardGlyphVector.getGlyphOutlineBounds(StandardG
>> lyphVector.java:1174)
>>at
>> sun.font.StandardGlyphVector.getGlyphVisualBounds(StandardGl
>> yphVector.java:586)
>>at
>> sun.font.StandardGlyphVector.getGlyphInfo(
>>
> StandardGlyphVector.java:864)
>>>
at
>>

Re: Release a 3.2

2017-02-28 Thread Philippe Mouawad 
Hello,
We're now at:

   - 48 Enhancements
   - 31 bug fixes

Sebb has fixed Windows failures on Jenkins

   - Ensure the migrated docs (from PDF) do not contain old "Urban legends"
   :-) nor bad practices. Those are the 4 Tutorial links in left menu. It
   would be nice to review them. I've fixed some but not done the full work

TODO

   - Fill in introduced properties in properties_reference.xml

DONE

   - If possible add JUnits on the regression introduced in GET with no
   body (see my mail)

DONE

   - Fill in New and Noteworthy section

TODO


Are you ok to start a release soon ?

Thanks

Regards

On Tue, Feb 21, 2017 at 4:21 PM, sebb  wrote:

> I'm seeing some test failures on Windows.
>
> I've started to set up a Jenkins build to be able to catch these.
> (at present the failure mails are sent direct to me)
>
> Depending on the cause, the failures need to be fixed before the next
> release.
>
> On 11 February 2017 at 10:22, Philippe Mouawad
>  wrote:
> > Hello,
> > Since our discussion on "Release a 3.2 ?" , trunk has nicely evolved:
> >
> >- 33 Enhancements
> >- 25 bug fixes
> >
> > I think we can now plan a release.
> >
> > I see the following remaining work:
> >
> >- Ensure the migrated docs (from PDF) do not contain old "Urban
> legends"
> >:-) nor bad practices. Those are the 4 Tutorial links in left menu. It
> >would be nice to review them. I've fixed some but not done the full
> work
> >- Fill in introduced properties in properties_reference.xml
> >- If possible add JUnits on the regression introduced in GET with no
> >body (see my mail)
> >- Fill in New and Noteworthy section
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>



-- 
Cordialement.
Philippe Mouawad.

HTTP Request : What to do with the Parameters tab entries for every method (was HTTP Request : Behaviour of PUT)

2017-02-28 Thread Philippe Mouawad 
Hello,
As per sebb will, I open a new discussion to decide:
1) what to do for each method
2) Which one takes precedence

Regards
Philippe

Jenkins build is back to normal : JMeter-trunk #5963

2017-02-28 Thread Apache Jenkins Server 
See

Re: svn commit: r1784727 - /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java

2017-02-28 Thread sebb 
On 28 February 2017 at 11:34,   wrote:
> Author: pmouawad
> Date: Tue Feb 28 11:34:16 2017
> New Revision: 1784727
>
> URL: http://svn.apache.org/viewvc?rev=1784727=rev
> Log:
> Avoid repetitive calls to getMethod

OK

> Decrease log level from WARN to DEBUG for some components supersed

Why?

The idea of the log message is to warn users that the Auth Manager may
have been inadvertently overridden.

-1 without a good reason why this warning is not needed.

> Modified:
> 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>
> Modified: 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
> URL: 
> http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1784727=1784726=1784727=diff
> ==
> --- 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>  (original)
> +++ 
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
>  Tue Feb 28 11:34:16 2017
> @@ -452,7 +452,8 @@ public abstract class HTTPSamplerBase ex
>   */
>  public void setPath(String path, String contentEncoding) {
>  boolean fullUrl = path.startsWith(HTTP_PREFIX) || 
> path.startsWith(HTTPS_PREFIX);
> -boolean getOrDelete = HTTPConstants.GET.equals(getMethod()) || 
> HTTPConstants.DELETE.equals(getMethod());
> +String method = getMethod();
> +boolean getOrDelete = HTTPConstants.GET.equals(method) || 
> HTTPConstants.DELETE.equals(method);
>  if (!fullUrl && getOrDelete) {
>  int index = path.indexOf(QRY_PFX);
>  if (index > -1) {
> @@ -825,7 +826,9 @@ public abstract class HTTPSamplerBase ex
>  public void setAuthManager(AuthManager value) {
>  AuthManager mgr = getAuthManager();
>  if (mgr != null) {
> -log.warn("Existing AuthManager " + mgr.getName() + " superseded 
> by " + value.getName());
> +if(log.isDebugEnabled()) {
> +log.debug("Existing AuthManager {} superseded by {}", 
> mgr.getName(), value.getName());
> +}
>  }
>  setProperty(new TestElementProperty(AUTH_MANAGER, value));
>  }
> @@ -861,7 +864,9 @@ public abstract class HTTPSamplerBase ex
>  public void setCookieManager(CookieManager value) {
>  CookieManager mgr = getCookieManager();
>  if (mgr != null) {
> -log.warn("Existing CookieManager " + mgr.getName() + " 
> superseded by " + value.getName());
> +if(log.isDebugEnabled()) {
> +log.debug("Existing CookieManager {} superseded by {}", 
> mgr.getName(), value.getName());
> +}
>  }
>  setCookieManagerProperty(value);
>  }
> @@ -878,7 +883,9 @@ public abstract class HTTPSamplerBase ex
>  public void setCacheManager(CacheManager value) {
>  CacheManager mgr = getCacheManager();
>  if (mgr != null) {
> -log.warn("Existing CacheManager " + mgr.getName() + " superseded 
> by " + value.getName());
> +if(log.isDebugEnabled()) {
> +log.debug("Existing CacheManager {} superseded by {}", 
> mgr.getName(), value.getName());
> +}
>  }
>  setCacheManagerProperty(value);
>  }
> @@ -894,7 +901,9 @@ public abstract class HTTPSamplerBase ex
>  public void setDNSResolver(DNSCacheManager cacheManager) {
>  DNSCacheManager mgr = getDNSResolver();
>  if (mgr != null) {
> -log.warn("Existing DNSCacheManager " + mgr.getName() + " 
> superseded by " + cacheManager.getName());
> +if(log.isDebugEnabled()) {
> +log.debug("Existing DNSCacheManager {} superseded by {}", 
> mgr.getName(), cacheManager.getName());
> +}
>  }
>  setProperty(new TestElementProperty(DNS_CACHE_MANAGER, 
> cacheManager));
>  }
> @@ -964,6 +973,7 @@ public abstract class HTTPSamplerBase ex
>  }
>  String domain = getDomain();
>  String protocol = getProtocol();
> +String method = getMethod();
>  if (PROTOCOL_FILE.equalsIgnoreCase(protocol)) {
>  domain = null; // allow use of relative file URLs
>  } else {
> @@ -975,9 +985,9 @@ public abstract class HTTPSamplerBase ex
>  pathAndQuery.append(path);
>
>  // Add the query string if it is a HTTP GET or DELETE request
> -if (HTTPConstants.GET.equals(getMethod())
> -|| HTTPConstants.DELETE.equals(getMethod())
> -|| HTTPConstants.OPTIONS.equals(getMethod())) {
> +if (HTTPConstants.GET.equals(method)
> +|| HTTPConstants.DELETE.equals(method)
> +|| HTTPConstants.OPTIONS.equals(method)) {
>  // Get the query string

Re: HTTP Request : Behaviour of PUT

2017-02-28 Thread sebb 
On 28 February 2017 at 12:11, Philippe Mouawad
 wrote:
> Hello,
> It seems other method are also concerned.
> Except for POST, do you think all methods should put in URL the parameters
> in table ?

The problem with PUT is that it does nothing with the Parameters tab entries.

Whether it should append them to the URL or send them as body text is
another discussion.

Also whether parameters are allowed in both places, and if so, which
takes precedence.

> Regards
>
> On Mon, Feb 27, 2017 at 11:37 PM, Philippe Mouawad <
> philippe.moua...@gmail.com> wrote:
>
>> Ok, I have a fix then.
>> I'll commit it.
>>
>> On Mon, Feb 27, 2017 at 11:33 PM, sebb  wrote:
>>
>>> PUT seems to ignore the Parameters tab entirely.
>>>
>>> That does not seem right.
>>>
>>> Get appends any Parameters to the URL.
>>>
>>> On 27 February 2017 at 22:22, Philippe Mouawad
>>>  wrote:
>>> > Hello,
>>> > Currently when you set this in HTTP REquest:
>>> >
>>> > Method : PUT
>>> > Path: /test?name0=value0
>>> > Send Parameters with Request : name1 in Name: column / value1 in Value
>>> >
>>> > JMeter emits :
>>> > PUT http://localhost:8081/test?name0=value0
>>> >
>>> > Ignoring Send Parameters with Request content.
>>> >
>>> > Is this regular ?
>>> >
>>> > --
>>> > Cordialement.
>>> > Philippe Mouawad.
>>>
>>
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>>
>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.

[GitHub] jmeter issue #277: Bug 58506 - JMS Point-to-point sampler should offer an as...

2017-02-28 Thread pmouawad 
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/277
  
Hello,
Thank you for your contribution.
My notes:
- The class ExtendedQueueRequestor seems to come from existing code as per 
"This source code implements specifications defined by the Java Community 
Process." Are you the author of this code or not ? If not what is the license 
of this code ?
- The code lacks javadoc for  ExtendedQueueRequestor
- TemporaryQueueExecutor is not used anymore, it should be deprecated
- The ExtendedQueueRequestor needs to be unit tested. Since we've setup 
Sonar on repository, we try to increase test coverage either with JUnit code or 
Test Plan that allows testing results. This code should be unit tested using 
mocks I think

Regards


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: JMeter-trunk #5962

2017-02-28 Thread Apache Jenkins Server 
See 

--
[...truncated 393.84 KB...]
_check_exists:

_check_jarfile:
 [echo] Checking velocity-1.7.jar
 [echo] Deleting velocity-* (excluding velocity-1.7.jar)

_get_jarfile:
 [echo] Fetching: lib/doc/velocity-1.7.jar
  [get] Getting: 
https://repo1.maven.org/maven2/org/apache/velocity/velocity/1.7/velocity-1.7.jar
  [get] To: 


_checkMD5:
 [echo] Checksum OK: velocity-1.7.jar
 [move] Moving 1 file to 

 [move] Attempting to rename: 
 to 


_get_zipfile:

_check_exists:

_check_jarfile:
 [echo] Checking commons-lang-2.6.jar
 [echo] Deleting commons-lang-* (excluding commons-lang-2.6.jar)

_get_jarfile:
 [echo] Fetching: lib/doc/commons-lang-2.6.jar
  [get] Getting: 
https://repo1.maven.org/maven2/commons-lang/commons-lang/2.6/commons-lang-2.6.jar
  [get] To: 


_checkMD5:
 [echo] Checksum OK: commons-lang-2.6.jar
 [move] Moving 1 file to 

 [move] Attempting to rename: 

 to 


_get_zipfile:

_check_exists:

_check_jarfile:
 [echo] Checking xalan-2.7.2.jar
 [echo] Deleting xalan-* (excluding xalan-2.7.2.jar)

_get_jarfile:
 [echo] Fetching: lib/xalan-2.7.2.jar
  [get] Getting: 
https://repo1.maven.org/maven2/xalan/xalan/2.7.2/xalan-2.7.2.jar
  [get] To: 


_checkMD5:
 [echo] Checksum OK: xalan-2.7.2.jar
 [move] Moving 1 file to 

 [move] Attempting to rename: 
 to 


_get_zipfile:

_check_exists:

_check_jarfile:
 [echo] Checking xercesImpl-2.11.0.jar
 [echo] Deleting xercesImpl-* (excluding xercesImpl-2.11.0.jar)

_get_jarfile:
 [echo] Fetching: lib/xercesImpl-2.11.0.jar
  [get] Getting: 
https://repo1.maven.org/maven2/xerces/xercesImpl/2.11.0/xercesImpl-2.11.0.jar
  [get] To: 


_checkMD5:
 [echo] Checksum OK: xercesImpl-2.11.0.jar
 [move] Moving 1 file to 

 [move] Attempting to rename: 

 to 


_get_zipfile:

_check_exists:

_check_jarfile:
 [echo] Checking xml-apis-1.4.01.jar
 [echo] Deleting xml-apis-* (excluding xml-apis-1.4.01.jar)

_get_jarfile:
 [echo] Fetching: lib/xml-apis-1.4.01.jar
  [get] Getting: 
https://repo1.maven.org/maven2/xml-apis/xml-apis/1.4.01/xml-apis-1.4.01.jar
  [get] To: 


_checkMD5:
 [echo] Checksum OK: xml-apis-1.4.01.jar
 [move] Moving 1 file to 

 [move] Attempting to rename: 
 
to 

_get_zipfile:

_check_exists:

_check_jarfile:
 [echo] Checking xmlgraphics-commons-2.1.jar
 [echo] Deleting xmlgraphics-commons-* (excluding 
xmlgraphics-commons-2.1.jar)

_get_jarfile:
 [echo] Fetching: lib/xmlgraphics-commons-2.1.jar
  [get] Getting: 
https://repo1.maven.org/maven2/org/apache/xmlgraphics/xmlgraphics-commons/2.1/xmlgraphics-commons-2.1.jar
  [get] To: 


_checkMD5:
 [echo] Checksum OK: xmlgraphics-commons-2.1.jar
 [move] Moving 1 file to 

 [move] Attempting to rename: 

 to 


_get_zipfile:

_check_exists:

_check_jarfile:
 [echo] Checking xmlpull-1.1.3.1.jar
 [echo] Deleting xmlpull-* (excluding xmlpull-1.1.3.1.jar)

_get_jarfile:
 [echo] Fetching: lib/xmlpull-1.1.3.1.jar
  [get] Getting:

Re: HTTP Request : Behaviour of PUT

2017-02-28 Thread Philippe Mouawad 
Hello,
It seems other method are also concerned.
Except for POST, do you think all methods should put in URL the parameters
in table ?

Regards

On Mon, Feb 27, 2017 at 11:37 PM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> Ok, I have a fix then.
> I'll commit it.
>
> On Mon, Feb 27, 2017 at 11:33 PM, sebb  wrote:
>
>> PUT seems to ignore the Parameters tab entirely.
>>
>> That does not seem right.
>>
>> Get appends any Parameters to the URL.
>>
>> On 27 February 2017 at 22:22, Philippe Mouawad
>>  wrote:
>> > Hello,
>> > Currently when you set this in HTTP REquest:
>> >
>> > Method : PUT
>> > Path: /test?name0=value0
>> > Send Parameters with Request : name1 in Name: column / value1 in Value
>> >
>> > JMeter emits :
>> > PUT http://localhost:8081/test?name0=value0
>> >
>> > Ignoring Send Parameters with Request content.
>> >
>> > Is this regular ?
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>


-- 
Cordialement.
Philippe Mouawad.

[GitHub] jmeter issue #277: Bug 58506 - JMS Point-to-point sampler should offer an as...

2017-02-28 Thread mgashraf 
Github user mgashraf commented on the issue:

https://github.com/apache/jmeter/pull/277
  
Hello @pmouawad,
Could you please review the changes. We need to have this functionality as 
part of our project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---