[GitHub] jmeter pull request #316: Warn empty truststore loading like empty keystore ...

2017-10-11 Thread vherilier 
GitHub user vherilier opened a pull request:

https://github.com/apache/jmeter/pull/316

Warn empty truststore loading like empty keystore loading

Hi,

I noticed in the SSLManager that JMeter informs about not founding a 
truststore and loading an empty one instead but for the keystore it is a 
warning.
IMHO, it could be great to warn both events, they become more visible.

I hope this PR will help.

BR,
--Vincent

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vherilier/jmeter sslmanager_warning

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/316.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #316


commit 3540e76c9302eea20af1e85c31ea34e4753e341d
Author: Vincent Herilier 
Date:   2017-10-05T09:59:54Z

Warn empty truststore loading like empty keystore loading




---

Re: Bug 60190 - Content-Type is added for POST unconditionally

2017-10-11 Thread Philippe Mouawad 
Hello
Any feedback on this ?
Thanks

On Fri, Sep 8, 2017 at 2:12 PM, Philippe Mouawad <
p.moua...@ubik-ingenierie.com> wrote:

> Hello,
> How about not adding this anymore if not set and having a property that
> allows to do that ?
>
>- post_add_content_type_if_missing=false
>
>
> What is the risk ?
>
> As per:
>
>- https://www.w3.org/Protocols/rfc2616/rfc2616-sec7.html
>
> Any HTTP/1.1 message containing an entity-body SHOULD include a
> Content-Type header field defining the media type of that body. If and only
> if the media type is not given by a Content-Type field, the recipient MAY
> attempt to guess the media type via inspection of its content and/or the
> name extension(s) of the URI used to identify the resource. If the media
> type remains unknown, the recipient SHOULD treat it as type
> "application/octet-stream".
>
>
> --
> Regards.
> Philippe
>
>
>


-- 
Cordialement.
Philippe Mouawad.
Ubik-Ingénierie

UBIK LOAD PACK Web Site 

UBIK LOAD PACK on TWITTER

Re: Migration to HC4/HC5 last version

2017-10-11 Thread Philippe Mouawad 
Hello Team,
Pinging again in case somebody can help.
Regards


On Mon, Oct 9, 2017 at 11:19 PM, Philippe Mouawad 
wrote:

> Hello,
> Within JMeter projet I am working on migration fully to last APIs of
> HttpClient:
>
>- https://bz.apache.org/bugzilla/show_bug.cgi?id=58757
>
> You can see current code here:
>
>- https://github.com/ubikloadpack/jmeter/tree/HC4_FULL_MIGRATION
>
> I have nearly completed the work except for 2 remaining items:
>
>- Virtual Host:
>   - I don't see this parameter in newer interfaces
>  - https://github.com/apache/jmeter/blob/trunk/src/
>  protocol/http/org/apache/jmeter/protocol/http/sampler/
>  HTTPHC4Impl.java#L1117
>  
> 
>
>
>- "Slow " connection feature:
>   - This feature allows to simulate slow connection. Currently we
>   wrap Input/Output stream returned by socket with SlowInputStream/
>   SlowOutputStream
>   - https://github.com/apache/jmeter/blob/trunk/src/
>  protocol/http/org/apache/jmeter/protocol/http/util/
>  SlowHC4SocketFactory.java
>  
> 
>  - https://github.com/apache/jmeter/blob/trunk/src/
>  protocol/http/org/apache/jmeter/protocol/http/sampler/
>  HTTPHC4Impl.java#L322
>  
> 
>  - https://github.com/apache/jmeter/blob/trunk/src/
>  protocol/http/org/apache/jmeter/protocol/http/sampler/
>  HTTPHC4Impl.java#L892
>  
> 
>   - It is not clear for me how this feature should be implemented:
>  - Should we adapt SSLSocket and Socket with a Slow feature ?
>
>
> Hope you can help by pointing me to the components.
>
> Thanks
>
> Regards
>
> Philippe M.
>
> @philmdot
>

[GitHub] jmeter pull request #316: Warn empty truststore loading like empty keystore ...

2017-10-11 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/316


---

[GitHub] jmeter issue #313: BZ61466: Comment addition to SampleResults

2017-10-11 Thread pmouawad 
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/313
  
Thanks @vherilier  for your update, it looks good to me.

May I ask one last thing, there is no documentation nor illustration of how 
this feature can be used.
So if we want this feature to be popular there should be some sexy use case 
showing an example integration with some screenshot.
Thanks




---

Build failed in Jenkins: JMeter-trunk #6340

2017-10-11 Thread Apache Jenkins Server 
See 


Changes:

[pmouawad] Warn empty truststore loading like empty keystore loading
Contributed by Vincent Herilier
This closes #316

--
[...truncated 488.87 KB...]
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.modifier.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.parser...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.proxy...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.proxy.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.sampler.hc...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.util...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.util.accesslog...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.visualizers...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ftp.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ftp.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ftp.sampler...
  [javadoc] Loading source files for package org.apache.jmeter.protocol.jdbc...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jdbc.config...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jdbc.processor...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jdbc.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.config...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.test...
  [javadoc] Loading source files for package org.apache.jorphan.collections...
  [javadoc] Loading source files for package org.apache.jorphan.exec...
  [javadoc] Loading source files for package org.apache.jorphan.gui...
  [javadoc] Loading source files for package org.apache.jorphan.gui.layout...
  [javadoc] Loading source files for package org.apache.jorphan.io...
  [javadoc] Loading source files for package org.apache.jorphan.logging...
  [javadoc] Loading source files for package org.apache.jorphan.math...
  [javadoc] Loading source files for package org.apache.jorphan.reflect...
  [javadoc] Loading source files for package org.apache.jorphan.test...
  [javadoc] Loading source files for package org.apache.jorphan.util...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ldap.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ldap.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ldap.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.tcp.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.tcp.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.tcp.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.examples.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.examples.sampler.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.examples.testbeans.example1...
  [javadoc] Loading source files for package 
org.apache.jmeter.examples.testbeans.example2...
  [javadoc] Loading source files for package 
org.apache.jmeter.examples.testbeans.example3...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.mail.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.mail.sampler.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.smtp.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.smtp.sampler.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.smtp.sampler.protocol...
  [javadoc] Loading source files for package org.apache.jmeter.protocol.jms...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jms.client...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jms.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jms.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jms.sampler.render...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.system...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.system.gui...
  [javadoc] Loading

Jenkins build is back to normal : JMeter-trunk #6341

2017-10-11 Thread Apache Jenkins Server 
See