Re: Usage of $(...) instead of `...` in shell scripts

2017-11-06 Thread sebb 
On 6 November 2017 at 18:20, Felix Schumacher
 wrote:
>
>
> Am 6. November 2017 19:04:41 MEZ schrieb sebb :
>>The $() syntax is newer than the command files.
>>i.e. it was not available when they were written.
>
> That's probably true. To be more specific: I would like to know, whether it 
> is safe to change it.
>
> Do you know of any system, that has a default shell, that is not able to 
> process $(..)?

If there is any doubt, just leave it alone.

It's not broken, so don't try to fix it ...

> Regards,
> Felix
>
>>
>>On 4 November 2017 at 22:58, Philippe Mouawad
>> wrote:
>>> No idea why it’s like this
>>>
>>> On Saturday, November 4, 2017, Felix Schumacher <
>>> felix.schumac...@internetallee.de> wrote:
>>>
 Hi all,

 we have both forms of execution commands in our shell scripts.

 $(...) is the more modern form and should be preferred over `...` as
 explained on https://github.com/koalaman/shellcheck/wiki/SC2006

 Does anyone know, if there is a reason for using the old form `...`
>>in
 our scripts?

 Regards,
  Felix

>>>
>>>
>>> --
>>> Cordialement.
>>> Philippe Mouawad.

Re: svn commit: r1814345 - /jmeter/trunk/bin/jmeter

2017-11-06 Thread Felix Schumacher 


Am 6. November 2017 19:01:42 MEZ schrieb sebb :
>Why are we still using this fragile check at all?
>
>For most users the check is just a waste of time.
>
>Let's drop the check entirely.
>
>If the Java command exits with a non-zero status, then just print a
>message to say what the following error means:
>
>Exception in thread "main" java.lang.UnsupportedClassVersionError:
>org/apache/jmeter/NewDriver : Unsupported major.minor version 52.0

Right, we discussed this earlier. And I would like to drop it, too

The problem here is, that Java 9 needs a special parameter. :(

Regards, 
Felix 
>
>
>On 5 November 2017 at 10:56, Felix Schumacher
> wrote:
>>
>>
>> Am 5. November 2017 11:26:32 MEZ schrieb Philippe Mouawad
>:
>>>Hi Felix,
>>>Are there the same number problems on windows jmeter.bat ?
>>
>> Having no windows at hand and not being a windows guy, I really don't
>know.
>>
>> Felix
>>
>>>
>>>Thanks
>>>
>>>On Sunday, November 5, 2017,  wrote:
>>>
 Author: fschumacher
 Date: Sun Nov  5 09:59:48 2017
 New Revision: 1814345

 URL: http://svn.apache.org/viewvc?rev=1814345=rev
 Log:
 Use the same binary for version detection as the one we start.

 Bugzilla Id: 61529

 Modified:
 jmeter/trunk/bin/jmeter

 Modified: jmeter/trunk/bin/jmeter
 URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter?rev=
 1814345=1814344=1814345=diff
 
 ==
 --- jmeter/trunk/bin/jmeter (original)
 +++ jmeter/trunk/bin/jmeter Sun Nov  5 09:59:48 2017
 @@ -69,9 +69,8 @@ ADD_MODS=
  # Minimal version to run JMeter
  MINIMAL_VERSION=8

 -_java=`type java | awk '{ print $ NF }'`
  # Check if version is from OpenJDK or Oracle Hotspot JVM prior to
>9
 containing 1.${version}.x
 -CURRENT_VERSION=`"$_java" -version 2>&1 | awk -F'"' '/version/
 {gsub("^1[.]", "", $2); gsub("[^0-9].*$", "", $2); print $2}'`
 +CURRENT_VERSION=`"${JAVA_HOME}/bin/java" -version 2>&1 | awk -F'"'
 '/version/ {gsub("^1[.]", "", $2); gsub("[^0-9].*$", "", $2); print
>>>$2}'`

  # Check if Java is present and the minimal version requirement
  if [ "$CURRENT_VERSION" -gt "$MINIMAL_VERSION" ]; then

Re: Usage of $(...) instead of `...` in shell scripts

2017-11-06 Thread Felix Schumacher 


Am 6. November 2017 19:04:41 MEZ schrieb sebb :
>The $() syntax is newer than the command files.
>i.e. it was not available when they were written.

That's probably true. To be more specific: I would like to know, whether it is 
safe to change it. 

Do you know of any system, that has a default shell, that is not able to 
process $(..)? 

Regards, 
Felix 

>
>On 4 November 2017 at 22:58, Philippe Mouawad
> wrote:
>> No idea why it’s like this
>>
>> On Saturday, November 4, 2017, Felix Schumacher <
>> felix.schumac...@internetallee.de> wrote:
>>
>>> Hi all,
>>>
>>> we have both forms of execution commands in our shell scripts.
>>>
>>> $(...) is the more modern form and should be preferred over `...` as
>>> explained on https://github.com/koalaman/shellcheck/wiki/SC2006
>>>
>>> Does anyone know, if there is a reason for using the old form `...`
>in
>>> our scripts?
>>>
>>> Regards,
>>>  Felix
>>>
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.

Re: svn commit: r1814345 - /jmeter/trunk/bin/jmeter

2017-11-06 Thread Philippe Mouawad 
We have to check for java9 to add command line parameters

On Monday, November 6, 2017, sebb  wrote:

> Why are we still using this fragile check at all?
>
> For most users the check is just a waste of time.
>
> Let's drop the check entirely.
>
> If the Java command exits with a non-zero status, then just print a
> message to say what the following error means:
>
> Exception in thread "main" java.lang.UnsupportedClassVersionError:
> org/apache/jmeter/NewDriver : Unsupported major.minor version 52.0
>
>
> On 5 November 2017 at 10:56, Felix Schumacher
> > wrote:
> >
> >
> > Am 5. November 2017 11:26:32 MEZ schrieb Philippe Mouawad <
> philippe.moua...@gmail.com >:
> >>Hi Felix,
> >>Are there the same number problems on windows jmeter.bat ?
> >
> > Having no windows at hand and not being a windows guy, I really don't
> know.
> >
> > Felix
> >
> >>
> >>Thanks
> >>
> >>On Sunday, November 5, 2017, >
> wrote:
> >>
> >>> Author: fschumacher
> >>> Date: Sun Nov  5 09:59:48 2017
> >>> New Revision: 1814345
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=1814345=rev
> >>> Log:
> >>> Use the same binary for version detection as the one we start.
> >>>
> >>> Bugzilla Id: 61529
> >>>
> >>> Modified:
> >>> jmeter/trunk/bin/jmeter
> >>>
> >>> Modified: jmeter/trunk/bin/jmeter
> >>> URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter?rev=
> >>> 1814345=1814344=1814345=diff
> >>> 
> >>> ==
> >>> --- jmeter/trunk/bin/jmeter (original)
> >>> +++ jmeter/trunk/bin/jmeter Sun Nov  5 09:59:48 2017
> >>> @@ -69,9 +69,8 @@ ADD_MODS=
> >>>  # Minimal version to run JMeter
> >>>  MINIMAL_VERSION=8
> >>>
> >>> -_java=`type java | awk '{ print $ NF }'`
> >>>  # Check if version is from OpenJDK or Oracle Hotspot JVM prior to 9
> >>> containing 1.${version}.x
> >>> -CURRENT_VERSION=`"$_java" -version 2>&1 | awk -F'"' '/version/
> >>> {gsub("^1[.]", "", $2); gsub("[^0-9].*$", "", $2); print $2}'`
> >>> +CURRENT_VERSION=`"${JAVA_HOME}/bin/java" -version 2>&1 | awk -F'"'
> >>> '/version/ {gsub("^1[.]", "", $2); gsub("[^0-9].*$", "", $2); print
> >>$2}'`
> >>>
> >>>  # Check if Java is present and the minimal version requirement
> >>>  if [ "$CURRENT_VERSION" -gt "$MINIMAL_VERSION" ]; then
> >>>
> >>>
> >>>
>


-- 
Cordialement.
Philippe Mouawad.

Re: Usage of $(...) instead of `...` in shell scripts

2017-11-06 Thread sebb 
The $() syntax is newer than the command files.
i.e. it was not available when they were written.

On 4 November 2017 at 22:58, Philippe Mouawad
 wrote:
> No idea why it’s like this
>
> On Saturday, November 4, 2017, Felix Schumacher <
> felix.schumac...@internetallee.de> wrote:
>
>> Hi all,
>>
>> we have both forms of execution commands in our shell scripts.
>>
>> $(...) is the more modern form and should be preferred over `...` as
>> explained on https://github.com/koalaman/shellcheck/wiki/SC2006
>>
>> Does anyone know, if there is a reason for using the old form `...` in
>> our scripts?
>>
>> Regards,
>>  Felix
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.

Re: svn commit: r1814345 - /jmeter/trunk/bin/jmeter

2017-11-06 Thread sebb 
Why are we still using this fragile check at all?

For most users the check is just a waste of time.

Let's drop the check entirely.

If the Java command exits with a non-zero status, then just print a
message to say what the following error means:

Exception in thread "main" java.lang.UnsupportedClassVersionError:
org/apache/jmeter/NewDriver : Unsupported major.minor version 52.0


On 5 November 2017 at 10:56, Felix Schumacher
 wrote:
>
>
> Am 5. November 2017 11:26:32 MEZ schrieb Philippe Mouawad 
> :
>>Hi Felix,
>>Are there the same number problems on windows jmeter.bat ?
>
> Having no windows at hand and not being a windows guy, I really don't know.
>
> Felix
>
>>
>>Thanks
>>
>>On Sunday, November 5, 2017,  wrote:
>>
>>> Author: fschumacher
>>> Date: Sun Nov  5 09:59:48 2017
>>> New Revision: 1814345
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1814345=rev
>>> Log:
>>> Use the same binary for version detection as the one we start.
>>>
>>> Bugzilla Id: 61529
>>>
>>> Modified:
>>> jmeter/trunk/bin/jmeter
>>>
>>> Modified: jmeter/trunk/bin/jmeter
>>> URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter?rev=
>>> 1814345=1814344=1814345=diff
>>> 
>>> ==
>>> --- jmeter/trunk/bin/jmeter (original)
>>> +++ jmeter/trunk/bin/jmeter Sun Nov  5 09:59:48 2017
>>> @@ -69,9 +69,8 @@ ADD_MODS=
>>>  # Minimal version to run JMeter
>>>  MINIMAL_VERSION=8
>>>
>>> -_java=`type java | awk '{ print $ NF }'`
>>>  # Check if version is from OpenJDK or Oracle Hotspot JVM prior to 9
>>> containing 1.${version}.x
>>> -CURRENT_VERSION=`"$_java" -version 2>&1 | awk -F'"' '/version/
>>> {gsub("^1[.]", "", $2); gsub("[^0-9].*$", "", $2); print $2}'`
>>> +CURRENT_VERSION=`"${JAVA_HOME}/bin/java" -version 2>&1 | awk -F'"'
>>> '/version/ {gsub("^1[.]", "", $2); gsub("[^0-9].*$", "", $2); print
>>$2}'`
>>>
>>>  # Check if Java is present and the minimal version requirement
>>>  if [ "$CURRENT_VERSION" -gt "$MINIMAL_VERSION" ]; then
>>>
>>>
>>>

[GitHub] jmeter issue #321: [Influxdb] Allow users to add theirs owns tags

2017-11-06 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/321
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/321?src=pr=h1) 
Report
> Merging 
[#321](https://codecov.io/gh/apache/jmeter/pull/321?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/b0f89d7e402407e2d09bd22ddd994f4a85caede3?src=pr=desc)
 will **decrease** coverage by `0.01%`.
> The diff coverage is `38.09%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/321/graphs/tree.svg?width=650=150=pr=6Q7CI1wFSh)](https://codecov.io/gh/apache/jmeter/pull/321?src=pr=tree)

```diff
@@ Coverage Diff  @@
##  trunk #321  +/-   ##

- Coverage 57.73%   57.71%   -0.02% 
+ Complexity 9892 9890   -2 

  Files  1136 1136  
  Lines 7291372938  +25 
  Branches   7300 7300  

+ Hits  4209542098   +3 
- Misses2834728370  +23 
+ Partials   2471 2470   -1
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/321?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...ackend/influxdb/InfluxdbBackendListenerClient.java](https://codecov.io/gh/apache/jmeter/pull/321?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvYmFja2VuZC9pbmZsdXhkYi9JbmZsdXhkYkJhY2tlbmRMaXN0ZW5lckNsaWVudC5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| 
[...jmeter/visualizers/backend/BackendListenerGui.java](https://codecov.io/gh/apache/jmeter/pull/321?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvYmFja2VuZC9CYWNrZW5kTGlzdGVuZXJHdWkuamF2YQ==)
 | `79.81% <80%> (+0.43%)` | `13 <0> (ø)` | :arrow_down: |
| 
[...mpler/hc/JMeterPoolingClientConnectionManager.java](https://codecov.io/gh/apache/jmeter/pull/321?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL0pNZXRlclBvb2xpbmdDbGllbnRDb25uZWN0aW9uTWFuYWdlci5qYXZh)
 | `27.77% <0%> (-3.18%)` | `10% <0%> (-1%)` | |
| 
[...ocol/jms/org/apache/jmeter/protocol/jms/Utils.java](https://codecov.io/gh/apache/jmeter/pull/321?src=pr=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvVXRpbHMuamF2YQ==)
 | `56.98% <0%> (-2.16%)` | `15% <0%> (ø)` | |
| 
[...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/321?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==)
 | `85.38% <0%> (-0.77%)` | `18% <0%> (-1%)` | |
| 
[...apache/jmeter/extractor/TestBoundaryExtractor.java](https://codecov.io/gh/apache/jmeter/pull/321?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL1Rlc3RCb3VuZGFyeUV4dHJhY3Rvci5qYXZh)
 | `97.88% <0%> (ø)` | `17% <0%> (ø)` | :arrow_down: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/321?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/321?src=pr=footer). Last 
update 
[b0f89d7...44fb854](https://codecov.io/gh/apache/jmeter/pull/321?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter pull request #321: [Influxdb] Allow users to add theirs owns tags

2017-11-06 Thread pmouawad 
Github user pmouawad commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/321#discussion_r149132449
  
--- Diff: 
src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
 ---
@@ -318,6 +335,13 @@ public void setupTest(BackendListenerContext context) 
throws Exception {
 }
 }
 }
+// Check if more fields are filled ( corresponding to user tag )
+context.getParameterNamesIterator().forEachRemaining(name->{
+if ( !defaultArg.containsKey(name)) {
+TAG_USER += "," + 
AbstractInfluxdbMetricsSender.tagToStringValue(name.trim()) + "=" + 
AbstractInfluxdbMetricsSender.tagToStringValue(context.getParameter(name).trim());
--- End diff --

Add some logging here to debug in case of issue


---

[GitHub] jmeter pull request #321: [Influxdb] Allow users to add theirs owns tags

2017-11-06 Thread pmouawad 
Github user pmouawad commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/321#discussion_r149131377
  
--- Diff: 
src/components/org/apache/jmeter/visualizers/backend/BackendListenerGui.java ---
@@ -71,6 +72,10 @@
 
 /** A panel allowing the user to set arguments for this test. */
 private ArgumentsPanel argsPanel;
+
+/** The current className of the Backend listenenr **/
+private String className;
--- End diff --

This part does not seem to be related to this PR , it's probably here to 
avoid losing configuration when changing class. Would it be possible to make 
another PR ?


---

[GitHub] jmeter pull request #321: [Influxdb] Allow users to add theirs owns tags

2017-11-06 Thread pmouawad 
Github user pmouawad commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/321#discussion_r149132569
  
--- Diff: 
src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
 ---
@@ -92,6 +92,18 @@
 private static final int MAX_POOL_SIZE = 1;
 private static final String SEPARATOR = ";"; //$NON-NLS-1$
 private static final Object LOCK = new Object();
+private static Map defaultArg = new LinkedHashMap<>();
--- End diff --

Should be UPPER CASE


---

[GitHub] jmeter pull request #321: [Influxdb] Allow users to add theirs owns tags

2017-11-06 Thread pmouawad 
Github user pmouawad commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/321#discussion_r149131482
  
--- Diff: 
src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
 ---
@@ -105,7 +117,7 @@
 private String testTags;
 // Name of the application tested
 private String application = "";
-
+private String TAG_USER = "";
--- End diff --

Should be lower case or static final


---

[GitHub] jmeter pull request #321: [Influxdb] Allow users to add theirs owns tags

2017-11-06 Thread pmouawad 
Github user pmouawad commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/321#discussion_r149133328
  
--- Diff: 
src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
 ---
@@ -318,6 +335,13 @@ public void setupTest(BackendListenerContext context) 
throws Exception {
 }
 }
 }
+// Check if more fields are filled ( corresponding to user tag )
+context.getParameterNamesIterator().forEachRemaining(name->{
+if ( !defaultArg.containsKey(name)) {
+TAG_USER += "," + 
AbstractInfluxdbMetricsSender.tagToStringValue(name.trim()) + "=" + 
AbstractInfluxdbMetricsSender.tagToStringValue(context.getParameter(name).trim());
--- End diff --

Thanks for this PR. It would require more documentation as I find the usage 
a bit edgy. AFAIU you 'll enable user to add as many rows (key=value) which 
will be tags for Influx event.
Can't we have some meaningful prefix or something to avoid a conflict 
between a user tag and a real property of the InfluxdbBackendListenerClient ?


---

[GitHub] jmeter pull request #321: Allow users to add theirs owns tags

2017-11-06 Thread max3163 
GitHub user max3163 opened a pull request:

https://github.com/apache/jmeter/pull/321

Allow users to add theirs owns tags

This PR allow users to add ( from the parameters list ) theirs own tags to 
influxdb.
By example you can add the tag environnement with rct, qal, prd value ( or 
acceptance, live etc... ). In this way you can have multiple test in the same 
time on differents environnements without confuse datas in influxdb.


![image](https://user-images.githubusercontent.com/13835366/32451716-d766cea2-c317-11e7-8fa8-59e8059d3dbe.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/max3163/jmeter UsersTagsInfluxdb

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #321


commit 44fb85470aa5b2f15037ff9190380e60e206017b
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-11-06T16:19:41Z

Allow users to add theirs owns tags




---

[GitHub] jmeter issue #320: HTTPClient 4.5. migration to last APIs / Bugzilla 58757 &...

2017-11-06 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/320
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=h1) 
Report
> Merging 
[#320](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/b0f89d7e402407e2d09bd22ddd994f4a85caede3?src=pr=desc)
 will **decrease** coverage by `0.35%`.
> The diff coverage is `67.78%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/320/graphs/tree.svg?width=650=150=6Q7CI1wFSh=pr)](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=tree)

```diff
@@ Coverage Diff  @@
##  trunk #320  +/-   ##

- Coverage 57.73%   57.38%   -0.36% 
+ Complexity 9892 9811  -81 

  Files  1136 1139   +3 
  Lines 7291373011  +98 
  Branches   7300 7309   +9 

- Hits  4209541895 -200 
- Misses2834728663 +316 
+ Partials   2471 2453  -18
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...l/http/sampler/JMeterClientConnectionOperator.java](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL0pNZXRlckNsaWVudENvbm5lY3Rpb25PcGVyYXRvci5qYXZh)
 | `0% <ø> (-81.82%)` | `0 <0> (-2)` | |
| 
[.../jmeter/protocol/http/sampler/hc/HttpConnPool.java](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL0h0dHBDb25uUG9vbC5qYXZh)
 | `0% <ø> (-100%)` | `0 <0> (-3)` | |
| 
[...rotocol/http/util/HC4TrustAllSSLSocketFactory.java](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC91dGlsL0hDNFRydXN0QWxsU1NMU29ja2V0RmFjdG9yeS5qYXZh)
 | `0% <ø> (-63.64%)` | `0 <0> (-4)` | |
| 
[...l/http/sampler/hc/ManagedClientConnectionImpl.java](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL01hbmFnZWRDbGllbnRDb25uZWN0aW9uSW1wbC5qYXZh)
 | `0% <ø> (-43.78%)` | `0 <0> (-28)` | |
| 
[...jmeter/protocol/http/sampler/hc/HttpPoolEntry.java](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL0h0dHBQb29sRW50cnkuamF2YQ==)
 | `0% <ø> (-73.69%)` | `0 <0> (-8)` | |
| 
[...protocol/http/sampler/LazySchemeSocketFactory.java](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL0xhenlTY2hlbWVTb2NrZXRGYWN0b3J5LmphdmE=)
 | `0% <ø> (-66.67%)` | `0 <0> (-5)` | |
| 
[...mpler/hc/JMeterPoolingClientConnectionManager.java](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL0pNZXRlclBvb2xpbmdDbGllbnRDb25uZWN0aW9uTWFuYWdlci5qYXZh)
 | `0% <ø> (-30.96%)` | `0 <0> (-11)` | |
| 
[...ocol/http/sampler/HttpClientDefaultParameters.java](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL0h0dHBDbGllbnREZWZhdWx0UGFyYW1ldGVycy5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| 
[...meter/protocol/http/util/SlowHC4SocketFactory.java](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC91dGlsL1Nsb3dIQzRTb2NrZXRGYWN0b3J5LmphdmE=)
 | `0% <ø> (-80%)` | `0 <0> (-2)` | |
| 
[...tocol/http/sampler/MeasuringConnectionManager.java](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL01lYXN1cmluZ0Nvbm5lY3Rpb25NYW5hZ2VyLmphdmE=)
 | `0% <0%> (-64.39%)` | `0 <0> (-3)` | |
| ... and [27 
more](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=tree-more) | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=footer). Last 
update 
[b0f89d7...53e2934](https://codecov.io/gh/apache/jmeter/pull/320?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---