[GitHub] jmeter pull request #353: Re-wrote some existing tests in Spock

2017-12-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/353


---


[GitHub] jmeter pull request #353: Re-wrote some existing tests in Spock

2017-12-08 Thread ham1
GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/353

Re-wrote some existing tests in Spock

## Description
Re-wrote some existing tests in Spock:
* ThroughputControllerSpec
* MD5HexAssertionSpec
* RandomOrderControllerSpec
* org.apache.jmeter.engine.util.PackageSpec

plus some minor code tweaks.

## How Has This Been Tested?
`ant -Djava.awt.headless=true -Drmi_force_localhost=true 
-Dskip.bug52310=true -Dskip.test_https=true checkstyle clean test`

## Screenshots (if appropriate):

## Types of changes

- Dev enhancement

## Checklist:


- [x] My code follows the [code style][style-guide] of this project.
- [x] I have updated the documentation accordingly.

[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter more_spock_tests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/353.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #353


commit e9ab76884a90c8eaafb22e1d0fdd2fbdbe5e3947
Author: Graham Russell 
Date:   2017-11-27T19:02:54Z

Re-wrote some existing tests in Spock:
ThroughputControllerSpec
MD5HexAssertionSpec
RandomOrderControllerSpec
org.apache.jmeter.engine.util.PackageSpec

plus some minor code tweaks




---