subject:"Fix"

Fix

2017-11-05 Thread zhuhuan

Hi,
Fix "Cannot nest output folder 'jmeter/build/components' inside output folder 
'jmeter/build' when setting up eclipse

[PR] fix(Jmeter): fix a wrong method name [jmeter]

2024-08-10 Thread via GitHub



linvaux opened a new pull request, #6334:
URL: https://github.com/apache/jmeter/pull/6334

   update org.apache.jmeter.JMeter#startUdpDdaemon to 
org.apache.jmeter.JMeter#startUdpDaemon
   
   Closes 6325
   
   ## Description
   fix issue : https://github.com/apache/jmeter/issues/6325
   ## Motivation and Context
   When i read jmeter source code, i find this method name looks like  is 
misspelled ， so i create a issue and try to fix it
   
   ## How Has This Been Tested?
org.apache.jmeter.JMeter#startUdpDdaemon is a private static Method， so i 
could change it.
   
   ## Screenshots (if appropriate):
   
   ## Types of changes
   BugFix
   
   ## Checklist:
   - Run `./gradlew check`
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

BUG-49753 Fix

2012-01-10 Thread Mark Collin

I've implemented the enhancement BUG-49753 which is checked into github and
I have sent you a pull request here:

 

https://github.com/apache/jmeter/pull/2

 

Is there any chance of getting this added in?  It would be nice to get some
mavenised artefacts for JMeter building and eventually uploaded to the main
maven repo.


--
This message contains confidential information and is intended only for the 
individual named. If you are not the named addressee you should not 
disseminate, distribute or copy this e-mail. Please notify the sender 
immediately by e-mail if you have received this e-mail by mistake and delete 
this e-mail from your system. If you are not the intended recipient you are 
notified that disclosing, copying, distributing or taking any action in 
reliance on the contents of this information is strictly prohibited.

If you have received this email in error please notify 
postmas...@ardescosolutions.com

Re: BUG-49753 Fix

2012-01-10 Thread sebb

On 10 January 2012 11:19, Mark Collin  wrote:
> I've implemented the enhancement BUG-49753 which is checked into github and
> I have sent you a pull request here:
>
>
>
> https://github.com/apache/jmeter/pull/2
>
>
>
> Is there any chance of getting this added in?

Please can you attach the files to the Bugzilla issue?

Sorry, but we need that for tracking provenance.

> It would be nice to get some
> mavenised artefacts for JMeter building and eventually uploaded to the main
> maven repo.
>
>
> --
> This message contains confidential information and is intended only for the 
> individual named. If you are not the named addressee you should not 
> disseminate, distribute or copy this e-mail. Please notify the sender 
> immediately by e-mail if you have received this e-mail by mistake and delete 
> this e-mail from your system. If you are not the intended recipient you are 
> notified that disclosing, copying, distributing or taking any action in 
> reliance on the contents of this information is strictly prohibited.
>
> If you have received this email in error please notify 
> postmas...@ardescosolutions.com

RE: BUG-49753 Fix

2012-01-10 Thread Mark Collin

Added a patch file to the bug.

-Original Message-
From: sebb [mailto:seb...@gmail.com] 
Sent: 10 January 2012 13:51
To: dev@jmeter.apache.org
Subject: Re: BUG-49753 Fix

On 10 January 2012 11:19, Mark Collin  wrote:
> I've implemented the enhancement BUG-49753 which is checked into 
> github and I have sent you a pull request here:
>
>
>
> https://github.com/apache/jmeter/pull/2
>
>
>
> Is there any chance of getting this added in?

Please can you attach the files to the Bugzilla issue?

Sorry, but we need that for tracking provenance.

> It would be nice to get some
> mavenised artefacts for JMeter building and eventually uploaded to the 
> main maven repo.
>
>
> --
> This message contains confidential information and is intended only for
the individual named. If you are not the named addressee you should not
disseminate, distribute or copy this e-mail. Please notify the sender
immediately by e-mail if you have received this e-mail by mistake and delete
this e-mail from your system. If you are not the intended recipient you are
notified that disclosing, copying, distributing or taking any action in
reliance on the contents of this information is strictly prohibited.
>
> If you have received this email in error please notify 
> postmas...@ardescosolutions.com

--
This message contains confidential information and is intended only for the 
individual named. If you are not the named addressee you should not 
disseminate, distribute or copy this e-mail. Please notify the sender 
immediately by e-mail if you have received this e-mail by mistake and delete 
this e-mail from your system. If you are not the intended recipient you are 
notified that disclosing, copying, distributing or taking any action in 
reliance on the contents of this information is strictly prohibited.

If you have received this email in error please notify 
postmas...@ardescosolutions.com

RE: BUG-49753 Fix

2012-01-11 Thread Mark Collin

I've uploaded an archive as requested, I've updated it just now to pull in
three modules that were originally missed.

-Original Message-
From: Mark Collin [mailto:m...@ardescosolutions.com] 
Sent: 10 January 2012 20:59
To: dev@jmeter.apache.org
Subject: RE: BUG-49753 Fix

Added a patch file to the bug.

-Original Message-
From: sebb [mailto:seb...@gmail.com]
Sent: 10 January 2012 13:51
To: dev@jmeter.apache.org
Subject: Re: BUG-49753 Fix

On 10 January 2012 11:19, Mark Collin  wrote:
> I've implemented the enhancement BUG-49753 which is checked into 
> github and I have sent you a pull request here:
>
>
>
> https://github.com/apache/jmeter/pull/2
>
>
>
> Is there any chance of getting this added in?

Please can you attach the files to the Bugzilla issue?

Sorry, but we need that for tracking provenance.

> It would be nice to get some
> mavenised artefacts for JMeter building and eventually uploaded to the 
> main maven repo.
>
>
> --
> This message contains confidential information and is intended only 
> for
the individual named. If you are not the named addressee you should not
disseminate, distribute or copy this e-mail. Please notify the sender
immediately by e-mail if you have received this e-mail by mistake and delete
this e-mail from your system. If you are not the intended recipient you are
notified that disclosing, copying, distributing or taking any action in
reliance on the contents of this information is strictly prohibited.
>
> If you have received this email in error please notify 
> postmas...@ardescosolutions.com

--
This message contains confidential information and is intended only for the
individual named. If you are not the named addressee you should not
disseminate, distribute or copy this e-mail. Please notify the sender
immediately by e-mail if you have received this e-mail by mistake and delete
this e-mail from your system. If you are not the intended recipient you are
notified that disclosing, copying, distributing or taking any action in
reliance on the contents of this information is strictly prohibited.

If you have received this email in error please notify
postmas...@ardescosolutions.com
--
This message contains confidential information and is intended only for the
individual named. If you are not the named addressee you should not
disseminate, distribute or copy this e-mail. Please notify the sender
immediately by e-mail if you have received this e-mail by mistake and delete
this e-mail from your system. If you are not the intended recipient you are
notified that disclosing, copying, distributing or taking any action in
reliance on the contents of this information is strictly prohibited.

If you have received this email in error please notify
postmas...@ardescosolutions.com

--
This message contains confidential information and is intended only for the 
individual named. If you are not the named addressee you should not 
disseminate, distribute or copy this e-mail. Please notify the sender 
immediately by e-mail if you have received this e-mail by mistake and delete 
this e-mail from your system. If you are not the intended recipient you are 
notified that disclosing, copying, distributing or taking any action in 
reliance on the contents of this information is strictly prohibited.

If you have received this email in error please notify 
postmas...@ardescosolutions.com

Regarding fix of Bug 64075

2020-08-17 Thread Prajjwal Laad

Hello,

We had reported a bug regarding "Japanese Shift-JIS string contain some 
specific character cause text broken at script recording".
The details of the bug can be found in the link below
https://bz.apache.org/bugzilla/show_bug.cgi?id=64075

We have a patch for this bug as shared here 
https://github.com/apache/jmeter/pull/467 .

Mr. Phillipe commented that this part is very sensitive and requires 
non-regression testing.
ref: https://bz.apache.org/bugzilla/show_bug.cgi?id=64075#c1

I would request to please share the level and scope of the non-regression 
testing required for this part so that we can fix the bug.
Also if anyone else has encountered same or similar kind of issue please share 
the details.

Thanks and Regards
Prajjwal Laad

 The contents of this e-mail and any attachment(s) are confidential and 
intended for the named recipient(s) only. It shall not attach any liability on 
the originator or NECTI or its affiliates. Any views or opinions presented in 
this email are solely those of the author and may not necessarily reflect the 
opinions of NECTI or its affiliates. Any form of reproduction, dissemination, 
copying, disclosure, modification, distribution and / or publication of this 
message without the prior written consent of the author of this e-mail is 
strictly prohibited. If you have received this email in error please delete it 
and notify the sender immediately.

[PR] fix(deps): update org.checkerframework [jmeter]

2023-12-14 Thread via GitHub



renovate-bot opened a new pull request, #6183:
URL: https://github.com/apache/jmeter/pull/6183

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | [org.checkerframework:checker-qual](https://checkerframework.org/) 
([source](https://togithub.com/typetools/checker-framework)) | `3.40.0` -> 
`3.41.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.checkerframework:checker-qual/3.41.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.checkerframework:checker-qual/3.41.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.checkerframework:checker-qual/3.40.0/3.41.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.checkerframework:checker-qual/3.40.0/3.41.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | org.checkerframework:org.checkerframework.gradle.plugin | `0.6.35` -> 
`0.6.36` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.checkerframework:org.checkerframework.gradle.plugin/0.6.36?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.checkerframework:org.checkerframework.gradle.plugin/0.6.36?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.checkerframework:org.checkerframework.gradle.plugin/0.6.35/0.6.36?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.checkerframework:org.checkerframework.gradle.plugin/0.6.35/0.6.36?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | [org.checkerframework:checker](https://checkerframework.org/) 
([source](https://togithub.com/typetools/checker-framework)) | `3.40.0` -> 
`3.41.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.checkerframework:checker/3.41.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.checkerframework:checker/3.41.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.checkerframework:checker/3.40.0/3.41.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.checkerframework:checker/3.40.0/3.41.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config 
help](https://togithub.com/renovatebot/renovate/discussions) if that's 
undesired.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/jmeter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] fix(deps): update org.checkerframework [jmeter]

2023-12-24 Thread via GitHub



renovate-bot opened a new pull request, #6209:
URL: https://github.com/apache/jmeter/pull/6209

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | [org.checkerframework:checker-qual](https://checkerframework.org/) 
([source](https://togithub.com/typetools/checker-framework)) | `3.41.0` -> 
`3.42.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.checkerframework:checker-qual/3.42.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.checkerframework:checker-qual/3.42.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.checkerframework:checker-qual/3.41.0/3.42.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.checkerframework:checker-qual/3.41.0/3.42.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | org.checkerframework:org.checkerframework.gradle.plugin | `0.6.36` -> 
`0.6.37` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.checkerframework:org.checkerframework.gradle.plugin/0.6.37?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.checkerframework:org.checkerframework.gradle.plugin/0.6.37?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.checkerframework:org.checkerframework.gradle.plugin/0.6.36/0.6.37?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.checkerframework:org.checkerframework.gradle.plugin/0.6.36/0.6.37?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | [org.checkerframework:checker](https://checkerframework.org/) 
([source](https://togithub.com/typetools/checker-framework)) | `3.41.0` -> 
`3.42.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.checkerframework:checker/3.42.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.checkerframework:checker/3.42.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.checkerframework:checker/3.41.0/3.42.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.checkerframework:checker/3.41.0/3.42.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config 
help](https://togithub.com/renovatebot/renovate/discussions) if that's 
undesired.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/jmeter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

bug and fix for ProxyControl.deliverSampler() method

2014-01-11 Thread James Liang

Bug:

The Test Script Recorder (proxy) supports filtering of url patterns before 
sending the http requests to the Recording Controller.  Just to be clear, this 
part works.  However, if we add a View Results Tree element to the Test Script 
Recorder, the View Results Tree captures all calls and completely ignores the 
filtering rules.

As a result the calls captured by Recording Controller is in consistent with 
the View Results Tree of the recorder.  This complicates the reconciliation of 
the captured tests and the recorded result tree.  Furthermore, the filter is 
use to filter out resources (e.g. jpg, css, etc.) which are quite numerous.  
The test script recorder would be easier to use and more consistent if the Test 
Script Recorder honors the filter rule when it forwards the result to the View 
Results Tree.  In other words, the Test Scripts Recorder should send the same 
output to both the Recording Controller and View Results Tree.

Fix:
ProxyControl.java

method:
public synchronized void deliverSampler(final HTTPSamplerBase sampler, final 
TestElement[] subConfigs, final SampleResult result)

changes:

move line 545 to after 536 (before 537) so that the filter rule applies to the 
notification.

The code of the line to move is:
notifySampleListeners(new SampleEvent(result, "WorkBench")); // TODO - is this 
the correct threadgroup name?

I've attached the corrected java file.  The fix is based on the v2_10 src tree.
http://svn.apache.org/viewvc/jmeter/tags/v2_10/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java?revision=1533926&view=markup



Thanks,
James Liang

[GitHub] jmeter issue #289: Fix Typo

2017-04-15 Thread milamberspace

Github user milamberspace commented on the issue:

https://github.com/apache/jmeter/pull/289
  
 Thanks.

I merge the changes except the fixes on sbadmin because JMeter has not the 
source of this app.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #378: Fix 43612

2018-03-20 Thread artem-fedorov

Github user artem-fedorov commented on the issue:

https://github.com/apache/jmeter/pull/378
  
something wrong with TCP_TESTS


---

[GitHub] jmeter issue #378: Fix 43612

2018-03-20 Thread pmouawad

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/378
  
Hello @artem-fedorov ,
Is your PR for the bug you indicate which is supposed to be fixed long time 
ago or for this one:

- https://bz.apache.org/bugzilla/show_bug.cgi?id=60782

See those discussions:

- 
http://mail-archives.apache.org/mod_mbox/jmeter-dev/201702.mbox/%3CCAH9fUpZ6dKz4f4DFuVU56qc5cC0PkfCT3Qxq1r38_UbNmsiruA%40mail.gmail.com%3E
- 
http://mail-archives.apache.org/mod_mbox/jmeter-dev/201702.mbox/%3CCAH9fUpbSfK95m2ZYQwRJqEN%3D4NBmfSzqY3-FqNpSc2xz2hDD%2BA%40mail.gmail.com%3E


Regards


---

[GitHub] jmeter issue #378: Fix 43612

2018-03-21 Thread artem-fedorov

Github user artem-fedorov commented on the issue:

https://github.com/apache/jmeter/pull/378
  
@pmouawad 
I think it fix for old bug 43612.
See screenshots:
https://bz.apache.org/bugzilla/attachment.cgi?id=35796
https://bz.apache.org/bugzilla/attachment.cgi?id=35797


---

[GitHub] jmeter issue #439: Fix 63055

2019-02-04 Thread pmouawad

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/439
  
Hello @artem-fedorov ,
Can you provide a documentation of new property, it's in 
properties_reference.xml and we also usually add it commented to 
jmeter.properties.

Thanks


---

[GitHub] jmeter issue #439: Fix 63055

2019-02-04 Thread codecov-io

Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/439
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/439?src=pr&el=h1) 
Report
> Merging 
[#439](https://codecov.io/gh/apache/jmeter/pull/439?src=pr&el=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/295528a48fdf919d5479e0b91d030d19736adcf7?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
> The diff coverage is `91.3%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/439/graphs/tree.svg?width=650&token=6Q7CI1wFSh&height=150&src=pr)](https://codecov.io/gh/apache/jmeter/pull/439?src=pr&el=tree)

```diff
@@ Coverage Diff  @@
##  trunk #439  +/-   ##

+ Coverage 58.57%   58.57%   +<.01% 
- Complexity1077510778   +3 

  Files  1206 1206  
  Lines 7719377212  +19 
  Branches   7456 7456  

+ Hits  4521345230  +17 
- Misses2945129453   +2 
  Partials   2529 2529
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/439?src=pr&el=tree) | Coverage 
Î | Complexity Î | |
|---|---|---|---|
| 
[...c/org/apache/jmeter/samplers/TestSampleResult.java](https://codecov.io/gh/apache/jmeter/pull/439/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvc2FtcGxlcnMvVGVzdFNhbXBsZVJlc3VsdC5qYXZh)
 | `94.38% <100%> (+0.53%)` | `25 <1> (+1)` | :arrow_up: |
| 
[.../core/org/apache/jmeter/samplers/SampleResult.java](https://codecov.io/gh/apache/jmeter/pull/439/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvc2FtcGxlcnMvU2FtcGxlUmVzdWx0LmphdmE=)
 | `75.51% <66.66%> (-0.12%)` | `135 <4> (+2)` | |
| 
[...ocol/jms/org/apache/jmeter/protocol/jms/Utils.java](https://codecov.io/gh/apache/jmeter/pull/439/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvVXRpbHMuamF2YQ==)
 | `54.83% <0%> (-2.16%)` | `15% <0%> (Ã¸)` | |
| 
[...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/439/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==)
 | `85.49% <0%> (-0.77%)` | `18% <0%> (-1%)` | |
| 
[...s/org/apache/jmeter/timers/PoissonRandomTimer.java](https://codecov.io/gh/apache/jmeter/pull/439/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdGltZXJzL1BvaXNzb25SYW5kb21UaW1lci5qYXZh)
 | `78.37% <0%> (+5.4%)` | `10% <0%> (+1%)` | :arrow_up: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/439?src=pr&el=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Î = absolute  (impact)`, `Ã¸ = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/439?src=pr&el=footer). Last 
update 
[295528a...d15ed03](https://codecov.io/gh/apache/jmeter/pull/439?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[PR] fix(deps): update org.checkerframework [jmeter]

2023-11-24 Thread via GitHub



renovate-bot opened a new pull request, #6144:
URL: https://github.com/apache/jmeter/pull/6144

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | [org.checkerframework:checker-qual](https://checkerframework.org/) 
([source](https://togithub.com/typetools/checker-framework)) | `3.35.0` -> 
`3.40.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.checkerframework:checker-qual/3.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.checkerframework:checker-qual/3.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.checkerframework:checker-qual/3.35.0/3.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.checkerframework:checker-qual/3.35.0/3.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | org.checkerframework:org.checkerframework.gradle.plugin | `0.6.28` -> 
`0.6.35` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.checkerframework:org.checkerframework.gradle.plugin/0.6.35?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.checkerframework:org.checkerframework.gradle.plugin/0.6.35?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.checkerframework:org.checkerframework.gradle.plugin/0.6.28/0.6.35?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.checkerframework:org.checkerframework.gradle.plugin/0.6.28/0.6.35?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | [org.checkerframework:checker](https://checkerframework.org/) 
([source](https://togithub.com/typetools/checker-framework)) | `3.35.0` -> 
`3.40.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.checkerframework:checker/3.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.checkerframework:checker/3.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.checkerframework:checker/3.35.0/3.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.checkerframework:checker/3.35.0/3.40.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config 
help](https://togithub.com/renovatebot/renovate/discussions) if that's 
undesired.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/jmeter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] fix(deps): update org.checkerframework [jmeter]

2023-12-14 Thread via GitHub



vlsi closed pull request #6183: fix(deps): update org.checkerframework
URL: https://github.com/apache/jmeter/pull/6183


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] fix(deps): update org.checkerframework [jmeter]

2023-12-25 Thread via GitHub



vlsi closed pull request #6209: fix(deps): update org.checkerframework
URL: https://github.com/apache/jmeter/pull/6209


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

RE: intSum() is broken; code fix available

2013-12-11 Thread James Liang

I found the problem and have a fix.

The problem is cause by parsing of the lead space character when intSum() 
parses the input parameters.

bad=${__intSum(${start}, ${counter})}

Notice there is a space character after the , and before $.

The line that failed to parse this properly is IntSum.java line 64.

Here is the fix:

current code with parsing error:
String varName = ((CompoundVariable) values[values.length - 1]).execute();

corrected code which remove any leading and trailing space:
String varName = ((CompoundVariable) values[values.length - 
1]).execute().trim();


I've compared my fix to IntSum.java and LongSum.java (which already works).  
Looks like whoever fixed LongSum.java forgot to apply the same to IntSum.java.


Implication for other jmeter functions:

Also note that any other jmeter functions that don't properly trim the leading 
space will have the same parsing problem.  Perhaps a better place to fix this 
problem is in CompoundVariable.execute(SampleResult previousResult, Sampler 
currentSampler) method.  Fixing things in CompoundVariable.execute() means all 
jmeter functions will automatically benefit.  However, I am not familiar enough 
with jmeter source code to have confidence that trimming leading and trailing 
spaces in CompoundVariable.execute() won't cause other side effects.



Thanks,
James Liang



-Original Message-
From: James Liang [mailto:jli...@andera.com] 
Sent: Tuesday, December 10, 2013 4:01 PM
To: dev@jmeter.apache.org
Subject: bug: intSum() is broken

Hi all,

I notice intSum() is broken for version 2.10.  The function longSum() works 
fine.

To reproduce:

create 4 user paramters as follow:

start=5
counter=${__counter(FALSE)}
bad=${__intSum(${start}, ${counter})}
good=${__longSum(${start}, ${counter})}

I've test this inside a loop.  Remember __counter() starts with 1.

On 1st pass
bad=5
good=6

On 2nd pass
bad=5
good=7

The jmeter log shows no errors.  It'd seem intSum() is always returning the 
first parameter without doing the sum operation.



Thanks,
James Liang

Re: intSum() is broken; code fix available

2013-12-12 Thread Milamber


Hello,

Thanks for your report and your analysis.
I chose to apply the trim() method only in IntSum class like LongSum 
class to avoid incompatibly / side effect with the others functions.


Fix track:
https://issues.apache.org/bugzilla/show_bug.cgi?id=55871

Milamber

Le 12/12/2013 01:06, James Liang a ecrit :

I found the problem and have a fix.

The problem is cause by parsing of the lead space character when intSum() 
parses the input parameters.

bad=${__intSum(${start}, ${counter})}

Notice there is a space character after the , and before $.

The line that failed to parse this properly is IntSum.java line 64.

Here is the fix:

current code with parsing error:
String varName = ((CompoundVariable) values[values.length - 1]).execute();

corrected code which remove any leading and trailing space:
String varName = ((CompoundVariable) values[values.length - 
1]).execute().trim();


I've compared my fix to IntSum.java and LongSum.java (which already works).  
Looks like whoever fixed LongSum.java forgot to apply the same to IntSum.java.


Implication for other jmeter functions:

Also note that any other jmeter functions that don't properly trim the leading 
space will have the same parsing problem.  Perhaps a better place to fix this 
problem is in CompoundVariable.execute(SampleResult previousResult, Sampler 
currentSampler) method.  Fixing things in CompoundVariable.execute() means all 
jmeter functions will automatically benefit.  However, I am not familiar enough 
with jmeter source code to have confidence that trimming leading and trailing 
spaces in CompoundVariable.execute() won't cause other side effects.



Thanks,
James Liang



-Original Message-
From: James Liang [mailto:jli...@andera.com]
Sent: Tuesday, December 10, 2013 4:01 PM
To: dev@jmeter.apache.org
Subject: bug: intSum() is broken

Hi all,

I notice intSum() is broken for version 2.10.  The function longSum() works 
fine.

To reproduce:

create 4 user paramters as follow:

start=5
counter=${__counter(FALSE)}
bad=${__intSum(${start}, ${counter})}
good=${__longSum(${start}, ${counter})}

I've test this inside a loop.  Remember __counter() starts with 1.

On 1st pass
bad=5
good=6

On 2nd pass
bad=5
good=7

The jmeter log shows no errors.  It'd seem intSum() is always returning the 
first parameter without doing the sum operation.



Thanks,
James Liang

Re: bug and fix for ProxyControl.deliverSampler() method

2014-01-11 Thread sebb

Bug reports and enhancement requests are much easier to keep track of
if they are recorded in the JMeter issue tracking system, i.e.
Bugzilla.

Could you please create yourself a login and upload the details there?
Thanks!


On 12 January 2014 00:35, James Liang  wrote:
> Bug:
>
>
>
> The Test Script Recorder (proxy) supports filtering of url patterns before
> sending the http requests to the Recording Controller.  Just to be clear,
> this part works.  However, if we add a View Results Tree element to the Test
> Script Recorder, the View Results Tree captures all calls and completely
> ignores the filtering rules.
>
>
>
> As a result the calls captured by Recording Controller is in consistent with
> the View Results Tree of the recorder.  This complicates the reconciliation
> of the captured tests and the recorded result tree.  Furthermore, the filter
> is use to filter out resources (e.g. jpg, css, etc.) which are quite
> numerous.  The test script recorder would be easier to use and more
> consistent if the Test Script Recorder honors the filter rule when it
> forwards the result to the View Results Tree.  In other words, the Test
> Scripts Recorder should send the same output to both the Recording
> Controller and View Results Tree.
>
>
>
> Fix:
>
> ProxyControl.java
>
>
>
> method:
>
> public synchronized void deliverSampler(final HTTPSamplerBase sampler, final
> TestElement[] subConfigs, final SampleResult result)
>
>
>
> changes:
>
>
>
> move line 545 to after 536 (before 537) so that the filter rule applies to
> the notification.
>
>
>
> The code of the line to move is:
>
> notifySampleListeners(new SampleEvent(result, "WorkBench")); // TODO - is
> this the correct threadgroup name?
>
>
>
> I’ve attached the corrected java file.  The fix is based on the v2_10 src
> tree.
>
> http://svn.apache.org/viewvc/jmeter/tags/v2_10/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java?revision=1533926&view=markup
>
>
>
>
>
>
>
> Thanks,
>
> James Liang
>
>
>
>

Re: bug and fix for ProxyControl.deliverSampler() method

2014-01-12 Thread Philippe Mouawad

Hello,
A bugzilla already exists:
- https://issues.apache.org/bugzilla/show_bug.cgi?id=52013

Regards
Philippe

On Sunday, January 12, 2014, sebb wrote:

> Bug reports and enhancement requests are much easier to keep track of
> if they are recorded in the JMeter issue tracking system, i.e.
> Bugzilla.
>
> Could you please create yourself a login and upload the details there?
> Thanks!
>
>
> On 12 January 2014 00:35, James Liang >
> wrote:
> > Bug:
> >
> >
> >
> > The Test Script Recorder (proxy) supports filtering of url patterns
> before
> > sending the http requests to the Recording Controller.  Just to be clear,
> > this part works.  However, if we add a View Results Tree element to the
> Test
> > Script Recorder, the View Results Tree captures all calls and completely
> > ignores the filtering rules.
> >
> >
> >
> > As a result the calls captured by Recording Controller is in consistent
> with
> > the View Results Tree of the recorder.  This complicates the
> reconciliation
> > of the captured tests and the recorded result tree.  Furthermore, the
> filter
> > is use to filter out resources (e.g. jpg, css, etc.) which are quite
> > numerous.  The test script recorder would be easier to use and more
> > consistent if the Test Script Recorder honors the filter rule when it
> > forwards the result to the View Results Tree.  In other words, the Test
> > Scripts Recorder should send the same output to both the Recording
> > Controller and View Results Tree.
> >
> >
> >
> > Fix:
> >
> > ProxyControl.java
> >
> >
> >
> > method:
> >
> > public synchronized void deliverSampler(final HTTPSamplerBase sampler,
> final
> > TestElement[] subConfigs, final SampleResult result)
> >
> >
> >
> > changes:
> >
> >
> >
> > move line 545 to after 536 (before 537) so that the filter rule applies
> to
> > the notification.
> >
> >
> >
> > The code of the line to move is:
> >
> > notifySampleListeners(new SampleEvent(result, "WorkBench")); // TODO - is
> > this the correct threadgroup name?
> >
> >
> >
> > I’ve attached the corrected java file.  The fix is based on the v2_10 src
> > tree.
> >
> >
> http://svn.apache.org/viewvc/jmeter/tags/v2_10/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java?revision=1533926&view=markup
> >
> >
> >
> >
> >
> >
> >
> > Thanks,
> >
> > James Liang
> >
> >
> >
> >
>


-- 
Cordialement.
Philippe Mouawad.

Re: bug and fix for ProxyControl.deliverSampler() method

2014-01-12 Thread Philippe Mouawad

Hello,
Enhancement implemented with addition of a new setting in Recorder:
- Notify Child Listeners of filtered samplers (unchecked by default)

Regards


On Sun, Jan 12, 2014 at 9:27 AM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> Hello,
> A bugzilla already exists:
> - https://issues.apache.org/bugzilla/show_bug.cgi?id=52013
>
> Regards
> Philippe
>
>
> On Sunday, January 12, 2014, sebb wrote:
>
>> Bug reports and enhancement requests are much easier to keep track of
>> if they are recorded in the JMeter issue tracking system, i.e.
>> Bugzilla.
>>
>> Could you please create yourself a login and upload the details there?
>> Thanks!
>>
>>
>> On 12 January 2014 00:35, James Liang  wrote:
>> > Bug:
>> >
>> >
>> >
>> > The Test Script Recorder (proxy) supports filtering of url patterns
>> before
>> > sending the http requests to the Recording Controller.  Just to be
>> clear,
>> > this part works.  However, if we add a View Results Tree element to the
>> Test
>> > Script Recorder, the View Results Tree captures all calls and completely
>> > ignores the filtering rules.
>> >
>> >
>> >
>> > As a result the calls captured by Recording Controller is in consistent
>> with
>> > the View Results Tree of the recorder.  This complicates the
>> reconciliation
>> > of the captured tests and the recorded result tree.  Furthermore, the
>> filter
>> > is use to filter out resources (e.g. jpg, css, etc.) which are quite
>> > numerous.  The test script recorder would be easier to use and more
>> > consistent if the Test Script Recorder honors the filter rule when it
>> > forwards the result to the View Results Tree.  In other words, the Test
>> > Scripts Recorder should send the same output to both the Recording
>> > Controller and View Results Tree.
>> >
>> >
>> >
>> > Fix:
>> >
>> > ProxyControl.java
>> >
>> >
>> >
>> > method:
>> >
>> > public synchronized void deliverSampler(final HTTPSamplerBase sampler,
>> final
>> > TestElement[] subConfigs, final SampleResult result)
>> >
>> >
>> >
>> > changes:
>> >
>> >
>> >
>> > move line 545 to after 536 (before 537) so that the filter rule applies
>> to
>> > the notification.
>> >
>> >
>> >
>> > The code of the line to move is:
>> >
>> > notifySampleListeners(new SampleEvent(result, "WorkBench")); // TODO -
>> is
>> > this the correct threadgroup name?
>> >
>> >
>> >
>> > I’ve attached the corrected java file.  The fix is based on the v2_10
>> src
>> > tree.
>> >
>> >
>> http://svn.apache.org/viewvc/jmeter/tags/v2_10/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java?revision=1533926&view=markup
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> > Thanks,
>> >
>> > James Liang
>> >
>> >
>> >
>> >
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
>


-- 
Cordialement.
Philippe Mouawad.

Re: bug and fix for ProxyControl.deliverSampler() method

2014-01-12 Thread sebb

On 12 January 2014 14:58, Philippe Mouawad  wrote:
> Hello,
> Enhancement implemented with addition of a new setting in Recorder:
> - Notify Child Listeners of filtered samplers (unchecked by default)

I think it's wrong to change the default here, even if it is
documented as an incompatible change.

> Regards
>
>
> On Sun, Jan 12, 2014 at 9:27 AM, Philippe Mouawad <
> philippe.moua...@gmail.com> wrote:
>
>> Hello,
>> A bugzilla already exists:
>> - https://issues.apache.org/bugzilla/show_bug.cgi?id=52013
>>
>> Regards
>> Philippe
>>
>>
>> On Sunday, January 12, 2014, sebb wrote:
>>
>>> Bug reports and enhancement requests are much easier to keep track of
>>> if they are recorded in the JMeter issue tracking system, i.e.
>>> Bugzilla.
>>>
>>> Could you please create yourself a login and upload the details there?
>>> Thanks!
>>>
>>>
>>> On 12 January 2014 00:35, James Liang  wrote:
>>> > Bug:
>>> >
>>> >
>>> >
>>> > The Test Script Recorder (proxy) supports filtering of url patterns
>>> before
>>> > sending the http requests to the Recording Controller.  Just to be
>>> clear,
>>> > this part works.  However, if we add a View Results Tree element to the
>>> Test
>>> > Script Recorder, the View Results Tree captures all calls and completely
>>> > ignores the filtering rules.
>>> >
>>> >
>>> >
>>> > As a result the calls captured by Recording Controller is in consistent
>>> with
>>> > the View Results Tree of the recorder.  This complicates the
>>> reconciliation
>>> > of the captured tests and the recorded result tree.  Furthermore, the
>>> filter
>>> > is use to filter out resources (e.g. jpg, css, etc.) which are quite
>>> > numerous.  The test script recorder would be easier to use and more
>>> > consistent if the Test Script Recorder honors the filter rule when it
>>> > forwards the result to the View Results Tree.  In other words, the Test
>>> > Scripts Recorder should send the same output to both the Recording
>>> > Controller and View Results Tree.
>>> >
>>> >
>>> >
>>> > Fix:
>>> >
>>> > ProxyControl.java
>>> >
>>> >
>>> >
>>> > method:
>>> >
>>> > public synchronized void deliverSampler(final HTTPSamplerBase sampler,
>>> final
>>> > TestElement[] subConfigs, final SampleResult result)
>>> >
>>> >
>>> >
>>> > changes:
>>> >
>>> >
>>> >
>>> > move line 545 to after 536 (before 537) so that the filter rule applies
>>> to
>>> > the notification.
>>> >
>>> >
>>> >
>>> > The code of the line to move is:
>>> >
>>> > notifySampleListeners(new SampleEvent(result, "WorkBench")); // TODO -
>>> is
>>> > this the correct threadgroup name?
>>> >
>>> >
>>> >
>>> > I’ve attached the corrected java file.  The fix is based on the v2_10
>>> src
>>> > tree.
>>> >
>>> >
>>> http://svn.apache.org/viewvc/jmeter/tags/v2_10/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java?revision=1533926&view=markup
>>> >
>>> >
>>> >
>>> >
>>> >
>>> >
>>> >
>>> > Thanks,
>>> >
>>> > James Liang
>>> >
>>> >
>>> >
>>> >
>>>
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>>
>>
>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.

[GitHub] jmeter pull request: Fix 'statisfied' typo

2016-04-26 Thread automatictester

GitHub user automatictester opened a pull request:

https://github.com/apache/jmeter/pull/205

Fix 'statisfied' typo

Let's try to fix that before we have another problem of [that 
kind](http://user.jmeter.apache.narkive.com/uO9eXdwN/responseassertion-typo).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/automatictester/jmeter statisfied

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/205.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #205


commit 89268fae25045a9180d4efa1e279fdc9743be4ff
Author: automatictester 
Date:   2016-04-26T16:11:02Z

Fix 'statisfied' typo




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Fix 'statisfied' typo

2016-04-26 Thread automatictester

Github user automatictester commented on the pull request:

https://github.com/apache/jmeter/pull/205#issuecomment-214804684
  
Anyone knows why the above builds are hanging?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Fix 'statisfied' typo

2016-04-26 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/205


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request: Fix 'statisfied' typo

2016-04-26 Thread pmouawad

Github user pmouawad commented on the pull request:

https://github.com/apache/jmeter/pull/205#issuecomment-214866111
  
Thanks for your tests and PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request #289: Fix Typo

2017-04-14 Thread Mithrandir0407

GitHub user Mithrandir0407 opened a pull request:

https://github.com/apache/jmeter/pull/289

Fix Typo



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Mithrandir0407/jmeter trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #289






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request #289: Fix Typo

2017-04-15 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/289


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #295: Fix to 61071

2017-05-05 Thread abalanonline

Github user abalanonline commented on the issue:

https://github.com/apache/jmeter/pull/295
  
https://bz.apache.org/bugzilla/show_bug.cgi?id=61071


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #295: Fix to 61071

2017-05-05 Thread pmouawad

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/295
  
Hello @abalanonline ,
Thanks for your PR.
Would it be possible to provide a current failing test case that shows the 
issue and confirms that your fix is ok ?

Thank you


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #295: Fix to 61071

2017-05-05 Thread abalanonline

Github user abalanonline commented on the issue:

https://github.com/apache/jmeter/pull/295
  
Hello @pmouawad ,
Test case provided.
There are errors in build. Failed to resolve host name: jmeter.apache.org


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #295: Fix to 61071

2017-05-06 Thread pmouawad

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/295
  
Thanks for completing the PR.
Percentile 50 should be equal to median. 
So I suspect the bug is in getPercentPoint().

I wonder if it's not occasion to switch to 
https://github.com/HdrHistogram/HdrHistogram


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #295: Fix to 61071

2017-05-06 Thread abalanonline

Github user abalanonline commented on the issue:

https://github.com/apache/jmeter/pull/295
  
There are two methods for calculating percentile: Nearest Rank method and 
Linear Interpolation Between Closest Ranks method.
Median equal to percentile 50 if interpolation method is used. But for 
JMeter measuring purposes the nearest rank percentile should be used because 
perc 90 gives the exact maximum time for 90% of tests and this is what JMeter 
users are expecting.
This is why the median should be calculated separately (or we can implement 
interpolation method and use it for particular median purpose).
By the way getPercentPoint method is [failing 
also](https://gist.github.com/abalanonline/9b128faa67e2459b765c1ef56454684b). I 
will raise a bug.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #295: Fix to 61071

2017-05-07 Thread abalanonline

Github user abalanonline commented on the issue:

https://github.com/apache/jmeter/pull/295
  
Hello @pmouawad ,
I investigated the HdrHistogram project. Unfortunately we cannot use it in 
JMeter right now.
1. It do not have median method implemented.
2. It do not have the interpolated percentile method either.
3. It have the same bug calculating the 75th percentile of 11 data values 
{3, 6, 7, 8, 8, 9, 10, 13, 15, 16, 20} (example from Wikipedia)
So I suggest either fix the bugs in current org.apache.jorphan library. Or 
implement the necessary methods (and fix the bug) in HdrHistogram and after 
that use it in JMeter.
I provided two pull requests in case you prefer a quick solution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #295: Fix to 61071

2017-05-25 Thread pmouawad

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/295
  
Hi Team,
What shall we do ?
As per Felix note on dev mailing list, it is more an algorithm variation 
than a bug.







---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #306: Fix to BUG_60156

2017-09-07 Thread pmouawad

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/306
  
Hello
Unless there is a NO GO , I'll commit this tomorrow.

Thanks


---

[GitHub] jmeter issue #306: Fix to BUG_60156

2017-09-08 Thread pmouawad

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/306
  
This PR was merged through svn commit 
http://svn.apache.org/viewvc?rev=1807719&view=rev


---

[GitHub] jmeter issue #306: Fix to BUG_60156

2017-09-08 Thread pmouawad

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/306
  
Thanks @emilianbold  for review.


---

[GitHub] jmeter issue #370: ConstantPoissonProcessGenerator sonar fix

2018-01-07 Thread codecov-io

Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/370
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/370?src=pr&el=h1) 
Report
> Merging 
[#370](https://codecov.io/gh/apache/jmeter/pull/370?src=pr&el=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/33f09a9652e16220585aa9589a68672292e9bd74?src=pr&el=desc)
 will **decrease** coverage by `<.01%`.
> The diff coverage is `25%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/370/graphs/tree.svg?src=pr&token=6Q7CI1wFSh&width=650&height=150)](https://codecov.io/gh/apache/jmeter/pull/370?src=pr&el=tree)

```diff
@@ Coverage Diff  @@
##  trunk #370  +/-   ##

- Coverage 58.37%   58.37%   -0.01% 
- Complexity1031610317   +1 

  Files  1170 1170  
  Lines 7434774354   +7 
  Branches   7324 7325   +1 

+ Hits  4339943403   +4 
- Misses2842128424   +3 
  Partials   2527 2527
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/370?src=pr&el=tree) | Coverage 
Î | Complexity Î | |
|---|---|---|---|
| 
[...issonarrivals/ConstantPoissonProcessGenerator.java](https://codecov.io/gh/apache/jmeter/pull/370/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdGltZXJzL3BvaXNzb25hcnJpdmFscy9Db25zdGFudFBvaXNzb25Qcm9jZXNzR2VuZXJhdG9yLmphdmE=)
 | `44.08% <25%> (-0.11%)` | `9 <1> (Ã¸)` | |
| 
[...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/370/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==)
 | `86.15% <0%> (+0.76%)` | `19% <0%> (+1%)` | :arrow_up: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/370?src=pr&el=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Î = absolute  (impact)`, `Ã¸ = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/370?src=pr&el=footer). Last 
update 
[33f09a9...7aeb30b](https://codecov.io/gh/apache/jmeter/pull/370?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter pull request #378: Fix 43612

2018-03-20 Thread artem-fedorov

GitHub user artem-fedorov opened a pull request:

https://github.com/apache/jmeter/pull/378

Fix 43612

Hello,

I tried to send PUT request with a few Parameters, but I don't see them in 
my Request. I found bug for it 
https://bz.apache.org/bugzilla/show_bug.cgi?id=43612 

If I send PUT request with RawBody it works fine. 

Please, review my PR with fix

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/artem-fedorov/jmeter fix-43612

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #378


commit 3a9dbfd3fc9d5d7d76b2d6d1c3db8f510f80ef8e
Author: Artem Fedorov 
Date:   2018-03-19T16:04:10Z

    fix put arguments

commit 7cebb0e707e92be41ecfb6b68d288f78a7da66d8
Author: Artem Fedorov 
Date:   2018-03-19T16:04:18Z

changelog

commit 70f8004bc64dc0309198f998965556a75efa4663
Author: Artem Fedorov 
Date:   2018-03-20T08:50:56Z

add tests




---

[GitHub] jmeter pull request #378: Fix 43612

2018-03-20 Thread undera

Github user undera commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/378#discussion_r175759441
  
--- Diff: 
src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java ---
@@ -1649,6 +1648,43 @@ else if(getSendParameterValuesAsPostBody()) {
 }
 StringEntity requestEntity = new 
StringEntity(entityBodyContent.toString(), charset);
 entity.setEntity(requestEntity);
+} else if (hasArguments()) {
--- End diff --

Is it possible to extract this long code piece into separate method? For 
better readability.


---

[GitHub] jmeter pull request #378: Fix 43612

2018-03-20 Thread artem-fedorov

Github user artem-fedorov commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/378#discussion_r175794961
  
--- Diff: 
src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java ---
@@ -1649,6 +1648,43 @@ else if(getSendParameterValuesAsPostBody()) {
 }
 StringEntity requestEntity = new 
StringEntity(entityBodyContent.toString(), charset);
 entity.setEntity(requestEntity);
+} else if (hasArguments()) {
--- End diff --

Done


---

[GitHub] jmeter pull request #378: Fix 43612

2018-04-02 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/378


---

[GitHub] jmeter issue #388: Fix minor typo

2018-06-13 Thread FSchumacher

Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/388
  
Thanks for the contribution.


---

[GitHub] jmeter issue #396: Fix to 62336

2018-08-26 Thread codecov-io

Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/396
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/396?src=pr&el=h1) 
Report
> Merging 
[#396](https://codecov.io/gh/apache/jmeter/pull/396?src=pr&el=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/f8fb20aa9a711aa351a976098890bfedb97b235d?src=pr&el=desc)
 will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/396/graphs/tree.svg?width=650&token=6Q7CI1wFSh&height=150&src=pr)](https://codecov.io/gh/apache/jmeter/pull/396?src=pr&el=tree)

```diff
@@ Coverage Diff  @@
##  trunk #396  +/-   ##

- Coverage 58.62%   58.61%   -0.01% 
  Complexity1060210602  

  Files  1193 1193  
  Lines 7583775842   +5 
  Branches   7330 7331   +1 

  Hits  4445744457  
- Misses2886928874   +5 
  Partials   2511 2511
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/396?src=pr&el=tree) | Coverage 
Î | Complexity Î | |
|---|---|---|---|
| 
[src/core/org/apache/jmeter/gui/MainFrame.java](https://codecov.io/gh/apache/jmeter/pull/396/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZ3VpL01haW5GcmFtZS5qYXZh)
 | `1.53% <0%> (-0.03%)` | `1 <0> (Ã¸)` | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/396?src=pr&el=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Î = absolute  (impact)`, `Ã¸ = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/396?src=pr&el=footer). Last 
update 
[f8fb20a...1df6d1b](https://codecov.io/gh/apache/jmeter/pull/396?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter issue #396: Fix to 62336

2018-08-26 Thread varan123

Github user varan123 commented on the issue:

https://github.com/apache/jmeter/pull/396
  
current_event is KeyEvent. action_event is ActionEvent. KeyEvent and
ActonEvent two different types, but both from AWTEvent. Line: String
propname = "gui.quick_" + actionEvent.getActionCommand(); tries to prepare
property name where last part it is pressed key with digit, and not working
with CTRL-6.  I just replaced, with code, which take key text directly from
KeyEvent.

np. I will rename variables.




On Sun, Aug 26, 2018 at 3:30 PM Felix Schumacher 
wrote:

> *@FSchumacher* requested changes on this pull request.
>
> Thanks for your patch.
> I have one question and a few minor notes about code formatting.
> --
>
> In src/core/org/apache/jmeter/gui/MainFrame.java
> :
>
> > @@ -680,7 +683,15 @@ private void addQuickComponentHotkeys(JTree 
treevar) {
>
>  @Override
>  public void actionPerformed(ActionEvent actionEvent) {
> -String propname = "gui.quick_" + 
actionEvent.getActionCommand();
> +//Bug 62336
> +AWTEvent current_event = EventQueue.getCurrentEvent();
>
> Have you checked what actionEvent is here? If I read the Swing-API
> correctly, it should be the same object as current_event. If actionEvent
> is really null here, is it only sometimes null and the NPE stops the AWT
> thread?
> As a minor note: current_event should be written in camel case as
> currentEvent to match the other names.
> --
>
> In src/core/org/apache/jmeter/gui/MainFrame.java
> :
>
> > @@ -680,7 +683,15 @@ private void addQuickComponentHotkeys(JTree 
treevar) {
>
>  @Override
>  public void actionPerformed(ActionEvent actionEvent) {
> -String propname = "gui.quick_" + 
actionEvent.getActionCommand();
> +//Bug 62336
> +AWTEvent current_event = EventQueue.getCurrentEvent();
> +String key_text = "";
> +if(current_event instanceof KeyEvent) {
>
> I would place a space between if and the opening parenthesis as if is not
> a function call.
> --
>
> In src/core/org/apache/jmeter/gui/MainFrame.java
> :
>
> > @@ -680,7 +683,15 @@ private void addQuickComponentHotkeys(JTree 
treevar) {
>
>  @Override
>  public void actionPerformed(ActionEvent actionEvent) {
> -String propname = "gui.quick_" + 
actionEvent.getActionCommand();
> +//Bug 62336
> +AWTEvent current_event = EventQueue.getCurrentEvent();
> +String key_text = "";
> +if(current_event instanceof KeyEvent) {
> +KeyEvent key_event = (KeyEvent)current_event;
> +key_text = KeyEvent.getKeyText( 
key_event.getKeyCode() );
>
> Again a minor nit: No space needed after the opening and before the
> closing parenthesis as this is a function call.
> And as above variable names should be written in camel case: keyEvent
> instead of key_event.
> --
>
> In src/core/org/apache/jmeter/gui/MainFrame.java
> :
>
> > @@ -680,7 +683,15 @@ private void addQuickComponentHotkeys(JTree 
treevar) {
>
>  @Override
>  public void actionPerformed(ActionEvent actionEvent) {
> -String propname = "gui.quick_" + 
actionEvent.getActionCommand();
> +//Bug 62336
> +AWTEvent current_event = EventQueue.getCurrentEvent();
> +String key_text = "";
> +if(current_event instanceof KeyEvent) {
> +KeyEvent key_event = (KeyEvent)current_event;
>
> Here I would put a space after the closing parenthesis as this is a cast.
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 

> .
>



---

[GitHub] jmeter issue #396: Fix to 62336

2018-08-29 Thread FSchumacher

Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/396
  
Right, the events will never be the same, but still... I wonder why 
`ActionEvent` is `null` in the first place. This seems to be a bug in the JDK, 
it doesn't make sense to call an action listener without a valid event.
Can you post a stacktrace when the event is `null` (and maybe return early 
from the function and see, if the next event in the action listener is the 
*correct* one)?


---

[GitHub] jmeter issue #396: Fix to 62336

2018-08-30 Thread varan123

Github user varan123 commented on the issue:

https://github.com/apache/jmeter/pull/396
  
I based my solution on discussion: 
https://stackoverflow.com/questions/32978936/why-actionevent-getactioncommand-returns-null
If we want to receive key value, have sense to receive it directly from 
KeyEvent.
Debug results:
Ctrl-6: propname value "gui.quick_null"
Ctrl-3: propname value "gui.quick_3"
Stacktrace:
at org.apache.jmeter.gui.MainFrame$2.actionPerformed(MainFrame.java:696)
at javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1663)
at javax.swing.JComponent.processKeyBinding(JComponent.java:2882)
at javax.swing.KeyboardManager.fireBinding(KeyboardManager.java:307)
at 
javax.swing.KeyboardManager.fireKeyboardAction(KeyboardManager.java:250)
at 
javax.swing.JComponent.processKeyBindingsForAllComponents(JComponent.java:2974)
at javax.swing.JComponent.processKeyBindings(JComponent.java:2966)
at javax.swing.JComponent.processKeyEvent(JComponent.java:2845)
at java.awt.Component.processEvent(Component.java:6310)
at java.awt.Container.processEvent(Container.java:2237)
at java.awt.Component.dispatchEventImpl(Component.java:4889)
at java.awt.Container.dispatchEventImpl(Container.java:2295)
at java.awt.Component.dispatchEvent(Component.java:4711)
at 
java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1954)
at 
java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:806)
at 
java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1074)
at 
java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:945)
at 
java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:771)
at java.awt.Component.dispatchEventImpl(Component.java:4760)
at java.awt.Container.dispatchEventImpl(Container.java:2295)
at java.awt.Window.dispatchEventImpl(Window.java:2746)
at java.awt.Component.dispatchEvent(Component.java:4711)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
at java.awt.EventQueue.access$500(EventQueue.java:97)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.awt.EventQueue$3.run(EventQueue.java:703)
at java.security.AccessController.doPrivileged(AccessController.java)
at 
java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
at 
java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90)
at java.awt.EventQueue$4.run(EventQueue.java:731)
at java.awt.EventQueue$4.run(EventQueue.java:729)
at java.security.AccessController.doPrivileged(AccessController.java)
at 
java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
at 
java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
at 
java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at 
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)


---

[GitHub] jmeter issue #396: Fix to 62336

2018-09-10 Thread FSchumacher

Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/396
  
Just wanted to let you know, that you are not forgotten. I have now access 
to a windows 10 system and can reproduce the issue. But before I implement your 
fix, I would like to understand why `ctrl`+`6`doesn't work, as all other keys 
seem to work OK.


---

[GitHub] jmeter issue #396: Fix to 62336

2018-10-28 Thread FSchumacher

Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/396
  
Thanks for your contribution.

I still don't know, why we get `null` for `CTRL`+`6` on windows, but the 
workaround seems to work, so I have included it and hope somebody can explain 
the real bug to me.


---

[GitHub] jmeter pull request #439: Fix 63055

2019-02-04 Thread artem-fedorov

GitHub user artem-fedorov opened a pull request:

https://github.com/apache/jmeter/pull/439

Fix 63055

https://bz.apache.org/bugzilla/show_bug.cgi?id=63055

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/artem-fedorov/jmeter fix-63055

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/439.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #439


commit 2d6b530764017678bd06eea6296b3ca09141575a
Author: Artem Fedorov 
Date:   2019-02-04T13:49:04Z

fix rename sample labels

https://bz.apache.org/bugzilla/show_bug.cgi?id=63055

commit a453a63372d0563a7cf7582ce87193dd7b5d3571
Author: Artem Fedorov 
Date:   2019-02-04T14:19:43Z

fix isRenameSampleLabe()

commit 3b7e2eb8135570e112403aa705b5a48fa6990d93
Author: Artem Fedorov 
Date:   2019-02-04T14:19:48Z

add test

commit 064ac6fb0ae049f7536e487d0b40093858c361fe
Author: Artem Fedorov 
Date:   2019-02-04T14:24:43Z

add changelog




---

[GitHub] jmeter pull request #439: Fix 63055

2019-02-04 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/439


---

Re: [PR] fix(deps): update org.checkerframework [jmeter]

2023-11-24 Thread via GitHub



vlsi closed pull request #6144: fix(deps): update org.checkerframework
URL: https://github.com/apache/jmeter/pull/6144


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] fix(deps): update com.fasterxml.jackson.core to v2.16.1 [jmeter]

2023-12-24 Thread via GitHub



renovate-bot opened a new pull request, #6200:
URL: https://github.com/apache/jmeter/pull/6200

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | 
[com.fasterxml.jackson.core:jackson-databind](https://togithub.com/FasterXML/jackson)
 ([source](https://togithub.com/FasterXML/jackson-databind)) | `2.16.0` -> 
`2.16.1` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.fasterxml.jackson.core:jackson-databind/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.fasterxml.jackson.core:jackson-databind/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.fasterxml.jackson.core:jackson-databind/2.16.0/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.fasterxml.jackson.core:jackson-databind/2.16.0/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | 
[com.fasterxml.jackson.core:jackson-core](https://togithub.com/FasterXML/jackson-core)
 | `2.16.0` -> `2.16.1` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.fasterxml.jackson.core:jackson-core/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.fasterxml.jackson.core:jackson-core/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.fasterxml.jackson.core:jackson-core/2.16.0/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.fasterxml.jackson.core:jackson-core/2.16.0/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | 
[com.fasterxml.jackson.core:jackson-annotations](https://togithub.com/FasterXML/jackson)
 ([source](https://togithub.com/FasterXML/jackson-annotations)) | `2.16.0` -> 
`2.16.1` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.fasterxml.jackson.core:jackson-annotations/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.fasterxml.jackson.core:jackson-annotations/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.fasterxml.jackson.core:jackson-annotations/2.16.0/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.fasterxml.jackson.core:jackson-annotations/2.16.0/2.16.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   🔕 **Ignore**: Close this PR and you won't be reminded about these updates 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/jmeter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] fix(deps): update com.google.errorprone to v2.24.0 [jmeter]

2023-12-24 Thread via GitHub



renovate-bot opened a new pull request, #6208:
URL: https://github.com/apache/jmeter/pull/6208

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | [com.google.errorprone:error_prone_annotations](https://errorprone.info) 
([source](https://togithub.com/google/error-prone)) | `2.23.0` -> `2.24.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.errorprone:error_prone_annotations/2.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.errorprone:error_prone_annotations/2.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.errorprone:error_prone_annotations/2.23.0/2.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.errorprone:error_prone_annotations/2.23.0/2.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | [com.google.errorprone:error_prone_core](https://errorprone.info) 
([source](https://togithub.com/google/error-prone)) | `2.23.0` -> `2.24.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.errorprone:error_prone_core/2.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.errorprone:error_prone_core/2.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.errorprone:error_prone_core/2.23.0/2.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.errorprone:error_prone_core/2.23.0/2.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Release Notes
   
   
   google/error-prone 
(com.google.errorprone:error_prone_annotations)
   
   ### 
[`v2.24.0`](https://togithub.com/google/error-prone/releases/tag/v2.24.0): 
Error Prone 2.24.0
   
   New checks:
   
   -   
[`MultipleNullnessAnnotations`](https://errorprone.info/bugpattern/MultipleNullnessAnnotations):
 Discourage multiple nullness annotations
   -   
[`NullableTypeParameter`](https://errorprone.info/bugpattern/NullableTypeParameter):
 Discourage nullness annotations on type parameters
   -   
[`NullableWildcard`](https://errorprone.info/bugpattern/NullableWildcard): 
Discourage nullness annotations on wildcards
   -   
[`SuperCallToObjectMethod`](https://errorprone.info/bugpattern/SuperCallToObjectMethod):
 Generalization of `SuperEqualsIsObjectEquals`, now covers `hashCode`
   
   Full Changelog: 
https://github.com/google/error-prone/compare/v2.23.0...v2.24.0
   
   
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   🔕 **Ignore**: Close this PR and you won't be reminded about these updates 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/jmeter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] fix(deps): update org.apache.logging.log4j to v2.22.1 [jmeter]

2023-12-27 Thread via GitHub



renovate-bot opened a new pull request, #6213:
URL: https://github.com/apache/jmeter/pull/6213

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | 
[org.apache.logging.log4j:log4j-slf4j-impl](https://logging.apache.org/log4j/2.x/)
 ([source](https://togithub.com/apache/logging-log4j2)) | `2.22.0` -> `2.22.1` 
| 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.logging.log4j:log4j-slf4j-impl/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.logging.log4j:log4j-slf4j-impl/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.logging.log4j:log4j-slf4j-impl/2.22.0/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.logging.log4j:log4j-slf4j-impl/2.22.0/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | 
[org.apache.logging.log4j:log4j-core](https://logging.apache.org/log4j/2.x/) 
([source](https://togithub.com/apache/logging-log4j2)) | `2.22.0` -> `2.22.1` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.logging.log4j:log4j-core/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.logging.log4j:log4j-core/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.logging.log4j:log4j-core/2.22.0/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.logging.log4j:log4j-core/2.22.0/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | 
[org.apache.logging.log4j:log4j-api](https://logging.apache.org/log4j/2.x/) 
([source](https://togithub.com/apache/logging-log4j2)) | `2.22.0` -> `2.22.1` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.logging.log4j:log4j-api/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.logging.log4j:log4j-api/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.logging.log4j:log4j-api/2.22.0/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.logging.log4j:log4j-api/2.22.0/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | 
[org.apache.logging.log4j:log4j-1.2-api](https://logging.apache.org/log4j/2.x/) 
([source](https://togithub.com/apache/logging-log4j2)) | `2.22.0` -> `2.22.1` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.logging.log4j:log4j-1.2-api/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.logging.log4j:log4j-1.2-api/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.logging.log4j:log4j-1.2-api/2.22.0/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.logging.log4j:log4j-1.2-api/2.22.0/2.22.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   🔕 **Ignore**: Close this PR and you won't be reminded about these updates 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/jmeter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[I] Please fix vulnerability CVE-2022-44729 [jmeter]

2024-08-23 Thread via GitHub



fmuntean opened a new issue, #6338:
URL: https://github.com/apache/jmeter/issues/6338

   ### Expected behavior
   
   https://securityvulnerability.io/vulnerability/CVE-2022-44729
   Please update batik to v1.7
   
   ### Actual behavior
   
   _No response_
   
   ### Steps to reproduce the problem
   
   run vulnerability scan
   
   ### JMeter Version
   
   5.6.3
   
   ### Java Version
   
   _No response_
   
   ### OS Version
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Some Javadoc warning to fix before next release?

2015-02-28 Thread Milamber

Hello,

When I launch the distribution task to test the next release, I've these
Javadoc warning messages:

  [javadoc]
/home/milamber/temp/jmetertemp/src/core/org/apache/jmeter/save/SaveService.java:515:
warning - @param argument "file" is not a parameter name.
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/http/org/apache/jmeter/protocol/http/sampler/MeasuringConnectionManager.java:47:
warning - Tag @link: reference not found: MeasuringConnectionRequest
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_NONE (referenced by @value tag) is an
unknown reference.
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_READ_COMMITTED (referenced by @value
tag) is an unknown reference.
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_READ_UNCOMMITTED (referenced by @value
tag) is an unknown reference.
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_REPEATABLE_READ (referenced by @value
tag) is an unknown reference.
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java:120:
warning - Connection#TRANSACTION_SERIALIZABLE (referenced by @value tag)
is an unknown reference.
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/http/org/apache/jmeter/protocol/http/sampler/MeasuringConnectionManager.java:47:
warning - Tag @link: reference not found: MeasuringConnectionRequest
  [javadoc] Building index for all the packages and classes...
  [javadoc]
/home/milamber/temp/jmetertemp/src/protocol/http/org/apache/jmeter/protocol/http/sampler/MeasuringConnectionManager.java:47:
warning - Tag @link: reference not found: MeasuringConnectionRequest
  [javadoc] Building index for all classes...
  [javadoc] Generating
/home/milamber/temp/jmetertemp/docs/api/stylesheet.css...
  [javadoc] 9 warnings

I must ignore these messages or try to fix them?

Milamber

[GitHub] jmeter pull request #295: Fix to 61071

2017-05-05 Thread abalanonline

GitHub user abalanonline opened a pull request:

https://github.com/apache/jmeter/pull/295

Fix to 61071



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/abalanonline/jmeter 61071

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #295


commit b71640eb8c3bfbb88dee63f16ce8e76e2cdb9b47
Author: Aleksei Balan 
Date:   2017-05-05T18:09:06Z

Fix to 61071




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request #295: Fix to 61071

2017-05-05 Thread abalanonline

GitHub user abalanonline reopened a pull request:

https://github.com/apache/jmeter/pull/295

Fix to 61071



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/abalanonline/jmeter 61071

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #295


commit b71640eb8c3bfbb88dee63f16ce8e76e2cdb9b47
Author: Aleksei Balan 
Date:   2017-05-05T18:09:06Z

Fix to 61071

commit 75a30f25367180578cdf08478829ffbbd55106cd
Author: Aleksei Balan 
Date:   2017-05-05T21:26:07Z

Median test case for bug 61071




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request #295: Fix to 61071

2017-05-05 Thread abalanonline

Github user abalanonline closed the pull request at:

https://github.com/apache/jmeter/pull/295


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request #306: Fix to BUG_60156

2017-09-02 Thread ubikloadpack

GitHub user ubikloadpack opened a pull request:

https://github.com/apache/jmeter/pull/306

Fix to BUG_60156



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ubikloadpack/jmeter BUG_60156

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #306


commit a25764304ce0589acb357bbac2dc1b5085d598fb
Author: pmouawad 
Date:   2017-09-02T20:15:47Z

Fix to BUG_60156




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] jmeter issue #306: Fix to BUG_60156

2017-09-07 Thread Emilian Bold

I don't know the codebase but why bother marking the old method as
@Deprecated if you are not making the change backwards compatible?

I see 'return null' in two existing methods while previously those methods
returned something.

A proper pattern would have been to call read(is, null) or read(is, new
DummySampleResult()).

--emi

On Thu, Sep 7, 2017 at 11:25 PM, pmouawad  wrote:

> Github user pmouawad commented on the issue:
>
> https://github.com/apache/jmeter/pull/306
>
> Hello
> Unless there is a NO GO , I'll commit this tomorrow.
>
> Thanks
>
>
> ---
>

Re: [GitHub] jmeter issue #306: Fix to BUG_60156

2017-09-07 Thread Philippe Mouawad

Hi Emilian
AFAIU, it is backward compatible no ?

in AbstractTCPClient.java
,
the new method calls the old one.

Only the subclasses has been modified to implement the new one.

Thanks for reviewing

On Thu, Sep 7, 2017 at 10:58 PM, Emilian Bold 
wrote:

> I don't know the codebase but why bother marking the old method as
> @Deprecated if you are not making the change backwards compatible?
>
> I see 'return null' in two existing methods while previously those methods
> returned something.
>
> A proper pattern would have been to call read(is, null) or read(is, new
> DummySampleResult()).
>
>
> --emi
>
> On Thu, Sep 7, 2017 at 11:25 PM, pmouawad  wrote:
>
> > Github user pmouawad commented on the issue:
> >
> > https://github.com/apache/jmeter/pull/306
> >
> > Hello
> > Unless there is a NO GO , I'll commit this tomorrow.
> >
> > Thanks
> >
> >
> > ---
> >
>



-- 
Cordialement.
Philippe Mouawad.

Re: [GitHub] jmeter issue #306: Fix to BUG_60156

2017-09-07 Thread Emilian Bold

It is backwards compatible as an SPI, meaning that 3rd party
implementations that use AbstractTCPClient will still work if they
implement only the old method.

But it is not backwards compatible as an API because 3rd party code that
calls the old method will now receive nulls for those existing
implementations.

So the question is if this is supposed to be an API or it's just an SPI.

--emi

On Fri, Sep 8, 2017 at 12:03 AM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> Hi Emilian
> AFAIU, it is backward compatible no ?
>
> in AbstractTCPClient.java
>  a9c4a5285efe7b85e9bcd62614>,
> the new method calls the old one.
>
> Only the subclasses has been modified to implement the new one.
>
> Thanks for reviewing
>
> On Thu, Sep 7, 2017 at 10:58 PM, Emilian Bold 
> wrote:
>
> > I don't know the codebase but why bother marking the old method as
> > @Deprecated if you are not making the change backwards compatible?
> >
> > I see 'return null' in two existing methods while previously those
> methods
> > returned something.
> >
> > A proper pattern would have been to call read(is, null) or read(is, new
> > DummySampleResult()).
> >
> >
> > --emi
> >
> > On Thu, Sep 7, 2017 at 11:25 PM, pmouawad  wrote:
> >
> > > Github user pmouawad commented on the issue:
> > >
> > > https://github.com/apache/jmeter/pull/306
> > >
> > > Hello
> > > Unless there is a NO GO , I'll commit this tomorrow.
> > >
> > > Thanks
> > >
> > >
> > > ---
> > >
> >
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>

Re: [GitHub] jmeter issue #306: Fix to BUG_60156

2017-09-08 Thread UBIK LOAD PACK Support

Hello Emilian,
There was indeed one last issue in TCPClientImpl with backward
compatibility, we pushed a commit
It should be ok now, but please review (
https://github.com/apache/jmeter/pull/306/files):

   - If AbstractTCPClient implement the old method they will work
   - If AbstractTCPClient implement the new  method, they will of course
   work
   - If 3rd party code calls the old method, they should also work


Regards

@ubikloadpack Team
On Fri, Sep 8, 2017 at 6:31 AM, Emilian Bold  wrote:

> It is backwards compatible as an SPI, meaning that 3rd party
> implementations that use AbstractTCPClient will still work if they
> implement only the old method.
>
> But it is not backwards compatible as an API because 3rd party code that
> calls the old method will now receive nulls for those existing
> implementations.
>
> So the question is if this is supposed to be an API or it's just an SPI.
>
> --emi
>
> On Fri, Sep 8, 2017 at 12:03 AM, Philippe Mouawad <
> philippe.moua...@gmail.com> wrote:
>
> > Hi Emilian
> > AFAIU, it is backward compatible no ?
> >
> > in AbstractTCPClient.java
> >  > a9c4a5285efe7b85e9bcd62614>,
> > the new method calls the old one.
> >
> > Only the subclasses has been modified to implement the new one.
> >
> > Thanks for reviewing
> >
> > On Thu, Sep 7, 2017 at 10:58 PM, Emilian Bold 
> > wrote:
> >
> > > I don't know the codebase but why bother marking the old method as
> > > @Deprecated if you are not making the change backwards compatible?
> > >
> > > I see 'return null' in two existing methods while previously those
> > methods
> > > returned something.
> > >
> > > A proper pattern would have been to call read(is, null) or read(is, new
> > > DummySampleResult()).
> > >
> > >
> > > --emi
> > >
> > > On Thu, Sep 7, 2017 at 11:25 PM, pmouawad  wrote:
> > >
> > > > Github user pmouawad commented on the issue:
> > > >
> > > > https://github.com/apache/jmeter/pull/306
> > > >
> > > > Hello
> > > > Unless there is a NO GO , I'll commit this tomorrow.
> > > >
> > > > Thanks
> > > >
> > > >
> > > > ---
> > > >
> > >
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> >
>

Re: [GitHub] jmeter issue #306: Fix to BUG_60156

2017-09-08 Thread Emilian Bold

Looks much better now.

--emi

Pe 8 sept. 2017, la 12:04, UBIK LOAD PACK Support  a 
scris:

> Hello Emilian,
> There was indeed one last issue in TCPClientImpl with backward
> compatibility, we pushed a commit
> It should be ok now, but please review (
> https://github.com/apache/jmeter/pull/306/files):
> 
>   - If AbstractTCPClient implement the old method they will work
>   - If AbstractTCPClient implement the new  method, they will of course
>   work
>   - If 3rd party code calls the old method, they should also work
> 
> 
> Regards
> 
> @ubikloadpack Team
>> On Fri, Sep 8, 2017 at 6:31 AM, Emilian Bold  wrote:
>> 
>> It is backwards compatible as an SPI, meaning that 3rd party
>> implementations that use AbstractTCPClient will still work if they
>> implement only the old method.
>> 
>> But it is not backwards compatible as an API because 3rd party code that
>> calls the old method will now receive nulls for those existing
>> implementations.
>> 
>> So the question is if this is supposed to be an API or it's just an SPI.
>> 
>> --emi
>> 
>> On Fri, Sep 8, 2017 at 12:03 AM, Philippe Mouawad <
>> philippe.moua...@gmail.com> wrote:
>> 
>>> Hi Emilian
>>> AFAIU, it is backward compatible no ?
>>> 
>>> in AbstractTCPClient.java
>>> >> a9c4a5285efe7b85e9bcd62614>,
>>> the new method calls the old one.
>>> 
>>> Only the subclasses has been modified to implement the new one.
>>> 
>>> Thanks for reviewing
>>> 
>>> On Thu, Sep 7, 2017 at 10:58 PM, Emilian Bold 
>>> wrote:
>>> 
 I don't know the codebase but why bother marking the old method as
 @Deprecated if you are not making the change backwards compatible?
 
 I see 'return null' in two existing methods while previously those
>>> methods
 returned something.
 
 A proper pattern would have been to call read(is, null) or read(is, new
 DummySampleResult()).
 
 
 --emi
 
> On Thu, Sep 7, 2017 at 11:25 PM, pmouawad  wrote:
> 
> Github user pmouawad commented on the issue:
> 
>https://github.com/apache/jmeter/pull/306
> 
>Hello
>Unless there is a NO GO , I'll commit this tomorrow.
> 
>Thanks
> 
> 
> ---
> 
 
>>> 
>>> 
>>> 
>>> --
>>> Cordialement.
>>> Philippe Mouawad.
>>> 
>>

[GitHub] jmeter pull request #306: Fix to BUG_60156

2017-09-08 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/306


---

[GitHub] jmeter pull request #314: Fix to 61556

2017-10-04 Thread turf00

GitHub user turf00 opened a pull request:

https://github.com/apache/jmeter/pull/314

Fix to 61556

Added clarification in documentation around using Groovy for performance.

+ Made clear that when using the __groovy function you should use vars.get 
to fetch variables so that the script can be cached.
+ Made clear in the ifController the performant way of dealing with Groovy.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/turf00/jmeter 61556

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/314.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #314


commit 669fa427768485140f9a45a44e99b88280b710ae
Author: Justin McCartney 
Date:   2017-10-04T09:04:01Z

Fix to 61556

Added clarification in documentation around using Groovy for performance.

+ Made clear that when using the __groovy function you should use vars.get 
to fetch variables so that the script can be cached.
+ Made clear in the ifController the performant way of dealing with Groovy.




---

[GitHub] jmeter pull request #314: Fix to 61556

2017-10-05 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/314


---

[GitHub] jmeter issue #318: OS_TESTS.jmx fix for Windows

2017-10-26 Thread codecov-io

Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/318
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/318?src=pr&el=h1) 
Report
> Merging 
[#318](https://codecov.io/gh/apache/jmeter/pull/318?src=pr&el=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/833d53f92129ee83fbe31f56980c5fd6031dba9b?src=pr&el=desc)
 will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/318/graphs/tree.svg?src=pr&width=650&token=6Q7CI1wFSh&height=150)](https://codecov.io/gh/apache/jmeter/pull/318?src=pr&el=tree)

```diff
@@Coverage Diff@@
##  trunk #318   +/-   ##
=
  Coverage 57.56%   57.56%   
  Complexity 9835 9835   
=
  Files  1136 1136   
  Lines 7286072860   
  Branches   7294 7294   
=
  Hits  4193941939   
  Misses2845428454   
  Partials   2467 2467
```



--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/318?src=pr&el=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Î = absolute  (impact)`, `Ã¸ = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/318?src=pr&el=footer). Last 
update 
[833d53f...6e83f7e](https://codecov.io/gh/apache/jmeter/pull/318?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter issue #318: OS_TESTS.jmx fix for Windows

2017-10-26 Thread pmouawad

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/318
  
Merged, thank you !


---

[GitHub] jmeter issue #318: OS_TESTS.jmx fix for Windows

2017-10-27 Thread abalanonline

Github user abalanonline commented on the issue:

https://github.com/apache/jmeter/pull/318
  
Glad to know. Thank you.


---

[GitHub] jmeter issue #338: Fix main frame position

2017-11-23 Thread codecov-io

Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/338
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/338?src=pr&el=h1) 
Report
> Merging 
[#338](https://codecov.io/gh/apache/jmeter/pull/338?src=pr&el=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/738badc97c23db7b27855c25ed74737e5c2e7b0b?src=pr&el=desc)
 will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/338/graphs/tree.svg?height=150&width=650&token=6Q7CI1wFSh&src=pr)](https://codecov.io/gh/apache/jmeter/pull/338?src=pr&el=tree)

```diff
@@ Coverage Diff  @@
##  trunk #338  +/-   ##

- Coverage 57.91%   57.91%   -0.01% 
+ Complexity1002410023   -1 

  Files  1148 1148  
  Lines 7378573787   +2 
  Branches   7328 7328  

- Hits  4273542731   -4 
- Misses2857328579   +6 
  Partials   2477 2477
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/338?src=pr&el=tree) | Coverage 
Î | Complexity Î | |
|---|---|---|---|
| 
[.../jorphan/org/apache/jorphan/gui/ComponentUtil.java](https://codecov.io/gh/apache/jmeter/pull/338?src=pr&el=tree#diff-c3JjL2pvcnBoYW4vb3JnL2FwYWNoZS9qb3JwaGFuL2d1aS9Db21wb25lbnRVdGlsLmphdmE=)
 | `0% <0%> (Ã¸)` | `0 <0> (Ã¸)` | :arrow_down: |
| 
[src/core/org/apache/jmeter/JMeter.java](https://codecov.io/gh/apache/jmeter/pull/338?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvSk1ldGVyLmphdmE=)
 | `39.3% <0%> (-0.12%)` | `43 <0> (Ã¸)` | |
| 
[...mpler/hc/JMeterPoolingClientConnectionManager.java](https://codecov.io/gh/apache/jmeter/pull/338?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL0pNZXRlclBvb2xpbmdDbGllbnRDb25uZWN0aW9uTWFuYWdlci5qYXZh)
 | `27.77% <0%> (-3.18%)` | `10% <0%> (-1%)` | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/338?src=pr&el=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Î = absolute  (impact)`, `Ã¸ = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/338?src=pr&el=footer). Last 
update 
[738badc...aaee0a5](https://codecov.io/gh/apache/jmeter/pull/338?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter issue #368: Csv sample reader fix

2017-12-23 Thread codecov-io

Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/368
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/368?src=pr&el=h1) 
Report
> Merging 
[#368](https://codecov.io/gh/apache/jmeter/pull/368?src=pr&el=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/998b3302a10ad8f298c12e67e08369f5a205018d?src=pr&el=desc)
 will **increase** coverage by `0.01%`.
> The diff coverage is `81.25%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/368/graphs/tree.svg?width=650&height=150&src=pr&token=6Q7CI1wFSh)](https://codecov.io/gh/apache/jmeter/pull/368?src=pr&el=tree)

```diff
@@ Coverage Diff  @@
##  trunk #368  +/-   ##

+ Coverage 58.35%   58.36%   +0.01% 
- Complexity1028810290   +2 

  Files  1164 1164  
  Lines 7412774126   -1 
  Branches   7298 7298  

+ Hits  4325443266  +12 
+ Misses2835928349  -10 
+ Partials   2514 2511   -3
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/368?src=pr&el=tree) | Coverage 
Î | Complexity Î | |
|---|---|---|---|
| 
[...apache/jmeter/report/core/CsvSampleReaderTest.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L2NvcmUvQ3N2U2FtcGxlUmVhZGVyVGVzdC5qYXZh)
 | `78.18% <100%> (+4.49%)` | `11 <1> (-1)` | :arrow_down: |
| 
[...org/apache/jmeter/report/core/CsvSampleReader.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L2NvcmUvQ3N2U2FtcGxlUmVhZGVyLmphdmE=)
 | `57.57% <50%> (+0.65%)` | `12 <0> (Ã¸)` | :arrow_down: |
| 
[src/core/org/apache/jmeter/report/core/Sample.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L2NvcmUvU2FtcGxlLmphdmE=)
 | `41.02% <0%> (+2.56%)` | `11% <0%> (+1%)` | :arrow_up: |
| 
[...mpler/hc/JMeterPoolingClientConnectionManager.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL0pNZXRlclBvb2xpbmdDbGllbnRDb25uZWN0aW9uTWFuYWdlci5qYXZh)
 | `30.95% <0%> (+3.17%)` | `11% <0%> (+1%)` | :arrow_up: |
| 
[...re/org/apache/jmeter/engine/DistributedRunner.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZW5naW5lL0Rpc3RyaWJ1dGVkUnVubmVyLmphdmE=)
 | `85.95% <0%> (+4.13%)` | `32% <0%> (+1%)` | :arrow_up: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/368?src=pr&el=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Î = absolute  (impact)`, `Ã¸ = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/368?src=pr&el=footer). Last 
update 
[998b330...083b1ae](https://codecov.io/gh/apache/jmeter/pull/368?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter pull request #370: ConstantPoissonProcessGenerator sonar fix

2018-01-07 Thread ham1

GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/370

ConstantPoissonProcessGenerator sonar fix

Fix sonar 'bug'. It also makes it more obvious we are changing the `i` 
declared outside the `do while` instead of redeclaring another `i` for the 
`for` loop.

PS. If someone has a better name for this variable please change as the 
code isn't very easy to understand, at least for me.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter cppg_sonar_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/370.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #370


commit 9e584c4db43627e06df469b0cedd4ddee41f3594
Author: Graham Russell 
Date:   2018-01-07T16:15:26Z

fixed sonar warning

commit 7aeb30b9d8e44d990efb589fac3b24c1907829f4
Author: Graham Russell 
Date:   2018-01-07T16:15:37Z

formatting




---

[GitHub] jmeter pull request #370: ConstantPoissonProcessGenerator sonar fix

2018-01-07 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/370


---

[GitHub] jmeter pull request #388: Fix minor typo.

2018-06-13 Thread giancarloromeo

GitHub user giancarloromeo opened a pull request:

https://github.com/apache/jmeter/pull/388

Fix minor typo.

## Description



## Motivation and Context



## How Has This Been Tested?




## Screenshots (if appropriate):

## Types of changes

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality 
to not work as expected)

## Checklist:


- [ ] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.

[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/giancarloromeo/jmeter patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/388.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #388


commit ea85da3b8539e5ff7e0a03a11a349af44b04398b
Author: Giancarlo Romeo 
Date:   2018-06-13T08:40:13Z

Fix minor typo.




---

[GitHub] jmeter pull request #388: Fix minor typo

2018-06-13 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/388


---

[GitHub] jmeter pull request #396: Fix to 62336

2018-08-26 Thread varan123

GitHub user varan123 opened a pull request:

https://github.com/apache/jmeter/pull/396

Fix to 62336

## Description
Keyboard shortcut Ctrl +6 is not working.
Was reproduced for Java 8 on Windows 10.
actionEvent.getActionCommand() in MainFrame unexpected returning null only 
for CTRL-6. getActionCommand was replaced with alternative code. New version 
working stable.

## Motivation and Context
All CTRL-{N} working stable, after fix.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62336

## How Has This Been Tested?
Tested on Java 8 and  Java 9 on Windows 10. Issue was reproduced. New code 
working fine. 

## Screenshots (if appropriate):

## Types of changes
- Bug fix 62336. Was changed org.apache.jmeter.gui.MainFarme around line 
686.


## Checklist:
PathFilenameExtension   Status  Lines added Lines 
removed   Last Modified   Size
src/core/org/apache/jmeter/gui/MainFrame.java   MainFrame.java  .java   
Modified12  1   


[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/varan123/jmeter Bug_62336

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/396.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #396


commit 1df6d1b56e8e73df58ee68981c7f2bbc19273a94
Author: Michael Pavlov 
Date:   2018-08-26T04:29:28Z

Fix to 62336




---

[GitHub] jmeter pull request #396: Fix to 62336

2018-08-26 Thread FSchumacher

Github user FSchumacher commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/396#discussion_r212836415
  
--- Diff: src/core/org/apache/jmeter/gui/MainFrame.java ---
@@ -680,7 +683,15 @@ private void addQuickComponentHotkeys(JTree treevar) {
 
 @Override
 public void actionPerformed(ActionEvent actionEvent) {
-String propname = "gui.quick_" + 
actionEvent.getActionCommand();
+//Bug 62336
+AWTEvent current_event = EventQueue.getCurrentEvent();
+String key_text = "";
+if(current_event instanceof KeyEvent) {
--- End diff --

I would place a space between `if` and the opening parenthesis as `if` is 
not a function call.


---

[GitHub] jmeter pull request #396: Fix to 62336

2018-08-26 Thread FSchumacher

Github user FSchumacher commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/396#discussion_r212836402
  
--- Diff: src/core/org/apache/jmeter/gui/MainFrame.java ---
@@ -680,7 +683,15 @@ private void addQuickComponentHotkeys(JTree treevar) {
 
 @Override
 public void actionPerformed(ActionEvent actionEvent) {
-String propname = "gui.quick_" + 
actionEvent.getActionCommand();
+//Bug 62336
+AWTEvent current_event = EventQueue.getCurrentEvent();
--- End diff --

Have you checked what `actionEvent` is here? If I read the Swing-API 
correctly, it should be the same object as `current_event`. If `actionEvent` is 
really `null` here, is it only sometimes `null` and the NPE stops the AWT 
thread?
As a minor note: `current_event` should be written in camel case as 
`currentEvent` to match the other names. 


---

[GitHub] jmeter pull request #396: Fix to 62336

2018-08-26 Thread FSchumacher

Github user FSchumacher commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/396#discussion_r212836472
  
--- Diff: src/core/org/apache/jmeter/gui/MainFrame.java ---
@@ -680,7 +683,15 @@ private void addQuickComponentHotkeys(JTree treevar) {
 
 @Override
 public void actionPerformed(ActionEvent actionEvent) {
-String propname = "gui.quick_" + 
actionEvent.getActionCommand();
+//Bug 62336
+AWTEvent current_event = EventQueue.getCurrentEvent();
+String key_text = "";
+if(current_event instanceof KeyEvent) {
+KeyEvent key_event = (KeyEvent)current_event;
+key_text = KeyEvent.getKeyText( key_event.getKeyCode() 
);
--- End diff --

Again a minor nit: No space needed after the opening and before the closing 
parenthesis as this is a function call.
And as above variable names should be written in camel case: `keyEvent` 
instead of `key_event`.


---

[GitHub] jmeter pull request #396: Fix to 62336

2018-08-26 Thread FSchumacher

Github user FSchumacher commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/396#discussion_r212836512
  
--- Diff: src/core/org/apache/jmeter/gui/MainFrame.java ---
@@ -680,7 +683,15 @@ private void addQuickComponentHotkeys(JTree treevar) {
 
 @Override
 public void actionPerformed(ActionEvent actionEvent) {
-String propname = "gui.quick_" + 
actionEvent.getActionCommand();
+//Bug 62336
+AWTEvent current_event = EventQueue.getCurrentEvent();
+String key_text = "";
+if(current_event instanceof KeyEvent) {
+KeyEvent key_event = (KeyEvent)current_event;
--- End diff --

Here I would put a space after the closing parenthesis as this is a cast.


---

[GitHub] jmeter issue #399: Fix undefined disabled icon

2018-09-16 Thread pmouawad

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/399
  
Thanks for PR.
We'll merge it once version 5.0 is released.

Regards


---

[GitHub] jmeter pull request #396: Fix to 62336

2018-10-28 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/396


---

[PR] fix(deps): update com.fasterxml.jackson.core to v2.16.0 [jmeter]

2023-11-24 Thread via GitHub



renovate-bot opened a new pull request, #6124:
URL: https://github.com/apache/jmeter/pull/6124

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | 
[com.fasterxml.jackson.core:jackson-databind](https://togithub.com/FasterXML/jackson)
 ([source](https://togithub.com/FasterXML/jackson-databind)) | `2.15.2` -> 
`2.16.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.fasterxml.jackson.core:jackson-databind/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.fasterxml.jackson.core:jackson-databind/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.fasterxml.jackson.core:jackson-databind/2.15.2/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.fasterxml.jackson.core:jackson-databind/2.15.2/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | 
[com.fasterxml.jackson.core:jackson-core](https://togithub.com/FasterXML/jackson-core)
 | `2.15.2` -> `2.16.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.fasterxml.jackson.core:jackson-core/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.fasterxml.jackson.core:jackson-core/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.fasterxml.jackson.core:jackson-core/2.15.2/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.fasterxml.jackson.core:jackson-core/2.15.2/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | 
[com.fasterxml.jackson.core:jackson-annotations](https://togithub.com/FasterXML/jackson)
 ([source](https://togithub.com/FasterXML/jackson-annotations)) | `2.15.2` -> 
`2.16.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.fasterxml.jackson.core:jackson-annotations/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.fasterxml.jackson.core:jackson-annotations/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.fasterxml.jackson.core:jackson-annotations/2.15.2/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.fasterxml.jackson.core:jackson-annotations/2.15.2/2.16.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   🔕 **Ignore**: Close this PR and you won't be reminded about these updates 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/jmeter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] fix(deps): update org.apache.activemq to v5.16.7 [jmeter]

2023-11-24 Thread via GitHub



renovate-bot opened a new pull request, #6122:
URL: https://github.com/apache/jmeter/pull/6122

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | [org.apache.activemq:activemq-spring](http://activemq.apache.org) 
([source](https://togithub.com/apache/activemq)) | `5.16.6` -> `5.16.7` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.activemq:activemq-spring/5.16.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.activemq:activemq-spring/5.16.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.activemq:activemq-spring/5.16.6/5.16.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.activemq:activemq-spring/5.16.6/5.16.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | [org.apache.activemq:activemq-client](http://activemq.apache.org) 
([source](https://togithub.com/apache/activemq)) | `5.16.6` -> `5.16.7` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.activemq:activemq-client/5.16.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.activemq:activemq-client/5.16.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.activemq:activemq-client/5.16.6/5.16.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.activemq:activemq-client/5.16.6/5.16.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | [org.apache.activemq:activemq-broker](http://activemq.apache.org) 
([source](https://togithub.com/apache/activemq)) | `5.16.6` -> `5.16.7` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.activemq:activemq-broker/5.16.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.activemq:activemq-broker/5.16.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.activemq:activemq-broker/5.16.6/5.16.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.activemq:activemq-broker/5.16.6/5.16.7?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   🔕 **Ignore**: Close this PR and you won't be reminded about these updates 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/jmeter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] fix(deps): update org.openjdk.jmh to v1.37 [jmeter]

2023-11-24 Thread via GitHub



renovate-bot opened a new pull request, #6145:
URL: https://github.com/apache/jmeter/pull/6145

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | 
[org.openjdk.jmh:jmh-generator-annprocess](http://openjdk.java.net/projects/code-tools/jmh/)
 ([source](https://togithub.com/openjdk/jmh)) | `1.36` -> `1.37` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.openjdk.jmh:jmh-generator-annprocess/1.37?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.openjdk.jmh:jmh-generator-annprocess/1.37?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.openjdk.jmh:jmh-generator-annprocess/1.36/1.37?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.openjdk.jmh:jmh-generator-annprocess/1.36/1.37?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | 
[org.openjdk.jmh:jmh-core](http://openjdk.java.net/projects/code-tools/jmh/) 
([source](https://togithub.com/openjdk/jmh)) | `1.36` -> `1.37` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.openjdk.jmh:jmh-core/1.37?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.openjdk.jmh:jmh-core/1.37?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.openjdk.jmh:jmh-core/1.36/1.37?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.openjdk.jmh:jmh-core/1.36/1.37?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Release Notes
   
   
   openjdk/jmh (org.openjdk.jmh:jmh-generator-annprocess)
   
   ### [`v1.37`](https://togithub.com/openjdk/jmh/compare/1.36...1.37)
   
   [Compare Source](https://togithub.com/openjdk/jmh/compare/1.36...1.37)
   
   
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   🔕 **Ignore**: Close this PR and you won't be reminded about these updates 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/jmeter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] fix(deps): update com.google.errorprone to v2.23.0 [jmeter]

2023-11-24 Thread via GitHub

thub.com/google/error-prone/commit/44b65527debbc57892f21ca3ba458b16771e423e)
   -   Prevent SuggestedFixes#renameMethod from modifying return type 
declaration 
([#4043](https://togithub.com/google/error-prone/issues/4043))
   -   Fix UnusedVariable false positives for private record parameters 
([#2713](https://togithub.com/google/error-prone/issues/2713))
   -   When running in conservative mode, no longer assume that implementations 
of `Map.get`, etc. return `null` 
([#2910](https://togithub.com/google/error-prone/issues/2910))
   -   CanIgnoreReturnValueSuggester: Support additional exempting method 
annotations 
([#4009](https://togithub.com/google/error-prone/issues/4009))
   -   UnusedVariable: exclude junit5's `@RegisterExtension` 
([#3892](https://togithub.com/google/error-prone/issues/3892))
   -   Support running all available patch checks 
([#947](https://togithub.com/google/error-prone/issues/947))
   -   Upgrade java-diff-utils 4.0 -> 4.12 
([#4081](https://togithub.com/google/error-prone/issues/4081))
   -   Flag unused Refaster template parameters 
([#4060](https://togithub.com/google/error-prone/issues/4060))
   -   Support `@SuppressWarnings("all")` 
([#4065](https://togithub.com/google/error-prone/issues/4065))
   -   Prevent Refaster `UMemberSelect` from matching method parameters 
([#2456](https://togithub.com/google/error-prone/issues/2456))
   -   MissingDefault : Don't require `// fall out` comments on expression 
switches ([#2709](https://togithub.com/google/error-prone/issues/2709))
   -   Skip UnnecessaryLambda findings for usages in enhanced for loops 
([#2518](https://togithub.com/google/error-prone/issues/2518))
   -   Fix bug where nested MissingBraces violations' suggested fixes result in 
broken code 
([#3797](https://togithub.com/google/error-prone/issues/3797))
   -   Add support for specifying `exemptPrefixes`/`exemptNames` for 
UnusedVariable via flags 
([#2753](https://togithub.com/google/error-prone/issues/2753))
   -   UnusedMethod: Added exempting variable annotations 
([#2881](https://togithub.com/google/error-prone/issues/2881))
   
   Full Changelog: 
https://github.com/google/error-prone/compare/v2.21.1...v2.22.0
   
   ### 
[`v2.21.1`](https://togithub.com/google/error-prone/releases/tag/v2.21.1): 
Error Prone 2.21.1
   
   [Compare 
Source](https://togithub.com/google/error-prone/compare/v2.21.0...v2.21.1)
   
   Changes:
   
   -   Handle overlapping ranges in suppressedRegions (fixes 
[#4040](https://togithub.com/google/error-prone/issues/4040))
   -   Add [` AddressSelection  
`](https://errorprone.info/bugpattern/AddressSelection) to discourage APIs that 
convert a hostname to a single address
   
   Full Changelog: 
https://github.com/google/error-prone/compare/v2.21.0...v2.21.1
   
   ### 
[`v2.21.0`](https://togithub.com/google/error-prone/releases/tag/v2.21.0): 
Error Prone 2.21.0
   
   [Compare 
Source](https://togithub.com/google/error-prone/compare/v2.20.0...v2.21.0)
   
   New Checkers:
   
   -   
[`AttemptedNegativeZero`](https://errorprone.info/bugpattern/AttemptedNegativeZero):
 Prevents accidental use of `-0`, which is the same as `0`. The floating-point 
negative zero is `-0.0`.
   -   
[`ICCProfileGetInstance`](https://errorprone.info/bugpattern/ICCProfileGetInstance):
 Warns on uses of `ICC_Profile.getInstance(String)`, due to 
[JDK-8191622](https://bugs.openjdk.org/browse/JDK-8191622).
   -   
[`MutableGuiceModule`](https://errorprone.info/bugpattern/MutableGuiceModule): 
Fields in Guice modules should be `final`.
   -   
[`NullableOptional`](https://errorprone.info/bugpattern/NullableOptional): 
Discourages `@Nullable`-annotated `Optional`s.
   -   
[`OverridingMethodInconsistentArgumentNamesChecker`](https://errorprone.info/bugpattern/OverridingMethodInconsistentArgumentNamesChecker):
 Arguments of overriding method are inconsistent with overridden method.
   
   Fixed issues: 
[#3976](https://togithub.com/google/error-prone/issues/3976), 
[#3986](https://togithub.com/google/error-prone/issues/3986), 
[#4001](https://togithub.com/google/error-prone/issues/4001), 
[#4002](https://togithub.com/google/error-prone/issues/4002), 
[#4026](https://togithub.com/google/error-prone/issues/4026), 
[#4027](https://togithub.com/google/error-prone/issues/4027)
   
   Full Changelog: 
https://github.com/google/error-prone/compare/v2.20.0...v2.21.0
   
   
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   🔕 **Ignore**: Close this PR and you won't be reminded about these updates 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR

[PR] fix(deps): update org.apache.logging.log4j to v2.22.0 [jmeter]

2023-11-24 Thread via GitHub



renovate-bot opened a new pull request, #6157:
URL: https://github.com/apache/jmeter/pull/6157

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | 
[org.apache.logging.log4j:log4j-slf4j-impl](https://logging.apache.org/log4j/2.x/)
 ([source](https://togithub.com/apache/logging-log4j2)) | `2.20.0` -> `2.22.0` 
| 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.logging.log4j:log4j-slf4j-impl/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.logging.log4j:log4j-slf4j-impl/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.logging.log4j:log4j-slf4j-impl/2.20.0/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.logging.log4j:log4j-slf4j-impl/2.20.0/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | 
[org.apache.logging.log4j:log4j-core](https://logging.apache.org/log4j/2.x/) 
([source](https://togithub.com/apache/logging-log4j2)) | `2.20.0` -> `2.22.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.logging.log4j:log4j-core/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.logging.log4j:log4j-core/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.logging.log4j:log4j-core/2.20.0/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.logging.log4j:log4j-core/2.20.0/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | 
[org.apache.logging.log4j:log4j-api](https://logging.apache.org/log4j/2.x/) 
([source](https://togithub.com/apache/logging-log4j2)) | `2.20.0` -> `2.22.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.logging.log4j:log4j-api/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.logging.log4j:log4j-api/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.logging.log4j:log4j-api/2.20.0/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.logging.log4j:log4j-api/2.20.0/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | 
[org.apache.logging.log4j:log4j-1.2-api](https://logging.apache.org/log4j/2.x/) 
([source](https://togithub.com/apache/logging-log4j2)) | `2.20.0` -> `2.22.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/org.apache.logging.log4j:log4j-1.2-api/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.apache.logging.log4j:log4j-1.2-api/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.apache.logging.log4j:log4j-1.2-api/2.20.0/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.apache.logging.log4j:log4j-1.2-api/2.20.0/2.22.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   🔕 **Ignore**: Close this PR and you won't be reminded about these updates 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/jmeter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] fix(deps): update io.burt to v0.6.0 [jmeter]

2023-11-24 Thread via GitHub



renovate-bot opened a new pull request, #6159:
URL: https://github.com/apache/jmeter/pull/6159

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | [io.burt:jmespath-jackson](https://togithub.com/burtcorp/jmespath-java) | 
`0.5.1` -> `0.6.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/io.burt:jmespath-jackson/0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.burt:jmespath-jackson/0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.burt:jmespath-jackson/0.5.1/0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.burt:jmespath-jackson/0.5.1/0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   | [io.burt:jmespath-core](https://togithub.com/burtcorp/jmespath-java) | 
`0.5.1` -> `0.6.0` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/io.burt:jmespath-core/0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.burt:jmespath-core/0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.burt:jmespath-core/0.5.1/0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.burt:jmespath-core/0.5.1/0.6.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   🔕 **Ignore**: Close this PR and you won't be reminded about these updates 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/jmeter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] fix(deps): update io.burt to v0.6.0 [jmeter]

2023-11-24 Thread via GitHub



vlsi merged PR #6159:
URL: https://github.com/apache/jmeter/pull/6159


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] fix(deps): update dependency com.github.spotbugs:com.github.spotbugs.gradle.plugin to v5.2.5 [jmeter]

2023-12-03 Thread via GitHub



renovate-bot opened a new pull request, #6167:
URL: https://github.com/apache/jmeter/pull/6167

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | com.github.spotbugs:com.github.spotbugs.gradle.plugin | `5.2.3` -> `5.2.5` 
| 
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.github.spotbugs:com.github.spotbugs.gradle.plugin/5.2.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.github.spotbugs:com.github.spotbugs.gradle.plugin/5.2.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.github.spotbugs:com.github.spotbugs.gradle.plugin/5.2.3/5.2.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.github.spotbugs:com.github.spotbugs.gradle.plugin/5.2.3/5.2.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   🔕 **Ignore**: Close this PR and you won't be reminded about this update 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/jmeter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] fix(deps): update dependency checkstyle to v10.12.6 [jmeter]

2023-12-14 Thread via GitHub



renovate-bot opened a new pull request, #6177:
URL: https://github.com/apache/jmeter/pull/6177

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | [checkstyle](https://checkstyle.org/) 
([source](https://togithub.com/checkstyle/checkstyle)) | `10.12.5` -> `10.12.6` 
| 
[![age](https://developer.mend.io/api/mc/badges/age/maven/checkstyle/10.12.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/checkstyle/10.12.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/checkstyle/10.12.5/10.12.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/checkstyle/10.12.5/10.12.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   🔕 **Ignore**: Close this PR and you won't be reminded about this update 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/jmeter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] fix(deps): update dependency nl.jqno.equalsverifier:equalsverifier to v3.15.4 [jmeter]

2023-12-14 Thread via GitHub



renovate-bot opened a new pull request, #6178:
URL: https://github.com/apache/jmeter/pull/6178

   [![Mend 
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
   
   This PR contains the following updates:
   
   | Package | Change | Age | Adoption | Passing | Confidence |
   |---|---|---|---|---|---|
   | 
[nl.jqno.equalsverifier:equalsverifier](https://www.jqno.nl/equalsverifier) 
([source](https://togithub.com/jqno/equalsverifier)) | `3.15.3` -> `3.15.4` | 
[![age](https://developer.mend.io/api/mc/badges/age/maven/nl.jqno.equalsverifier:equalsverifier/3.15.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/nl.jqno.equalsverifier:equalsverifier/3.15.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/nl.jqno.equalsverifier:equalsverifier/3.15.3/3.15.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 | 
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/nl.jqno.equalsverifier:equalsverifier/3.15.3/3.15.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
 |
   
   ---
   
   ### Release Notes
   
   
   jqno/equalsverifier 
(nl.jqno.equalsverifier:equalsverifier)
   
   ### 
[`v3.15.4`](https://togithub.com/jqno/equalsverifier/blob/HEAD/CHANGELOG.md#3154---2023-11-29)
   
   # Added
   
   -   A check for Scala with its `-Xcheckinit` flag switched on. This flag 
generates a field that should have been marked as synthetic, but isn't, so 
EqualsVerifier has to check for this field explicitly.
   
   
   
   ---
   
   ### Configuration
   
   📅 **Schedule**: Branch creation - "every 3 weeks on Monday" (UTC), Automerge 
- At any time (no schedule defined).
   
   🚦 **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
   🔕 **Ignore**: Close this PR and you won't be reminded about this update 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Mend 
Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository 
job log [here](https://developer.mend.io/github/apache/jmeter).
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] fix(deps): update com.fasterxml.jackson.core to v2.16.0 [jmeter]

2023-12-14 Thread via GitHub



vlsi closed pull request #6124: fix(deps): update com.fasterxml.jackson.core to 
v2.16.0
URL: https://github.com/apache/jmeter/pull/6124


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

1 2 3 4 5 6 7 8 >

1 - 100 of 734 matches

Mail list logo