[GitHub] incubator-joshua issue #70: validate the original implementation of SARI
Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/70 This PR should be closed @cocoxu can you please close off? Thank you ---
[GitHub] incubator-joshua issue #71: JOSHUA-290 - separate OSGi artifact for Joshua, ...
Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/71 Or port to master? ---
[GitHub] incubator-joshua issue #71: JOSHUA-290 - separate OSGi artifact for Joshua, ...
Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/71 Close this one off @tteofili ? ---
[GitHub] incubator-joshua pull request #74: JOSHUA-321 Add JOSHUA env to ./bin/bleu a...
GitHub user lewismc opened a pull request: https://github.com/apache/incubator-joshua/pull/74 JOSHUA-321 Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash scripts This issue addresses https://issues.apache.org/jira/browse/JOSHUA-321 You can merge this pull request into a Git repository by running: $ git pull https://github.com/lewismc/incubator-joshua JOSHUA-321 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-joshua/pull/74.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #74 commit 2f3e752969a2bacc17aa029595c9a56b93331e9e Author: Lewis John McGibbney <lewis.mcgibb...@gmail.com> Date: 2016-11-09T23:31:30Z JOSHUA-321 Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash scripts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua issue #73: JOSHUA-316 run_bundler.py returning JOB FAILED (...
Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/73 A further comment, I just closed off https://issues.apache.org/jira/browse/JOSHUA-319, this is because I am able to run end to end pipelines without a hitch now. The only barrier is ensuring that enough memory is allocated to the processes. I ran with this PR on my local joshua code and it ran like a charm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua issue #73: JOSHUA-316 run_bundler.py returning JOB FAILED (...
Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/73 The most recent commit I submitted here also addresses [JOSHUA-317](https://issues.apache.org/jira/browse/JOSHUA-317) and [JOSHUA-318](https://issues.apache.org/jira/browse/JOSHUA-318) as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua issue #73: JOSHUA-316 run_bundler.py returning JOB FAILED (...
Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/73 BTW I am using Python 3.5 here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request #73: JOSHUA-316 run_bundler.py returning JOB F...
GitHub user lewismc opened a pull request: https://github.com/apache/incubator-joshua/pull/73 JOSHUA-316 run_bundler.py returning JOB FAILED (return code 1) TypeError: memoryview: a bytes-like object is required, not 'str' This issue addresses https://issues.apache.org/jira/browse/JOSHUA-316 This issue was a complete PITA. The non ascii character in run_bundler.py README template was a frigging big PITA. Done now folks :) You can merge this pull request into a Git repository by running: $ git pull https://github.com/lewismc/incubator-joshua JOSHUA-316 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-joshua/pull/73.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #73 commit d137f2970d1eace1dcec576d287712cd5b88 Author: Lewis John McGibbney <lewis.mcgibb...@gmail.com> Date: 2016-10-26T02:31:10Z JOSHUA-316 run_bundler.py returning JOB FAILED (return code 1) TypeError: memoryview: a bytes-like object is required, not 'str' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua issue #67: JOSHUA-299 Move regression tests to proper unit ...
Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/67 ack ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal
Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/24 Boom goes the dynamite On Aug 17, 2016 3:33 AM, "Matt Post" <notificati...@github.com> wrote: > Awesome, that merged really cleanly. There is now a pushed 7 branch that > we can begin work on for release 7. Travis-CI > <https://travis-ci.org/apache/incubator-joshua/builds/152931806> is > testing this as I write. > > Once we release 6.1, I'll merge 7 into master. > > â > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-joshua/pull/24#issuecomment-240374918>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABHJl5m5Z5FWe2PClnnsEKZs-vGOwTuKks5qguOXgaJpZM4I3JQs> > . > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal
Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/24 @mjpost so is the proposal to include this in 6.1? Or 7 only? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request #32: JOSHUA-286 - Replace old joshua-decoder.o...
Github user lewismc commented on a diff in the pull request: https://github.com/apache/incubator-joshua/pull/32#discussion_r72566062 --- Diff: scripts/support/make-release.sh --- @@ -40,7 +40,7 @@ echo "Bundling up joshua-$version" [[ ! -d release ]] && mkdir release rm -f joshua-$version && ln -s $JOSHUA joshua-$version -wget -r http://joshua-decoder.org/ +wget -r http://joshua.apache.org/6.0/ --- End diff -- Again, this site does not exist. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request #32: JOSHUA-286 - Replace old joshua-decoder.o...
Github user lewismc commented on a diff in the pull request: https://github.com/apache/incubator-joshua/pull/32#discussion_r72566047 --- Diff: CHANGELOG --- @@ -139,7 +139,7 @@ They include: - Significantly improved and expanded documentation (both user and developer) - See http://joshua-decoder.org/4.0 or ./joshua-decoder.org/4.0/index.html (local mirror) + See http://apache.joshua.org/4.0 or ./apache.joshua.org/4.0/index.html (local mirror) --- End diff -- There is no such site as http://apache.joshua.org, it should be http://joshua.apache.org, also the CHANGELOG should not be altered at all as this indicates changes to previous releases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request #32: JOSHUA-286 - Replace old joshua-decoder.o...
Github user lewismc commented on a diff in the pull request: https://github.com/apache/incubator-joshua/pull/32#discussion_r72566005 --- Diff: .gitignore --- @@ -42,6 +42,7 @@ doxygen_*.tmp .cachepipe joshua-decoder.org +joshua.apache.org --- End diff -- both of these can be removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal
Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/24 This is dynamite. I'll pull later and check it out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-258 Add back penn-treebank-(de)tokeniz...
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/8 > @lewismc, do you mind closing this PR? I don't have write access and can't, and this has been fixed elsewhere. No problems. Thanks @mjpost --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-258 Add back penn-treebank-(de)tokeniz...
Github user lewismc closed the pull request at: https://github.com/apache/incubator-joshua/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use Maven to b...
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12 Ho @mjpost can you point me at the latest BerkeleyLM codebase? I can Mavenize it and get it in to Maven Central so we can use it as a dependency in pom.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-81985 ack --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-38661 > I assume the edits to $JOSHUA/bin/joshua mean that eclipse compiled files will override the jar? So I can do fast development in Eclipse? Yes all you need to execute in your terminal is ```mvn eclipse:eclipse``` > We still have to solve the KenLM problem. Yes we do :( > Do we have ideas for how to pull in KenLM and compile it? And BerkeleyLM? https://bitbucket.org/atlassian/bash-maven-plugin Honestly thats the most I can find right now without hacking a Maven Github download build plugin. I am fed up of XML @mjpost :0 :) :) :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-04155 Make an entry in logging file? Parameterized logging as implemented by @thammegowda is magnitudes more efficient than traditional string + Excepton logging @thammegowda maybe we need INFO degreded (logging sense) to DEBUG Thank you @thammegowda for trying to understand the logging. When I was doing the build thats something I didn't approach :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222199387 @thammegowda please revert logging patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222037050 What kind of 'tests' are we talking about here? The only tests which I know of are invoked by running ```mvn clean test```. These execute very quickly by the looks of it however I assume that they cover little or none of the multithreaded functionality you are referring to. Do you have something we could code, profile and see what is taking so long @mjpost ? Thanks One last thing. No I changed absolutely no code. I did however introduce some classes such as the ArpaFile, etc which were required to get the current tests running. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-222002633 There will be a number of scripts which we need to update with the paths to the generated jar files. This is all part of the new build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-221793740 Cool @thammegowda #15 merged into JOSHUA-252 Work still to be done * plan on how we are going to compile and package GIZA++, KenLM, berkeleylm, thrax, etc. Right now the ext directory has been completely removed as that code should not live but instead be acquired as part of the build system. @mjpost have you made any changes to master which we need to merge into JOSHUA-252 branch? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-264 System.exit() calls are ...
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/13#issuecomment-219586971 Nice, I've been working on the eats for the last hour or so, so I'll update feature branch once this is done. @matt did you merge this PR into feature branch? If so then thanks very much. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-219336222 ACK Safe flight Kellen. On Sun, May 15, 2016 at 7:25 PM, Kellen Sunderland <notificati...@github.com > wrote: > Hey Lewis. I'm flying today but can take a look at getting the tests to > compile next week. Thanks for all the work. I'd be game for a google > hangout to discuss any issues we have. > > On Sun, May 15, 2016 at 7:19 PM, Lewis John McGibbney < > notificati...@github.com> wrote: > > > The PR is not finished yet. There are a number of issues as highlighted > > above which need attention. > > > > â > > You are receiving this because you were mentioned. > > Reply to this email directly or view it on GitHub > > < > https://github.com/apache/incubator-joshua/pull/12#issuecomment-219335321> > > > > â > You are receiving this because you were mentioned. > Reply to this email directly or view it on GitHub > <https://github.com/apache/incubator-joshua/pull/12#issuecomment-219335946> > -- *Lewis* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-252 Make it possible to use ...
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/12#issuecomment-219335321 The PR is not finished yet. There are a number of issues as highlighted above which need attention. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-258 Add back penn-treebank-(...
Github user lewismc commented on the pull request: https://github.com/apache/incubator-joshua/pull/8#issuecomment-215571337 I also noted this issue over on https://github.com/joshua-decoder/joshua_translation_engine/issues/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-258 Add back penn-treebank-(...
GitHub user lewismc opened a pull request: https://github.com/apache/incubator-joshua/pull/8 JOSHUA-258 Add back penn-treebank-(de)tokenizer perl scripts This issue addresses https://issues.apache.org/jira/browse/JOSHUA-258 You can merge this pull request into a Git repository by running: $ git pull https://github.com/lewismc/incubator-joshua JOSHUA-258 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-joshua/pull/8.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8 commit c43b8b023f4380159812ffa1ab03d6a0c646aaee Author: Lewis John McGibbney <lewis.j.mcgibb...@jpl.nasa.gov> Date: 2016-04-28T21:44:02Z JOSHUA-258 Add back penn-treebank-(de)tokenizer perl scripts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-256 Note that Joshua builds ...
GitHub user lewismc opened a pull request: https://github.com/apache/incubator-joshua/pull/5 JOSHUA-256 Note that Joshua builds and runs with >= Java 1.8 This PR addresses https://issues.apache.org/jira/browse/JOSHUA-256 You can merge this pull request into a Git repository by running: $ git pull https://github.com/lewismc/incubator-joshua JOSHUA-256 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-joshua/pull/5.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5 commit 6f45d19b1f9c7bc33c57b7485d99f27bd2e2eda6 Author: Lewis John McGibbney <lewis.j.mcgibb...@jpl.nasa.gov> Date: 2016-04-27T15:23:31Z JOSHUA-256 Note that Joshua builds and runs with >= Java 1.8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-255 License headers for all ...
GitHub user lewismc opened a pull request: https://github.com/apache/incubator-joshua/pull/4 JOSHUA-255 License headers for all bash scripts This issue addresses https://issues.apache.org/jira/browse/JOSHUA-255 You can merge this pull request into a Git repository by running: $ git pull https://github.com/lewismc/incubator-joshua JOSHUA-255 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-joshua/pull/4.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4 commit 3f55fe9e719ed578f417801c7abbeaca48e79e9d Author: Lewis John McGibbney <lewis.j.mcgibb...@jpl.nasa.gov> Date: 2016-04-27T14:15:13Z JOSHUA-255 License headers for all bash scripts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request: JOSHUA-254 Update README with corre...
GitHub user lewismc opened a pull request: https://github.com/apache/incubator-joshua/pull/3 JOSHUA-254 Update README with correct branding This issue addresses https://issues.apache.org/jira/browse/JOSHUA-254 You can merge this pull request into a Git repository by running: $ git pull https://github.com/lewismc/incubator-joshua JOSHUA-254 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-joshua/pull/3.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3 commit 506264b571cd4a17284ba27e86cf98421fed1b84 Author: Lewis John McGibbney <lewis.j.mcgibb...@jpl.nasa.gov> Date: 2016-04-26T18:49:05Z JOSHUA-254 Update README with correct branding --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
