Re: [jira] [Commented] (JOSHUA-291) Improve code quality via static analysis

2016-09-28 Thread Matt Post 
Great, thanks for sending the email.


> On Sep 28, 2016, at 5:13 AM, Tommaso Teofili  
> wrote:
> 
> it's fixed now [1].
> 
> Regards,
> Tommaso
> 
> [1] : https://github.com/apache/incubator-joshua
> 
> Il giorno mar 27 set 2016 alle ore 21:15 Tommaso Teofili <
> tommaso.teof...@gmail.com> ha scritto:
> 
>> Right, that's weird, it should sync automatically.
>> I've noticed that also other mirrors at apache have the same issue, maybe
>> it's related to a failure on github mirroring from yesterday, as you can
>> see from [1].
>> 
>> I'd opt for waiting a few more hours, then I'd ask infra@.
>> 
>> Regards,
>> Tommaso
>> 
>> [1] : http://status.apache.org/
>> 
>> 
>> Il giorno mar 27 set 2016 alle ore 20:38 Matt Post  ha
>> scritto:
>> 
>>> Tommaso, this looks great. One problem, though, is that while these are
>>> present on Apache master, they are for some reason not being mirrored to
>>> Github. Anyone have any idea why?
>>> 
>>> 
>>> https://git-wip-us.apache.org/repos/asf?p=incubator-joshua.git;a=summary
>>> 
>>> The last commit to Github is from 12 days ago:
>>> 
>>>https://github.com/apache/incubator-joshua/
>>> 
>>> This is supposed to be mirrored automatically, I wonder what's up?
>>> 
>>> matt
>>> 
>>> 
>>> 
 On Sep 26, 2016, at 8:30 AM, Tommaso Teofili (JIRA) 
>>> wrote:
 
 
   [
>>> https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522917#comment-15522917
>>> ]
 
 Tommaso Teofili commented on JOSHUA-291:
 
 
 I've applied a bunch of improvements to the codebase based on static
>>> code analysis, marking as resolved for now.
 
> Improve code quality via static analysis
> 
> 
>   Key: JOSHUA-291
>   URL: https://issues.apache.org/jira/browse/JOSHUA-291
>   Project: Joshua
>Issue Type: Improvement
>Components: core
>  Reporter: Tommaso Teofili
>  Assignee: Tommaso Teofili
>   Fix For: 6.1
> 
> 
> We can improve code quality / readability leveraging code analysis
>>> from tools like FindBugs and others integrated in IDEs.
 
 
 
 --
 This message was sent by Atlassian JIRA
 (v6.3.4#6332)
>>> 
>>>

[jira] [Commented] (JOSHUA-291) Improve code quality via static analysis

2016-09-28 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529058#comment-15529058
 ] 

Hudson commented on JOSHUA-291:
---

SUCCESS: Integrated in Jenkins build joshua_master #121 (See 
[https://builds.apache.org/job/joshua_master/121/])
JOSHUA-291 - minor fixes to AdaGradCore (tommaso: rev 
402b08a8715b9121ca15b1732310e66a01926e50)
* (edit) src/main/java/org/apache/joshua/adagrad/AdaGradCore.java


> Improve code quality via static analysis
> 
>
> Key: JOSHUA-291
> URL: https://issues.apache.org/jira/browse/JOSHUA-291
> Project: Joshua
>  Issue Type: Improvement
>  Components: core
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> We can improve code quality / readability leveraging code analysis from tools 
> like FindBugs and others integrated in IDEs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-291) Improve code quality via static analysis

2016-08-29 Thread Matt Post (JIRA) 

[ 
https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447853#comment-15447853
 ] 

Matt Post commented on JOSHUA-291:
--

[~maxthomas], do you want to take a look at the 7 branch? This was merged into 
master but may have gotten dropped when I merged a number of changes on master 
into 7.

> Improve code quality via static analysis
> 
>
> Key: JOSHUA-291
> URL: https://issues.apache.org/jira/browse/JOSHUA-291
> Project: Joshua
>  Issue Type: Improvement
>  Components: core
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.2
>
>
> We can improve code quality / readability leveraging code analysis from tools 
> like FindBugs and others integrated in IDEs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-291) Improve code quality via static analysis

2016-08-18 Thread Max Thomas (JIRA) 

[ 
https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426843#comment-15426843
 ] 

Max Thomas commented on JOSHUA-291:
---

Nice. I'll probably hold off a bit - I'm just getting acquainted with the code 
base, and I think there are more pressing issues, so I'll probably revisit this 
after 7 gets merged in. 

> Improve code quality via static analysis
> 
>
> Key: JOSHUA-291
> URL: https://issues.apache.org/jira/browse/JOSHUA-291
> Project: Joshua
>  Issue Type: Improvement
>  Components: core
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> We can improve code quality / readability leveraging code analysis from tools 
> like FindBugs and others integrated in IDEs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-291) Improve code quality via static analysis

2016-08-18 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426112#comment-15426112
 ] 

Hudson commented on JOSHUA-291:
---

SUCCESS: Integrated in Jenkins build joshua_master #92 (See 
[https://builds.apache.org/job/joshua_master/92/])
JOSHUA-291 - static analysis based code improvements on adagrad package 
(tommaso: rev 233818d6ce526f3a77b33110d67314b723371743)
* (edit) src/main/java/org/apache/joshua/adagrad/Optimizer.java
* (edit) src/main/java/org/apache/joshua/adagrad/AdaGradCore.java
JOSHUA-291 - static analysis based code improvements on corpus package 
(tommaso: rev 356b173d4fa3f0efa4ea53809e46c9e04c8c1ca5)
* (edit) src/main/java/org/apache/joshua/corpus/SymbolTable.java
* (edit) src/main/java/org/apache/joshua/corpus/Span.java
* (edit) src/main/java/org/apache/joshua/corpus/Phrase.java
* (edit) src/main/java/org/apache/joshua/corpus/ContiguousPhrase.java
* (edit) src/main/java/org/apache/joshua/corpus/Vocabulary.java
* (edit) src/main/java/org/apache/joshua/corpus/syntax/ArraySyntaxTree.java
* (edit) src/main/java/org/apache/joshua/corpus/syntax/SyntaxTree.java
* (edit) src/main/java/org/apache/joshua/corpus/BasicPhrase.java
JOSHUA-291 - static analysis based code improvements on decoder package 
(tommaso: rev 029cbbcc156d4939ebe503cc58962ab24728f653)
* (edit) src/main/java/org/apache/joshua/decoder/ff/SourceDependentFF.java
* (edit) 
src/main/java/org/apache/joshua/decoder/hypergraph/OutputStringExtractor.java
* (edit) 
src/main/java/org/apache/joshua/decoder/ff/lm/bloomfilter_lm/BloomFilterLanguageModel.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/Coverage.java
* (edit) 
src/main/java/org/apache/joshua/decoder/ff/tm/hash_based/ExtensionIterator.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/tm/CreateGlueGrammar.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/tm/GrammarReader.java
* (edit) src/main/java/org/apache/joshua/decoder/Decoder.java
* (edit) 
src/main/java/org/apache/joshua/decoder/ff/tm/format/MosesFormatReader.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/Hypothesis.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/PhraseChart.java
* (edit) src/main/java/org/apache/joshua/decoder/ArgsParser.java
* (edit) src/main/java/org/apache/joshua/decoder/BLEU.java
* (edit) 
src/main/java/org/apache/joshua/decoder/ff/lm/bloomfilter_lm/BloomFilter.java
* (edit) 
src/main/java/org/apache/joshua/decoder/chart_parser/ComputeNodeResult.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/fragmentlm/Trees.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/Header.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/fragmentlm/FragmentLMFF.java
* (edit) src/main/java/org/apache/joshua/decoder/Translation.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/LexicalFeatures.java
* (edit) src/main/java/org/apache/joshua/decoder/StructuredTranslation.java
* (edit) src/main/java/org/apache/joshua/decoder/JoshuaConfiguration.java
* (edit) 
src/main/java/org/apache/joshua/decoder/hypergraph/ViterbiExtractor.java
* (edit) src/main/java/org/apache/joshua/decoder/chart_parser/Chart.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/PhraseTable.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/TargetBigram.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/Candidate.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/Stacks.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/SourcePathFF.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/lm/buildin_lm/TrieLM.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/FeatureVector.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/LabelCombinationFF.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/RuleShape.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/tm/OwnerMap.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/tm/Rule.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/lm/KenLM.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/PhraseModel.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/phrase/Distortion.java
* (edit) src/main/java/org/apache/joshua/decoder/segment_file/Sentence.java
* (edit) src/main/java/org/apache/joshua/decoder/NbestMinRiskReranker.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/fragmentlm/Tree.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/tm/AbstractGrammar.java
* (edit) 
src/main/java/org/apache/joshua/decoder/ff/tm/hash_based/MemoryBasedBatchGrammar.java
* (edit) 
src/main/java/org/apache/joshua/decoder/ff/tm/SentenceFilteredGrammar.java
* (edit) src/main/java/org/apache/joshua/decoder/DecoderThread.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/lm/LanguageModelFF.java
* (edit) src/main/java/org/apache/joshua/decoder/io/JSONMessage.java
* (edit) src/main/java/org/apache/joshua/decoder/chart_parser/Cell.java
* (edit)

[jira] [Commented] (JOSHUA-291) Improve code quality via static analysis

2016-08-18 Thread Tommaso Teofili (JIRA) 

[ 
https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426067#comment-15426067
 ] 

Tommaso Teofili commented on JOSHUA-291:


I've committed some per package clean up I had been doing weeks ago, I'll now 
let [~maxthomas] go ahead with his fixes.

> Improve code quality via static analysis
> 
>
> Key: JOSHUA-291
> URL: https://issues.apache.org/jira/browse/JOSHUA-291
> Project: Joshua
>  Issue Type: Improvement
>  Components: core
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> We can improve code quality / readability leveraging code analysis from tools 
> like FindBugs and others integrated in IDEs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-291) Improve code quality via static analysis

2016-08-17 Thread Max Thomas (JIRA) 

[ 
https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424583#comment-15424583
 ] 

Max Thomas commented on JOSHUA-291:
---

alright, I'll submit some stuff I've already done on master then work off the 7 
branch. 

> Improve code quality via static analysis
> 
>
> Key: JOSHUA-291
> URL: https://issues.apache.org/jira/browse/JOSHUA-291
> Project: Joshua
>  Issue Type: Improvement
>  Components: core
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> We can improve code quality / readability leveraging code analysis from tools 
> like FindBugs and others integrated in IDEs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-291) Improve code quality via static analysis

2016-08-17 Thread Matt Post (JIRA) 

[ 
https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424280#comment-15424280
 ] 

Matt Post commented on JOSHUA-291:
--

I think either is fine. If you go the sub ticket route, it would be good to 
reference this ticket in the discussion.

One thing to be wary of: we are working on issues for the impending 6.1 
release, but are going to close that out soon. The 7 release (I just created a 
branch) involves a substantial multi-module support change to the codebase. So 
to avoid complex merges in the near future, you should (a) convince us these 
changes should go into 6.1, or (b) start basing your changes off the 7 branch. 
Once 6.1 is released in early September, we'll merge 7 back into master.

> Improve code quality via static analysis
> 
>
> Key: JOSHUA-291
> URL: https://issues.apache.org/jira/browse/JOSHUA-291
> Project: Joshua
>  Issue Type: Improvement
>  Components: core
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> We can improve code quality / readability leveraging code analysis from tools 
> like FindBugs and others integrated in IDEs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-291) Improve code quality via static analysis

2016-08-16 Thread Max Thomas (JIRA) 

[ 
https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423671#comment-15423671
 ] 

Max Thomas commented on JOSHUA-291:
---

It might be worth creating a few sub-tickets on this.

I personally have a pull request ready to go that addresses a few issues found 
by FindBugs. But, it doesn't resolve all of them. Should I submit a new issue? 
Perhaps as a sub-issue? 

In any event, there are maven plugins about findbugs that can be run inside the 
build, for example, an integration test. The accumulo project makes use of 
these, you can see their pom here: 

https://github.com/apache/accumulo/blob/master/pom.xml

> Improve code quality via static analysis
> 
>
> Key: JOSHUA-291
> URL: https://issues.apache.org/jira/browse/JOSHUA-291
> Project: Joshua
>  Issue Type: Improvement
>  Components: core
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> We can improve code quality / readability leveraging code analysis from tools 
> like FindBugs and others integrated in IDEs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)