Re: Merging 7.X into master??? + cleaning up branches
Hi Folks, On Sat, Jul 8, 2017 at 9:38 PM, <dev-digest-h...@joshua.incubator.apache.org > wrote: > > From: Matt Post <p...@cs.jhu.edu> > To: dev@joshua.incubator.apache.org > Cc: > Bcc: > Date: Tue, 4 Jul 2017 12:40:36 -0400 > Subject: Re: Merging 7.X into master??? + cleaning up branches > ...snip > I think that it would be better to focus on low-resource scenarios and > user-focused applications, instead. > > This is a valid point. IMHO there is currently NO toolkit/framework out there which makes it easy to undertake language translation tasks... Joshua in it's current state e.g. Maven artifact(s), community language packs and source downloads represent the best resource in the field and this speaks volumes towards the user-focused applications perspective you mention above Matt. Additionally, there is a still a significant win to be had from continued development of 7.X branch (as new master) with the aim of further infusion into other Apache products and communities. We also still have Incubator graduation to think about... so there is loads on the table at this stage. My opinion is that we should make an effort to forward port everything from master into 7.X and then possibly make another release as the re-architected codebase. Is there any objections to this? If you are too busy Matt, then I would step up and champion the effort. A few questions right now; 1. Which branch is 7.X? Is it [0]? Is there a JIRA ticket open for this? 2. Does anyone have a suggestion for how to forward port issues from master to 7.X? 3. Which branches can we delete to clean things up a wee bit? Thanks Lewis [0] https://github.com/apache/incubator-joshua/tree/7
Re: Merging 7.X into master??? + cleaning up branches
Whether to integrate neural stuff in Joshua is an interesting question. The research direction has been to develop fully neural systems that leave behind the phrase-based and hierarchical framework entirely. Doing this in Joshua would basically require a ground-up rewrite and is probably not worth the time. Moses has neural feature functions; for example, you can use a Nematus model as a rescore feature (though it breaks dynamic programming). This might be reasonable to implement as a project but it would be quite a bit of work and introduce GPU requirements that would raise the question of why you'd use Joshua if you had a GPU available. I think that it would be better to focus on low-resource scenarios and user-focused applications, instead. > On Jun 29, 2017, at 12:35 PM, Tommaso Teofili> wrote: > > Hi Matt, > > Il giorno gio 29 giu 2017 alle ore 05:21 Matt Post ha > scritto: > >> This is definitely a good idea. Many of these branches are dead and are >> unlikely to contain much that can be merged in, and are therefore probably >> best deleted. The plan for 7 was a big simplification of much of the guts, >> but with the transition to neural approaches in the research community, >> this is unlikely to be done unless it finds a new champion. >> > > do you think we should look at NMT in the Joshua project ? > Or is it more like you are more interested on NMT at the moment ? > Or both ? :) > > Other than that let's merge 7 to master and drop the remaining stuff, > except that for the PR for JOSHUA-290 [1] which should be merged into 7 > branch. > > Regards, > Tommaso > > [1] : https://github.com/apache/incubator-joshua/pull/71 > > >> >> >> >> >>> On Jun 28, 2017, at 3:43 AM, Tommaso Teofili >> wrote: >>> >>> +1 for both cleaning up branches *and* merging 7 branch into master. >>> >>> Regarding branches and Git let me read through the links and I'll share >> my >>> opinion. >>> >>> Regards, >>> Tommaso >>> >>> Il giorno mer 28 giu 2017 alle ore 06:41 Chris Mattmann < >> mattm...@apache.org> >>> ha scritto: >>> Hey Team, I recommend that Joshua consider adopting the Tika and/or Nutch contribution policy RE: branches and Git: https://github.com/apache/tika/#contributing-via-github https://github.com/apache/nutch/#contributing Cheers, Chris On 6/27/17, 9:36 PM, "lewis john mcgibbney" wrote: Hi Folks, Two things... 1. Currently the branches for Joshua are a bit of a mess... it would be better if they were named after JIRA issues such that the mappings back to some concrete development were explicit. Does anyone want to clean these up? 2. Now that 6.1-incubating is released and live, Is there any desire to merge 7.X branch into master and continue development there? I was not involved with the 7.X development but it looked like a significant step forward... it would be a shame for that work to stagnate. Thanks, lewis -- http://home.apache.org/~lewismc/ @hectorMcSpector http://www.linkedin.com/in/lmcgibbney >> >>
Re: Merging 7.X into master??? + cleaning up branches
Hi Matt, Il giorno gio 29 giu 2017 alle ore 05:21 Matt Postha scritto: > This is definitely a good idea. Many of these branches are dead and are > unlikely to contain much that can be merged in, and are therefore probably > best deleted. The plan for 7 was a big simplification of much of the guts, > but with the transition to neural approaches in the research community, > this is unlikely to be done unless it finds a new champion. > do you think we should look at NMT in the Joshua project ? Or is it more like you are more interested on NMT at the moment ? Or both ? :) Other than that let's merge 7 to master and drop the remaining stuff, except that for the PR for JOSHUA-290 [1] which should be merged into 7 branch. Regards, Tommaso [1] : https://github.com/apache/incubator-joshua/pull/71 > > > > > > On Jun 28, 2017, at 3:43 AM, Tommaso Teofili > wrote: > > > > +1 for both cleaning up branches *and* merging 7 branch into master. > > > > Regarding branches and Git let me read through the links and I'll share > my > > opinion. > > > > Regards, > > Tommaso > > > > Il giorno mer 28 giu 2017 alle ore 06:41 Chris Mattmann < > mattm...@apache.org> > > ha scritto: > > > >> Hey Team, > >> > >> I recommend that Joshua consider adopting the Tika and/or Nutch > >> contribution > >> policy RE: branches and Git: > >> > >> https://github.com/apache/tika/#contributing-via-github > >> https://github.com/apache/nutch/#contributing > >> > >> Cheers, > >> Chris > >> > >> > >> > >> On 6/27/17, 9:36 PM, "lewis john mcgibbney" wrote: > >> > >>Hi Folks, > >>Two things... > >> > >> 1. Currently the branches for Joshua are a bit of a mess... it > >> would be > >> better if they were named after JIRA issues such that the mappings > >> back to > >> some concrete development were explicit. Does anyone want to clean > >> these up? > >> 2. Now that 6.1-incubating is released and live, Is there any > >> desire to > >> merge 7.X branch into master and continue development there? I was > >> not > >> involved with the 7.X development but it looked like a significant > >> step > >> forward... it would be a shame for that work to stagnate. > >> > >>Thanks, > >> > >>lewis > >> > >>-- > >>http://home.apache.org/~lewismc/ > >>@hectorMcSpector > >>http://www.linkedin.com/in/lmcgibbney > >> > >> > >> > >> > >
Re: Merging 7.X into master??? + cleaning up branches
This is definitely a good idea. Many of these branches are dead and are unlikely to contain much that can be merged in, and are therefore probably best deleted. The plan for 7 was a big simplification of much of the guts, but with the transition to neural approaches in the research community, this is unlikely to be done unless it finds a new champion. > On Jun 28, 2017, at 3:43 AM, Tommaso Teofili> wrote: > > +1 for both cleaning up branches *and* merging 7 branch into master. > > Regarding branches and Git let me read through the links and I'll share my > opinion. > > Regards, > Tommaso > > Il giorno mer 28 giu 2017 alle ore 06:41 Chris Mattmann > ha scritto: > >> Hey Team, >> >> I recommend that Joshua consider adopting the Tika and/or Nutch >> contribution >> policy RE: branches and Git: >> >> https://github.com/apache/tika/#contributing-via-github >> https://github.com/apache/nutch/#contributing >> >> Cheers, >> Chris >> >> >> >> On 6/27/17, 9:36 PM, "lewis john mcgibbney" wrote: >> >>Hi Folks, >>Two things... >> >> 1. Currently the branches for Joshua are a bit of a mess... it >> would be >> better if they were named after JIRA issues such that the mappings >> back to >> some concrete development were explicit. Does anyone want to clean >> these up? >> 2. Now that 6.1-incubating is released and live, Is there any >> desire to >> merge 7.X branch into master and continue development there? I was >> not >> involved with the 7.X development but it looked like a significant >> step >> forward... it would be a shame for that work to stagnate. >> >>Thanks, >> >>lewis >> >>-- >>http://home.apache.org/~lewismc/ >>@hectorMcSpector >>http://www.linkedin.com/in/lmcgibbney >> >> >> >>
Re: Merging 7.X into master??? + cleaning up branches
+1 for both cleaning up branches *and* merging 7 branch into master. Regarding branches and Git let me read through the links and I'll share my opinion. Regards, Tommaso Il giorno mer 28 giu 2017 alle ore 06:41 Chris Mattmannha scritto: > Hey Team, > > I recommend that Joshua consider adopting the Tika and/or Nutch > contribution > policy RE: branches and Git: > > https://github.com/apache/tika/#contributing-via-github > https://github.com/apache/nutch/#contributing > > Cheers, > Chris > > > > On 6/27/17, 9:36 PM, "lewis john mcgibbney" wrote: > > Hi Folks, > Two things... > >1. Currently the branches for Joshua are a bit of a mess... it > would be >better if they were named after JIRA issues such that the mappings > back to >some concrete development were explicit. Does anyone want to clean > these up? >2. Now that 6.1-incubating is released and live, Is there any > desire to >merge 7.X branch into master and continue development there? I was > not >involved with the 7.X development but it looked like a significant > step >forward... it would be a shame for that work to stagnate. > > Thanks, > > lewis > > -- > http://home.apache.org/~lewismc/ > @hectorMcSpector > http://www.linkedin.com/in/lmcgibbney > > > >
Re: Merging 7.X into master??? + cleaning up branches
Hey Team, I recommend that Joshua consider adopting the Tika and/or Nutch contribution policy RE: branches and Git: https://github.com/apache/tika/#contributing-via-github https://github.com/apache/nutch/#contributing Cheers, Chris On 6/27/17, 9:36 PM, "lewis john mcgibbney"wrote: Hi Folks, Two things... 1. Currently the branches for Joshua are a bit of a mess... it would be better if they were named after JIRA issues such that the mappings back to some concrete development were explicit. Does anyone want to clean these up? 2. Now that 6.1-incubating is released and live, Is there any desire to merge 7.X branch into master and continue development there? I was not involved with the 7.X development but it looked like a significant step forward... it would be a shame for that work to stagnate. Thanks, lewis -- http://home.apache.org/~lewismc/ @hectorMcSpector http://www.linkedin.com/in/lmcgibbney