[jira] [Updated] (KAFKA-1711) WARN Property topic is not valid when running console producer
[ https://issues.apache.org/jira/browse/KAFKA-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Crobak updated KAFKA-1711: -- Attachment: KAFKA-1711.patch Here's a patch that fixes the warning. WARN Property topic is not valid when running console producer -- Key: KAFKA-1711 URL: https://issues.apache.org/jira/browse/KAFKA-1711 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8.2 Reporter: Jun Rao Labels: newbie Attachments: KAFKA-1711.patch bin/kafka-console-producer.sh --broker-list localhost:9092 --topic test [2014-10-17 09:54:23,984] WARN Property topic is not valid (kafka.utils.VerifiableProperties) It would be good if we can get rid of the warning. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review48877 --- Good stuff, I was able to get all binaries to build and pass tests with this patch. I think a fix to maintain compatibility with the BeanProperty change is important, but the other two aren't so much. build.gradle https://reviews.apache.org/r/23895/#comment85642 I think the file can be removed so that the exclusion isn't needed. core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala https://reviews.apache.org/r/23895/#comment85644 you need to add `def getBuffer = buffer` here and below in order to maintain backwards compatibility (those are added by the @BeanProperty annotation). You could also do something similar to `kafka.utils.Annotations_2.9+.scala` and the groovy excludes to keep the BeanProperty annotation working. gradle.properties https://reviews.apache.org/r/23895/#comment85643 I hesitate to nit, but scala 2.11.2 was released 6 days ago. Might be worth switching if it doesn't cause any issues? - Joe Crobak On July 28, 2014, 3:07 p.m., Ivan Lyutov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated July 28, 2014, 3:07 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes Diffs - build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review48957 --- build.gradle https://reviews.apache.org/r/23895/#comment85795 I think these two dependencies need to be updated. As I was trying out this code, I got some strange compile errors [1] in a downstream project. This seems to work better: + compile 'org.scala-lang.modules:scala-xml_2.11:1.0.2' + compile 'org.scala-lang.modules:scala-parser-combinators_2.11:1.0.2' That error also makes me wonder if those compile dependencies are actually needed, too. [1] java.lang.RuntimeException: Conflicting cross-version suffixes in: org.scala-lang.modules:scala-xml, org.scala-lang.modules:scala-parser-combinators - Joe Crobak On July 28, 2014, 3:07 p.m., Ivan Lyutov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated July 28, 2014, 3:07 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes Diffs - build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[
https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073651#comment-14073651
]
Joe Crobak commented on KAFKA-1419:
---
I tried out this patch earlier today, and I have a few pieces of feedback:
* I'm not sure it's possible to support both scala 2.8 and 2.11 at the same
time while using the zinc compiler. 2.8 seems to require gradle 1.6/zinc 0.2.5,
and 2.11 requires gradle 2.0/zinc 0.3.0+. It's possible that there's a version
in between that supports them, but I didn't do the binary search. Switching to
{{scalaCompileOptions.useAnt = true}} seems to compile all scala versions for
me.
* I think the {{jarAll}}, {{srcJarAll}} and other `*All` tasks should be
updated to include scala 2.11.
* scala 2.9 support seems to be broken by two things: 1) several {{else{}}}
clauses were formerly scala 2.9 specific but were converted to be scala 2.11
specific. 2) wrong zinc version being selected.
* Moving {{BeanProperty}} from {{scala.reflect}} to {{scala.beans}} is
backwards incompatible with scala 2.10. it's likely better to remove the
{{BeanProperty}} dep and implement {{def getBuffer = buffer}} in those two
places.
* scala.gradle needs an override for 2.11 like it has for 2.10.
I have a feeling that trying to support 4 versions of scala is going to be a
pain in the long run—when can scala 2.8 (and also 2.9) be dropped?
cross build for scala 2.11
--
Key: KAFKA-1419
URL: https://issues.apache.org/jira/browse/KAFKA-1419
Project: Kafka
Issue Type: Improvement
Components: clients
Affects Versions: 0.8.1
Reporter: Scott Clasen
Assignee: Ivan Lyutov
Priority: Blocker
Fix For: 0.8.2
Attachments: KAFKA-1419.patch, KAFKA-1419.patch
Please publish builds for scala 2.11, hopefully just needs a small tweak to
the gradle conf?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
