Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop Timeout and Make It Reachable by the End User

2018-05-31 Thread Jason Gustafson 
I'm going to call this vote since it has enough binding votes and it has
been open for a long time. The final tally:

Binding +4: me, Ismael, Rajini, and Guozhang
Non-binding +4: Ted, Moshe, Alex, and Dhruvil

There were no -1 votes.

Thanks to Alexander Dunayevsky for the KIP!

Thanks,
Jason

On Fri, May 11, 2018 at 8:55 AM, Guozhang Wang  wrote:

> +1 (binding), thanks!
>
>
> Guozhang
>
>
> On Thu, May 10, 2018 at 4:41 PM, Ismael Juma  wrote:
>
> > Thanks for the KIP, +1 (binding). A few suggestions:
> >
> > 1. We normally include the time unit in configs. Not sure if we do it for
> > command line parameters though, so can we please verify and make it
> > consistent?
> > 2. The KIP mentions --polling-loop-timeout and --timeout. Which is it?
> > 3. Can we include the description of the new parameter in the KIP? In the
> > PR it says "Consumer polling loop timeout", but I think this is a bit
> > unclear. What are we actually measuring here?
> >
> > Ismael
> >
> > On Mon, Apr 16, 2018 at 2:25 PM Alex Dunayevsky 
> > wrote:
> >
> > > Hello friends,
> > >
> > > Let's start the vote for KIP-281: ConsumerPerformance: Increase Polling
> > > Loop Timeout and Make It Reachable by the End User:
> > >
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 281%3A+ConsumerPerformance%3A+Increase+Polling+Loop+Timeout+
> > and+Make+It+Reachable+by+the+End+User
> > >
> > > Thank you,
> > > Alexander Dunayevsky
> > >
> >
>
>
>
> --
> -- Guozhang
>

Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop Timeout and Make It Reachable by the End User

2018-05-11 Thread Guozhang Wang 
+1 (binding), thanks!


Guozhang


On Thu, May 10, 2018 at 4:41 PM, Ismael Juma  wrote:

> Thanks for the KIP, +1 (binding). A few suggestions:
>
> 1. We normally include the time unit in configs. Not sure if we do it for
> command line parameters though, so can we please verify and make it
> consistent?
> 2. The KIP mentions --polling-loop-timeout and --timeout. Which is it?
> 3. Can we include the description of the new parameter in the KIP? In the
> PR it says "Consumer polling loop timeout", but I think this is a bit
> unclear. What are we actually measuring here?
>
> Ismael
>
> On Mon, Apr 16, 2018 at 2:25 PM Alex Dunayevsky 
> wrote:
>
> > Hello friends,
> >
> > Let's start the vote for KIP-281: ConsumerPerformance: Increase Polling
> > Loop Timeout and Make It Reachable by the End User:
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 281%3A+ConsumerPerformance%3A+Increase+Polling+Loop+Timeout+
> and+Make+It+Reachable+by+the+End+User
> >
> > Thank you,
> > Alexander Dunayevsky
> >
>



-- 
-- Guozhang

Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop Timeout and Make It Reachable by the End User

2018-05-10 Thread Ismael Juma 
Thanks for the KIP, +1 (binding). A few suggestions:

1. We normally include the time unit in configs. Not sure if we do it for
command line parameters though, so can we please verify and make it
consistent?
2. The KIP mentions --polling-loop-timeout and --timeout. Which is it?
3. Can we include the description of the new parameter in the KIP? In the
PR it says "Consumer polling loop timeout", but I think this is a bit
unclear. What are we actually measuring here?

Ismael

On Mon, Apr 16, 2018 at 2:25 PM Alex Dunayevsky 
wrote:

> Hello friends,
>
> Let's start the vote for KIP-281: ConsumerPerformance: Increase Polling
> Loop Timeout and Make It Reachable by the End User:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-281%3A+ConsumerPerformance%3A+Increase+Polling+Loop+Timeout+and+Make+It+Reachable+by+the+End+User
>
> Thank you,
> Alexander Dunayevsky
>

Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop Timeout and Make It Reachable by the End User

2018-05-09 Thread Rajini Sivaram 
+1 (binding)

Thanks for the KIP, Alex!

Regards,

Rajini

On Sat, Apr 21, 2018 at 3:35 AM, Ted Yu  wrote:

> You need two more binding votes.
>
> FYI
>
> On Thu, Apr 19, 2018 at 10:45 PM, Alex Dunayevsky 
> wrote:
>
> > +1
> >
> >
> > 4 votes total:
> >
> >   1 binding vote (Jason Gustafson)
> >
> >   3 non-binding votes (Moshe Blumberg, Ted Yu, Alex Dunayevsky)
> >
> >
> > Can we consider the voting closed?
> >
> >
> > Thank you everyone!
> >
> > Alex Dunayevsky
> >
> >
> > > Tue, 17 Apr 2018 23:28:35 GMT, Jason Gustafson 
> > wrote:
> >
> > > +1 (binding)
> > >
> > > On Tue, Apr 17, 2018 at 9:04 AM, > Moshe Blumberg > <
> > mos...@hotmail.co.uk>
> > wrote:
> >
> > > +1
> > >
> > >
> > > 
> > > From: Ted Yu 
> > > Sent: 16 April 2018 22:43
> > > To: dev@kafka.apache.org
> > > Subject: Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop
> > > Timeout and Make It Reachable by the End User
> > > >
> > > > +1
> > > >
> > > > On Mon, Apr 16, 2018 at 2:25 PM, Alex Dunayevsky <
> > a.dunayev...@gmail.com>
> > > wrote:
> > > >
> > > > > Hello friends,
> > > > >
> > > > > Let's start the vote for KIP-281: ConsumerPerformance: Increase
> > Polling
> > > > > Loop Timeout and Make It Reachable by the End User:
> > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > > 281%3A+ConsumerPerformance%3A+Increase+Polling+Loop+Timeout+
> > > > > and+Make+It+Reachable+by+the+End+User
> > > > >
> > > > > Thank you,
> > > > > Alexander Dunayevsky
> > > >
> > >
> >
>

Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop Timeout and Make It Reachable by the End User

2018-04-20 Thread Ted Yu 
You need two more binding votes.

FYI

On Thu, Apr 19, 2018 at 10:45 PM, Alex Dunayevsky 
wrote:

> +1
>
>
> 4 votes total:
>
>   1 binding vote (Jason Gustafson)
>
>   3 non-binding votes (Moshe Blumberg, Ted Yu, Alex Dunayevsky)
>
>
> Can we consider the voting closed?
>
>
> Thank you everyone!
>
> Alex Dunayevsky
>
>
> > Tue, 17 Apr 2018 23:28:35 GMT, Jason Gustafson 
> wrote:
>
> > +1 (binding)
> >
> > On Tue, Apr 17, 2018 at 9:04 AM, > Moshe Blumberg > <
> mos...@hotmail.co.uk>
> wrote:
>
> > +1
> >
> >
> > 
> > From: Ted Yu 
> > Sent: 16 April 2018 22:43
> > To: dev@kafka.apache.org
> > Subject: Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop
> > Timeout and Make It Reachable by the End User
> > >
> > > +1
> > >
> > > On Mon, Apr 16, 2018 at 2:25 PM, Alex Dunayevsky <
> a.dunayev...@gmail.com>
> > wrote:
> > >
> > > > Hello friends,
> > > >
> > > > Let's start the vote for KIP-281: ConsumerPerformance: Increase
> Polling
> > > > Loop Timeout and Make It Reachable by the End User:
> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > 281%3A+ConsumerPerformance%3A+Increase+Polling+Loop+Timeout+
> > > > and+Make+It+Reachable+by+the+End+User
> > > >
> > > > Thank you,
> > > > Alexander Dunayevsky
> > >
> >
>

Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop Timeout and Make It Reachable by the End User

2018-04-20 Thread Dhruvil Shah 
+1 from me as well. I was going to file a JIRA for this exact same problem.
:-)

On Thu, Apr 19, 2018 at 10:45 PM, Alex Dunayevsky 
wrote:

> +1
>
>
> 4 votes total:
>
>   1 binding vote (Jason Gustafson)
>
>   3 non-binding votes (Moshe Blumberg, Ted Yu, Alex Dunayevsky)
>
>
> Can we consider the voting closed?
>
>
> Thank you everyone!
>
> Alex Dunayevsky
>
>
> > Tue, 17 Apr 2018 23:28:35 GMT, Jason Gustafson 
> wrote:
>
> > +1 (binding)
> >
> > On Tue, Apr 17, 2018 at 9:04 AM, > Moshe Blumberg > <
> mos...@hotmail.co.uk>
> wrote:
>
> > +1
> >
> >
> > 
> > From: Ted Yu 
> > Sent: 16 April 2018 22:43
> > To: dev@kafka.apache.org
> > Subject: Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop
> > Timeout and Make It Reachable by the End User
> > >
> > > +1
> > >
> > > On Mon, Apr 16, 2018 at 2:25 PM, Alex Dunayevsky <
> a.dunayev...@gmail.com>
> > wrote:
> > >
> > > > Hello friends,
> > > >
> > > > Let's start the vote for KIP-281: ConsumerPerformance: Increase
> Polling
> > > > Loop Timeout and Make It Reachable by the End User:
> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > 281%3A+ConsumerPerformance%3A+Increase+Polling+Loop+Timeout+
> > > > and+Make+It+Reachable+by+the+End+User
> > > >
> > > > Thank you,
> > > > Alexander Dunayevsky
> > >
> >
>

Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop Timeout and Make It Reachable by the End User

2018-04-19 Thread Alex Dunayevsky 
+1


4 votes total:

  1 binding vote (Jason Gustafson)

  3 non-binding votes (Moshe Blumberg, Ted Yu, Alex Dunayevsky)


Can we consider the voting closed?


Thank you everyone!

Alex Dunayevsky


> Tue, 17 Apr 2018 23:28:35 GMT, Jason Gustafson  wrote:

> +1 (binding)
>
> On Tue, Apr 17, 2018 at 9:04 AM, > Moshe Blumberg > 
wrote:

> +1
>
>
> 
> From: Ted Yu 
> Sent: 16 April 2018 22:43
> To: dev@kafka.apache.org
> Subject: Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop
> Timeout and Make It Reachable by the End User
> >
> > +1
> >
> > On Mon, Apr 16, 2018 at 2:25 PM, Alex Dunayevsky 
> wrote:
> >
> > > Hello friends,
> > >
> > > Let's start the vote for KIP-281: ConsumerPerformance: Increase Polling
> > > Loop Timeout and Make It Reachable by the End User:
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 281%3A+ConsumerPerformance%3A+Increase+Polling+Loop+Timeout+
> > > and+Make+It+Reachable+by+the+End+User
> > >
> > > Thank you,
> > > Alexander Dunayevsky
> >
>

Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop Timeout and Make It Reachable by the End User

2018-04-17 Thread Jason Gustafson 
+1 (binding)

On Tue, Apr 17, 2018 at 9:04 AM, Moshe Blumberg 
wrote:

> +1
>
>
> 
> From: Ted Yu 
> Sent: 16 April 2018 22:43
> To: dev@kafka.apache.org
> Subject: Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop
> Timeout and Make It Reachable by the End User
>
> +1
>
> On Mon, Apr 16, 2018 at 2:25 PM, Alex Dunayevsky 
> wrote:
>
> > Hello friends,
> >
> > Let's start the vote for KIP-281: ConsumerPerformance: Increase Polling
> > Loop Timeout and Make It Reachable by the End User:
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 281%3A+ConsumerPerformance%3A+Increase+Polling+Loop+Timeout+
> > and+Make+It+Reachable+by+the+End+User
> >
> > Thank you,
> > Alexander Dunayevsky
> >
>

Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop Timeout and Make It Reachable by the End User

2018-04-17 Thread Moshe Blumberg 
+1



From: Ted Yu 
Sent: 16 April 2018 22:43
To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop Timeout 
and Make It Reachable by the End User

+1

On Mon, Apr 16, 2018 at 2:25 PM, Alex Dunayevsky 
wrote:

> Hello friends,
>
> Let's start the vote for KIP-281: ConsumerPerformance: Increase Polling
> Loop Timeout and Make It Reachable by the End User:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 281%3A+ConsumerPerformance%3A+Increase+Polling+Loop+Timeout+
> and+Make+It+Reachable+by+the+End+User
>
> Thank you,
> Alexander Dunayevsky
>

Re: [VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop Timeout and Make It Reachable by the End User

2018-04-16 Thread Ted Yu 
+1

On Mon, Apr 16, 2018 at 2:25 PM, Alex Dunayevsky 
wrote:

> Hello friends,
>
> Let's start the vote for KIP-281: ConsumerPerformance: Increase Polling
> Loop Timeout and Make It Reachable by the End User:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 281%3A+ConsumerPerformance%3A+Increase+Polling+Loop+Timeout+
> and+Make+It+Reachable+by+the+End+User
>
> Thank you,
> Alexander Dunayevsky
>

[VOTE] KIP-281: ConsumerPerformance: Increase Polling Loop Timeout and Make It Reachable by the End User

2018-04-16 Thread Alex Dunayevsky 
Hello friends,

Let's start the vote for KIP-281: ConsumerPerformance: Increase Polling
Loop Timeout and Make It Reachable by the End User:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-281%3A+ConsumerPerformance%3A+Increase+Polling+Loop+Timeout+and+Make+It+Reachable+by+the+End+User

Thank you,
Alexander Dunayevsky