[VOTE] KIP-346 - Improve LogCleaner behavior on error

[Stanislav Kozlovski]

Hey everybody,
I'm starting a vote on KIP-346


-- 
Best,
Stanislav

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

[Thomas Becker]

+1 (non-binding)

We've hit issues with the log cleaner in the past, and this would be a great 
improvement.
On Tue, 2018-08-07 at 12:19 +0100, Stanislav Kozlovski wrote:

Hey everybody,

I'm starting a vote on KIP-346







This email and any attachments may contain confidential and privileged material 
for the sole use of the intended recipient. Any review, copying, or 
distribution of this email (or any attachments) by others is prohibited. If you 
are not the intended recipient, please contact the sender immediately and 
permanently delete this email and any attachments. No employee or agent of TiVo 
Inc. is authorized to conclude any binding agreement on behalf of TiVo Inc. by 
email. Binding agreements with TiVo Inc. may only be made by a signed written 
agreement.

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

[Ted Yu]

+1

On Tue, Aug 7, 2018 at 5:25 AM Thomas Becker  wrote:

> +1 (non-binding)
>
> We've hit issues with the log cleaner in the past, and this would be a
> great improvement.
> On Tue, 2018-08-07 at 12:19 +0100, Stanislav Kozlovski wrote:
>
> Hey everybody,
>
> I'm starting a vote on KIP-346
>
> <
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error
> >
>
>
>
> 
>
> This email and any attachments may contain confidential and privileged
> material for the sole use of the intended recipient. Any review, copying,
> or distribution of this email (or any attachments) by others is prohibited.
> If you are not the intended recipient, please contact the sender
> immediately and permanently delete this email and any attachments. No
> employee or agent of TiVo Inc. is authorized to conclude any binding
> agreement on behalf of TiVo Inc. by email. Binding agreements with TiVo
> Inc. may only be made by a signed written agreement.
>

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

[Ray Chiang]

+1 (non-binding)

-Ray

On 8/7/18 9:26 AM, Ted Yu wrote:

+1

On Tue, Aug 7, 2018 at 5:25 AM Thomas Becker  wrote:


+1 (non-binding)

We've hit issues with the log cleaner in the past, and this would be a
great improvement.
On Tue, 2018-08-07 at 12:19 +0100, Stanislav Kozlovski wrote:

Hey everybody,

I'm starting a vote on KIP-346

<
https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error




This email and any attachments may contain confidential and privileged
material for the sole use of the intended recipient. Any review, copying,
or distribution of this email (or any attachments) by others is prohibited.
If you are not the intended recipient, please contact the sender
immediately and permanently delete this email and any attachments. No
employee or agent of TiVo Inc. is authorized to conclude any binding
agreement on behalf of TiVo Inc. by email. Binding agreements with TiVo
Inc. may only be made by a signed written agreement.

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

[Manikumar]

+1 (non-binding)

Thanks for the KIP.

On Tue, Aug 7, 2018 at 10:42 PM Ray Chiang  wrote:

> +1 (non-binding)
>
> -Ray
>
> On 8/7/18 9:26 AM, Ted Yu wrote:
> > +1
> >
> > On Tue, Aug 7, 2018 at 5:25 AM Thomas Becker 
> wrote:
> >
> >> +1 (non-binding)
> >>
> >> We've hit issues with the log cleaner in the past, and this would be a
> >> great improvement.
> >> On Tue, 2018-08-07 at 12:19 +0100, Stanislav Kozlovski wrote:
> >>
> >> Hey everybody,
> >>
> >> I'm starting a vote on KIP-346
> >>
> >> <
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error
> >>
> >>
> >> 
> >>
> >> This email and any attachments may contain confidential and privileged
> >> material for the sole use of the intended recipient. Any review,
> copying,
> >> or distribution of this email (or any attachments) by others is
> prohibited.
> >> If you are not the intended recipient, please contact the sender
> >> immediately and permanently delete this email and any attachments. No
> >> employee or agent of TiVo Inc. is authorized to conclude any binding
> >> agreement on behalf of TiVo Inc. by email. Binding agreements with TiVo
> >> Inc. may only be made by a signed written agreement.
> >>
>
>

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

[Harsha]

+1 (binding)

Thanks,
Harsha

On Tue, Aug 7, 2018, at 10:22 AM, Manikumar wrote:
> +1 (non-binding)
> 
> Thanks for the KIP.
> 
> On Tue, Aug 7, 2018 at 10:42 PM Ray Chiang  wrote:
> 
> > +1 (non-binding)
> >
> > -Ray
> >
> > On 8/7/18 9:26 AM, Ted Yu wrote:
> > > +1
> > >
> > > On Tue, Aug 7, 2018 at 5:25 AM Thomas Becker 
> > wrote:
> > >
> > >> +1 (non-binding)
> > >>
> > >> We've hit issues with the log cleaner in the past, and this would be a
> > >> great improvement.
> > >> On Tue, 2018-08-07 at 12:19 +0100, Stanislav Kozlovski wrote:
> > >>
> > >> Hey everybody,
> > >>
> > >> I'm starting a vote on KIP-346
> > >>
> > >> <
> > >>
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error
> > >>
> > >>
> > >> 
> > >>
> > >> This email and any attachments may contain confidential and privileged
> > >> material for the sole use of the intended recipient. Any review,
> > copying,
> > >> or distribution of this email (or any attachments) by others is
> > prohibited.
> > >> If you are not the intended recipient, please contact the sender
> > >> immediately and permanently delete this email and any attachments. No
> > >> employee or agent of TiVo Inc. is authorized to conclude any binding
> > >> agreement on behalf of TiVo Inc. by email. Binding agreements with TiVo
> > >> Inc. may only be made by a signed written agreement.
> > >>
> >
> >

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

[Gwen Shapira]

+1 (binding)

On Tue, Aug 7, 2018 at 4:19 AM, Stanislav Kozlovski 
wrote:

> Hey everybody,
> I'm starting a vote on KIP-346
>  346+-+Improve+LogCleaner+behavior+on+error>
>
> --
> Best,
> Stanislav
>



-- 
*Gwen Shapira*
Product Manager | Confluent
650.450.2760 | @gwenshap
Follow us: Twitter  | blog

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

[Mickael Maison]

+1 (non-binding)
Thanks for the KIP!
On Tue, Aug 7, 2018 at 6:53 PM Gwen Shapira  wrote:
>
> +1 (binding)
>
> On Tue, Aug 7, 2018 at 4:19 AM, Stanislav Kozlovski 
> wrote:
>
> > Hey everybody,
> > I'm starting a vote on KIP-346
> >  > 346+-+Improve+LogCleaner+behavior+on+error>
> >
> > --
> > Best,
> > Stanislav
> >
>
>
>
> --
> *Gwen Shapira*
> Product Manager | Confluent
> 650.450.2760 | @gwenshap
> Follow us: Twitter  | blog
> 

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

[Colin McCabe]

+1 (non-binding)

best,
Colin

On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote:
> Hey everybody,
> I'm starting a vote on KIP-346
> 
> 
> -- 
> Best,
> Stanislav

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

[Dhruvil Shah]

Thanks for the KIP, Stanislav! +1 (non-binding)

- Dhruvil

On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe  wrote:

> +1 (non-binding)
>
> best,
> Colin
>
> On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote:
> > Hey everybody,
> > I'm starting a vote on KIP-346
> > <
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-346+-+Improve+LogCleaner+behavior+on+error
> >
> >
> > --
> > Best,
> > Stanislav
>

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

[Jason Gustafson]

+1 Thanks for the KIP! I'd suggest mentioning the configurations that were
previously proposed in the rejected alternatives section. We may reconsider
them in the future.

On Mon, Aug 13, 2018 at 9:48 AM, Dhruvil Shah  wrote:

> Thanks for the KIP, Stanislav! +1 (non-binding)
>
> - Dhruvil
>
> On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe  wrote:
>
> > +1 (non-binding)
> >
> > best,
> > Colin
> >
> > On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote:
> > > Hey everybody,
> > > I'm starting a vote on KIP-346
> > > <
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 346+-+Improve+LogCleaner+behavior+on+error
> > >
> > >
> > > --
> > > Best,
> > > Stanislav
> >
>

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

[Stanislav Kozlovski]

Hi everybody,

@Jason - I've updated the section. Thanks for the reminder

I'm glad to say that the vote *has passed* with 3 binding votes (Jason,
Gwen, Harsha) and 6 non-binding votes (Dhruvil, Colin, Mickael, Manikumar,
Ray, Ted, Thomas).

The PR is ready for review at https://github.com/apache/kafka/pull/5439

On Tue, Aug 21, 2018 at 4:55 PM Jason Gustafson  wrote:

> +1 Thanks for the KIP! I'd suggest mentioning the configurations that were
> previously proposed in the rejected alternatives section. We may reconsider
> them in the future.
>
> On Mon, Aug 13, 2018 at 9:48 AM, Dhruvil Shah 
> wrote:
>
> > Thanks for the KIP, Stanislav! +1 (non-binding)
> >
> > - Dhruvil
> >
> > On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe  wrote:
> >
> > > +1 (non-binding)
> > >
> > > best,
> > > Colin
> > >
> > > On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote:
> > > > Hey everybody,
> > > > I'm starting a vote on KIP-346
> > > > <
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 346+-+Improve+LogCleaner+behavior+on+error
> > > >
> > > >
> > > > --
> > > > Best,
> > > > Stanislav
> > >
> >
>


-- 
Best,
Stanislav

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

[Jun Rao]

Hi, Stan,

Thanks for the KIP. Looks good to me overall. Just one comment below.

uncleanable-partitions-count is per logDir, but uncleanable-bytes is not.
Should we make them consistent?

Jun


On Wed, Aug 22, 2018 at 4:15 AM, Stanislav Kozlovski  wrote:

> Hi everybody,
>
> @Jason - I've updated the section. Thanks for the reminder
>
> I'm glad to say that the vote *has passed* with 3 binding votes (Jason,
> Gwen, Harsha) and 6 non-binding votes (Dhruvil, Colin, Mickael, Manikumar,
> Ray, Ted, Thomas).
>
> The PR is ready for review at https://github.com/apache/kafka/pull/5439
>
> On Tue, Aug 21, 2018 at 4:55 PM Jason Gustafson 
> wrote:
>
> > +1 Thanks for the KIP! I'd suggest mentioning the configurations that
> were
> > previously proposed in the rejected alternatives section. We may
> reconsider
> > them in the future.
> >
> > On Mon, Aug 13, 2018 at 9:48 AM, Dhruvil Shah 
> > wrote:
> >
> > > Thanks for the KIP, Stanislav! +1 (non-binding)
> > >
> > > - Dhruvil
> > >
> > > On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe 
> wrote:
> > >
> > > > +1 (non-binding)
> > > >
> > > > best,
> > > > Colin
> > > >
> > > > On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote:
> > > > > Hey everybody,
> > > > > I'm starting a vote on KIP-346
> > > > > <
> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 346+-+Improve+LogCleaner+behavior+on+error
> > > > >
> > > > >
> > > > > --
> > > > > Best,
> > > > > Stanislav
> > > >
> > >
> >
>
>
> --
> Best,
> Stanislav
>

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

[Stanislav Kozlovski]

Hi Jun,

Yes, my intention was to have them per logDir but I failed to mention it in
the KIP. Updated.

Thanks,
Stan

On Fri, Aug 24, 2018 at 12:00 AM Jun Rao  wrote:

> Hi, Stan,
>
> Thanks for the KIP. Looks good to me overall. Just one comment below.
>
> uncleanable-partitions-count is per logDir, but uncleanable-bytes is not.
> Should we make them consistent?
>
> Jun
>
>
> On Wed, Aug 22, 2018 at 4:15 AM, Stanislav Kozlovski <
> stanis...@confluent.io
> > wrote:
>
> > Hi everybody,
> >
> > @Jason - I've updated the section. Thanks for the reminder
> >
> > I'm glad to say that the vote *has passed* with 3 binding votes (Jason,
> > Gwen, Harsha) and 6 non-binding votes (Dhruvil, Colin, Mickael,
> Manikumar,
> > Ray, Ted, Thomas).
> >
> > The PR is ready for review at https://github.com/apache/kafka/pull/5439
> >
> > On Tue, Aug 21, 2018 at 4:55 PM Jason Gustafson 
> > wrote:
> >
> > > +1 Thanks for the KIP! I'd suggest mentioning the configurations that
> > were
> > > previously proposed in the rejected alternatives section. We may
> > reconsider
> > > them in the future.
> > >
> > > On Mon, Aug 13, 2018 at 9:48 AM, Dhruvil Shah 
> > > wrote:
> > >
> > > > Thanks for the KIP, Stanislav! +1 (non-binding)
> > > >
> > > > - Dhruvil
> > > >
> > > > On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe 
> > wrote:
> > > >
> > > > > +1 (non-binding)
> > > > >
> > > > > best,
> > > > > Colin
> > > > >
> > > > > On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote:
> > > > > > Hey everybody,
> > > > > > I'm starting a vote on KIP-346
> > > > > > <
> > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > 346+-+Improve+LogCleaner+behavior+on+error
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Best,
> > > > > > Stanislav
> > > > >
> > > >
> > >
> >
> >
> > --
> > Best,
> > Stanislav
> >
>


-- 
Best,
Stanislav

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

[Stanislav Kozlovski]

Hi,

I just wanted to remind everybody that the this KIP has been accepted. The
only thing left is for it to pass PR reviews and get merged for 2.1. PR:
https://github.com/apache/kafka/pull/5439

On Fri, Aug 24, 2018 at 11:12 AM Stanislav Kozlovski 
wrote:

> Hi Jun,
>
> Yes, my intention was to have them per logDir but I failed to mention it
> in the KIP. Updated.
>
> Thanks,
> Stan
>
> On Fri, Aug 24, 2018 at 12:00 AM Jun Rao  wrote:
>
>> Hi, Stan,
>>
>> Thanks for the KIP. Looks good to me overall. Just one comment below.
>>
>> uncleanable-partitions-count is per logDir, but uncleanable-bytes is not.
>> Should we make them consistent?
>>
>> Jun
>>
>>
>> On Wed, Aug 22, 2018 at 4:15 AM, Stanislav Kozlovski <
>> stanis...@confluent.io
>> > wrote:
>>
>> > Hi everybody,
>> >
>> > @Jason - I've updated the section. Thanks for the reminder
>> >
>> > I'm glad to say that the vote *has passed* with 3 binding votes (Jason,
>> > Gwen, Harsha) and 6 non-binding votes (Dhruvil, Colin, Mickael,
>> Manikumar,
>> > Ray, Ted, Thomas).
>> >
>> > The PR is ready for review at https://github.com/apache/kafka/pull/5439
>> >
>> > On Tue, Aug 21, 2018 at 4:55 PM Jason Gustafson 
>> > wrote:
>> >
>> > > +1 Thanks for the KIP! I'd suggest mentioning the configurations that
>> > were
>> > > previously proposed in the rejected alternatives section. We may
>> > reconsider
>> > > them in the future.
>> > >
>> > > On Mon, Aug 13, 2018 at 9:48 AM, Dhruvil Shah 
>> > > wrote:
>> > >
>> > > > Thanks for the KIP, Stanislav! +1 (non-binding)
>> > > >
>> > > > - Dhruvil
>> > > >
>> > > > On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe 
>> > wrote:
>> > > >
>> > > > > +1 (non-binding)
>> > > > >
>> > > > > best,
>> > > > > Colin
>> > > > >
>> > > > > On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote:
>> > > > > > Hey everybody,
>> > > > > > I'm starting a vote on KIP-346
>> > > > > > <
>> > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>> > > > 346+-+Improve+LogCleaner+behavior+on+error
>> > > > > >
>> > > > > >
>> > > > > > --
>> > > > > > Best,
>> > > > > > Stanislav
>> > > > >
>> > > >
>> > >
>> >
>> >
>> > --
>> > Best,
>> > Stanislav
>> >
>>
>
>
> --
> Best,
> Stanislav
>


-- 
Best,
Stanislav