Re: [VOTE] KIP-779: Allow Source Tasks to Handle Producer Exceptions
Hi Knowles, No, just the update to the KIP page itself and the KIP index. Cheers, Tom On Mon, Nov 29, 2021 at 6:26 PM Knowles Atchison Jr wrote: > Thank you all for voting! > > KIP-779 has been approved: > > 3 binding votes (John, Mickael, Tom) > 4 non-binding votes (Knowles, Chris S., Chris E., Arjun) > > The vote is now closed. Other than modifying the wiki, is anything > additional I need to do vote wise? > > Knowles > > On Mon, Nov 29, 2021 at 10:49 AM Tom Bentley wrote: > > > Hi Knowles, > > > > Thanks for the KIP, +1 (binding) > > > > Kind regards, > > > > Tom > > > > On 11/29/21, Mickael Maison wrote: > > > Hi Knowles, > > > > > > +1 (binding) > > > > > > Thanks for the KIP! > > > > > > On Mon, Nov 29, 2021 at 12:56 PM Knowles Atchison Jr > > > wrote: > > >> > > >> Good morning, > > >> > > >> Bringing this back to the top. > > >> > > >> We currently have > > >> > > >> 1 binding > > >> 4 non-binding > > >> > > >> Knowles > > >> > > >> On Fri, Nov 19, 2021 at 10:02 AM Knowles Atchison Jr > > >> > > >> wrote: > > >> > > >> > Thank you all for voting. We still need two more binding votes. > > >> > > > >> > I have rebased and updated the PR to be ready to go once this vote > > >> > passes: > > >> > > > >> > https://github.com/apache/kafka/pull/11382 > > >> > > > >> > Knowles > > >> > > > >> > On Tue, Nov 16, 2021 at 3:43 PM Chris Egerton > > >> > > > >> > wrote: > > >> > > > >> >> +1 (non-binding). Thanks Knowles! > > >> >> > > >> >> On Tue, Nov 16, 2021 at 10:48 AM Arjun Satish < > > arjun.sat...@gmail.com> > > >> >> wrote: > > >> >> > > >> >> > +1 (non-binding). Thanks for the KIP, Knowles! and appreciate the > > >> >> > follow-ups! > > >> >> > > > >> >> > On Thu, Nov 11, 2021 at 2:55 PM John Roesler < > vvcep...@apache.org> > > >> >> wrote: > > >> >> > > > >> >> > > Thanks, Knowles! > > >> >> > > > > >> >> > > I'm +1 (binding) > > >> >> > > > > >> >> > > -John > > >> >> > > > > >> >> > > On Wed, 2021-11-10 at 12:42 -0500, Christopher Shannon > > >> >> > > wrote: > > >> >> > > > +1 (non-binding). This looks good to me and will be useful > as a > > >> >> > > > way > > >> >> to > > >> >> > > > handle producer errors. > > >> >> > > > > > >> >> > > > On Mon, Nov 8, 2021 at 8:55 AM Knowles Atchison Jr < > > >> >> > > katchiso...@gmail.com> > > >> >> > > > wrote: > > >> >> > > > > > >> >> > > > > Good morning, > > >> >> > > > > > > >> >> > > > > I'd like to start a vote for KIP-779: Allow Source Tasks to > > >> >> > > > > Handle > > >> >> > > Producer > > >> >> > > > > Exceptions: > > >> >> > > > > > > >> >> > > > > > > >> >> > > > > > > >> >> > > > > >> >> > > > >> >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-779%3A+Allow+Source+Tasks+to+Handle+Producer+Exceptions > > >> >> > > > > > > >> >> > > > > The purpose of this KIP is to allow Source Tasks the option > > to > > >> >> > "ignore" > > >> >> > > > > kafka producer exceptions. After a few iterations, this is > > now > > >> >> part > > >> >> > of > > >> >> > > the > > >> >> > > > > "errors.tolerance" configuration and provides a null > > >> >> RecordMetadata > > >> >> > to > > >> >> > > > > commitRecord() in lieu of a new SourceTask interface method > > or > > >> >> worker > > >> >> > > > > configuration item. > > >> >> > > > > > > >> >> > > > > PR is here: > > >> >> > > > > > > >> >> > > > > https://github.com/apache/kafka/pull/11382 > > >> >> > > > > > > >> >> > > > > Any comments and feedback are welcome. > > >> >> > > > > > > >> >> > > > > Knowles > > >> >> > > > > > > >> >> > > > > >> >> > > > > >> >> > > > > >> >> > > > >> >> > > >> > > > > > > > > > > > >
Re: [VOTE] KIP-779: Allow Source Tasks to Handle Producer Exceptions
Thank you all for voting! KIP-779 has been approved: 3 binding votes (John, Mickael, Tom) 4 non-binding votes (Knowles, Chris S., Chris E., Arjun) The vote is now closed. Other than modifying the wiki, is anything additional I need to do vote wise? Knowles On Mon, Nov 29, 2021 at 10:49 AM Tom Bentley wrote: > Hi Knowles, > > Thanks for the KIP, +1 (binding) > > Kind regards, > > Tom > > On 11/29/21, Mickael Maison wrote: > > Hi Knowles, > > > > +1 (binding) > > > > Thanks for the KIP! > > > > On Mon, Nov 29, 2021 at 12:56 PM Knowles Atchison Jr > > wrote: > >> > >> Good morning, > >> > >> Bringing this back to the top. > >> > >> We currently have > >> > >> 1 binding > >> 4 non-binding > >> > >> Knowles > >> > >> On Fri, Nov 19, 2021 at 10:02 AM Knowles Atchison Jr > >> > >> wrote: > >> > >> > Thank you all for voting. We still need two more binding votes. > >> > > >> > I have rebased and updated the PR to be ready to go once this vote > >> > passes: > >> > > >> > https://github.com/apache/kafka/pull/11382 > >> > > >> > Knowles > >> > > >> > On Tue, Nov 16, 2021 at 3:43 PM Chris Egerton > >> > > >> > wrote: > >> > > >> >> +1 (non-binding). Thanks Knowles! > >> >> > >> >> On Tue, Nov 16, 2021 at 10:48 AM Arjun Satish < > arjun.sat...@gmail.com> > >> >> wrote: > >> >> > >> >> > +1 (non-binding). Thanks for the KIP, Knowles! and appreciate the > >> >> > follow-ups! > >> >> > > >> >> > On Thu, Nov 11, 2021 at 2:55 PM John Roesler > >> >> wrote: > >> >> > > >> >> > > Thanks, Knowles! > >> >> > > > >> >> > > I'm +1 (binding) > >> >> > > > >> >> > > -John > >> >> > > > >> >> > > On Wed, 2021-11-10 at 12:42 -0500, Christopher Shannon > >> >> > > wrote: > >> >> > > > +1 (non-binding). This looks good to me and will be useful as a > >> >> > > > way > >> >> to > >> >> > > > handle producer errors. > >> >> > > > > >> >> > > > On Mon, Nov 8, 2021 at 8:55 AM Knowles Atchison Jr < > >> >> > > katchiso...@gmail.com> > >> >> > > > wrote: > >> >> > > > > >> >> > > > > Good morning, > >> >> > > > > > >> >> > > > > I'd like to start a vote for KIP-779: Allow Source Tasks to > >> >> > > > > Handle > >> >> > > Producer > >> >> > > > > Exceptions: > >> >> > > > > > >> >> > > > > > >> >> > > > > > >> >> > > > >> >> > > >> >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-779%3A+Allow+Source+Tasks+to+Handle+Producer+Exceptions > >> >> > > > > > >> >> > > > > The purpose of this KIP is to allow Source Tasks the option > to > >> >> > "ignore" > >> >> > > > > kafka producer exceptions. After a few iterations, this is > now > >> >> part > >> >> > of > >> >> > > the > >> >> > > > > "errors.tolerance" configuration and provides a null > >> >> RecordMetadata > >> >> > to > >> >> > > > > commitRecord() in lieu of a new SourceTask interface method > or > >> >> worker > >> >> > > > > configuration item. > >> >> > > > > > >> >> > > > > PR is here: > >> >> > > > > > >> >> > > > > https://github.com/apache/kafka/pull/11382 > >> >> > > > > > >> >> > > > > Any comments and feedback are welcome. > >> >> > > > > > >> >> > > > > Knowles > >> >> > > > > > >> >> > > > >> >> > > > >> >> > > > >> >> > > >> >> > >> > > > > > > >
Re: [VOTE] KIP-779: Allow Source Tasks to Handle Producer Exceptions
Hi Knowles, Thanks for the KIP, +1 (binding) Kind regards, Tom On 11/29/21, Mickael Maison wrote: > Hi Knowles, > > +1 (binding) > > Thanks for the KIP! > > On Mon, Nov 29, 2021 at 12:56 PM Knowles Atchison Jr > wrote: >> >> Good morning, >> >> Bringing this back to the top. >> >> We currently have >> >> 1 binding >> 4 non-binding >> >> Knowles >> >> On Fri, Nov 19, 2021 at 10:02 AM Knowles Atchison Jr >> >> wrote: >> >> > Thank you all for voting. We still need two more binding votes. >> > >> > I have rebased and updated the PR to be ready to go once this vote >> > passes: >> > >> > https://github.com/apache/kafka/pull/11382 >> > >> > Knowles >> > >> > On Tue, Nov 16, 2021 at 3:43 PM Chris Egerton >> > >> > wrote: >> > >> >> +1 (non-binding). Thanks Knowles! >> >> >> >> On Tue, Nov 16, 2021 at 10:48 AM Arjun Satish >> >> wrote: >> >> >> >> > +1 (non-binding). Thanks for the KIP, Knowles! and appreciate the >> >> > follow-ups! >> >> > >> >> > On Thu, Nov 11, 2021 at 2:55 PM John Roesler >> >> wrote: >> >> > >> >> > > Thanks, Knowles! >> >> > > >> >> > > I'm +1 (binding) >> >> > > >> >> > > -John >> >> > > >> >> > > On Wed, 2021-11-10 at 12:42 -0500, Christopher Shannon >> >> > > wrote: >> >> > > > +1 (non-binding). This looks good to me and will be useful as a >> >> > > > way >> >> to >> >> > > > handle producer errors. >> >> > > > >> >> > > > On Mon, Nov 8, 2021 at 8:55 AM Knowles Atchison Jr < >> >> > > katchiso...@gmail.com> >> >> > > > wrote: >> >> > > > >> >> > > > > Good morning, >> >> > > > > >> >> > > > > I'd like to start a vote for KIP-779: Allow Source Tasks to >> >> > > > > Handle >> >> > > Producer >> >> > > > > Exceptions: >> >> > > > > >> >> > > > > >> >> > > > > >> >> > > >> >> > >> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-779%3A+Allow+Source+Tasks+to+Handle+Producer+Exceptions >> >> > > > > >> >> > > > > The purpose of this KIP is to allow Source Tasks the option to >> >> > "ignore" >> >> > > > > kafka producer exceptions. After a few iterations, this is now >> >> part >> >> > of >> >> > > the >> >> > > > > "errors.tolerance" configuration and provides a null >> >> RecordMetadata >> >> > to >> >> > > > > commitRecord() in lieu of a new SourceTask interface method or >> >> worker >> >> > > > > configuration item. >> >> > > > > >> >> > > > > PR is here: >> >> > > > > >> >> > > > > https://github.com/apache/kafka/pull/11382 >> >> > > > > >> >> > > > > Any comments and feedback are welcome. >> >> > > > > >> >> > > > > Knowles >> >> > > > > >> >> > > >> >> > > >> >> > > >> >> > >> >> >> > > >
Re: [VOTE] KIP-779: Allow Source Tasks to Handle Producer Exceptions
Hi Knowles, +1 (binding) Thanks for the KIP! On Mon, Nov 29, 2021 at 12:56 PM Knowles Atchison Jr wrote: > > Good morning, > > Bringing this back to the top. > > We currently have > > 1 binding > 4 non-binding > > Knowles > > On Fri, Nov 19, 2021 at 10:02 AM Knowles Atchison Jr > wrote: > > > Thank you all for voting. We still need two more binding votes. > > > > I have rebased and updated the PR to be ready to go once this vote passes: > > > > https://github.com/apache/kafka/pull/11382 > > > > Knowles > > > > On Tue, Nov 16, 2021 at 3:43 PM Chris Egerton > > wrote: > > > >> +1 (non-binding). Thanks Knowles! > >> > >> On Tue, Nov 16, 2021 at 10:48 AM Arjun Satish > >> wrote: > >> > >> > +1 (non-binding). Thanks for the KIP, Knowles! and appreciate the > >> > follow-ups! > >> > > >> > On Thu, Nov 11, 2021 at 2:55 PM John Roesler > >> wrote: > >> > > >> > > Thanks, Knowles! > >> > > > >> > > I'm +1 (binding) > >> > > > >> > > -John > >> > > > >> > > On Wed, 2021-11-10 at 12:42 -0500, Christopher Shannon > >> > > wrote: > >> > > > +1 (non-binding). This looks good to me and will be useful as a way > >> to > >> > > > handle producer errors. > >> > > > > >> > > > On Mon, Nov 8, 2021 at 8:55 AM Knowles Atchison Jr < > >> > > katchiso...@gmail.com> > >> > > > wrote: > >> > > > > >> > > > > Good morning, > >> > > > > > >> > > > > I'd like to start a vote for KIP-779: Allow Source Tasks to Handle > >> > > Producer > >> > > > > Exceptions: > >> > > > > > >> > > > > > >> > > > > > >> > > > >> > > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-779%3A+Allow+Source+Tasks+to+Handle+Producer+Exceptions > >> > > > > > >> > > > > The purpose of this KIP is to allow Source Tasks the option to > >> > "ignore" > >> > > > > kafka producer exceptions. After a few iterations, this is now > >> part > >> > of > >> > > the > >> > > > > "errors.tolerance" configuration and provides a null > >> RecordMetadata > >> > to > >> > > > > commitRecord() in lieu of a new SourceTask interface method or > >> worker > >> > > > > configuration item. > >> > > > > > >> > > > > PR is here: > >> > > > > > >> > > > > https://github.com/apache/kafka/pull/11382 > >> > > > > > >> > > > > Any comments and feedback are welcome. > >> > > > > > >> > > > > Knowles > >> > > > > > >> > > > >> > > > >> > > > >> > > >> > >
Re: [VOTE] KIP-779: Allow Source Tasks to Handle Producer Exceptions
Good morning, Bringing this back to the top. We currently have 1 binding 4 non-binding Knowles On Fri, Nov 19, 2021 at 10:02 AM Knowles Atchison Jr wrote: > Thank you all for voting. We still need two more binding votes. > > I have rebased and updated the PR to be ready to go once this vote passes: > > https://github.com/apache/kafka/pull/11382 > > Knowles > > On Tue, Nov 16, 2021 at 3:43 PM Chris Egerton > wrote: > >> +1 (non-binding). Thanks Knowles! >> >> On Tue, Nov 16, 2021 at 10:48 AM Arjun Satish >> wrote: >> >> > +1 (non-binding). Thanks for the KIP, Knowles! and appreciate the >> > follow-ups! >> > >> > On Thu, Nov 11, 2021 at 2:55 PM John Roesler >> wrote: >> > >> > > Thanks, Knowles! >> > > >> > > I'm +1 (binding) >> > > >> > > -John >> > > >> > > On Wed, 2021-11-10 at 12:42 -0500, Christopher Shannon >> > > wrote: >> > > > +1 (non-binding). This looks good to me and will be useful as a way >> to >> > > > handle producer errors. >> > > > >> > > > On Mon, Nov 8, 2021 at 8:55 AM Knowles Atchison Jr < >> > > katchiso...@gmail.com> >> > > > wrote: >> > > > >> > > > > Good morning, >> > > > > >> > > > > I'd like to start a vote for KIP-779: Allow Source Tasks to Handle >> > > Producer >> > > > > Exceptions: >> > > > > >> > > > > >> > > > > >> > > >> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-779%3A+Allow+Source+Tasks+to+Handle+Producer+Exceptions >> > > > > >> > > > > The purpose of this KIP is to allow Source Tasks the option to >> > "ignore" >> > > > > kafka producer exceptions. After a few iterations, this is now >> part >> > of >> > > the >> > > > > "errors.tolerance" configuration and provides a null >> RecordMetadata >> > to >> > > > > commitRecord() in lieu of a new SourceTask interface method or >> worker >> > > > > configuration item. >> > > > > >> > > > > PR is here: >> > > > > >> > > > > https://github.com/apache/kafka/pull/11382 >> > > > > >> > > > > Any comments and feedback are welcome. >> > > > > >> > > > > Knowles >> > > > > >> > > >> > > >> > > >> > >> >
Re: [VOTE] KIP-779: Allow Source Tasks to Handle Producer Exceptions
Thank you all for voting. We still need two more binding votes. I have rebased and updated the PR to be ready to go once this vote passes: https://github.com/apache/kafka/pull/11382 Knowles On Tue, Nov 16, 2021 at 3:43 PM Chris Egerton wrote: > +1 (non-binding). Thanks Knowles! > > On Tue, Nov 16, 2021 at 10:48 AM Arjun Satish > wrote: > > > +1 (non-binding). Thanks for the KIP, Knowles! and appreciate the > > follow-ups! > > > > On Thu, Nov 11, 2021 at 2:55 PM John Roesler > wrote: > > > > > Thanks, Knowles! > > > > > > I'm +1 (binding) > > > > > > -John > > > > > > On Wed, 2021-11-10 at 12:42 -0500, Christopher Shannon > > > wrote: > > > > +1 (non-binding). This looks good to me and will be useful as a way > to > > > > handle producer errors. > > > > > > > > On Mon, Nov 8, 2021 at 8:55 AM Knowles Atchison Jr < > > > katchiso...@gmail.com> > > > > wrote: > > > > > > > > > Good morning, > > > > > > > > > > I'd like to start a vote for KIP-779: Allow Source Tasks to Handle > > > Producer > > > > > Exceptions: > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-779%3A+Allow+Source+Tasks+to+Handle+Producer+Exceptions > > > > > > > > > > The purpose of this KIP is to allow Source Tasks the option to > > "ignore" > > > > > kafka producer exceptions. After a few iterations, this is now part > > of > > > the > > > > > "errors.tolerance" configuration and provides a null RecordMetadata > > to > > > > > commitRecord() in lieu of a new SourceTask interface method or > worker > > > > > configuration item. > > > > > > > > > > PR is here: > > > > > > > > > > https://github.com/apache/kafka/pull/11382 > > > > > > > > > > Any comments and feedback are welcome. > > > > > > > > > > Knowles > > > > > > > > > > > > > > > > >
Re: [VOTE] KIP-779: Allow Source Tasks to Handle Producer Exceptions
+1 (non-binding). Thanks Knowles! On Tue, Nov 16, 2021 at 10:48 AM Arjun Satish wrote: > +1 (non-binding). Thanks for the KIP, Knowles! and appreciate the > follow-ups! > > On Thu, Nov 11, 2021 at 2:55 PM John Roesler wrote: > > > Thanks, Knowles! > > > > I'm +1 (binding) > > > > -John > > > > On Wed, 2021-11-10 at 12:42 -0500, Christopher Shannon > > wrote: > > > +1 (non-binding). This looks good to me and will be useful as a way to > > > handle producer errors. > > > > > > On Mon, Nov 8, 2021 at 8:55 AM Knowles Atchison Jr < > > katchiso...@gmail.com> > > > wrote: > > > > > > > Good morning, > > > > > > > > I'd like to start a vote for KIP-779: Allow Source Tasks to Handle > > Producer > > > > Exceptions: > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-779%3A+Allow+Source+Tasks+to+Handle+Producer+Exceptions > > > > > > > > The purpose of this KIP is to allow Source Tasks the option to > "ignore" > > > > kafka producer exceptions. After a few iterations, this is now part > of > > the > > > > "errors.tolerance" configuration and provides a null RecordMetadata > to > > > > commitRecord() in lieu of a new SourceTask interface method or worker > > > > configuration item. > > > > > > > > PR is here: > > > > > > > > https://github.com/apache/kafka/pull/11382 > > > > > > > > Any comments and feedback are welcome. > > > > > > > > Knowles > > > > > > > > > > >
Re: [VOTE] KIP-779: Allow Source Tasks to Handle Producer Exceptions
+1 (non-binding). Thanks for the KIP, Knowles! and appreciate the follow-ups! On Thu, Nov 11, 2021 at 2:55 PM John Roesler wrote: > Thanks, Knowles! > > I'm +1 (binding) > > -John > > On Wed, 2021-11-10 at 12:42 -0500, Christopher Shannon > wrote: > > +1 (non-binding). This looks good to me and will be useful as a way to > > handle producer errors. > > > > On Mon, Nov 8, 2021 at 8:55 AM Knowles Atchison Jr < > katchiso...@gmail.com> > > wrote: > > > > > Good morning, > > > > > > I'd like to start a vote for KIP-779: Allow Source Tasks to Handle > Producer > > > Exceptions: > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-779%3A+Allow+Source+Tasks+to+Handle+Producer+Exceptions > > > > > > The purpose of this KIP is to allow Source Tasks the option to "ignore" > > > kafka producer exceptions. After a few iterations, this is now part of > the > > > "errors.tolerance" configuration and provides a null RecordMetadata to > > > commitRecord() in lieu of a new SourceTask interface method or worker > > > configuration item. > > > > > > PR is here: > > > > > > https://github.com/apache/kafka/pull/11382 > > > > > > Any comments and feedback are welcome. > > > > > > Knowles > > > > > >
Re: [VOTE] KIP-779: Allow Source Tasks to Handle Producer Exceptions
Thanks, Knowles! I'm +1 (binding) -John On Wed, 2021-11-10 at 12:42 -0500, Christopher Shannon wrote: > +1 (non-binding). This looks good to me and will be useful as a way to > handle producer errors. > > On Mon, Nov 8, 2021 at 8:55 AM Knowles Atchison Jr > wrote: > > > Good morning, > > > > I'd like to start a vote for KIP-779: Allow Source Tasks to Handle Producer > > Exceptions: > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-779%3A+Allow+Source+Tasks+to+Handle+Producer+Exceptions > > > > The purpose of this KIP is to allow Source Tasks the option to "ignore" > > kafka producer exceptions. After a few iterations, this is now part of the > > "errors.tolerance" configuration and provides a null RecordMetadata to > > commitRecord() in lieu of a new SourceTask interface method or worker > > configuration item. > > > > PR is here: > > > > https://github.com/apache/kafka/pull/11382 > > > > Any comments and feedback are welcome. > > > > Knowles > >
Re: [VOTE] KIP-779: Allow Source Tasks to Handle Producer Exceptions
+1 (non-binding). This looks good to me and will be useful as a way to handle producer errors. On Mon, Nov 8, 2021 at 8:55 AM Knowles Atchison Jr wrote: > Good morning, > > I'd like to start a vote for KIP-779: Allow Source Tasks to Handle Producer > Exceptions: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-779%3A+Allow+Source+Tasks+to+Handle+Producer+Exceptions > > The purpose of this KIP is to allow Source Tasks the option to "ignore" > kafka producer exceptions. After a few iterations, this is now part of the > "errors.tolerance" configuration and provides a null RecordMetadata to > commitRecord() in lieu of a new SourceTask interface method or worker > configuration item. > > PR is here: > > https://github.com/apache/kafka/pull/11382 > > Any comments and feedback are welcome. > > Knowles >
[VOTE] KIP-779: Allow Source Tasks to Handle Producer Exceptions
Good morning, I'd like to start a vote for KIP-779: Allow Source Tasks to Handle Producer Exceptions: https://cwiki.apache.org/confluence/display/KAFKA/KIP-779%3A+Allow+Source+Tasks+to+Handle+Producer+Exceptions The purpose of this KIP is to allow Source Tasks the option to "ignore" kafka producer exceptions. After a few iterations, this is now part of the "errors.tolerance" configuration and provides a null RecordMetadata to commitRecord() in lieu of a new SourceTask interface method or worker configuration item. PR is here: https://github.com/apache/kafka/pull/11382 Any comments and feedback are welcome. Knowles