[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895156#comment-13895156 ] Jun Rao commented on KAFKA-1171: Thanks for the review. Patch v15 is now committed. We can leave this jira open for other changes. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur >Priority: Blocker > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v15.patch, > kafka-1171_v6.patch, kafka-1171_v7.patch, kafka-1171_v8.patch, > kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895058#comment-13895058 ] Joel Koshy commented on KAFKA-1171: --- +1 > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur >Priority: Blocker > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v15.patch, > kafka-1171_v6.patch, kafka-1171_v7.patch, kafka-1171_v8.patch, > kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895051#comment-13895051 ] Neha Narkhede commented on KAFKA-1171: -- +1 > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur >Priority: Blocker > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v15.patch, > kafka-1171_v6.patch, kafka-1171_v7.patch, kafka-1171_v8.patch, > kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895028#comment-13895028 ] David Arthur commented on KAFKA-1171: - +1 > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur >Priority: Blocker > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v15.patch, > kafka-1171_v6.patch, kafka-1171_v7.patch, kafka-1171_v8.patch, > kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895019#comment-13895019 ] Jun Rao commented on KAFKA-1171: Just so that we don't carry the big patch for too long. I will make a small change in kafka-run-class.sh so that both sbt and gradle will work and then check in the patch. We can then iterate on it and remove sbt when everything is done. I will do that if I don't hear any objection in the next hour or so. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur >Priority: Blocker > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v15.patch, > kafka-1171_v6.patch, kafka-1171_v7.patch, kafka-1171_v8.patch, > kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894934#comment-13894934 ] Joe Stein commented on KAFKA-1171: -- yup, great, thanks that worked :) > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur >Priority: Blocker > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v15.patch, > kafka-1171_v6.patch, kafka-1171_v7.patch, kafka-1171_v8.patch, > kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894922#comment-13894922 ] David Arthur commented on KAFKA-1171: - [~joestein] I usually use "git apply" when applying patches. I think git-am is specific to the weird git email stuff > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur >Priority: Blocker > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v15.patch, > kafka-1171_v6.patch, kafka-1171_v7.patch, kafka-1171_v8.patch, > kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894916#comment-13894916 ] Joe Stein commented on KAFKA-1171: -- I tried to apply v15 (off a fresh trunk clone) git am --signoff < kafka-1171_v15.patch and got the "Patch does not have a valid e-mail address." error so I tried patch -p1 < kafka-1171_v15.patch and got all sorts of other errors from that... ./gradlew uploadArchivesAll Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain probably doing something wrong let me know so I can try out the upload artifacts, releases, build and the rest... didn't have more time to dig into I gotta run out will be back later tonight/tomorrow if anyone can help out thanks! > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur >Priority: Blocker > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v15.patch, > kafka-1171_v6.patch, kafka-1171_v7.patch, kafka-1171_v8.patch, > kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894817#comment-13894817 ] Neha Narkhede commented on KAFKA-1171: -- +1. I'm also in favor of proceeding with checkin and filing bugs for minor issues to fix right after. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur >Priority: Blocker > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v15.patch, > kafka-1171_v6.patch, kafka-1171_v7.patch, kafka-1171_v8.patch, > kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894795#comment-13894795 ] David Arthur commented on KAFKA-1171: - I'm wondering if this isn't done enough to merge. The main requirement here is that developers can build and test using Gradle, and we can do a release. I think both cases are mostly covered. Smaller fixes (of which there are plenty) to the project/build can be done outside of this issue. I just worry about this dragging on too long. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur >Priority: Blocker > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v15.patch, > kafka-1171_v6.patch, kafka-1171_v7.patch, kafka-1171_v8.patch, > kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893925#comment-13893925 ] Joel Koshy commented on KAFKA-1171: --- 1 - build.gradle: there should be a programmatic way to enumerate the versions for dependsOn as opposed to explicitly enumerating. Ideally, the versions should only be specified once in some global list. 2 - Would love it if we can avoid the additional copyDependantLibs step which is extremely annoying. It seems possible by specifying a task dependency and it is worth doing. 3 - gradlew tasks shows a number of tasks. I'm not sure if some are to be used or not. E.g., ./gradlew builds, but then is it redundant to jar? Can redundant or irrelevant tasks be hidden? Basically it would be nice to have consistency between the readme and the tasks output. I'd rather have one way to do something than several. I don't care too much but it is a bit annoying if the menu shows a lot of options when only half of them are to be used. 4 - kafka-run-class.sh: Why is it there are scala version-specific jars for dependant libs and not for kafka-perf* and kafka*? E.g., if we were to do jar_all and then kafka-run-class.sh there would be multiple jars on the classpath which is a problem - I got an exception. 5 - Can we get the stand-alone tests available in a test jar or something like that? This seems broken on the sbt side as well. 6 - Would be good to add a line to README.md on how to run a specific unit test. 7 - license plugin: seems very useful. I just ran ./gradlew licenseFormatMain and licenseFormatTest and it seems a number of files need license headers. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur >Priority: Blocker > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893674#comment-13893674 ] Neha Narkhede commented on KAFKA-1171: -- +1 on the latest patch. Few minor comments - 1. Is it gradle naming convention to have "_" in the task names. For example, test_all instead of just testall? 2. It is worth trying Jakob's suggestion above as that will improve readability of tests > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur >Priority: Blocker > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893636#comment-13893636 ] Jun Rao commented on KAFKA-1171: These commands no longer exist in the latest patch. The new commands are in README. ./gradlew uploadCoreArchives_all => ./gradlew uploadArchives_all ./gradlew build_all => ./gradlew test_all > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur >Priority: Blocker > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893576#comment-13893576 ] Neha Narkhede commented on KAFKA-1171: -- Tested patch 14. Here are some review comments - uploadCoreArchives_all (mentioned in the README) fails with the following error - [nnarkhed@nnarkhed-ld1 kafka]$ ./gradlew uploadCoreArchives_all The TaskContainer.add() method has been deprecated and is scheduled to be removed in Gradle 2.0. Please use the create() method instead. Building project 'core' with Scala version 2.8.0 Building project 'perf' with Scala version 2.8.0 FAILURE: Could not determine which tasks to execute. * What went wrong: Task 'uploadCoreArchives_all' not found in root project 'kafka'. * Try: Run gradlew tasks to get a list of available tasks. BUILD FAILED Total time: 4.577 secs :core:uploadCoreArhives fails as well - http://pastebin.com/0NkShchU Also, can we fix the comment and documentation here? README should be self sufficient and a lookup of build.gradle should not be required to run commands ./gradlew :core:uploadArchives (to test locally, see the comment in build.gradle) build_all also failed [nnarkhed@nnarkhed-ld1 kafka]$ ./gradlew build_all The TaskContainer.add() method has been deprecated and is scheduled to be removed in Gradle 2.0. Please use the create() method instead. Building project 'core' with Scala version 2.8.0 Building project 'perf' with Scala version 2.8.0 FAILURE: Could not determine which tasks to execute. * What went wrong: Task 'build_all' not found in root project 'kafka'. * Try: Run gradlew tasks to get a list of available tasks. BUILD FAILED Total time: 4.672 secs > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892908#comment-13892908 ] Jakob Homan commented on KAFKA-1171: There's the test output html, but you can also have gradle be more chatty about which tests it's running/run: http://forums.gradle.org/gradle/topics/whats_new_in_gradle_1_1_test_logging > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892463#comment-13892463 ] Guozhang Wang commented on KAFKA-1171: -- When I run ./gradlew -Dtest.single=RequestResponseSerializationTest core:test, I get: - The TaskContainer.add() method has been deprecated and is scheduled to be removed in Gradle 2.0. Please use the create() method instead. Building project 'core' with Scala version 2.8.0 Building project 'perf' with Scala version 2.8.0 :core:compileJava UP-TO-DATE :core:compileScala UP-TO-DATE :core:processResources UP-TO-DATE :core:classes UP-TO-DATE :core:compileTestJava UP-TO-DATE :core:compileTestScala UP-TO-DATE :core:processTestResources UP-TO-DATE :core:testClasses UP-TO-DATE :core:test BUILD SUCCESSFUL Total time: 1 mins 19.067 secs -- Which is similar when I run ./gradlew build, except for more tasks UP-TO-DATE, so is there a way to show which tests have been actually executed? > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892366#comment-13892366 ] Jun Rao commented on KAFKA-1171: Guozhang, I tried ./gradlew -Dtest.single=RequestResponseSerializationTest core:test and it only ran 1 test. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892351#comment-13892351 ] Guozhang Wang commented on KAFKA-1171: -- Wondering how to run a single unit test: ./gradlew -Dtest.single=RequestResponseSerializationTest core:test would execute all the tests in cores. ./gradlew -Dtest.single=RequestResponseSerializationTest core:test:[SpecificTestName] seems not the correct syntax. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch, > kafka-1171_v13.patch, kafka-1171_v6.patch, kafka-1171_v7.patch, > kafka-1171_v8.patch, kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[
https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891820#comment-13891820
]
Jun Rao commented on KAFKA-1171:
The unit tests issue for scala 2.10.x is caused by scalatest version. In sbt,
we have the following
libraryDependencies <<= (scalaVersion, libraryDependencies) { (sv, deps) =>
deps :+ (sv match {
case "2.8.0" => "org.scalatest" % "scalatest" % "1.2" % "test"
case v if v.startsWith("2.10") => "org.scalatest" %% "scalatest" % "1.9.1"
% "test"
case _ => "org.scalatest" %% "scalatest" % "1.8" % "test"
})
}
Need to figure out how to add the correct scalatest dependency in gradle.
> Gradle build for Kafka
> --
>
> Key: KAFKA-1171
> URL: https://issues.apache.org/jira/browse/KAFKA-1171
> Project: Kafka
> Issue Type: Improvement
> Components: packaging
>Affects Versions: 0.8.1, 0.9.0
>Reporter: David Arthur
>Assignee: David Arthur
> Attachments: 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v6.patch,
> kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch
>
>
> We have previously discussed moving away from SBT to an
> easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a
> patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted
> to check out Gradle as well.
> 1. https://issues.apache.org/jira/browse/KAFKA-855
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891612#comment-13891612 ] Neha Narkhede commented on KAFKA-1171: -- Thanks for the patch, Jun. 1. ./gradlew copyDependantLibs Is it a standard gradle command or did we create it? If we created it, can we rename it to assembleDependencies? 2. Random nitpick: Why is everything ./gradlew and not simply ./gradle? 3. Most unit tests fail on Scala 2.10.x. These pass on sbt though (./sbt "++2.10.0 test") > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[
https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891472#comment-13891472
]
David Arthur commented on KAFKA-1171:
-
Jun, that's fine. I added the subproject name because it was causing a conflict
when publishing to Nexus since our artifact pattern is just
kafka-${scalaVersion} - so "perf" and "core" were producing the same artifact.
It does appear that we publish "kafka", "kafka-perf", and "contrib" artifacts
to Maven Central.
If keeping the name consistent with 0.8.0 is important, then we can do some
scripting in the build to achieve this, but otherwise it's simpler to add the
subproject name to the artifact.
On a related note, are there plans to split the artifacts up into core, server,
and client? Maybe after [~jkreps]'s client refactoring?
> Gradle build for Kafka
> --
>
> Key: KAFKA-1171
> URL: https://issues.apache.org/jira/browse/KAFKA-1171
> Project: Kafka
> Issue Type: Improvement
> Components: packaging
>Affects Versions: 0.8.1, 0.9.0
>Reporter: David Arthur
>Assignee: David Arthur
> Attachments: 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v6.patch,
> kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch
>
>
> We have previously discussed moving away from SBT to an
> easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a
> patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted
> to check out Gradle as well.
> 1. https://issues.apache.org/jira/browse/KAFKA-855
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890828#comment-13890828 ] Jay Kreps commented on KAFKA-1171: -- My impression is that people who use Scala have mostly moved on. People who don't use Scala should actually use 2.9 as its supposed to be a bit faster. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890404#comment-13890404 ] Jun Rao commented on KAFKA-1171: Jay, Is there any benefit of not defaulting to 2.8.0? I was thinking that we should probably stay with the lowest supported scala version as the default. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890403#comment-13890403 ] Jun Rao commented on KAFKA-1171: David, I don't think there is any outstanding issue. Could you help check the pom file? > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890278#comment-13890278 ] David Arthur commented on KAFKA-1171: - I've seen some transient test failures as well, can't remember off hand what they are though. Once the build is finalized, I think a good next step would be to get some CI going. [~junrao], are there any more outstanding issues? > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[
https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890276#comment-13890276
]
Guozhang Wang commented on KAFKA-1171:
--
Tried v9 with all the functionalities, a few observations:
-
1. When apply the patch some warnings are shown.
[guwang@guwang-ld2 kafka_1171v8]$ git apply kafka-1171_v9.patch
kafka-1171_v9.patch:168: trailing whitespace.
kafka-1171_v9.patch:286: trailing whitespace.
tasks.create(name: "releaseTarGz", dependsOn:
configurations.archives.artifacts, type: Tar) {
kafka-1171_v9.patch:288: trailing whitespace.
compression = Compression.GZIP
warning: 3 lines add whitespace errors.
---
2. The first time I run ./gradlew build all tests passed OK, then if I change
one line in one of the test (testCircularIterator) to let it fail, sometimes
another test fails also:
kafka.server.LogRecoveryTest > testHWCheckpointNoFailuresMultipleLogSegments
FAILED
java.lang.AssertionError at LogRecoveryTest.scala:182
kafka.utils.UtilsTest > testCircularIterator FAILED
java.lang.AssertionError at UtilsTest.scala:48
This testHWCheckpointNoFailuresMultipleLogSegments seems have transient
failures. I tried the same pattern 3 times and this test failed twice.
> Gradle build for Kafka
> --
>
> Key: KAFKA-1171
> URL: https://issues.apache.org/jira/browse/KAFKA-1171
> Project: Kafka
> Issue Type: Improvement
> Components: packaging
>Affects Versions: 0.8.1, 0.9.0
>Reporter: David Arthur
>Assignee: David Arthur
> Attachments: 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, kafka-1171_v6.patch,
> kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch
>
>
> We have previously discussed moving away from SBT to an
> easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a
> patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted
> to check out Gradle as well.
> 1. https://issues.apache.org/jira/browse/KAFKA-855
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889860#comment-13889860 ] Jun Rao commented on KAFKA-1171: Please use "git apply kafka-1171_v9.patch" to try the patch. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889719#comment-13889719 ] Guozhang Wang commented on KAFKA-1171: -- No, when I applied the patch these are the files added: [guwang@guwang-ld2 kafka_1171v8]$ patch -p1 < kafka-1171_v8.patch patching file HEADER patching file README.md patching file bin/kafka-run-class.sh patching file build.gradle patching file gradle.properties patching file gradle/buildscript.gradle patching file gradle/license.gradle patching file gradle/wrapper/gradle-wrapper.properties patching file gradlew patching file settings.gradle - And the jar file is not included: [guwang@guwang-ld2 kafka_1171v8]$ ls gradle/wrapper/ gradle-wrapper.properties > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889711#comment-13889711 ] Jun Rao commented on KAFKA-1171: Guozhang, That class is included in the patch in gradle/wrapper/gradle-wrapper.jar. Do you see it? > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889705#comment-13889705 ] Guozhang Wang commented on KAFKA-1171: -- Used Linux to try the patch, still get the following exception on running ./gradlew: Exception in thread "main" java.lang.NoClassDefFoundError: org/gradle/wrapper/GradleWrapperMain Caused by: java.lang.ClassNotFoundException: org.gradle.wrapper.GradleWrapperMain at java.net.URLClassLoader$1.run(URLClassLoader.java:202) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:190) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) Could not find the main class: org.gradle.wrapper.GradleWrapperMain. Program will exit. Also, could we avoid manually "chmod u+x" on the gradlew file? > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889696#comment-13889696 ] Jay Kreps commented on KAFKA-1171: -- Shouldn't we default to scala 2.9 or something newer than 2.8? > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, kafka-1171_v6.patch, > kafka-1171_v7.patch, kafka-1171_v8.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[
https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13886227#comment-13886227
]
David Arthur commented on KAFKA-1171:
-
Figured out the POM thing finally.
After Google utterly failed me, I started looking at Netflix OSS (big Gradle
users) and see what they are doing different. I came across the following
tidbit in Archaius
https://github.com/Netflix/archaius/blob/master/gradle/maven.gradle#L3
{code}
apply plugin: 'maven' // Java plugin has to have been already applied for the
conf2scope mappings to work
{code}
I added " {{apply plugin: 'java'}} " to the subprojects declaration and now I
see a fully populated POM in my Nexus repo. My local state is pretty messed up
at the moment, so I'll have to wait until tomorrow evening to generate a new
patch - or someone else can do it.
One step closer...
> Gradle build for Kafka
> --
>
> Key: KAFKA-1171
> URL: https://issues.apache.org/jira/browse/KAFKA-1171
> Project: Kafka
> Issue Type: Improvement
> Components: packaging
>Affects Versions: 0.8.1, 0.9.0
>Reporter: David Arthur
>Assignee: David Arthur
> Attachments: 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, kafka-1171_v6.patch
>
>
> We have previously discussed moving away from SBT to an
> easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a
> patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted
> to check out Gradle as well.
> 1. https://issues.apache.org/jira/browse/KAFKA-855
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881635#comment-13881635 ] Joe Stein commented on KAFKA-1171: -- yup, will take a look. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v6.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881633#comment-13881633 ] Jun Rao commented on KAFKA-1171: Joe Stein, Do you think you can take a look at maven publishing? I tried to publish locally using mavenLocal(). However, I didn't see any pom file generated in the .m2/ (only saw the jar and the ivy file). Is that normal? > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > kafka-1171_v6.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875305#comment-13875305 ] Guozhang Wang commented on KAFKA-1171: -- Downloaded the latest patch and apply on trunk. Some observations: 1. Need to manually chmod u+x gradlew file. 2. When run ./gradlew, got the following error: Exception in thread "main" java.lang.NoClassDefFoundError: org/gradle/wrapper/GradleWrapperMain Caused by: java.lang.ClassNotFoundException: org.gradle.wrapper.GradleWrapperMain at java.net.URLClassLoader$1.run(URLClassLoader.java:202) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:190) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) Could not find the main class: org.gradle.wrapper.GradleWrapperMain. Program will exit. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[
https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864627#comment-13864627
]
Christopher Freeman commented on KAFKA-1171:
In the patch, the scalatest dependency is wrong. In :core dependencies, I
replace it with
{code}
if (scalaVersion.startsWith('2.8')) {
testCompile 'org.scalatest:scalatest:1.2'
} else if (scalaVersion.startsWith('2.10')) {
testCompile 'org.scalatest:scalatest_2.10:1.9.1'
} else {
testCompile "org.scalatest:scalatest_$scalaVersion:1.8"
}
{code}
to match the logic in core/build.sbt and ./gradlew -PscalaVersion=2.10.1 now
works
> Gradle build for Kafka
> --
>
> Key: KAFKA-1171
> URL: https://issues.apache.org/jira/browse/KAFKA-1171
> Project: Kafka
> Issue Type: Improvement
> Components: packaging
>Affects Versions: 0.8.1, 0.9.0
>Reporter: David Arthur
>Assignee: David Arthur
> Attachments: 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch
>
>
> We have previously discussed moving away from SBT to an
> easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a
> patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted
> to check out Gradle as well.
> 1. https://issues.apache.org/jira/browse/KAFKA-855
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863096#comment-13863096 ] Joe Stein commented on KAFKA-1171: -- with the new patch I was able to get ./gradlew -PscalaVersion=2.8.0 clean core:test ./gradlew -PscalaVersion=2.8.2 clean core:test ./gradlew -PscalaVersion=2.9.1 clean core:test ./gradlew -PscalaVersion=2.9.2 clean core:test to BUILD SUCCESSFUL however ./gradlew -PscalaVersion=2.10.1 clean core:test fails with java.lang.NoClassDefFoundError for every test :( (same trying 2.10.2 and 2.10.3) are there other tasks to try out yet or not yet? Would be cool to have the README updated/changed also to reflect the gradle tasks that are supported / pending for everything to switch the existing README out from sbt to gradle (once everything is in there of course). > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[
https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863029#comment-13863029
]
David Arthur commented on KAFKA-1171:
-
Sorry for being quiet on this for a few weeks - just getting back into working
mode after the holidays.
[~joestein], still having permissions issues? Does something need a chmod +x?
[~junrao], to answer your questions:
1. Gradle will generate IDEA and Eclipse project files (I've tested this a
little)
2. Building a release is a matter of writing a Gradle task that does all the
necessary things (build jar, build javadocs, copy bin scripts, etc). There are
some Gradle plugins to help with some tasks (e.g., license checking)
3. {./gradlew -Dtest.single=RequestResponseSerializationTest core:test}
4. Not sure - what is the purpose of this step in the current build? If it's
for gathering deps for a distribution? I see this Gradle plugin
(http://www.gradle.org/docs/current/userguide/distribution_plugin.html) which I
haven't tried yet.
> Gradle build for Kafka
> --
>
> Key: KAFKA-1171
> URL: https://issues.apache.org/jira/browse/KAFKA-1171
> Project: Kafka
> Issue Type: Improvement
> Components: packaging
>Affects Versions: 0.8.1, 0.9.0
>Reporter: David Arthur
>Assignee: David Arthur
> Attachments: 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch
>
>
> We have previously discussed moving away from SBT to an
> easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a
> patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted
> to check out Gradle as well.
> 1. https://issues.apache.org/jira/browse/KAFKA-855
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862332#comment-13862332 ] Jun Rao commented on KAFKA-1171: Thanks for the patch. I tried ./gradlew build and got the following error. FAILURE: Build failed with an exception. * Where: Build file '/Users/jrao/Intellij/kafka_git/build.gradle' line: 5 * What went wrong: A problem occurred evaluating root project 'kafka_git'. > Could not read script > '/Users/jrao/Intellij/kafka_git/gradle/buildscript.gradle' as it does not > exist. Also, could you describe how to the following: 1. ide support 2. build a release tar/zip 3. run a single unit test (the test-only option in sbt) 4. Is there still a assembly-package-dependency step? > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855864#comment-13855864 ] Joe Stein commented on KAFKA-1171: -- Hi David, I applied the latest patch and got stuck after the build target Joes-MacBook-Air:kafka joestein$ ./gradlew -PscalaVersion=2.9.2 build -bash: ./gradlew: Permission denied Joes-MacBook-Air:kafka joestein$ chmod a+x gradlew Joes-MacBook-Air:kafka joestein$ ./gradlew -PscalaVersion=2.9.2 build Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain let me know if I am missing a step please > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846543#comment-13846543 ] Neha Narkhede commented on KAFKA-1171: -- +1 on Gradle > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846529#comment-13846529 ] David Arthur commented on KAFKA-1171: - Yea, I agree we're bike-shedding a bit. Any of the options discussed (Ant, Gradle, SBT) can be made to work (probably). To your last point [~jkreps], I'd be happy to own the build... provided that it's not SBT :) Right now, to me, Gradle looks like the most attractive option. Speaking of CI, are we doing anything with Jenkins or TravisCI? > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846415#comment-13846415 ] Jay Kreps commented on KAFKA-1171: -- These build discussions tend to blow up due to the bike shed factor :-) Here is my two cents: 1. We migrated off ant to sbt because it seemed shiny. We never really learned to use it properly. No one "owns" it. 2. SBT has been a pain. 3. The most important thing is that the committers learn the build system. This will be easier if it is something standard like ant/mvn since the skill is more reusable, but even if we choose something esoteric we just need to suck it up and learn it. Same if we decide to stay with SBT. 4. LinkedIn uses gradle so for the LinkedIn people that is mainstream though it is not common elsewhere. We also have paid support from the gradle people so we can punt harder questions to them. Because we have consulting from the play people we may actually have access to the same thing for sbt though we never used it due to, I don't know, machisimo. 5. Either because people won't learn it, can't learn it, or because it can't do it, some of the SBT stuff is suboptimal. For example unit tests don't produce an html unit test report, don't give stack traces, etc. This makes CI less useful. 6. Whatever we do we cannot regress multi-version scala build or building release artifacts and maven publishing. Ideally we would not regress incremental compilation but I think the IDE does this anyway so that may be good enough (it is for me). 7. I am willing to live with any technology choice but I think the most important two things to be successful is that (a) someone officially own build and work to make it good and help others when they get stumped (b) everyone learn the technology we choose. Would anyone be willing to do that? > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846386#comment-13846386 ] David Arthur commented on KAFKA-1171: - [~omnomnom], looks like the Gradle Scala plugin supports Zinc as well as scalac. I'll update my patch if I can get this working. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846367#comment-13846367 ] Kostya Golikov commented on KAFKA-1171: --- [~mumrah] talking about sbt pros -- it is able to perform incremental compilation and continuous tests execution [out of the box], whereas in ant you are doomed to manual clean/compile loop (aren't you?). It is not vital and showstopper, but such things could ease developer life a lot. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846362#comment-13846362 ] David Arthur commented on KAFKA-1171: - I think having a maintainable build is a big plus. SBT does not lend itself to this. It also seems that Gradle has been gaining traction in the Scala world (probably b/c people dislike SBT so much). Netflix has adopted it, and Samza is using it. Having two closely related projects (Kafka and Samza) use the same build makes good sense. And yea, that Ant task thing looks neat. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846339#comment-13846339 ] Joe Stein commented on KAFKA-1171: -- Even moving to Gradle I will ask the same questions. What are we gaining vs the risk involved of ripping something out that is fundamentally working (couple issues that are minor fixes now at this point). Will test cases run faster? Will it be easier for folks to integrate it into their environment when doing development? What problems are we trying to solve by introducing this change? I have read enough about gradle that I would not be surprised if an argument could be made a proved out it is better than sbt if it all actually worked and could do everything (including publishing repo, building release, etc) ... I feel ant/xml to be very verbose and something that has continually become out of favor which means less people to steward and support projects using it (resources go down). Not sure if you have seen this but it seems in gradle you can do ant task type things http://www.gradle.org/docs/current/userguide/ant.html > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[
https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846314#comment-13846314
]
David Arthur commented on KAFKA-1171:
-
[~joestein], I think we would gain plenty, but that's just me.
What I like about Ant: It's well understood tech - very old, boring, and
stable. It has very wide adoption (lots of people know it). Build scripts are
easily understood and modified (no "magic"). The biggest downside is that it is
pretty verbose and not well loved by the Scala community.
As for SBT, the only real benefits I see are the cross-building you get for
free. Everything else seems like a pain. The DSL is incomprehensible without
significant investment (for a build system, this is crazy, IMO). I haven't used
it very much, but it seems to be a moving target that is constantly breaking
compatibility of plugins.
As far as I see it:
* We can make SBT work, but it's caused us pain so far
* We can maybe make Gradle work, but it's not obvious to me
* We can make Ant work, but it's new and unpopular :)
Back to Gradle for a moment:
In the Samza build, they parameterize the Scala version which is pretty
straightforward. This allows for doing things like {{./gradlew
-DscalaVersion=2.9.1 build}}. It solves the issue of targeting multiple
versions, but it won't automatically run the build for _all_ versions. If we
can live with this, then we can probably get Gradle working. I'll continue
tinkering for now.
> Gradle build for Kafka
> --
>
> Key: KAFKA-1171
> URL: https://issues.apache.org/jira/browse/KAFKA-1171
> Project: Kafka
> Issue Type: Improvement
> Components: packaging
>Affects Versions: 0.8.1, 0.9.0
>Reporter: David Arthur
>Assignee: David Arthur
> Attachments: 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch
>
>
> We have previously discussed moving away from SBT to an
> easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a
> patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted
> to check out Gradle as well.
> 1. https://issues.apache.org/jira/browse/KAFKA-855
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846289#comment-13846289 ] Joe Stein commented on KAFKA-1171: -- what do we gain moving away from SBT to ant? Ant its is not well adopted in the scala community and for a scala project i think that is an important consideration > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846071#comment-13846071 ] David Arthur commented on KAFKA-1171: - I dusted off the Ant build I put together a while ago and got it working with the latest trunk. Here is the current state (on my GitHub fork): https://github.com/mumrah/kafka/compare/apache:trunk...ant If no one strongly objects (or gets Gradle working), I'm going to continue down the Ant path and update KAFKA-855. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, > 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845481#comment-13845481 ] David Arthur commented on KAFKA-1171: - Made some progress with the multi-scala plugin from https://issues.apache.org/jira/browse/SAMZA-34. A few things work, some don't. Top level tasks (assemble, build) don't work, but calling the specific tasks like "./gradlew core:compileScala2_10Java core:compileScala2_10Scala" does work. I can't figure out how to override the source sets however, which is important b/c we have Scala-version-dependent code in some places (e.g., Annotations_2.9+.scala). After hacking on this for a few hours, I'm inclined to go back to Ant. The inability to debug what is happening under the covers with Gradle is pretty frustrating. If we _really_ want to use Gradle for the other plugins, we could create a simple Ant build script for doing the cross-version build and call it from Gradle (http://www.gradle.org/docs/current/userguide/ant.html). However, this feels like asking from trouble (unnecessary complexity). What do others think? > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844808#comment-13844808 ] Chris Riccomini commented on KAFKA-1171: That sounds a lot like a version incompatibility between the version of Gradle you're using, and what the project was built against (it includes no gradlew script). I was able to successfully compile it use Samza's gradlew script. Might setup a gradlew in the project, and give that a shot. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[
https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844789#comment-13844789
]
David Arthur commented on KAFKA-1171:
-
[~criccomini] thanks for the pointer.
When I try out that sample you have on the SAMZA issue, I get the following:
{code}
FAILURE: Build failed with an exception.
* Where:
Script '/Users/mumrah/Downloads/multi-scala/scala.gradle' line: 44
* What went wrong:
A problem occurred evaluating root project 'multi-scala'.
> Failed to notify action.
> groovy.lang.MissingMethodException: No signature of method:
org.gradle.api.internal.artifacts.configurations.DefaultResolutionStrategy.eachDependency()
is applicable for argument types:
(scala_319e62rbueqtrto35ji6mp2hbc$_configureResolution_closure3) values:
[scala_319e62rbueqtrto35ji6mp2hbc$_configureResolution_closure3@17e06b12]
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 4.169 secs
{code}
> Gradle build for Kafka
> --
>
> Key: KAFKA-1171
> URL: https://issues.apache.org/jira/browse/KAFKA-1171
> Project: Kafka
> Issue Type: Improvement
> Components: packaging
>Affects Versions: 0.8.1, 0.9.0
>Reporter: David Arthur
>Assignee: David Arthur
> Attachments: 0001-Adding-basic-Gradle-build.patch
>
>
> We have previously discussed moving away from SBT to an
> easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a
> patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted
> to check out Gradle as well.
> 1. https://issues.apache.org/jira/browse/KAFKA-855
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844780#comment-13844780 ] Chris Riccomini commented on KAFKA-1171: For the record, a good set of examples on how to build OSS multi-module Gradle projects is Netflix's GitHub account: https://github.com/Netflix Their account contains a number of projects that use Gradle (Lipstick, astyanax, servo, etc). In addition, they have a stub repo for bootstrapping new projects with Gradle. https://github.com/Netflix/gradle-template > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844763#comment-13844763 ] Chris Riccomini commented on KAFKA-1171: For cross-building Scala versions, have a look at: https://issues.apache.org/jira/browse/SAMZA-34 [~szczepiq] provided the example zip file. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844401#comment-13844401 ] David Arthur commented on KAFKA-1171: - Jun, Gradle does have plugins for IDEs and Maven publishing (as well as many others). What it's missing right now is support for building against different Scala versions. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844396#comment-13844396 ] Jun Rao commented on KAFKA-1171: David, Thanks for the patch. Is that all we need to do to switch to Gradle? Does the patch support maven publishing and ide project build? > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842252#comment-13842252 ] David Arthur commented on KAFKA-1171: - Created reviewboard https://reviews.apache.org/r/16102/ against branch origin/trunk > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, KAFKA-1171.patch, > KAFKA-1171.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842251#comment-13842251 ] David Arthur commented on KAFKA-1171: - Created reviewboard against branch origin/trunk > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch, KAFKA-1171.patch, > KAFKA-1171.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842250#comment-13842250 ] David Arthur commented on KAFKA-1171: - [~joestein], yea we should definitely use the wrapper. I think it would also allow us to lock down a particular version of Gradle too. > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (KAFKA-1171) Gradle build for Kafka
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842247#comment-13842247 ] Joe Stein commented on KAFKA-1171: -- Exciting!!! What do think about using a wrapper like this ( or even just using this wrapper https://github.com/apache/incubator-aurora/blob/master/gradlew) it's nice because it downloads grade for you as not everyone uses brew and on Linux no one does > Gradle build for Kafka > -- > > Key: KAFKA-1171 > URL: https://issues.apache.org/jira/browse/KAFKA-1171 > Project: Kafka > Issue Type: Improvement > Components: packaging >Affects Versions: 0.8.1, 0.9.0 >Reporter: David Arthur >Assignee: David Arthur > Attachments: 0001-Adding-basic-Gradle-build.patch > > > We have previously discussed moving away from SBT to an > easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a > patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted > to check out Gradle as well. > 1. https://issues.apache.org/jira/browse/KAFKA-855 -- This message was sent by Atlassian JIRA (v6.1#6144)
