[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565930#comment-14565930 ] Ismael Juma commented on KAFKA-1419: 0.8.2.1 is available for Scala 2.11, see: http://mvnrepository.com/artifact/org.apache.kafka/kafka_2.11/0.8.2.1 > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.1.2, 0.8.2.0 > > Attachments: KAFKA-1419-scalaBinaryVersion.patch, > KAFKA-1419-scalaBinaryVersion.patch, KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch, > KAFKA-1419_2014-08-07_10:17:34.patch, KAFKA-1419_2014-08-07_10:52:18.patch, > KAFKA-1419_cross_build_for_scala_2_11_for_0_8_1_branch.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559172#comment-14559172 ] Adamos Loizou commented on KAFKA-1419: -- Hello, is there any ETA on including the 2.11 fix? Thanks! > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.1.2, 0.8.2.0 > > Attachments: KAFKA-1419-scalaBinaryVersion.patch, > KAFKA-1419-scalaBinaryVersion.patch, KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch, > KAFKA-1419_2014-08-07_10:17:34.patch, KAFKA-1419_2014-08-07_10:52:18.patch, > KAFKA-1419_cross_build_for_scala_2_11_for_0_8_1_branch.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329842#comment-14329842 ] Jun Rao commented on KAFKA-1419: The fix will be included in 0.8.2.x. Closing the jira. > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.1.2, 0.8.2.0 > > Attachments: KAFKA-1419-scalaBinaryVersion.patch, > KAFKA-1419-scalaBinaryVersion.patch, KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch, > KAFKA-1419_2014-08-07_10:17:34.patch, KAFKA-1419_2014-08-07_10:52:18.patch, > KAFKA-1419_cross_build_for_scala_2_11_for_0_8_1_branch.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316760#comment-14316760 ] Helena Edelson commented on KAFKA-1419: --- This ticket says the cross build is available for kafka v 0.8.1.2 with Scala 2.11 but I don't see that artifact anywhere? > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.1.2, 0.8.2.0 > > Attachments: KAFKA-1419-scalaBinaryVersion.patch, > KAFKA-1419-scalaBinaryVersion.patch, KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch, > KAFKA-1419_2014-08-07_10:17:34.patch, KAFKA-1419_2014-08-07_10:52:18.patch, > KAFKA-1419_cross_build_for_scala_2_11_for_0_8_1_branch.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225564#comment-14225564 ] Jun Rao commented on KAFKA-1419: This is being tracked in KAFKA-1054. > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.1.2, 0.8.2 > > Attachments: KAFKA-1419-scalaBinaryVersion.patch, > KAFKA-1419-scalaBinaryVersion.patch, KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch, > KAFKA-1419_2014-08-07_10:17:34.patch, KAFKA-1419_2014-08-07_10:52:18.patch, > KAFKA-1419_cross_build_for_scala_2_11_for_0_8_1_branch.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[
https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222193#comment-14222193
]
Peter Vandenabeele commented on KAFKA-1419:
---
New to Kafka and Scala ...
Trying to build Kafka HEAD of 0.8.2 (fbecd48) with Scala 2.11.4
Most works, but I get a number of warnings that may be relevant (?)
{noformat}
$ gradle -PscalaVersion=2.11.4 clean
... (all OK)
$ gradle -PscalaVersion=2.11.4
... (all OK)
$ ./gradlew -PscalaVersion=2.11.4 test
... (all OK)
:core:compileScala
Download
http://repo1.maven.org/maven2/org/scala-lang/scala-library/2.11.4/scala-library-2.11.4.pom
Download
http://repo1.maven.org/maven2/org/scala-lang/scala-library/2.11.4/scala-library-2.11.4.jar
Download
http://repo1.maven.org/maven2/org/scala-lang/scala-compiler/2.11.4/scala-compiler-2.11.4.pom
Download
http://repo1.maven.org/maven2/org/scala-lang/scala-reflect/2.11.4/scala-reflect-2.11.4.pom
Download
http://repo1.maven.org/maven2/org/scala-lang/scala-compiler/2.11.4/scala-compiler-2.11.4.jar
Download
http://repo1.maven.org/maven2/org/scala-lang/scala-reflect/2.11.4/scala-reflect-2.11.4.jar
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m;
support was removed in 8.0
/Users/peter_v/Documents/data/github/apache/kafka/core/src/main/scala/kafka/admin/AdminUtils.scala:259:
non-variable type argument String in type pattern
scala.collection.Map[String,_] is unchecked since it is eliminated by erasure
case Some(map: Map[String, _]) =>
^
/Users/peter_v/Documents/data/github/apache/kafka/core/src/main/scala/kafka/admin/AdminUtils.scala:262:
non-variable type argument String in type pattern
scala.collection.Map[String,String] is unchecked since it is eliminated by
erasure
case Some(config: Map[String, String]) =>
^
/Users/peter_v/Documents/data/github/apache/kafka/core/src/main/scala/kafka/consumer/ConsumerIterator.scala:107:
A try without a catch or finally is equivalent to putting its body in a block;
no exceptions are handled.
try {
^
/Users/peter_v/Documents/data/github/apache/kafka/core/src/main/scala/kafka/server/KafkaServer.scala:167:
a pure expression does nothing in statement position; you may be omitting
necessary parentheses
ControllerStats.uncleanLeaderElectionRate
^
/Users/peter_v/Documents/data/github/apache/kafka/core/src/main/scala/kafka/server/KafkaServer.scala:168:
a pure expression does nothing in statement position; you may be omitting
necessary parentheses
ControllerStats.leaderElectionTimer
^
/Users/peter_v/Documents/data/github/apache/kafka/core/src/main/scala/kafka/utils/Utils.scala:81:
a pure expression does nothing in statement position; you may be omitting
necessary parentheses
daemonThread(name, runnable(fun))
^
/Users/peter_v/Documents/data/github/apache/kafka/core/src/main/scala/kafka/utils/Json.scala:28:
object JSON in package json is deprecated: This object will be removed.
JSON.globalNumberParser = myConversionFunc
^
/Users/peter_v/Documents/data/github/apache/kafka/core/src/main/scala/kafka/utils/Json.scala:37:
object JSON in package json is deprecated: This object will be removed.
JSON.parseFull(input)
^
/Users/peter_v/Documents/data/github/apache/kafka/core/src/main/scala/kafka/consumer/ConsumerConfig.scala:107:
Reference to uninitialized value fetchWaitMaxMs
require(fetchWaitMaxMs <= socketTimeoutMs, "socket.timeout.ms should always
be at least fetch.wait.max.ms" +
^
/Users/peter_v/Documents/data/github/apache/kafka/core/src/main/scala/kafka/server/KafkaConfig.scala:240:
Reference to uninitialized value replicaFetchWaitMaxMs
require(replicaFetchWaitMaxMs <= replicaSocketTimeoutMs,
"replica.socket.timeout.ms should always be at least replica.fetch.wait.max.ms"
+
^
there were 12 feature warnings; re-run with -feature for details
11 warnings found
... (all OK)
BUILD SUCCESSFUL
Total time: 6 mins 41.737 secs
{noformat}
> cross build for scala 2.11
> --
>
> Key: KAFKA-1419
> URL: https://issues.apache.org/jira/browse/KAFKA-1419
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 0.8.1
>Reporter: Scott Clasen
>Assignee: Ivan Lyutov
>Priority: Blocker
> Fix For: 0.8.1.2, 0.8.2
>
> Attachments: KAFKA-1419-scalaBinaryVersion.patch,
> KAFKA-1419-scalaBinaryVersion.patch, KAFKA-1419.patch, KAFKA-1419.patch,
> KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch,
> KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch,
> KAFKA-1419_2014-08-07_10:17:34.patch, KAFKA-1419_2014-08-07_10:52:18.patch,
> KAFKA-1419_cros
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150693#comment-14150693 ] Dan Di Spaltro commented on KAFKA-1419: --- [~herriojr] It looks like the patchfile https://issues.apache.org/jira/secure/attachment/12669733/KAFKA-1419_cross_build_for_scala_2_11_for_0_8_1_branch.patch works for 8.1. It sounds like it'll be included in the 0.8.2 release. > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2, 0.8.1.2 > > Attachments: KAFKA-1419-scalaBinaryVersion.patch, > KAFKA-1419-scalaBinaryVersion.patch, KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch, > KAFKA-1419_2014-08-07_10:17:34.patch, KAFKA-1419_2014-08-07_10:52:18.patch, > KAFKA-1419_cross_build_for_scala_2_11_for_0_8_1_branch.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148228#comment-14148228 ] Jonathan Herriott commented on KAFKA-1419: -- Hi, I need to integrate the kafka 0.8.1 java libraries built for scala 2.11.1 into a project. It appears that neither the 0.8 nor the 0.8.1 branch have these patches applied. Which patches above are necessary in order to get this working? > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2, 0.8.1.2 > > Attachments: KAFKA-1419-scalaBinaryVersion.patch, > KAFKA-1419-scalaBinaryVersion.patch, KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch, > KAFKA-1419_2014-08-07_10:17:34.patch, KAFKA-1419_2014-08-07_10:52:18.patch, > KAFKA-1419_cross_build_for_scala_2_11_for_0_8_1_branch.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110779#comment-14110779 ] Jun Rao commented on KAFKA-1419: I got the text version of the patch, but saw the following when applying. git apply kafka-1419.patch error: patch failed: bin/windows/kafka-run-class.bat:28 error: bin/windows/kafka-run-class.bat: patch does not apply Could you attach a text version directly? > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419-scalaBinaryVersion.patch, KAFKA-1419.patch, > KAFKA-1419.patch, KAFKA-1419_2014-07-28_15:05:16.patch, > KAFKA-1419_2014-07-29_15:13:43.patch, KAFKA-1419_2014-08-04_14:43:26.patch, > KAFKA-1419_2014-08-05_12:51:16.patch, KAFKA-1419_2014-08-07_10:17:34.patch, > KAFKA-1419_2014-08-07_10:52:18.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108832#comment-14108832 ] Stevo Slavic commented on KAFKA-1419: - I saw binary content too when opening attached file with .diff extension. Now I just named file with .patch extension, and it's text file. Btw, I see and open .diff file locally as text file. Strange. Maybe JIRA doing something funky. Anyway, please use attached patch. Also, please consider accepting github pull requests, like lots of other Apache projects. (just [google apache project pull request|https://www.google.com/search?q=apache+project+pull+request]). That would make it a lot easier for all, both committers and contributors, and avoid issues like this. > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419-scalaBinaryVersion.patch, KAFKA-1419.patch, > KAFKA-1419.patch, KAFKA-1419_2014-07-28_15:05:16.patch, > KAFKA-1419_2014-07-29_15:13:43.patch, KAFKA-1419_2014-08-04_14:43:26.patch, > KAFKA-1419_2014-08-05_12:51:16.patch, KAFKA-1419_2014-08-07_10:17:34.patch, > KAFKA-1419_2014-08-07_10:52:18.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108781#comment-14108781 ] Gwen Shapira commented on KAFKA-1419: - Its not binary, it is ucs-2. After iconv (iconv -f ucs-2 -t iso-8859-1 KAFKA-1419.1.patch), I could apply it without fatal error, but there are still some issues that prevent it from applying cleanly. > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419-scalaBinaryVersion.diff, KAFKA-1419.patch, > KAFKA-1419.patch, KAFKA-1419_2014-07-28_15:05:16.patch, > KAFKA-1419_2014-07-29_15:13:43.patch, KAFKA-1419_2014-08-04_14:43:26.patch, > KAFKA-1419_2014-08-05_12:51:16.patch, KAFKA-1419_2014-08-07_10:17:34.patch, > KAFKA-1419_2014-08-07_10:52:18.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108717#comment-14108717 ] Jun Rao commented on KAFKA-1419: Stevo, Is the patch in binary form? I am not sure how to apply it. Thanks, > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419-scalaBinaryVersion.diff, KAFKA-1419.patch, > KAFKA-1419.patch, KAFKA-1419_2014-07-28_15:05:16.patch, > KAFKA-1419_2014-07-29_15:13:43.patch, KAFKA-1419_2014-08-04_14:43:26.patch, > KAFKA-1419_2014-08-05_12:51:16.patch, KAFKA-1419_2014-08-07_10:17:34.patch, > KAFKA-1419_2014-08-07_10:52:18.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[
https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105299#comment-14105299
]
Stevo Slavic commented on KAFKA-1419:
-
{{bin/windows/kafka-run-class.bat}} still reference 2.8.0.
Both {{kafka-run-class.sh}} and {{kafka-run-class.bat}} are broken for scala
versions where scala version is not equal to scala binary version, like 2.10.1
where binary version is 2.10.
More specifically classpath addition for kafka core is wrong.
In {{kafka-run-class.bat}} instead of
{noformat}
%BASE_DIR%\core\build\libs\kafka_%SCALA_VERSION%*.jar
{noformat}
there should be something like:
{noformat}
%BASE_DIR%\core\build\libs\kafka_%SCALA_BINARY_VERSION%*.jar
{noformat}
Similarly, in {{kafka-run-class.sh}} instead of
{noformat}
for file in $base_dir/core/build/libs/kafka_${SCALA_VERSION}*.jar;
do
CLASSPATH=$CLASSPATH:$file
done
{noformat}
there should be something like
{noformat}
for file in $base_dir/core/build/libs/kafka_${SCALA_BINARY_VERSION}*.jar;
do
CLASSPATH=$CLASSPATH:$file
done
{noformat}
This will require adding one more variable for scala binary version, in both
mentioned scripts.
e.g. in {{kafka-run-class.sh}} from
{noformat}
if [ -z "$SCALA_VERSION" ]; then
SCALA_VERSION=2.10.1
fi
{noformat}
to
{noformat}
if [ -z "$SCALA_VERSION" ]; then
SCALA_VERSION=2.10.1
fi
if [ -z "$SCALA_BINARY_VERSION" ]; then
SCALA_BINARY_VERSION=2.10
fi
{noformat}
and in {{kafka-run-class.bat}}, from
{noformat}
IF ["%SCALA_VERSION%"] EQU [""] (
set SCALA_VERSION=2.10.1
)
{noformat}
to
{noformat}
IF ["%SCALA_VERSION%"] EQU [""] (
set SCALA_VERSION=2.10.1
)
IF ["%SCALA_BINARY_VERSION%"] EQU [""] (
set SCALA_BINARY_VERSION=2.10
)
{noformat}
> cross build for scala 2.11
> --
>
> Key: KAFKA-1419
> URL: https://issues.apache.org/jira/browse/KAFKA-1419
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 0.8.1
>Reporter: Scott Clasen
>Assignee: Ivan Lyutov
>Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: KAFKA-1419.patch, KAFKA-1419.patch,
> KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch,
> KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch,
> KAFKA-1419_2014-08-07_10:17:34.patch, KAFKA-1419_2014-08-07_10:52:18.patch
>
>
> Please publish builds for scala 2.11, hopefully just needs a small tweak to
> the gradle conf?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089125#comment-14089125 ] Ivan Lyutov commented on KAFKA-1419: Updated reviewboard https://reviews.apache.org/r/23895/diff/ against branch apache/trunk > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch, > KAFKA-1419_2014-08-07_10:17:34.patch, KAFKA-1419_2014-08-07_10:52:18.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089103#comment-14089103 ] Ivan Lyutov commented on KAFKA-1419: Updated reviewboard https://reviews.apache.org/r/23895/diff/ against branch apache/trunk > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch, > KAFKA-1419_2014-08-07_10:17:34.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086309#comment-14086309 ] Joe Stein commented on KAFKA-1419: -- [~junrao] Is 2.9.2 going to still be the version we are recommending? If so we should make that the default in this patch for builds. > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086215#comment-14086215 ] Ivan Lyutov commented on KAFKA-1419: Updated reviewboard https://reviews.apache.org/r/23895/diff/ against branch apache/trunk > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch, KAFKA-1419_2014-08-05_12:51:16.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084715#comment-14084715 ] Ivan Lyutov commented on KAFKA-1419: Updated reviewboard https://reviews.apache.org/r/23895/diff/ against branch apache/trunk > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch, > KAFKA-1419_2014-08-04_14:43:26.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083369#comment-14083369 ] Patrick Wendell commented on KAFKA-1419: Hey all - just chiming in from the Apache Spark community. We'd love to see this feature go in soon as it's one of the main blockers for our own upgrade to Scala 2.11. Thanks for all the great work! > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077817#comment-14077817 ] Ivan Lyutov commented on KAFKA-1419: Updated reviewboard https://reviews.apache.org/r/23895/diff/ against branch apache/trunk > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch, KAFKA-1419_2014-07-29_15:13:43.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076285#comment-14076285 ] Ivan Lyutov commented on KAFKA-1419: Updated reviewboard https://reviews.apache.org/r/23895/diff/ against branch apache/trunk > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch, > KAFKA-1419_2014-07-28_15:05:16.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073666#comment-14073666 ] Joe Stein commented on KAFKA-1419: -- Thanks [~joecrobak] for the feedback/review. Yes, we can drop support for Scala 2.8 https://issues.apache.org/jira/browse/KAFKA-1399 lets do that in this ticket. [~edgefox] can you take care of that and the other feedback so far too please. Thanks! > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[
https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073651#comment-14073651
]
Joe Crobak commented on KAFKA-1419:
---
I tried out this patch earlier today, and I have a few pieces of feedback:
* I'm not sure it's possible to support both scala 2.8 and 2.11 at the same
time while using the zinc compiler. 2.8 seems to require gradle 1.6/zinc 0.2.5,
and 2.11 requires gradle 2.0/zinc 0.3.0+. It's possible that there's a version
in between that supports them, but I didn't do the binary search. Switching to
{{scalaCompileOptions.useAnt = true}} seems to compile all scala versions for
me.
* I think the {{jarAll}}, {{srcJarAll}} and other `*All` tasks should be
updated to include scala 2.11.
* scala 2.9 support seems to be broken by two things: 1) several {{else{}}}
clauses were formerly scala 2.9 specific but were converted to be scala 2.11
specific. 2) wrong zinc version being selected.
* Moving {{BeanProperty}} from {{scala.reflect}} to {{scala.beans}} is
backwards incompatible with scala <2.10. it's likely better to remove the
{{BeanProperty}} dep and implement {{def getBuffer = buffer}} in those two
places.
* scala.gradle needs an override for 2.11 like it has for 2.10.
I have a feeling that trying to support 4 versions of scala is going to be a
pain in the long run—when can scala 2.8 (and also 2.9) be dropped?
> cross build for scala 2.11
> --
>
> Key: KAFKA-1419
> URL: https://issues.apache.org/jira/browse/KAFKA-1419
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 0.8.1
>Reporter: Scott Clasen
>Assignee: Ivan Lyutov
>Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: KAFKA-1419.patch, KAFKA-1419.patch
>
>
> Please publish builds for scala 2.11, hopefully just needs a small tweak to
> the gradle conf?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073337#comment-14073337 ] Ivan Lyutov commented on KAFKA-1419: Created reviewboard https://reviews.apache.org/r/23895/diff/ against branch apache/trunk > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch, KAFKA-1419.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073300#comment-14073300 ] Ivan Lyutov commented on KAFKA-1419: Created reviewboard against branch apache/0.8.1 > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1419.patch > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071024#comment-14071024 ] Adriaan Moors commented on KAFKA-1419: -- Sorry about the sbt gymnastics! Here's how we recommend depending on scala-version-specific versions of your dependencies: https://github.com/scala/scala-module-dependency-sample > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049517#comment-14049517 ] Jakob Homan commented on KAFKA-1419: As long as the sources compiled are what was voted on as the release, it should be fine. The jars are just conveniences for the users. > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Priority: Blocker > Fix For: 0.8.2 > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049213#comment-14049213 ] Joe Stein commented on KAFKA-1419: -- We might also be able to build and release for 0.8.1.1 like was done with the test jar [~jghoman] what do you think? I think that should be ok? > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen >Priority: Blocker > Fix For: 0.8.2 > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049210#comment-14049210 ] Joe Stein commented on KAFKA-1419: -- That makes sense Scott (thanks) if you or someone else wants to upload a patch I can review and commit it we can get it into 0.8.2 otherwise I can do it before the release and someone else can review and commit, either way that makes sense to me (ease of use for the community is a +1 for sure) > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen > Fix For: 0.8.2 > > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[
https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049206#comment-14049206
]
Scott Clasen commented on KAFKA-1419:
-
Makes it a sbt gymnastic task to cross build downstream libraries that are
built on top of kafka.
rather than simply ` libraryDependencies = "org.apache.kafka" %% "kafka"
%"0.8.1" `
it takes more sbt knowledge to do something like what I had to do for spray
(example below) when they didnt cross build. The above is something most folks
can type out. The below took googling and cursing and time to figure out.
```
def spray:Seq[Setting[Seq[ModuleID]]] = Seq(libraryDependencies <+=
scalaVersion(sprayDependency(_)))
def sprayDependency(scalaVersion: String) = scalaVersion match {
case "2.10.4" => "io.spray" % "spray-client" % "1.3.1" % "compile"
case "2.11.1" => "io.spray" % "spray-client_2.11" % "1.3.1-20140423" %
"compile"
}
```
> cross build for scala 2.11
> --
>
> Key: KAFKA-1419
> URL: https://issues.apache.org/jira/browse/KAFKA-1419
> Project: Kafka
> Issue Type: Improvement
> Components: clients
>Affects Versions: 0.8.1
>Reporter: Scott Clasen
>
> Please publish builds for scala 2.11, hopefully just needs a small tweak to
> the gradle conf?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049204#comment-14049204 ] Kostya Golikov commented on KAFKA-1419: --- [~joestein], Scala 2.11 is only *source* compatible with 2.10, but not binary compatible. To quote release notes you've linked: > Code that compiled on 2.10.x without deprecation warnings should compile on > 2.11.x ... This release is not binary compatible with the 2.10.x series, to > allow us to keep improving the Scala standard library. That means, that although you likely don't have to support two different versions of kafka source code, kafka artifact built against 2.10 would not work if user will have 2.11 on classpath (and vice versa). > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1419) cross build for scala 2.11
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049197#comment-14049197 ] Joe Stein commented on KAFKA-1419: -- Is there a reason we need to-do this? Scala 2.11 works with 2.10 binaries http://www.scala-lang.org/news/2.11.0 > cross build for scala 2.11 > -- > > Key: KAFKA-1419 > URL: https://issues.apache.org/jira/browse/KAFKA-1419 > Project: Kafka > Issue Type: Improvement > Components: clients >Affects Versions: 0.8.1 >Reporter: Scott Clasen > > Please publish builds for scala 2.11, hopefully just needs a small tweak to > the gradle conf? -- This message was sent by Atlassian JIRA (v6.2#6252)
