[jira] [Commented] (KAFKA-2711) SaslClientAuthenticator no longer needs KerberosNameParser in constructor
[ https://issues.apache.org/jira/browse/KAFKA-2711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982747#comment-14982747 ] ASF GitHub Bot commented on KAFKA-2711: --- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/390 > SaslClientAuthenticator no longer needs KerberosNameParser in constructor > - > > Key: KAFKA-2711 > URL: https://issues.apache.org/jira/browse/KAFKA-2711 > Project: Kafka > Issue Type: Sub-task > Components: clients >Affects Versions: 0.9.0.0 >Reporter: Jun Rao >Assignee: Ismael Juma >Priority: Minor > Fix For: 0.9.0.0 > > > Since the sasl client doesn't need to know the principal name, we don't need > to pass in KerberosNameParser to SaslClientAuthenticator. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2711) SaslClientAuthenticator no longer needs KerberosNameParser in constructor
[ https://issues.apache.org/jira/browse/KAFKA-2711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982384#comment-14982384 ] ASF GitHub Bot commented on KAFKA-2711: --- GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/390 KAFKA-2711; SaslClientAuthenticator no longer needs KerberosNameParser in constructor Also refactor `KerberosNameParser` and `KerberosName` to make the code clearer and easier to use when `shortName` is not needed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-2711 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/390.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #390 commit 751e52ffee04401a6bf8170469594fe5f526bff1 Author: Ismael Juma Date: 2015-10-30T11:13:11Z Remove unnecessary usage of `KerberosNameParser` in `SaslClientAuthenticator` Also refactor `KerberosNameParser` and `KerberosName` to make the code clearer. > SaslClientAuthenticator no longer needs KerberosNameParser in constructor > - > > Key: KAFKA-2711 > URL: https://issues.apache.org/jira/browse/KAFKA-2711 > Project: Kafka > Issue Type: Sub-task > Components: clients >Affects Versions: 0.9.0.0 >Reporter: Jun Rao >Priority: Minor > Fix For: 0.9.1 > > > Since the sasl client doesn't need to know the principal name, we don't need > to pass in KerberosNameParser to SaslClientAuthenticator. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2711) SaslClientAuthenticator no longer needs KerberosNameParser in constructor
[ https://issues.apache.org/jira/browse/KAFKA-2711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982019#comment-14982019 ] Ismael Juma commented on KAFKA-2711: SASL_KERBEROS_PRINCIPAL_TO_LOCAL_RULES is only used in KerberosName.shortName(). The other methods in KerberosName are independent of that config. Maybe this code can be refactored to make this clearer. > SaslClientAuthenticator no longer needs KerberosNameParser in constructor > - > > Key: KAFKA-2711 > URL: https://issues.apache.org/jira/browse/KAFKA-2711 > Project: Kafka > Issue Type: Sub-task > Components: clients >Affects Versions: 0.9.0.0 >Reporter: Jun Rao >Priority: Minor > Fix For: 0.9.1 > > > Since the sasl client doesn't need to know the principal name, we don't need > to pass in KerberosNameParser to SaslClientAuthenticator. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2711) SaslClientAuthenticator no longer needs KerberosNameParser in constructor
[ https://issues.apache.org/jira/browse/KAFKA-2711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981954#comment-14981954 ] Jun Rao commented on KAFKA-2711: Yes, you are right. clientPrincipalName is still used. My confusion is that SASL_KERBEROS_PRINCIPAL_TO_LOCAL_RULES is no longer in the client config. So, it seems that we will always be using the default rule to get the client principal name? It also seems that we don't really need to pass in kerberosNameParser to SaslClientAuthenticator. > SaslClientAuthenticator no longer needs KerberosNameParser in constructor > - > > Key: KAFKA-2711 > URL: https://issues.apache.org/jira/browse/KAFKA-2711 > Project: Kafka > Issue Type: Sub-task > Components: clients >Affects Versions: 0.9.0.0 >Reporter: Jun Rao >Priority: Minor > Fix For: 0.9.1 > > > Since the sasl client doesn't need to know the principal name, we don't need > to pass in KerberosNameParser to SaslClientAuthenticator. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2711) SaslClientAuthenticator no longer needs KerberosNameParser in constructor
[ https://issues.apache.org/jira/browse/KAFKA-2711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981805#comment-14981805 ] Ismael Juma commented on KAFKA-2711: I'm not sure I understand. `clientPrincipalName` is used in the creation of SaslClient. Do you mean that the following line could be replaced by simply assigning `clientPrincipal.getName' to 'clientPrincipalName`? this.clientPrincipalName = kerberosNameParser.parse(clientPrincipal.getName()).toString(); > SaslClientAuthenticator no longer needs KerberosNameParser in constructor > - > > Key: KAFKA-2711 > URL: https://issues.apache.org/jira/browse/KAFKA-2711 > Project: Kafka > Issue Type: Sub-task > Components: clients >Affects Versions: 0.9.0.0 >Reporter: Jun Rao >Priority: Minor > Fix For: 0.9.1 > > > Since the sasl client doesn't need to know the principal name, we don't need > to pass in KerberosNameParser to SaslClientAuthenticator. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
