[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129290#comment-15129290 ] ASF GitHub Bot commented on KAFKA-826: -- Github user stumped2 closed the pull request at: https://github.com/apache/kafka/pull/3 > Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x > - > > Key: KAFKA-826 > URL: https://issues.apache.org/jira/browse/KAFKA-826 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.8.0 >Reporter: Neha Narkhede >Assignee: Dragos Manolescu >Priority: Blocker > Labels: build, kafka-0.8, metrics > Fix For: 0.8.0 > > Attachments: kafka-fix-for-826-complete.patch, > kafka-fix-for-826-take2.patch, kafka-fix-for-826.patch > > > In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since > metrics 3.x is a huge change as well as not an officially supported release. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699191#comment-13699191 ] Cosmin Lehene commented on KAFKA-826: - https://issues.apache.org/jira/browse/KAFKA-960 Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Dragos Manolescu Priority: Blocker Labels: build, kafka-0.8, metrics Fix For: 0.8 Attachments: kafka-fix-for-826-complete.patch, kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628350#comment-13628350 ] Dragos Manolescu commented on KAFKA-826: Jun, I understand what you're after. The sbt-assembly task lists the JARs it packages together when executed: assembly-package-dependency [info] Including metrics-core-2.2.0.jar [info] Including metrics-annotation-2.2.0.jar [info] Including snappy-java-1.0.4.1.jar [info] Including slf4j-api-1.7.2.jar [info] Including log4j-1.2.15.jar [info] Including zkclient-0.2.jar [info] Including scala-compiler.jar [info] Including zookeeper-3.3.4.jar [info] Including slf4j-simple-1.6.4.jar [info] Including scala-library.jar [info] Including jopt-simple-3.2.jar Following the execution of the update task these JARs will be available from the ivy cache (rather than the target folder, which if my understanding is correct holds only artifacts generated while compiling and building). I am not aware of a mechanism to have sbt-assembly place the dependencies in the target folder. As plugins like sbt-assembly, sbt-proguard, sbt-onejar and others indicate fat JARs are the typical packaging mechanism for releasing JVM bytecode. Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Dragos Manolescu Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826-complete.patch, kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626304#comment-13626304 ] Matt Christiansen commented on KAFKA-826: - I made my own branch and applyed this patch, in all my testing it seems like its doing great. I would also love to see it committed. Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Dragos Manolescu Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826-complete.patch, kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627227#comment-13627227 ] Neha Narkhede commented on KAFKA-826: - Thanks a lot for the patches! +1 on the complete patch. In addition to that, I will check in a change that deletes core/lib Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Dragos Manolescu Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826-complete.patch, kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627302#comment-13627302 ] Jun Rao commented on KAFKA-826: --- Dragos, Thanks for the patch. It seems that you merged all dependant jars into a fat jar kafka-assembly-0.8-SNAPSHOT-deps.jar. Is it possible to keep individual jars in target/scala-2.8.0? This way, if people want to release the binary, it's clear for them what are the dependant jars and their version. Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Dragos Manolescu Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826-complete.patch, kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626135#comment-13626135 ] Scott Carey commented on KAFKA-826: --- Can a committer look at this? This would be great to get in the 0.8 branch soon and looks good to me. I have a cleanup of sbt to significantly simplify it further that I'd like to do as part of KAFKA-854 but it will fail to merge with this change. Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Dragos Manolescu Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826-complete.patch, kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622062#comment-13622062 ] Maxime Brugidou commented on KAFKA-826: --- Yes there has been some work and it breaks when I try to use 3.0.0-BETA1 from 0.8 branch. We need to have a MetricsRegistry (static or injected) and use the new register() method to add gauges/metrics. Also the core namespace has been removed Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Dragos Manolescu Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622458#comment-13622458 ] Jun Rao commented on KAFKA-826: --- I pinged Coda and the following are the answers that I got. 1. How stable is 3.0.0-Beta1? The code is actually less complicated than Metrics 2 and far better tested: no thread pools, no lifecycles, no static references, just simple objects. 2. Is it true that 3.0.0-Beta1 has no classpath conflict with 2.x? In other words, can an application use both jars in the same JVM? Many of the classes have changed names and/or packages, but I didn't intend for there to be no classpath conflicts. You might be able to get away with it, but someone somewhere will step on something sharp, I'm sure. 3. Will there be any api change btw 3.0.0-Beta1 and the final 3.0 release? Probably, yes. 4. Were there any api changes btw 3.0.0-Beta1 and 3.0.0-SNAPSHOT (the one that we are currently using in Kafka 0.8)? I don't know which snapshot build you're using, but I would imagine there are a lot of changes. Based on the above, my feeling is that Kafka 0.8 release should use metrics 2.x since (1) it has been stable; (2) people who depend on 2.x have no risk in using Kafka 0.8; (3) the api of 3.x is likely going to change again. In a post 0.8 release, we can upgrade to metrics 3.x when the final version is released and is deemed stable. Any concern with this approach? Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Dragos Manolescu Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622515#comment-13622515 ] Neha Narkhede commented on KAFKA-826: - I agree with Jun that we should release Kafka 0.8 with metrics 2.x. Let's wait until metrics 3.x APIs are stable. Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Dragos Manolescu Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622650#comment-13622650 ] Scott Carey commented on KAFKA-826: --- Sounds good to me. Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Dragos Manolescu Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622833#comment-13622833 ] Swapnil Ghike commented on KAFKA-826: - Dragos, it seems like we are headed towards agreeing on using 2.2.0. Do you mind including the review suggestions in your patch? If you are busy, I can finish it up too. Thanks. Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Dragos Manolescu Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621416#comment-13621416 ] Scott Carey commented on KAFKA-826: --- My main complaint prior to this was two-fold: * Early versions of metrics 3.x had classpath collisions with 2.2.x , so we would be unable to have both in the same application and we already use 2.2. * There was no official version of metrics 3.x published anywhere to consume, no roadmap, and the developer was MIA for months. Kafka would have had to publish their own artifact version which gets messy fast and would have likely api compatibility issues with any future final metrics 3.0.x release and therefore be very difficult to use kafka 0.8 and the final metrics 3.0 in the same application. If 3.x is stable enough API wise, I'd be fine with keeping kafka on it. I believe 3.x no longer collides with 2.2.x in a classpath, but have not tested that recently, meaning we could migrate to 3.x at our own pace and not have to time it to be in sync with use of Kafka 0.8. Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Dragos Manolescu Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621426#comment-13621426 ] Scott Carey commented on KAFKA-826: --- Given the volume of work that has been done on metrics 3 between the snapshot on March 12 and the recent BETA1, I am comfortable with it -- a full release is likely to be complete before Kafka 0.8 is through its beta. Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Dragos Manolescu Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620566#comment-13620566 ] Otis Gospodnetic commented on KAFKA-826: [~junrao] - I'm on the ML for that metrics lib and a few weeks (1-2 months?) ago Coda wrote an email saying he was not happy with a number of things in 2.x that he completely reworked in 3.x. I don't recall the details, but I recall feeling like 3.x is the version I'd use if I had to pick between 2.x and 3.x. Unless Kafka 0.8 is going to be released within the next week or two, I'd personally go with 3.x, unless you are open moving from 2.x to 3.x in the near future in 0.8.1. Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Dragos Manolescu Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619138#comment-13619138 ] Dragos Manolescu commented on KAFKA-826: I'm sorry you've had problems with this patch. You should be good to go: seac02jh0rjdkq4 ~/Repos/kafka% git status [92] # On branch 0.8 # Untracked files: # (use git add file... to include in what will be committed) # # .idea_modules/ nothing added to commit but untracked files present (use git add to track) mseac02jh0rjdkq4 ~/Repos/kafka% patch -p1 --dry-run ../kafka-fix-for-826-take2.patch [93] patching file core/src/main/scala/kafka/cluster/Partition.scala patching file core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala patching file core/src/main/scala/kafka/controller/KafkaController.scala patching file core/src/main/scala/kafka/log/Log.scala patching file core/src/main/scala/kafka/network/RequestChannel.scala patching file core/src/main/scala/kafka/producer/async/ProducerSendThread.scala patching file core/src/main/scala/kafka/server/AbstractFetcherThread.scala patching file core/src/main/scala/kafka/server/ReplicaManager.scala patching file core/src/main/scala/kafka/server/RequestPurgatory.scala patching file core/src/test/scala/unit/kafka/metrics/KafkaTimerTest.scala patching file project/Build.scala patching file project/build/KafkaProject.scala Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Jun Rao Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619153#comment-13619153 ] Swapnil Ghike commented on KAFKA-826: - Hi Dragos, sorry for bugging you again. I think if I copy paste your new patch, I am not able to apply it again. Do you mind attaching it as a file? Thanks for the help Dragos! Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Jun Rao Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619172#comment-13619172 ] Swapnil Ghike commented on KAFKA-826: - The take2 patch applies quite smoothly! Thanks a ton, will check today how it works out. Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Jun Rao Priority: Blocker Labels: build, kafka-0.8, metrics Attachments: kafka-fix-for-826.patch, kafka-fix-for-826-take2.patch In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617539#comment-13617539 ] Scott Carey commented on KAFKA-826: --- The only real trouble with 3.0.x is if: * it conflicts with 2.2.x if in the same classloader * there is no released artifact in a public maven repo to provide repeatable builds. We might be able to find out when a 3.0-alpha may be available and pushed to a public maven repo. It does not appear that a final version is due out in time. Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Jun Rao Priority: Blocker Labels: build, kafka-0.8, metrics In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617646#comment-13617646 ] Swapnil Ghike commented on KAFKA-826: - [~dragosm]: Could you upload a patch using the attach files options above? I tried applying your patch using patch -p1, but it could not be applied. Thanks. Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Jun Rao Priority: Blocker Labels: build, kafka-0.8, metrics In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616783#comment-13616783 ] Joel Koshy commented on KAFKA-826: -- Thank you for looking into this. Metrics 2.x had a few minor issues with the CsvReporter (which we use in the system tests) and this is why we used 3.x. The fixes that I'm aware of are: - https://github.com/codahale/metrics/pull/225 - https://github.com/codahale/metrics/pull/290 - If a CSV file already exists, metrics throws an IOException and does not resume CSV reporting. This would be the case on a broker bounce for example. Someone put out a patch for this (https://github.com/adagios/metrics/compare/2.x-maintenance...2.x-epoch-in-csv) but I'd have to check if that was pulled into metrics-3.x Unfortunately, although the above are small fixes, if we want to use the official 2.x metrics release we would need to copy over the code of the metrics CsvReporter (i.e., into a new implementation of metrics' AbstractReporter), patch in those fixes and plug that into KafkaMetricsCsvReporter. I don't think it is difficult, but a bit clunky (which is why at the time we preferred using 3.x). Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Assignee: Jun Rao Priority: Blocker Labels: build, kafka-0.8, metrics In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13613192#comment-13613192 ] Scott Carey commented on KAFKA-826: --- Thank you! We will be able to test and validate this quickly once there is a patch. Metrics 3.0.x has hit its first snapshot recently: https://groups.google.com/forum/#!topic/metrics-user/c4sPUhLjHEQ However, it looks like it won't be done in time for Kafka 0.8. It now at least does not conflict with a copy of 2.2.x as badly as it did a couple months ago. Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x - Key: KAFKA-826 URL: https://issues.apache.org/jira/browse/KAFKA-826 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8 Reporter: Neha Narkhede Priority: Blocker Labels: kafka-0.8 In order to mavenize Kafka 0.8, we have to depend on metrics 2.2.0 since metrics 3.x is a huge change as well as not an officially supported release. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
