Re: First Contribution
Hi Steven, Thanks for your contribution! This is definitively a process we need to automate. I left a few comments in your PRs. Thanks, Mickael On Tue, Jun 13, 2023 at 8:11 PM Lovish Madhu wrote: > > Looks good, but I am also a newbie. > > However I feel like variables such as n = 10 as some meaningful variable > name as it is global constant. > Also you forgot to use n and instead used 10 > here: refreshed_collaborators[:10] > > On Tue, Jun 13, 2023 at 11:23 PM Steven Booke > wrote: > > > To whom this may concern, > > > > This is my first time contributing and I have just submitted my first PR. I > > have made changes to both apache/kafka-site and apache/kafka repos. I > > believe I have followed the detailed instructions for contributing a code > > change and am looking for feedback. > > > > Here are the PRs for reference: https://github.com/apache/kafka/pull/13842 > > and https://github.com/apache/kafka-site/pull/521 > > > > Here is the JIRA ticket for reference: > > https://issues.apache.org/jira/browse/KAFKA-14995 > > > > -- > > Regards > > > > Steven Booke > >
Re: First Contribution
Looks good, but I am also a newbie. However I feel like variables such as n = 10 as some meaningful variable name as it is global constant. Also you forgot to use n and instead used 10 here: refreshed_collaborators[:10] On Tue, Jun 13, 2023 at 11:23 PM Steven Booke wrote: > To whom this may concern, > > This is my first time contributing and I have just submitted my first PR. I > have made changes to both apache/kafka-site and apache/kafka repos. I > believe I have followed the detailed instructions for contributing a code > change and am looking for feedback. > > Here are the PRs for reference: https://github.com/apache/kafka/pull/13842 > and https://github.com/apache/kafka-site/pull/521 > > Here is the JIRA ticket for reference: > https://issues.apache.org/jira/browse/KAFKA-14995 > > -- > Regards > > Steven Booke >
First Contribution
To whom this may concern, This is my first time contributing and I have just submitted my first PR. I have made changes to both apache/kafka-site and apache/kafka repos. I believe I have followed the detailed instructions for contributing a code change and am looking for feedback. Here are the PRs for reference: https://github.com/apache/kafka/pull/13842 and https://github.com/apache/kafka-site/pull/521 Here is the JIRA ticket for reference: https://issues.apache.org/jira/browse/KAFKA-14995 -- Regards Steven Booke
First Contribution
To whom this may concern, This is my first time contributing and I have just submitted my first PR. I have made changes to both apache/kafka-site and apache/kafka repos. I believe I have followed the detailed instructions for contributing a code change and am looking for feedback. Here are the PRs for reference: https://github.com/apache/kafka/pull/13842 and https://github.com/apache/kafka-site/pull/521 Here is the JIRA ticket for reference: https://issues.apache.org/jira/browse/KAFKA-14995 -- Regards Steven Booke
Re: Help with first contribution
Hello, Matthias. Thank you! I took this ticket. В Вс, 01/07/2018 в 18:10 -0700, Matthias J. Sax пишет: > How about this: https://issues.apache.org/jira/browse/KAFKA-7125 > > -Matthias > > On 6/28/18 8:31 AM, Nikolay Izhikov wrote: > > Hello, Matthias! > > > > > Did you filter for JIRAs with label "newbie" or "beginner"? > > > > "newbie" as it mentioned in "how to contribute" guide. > > Seems, many of them already discussed or assigned. > > > > Can you, please, suggest one? > > > > > What component of Kafka do you want to work on/interests you most? > > > > Actually, I don't have any specific wishes so any good-to-start issue will > > be accepted. > > > > В Чт, 28/06/2018 в 08:02 -0700, Matthias J. Sax пишет: > > > Nikolay, > > > > > > thanks for your interest in contribution to Kafka! > > > > > > Did you filter for JIRAs with label "newbie" or "beginner"? What > > > component of Kafka do you want to work on/interests you most? > > > > > > > > > -Matthias > > > > > > On 6/28/18 3:20 AM, Nikolay Izhikov wrote: > > > > Hello, guys. > > > > > > > > I'm experienced java/scala engineer. > > > > I want to contribute to kafka. > > > > I read the documentation and look over jira tickets. > > > > > > > > Seems it's not easy to find a right issue to start contributing with. > > > > > > > > Can you, please, suggest some ticket(s) or JIRA filters I can take and > > > > solve. > > > > > > signature.asc Description: This is a digitally signed message part
Re: Help with first contribution
How about this: https://issues.apache.org/jira/browse/KAFKA-7125 -Matthias On 6/28/18 8:31 AM, Nikolay Izhikov wrote: > Hello, Matthias! > >> Did you filter for JIRAs with label "newbie" or "beginner"? > > "newbie" as it mentioned in "how to contribute" guide. > Seems, many of them already discussed or assigned. > > Can you, please, suggest one? > >> What component of Kafka do you want to work on/interests you most? > > Actually, I don't have any specific wishes so any good-to-start issue will be > accepted. > > В Чт, 28/06/2018 в 08:02 -0700, Matthias J. Sax пишет: >> Nikolay, >> >> thanks for your interest in contribution to Kafka! >> >> Did you filter for JIRAs with label "newbie" or "beginner"? What >> component of Kafka do you want to work on/interests you most? >> >> >> -Matthias >> >> On 6/28/18 3:20 AM, Nikolay Izhikov wrote: >>> Hello, guys. >>> >>> I'm experienced java/scala engineer. >>> I want to contribute to kafka. >>> I read the documentation and look over jira tickets. >>> >>> Seems it's not easy to find a right issue to start contributing with. >>> >>> Can you, please, suggest some ticket(s) or JIRA filters I can take and >>> solve. >>> >> signature.asc Description: OpenPGP digital signature
Re: Help with first contribution
Hello, Matthias! > Did you filter for JIRAs with label "newbie" or "beginner"? "newbie" as it mentioned in "how to contribute" guide. Seems, many of them already discussed or assigned. Can you, please, suggest one? > What component of Kafka do you want to work on/interests you most? Actually, I don't have any specific wishes so any good-to-start issue will be accepted. В Чт, 28/06/2018 в 08:02 -0700, Matthias J. Sax пишет: > Nikolay, > > thanks for your interest in contribution to Kafka! > > Did you filter for JIRAs with label "newbie" or "beginner"? What > component of Kafka do you want to work on/interests you most? > > > -Matthias > > On 6/28/18 3:20 AM, Nikolay Izhikov wrote: > > Hello, guys. > > > > I'm experienced java/scala engineer. > > I want to contribute to kafka. > > I read the documentation and look over jira tickets. > > > > Seems it's not easy to find a right issue to start contributing with. > > > > Can you, please, suggest some ticket(s) or JIRA filters I can take and > > solve. > > > > signature.asc Description: This is a digitally signed message part
Re: Help with first contribution
Nikolay, thanks for your interest in contribution to Kafka! Did you filter for JIRAs with label "newbie" or "beginner"? What component of Kafka do you want to work on/interests you most? -Matthias On 6/28/18 3:20 AM, Nikolay Izhikov wrote: > Hello, guys. > > I'm experienced java/scala engineer. > I want to contribute to kafka. > I read the documentation and look over jira tickets. > > Seems it's not easy to find a right issue to start contributing with. > > Can you, please, suggest some ticket(s) or JIRA filters I can take and solve. > signature.asc Description: OpenPGP digital signature
Help with first contribution
Hello, guys. I'm experienced java/scala engineer. I want to contribute to kafka. I read the documentation and look over jira tickets. Seems it's not easy to find a right issue to start contributing with. Can you, please, suggest some ticket(s) or JIRA filters I can take and solve. signature.asc Description: This is a digitally signed message part
Re: First contribution
Hi Marc, You can take a look at this page: https://issues.apache.org/jira/issues/?jql=project%20%3D%20KAFKA%20AND%20labels%20%3D%20newbie%20AND%20status%20%3D%20Open Guozhang On Thu, Mar 2, 2017 at 12:59 PM, Marc Juchliwrote: > Hi all. > > We are a group of master students, about to start contributing to the > apache Kafka project . Are there any suggestions for an open issue for us > to knock our heads on and propose a fix within a reasonable amount of time? > > Thanks! > Marc > -- -- Guozhang
First contribution
Hi all. We are a group of master students, about to start contributing to the apache Kafka project . Are there any suggestions for an open issue for us to knock our heads on and propose a fix within a reasonable amount of time? Thanks! Marc