Re: [REVIEW REQUEST] ConsumerGroupCommand move to tools
Hi Team, Greetings, Apologies for the delay in reply as I was down with flu. We actually reached out to you for IT/ SAP/ Oracle/ Infor / Microsoft “VOTEC IT SERVICE PARTNERSHIP” “IT SERVICE OUTSOURCING” “ “PARTNER SERVICE SUBCONTRACTING” We have very attractive newly introduce reasonably price PARTNER IT SERVICE ODC SUBCONTRACTING MODEL in USA, Philippines, India and Singapore etc with White Label Model. Our LOW COST IT SERVICE ODC MODEL eliminate the cost of expensive employee payroll, Help partner to get profit more than 50% on each project.. ..We really mean it. We are already working with platinum partner like NTT DATA, NEC Singapore, Deloitte, Hitachi consulting. ACCENTURE, Abeam Singapore etc. Are u keen to understand VOTEC IT SERVICE MODEL PARTNERSHIP offerings? Let us know your availability this week OR Next week?? We can arrange discussion with Partner Manager. > On 01/25/2024 1:33 AM +08 Николай Ижиков wrote: > > > Hello. > > After merge of the first PR in series there are two following PR’s that moves > some of ConsumerGroupCommand tests to tools module. > Please, take a look: > > * ConsoleGroupServiceTest - https://github.com/apache/kafka/pull/15248 > * DeleteConsumerGroupsTest, DeleteOffsetsConsumerGroupCommandIntegrationTest, > ListConsumerGroupTest https://github.com/apache/kafka/pull/15256 > > > > 15 янв. 2024 г., в 18:10, Николай Ижиков > > написал(а): > > > > Hello. > > > > The PRs still need review. > > > > Please, take a look - https://github.com/apache/kafka/pull/14856 > > > > > > > >> 12 дек. 2023 г., в 11:01, Николай Ижиков написал(а): > >> > >> Hello. > >> > >> Please, take a time and help me with moving ConsumerGroupCommand move tools > >> First patch in the series are waiting for review. > >> > >> > >>> 4 дек. 2023 г., в 11:07, Николай Ижиков > >>> написал(а): > >>> > >>> Hello. > >>> > >>> Dear Kafka committers. > >>> As far as I know - we moving Kafka from scala to java. > >>> > >>> I prepared a series of PRs to move `ConsumerGroupCommand` from scala to > >>> java. > >>> From my experience, right now, Mickael Maison and Justine Olshan are > >>> overwhelmed with other activities and can review my patches from time to > >>> time only. > >>> > >>> So, if any Kafka committer has any chance to review simple patches and > >>> keep pace of moving scala code to java, please, do it. > >>> Help me to move these command to tools. > >>> > >>> Looks like all code are prepared and quality review is all we need :). > >>> > 30 нояб. 2023 г., в 13:28, Николай Ижиков > написал(а): > > Hello. > > I prepared a PR to move `ConsumerGroupCommand` to `tools` module. > Full changes are pretty huge [1] so I split them into several PR’s. > > Please, take a look at first PR in the series - > https://github.com/apache/kafka/pull/14856 > > PR adds `ConsumerGroupCommandOptions` class and other command case > classes to `tools` module. > > [1] https://github.com/apache/kafka/pull/14471 > > >>> > >> > >
Re: [REVIEW REQUEST] ConsumerGroupCommand move to tools
Hello. After merge of the first PR in series there are two following PR’s that moves some of ConsumerGroupCommand tests to tools module. Please, take a look: * ConsoleGroupServiceTest - https://github.com/apache/kafka/pull/15248 * DeleteConsumerGroupsTest, DeleteOffsetsConsumerGroupCommandIntegrationTest, ListConsumerGroupTest https://github.com/apache/kafka/pull/15256 > 15 янв. 2024 г., в 18:10, Николай Ижиков написал(а): > > Hello. > > The PRs still need review. > > Please, take a look - https://github.com/apache/kafka/pull/14856 > > > >> 12 дек. 2023 г., в 11:01, Николай Ижиков написал(а): >> >> Hello. >> >> Please, take a time and help me with moving ConsumerGroupCommand move tools >> First patch in the series are waiting for review. >> >> >>> 4 дек. 2023 г., в 11:07, Николай Ижиков написал(а): >>> >>> Hello. >>> >>> Dear Kafka committers. >>> As far as I know - we moving Kafka from scala to java. >>> >>> I prepared a series of PRs to move `ConsumerGroupCommand` from scala to >>> java. >>> From my experience, right now, Mickael Maison and Justine Olshan are >>> overwhelmed with other activities and can review my patches from time to >>> time only. >>> >>> So, if any Kafka committer has any chance to review simple patches and keep >>> pace of moving scala code to java, please, do it. >>> Help me to move these command to tools. >>> >>> Looks like all code are prepared and quality review is all we need :). >>> 30 нояб. 2023 г., в 13:28, Николай Ижиков написал(а): Hello. I prepared a PR to move `ConsumerGroupCommand` to `tools` module. Full changes are pretty huge [1] so I split them into several PR’s. Please, take a look at first PR in the series - https://github.com/apache/kafka/pull/14856 PR adds `ConsumerGroupCommandOptions` class and other command case classes to `tools` module. [1] https://github.com/apache/kafka/pull/14471 >>> >> >
Re: [REVIEW REQUEST] ConsumerGroupCommand move to tools
Hello. The PRs still need review. Please, take a look - https://github.com/apache/kafka/pull/14856 > 12 дек. 2023 г., в 11:01, Николай Ижиков написал(а): > > Hello. > > Please, take a time and help me with moving ConsumerGroupCommand move tools > First patch in the series are waiting for review. > > >> 4 дек. 2023 г., в 11:07, Николай Ижиков написал(а): >> >> Hello. >> >> Dear Kafka committers. >> As far as I know - we moving Kafka from scala to java. >> >> I prepared a series of PRs to move `ConsumerGroupCommand` from scala to java. >> From my experience, right now, Mickael Maison and Justine Olshan are >> overwhelmed with other activities and can review my patches from time to >> time only. >> >> So, if any Kafka committer has any chance to review simple patches and keep >> pace of moving scala code to java, please, do it. >> Help me to move these command to tools. >> >> Looks like all code are prepared and quality review is all we need :). >> >>> 30 нояб. 2023 г., в 13:28, Николай Ижиков >>> написал(а): >>> >>> Hello. >>> >>> I prepared a PR to move `ConsumerGroupCommand` to `tools` module. >>> Full changes are pretty huge [1] so I split them into several PR’s. >>> >>> Please, take a look at first PR in the series - >>> https://github.com/apache/kafka/pull/14856 >>> >>> PR adds `ConsumerGroupCommandOptions` class and other command case classes >>> to `tools` module. >>> >>> [1] https://github.com/apache/kafka/pull/14471 >>> >> >
Re: [REVIEW REQUEST] ConsumerGroupCommand move to tools
Hello. Please, take a time and help me with moving ConsumerGroupCommand move tools First patch in the series are waiting for review. > 4 дек. 2023 г., в 11:07, Николай Ижиков написал(а): > > Hello. > > Dear Kafka committers. > As far as I know - we moving Kafka from scala to java. > > I prepared a series of PRs to move `ConsumerGroupCommand` from scala to java. > From my experience, right now, Mickael Maison and Justine Olshan are > overwhelmed with other activities and can review my patches from time to time > only. > > So, if any Kafka committer has any chance to review simple patches and keep > pace of moving scala code to java, please, do it. > Help me to move these command to tools. > > Looks like all code are prepared and quality review is all we need :). > >> 30 нояб. 2023 г., в 13:28, Николай Ижиков >> написал(а): >> >> Hello. >> >> I prepared a PR to move `ConsumerGroupCommand` to `tools` module. >> Full changes are pretty huge [1] so I split them into several PR’s. >> >> Please, take a look at first PR in the series - >> https://github.com/apache/kafka/pull/14856 >> >> PR adds `ConsumerGroupCommandOptions` class and other command case classes >> to `tools` module. >> >> [1] https://github.com/apache/kafka/pull/14471 >> >
Re: [REVIEW REQUEST] ConsumerGroupCommand move to tools
Hello. Dear Kafka committers. As far as I know - we moving Kafka from scala to java. I prepared a series of PRs to move `ConsumerGroupCommand` from scala to java. From my experience, right now, Mickael Maison and Justine Olshan are overwhelmed with other activities and can review my patches from time to time only. So, if any Kafka committer has any chance to review simple patches and keep pace of moving scala code to java, please, do it. Help me to move these command to tools. Looks like all code are prepared and quality review is all we need :). > 30 нояб. 2023 г., в 13:28, Николай Ижиков написал(а): > > Hello. > > I prepared a PR to move `ConsumerGroupCommand` to `tools` module. > Full changes are pretty huge [1] so I split them into several PR’s. > > Please, take a look at first PR in the series - > https://github.com/apache/kafka/pull/14856 > > PR adds `ConsumerGroupCommandOptions` class and other command case classes to > `tools` module. > > [1] https://github.com/apache/kafka/pull/14471 >
