Re: [VOTE] Add TaskId field to StreamsException

2021-10-21 Thread Sophie Blee-Goldman 
Thanks all for voting!

This KIP passes with five +1 (binding) votes from John, Bill, Guozhang,
Matthias, and myself,
and three +1 (non-binding) votes from Luke, Walker, and Israel.

Best,
Sophie

On Tue, Oct 19, 2021 at 11:58 AM Matthias J. Sax  wrote:

> +1 (binding)
>
> On 10/19/21 10:37 AM, Israel Ekpo wrote:
> > Thanks for the KIP
> >
> > +1 from me (non binding)
> >
> > On Tue, Oct 19, 2021 at 12:39 PM Guozhang Wang 
> wrote:
> >
> >> Thanks for the KIP Sophie, I'm big +1 on this idea :)
> >>
> >> On Tue, Oct 19, 2021 at 6:48 AM Bill Bejeck  wrote:
> >>
> >>> Thanks for the KIP Sophie, I think this will be helpful.
> >>>
> >>> +1(binding)
> >>>
> >>> -Bill
> >>>
> >>> On Mon, Oct 18, 2021 at 5:04 PM John Roesler 
> >> wrote:
> >>>
>  Thanks, Sophie,
> 
>  +1 from me.
> 
>  I was a little apprehensive about the potential to break
>  exception handler logic, but I agree with your comment in
>  the "compatibility" section: Identifying the causes of
>  exceptions is always kind of chaotic and this seems like
>  more of an improvement than anything.
> 
>  Regardless, it'll be really nice to get some information
>  about the context of the exception.
> 
>  Thanks!
>  -John
> 
>  On Mon, 2021-10-18 at 13:56 -0500, Walker Carlson wrote:
> > Hey Sophie,
> >
> > +1 for me, I think that is would only help.
> >
> > Walker
> >
> > On Mon, Oct 18, 2021 at 1:45 AM Luke Chen  wrote:
> >
> >> Hi Sophie,
> >> Add taskId to make the exception much clear is a good improvement.
> >> + 1 (non-binding)
> >>
> >> Thank you.
> >> Luke
> >>
> >> On Mon, Oct 18, 2021 at 12:10 PM Sophie Blee-Goldman
> >>  wrote:
> >>
> >>> Hey all,
> >>>
> >>> I'd like to kick off the vote on this small KIP which adds a
> >> TaskId
>  field
> >>> to the StreamsException class. Please take a look and cast your
> >>> vote
>  when
> >>> you have a chance.
> >>>
> >>> Links:
> >>>
> >>> - KIP-783: Add TaskId field to StreamsException
> >>> 
> >>> - PR #11405 
> >>>
> >>>
> >>> Thanks!
> >>> Sophie
> >>>
> >>
> 
> 
> 
> >>>
> >>
> >>
> >> --
> >> -- Guozhang
> >>
> >
>

Re: [VOTE] Add TaskId field to StreamsException

2021-10-19 Thread Matthias J. Sax 

+1 (binding)

On 10/19/21 10:37 AM, Israel Ekpo wrote:

Thanks for the KIP

+1 from me (non binding)

On Tue, Oct 19, 2021 at 12:39 PM Guozhang Wang  wrote:


Thanks for the KIP Sophie, I'm big +1 on this idea :)

On Tue, Oct 19, 2021 at 6:48 AM Bill Bejeck  wrote:


Thanks for the KIP Sophie, I think this will be helpful.

+1(binding)

-Bill

On Mon, Oct 18, 2021 at 5:04 PM John Roesler 

wrote:



Thanks, Sophie,

+1 from me.

I was a little apprehensive about the potential to break
exception handler logic, but I agree with your comment in
the "compatibility" section: Identifying the causes of
exceptions is always kind of chaotic and this seems like
more of an improvement than anything.

Regardless, it'll be really nice to get some information
about the context of the exception.

Thanks!
-John

On Mon, 2021-10-18 at 13:56 -0500, Walker Carlson wrote:

Hey Sophie,

+1 for me, I think that is would only help.

Walker

On Mon, Oct 18, 2021 at 1:45 AM Luke Chen  wrote:


Hi Sophie,
Add taskId to make the exception much clear is a good improvement.
+ 1 (non-binding)

Thank you.
Luke

On Mon, Oct 18, 2021 at 12:10 PM Sophie Blee-Goldman
 wrote:


Hey all,

I'd like to kick off the vote on this small KIP which adds a

TaskId

field

to the StreamsException class. Please take a look and cast your

vote

when

you have a chance.

Links:

- KIP-783: Add TaskId field to StreamsException

- PR #11405 


Thanks!
Sophie












--
-- Guozhang

Re: [VOTE] Add TaskId field to StreamsException

2021-10-19 Thread Israel Ekpo 
Thanks for the KIP

+1 from me (non binding)

On Tue, Oct 19, 2021 at 12:39 PM Guozhang Wang  wrote:

> Thanks for the KIP Sophie, I'm big +1 on this idea :)
>
> On Tue, Oct 19, 2021 at 6:48 AM Bill Bejeck  wrote:
>
> > Thanks for the KIP Sophie, I think this will be helpful.
> >
> > +1(binding)
> >
> > -Bill
> >
> > On Mon, Oct 18, 2021 at 5:04 PM John Roesler 
> wrote:
> >
> > > Thanks, Sophie,
> > >
> > > +1 from me.
> > >
> > > I was a little apprehensive about the potential to break
> > > exception handler logic, but I agree with your comment in
> > > the "compatibility" section: Identifying the causes of
> > > exceptions is always kind of chaotic and this seems like
> > > more of an improvement than anything.
> > >
> > > Regardless, it'll be really nice to get some information
> > > about the context of the exception.
> > >
> > > Thanks!
> > > -John
> > >
> > > On Mon, 2021-10-18 at 13:56 -0500, Walker Carlson wrote:
> > > > Hey Sophie,
> > > >
> > > > +1 for me, I think that is would only help.
> > > >
> > > > Walker
> > > >
> > > > On Mon, Oct 18, 2021 at 1:45 AM Luke Chen  wrote:
> > > >
> > > > > Hi Sophie,
> > > > > Add taskId to make the exception much clear is a good improvement.
> > > > > + 1 (non-binding)
> > > > >
> > > > > Thank you.
> > > > > Luke
> > > > >
> > > > > On Mon, Oct 18, 2021 at 12:10 PM Sophie Blee-Goldman
> > > > >  wrote:
> > > > >
> > > > > > Hey all,
> > > > > >
> > > > > > I'd like to kick off the vote on this small KIP which adds a
> TaskId
> > > field
> > > > > > to the StreamsException class. Please take a look and cast your
> > vote
> > > when
> > > > > > you have a chance.
> > > > > >
> > > > > > Links:
> > > > > >
> > > > > >- KIP-783: Add TaskId field to StreamsException
> > > > > >
> > > > > >- PR #11405 
> > > > > >
> > > > > >
> > > > > > Thanks!
> > > > > > Sophie
> > > > > >
> > > > >
> > >
> > >
> > >
> >
>
>
> --
> -- Guozhang
>

Re: [VOTE] Add TaskId field to StreamsException

2021-10-19 Thread Guozhang Wang 
Thanks for the KIP Sophie, I'm big +1 on this idea :)

On Tue, Oct 19, 2021 at 6:48 AM Bill Bejeck  wrote:

> Thanks for the KIP Sophie, I think this will be helpful.
>
> +1(binding)
>
> -Bill
>
> On Mon, Oct 18, 2021 at 5:04 PM John Roesler  wrote:
>
> > Thanks, Sophie,
> >
> > +1 from me.
> >
> > I was a little apprehensive about the potential to break
> > exception handler logic, but I agree with your comment in
> > the "compatibility" section: Identifying the causes of
> > exceptions is always kind of chaotic and this seems like
> > more of an improvement than anything.
> >
> > Regardless, it'll be really nice to get some information
> > about the context of the exception.
> >
> > Thanks!
> > -John
> >
> > On Mon, 2021-10-18 at 13:56 -0500, Walker Carlson wrote:
> > > Hey Sophie,
> > >
> > > +1 for me, I think that is would only help.
> > >
> > > Walker
> > >
> > > On Mon, Oct 18, 2021 at 1:45 AM Luke Chen  wrote:
> > >
> > > > Hi Sophie,
> > > > Add taskId to make the exception much clear is a good improvement.
> > > > + 1 (non-binding)
> > > >
> > > > Thank you.
> > > > Luke
> > > >
> > > > On Mon, Oct 18, 2021 at 12:10 PM Sophie Blee-Goldman
> > > >  wrote:
> > > >
> > > > > Hey all,
> > > > >
> > > > > I'd like to kick off the vote on this small KIP which adds a TaskId
> > field
> > > > > to the StreamsException class. Please take a look and cast your
> vote
> > when
> > > > > you have a chance.
> > > > >
> > > > > Links:
> > > > >
> > > > >- KIP-783: Add TaskId field to StreamsException
> > > > >
> > > > >- PR #11405 
> > > > >
> > > > >
> > > > > Thanks!
> > > > > Sophie
> > > > >
> > > >
> >
> >
> >
>


-- 
-- Guozhang

Re: [VOTE] Add TaskId field to StreamsException

2021-10-19 Thread Bill Bejeck 
Thanks for the KIP Sophie, I think this will be helpful.

+1(binding)

-Bill

On Mon, Oct 18, 2021 at 5:04 PM John Roesler  wrote:

> Thanks, Sophie,
>
> +1 from me.
>
> I was a little apprehensive about the potential to break
> exception handler logic, but I agree with your comment in
> the "compatibility" section: Identifying the causes of
> exceptions is always kind of chaotic and this seems like
> more of an improvement than anything.
>
> Regardless, it'll be really nice to get some information
> about the context of the exception.
>
> Thanks!
> -John
>
> On Mon, 2021-10-18 at 13:56 -0500, Walker Carlson wrote:
> > Hey Sophie,
> >
> > +1 for me, I think that is would only help.
> >
> > Walker
> >
> > On Mon, Oct 18, 2021 at 1:45 AM Luke Chen  wrote:
> >
> > > Hi Sophie,
> > > Add taskId to make the exception much clear is a good improvement.
> > > + 1 (non-binding)
> > >
> > > Thank you.
> > > Luke
> > >
> > > On Mon, Oct 18, 2021 at 12:10 PM Sophie Blee-Goldman
> > >  wrote:
> > >
> > > > Hey all,
> > > >
> > > > I'd like to kick off the vote on this small KIP which adds a TaskId
> field
> > > > to the StreamsException class. Please take a look and cast your vote
> when
> > > > you have a chance.
> > > >
> > > > Links:
> > > >
> > > >- KIP-783: Add TaskId field to StreamsException
> > > >
> > > >- PR #11405 
> > > >
> > > >
> > > > Thanks!
> > > > Sophie
> > > >
> > >
>
>
>

Re: [VOTE] Add TaskId field to StreamsException

2021-10-18 Thread John Roesler 
Thanks, Sophie,

+1 from me.

I was a little apprehensive about the potential to break
exception handler logic, but I agree with your comment in
the "compatibility" section: Identifying the causes of
exceptions is always kind of chaotic and this seems like
more of an improvement than anything.

Regardless, it'll be really nice to get some information
about the context of the exception.

Thanks!
-John

On Mon, 2021-10-18 at 13:56 -0500, Walker Carlson wrote:
> Hey Sophie,
> 
> +1 for me, I think that is would only help.
> 
> Walker
> 
> On Mon, Oct 18, 2021 at 1:45 AM Luke Chen  wrote:
> 
> > Hi Sophie,
> > Add taskId to make the exception much clear is a good improvement.
> > + 1 (non-binding)
> > 
> > Thank you.
> > Luke
> > 
> > On Mon, Oct 18, 2021 at 12:10 PM Sophie Blee-Goldman
> >  wrote:
> > 
> > > Hey all,
> > > 
> > > I'd like to kick off the vote on this small KIP which adds a TaskId field
> > > to the StreamsException class. Please take a look and cast your vote when
> > > you have a chance.
> > > 
> > > Links:
> > > 
> > >- KIP-783: Add TaskId field to StreamsException
> > >
> > >- PR #11405 
> > > 
> > > 
> > > Thanks!
> > > Sophie
> > > 
> >

Re: [VOTE] Add TaskId field to StreamsException

2021-10-18 Thread Walker Carlson 
Hey Sophie,

+1 for me, I think that is would only help.

Walker

On Mon, Oct 18, 2021 at 1:45 AM Luke Chen  wrote:

> Hi Sophie,
> Add taskId to make the exception much clear is a good improvement.
> + 1 (non-binding)
>
> Thank you.
> Luke
>
> On Mon, Oct 18, 2021 at 12:10 PM Sophie Blee-Goldman
>  wrote:
>
> > Hey all,
> >
> > I'd like to kick off the vote on this small KIP which adds a TaskId field
> > to the StreamsException class. Please take a look and cast your vote when
> > you have a chance.
> >
> > Links:
> >
> >- KIP-783: Add TaskId field to StreamsException
> >
> >- PR #11405 
> >
> >
> > Thanks!
> > Sophie
> >
>

Re: [VOTE] Add TaskId field to StreamsException

2021-10-18 Thread Luke Chen 
Hi Sophie,
Add taskId to make the exception much clear is a good improvement.
+ 1 (non-binding)

Thank you.
Luke

On Mon, Oct 18, 2021 at 12:10 PM Sophie Blee-Goldman
 wrote:

> Hey all,
>
> I'd like to kick off the vote on this small KIP which adds a TaskId field
> to the StreamsException class. Please take a look and cast your vote when
> you have a chance.
>
> Links:
>
>- KIP-783: Add TaskId field to StreamsException
>
>- PR #11405 
>
>
> Thanks!
> Sophie
>