Re: [VOTE] KIP-453: Add close() method to RocksDBConfigSetter
Thanks everyone for voting! Closing the vote on this KIP which passes with three +1 (binding) from Guozhang, Bill, and Matthias, and two +1 (non-binding) from Kamal and John. For those interested you can check out the PR here: https://github.com/apache/kafka/pull/6697 On Tue, May 7, 2019 at 7:31 AM Guozhang Wang wrote: > +1 (binding) > > On Mon, May 6, 2019 at 6:44 PM Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > > > +1 (non-binding). Thanks for the KIP. > > > > On Tue, May 7, 2019 at 3:50 AM Bill Bejeck wrote: > > > > > Thanks for the KIP Sophie. > > > > > > +1(binding) > > > > > > On Mon, May 6, 2019 at 4:51 PM John Roesler wrote: > > > > > > > Thanks, Sophie, I reviewed the KIP, and I agree this is the best / > > > > only-practical approach. > > > > > > > > +1 (non-binding) > > > > > > > > On Mon, May 6, 2019 at 2:23 PM Matthias J. Sax < > matth...@confluent.io> > > > > wrote: > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > > > > > > > On 5/6/19 6:28 PM, Sophie Blee-Goldman wrote: > > > > > > Hi all, > > > > > > > > > > > > I'd like to call for a vote on a minor KIP that adds a close() > > method > > > > to > > > > > > the RocksDBConfigSetter interface of Streams. > > > > > > > > > > > > Link: > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-453%3A+Add+close%28%29+method+to+RocksDBConfigSetter > > > > > > > > > > > > This is important for users who have created RocksOBjects in > > > > > > RocksDBConfigSetter#setConfig to avoid leaking off-heap memory > > > > > > > > > > > > Thanks! > > > > > > Sophie > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > -- Guozhang >
Re: [VOTE] KIP-453: Add close() method to RocksDBConfigSetter
+1 (binding) On Mon, May 6, 2019 at 6:44 PM Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > +1 (non-binding). Thanks for the KIP. > > On Tue, May 7, 2019 at 3:50 AM Bill Bejeck wrote: > > > Thanks for the KIP Sophie. > > > > +1(binding) > > > > On Mon, May 6, 2019 at 4:51 PM John Roesler wrote: > > > > > Thanks, Sophie, I reviewed the KIP, and I agree this is the best / > > > only-practical approach. > > > > > > +1 (non-binding) > > > > > > On Mon, May 6, 2019 at 2:23 PM Matthias J. Sax > > > wrote: > > > > > > > +1 (binding) > > > > > > > > > > > > > > > > On 5/6/19 6:28 PM, Sophie Blee-Goldman wrote: > > > > > Hi all, > > > > > > > > > > I'd like to call for a vote on a minor KIP that adds a close() > method > > > to > > > > > the RocksDBConfigSetter interface of Streams. > > > > > > > > > > Link: > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-453%3A+Add+close%28%29+method+to+RocksDBConfigSetter > > > > > > > > > > This is important for users who have created RocksOBjects in > > > > > RocksDBConfigSetter#setConfig to avoid leaking off-heap memory > > > > > > > > > > Thanks! > > > > > Sophie > > > > > > > > > > > > > > > > > > > -- -- Guozhang
Re: [VOTE] KIP-453: Add close() method to RocksDBConfigSetter
+1 (non-binding). Thanks for the KIP. On Tue, May 7, 2019 at 3:50 AM Bill Bejeck wrote: > Thanks for the KIP Sophie. > > +1(binding) > > On Mon, May 6, 2019 at 4:51 PM John Roesler wrote: > > > Thanks, Sophie, I reviewed the KIP, and I agree this is the best / > > only-practical approach. > > > > +1 (non-binding) > > > > On Mon, May 6, 2019 at 2:23 PM Matthias J. Sax > > wrote: > > > > > +1 (binding) > > > > > > > > > > > > On 5/6/19 6:28 PM, Sophie Blee-Goldman wrote: > > > > Hi all, > > > > > > > > I'd like to call for a vote on a minor KIP that adds a close() method > > to > > > > the RocksDBConfigSetter interface of Streams. > > > > > > > > Link: > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-453%3A+Add+close%28%29+method+to+RocksDBConfigSetter > > > > > > > > This is important for users who have created RocksOBjects in > > > > RocksDBConfigSetter#setConfig to avoid leaking off-heap memory > > > > > > > > Thanks! > > > > Sophie > > > > > > > > > > > > >
Re: [VOTE] KIP-453: Add close() method to RocksDBConfigSetter
Thanks for the KIP Sophie. +1(binding) On Mon, May 6, 2019 at 4:51 PM John Roesler wrote: > Thanks, Sophie, I reviewed the KIP, and I agree this is the best / > only-practical approach. > > +1 (non-binding) > > On Mon, May 6, 2019 at 2:23 PM Matthias J. Sax > wrote: > > > +1 (binding) > > > > > > > > On 5/6/19 6:28 PM, Sophie Blee-Goldman wrote: > > > Hi all, > > > > > > I'd like to call for a vote on a minor KIP that adds a close() method > to > > > the RocksDBConfigSetter interface of Streams. > > > > > > Link: > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-453%3A+Add+close%28%29+method+to+RocksDBConfigSetter > > > > > > This is important for users who have created RocksOBjects in > > > RocksDBConfigSetter#setConfig to avoid leaking off-heap memory > > > > > > Thanks! > > > Sophie > > > > > > > >
Re: [VOTE] KIP-453: Add close() method to RocksDBConfigSetter
Thanks, Sophie, I reviewed the KIP, and I agree this is the best / only-practical approach. +1 (non-binding) On Mon, May 6, 2019 at 2:23 PM Matthias J. Sax wrote: > +1 (binding) > > > > On 5/6/19 6:28 PM, Sophie Blee-Goldman wrote: > > Hi all, > > > > I'd like to call for a vote on a minor KIP that adds a close() method to > > the RocksDBConfigSetter interface of Streams. > > > > Link: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-453%3A+Add+close%28%29+method+to+RocksDBConfigSetter > > > > This is important for users who have created RocksOBjects in > > RocksDBConfigSetter#setConfig to avoid leaking off-heap memory > > > > Thanks! > > Sophie > > > >
Re: [VOTE] KIP-453: Add close() method to RocksDBConfigSetter
+1 (binding) On 5/6/19 6:28 PM, Sophie Blee-Goldman wrote: > Hi all, > > I'd like to call for a vote on a minor KIP that adds a close() method to > the RocksDBConfigSetter interface of Streams. > > Link: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-453%3A+Add+close%28%29+method+to+RocksDBConfigSetter > > This is important for users who have created RocksOBjects in > RocksDBConfigSetter#setConfig to avoid leaking off-heap memory > > Thanks! > Sophie > signature.asc Description: OpenPGP digital signature