Re: Review Request 23567: Patch for KAFKA-1522
On Aug. 14, 2014, 11:15 p.m., Joel Koshy wrote: core/src/main/scala/kafka/api/TransactionRequest.scala, line 47 https://reviews.apache.org/r/23567/diff/7/?file=657006#file657006line47 It would help to have comments here describing each type's role. Please check the updated patch. Thanks! - Dong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/#review50663 --- On Aug. 15, 2014, 6:37 p.m., Dong Lin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated Aug. 15, 2014, 6:37 p.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description --- KAFKA-1522; Tansactional messaging request/response definitions Diffs - core/src/main/scala/kafka/api/RequestKeys.scala c24c0345feedc7b9e2e9f40af11bfa1b8d328c43 core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala cd16ced5465d098be7a60498326b2a98c248f343 Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
Re: Review Request 23567: Patch for KAFKA-1522
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/#review50663 --- Ship it! core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment88514 It would help to have comments here describing each type's role. - Joel Koshy On Aug. 9, 2014, 4:21 a.m., Dong Lin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated Aug. 9, 2014, 4:21 a.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description --- KAFKA-1522; Tansactional messaging request/response definitions Diffs - core/src/main/scala/kafka/api/RequestKeys.scala c24c0345feedc7b9e2e9f40af11bfa1b8d328c43 core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala cd16ced5465d098be7a60498326b2a98c248f343 Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
Re: Review Request 23567: Patch for KAFKA-1522
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/#review50081 --- core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment87615 Although this is sort-of a constructor it is a regular method so start with lower case. Also, maybe call it transactionRequestWithNewControl core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment87613 commit vs pre-commit: I think this is needed for the txcoordinator to broker instruction. i.e., there is a distinction between what is stored in the log and the inter-broker communcation. I'm wondering if we should separate these better. OTOH if we were to separate these they should ideally be consistent (i.e., same value) which is easier if they are all in one place - what do you think? core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment87616 From the comments in the earlier version of the patch we concluded that you did not need the order - can we just do a simple groupBy? core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment87617 Same as above - thought this was no longer required (see comments from previous review) - Joel Koshy On Aug. 6, 2014, 4:28 a.m., Dong Lin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated Aug. 6, 2014, 4:28 a.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description --- KAFKA-1522 Tansactional messaging request/response definitions Diffs - core/src/main/scala/kafka/api/RequestKeys.scala c24c0345feedc7b9e2e9f40af11bfa1b8d328c43 core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala cd16ced5465d098be7a60498326b2a98c248f343 Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
Re: Review Request 23567: Patch for KAFKA-1522
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated Aug. 9, 2014, 4:21 a.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description (updated) --- KAFKA-1522; Tansactional messaging request/response definitions Diffs (updated) - core/src/main/scala/kafka/api/RequestKeys.scala c24c0345feedc7b9e2e9f40af11bfa1b8d328c43 core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala cd16ced5465d098be7a60498326b2a98c248f343 Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
Re: Review Request 23567: Patch for KAFKA-1522
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated Aug. 6, 2014, 4:28 a.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description --- KAFKA-1522 Tansactional messaging request/response definitions Diffs (updated) - core/src/main/scala/kafka/api/RequestKeys.scala c24c0345feedc7b9e2e9f40af11bfa1b8d328c43 core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala cd16ced5465d098be7a60498326b2a98c248f343 Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
Re: Review Request 23567: Patch for KAFKA-1522
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 22, 2014, 11:43 p.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description (updated) --- KAFKA-1522 Tansactional messaging request/response definitions Diffs (updated) - core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala a2117b34c2ee3554602fe068eed0c90b075958c1 Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
Re: Review Request 23567: Patch for KAFKA-1522
On July 21, 2014, 5:49 p.m., Joel Koshy wrote: core/src/main/scala/kafka/api/TransactionRequest.scala, line 87 https://reviews.apache.org/r/23567/diff/4/?file=635090#file635090line87 TxControlTypes would be clearer I think (also based on what I have seen so far in KAFKA-1523 rb - I think you intend this to be stored in the message key which it should not.) Sure. Fixed! On July 21, 2014, 5:49 p.m., Joel Koshy wrote: core/src/main/scala/kafka/api/TransactionRequest.scala, line 172 https://reviews.apache.org/r/23567/diff/4/?file=635090#file635090line172 Why does it need to be ordered? You could just use the groupedBy function. Originally the order is needed, because when a broker receives a transactionRequest, it appends the request to the first topicPartition in the txPartitions. Based on your other comments, I have batched the transactionRequest sent to the same broker. Now this order is not needed. On July 21, 2014, 5:49 p.m., Joel Koshy wrote: core/src/main/scala/kafka/api/TransactionRequest.scala, line 181 https://reviews.apache.org/r/23567/diff/4/?file=635090#file635090line181 What does this method do? I have further comments on this in rb for KAFKA-1523 which I'm doing in parallel. This method return the first topicPartition in the txPartitions. The broker will append request to this partition. Now I have batched the transactionRequest sent to the same broker. This function is no longer needed. On July 21, 2014, 5:49 p.m., Joel Koshy wrote: core/src/main/scala/kafka/api/TransactionResponse.scala, line 36 https://reviews.apache.org/r/23567/diff/4/?file=635091#file635091line36 Would it make sense to have a per-partition error-response? E.g., after a prepare-commit/abort: if a transaction spans a lot of partitions and one of those brokers goes down the coordinatorwould only need to retry a commit/abort for that broker. Although the alternative is to just resend all the txcontrol messages to all the brokers. Sure! After batching the transactionRequest sent to the same broker, I have also updated transactionResponse to have a per-partition error-response. On July 21, 2014, 5:49 p.m., Joel Koshy wrote: core/src/main/scala/kafka/api/TransactionRequest.scala, line 41 https://reviews.apache.org/r/23567/diff/4/?file=635090#file635090line41 Method names should ideally not start with a capital. copyTransactionToTxId could be a reasonable name. My bad. I mistake this function as TransactionRequest constructor. On July 21, 2014, 5:49 p.m., Joel Koshy wrote: core/src/main/scala/kafka/api/TransactionRequest.scala, line 42 https://reviews.apache.org/r/23567/diff/4/?file=635090#file635090line42 Case classes have a copy method. i.e., you can instead do: oldTxRequest.copy(requestInfo = oldTxRequest.requestInfo.copy(txId = newTxId)) Finally, since it seems this is only used in one place in the coordinator and given the brevity of the above copy we can inline it there and not expose this at the object level. Cool. Thanks! On July 21, 2014, 5:49 p.m., Joel Koshy wrote: core/src/main/scala/kafka/api/TransactionRequest.scala, line 1 https://reviews.apache.org/r/23567/diff/4/?file=635090#file635090line1 Can you add these new request/responses to the request-response serialization/deserialization test? Sure! - Dong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/#review48259 --- On July 22, 2014, 11:43 p.m., Dong Lin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 22, 2014, 11:43 p.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description --- KAFKA-1522 Tansactional messaging request/response definitions Diffs - core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala a2117b34c2ee3554602fe068eed0c90b075958c1 Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
Re: Review Request 23567: Patch for KAFKA-1522
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/#review48259 --- core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment84623 Can you add these new request/responses to the request-response serialization/deserialization test? core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment84624 Method names should ideally not start with a capital. copyTransactionToTxId could be a reasonable name. core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment84625 Case classes have a copy method. i.e., you can instead do: oldTxRequest.copy(requestInfo = oldTxRequest.requestInfo.copy(txId = newTxId)) Finally, since it seems this is only used in one place in the coordinator and given the brevity of the above copy we can inline it there and not expose this at the object level. core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment84626 TxControlTypes would be clearer I think (also based on what I have seen so far in KAFKA-1523 rb - I think you intend this to be stored in the message key which it should not.) core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment84627 Typo - change it to transactionRequest core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment84628 Would prefer calling this txGroupId core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment84629 Would prefer calling groupId txGroupId core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment84630 Can we use a more generic type like Seq instead? core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment84632 Why does it need to be ordered? You could just use the groupedBy function. core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment84633 What does this method do? I have further comments on this in rb for KAFKA-1523 which I'm doing in parallel. core/src/main/scala/kafka/api/TransactionResponse.scala https://reviews.apache.org/r/23567/#comment84634 Would it make sense to have a per-partition error-response? E.g., after a prepare-commit/abort: if a transaction spans a lot of partitions and one of those brokers goes down the coordinatorwould only need to retry a commit/abort for that broker. Although the alternative is to just resend all the txcontrol messages to all the brokers. core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala https://reviews.apache.org/r/23567/#comment84635 txGroupId core/src/main/scala/kafka/common/ErrorMapping.scala https://reviews.apache.org/r/23567/#comment84636 TxCoordinatorNotAvailableCode - Joel Koshy On July 18, 2014, 3:12 a.m., Dong Lin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 3:12 a.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description --- KAFKA-1522 Tansactional messaging request/response definitions (version 2) Diffs - core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
Re: Review Request 23567: Patch for KAFKA-1522
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 2:30 a.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description (updated) --- KAFKA-1522 Tansactional messaging request/response definitions (version 2) Diffs (updated) - core/src/main/scala/kafka/admin/TopicCommand.scala 8d5c2e7088fc6e8bf69e775ea7f5893b94580fdf core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b core/src/main/scala/kafka/common/Topic.scala ad759786d1c22f67c47808c0b8f227eb2b1a9aa8 core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a core/src/main/scala/kafka/message/Message.scala d2a7293c7be4022af30884330924791340acc5c1 core/src/main/scala/kafka/server/KafkaApis.scala 0b668f230c8556fdf08654ce522a11847d0bf39b core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba core/src/main/scala/kafka/server/TransactionManager.scala PRE-CREATION core/src/main/scala/kafka/utils/ZkUtils.scala dcdc1ce2b02c996294e19cf480736106aaf29511 Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
Re: Review Request 23567: Patch for KAFKA-1522
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 2:36 a.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description --- KAFKA-1522 Tansactional messaging request/response definitions (version 2) This patch involves changes for transaction manager by mistake. Will re-upload. Diffs - core/src/main/scala/kafka/admin/TopicCommand.scala 8d5c2e7088fc6e8bf69e775ea7f5893b94580fdf core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b core/src/main/scala/kafka/common/Topic.scala ad759786d1c22f67c47808c0b8f227eb2b1a9aa8 core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a core/src/main/scala/kafka/message/Message.scala d2a7293c7be4022af30884330924791340acc5c1 core/src/main/scala/kafka/server/KafkaApis.scala 0b668f230c8556fdf08654ce522a11847d0bf39b core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba core/src/main/scala/kafka/server/TransactionManager.scala PRE-CREATION core/src/main/scala/kafka/utils/ZkUtils.scala dcdc1ce2b02c996294e19cf480736106aaf29511 Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
Re: Review Request 23567: Patch for KAFKA-1522
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 2:36 a.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description (updated) --- KAFKA-1522 Tansactional messaging request/response definitions (version 2) This patch involves changes for transaction manager by mistake. Will re-upload. Diffs - core/src/main/scala/kafka/admin/TopicCommand.scala 8d5c2e7088fc6e8bf69e775ea7f5893b94580fdf core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b core/src/main/scala/kafka/common/Topic.scala ad759786d1c22f67c47808c0b8f227eb2b1a9aa8 core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a core/src/main/scala/kafka/message/Message.scala d2a7293c7be4022af30884330924791340acc5c1 core/src/main/scala/kafka/server/KafkaApis.scala 0b668f230c8556fdf08654ce522a11847d0bf39b core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba core/src/main/scala/kafka/server/TransactionManager.scala PRE-CREATION core/src/main/scala/kafka/utils/ZkUtils.scala dcdc1ce2b02c996294e19cf480736106aaf29511 Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
Re: Review Request 23567: Patch for KAFKA-1522
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 2:36 a.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description --- KAFKA-1522 Tansactional messaging request/response definitions (version 2) This patch involves changes for transaction manager by mistake. Will re-upload. Diffs - core/src/main/scala/kafka/admin/TopicCommand.scala 8d5c2e7088fc6e8bf69e775ea7f5893b94580fdf core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b core/src/main/scala/kafka/common/Topic.scala ad759786d1c22f67c47808c0b8f227eb2b1a9aa8 core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a core/src/main/scala/kafka/message/Message.scala d2a7293c7be4022af30884330924791340acc5c1 core/src/main/scala/kafka/server/KafkaApis.scala 0b668f230c8556fdf08654ce522a11847d0bf39b core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba core/src/main/scala/kafka/server/TransactionManager.scala PRE-CREATION core/src/main/scala/kafka/utils/ZkUtils.scala dcdc1ce2b02c996294e19cf480736106aaf29511 Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
Re: Review Request 23567: Patch for KAFKA-1522
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 2:37 a.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description (updated) --- KAFKA-1522 Tansactional messaging request/response definitions (version 2) This patch involves changes for another ticket. Will re-upload. Diffs - core/src/main/scala/kafka/admin/TopicCommand.scala 8d5c2e7088fc6e8bf69e775ea7f5893b94580fdf core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b core/src/main/scala/kafka/common/Topic.scala ad759786d1c22f67c47808c0b8f227eb2b1a9aa8 core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a core/src/main/scala/kafka/message/Message.scala d2a7293c7be4022af30884330924791340acc5c1 core/src/main/scala/kafka/server/KafkaApis.scala 0b668f230c8556fdf08654ce522a11847d0bf39b core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba core/src/main/scala/kafka/server/TransactionManager.scala PRE-CREATION core/src/main/scala/kafka/utils/ZkUtils.scala dcdc1ce2b02c996294e19cf480736106aaf29511 Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
Re: Review Request 23567: Patch for KAFKA-1522
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 2:38 a.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description (updated) --- KAFKA-1522 Tansactional messaging request/response definitions (version 2) Diffs (updated) - core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
Re: Review Request 23567: Patch for KAFKA-1522
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 18, 2014, 3:12 a.m.) Review request for kafka. Bugs: KAFKA-1522 https://issues.apache.org/jira/browse/KAFKA-1522 Repository: kafka Description --- KAFKA-1522 Tansactional messaging request/response definitions (version 2) Diffs (updated) - core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b Diff: https://reviews.apache.org/r/23567/diff/ Testing --- Thanks, Dong Lin
