Re: Review Request 34070: Patch for KAFKA-2186
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34070/#review83472 --- Ship it! Ship It! - Joel Koshy On May 12, 2015, 1:39 a.m., Jiangjie Qin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34070/ --- (Updated May 12, 2015, 1:39 a.m.) Review request for kafka. Bugs: KAFKA-2186 https://issues.apache.org/jira/browse/KAFKA-2186 Repository: kafka Description --- Patch for KAFKA-2186 follow-up patch of KAFKA-1650, add the missing offset commit with map in java api Diffs - core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java cc3400ff81fc0db69b5129ad7b440f20a211a79d Diff: https://reviews.apache.org/r/34070/diff/ Testing --- Thanks, Jiangjie Qin
Re: Review Request 34070: Patch for KAFKA-2186
On May 12, 2015, 2:31 a.m., Aditya Auradkar wrote: core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java, line 73 https://reviews.apache.org/r/34070/diff/1/?file=955930#file955930line73 How does this work if the consumer doesn't own these partitions? Is it possible to commit offsets for any topic? Just curious.. Yes - it is possible. - Joel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34070/#review83343 --- On May 12, 2015, 1:39 a.m., Jiangjie Qin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34070/ --- (Updated May 12, 2015, 1:39 a.m.) Review request for kafka. Bugs: KAFKA-2186 https://issues.apache.org/jira/browse/KAFKA-2186 Repository: kafka Description --- Patch for KAFKA-2186 follow-up patch of KAFKA-1650, add the missing offset commit with map in java api Diffs - core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java cc3400ff81fc0db69b5129ad7b440f20a211a79d Diff: https://reviews.apache.org/r/34070/diff/ Testing --- Thanks, Jiangjie Qin
Re: Review Request 34070: Patch for KAFKA-2186
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34070/#review83343 --- Ship it! core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java https://reviews.apache.org/r/34070/#comment134315 How does this work if the consumer doesn't own these partitions? Is it possible to commit offsets for any topic? Just curious.. - Aditya Auradkar On May 12, 2015, 1:39 a.m., Jiangjie Qin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34070/ --- (Updated May 12, 2015, 1:39 a.m.) Review request for kafka. Bugs: KAFKA-2186 https://issues.apache.org/jira/browse/KAFKA-2186 Repository: kafka Description --- Patch for KAFKA-2186 follow-up patch of KAFKA-1650, add the missing offset commit with map in java api Diffs - core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java cc3400ff81fc0db69b5129ad7b440f20a211a79d Diff: https://reviews.apache.org/r/34070/diff/ Testing --- Thanks, Jiangjie Qin
