Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 7, 2014, 10:17 a.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description (updated) --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file - updated kafka-run-class.sh to run kafka classes with proper version KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file Diffs (updated) - bin/kafka-run-class.sh 5d5021dff8daeaf8e35923f6df31d7fc3d850e68 build.gradle 9cbedb87e1e2b7d1c41f6a41c9adb4ad9c72930d core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 core/src/main/scala/kafka/utils/Annotations_2.8.scala 28269eb037109f7680b9da732e4baa51c9a594b6 core/src/main/scala/kafka/utils/Annotations_2.9+.scala gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 7, 2014, 10:52 a.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description (updated) --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file - updated kafka-run-class.sh to run kafka classes with proper version KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file - changed default scala version to 2.10.1 KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file - changed default scala version to 2.10.1 Diffs (updated) - bin/kafka-run-class.sh 5d5021dff8daeaf8e35923f6df31d7fc3d850e68 build.gradle 9cbedb87e1e2b7d1c41f6a41c9adb4ad9c72930d core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 core/src/main/scala/kafka/utils/Annotations_2.8.scala 28269eb037109f7680b9da732e4baa51c9a594b6 core/src/main/scala/kafka/utils/Annotations_2.9+.scala gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 23895: Patch for KAFKA-1419
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23895/#review49920
---
Thanks for the patch. I think it's almost ready to go. A couple of minor
comments.
1. Could you change README accordingly?
2. I got a scala 2.11 specific warning during compilation like the following.
Do you think you can address that too?
/Users/jrao/Intellij/kafka_gradle/core/src/test/scala/unit/kafka/common/ConfigTest.scala:32:
Octal escape literals are deprecated, use \u instead.
val badChars = Array('/', '\\', ',', '\0', ':', \, '\'', ';', '*', '?',
' ', '\t', '\r', '\n', '=')
^
/Users/jrao/Intellij/kafka_gradle/core/src/test/scala/unit/kafka/common/ConfigTest.scala:62:
Octal escape literals are deprecated, use \u instead.
val badChars = Array('/', '\\', ',', '\0', ':', \, '\'', ';', '*', '?',
' ', '\t', '\r', '\n', '=')
^
/Users/jrao/Intellij/kafka_gradle/core/src/test/scala/unit/kafka/common/TopicTest.scala:35:
Octal escape literals are deprecated, use \u instead.
val badChars = Array('/', '\\', ',', '\0', ':', \, '\'', ';', '*', '?',
' ', '\t', '\r', '\n', '=')
^
three warnings found
- Jun Rao
On Aug. 7, 2014, 10:52 a.m., Ivan Lyutov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23895/
---
(Updated Aug. 7, 2014, 10:52 a.m.)
Review request for kafka.
Bugs: KAFKA-1419
https://issues.apache.org/jira/browse/KAFKA-1419
Repository: kafka
Description
---
KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor
bug fixes
KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency
version - updated scala version to 2.11.2 - added getBuffer to
ByteBufferMessageSet classes
KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency
version - updated scala version to 2.11.2 - added getBuffer to
ByteBufferMessageSet classes - removed annotations 2.8 file
KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency
version - updated scala version to 2.11.2 - added getBuffer to
ByteBufferMessageSet classes - removed annotations 2.8 file - updated
kafka-run-class.sh to run kafka classes with proper version
KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency
version - updated scala version to 2.11.2 - added getBuffer to
ByteBufferMessageSet classes - removed annotations 2.8 file
KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency
version - updated scala version to 2.11.2 - added getBuffer to
ByteBufferMessageSet classes - removed annotations 2.8 file - changed default
scala version to 2.10.1
KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency
version - updated scala version to 2.11.2 - added getBuffer to
ByteBufferMessageSet classes - removed annotations 2.8 file - changed default
scala version to 2.10.1
Diffs
-
bin/kafka-run-class.sh 5d5021dff8daeaf8e35923f6df31d7fc3d850e68
build.gradle 9cbedb87e1e2b7d1c41f6a41c9adb4ad9c72930d
core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala
fecee8d5f7b32f483bb1bfc6a5080d589906f9c4
core/src/main/scala/kafka/message/ByteBufferMessageSet.scala
73401c5ff34d08abce22267aa9c4d86632c6fb74
core/src/main/scala/kafka/utils/Annotations_2.8.scala
28269eb037109f7680b9da732e4baa51c9a594b6
core/src/main/scala/kafka/utils/Annotations_2.9+.scala
gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b
gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95
gradle/wrapper/gradle-wrapper.properties
610282a699afc89a82203ef0e4e71ecc53761039
scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820
Diff: https://reviews.apache.org/r/23895/diff/
Testing
---
Thanks,
Ivan Lyutov
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 5, 2014, 12:52 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description (updated) --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file - updated kafka-run-class.sh to run kafka classes with proper version Diffs (updated) - bin/kafka-run-class.sh 5d5021dff8daeaf8e35923f6df31d7fc3d850e68 build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 core/src/main/scala/kafka/utils/Annotations_2.8.scala 28269eb037109f7680b9da732e4baa51c9a594b6 core/src/main/scala/kafka/utils/Annotations_2.9+.scala gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review49601 --- build.gradle https://reviews.apache.org/r/23895/#comment86832 Do we need the : in front of clients? - Jun Rao On Aug. 5, 2014, 12:52 p.m., Ivan Lyutov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 5, 2014, 12:52 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file - updated kafka-run-class.sh to run kafka classes with proper version Diffs - bin/kafka-run-class.sh 5d5021dff8daeaf8e35923f6df31d7fc3d850e68 build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 core/src/main/scala/kafka/utils/Annotations_2.8.scala 28269eb037109f7680b9da732e4baa51c9a594b6 core/src/main/scala/kafka/utils/Annotations_2.9+.scala gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 23895: Patch for KAFKA-1419
On Aug. 5, 2014, 2:24 p.m., Joe Stein wrote: gradle.properties, line 18 https://reviews.apache.org/r/23895/diff/5/?file=652031#file652031line18 I think this should be 2.9.2 but confirming with Jun that is what we are going to be recommending when 0.8.2 releases. Joe, I agree with you that 2.11.2 seems relatively new. So perhaps we shouldn't default to it now. On the other hand, 2.9.2 is pretty old. How about we default to 2.10.1? We also need to change kafka-run-class.sh accordingly. - Jun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review49600 --- On Aug. 5, 2014, 12:52 p.m., Ivan Lyutov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 5, 2014, 12:52 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file - updated kafka-run-class.sh to run kafka classes with proper version Diffs - bin/kafka-run-class.sh 5d5021dff8daeaf8e35923f6df31d7fc3d850e68 build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 core/src/main/scala/kafka/utils/Annotations_2.8.scala 28269eb037109f7680b9da732e4baa51c9a594b6 core/src/main/scala/kafka/utils/Annotations_2.9+.scala gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review49454 --- build.gradle https://reviews.apache.org/r/23895/#comment86528 Can we remove Annotations_2.8.scala and rename Annotations_2.9+.scala to just Annotations.scala? We can then potentially remove sourceSets setting completely. - Jun Rao On July 29, 2014, 3:13 p.m., Ivan Lyutov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated July 29, 2014, 3:13 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes Diffs - build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 4, 2014, 2:43 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description (updated) --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file Diffs (updated) - build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 core/src/main/scala/kafka/utils/Annotations_2.8.scala 28269eb037109f7680b9da732e4baa51c9a594b6 core/src/main/scala/kafka/utils/Annotations_2.9+.scala gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review49559 --- Look good overall. We need to change the default scala version in bin/kafka-run-class.sh. Otherwise, the quickstart script will fail. build.gradle https://reviews.apache.org/r/23895/#comment86703 Since you are touching this part, could you also add clients:uploadArchives to uploadArchivesAll? - Jun Rao On Aug. 4, 2014, 2:43 p.m., Ivan Lyutov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 4, 2014, 2:43 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes - removed annotations 2.8 file Diffs - build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 core/src/main/scala/kafka/utils/Annotations_2.8.scala 28269eb037109f7680b9da732e4baa51c9a594b6 core/src/main/scala/kafka/utils/Annotations_2.9+.scala gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated July 29, 2014, 3:13 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description (updated) --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes KAFKA-1419 - cross build for scala 2.11 - changed 2.11 specific dependency version - updated scala version to 2.11.2 - added getBuffer to ByteBufferMessageSet classes Diffs (updated) - build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated July 28, 2014, 3:07 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description (updated) --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes Diffs (updated) - build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review48877 --- Good stuff, I was able to get all binaries to build and pass tests with this patch. I think a fix to maintain compatibility with the BeanProperty change is important, but the other two aren't so much. build.gradle https://reviews.apache.org/r/23895/#comment85642 I think the file can be removed so that the exclusion isn't needed. core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala https://reviews.apache.org/r/23895/#comment85644 you need to add `def getBuffer = buffer` here and below in order to maintain backwards compatibility (those are added by the @BeanProperty annotation). You could also do something similar to `kafka.utils.Annotations_2.9+.scala` and the groovy excludes to keep the BeanProperty annotation working. gradle.properties https://reviews.apache.org/r/23895/#comment85643 I hesitate to nit, but scala 2.11.2 was released 6 days ago. Might be worth switching if it doesn't cause any issues? - Joe Crobak On July 28, 2014, 3:07 p.m., Ivan Lyutov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated July 28, 2014, 3:07 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes Diffs - build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
Re: Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review48957 --- build.gradle https://reviews.apache.org/r/23895/#comment85795 I think these two dependencies need to be updated. As I was trying out this code, I got some strange compile errors [1] in a downstream project. This seems to work better: + compile 'org.scala-lang.modules:scala-xml_2.11:1.0.2' + compile 'org.scala-lang.modules:scala-parser-combinators_2.11:1.0.2' That error also makes me wonder if those compile dependencies are actually needed, too. [1] java.lang.RuntimeException: Conflicting cross-version suffixes in: org.scala-lang.modules:scala-xml, org.scala-lang.modules:scala-parser-combinators - Joe Crobak On July 28, 2014, 3:07 p.m., Ivan Lyutov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated July 28, 2014, 3:07 p.m.) Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description --- KAFKA-1419 - cross build for scala 2.11 - dropped scala 2.8 support - minor bug fixes Diffs - build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 scala.gradle ebd21b870c0746aade63248344ab65d9b5baf820 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
Review Request 23895: Patch for KAFKA-1419
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- Review request for kafka. Bugs: KAFKA-1419 https://issues.apache.org/jira/browse/KAFKA-1419 Repository: kafka Description --- KAFKA-1419 - cross build for scala 2.11 Diffs - build.gradle a72905df824ba68bed5d5170d18873c23e1782c9 core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 core/src/main/scala/kafka/message/ByteBufferMessageSet.scala 73401c5ff34d08abce22267aa9c4d86632c6fb74 gradle.properties 4827769a3f8e34f0fe7e783eb58e44d4db04859b gradle/buildscript.gradle 225e0a82708bc5f390e5e2c1d4d9a0d06f491b95 gradle/wrapper/gradle-wrapper.properties 610282a699afc89a82203ef0e4e71ecc53761039 Diff: https://reviews.apache.org/r/23895/diff/ Testing --- Thanks, Ivan Lyutov
