[GitHub] [kibble] turbaszek opened a new pull request #1: Initial project setup

[GitBox]

turbaszek opened a new pull request #1:
URL: https://github.com/apache/kibble/pull/1


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek closed pull request #1: Initial project setup

[GitBox]

turbaszek closed pull request #1:
URL: https://github.com/apache/kibble/pull/1


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek opened a new pull request #2: Initial configuration

[GitBox]

turbaszek opened a new pull request #2:
URL: https://github.com/apache/kibble/pull/2


   This PR adds the following:
   - README and CONTRIBUTING docs
   - `kibble` python package (with setup.py and file structure) with simple CLI
   - `Dockerfile` to build a docker image
   - CI system and pre-commits to assure quality from day 1
   - Some simple tests as example



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on a change in pull request #2: Initial configuration

[GitBox]

turbaszek commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r584647512



##
File path: NOTICE
##
@@ -0,0 +1,8 @@
+Apache Kibble
+Copyright 2017, the Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+The licenses and noticesd listed below are for intellectual property
+used in Apache Kibble, not covered by the Apache License.

Review comment:
   Cleared this list





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on a change in pull request #2: Initial configuration

[GitBox]

turbaszek commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r584647798



##
File path: README.md
##
@@ -0,0 +1,77 @@
+
+
+
+
+# Apache Kibble
+
+![CI](https://github.com/apache/kibble/workflows/CI/badge.svg)
+[![License](http://img.shields.io/:license-Apache%202-blue.svg)](http://www.apache.org/licenses/LICENSE-2.0.txt)
+
+Apache Kibble is a tool to collect, aggregate and visualize data about any 
software project that uses commonly known
+tools.
+
+
+
+**Table of contents**
+
+- [Documentation](#documentation)
+- [Live demo](#live-demo)
+- [Installation](#installation)
+- [Contributing](#contributing)
+
+
+
+## Documentation
+
+For information about the Kibble project and community, visit our
+website at [https://kibble.apache.org/](https://kibble.apache.org/).
+
+
+```
+  Usage: kibble [OPTIONS] COMMAND [ARGS]...
+
+Manage and configure Apache Kibble instance.
+
+  Options:
+--help  Show this message and exit.
+
+  Commands:
+configAccess configuration
+dbManage database
+scanners  Configure and trigger scanners
+serverAPI server commands
+version   Show Kibble version
+```
+

Review comment:
   This is autogenerated to avoid necessity to update it manually





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on a change in pull request #2: Initial configuration

[GitBox]

turbaszek commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r584648480



##
File path: kibble/cli/commands/config_command.py
##
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+__all__ = ["config_group"]
+
+import click
+
+
+@click.group(name="config")
+def config_group():
+"""Access configuration"""
+
+
+@config_group.command()
+def show():
+"""Shows configuration"""
+click.echo("To be implemented!")

Review comment:
   Those are here just to show what we may want to do and how it can be 
structure. I can remove this but I think this may help newcomers to understand 
how the project is structured





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on a change in pull request #2: Initial configuration

[GitBox]

turbaszek commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r584648710



##
File path: kibble/cli/parser.py
##
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import click
+
+from kibble.cli.commands.config_command import config_group
+from kibble.cli.commands.db_command import db_group
+from kibble.cli.commands.scanners_command import scanners_group
+from kibble.cli.commands.server_command import server_group
+from kibble.cli.commands.version_command import version_cmd
+
+
+@click.group()
+def cli():
+"""Manage and configure Apache Kibble instance."""
+
+
+# Try to keep this list sorted A-Z

Review comment:
   This is validated by tests





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on a change in pull request #2: Initial configuration

[GitBox]

turbaszek commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r584649374



##
File path: tests/cli/commands/test_config_command.py
##
@@ -0,0 +1,29 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from click.testing import CliRunner
+
+from kibble.cli.commands.config_command import config_group
+
+
+class TestConfigCommand:
+def test_show(self):
+runner = CliRunner()
+result = runner.invoke(config_group, ["show"])
+
+assert result.exit_code == 0
+assert result.output.strip() == "To be implemented!"

Review comment:
   Similary to the command - those are here mostly as reference where and 
how to write tests





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on a change in pull request #2: Initial configuration

[GitBox]

turbaszek commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r584650593



##
File path: .github/labeler.yml
##
@@ -0,0 +1,24 @@
+---
+area:api:
+  - 'kibble/api/*'

Review comment:
   ```suggestion
 - 'kibble/server/*'
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] kaxil commented on a change in pull request #2: Initial configuration

[GitBox]

kaxil commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r584688476



##
File path: setup.cfg
##
@@ -0,0 +1,52 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[metadata]
+name = Kibble
+summary = Apache Kibble is a tool to collect, aggregate and visualize data 
about any software project that uses commonly known tools.
+description-file = README.md
+author = Apache Kibble
+author-email = dev@kibble.apache.org
+license = Apache License, Version 2.0
+license_files =
+   LICENSE
+   NOTICE
+
+[bdist_wheel]
+python-tag=py3
+
+
+[files]
+packages = kibble
+
+[easy_install]
+
+[mypy]
+ignore_missing_imports = True
+no_implicit_optional = True
+warn_redundant_casts = True
+warn_unused_ignores = False
+pretty = True
+
+[isort]
+line_length=110
+combine_as_imports = true
+default_section = THIRDPARTY
+known_first_party=airflow,tests

Review comment:
   ```suggestion
   known_first_party=tests
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] kaxil commented on a change in pull request #2: Initial configuration

[GitBox]

kaxil commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r584688676



##
File path: setup.py
##
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import os
+
+from setuptools import find_packages, setup
+
+VERSION = "2.0.0dev"
+
+BASE_PATH = os.path.dirname(os.path.realpath(__file__))
+
+DEVEL_REQUIREMENTS = [
+"black==20.8b1",
+"pre-commit==2.7.1",
+"pylint==2.6.2",
+"pytest==6.1.1",
+]
+
+INSTALL_REQUIREMENTS = ["requests>=2.25.1"]
+
+EXTRAS_REQUIREMENTS = {"devel": DEVEL_REQUIREMENTS}
+
+
+def get_long_description() -> str:
+"""Retrieves package description from README.md"""
+try:
+with open(os.path.join(BASE_PATH, "README.md")) as file:
+description = file.read()
+except FileNotFoundError:
+description = ""
+return description
+
+
+def do_setup() -> None:
+"""Perform the Kibble package setup."""
+setup(
+name="apache-kibble",
+description="Apache Kibble is a tool to collect, aggregate "
+"and visualize data about any software project.",

Review comment:
   ```suggestion
   description="Apache Kibble is a tool to collect, aggregate and 
visualize data about any software project.",
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] kaxil commented on a change in pull request #2: Initial configuration

[GitBox]

kaxil commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r584699601



##
File path: .github/labeler.yml
##
@@ -0,0 +1,24 @@
+---
+area:api:
+  - 'kibble/server/*'
+
+area:cli:
+  - 'kibble/cli/*'
+
+area:scanners:
+  - 'kibble/scanners/*'
+
+area:ui:
+  - 'ui/*'
+
+area:docs:
+  - 'docs/*'
+  - '*.md'
+
+area:dev:
+  - '.github/*'
+  - '.pre-commit.config.yaml'
+  - 'asf.yaml'

Review comment:
   ```suggestion
 - '.asf.yaml'
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] michalslowikowski00 commented on a change in pull request #2: Initial configuration

[GitBox]

michalslowikowski00 commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r585909220



##
File path: kibble/cli/commands/db_command.py
##
@@ -0,0 +1,49 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+__all__ = ["db_group"]
+
+import click
+
+
+@click.group(name="db")
+def db_group():
+"""Manage database"""
+
+
+@db_group.command()
+def init():

Review comment:
   Wdyt to use more explicit func names, like `db_init()` for example.

##
File path: kibble/cli/commands/db_command.py
##
@@ -0,0 +1,49 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+__all__ = ["db_group"]
+
+import click
+
+
+@click.group(name="db")
+def db_group():
+"""Manage database"""
+
+
+@db_group.command()
+def init():
+"""Initialize database"""
+click.echo("To be implemented!")
+
+
+def _abort_reset(ctx, _, value):
+if not value:
+ctx.abort()
+
+
+@db_group.command()
+@click.option(
+"--yes",
+is_flag=True,
+callback=_abort_reset,
+expose_value=False,
+prompt="This will reset database. Do you want to continue?",
+)
+def reset():

Review comment:
   And here, `db_reset()`.

##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,135 @@
+
+
+# Contributing to Apache Kibble
+
+
+
+**Table of contents**
+
+- [Community](#community)
+- [Development installation](#development-installation)
+- [Testing](#testing)
+- [Code Quality](#code-quality)
+
+
+
+
+## Community
+
+The main development and design discussion happens on our mailing lists.
+We have a list specifically for development, and one for future user questions 
and feedback.
+
+To join in the discussion on the design and roadmap, you can send email to 
[dev@kibble.apache.org](mailto:dev@kibble.apache.org).
+You can subscribe to the list by sending an email to 
[dev-subscr...@kibble.apache.org](mailto:dev-subscr...@kibble.apache.org).
+You can also browse the archives online at 
[lists.apache.org](https://lists.apache.org/list.html?dev@kibble.apache.org).
+
+We also have:
+
+- IRC channel, #kibble on 
[Freenode](https://webchat.freenode.net/?channels=#kibble)
+- Slack channel, #kibble on [ASF slack](https://s.apache.org/slack-invite)
+
+## Development installation
+
+You should be able to install Apache Kibble by simply doing:
+
+```
+pip install -e ."[devel]"
+```
+
+This will install the Kibble package in editable mode together wit all 
requirements needed for fluent
+development.
+
+You may also use the development Docker file:
+
+```
+docker build -f Dockerfile.dev -t apache/kibble-dev .
+docker run apache/kibble-dev kibble
+docker run apache/kibble-dev pytest
+```
+
+## Testing
+
+Apache Kibble project uses [pytest](https://docs.pytest.org/en/stable/) for 
running testing. Writing
+good test helps us avoid regression and unexpected issues.
+
+In order to run tests you all you need to do is to call pytest:
+
+```
+# Run all tests
+pytest
+
+# Run single test file
+pytest tests/cli/commands/test_config_command.py
+```
+
+The test can be also run using the dev docker image:
+
+```
+➜ docker run apache/kibble pytest tests/cli/commands/test_config_command.py
+= test session starts 
==
+platform linux -- Python 3.8.8, pytest-6.1.1, py-1.10.0, pluggy-0.13.1 -- 
/usr/local/bin/python
+cachedir: .pytest_cache
+rootdir: /kibble, configfile: pyproject.toml
+collecting ... collected 1 item
+
+tests/cli/commands/tes

[GitHub] [kibble] turbaszek commented on a change in pull request #2: Initial configuration

[GitBox]

turbaszek commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r585957986



##
File path: .pre-commit-config.yaml
##
@@ -0,0 +1,169 @@
+#!/usr/bin/env python3
+# -*- coding: utf-8 -*-
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+---
+default_stages: [commit, push]
+default_language_version:
+  # force all unspecified python hooks to run python3
+  python: python3
+minimum_pre_commit_version: "1.20.0"
+
+repos:
+  - repo: meta
+hooks:
+  - id: identity
+  - id: check-hooks-apply
+
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+rev: v3.4.0
+hooks:
+  - id: check-merge-conflict
+  - id: debug-statements
+  - id: check-builtin-literals
+  - id: detect-private-key
+  - id: end-of-file-fixer
+  - id: mixed-line-ending
+  - id: check-executables-have-shebangs
+  - id: trailing-whitespace
+  - id: fix-encoding-pragma
+args:
+  - --remove
+
+  - repo: https://github.com/thlorenz/doctoc.git
+rev: v2.0.0
+hooks:
+  - id: doctoc
+name: Add TOC for md files
+files: ^README\.md$|^CONTRIBUTING\.md$
+args:
+  - "--maxlevel"
+  - "2"
+
+  # Licenses
+  - repo: https://github.com/Lucas-C/pre-commit-hooks
+rev: v1.1.9
+hooks:
+  - id: insert-license
+name: Add license for all other files
+exclude: ^\.github/.*$
+args:
+  - --comment-style
+  - "|#|"
+  - --license-filepath
+  - license-templates/LICENSE.txt
+  - --fuzzy-match-generates-todo
+files: >
+  \.cfg$|^Dockerfile.*$|\.sh$|\.bash$|\.py$|\.yml$|\.yaml$
+  - id: insert-license
+name: Add license for all rst files
+exclude: ^\.github/.*$
+args:
+  - --comment-style
+  - "||"
+  - --license-filepath
+  - license-templates/LICENSE.rst
+  - --fuzzy-match-generates-todo
+files: \.rst$
+  - id: insert-license
+name: Add license for all md and html files
+files: \.md$|\.html$
+exclude: ^\.github/.*$
+args:
+  - --comment-style
+  - ""
+  - --license-filepath
+  - license-templates/LICENSE.txt
+  - --fuzzy-match-generates-todo
+
+  - repo: https://github.com/psf/black
+rev: 20.8b1
+hooks:
+  - id: black
+args: [--config=./pyproject.toml]
+
+  - repo: https://github.com/timothycrosley/isort
+rev: 5.6.4
+hooks:
+  - id: isort
+name: Run isort to sort imports
+files: \.py$
+# To keep consistent with the global isort skip config defined in 
setup.cfg
+exclude: ^build/.*$|^.tox/.*$|^venv/.*$
+
+  - repo: https://github.com/pycqa/pydocstyle
+rev: 5.1.1
+hooks:
+  - id: pydocstyle
+name: Run pydocstyle
+args:
+  - --convention=pep257
+  - --add-ignore=D100,D102,D104,D105,D107,D205,D400,D401
+exclude: |
+  (?x)
+  ^tests/.*\.py$|
+  ^scripts/.*\.py$
+
+  - repo: https://github.com/adrienverge/yamllint
+rev: v1.25.0
+hooks:
+  - id: yamllint
+name: Check yaml files with yamllint
+entry: yamllint -c yamllint-config.yml --strict
+types: [yaml]
+
+  - repo: https://github.com/pre-commit/mirrors-mypy
+rev: "v0.812"
+hooks:
+  - id: mypy
+
+  - repo: local
+hooks:
+  - id: pylint
+name: Pylint on all sources
+entry: pylint
+language: system
+types: [python]
+
+  - id: consistent-pylint
+language: pygrep
+name: Check for inconsistent pylint disable/enable without space
+entry: "pylint:disable|pylint:enable"
+pass_filenames: true
+files: \.py$
+
+  - id: update-help-in-readme
+name: Update help in README.md
+entry: "./scripts/pre_commit_generate_cli_help.sh"
+language: system
+files: \.py$
+
+  - id: markdownlint
+name: Run markdownlint
+description: "Checks the style of Markdown files."
+entry: markdownlint
+language: node
+types: [markdown]
+files: \.(md|mdown|mar

[GitHub] [kibble] turbaszek commented on a change in pull request #2: Initial configuration

[GitBox]

turbaszek commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r585959512



##
File path: LICENSE
##
@@ -0,0 +1,201 @@
+ Apache License
+   Version 2.0, January 2004
+http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+  "License" shall mean the terms and conditions for use, reproduction,
+  and distribution as defined by Sections 1 through 9 of this document.
+
+  "Licensor" shall mean the copyright owner or entity authorized by
+  the copyright owner that is granting the License.
+
+  "Legal Entity" shall mean the union of the acting entity and all
+  other entities that control, are controlled by, or are under common
+  control with that entity. For the purposes of this definition,
+  "control" means (i) the power, direct or indirect, to cause the
+  direction or management of such entity, whether by contract or
+  otherwise, or (ii) ownership of fifty percent (50%) or more of the
+  outstanding shares, or (iii) beneficial ownership of such entity.
+
+  "You" (or "Your") shall mean an individual or Legal Entity
+  exercising permissions granted by this License.
+
+  "Source" form shall mean the preferred form for making modifications,
+  including but not limited to software source code, documentation
+  source, and configuration files.
+
+  "Object" form shall mean any form resulting from mechanical
+  transformation or translation of a Source form, including but
+  not limited to compiled object code, generated documentation,
+  and conversions to other media types.
+
+  "Work" shall mean the work of authorship, whether in Source or
+  Object form, made available under the License, as indicated by a
+  copyright notice that is included in or attached to the work
+  (an example is provided in the Appendix below).
+
+  "Derivative Works" shall mean any work, whether in Source or Object
+  form, that is based on (or derived from) the Work and for which the
+  editorial revisions, annotations, elaborations, or other modifications
+  represent, as a whole, an original work of authorship. For the purposes
+  of this License, Derivative Works shall not include works that remain
+  separable from, or merely link (or bind by name) to the interfaces of,
+  the Work and Derivative Works thereof.
+
+  "Contribution" shall mean any work of authorship, including
+  the original version of the Work and any modifications or additions
+  to that Work or Derivative Works thereof, that is intentionally
+  submitted to Licensor for inclusion in the Work by the copyright owner
+  or by an individual or Legal Entity authorized to submit on behalf of
+  the copyright owner. For the purposes of this definition, "submitted"
+  means any form of electronic, verbal, or written communication sent
+  to the Licensor or its representatives, including but not limited to
+  communication on electronic mailing lists, source code control systems,
+  and issue tracking systems that are managed by, or on behalf of, the
+  Licensor for the purpose of discussing and improving the Work, but
+  excluding communication that is conspicuously marked or otherwise
+  designated in writing by the copyright owner as "Not a Contribution."
+
+  "Contributor" shall mean Licensor and any individual or Legal Entity
+  on behalf of whom a Contribution has been received by Licensor and
+  subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+  copyright license to reproduce, prepare Derivative Works of,
+  publicly display, publicly perform, sublicense, and distribute the
+  Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+  (except as stated in this section) patent license to make, have made,
+  use, offer to sell, sell, import, and otherwise transfer the Work,
+  where such license applies only to those patent claims licensable
+  by such Contributor that are necessarily infringed by their
+  Contribution(s) alone or by combination of their Contribution(s)
+  with the Work to which such Contribution(s) was submitted. If You
+  institute patent litigation against any entity (including a
+  cross-claim or counterclaim in a lawsuit) alleging that the Work
+  or a Contribution incorporated

[GitHub] [kibble] turbaszek commented on a change in pull request #2: Initial configuration

[GitBox]

turbaszek commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r585959918



##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,135 @@
+
+
+# Contributing to Apache Kibble
+
+
+
+**Table of contents**
+
+- [Community](#community)
+- [Development installation](#development-installation)
+- [Testing](#testing)
+- [Code Quality](#code-quality)
+
+
+
+
+## Community
+
+The main development and design discussion happens on our mailing lists.
+We have a list specifically for development, and one for future user questions 
and feedback.
+
+To join in the discussion on the design and roadmap, you can send email to 
[dev@kibble.apache.org](mailto:dev@kibble.apache.org).
+You can subscribe to the list by sending an email to 
[dev-subscr...@kibble.apache.org](mailto:dev-subscr...@kibble.apache.org).
+You can also browse the archives online at 
[lists.apache.org](https://lists.apache.org/list.html?dev@kibble.apache.org).
+
+We also have:
+
+- IRC channel, #kibble on 
[Freenode](https://webchat.freenode.net/?channels=#kibble)
+- Slack channel, #kibble on [ASF slack](https://s.apache.org/slack-invite)
+
+## Development installation
+
+You should be able to install Apache Kibble by simply doing:
+
+```
+pip install -e ."[devel]"
+```
+
+This will install the Kibble package in editable mode together wit all 
requirements needed for fluent
+development.
+
+You may also use the development Docker file:
+
+```
+docker build -f Dockerfile.dev -t apache/kibble-dev .
+docker run apache/kibble-dev kibble
+docker run apache/kibble-dev pytest
+```
+
+## Testing
+
+Apache Kibble project uses [pytest](https://docs.pytest.org/en/stable/) for 
running testing. Writing
+good test helps us avoid regression and unexpected issues.
+
+In order to run tests you all you need to do is to call pytest:
+
+```
+# Run all tests
+pytest
+
+# Run single test file
+pytest tests/cli/commands/test_config_command.py
+```
+
+The test can be also run using the dev docker image:
+
+```
+➜ docker run apache/kibble pytest tests/cli/commands/test_config_command.py
+= test session starts 
==
+platform linux -- Python 3.8.8, pytest-6.1.1, py-1.10.0, pluggy-0.13.1 -- 
/usr/local/bin/python
+cachedir: .pytest_cache
+rootdir: /kibble, configfile: pyproject.toml
+collecting ... collected 1 item
+
+tests/cli/commands/test_config_command.py::TestConfigCommand::test_show PASSED 
[100%]
+
+== 1 passed in 0.02s 
===
+```
+
+## Code Quality
+
+Apache Kibble project is using different tools to ensure the quality of the 
code, including:
+
+- [black](https://github.com/psf/black)

Review comment:
   We can, but I wanted to mention only the critical tool no all to avoid 
growing and unreadable list

##
File path: CONTRIBUTING.md
##
@@ -0,0 +1,135 @@
+
+
+# Contributing to Apache Kibble
+
+
+
+**Table of contents**
+
+- [Community](#community)
+- [Development installation](#development-installation)
+- [Testing](#testing)
+- [Code Quality](#code-quality)
+
+
+
+
+## Community
+
+The main development and design discussion happens on our mailing lists.
+We have a list specifically for development, and one for future user questions 
and feedback.
+
+To join in the discussion on the design and roadmap, you can send email to 
[dev@kibble.apache.org](mailto:dev@kibble.apache.org).
+You can subscribe to the list by sending an email to 
[dev-subscr...@kibble.apache.org](mailto:dev-subscr...@kibble.apache.org).
+You can also browse the archives online at 
[lists.apache.org](https://lists.apache.org/list.html?dev@kibble.apache.org).
+
+We also have:
+
+- IRC channel, #kibble on 
[Freenode](https://webchat.freenode.net/?channels=#kibble)
+- Slack channel, #kibble on [ASF slack](https://s.apache.org/slack-invite)
+
+## Development installation
+
+You should be able to install Apache Kibble by simply doing:
+
+```
+pip install -e ."[devel]"
+```
+
+This will install the Kibble package in editable mode together wit all 
requirements needed for fluent
+development.
+
+You may also use the development Docker file:
+
+```
+docker build -f Dockerfile.dev -t apache/kibble-dev .
+docker run apache/kibble-dev kibble
+docker run apache/kibble-dev pytest
+```
+
+## Testing
+
+Apache Kibble project uses [pytest](https://docs.pytest.org/en/stable/) for 
running testing. Writing
+good test helps us avoid regression and unexpected issues.
+
+In order to run tests you all you need to do is to call pytest:
+
+```
+# Run all tests
+pytest
+
+# Run single test file
+pytest tests/cli/commands/test_config_command.py
+```
+
+The test can be also run using the dev docker image:
+
+```
+➜ docker run apache/kibble pytest tests/cli/commands/test_config_command.py
+= test session starts 
==
+platform linux -- Python 3.8.8, pytest-6.1.1, py-1.10.0, pluggy-0.13.1 -- 
/usr/lo

[GitHub] [kibble] kaxil commented on a change in pull request #2: Initial configuration

[GitBox]

kaxil commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r585963394



##
File path: LICENSE
##
@@ -0,0 +1,201 @@
+ Apache License
+   Version 2.0, January 2004
+http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+  "License" shall mean the terms and conditions for use, reproduction,
+  and distribution as defined by Sections 1 through 9 of this document.
+
+  "Licensor" shall mean the copyright owner or entity authorized by
+  the copyright owner that is granting the License.
+
+  "Legal Entity" shall mean the union of the acting entity and all
+  other entities that control, are controlled by, or are under common
+  control with that entity. For the purposes of this definition,
+  "control" means (i) the power, direct or indirect, to cause the
+  direction or management of such entity, whether by contract or
+  otherwise, or (ii) ownership of fifty percent (50%) or more of the
+  outstanding shares, or (iii) beneficial ownership of such entity.
+
+  "You" (or "Your") shall mean an individual or Legal Entity
+  exercising permissions granted by this License.
+
+  "Source" form shall mean the preferred form for making modifications,
+  including but not limited to software source code, documentation
+  source, and configuration files.
+
+  "Object" form shall mean any form resulting from mechanical
+  transformation or translation of a Source form, including but
+  not limited to compiled object code, generated documentation,
+  and conversions to other media types.
+
+  "Work" shall mean the work of authorship, whether in Source or
+  Object form, made available under the License, as indicated by a
+  copyright notice that is included in or attached to the work
+  (an example is provided in the Appendix below).
+
+  "Derivative Works" shall mean any work, whether in Source or Object
+  form, that is based on (or derived from) the Work and for which the
+  editorial revisions, annotations, elaborations, or other modifications
+  represent, as a whole, an original work of authorship. For the purposes
+  of this License, Derivative Works shall not include works that remain
+  separable from, or merely link (or bind by name) to the interfaces of,
+  the Work and Derivative Works thereof.
+
+  "Contribution" shall mean any work of authorship, including
+  the original version of the Work and any modifications or additions
+  to that Work or Derivative Works thereof, that is intentionally
+  submitted to Licensor for inclusion in the Work by the copyright owner
+  or by an individual or Legal Entity authorized to submit on behalf of
+  the copyright owner. For the purposes of this definition, "submitted"
+  means any form of electronic, verbal, or written communication sent
+  to the Licensor or its representatives, including but not limited to
+  communication on electronic mailing lists, source code control systems,
+  and issue tracking systems that are managed by, or on behalf of, the
+  Licensor for the purpose of discussing and improving the Work, but
+  excluding communication that is conspicuously marked or otherwise
+  designated in writing by the copyright owner as "Not a Contribution."
+
+  "Contributor" shall mean Licensor and any individual or Legal Entity
+  on behalf of whom a Contribution has been received by Licensor and
+  subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+  copyright license to reproduce, prepare Derivative Works of,
+  publicly display, publicly perform, sublicense, and distribute the
+  Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+  (except as stated in this section) patent license to make, have made,
+  use, offer to sell, sell, import, and otherwise transfer the Work,
+  where such license applies only to those patent claims licensable
+  by such Contributor that are necessarily infringed by their
+  Contribution(s) alone or by combination of their Contribution(s)
+  with the Work to which such Contribution(s) was submitted. If You
+  institute patent litigation against any entity (including a
+  cross-claim or counterclaim in a lawsuit) alleging that the Work
+  or a Contribution incorporated wit

[GitHub] [kibble] turbaszek commented on a change in pull request #2: Initial configuration

[GitBox]

turbaszek commented on a change in pull request #2:
URL: https://github.com/apache/kibble/pull/2#discussion_r585967616



##
File path: LICENSE
##
@@ -0,0 +1,201 @@
+ Apache License
+   Version 2.0, January 2004
+http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+  "License" shall mean the terms and conditions for use, reproduction,
+  and distribution as defined by Sections 1 through 9 of this document.
+
+  "Licensor" shall mean the copyright owner or entity authorized by
+  the copyright owner that is granting the License.
+
+  "Legal Entity" shall mean the union of the acting entity and all
+  other entities that control, are controlled by, or are under common
+  control with that entity. For the purposes of this definition,
+  "control" means (i) the power, direct or indirect, to cause the
+  direction or management of such entity, whether by contract or
+  otherwise, or (ii) ownership of fifty percent (50%) or more of the
+  outstanding shares, or (iii) beneficial ownership of such entity.
+
+  "You" (or "Your") shall mean an individual or Legal Entity
+  exercising permissions granted by this License.
+
+  "Source" form shall mean the preferred form for making modifications,
+  including but not limited to software source code, documentation
+  source, and configuration files.
+
+  "Object" form shall mean any form resulting from mechanical
+  transformation or translation of a Source form, including but
+  not limited to compiled object code, generated documentation,
+  and conversions to other media types.
+
+  "Work" shall mean the work of authorship, whether in Source or
+  Object form, made available under the License, as indicated by a
+  copyright notice that is included in or attached to the work
+  (an example is provided in the Appendix below).
+
+  "Derivative Works" shall mean any work, whether in Source or Object
+  form, that is based on (or derived from) the Work and for which the
+  editorial revisions, annotations, elaborations, or other modifications
+  represent, as a whole, an original work of authorship. For the purposes
+  of this License, Derivative Works shall not include works that remain
+  separable from, or merely link (or bind by name) to the interfaces of,
+  the Work and Derivative Works thereof.
+
+  "Contribution" shall mean any work of authorship, including
+  the original version of the Work and any modifications or additions
+  to that Work or Derivative Works thereof, that is intentionally
+  submitted to Licensor for inclusion in the Work by the copyright owner
+  or by an individual or Legal Entity authorized to submit on behalf of
+  the copyright owner. For the purposes of this definition, "submitted"
+  means any form of electronic, verbal, or written communication sent
+  to the Licensor or its representatives, including but not limited to
+  communication on electronic mailing lists, source code control systems,
+  and issue tracking systems that are managed by, or on behalf of, the
+  Licensor for the purpose of discussing and improving the Work, but
+  excluding communication that is conspicuously marked or otherwise
+  designated in writing by the copyright owner as "Not a Contribution."
+
+  "Contributor" shall mean Licensor and any individual or Legal Entity
+  on behalf of whom a Contribution has been received by Licensor and
+  subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+  copyright license to reproduce, prepare Derivative Works of,
+  publicly display, publicly perform, sublicense, and distribute the
+  Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+  this License, each Contributor hereby grants to You a perpetual,
+  worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+  (except as stated in this section) patent license to make, have made,
+  use, offer to sell, sell, import, and otherwise transfer the Work,
+  where such license applies only to those patent claims licensable
+  by such Contributor that are necessarily infringed by their
+  Contribution(s) alone or by combination of their Contribution(s)
+  with the Work to which such Contribution(s) was submitted. If You
+  institute patent litigation against any entity (including a
+  cross-claim or counterclaim in a lawsuit) alleging that the Work
+  or a Contribution incorporated

[GitHub] [kibble] turbaszek merged pull request #2: Initial configuration

[GitBox]

turbaszek merged pull request #2:
URL: https://github.com/apache/kibble/pull/2


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek opened a new pull request #3: Run pre-commit manually as workaround for apache security issues

[GitBox]

turbaszek opened a new pull request #3:
URL: https://github.com/apache/kibble/pull/3


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek merged pull request #3: Fix CI issues

[GitBox]

turbaszek merged pull request #3:
URL: https://github.com/apache/kibble/pull/3


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek opened a new pull request #4: Update .asf.yaml to allow projects

[GitBox]

turbaszek opened a new pull request #4:
URL: https://github.com/apache/kibble/pull/4


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek merged pull request #4: Update .asf.yaml to allow projects

[GitBox]

turbaszek merged pull request #4:
URL: https://github.com/apache/kibble/pull/4


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek opened a new pull request #5: Add area:database to labeler

[GitBox]

turbaszek opened a new pull request #5:
URL: https://github.com/apache/kibble/pull/5


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek opened a new pull request #6: Add codeowners for automate reviewer assignment

[GitBox]

turbaszek opened a new pull request #6:
URL: https://github.com/apache/kibble/pull/6


   > Code owners are automatically requested for review when someone opens a 
pull request that modifies code that they own. 
   
https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners
   
   I think we may try this feature. Currently contributors are not able to 
request review (unless they ping a committer). 
   
   I tried to create some basic rules but I'm happy to get any suggestions!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on a change in pull request #6: Add codeowners for automate reviewer assignment

[GitBox]

turbaszek commented on a change in pull request #6:
URL: https://github.com/apache/kibble/pull/6#discussion_r586507416



##
File path: .github/CODEOWNERS
##
@@ -0,0 +1,8 @@
+# All repo
+* @turbaszek

Review comment:
   I did not added all committers because not everyone may want to get 
updates. Let me know if I should add you





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sharanf commented on a change in pull request #6: Add codeowners for automate reviewer assignment

[GitBox]

sharanf commented on a change in pull request #6:
URL: https://github.com/apache/kibble/pull/6#discussion_r588858491



##
File path: .github/CODEOWNERS
##
@@ -0,0 +1,8 @@
+# All repo
+* @turbaszek

Review comment:
   I'm happy to manage the items you put me down for :-) 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] michalslowikowski00 commented on pull request #5: Add area:database to labeler

[GitBox]

michalslowikowski00 commented on pull request #5:
URL: https://github.com/apache/kibble/pull/5#issuecomment-792262521


   🚀 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] michalslowikowski00 removed a comment on pull request #5: Add area:database to labeler

[GitBox]

michalslowikowski00 removed a comment on pull request #5:
URL: https://github.com/apache/kibble/pull/5#issuecomment-792262521


   🚀 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] michalslowikowski00 commented on a change in pull request #6: Add codeowners for automate reviewer assignment

[GitBox]

michalslowikowski00 commented on a change in pull request #6:
URL: https://github.com/apache/kibble/pull/6#discussion_r589016692



##
File path: .github/CODEOWNERS
##
@@ -0,0 +1,8 @@
+# All repo
+* @turbaszek

Review comment:
   I will do my best to support. Please add me as well, Tomek.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek merged pull request #5: Add area:database to labeler

[GitBox]

turbaszek merged pull request #5:
URL: https://github.com/apache/kibble/pull/5


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on a change in pull request #6: Add codeowners for automate reviewer assignment

[GitBox]

turbaszek commented on a change in pull request #6:
URL: https://github.com/apache/kibble/pull/6#discussion_r589377509



##
File path: .github/CODEOWNERS
##
@@ -0,0 +1,8 @@
+# All repo
+* @turbaszek

Review comment:
   ```suggestion
   * @turbaszek @michalslowikowski00
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek merged pull request #6: Add codeowners for automate reviewer assignment

[GitBox]

turbaszek merged pull request #6:
URL: https://github.com/apache/kibble/pull/6


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] erogol opened a new issue #7: Current installation instructions do not work

[GitBox]

erogol opened a new issue #7:
URL: https://github.com/apache/kibble/issues/7


   I try to apply what is on the docs, but I guess the library is updated, and 
it is not reflected in the docs. 
   
   How can I find the right set of instructions to run the project? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on issue #7: Current installation instructions do not work

[GitBox]

turbaszek commented on issue #7:
URL: https://github.com/apache/kibble/issues/7#issuecomment-805786244


   @erogol currently we are working on new kibble - this repo. To use old 
version try:
   https://github.com/apache/kibble-1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] erogol commented on issue #7: Current installation instructions do not work

[GitBox]

erogol commented on issue #7:
URL: https://github.com/apache/kibble/issues/7#issuecomment-805787354


   Exciting :) do you have a certain timeline for the new one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on issue #7: Current installation instructions do not work

[GitBox]

turbaszek commented on issue #7:
URL: https://github.com/apache/kibble/issues/7#issuecomment-805788351


   We are still discussing it. If you are interested in being part of it feel 
free to chime in in one of our discussions:
   
https://lists.apache.org/thread.html/r6e948e670495aaa4a7d1e27850edf1d0868a33de03c6e3f6f41dd80b%40%3Cdev.kibble.apache.org%3E
   
https://lists.apache.org/thread.html/r741e43dbcd666f95c9279eaeceb03c903beba2f2a652ac08dd89cf8f%40%3Cdev.kibble.apache.org%3E


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sharanf commented on issue #7: Current installation instructions do not work

[GitBox]

sharanf commented on issue #7:
URL: https://github.com/apache/kibble/issues/7#issuecomment-817164730


   Hi @erogol -  I am following up on this issue. Did the installation 
instructions work for you for the  kibble-1 repo?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] erogol commented on issue #7: Current installation instructions do not work

[GitBox]

erogol commented on issue #7:
URL: https://github.com/apache/kibble/issues/7#issuecomment-817183961


   no unfortunately :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek opened a new pull request #8: Add Github issues and PRs scanner

[GitBox]

turbaszek opened a new pull request #8:
URL: https://github.com/apache/kibble/pull/8


   In this PR I tried to build some basic tooling around scanning data sources. 
Currently the data is only collected and not persisted anywhere. That's still 
something I plan to do in this PR.
   
   Although I decided to use old approach with configuration in yaml file it 
should be treated only as temporary solution before we have a database. 
   
   Why didn't I use known PyGithub? It's LGPL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] kaxil commented on a change in pull request #8: Add Github issues and PRs scanner

[GitBox]

kaxil commented on a change in pull request #8:
URL: https://github.com/apache/kibble/pull/8#discussion_r637394461



##
File path: kibble/configuration/yaml_config.py
##
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import os
+from typing import Dict
+
+import yaml
+
+KIBBLE_YAML = "kibble.yaml"
+
+
+def parse_kibble_yaml() -> Dict:
+"""Reads kibble.yaml config file"""
+kibble_base_path = 
os.path.join(os.path.dirname(os.path.abspath(__file__)), os.pardir)
+config_path = os.path.join(kibble_base_path, KIBBLE_YAML)

Review comment:
   Should we replace this with 
[`Pathlib`](https://docs.python.org/3/library/pathlib.html#basic-use) as this 
is now preferred in Python world over os lib




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] michalslowikowski00 commented on issue #7: Current installation instructions do not work

[GitBox]

michalslowikowski00 commented on issue #7:
URL: https://github.com/apache/kibble/issues/7#issuecomment-847272490


   I will take a look at it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] michalslowikowski00 commented on a change in pull request #8: Add Github issues and PRs scanner

[GitBox]

michalslowikowski00 commented on a change in pull request #8:
URL: https://github.com/apache/kibble/pull/8#discussion_r638217424



##
File path: kibble/scanners/base.py
##
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+from typing import Any
+
+
+class BaseScanner:
+"""Abstract, base class for all scanners"""
+
+# pylint: disable=too-few-public-methods
+def __init__(self, **kwargs):
+self.log = logging.getLogger(__name__)
+
+def _persist(self, payload: Any):  # pylint: disable=no-self-use
+"""Persists data to database. Should be implemented per scanner."""

Review comment:
   One scanner, one database/table?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on a change in pull request #8: Add Github issues and PRs scanner

[GitBox]

turbaszek commented on a change in pull request #8:
URL: https://github.com/apache/kibble/pull/8#discussion_r641906748



##
File path: kibble/scanners/base.py
##
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+from typing import Any
+
+
+class BaseScanner:
+"""Abstract, base class for all scanners"""
+
+# pylint: disable=too-few-public-methods
+def __init__(self, **kwargs):
+self.log = logging.getLogger(__name__)
+
+def _persist(self, payload: Any):  # pylint: disable=no-self-use
+"""Persists data to database. Should be implemented per scanner."""

Review comment:
   > One scanner, one database/table?
   
   I assume there will be only one database with multiple collections / 
document types. Need to evaluate ES vs some  other nosql db




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on a change in pull request #8: Add Github issues and PRs scanner

[GitBox]

turbaszek commented on a change in pull request #8:
URL: https://github.com/apache/kibble/pull/8#discussion_r641906748



##
File path: kibble/scanners/base.py
##
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+from typing import Any
+
+
+class BaseScanner:
+"""Abstract, base class for all scanners"""
+
+# pylint: disable=too-few-public-methods
+def __init__(self, **kwargs):
+self.log = logging.getLogger(__name__)
+
+def _persist(self, payload: Any):  # pylint: disable=no-self-use
+"""Persists data to database. Should be implemented per scanner."""

Review comment:
   > One scanner, one database/table?
   
   I assume there will be only one database with multiple collections / 
document types. Need to evaluate ES vs some  other nosql db. 
   
   But general idea here is that each data type provides information how to 
persist it and how to read it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on pull request #8: Add Github issues and PRs scanner

[GitBox]

turbaszek commented on pull request #8:
URL: https://github.com/apache/kibble/pull/8#issuecomment-851057538


   @kaxil @sharanf @Humbedooh @michalslowikowski00 happy to get your opinion.
   
   As suggested on the dev list I introduced concept of `DataSource` and 
`DataType`. Those for now can be configured yaml configuration file:
   ```yaml
   data_sources:
  - name: github_kibble
class: kibble.data_sources.github.GithubDataSource
config:
  repo_owner: apache
  repo_name: kibble
  enabled_data_types:
- pr_issues
   ```
   
   This form allow users to specify any external data sources as long as the 
class path points to importable object. 
   
   The role of `DataSource` is to provide authentication methods for the 
external service represented by it. `DataType` represent single type of 
information we can get from this source, in case of this PR those are Github 
issues (which include also PRs).  Role of `DataType` is to define :
   - how to process the raw data from external source and how to persist them 
into database (to be done)
   - how to read the data from database including aggregation, filters etc.
   
   In general this is rough idea I have in m mind:
   
![Kibble](https://user-images.githubusercontent.com/9528307/120119256-ff745000-c196-11eb-803a-ae39f1a3d345.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek edited a comment on pull request #8: Add Github issues and PRs scanner

[GitBox]

turbaszek edited a comment on pull request #8:
URL: https://github.com/apache/kibble/pull/8#issuecomment-851057538


   @kaxil @sharanf @Humbedooh @michalslowikowski00 happy to get your opinion.
   
   As suggested on the dev list I introduced concept of `DataSource` and 
`DataType`. Those for now can be configured yaml configuration file:
   ```yaml
   data_sources:
  - name: github_kibble
class: kibble.data_sources.github.GithubDataSource
config:
  repo_owner: apache
  repo_name: kibble
  enabled_data_types:
- pr_issues
   ```
   
   This form allow users to specify any external data sources as long as the 
class path points to importable object. 
   
   The role of `DataSource` is to provide authentication methods for the 
external service represented by it. `DataType` represent single type of 
information we can get from this source, in case of this PR those are Github 
issues (which include also PRs).  Role of `DataType` is to define :
   - how to process the raw data from external source and how to persist them 
into database (to be done)
   - how to read the data from database including aggregation, filters etc.
   
   In general this is rough idea I have in m mind:
   
![Kibble-2](https://user-images.githubusercontent.com/9528307/120119311-4eba8080-c197-11eb-9e81-acce6e650c10.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sharanf commented on pull request #8: Add Github issues and PRs scanner

[GitBox]

sharanf commented on pull request #8:
URL: https://github.com/apache/kibble/pull/8#issuecomment-851610895


   > @kaxil @sharanf @Humbedooh @michalslowikowski00 happy to get your opinion.
   > 
   > As suggested on the dev list I introduced concept of `DataSource` and 
`DataType`. Those for now can be configured yaml configuration file:
   > 
   > ```yaml
   > data_sources:
   >- name: github_kibble
   >  class: kibble.data_sources.github.GithubDataSource
   >  config:
   >repo_owner: apache
   >repo_name: kibble
   >enabled_data_types:
   >  - pr_issues
   > ```
   > 
   > This form allow users to specify any external data sources as long as the 
class path points to importable object.
   > 
   > The role of `DataSource` is to provide authentication methods for the 
external service represented by it. `DataType` represent single type of 
information we can get from this source, in case of this PR those are Github 
issues (which include also PRs). Role of `DataType` is to define :
   > 
   > * how to process the raw data from external source and how to persist 
them into database (to be done)
   > 
   > * how to read the data from database including aggregation, filters 
etc.
   > 
   > 
   > In general this is rough idea I have in m mind:
   > 
![Kibble-2](https://user-images.githubusercontent.com/9528307/120119311-4eba8080-c197-11eb-9e81-acce6e650c10.png)
   
   @turbaszek Thanks for working on this.  My initial thought is that this 
looks a lot more granular than what we have in place now - which is good as we 
have sometimes missed at been able to get to the right level of granularity. 
For Github the datatypes seem fairly organised and can pretty much already 
allocated - how do you see this working for example for our project mailing 
lists? Would each list the be a datasource and the conversations the datatype?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on pull request #8: Add Github issues and PRs scanner

[GitBox]

turbaszek commented on pull request #8:
URL: https://github.com/apache/kibble/pull/8#issuecomment-851616956


   > how do you see this working for example for our project mailing lists? 
Would each list the be a datasource and the conversations the datatype?
   
   That's a very good question @sharanf!
   
   I would lean to what you've written. Datasource does not only represent an 
"external service" entity but "account/organization within an external 
service". So, in case of mailing list each Apache project would required 
configuring their own data source. 
   
   For example:
   ```yaml
   data_sources:
  - name: asf_mails_kibble
class: kibble.data_sources.pony_mail.PonyMailDataSource
config:
  project_name: kibble
  enabled_data_types:
- mails
  - name: asf_mails_kafka
class: kibble.data_sources.pony_mail.PonyMailDataSource
config:
  project_name: kafka
  enabled_data_types:
- mails
  - name: asf_mails_pulsar
class: kibble.data_sources.pony_mail.PonyMailDataSource
config:
  project_name: pulsar
  enabled_data_types:
- mails
   ```
   
   While there's a bit of duplication in configuration it allow more 
granularity. In case of ASF the config will be big and repeatable but for 
smaller Kibble deployments it would be smaller and more configuration maybe an 
advantage.
   
   Additionally this additional granularity is useful in case of sources that 
need authorisation. In such cases we may want to store the credentials in 
different way or use different auth methods.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] Humbedooh commented on a change in pull request #8: Add Github issues and PRs scanner

[GitBox]

Humbedooh commented on a change in pull request #8:
URL: https://github.com/apache/kibble/pull/8#discussion_r643063549



##
File path: kibble/scanners/base.py
##
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import logging
+from typing import Any
+
+
+class BaseScanner:
+"""Abstract, base class for all scanners"""
+
+# pylint: disable=too-few-public-methods
+def __init__(self, **kwargs):
+self.log = logging.getLogger(__name__)
+
+def _persist(self, payload: Any):  # pylint: disable=no-self-use
+"""Persists data to database. Should be implemented per scanner."""

Review comment:
   as of current ES versions, you can't have different document types in 
the same DB.
   So it would have to be one document type per index, which is what we also 
did with Kibble 1, for instance you have kibble_mail, kibble_code_commit, 
kibble_issue etc - one per general data type. You can do more generalized 
queries across indices, but usually we just deal with one type at a time, so 
having multiple indices is not an issue...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on a change in pull request #8: Add Github issues and PRs scanner

[GitBox]

turbaszek commented on a change in pull request #8:
URL: https://github.com/apache/kibble/pull/8#discussion_r650214549



##
File path: docs/architecture.rst
##
@@ -0,0 +1,126 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+ ..   http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+
+Apache Kibble Overview
+==

Review comment:
   @sharanf @Humbedooh @kaxil @michalslowikowski00 I added some docs/notes 
about current status and how things are. Let me know what do you think




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sharanf commented on a change in pull request #8: Add Github issues and PRs scanner

[GitBox]

sharanf commented on a change in pull request #8:
URL: https://github.com/apache/kibble/pull/8#discussion_r650543429



##
File path: docs/architecture.rst
##
@@ -0,0 +1,126 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+ ..   http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+
+Apache Kibble Overview
+==

Review comment:
   Thanks Tomek! This is good work. I have added some minor text changes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] turbaszek commented on pull request #8: Add Github issues and PRs scanner

[GitBox]

turbaszek commented on pull request #8:
URL: https://github.com/apache/kibble/pull/8#issuecomment-864088838


   @kaxil @Humbedooh @sharanf please let me know if we should proceed and merge 
(once I fix tests). I would like to make it move 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sharanf commented on pull request #8: Add Github issues and PRs scanner

[GitBox]

sharanf commented on pull request #8:
URL: https://github.com/apache/kibble/pull/8#issuecomment-864596293


   > @kaxil @Humbedooh @sharanf please let me know if we should proceed and 
merge (once I fix tests). I would like to make it move
   
   @turbaszek From my side I am happy to keep things moving so have no problems 
with starting to merge your new code once the tests are fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] haukesomm commented on issue #7: Current installation instructions do not work

[GitBox]

haukesomm commented on issue #7:
URL: https://github.com/apache/kibble/issues/7#issuecomment-892503508


   I can confirm this. The instructions do not work for both the old kibble-1 
project an this one.
   There is no `setup`-directory in this repo so I assume the guide is still 
written for the old repo. The `setup.py` in that repo fails as well, however. 
This is the error I get:
   ```
   Traceback (most recent call last):   
   
 File "setup/setup.py", line 35, in 
   
   mappings = json.load(open("mappings.json"))  
   
   FileNotFoundError: [Errno 2] No such file or directory: 'mappings.json'
   ```
   
   The Docker installation instructions also don't work because neither repo 
contains a docker-compose.yaml at this point in time.
   
   There should be a note in the documentation that it needs to be updated as 
it is quite confusing at the moment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] haukesomm edited a comment on issue #7: Current installation instructions do not work

[GitBox]

haukesomm edited a comment on issue #7:
URL: https://github.com/apache/kibble/issues/7#issuecomment-892503508


   I can confirm this. The instructions do not work for both the old kibble-1 
project an this one.
   There is no `setup`-directory in this repo so I assume the guide is still 
written for the old repo. The `setup.py` in that repo fails as well, however. 
This is the error I get:
   ```
   Traceback (most recent call last):   
   
 File "setup/setup.py", line 35, in 
   
   mappings = json.load(open("mappings.json"))  
   
   FileNotFoundError: [Errno 2] No such file or directory: 'mappings.json'
   ```
   
   The Docker installation instructions also don't work because neither repo 
contains a `docker-compose.yml` at this point in time.
   
   There should be a note in the documentation that it needs to be updated as 
it is quite confusing at the moment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sharanf commented on issue #7: Current installation instructions do not work

[GitBox]

sharanf commented on issue #7:
URL: https://github.com/apache/kibble/issues/7#issuecomment-892895732


   Thanks @haukesomm for the report and yes you are correct - the documentation 
hasn't been updated yet. I am sorry for the confusion it has caused and if 
no-one beats me to it, I will try to take a look at the weekend to see what I 
can do. :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] haukesomm commented on issue #7: Current installation instructions do not work

[GitBox]

haukesomm commented on issue #7:
URL: https://github.com/apache/kibble/issues/7#issuecomment-892898968


   Thanks for your effort! ✌🏻


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sharanf commented on issue #7: Current installation instructions do not work

[GitBox]

sharanf commented on issue #7:
URL: https://github.com/apache/kibble/issues/7#issuecomment-892895732


   Thanks @haukesomm for the report and yes you are correct - the documentation 
hasn't been updated yet. I am sorry for the confusion it has caused and if 
no-one beats me to it, I will try to take a look at the weekend to see what I 
can do. :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] haukesomm commented on issue #7: Current installation instructions do not work

[GitBox]

haukesomm commented on issue #7:
URL: https://github.com/apache/kibble/issues/7#issuecomment-892898968


   Thanks for your effort! ✌🏻


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] Humbedooh commented on issue #7: Current installation instructions do not work

[GitBox]

Humbedooh commented on issue #7:
URL: https://github.com/apache/kibble/issues/7#issuecomment-894762738


   The setup.py must be run from the setup directory, as it expects 
mappings.json to be local to the CWD.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sebbASF opened a new issue #9: "Down -20%" is confusing - does it mean "Up 20%"?

[GitBox]

sebbASF opened a new issue #9:
URL: https://github.com/apache/kibble/issues/9


   https://demo.kibble.apache.org/organisations.html?page=org
   
   currently says:
   
   Commits this quarter
   
   Down -10% since last period
   
   That does not make sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sebbASF opened a new issue #10: Demo: lots of failed scans

[GitBox]

sebbASF opened a new issue #10:
URL: https://github.com/apache/kibble/issues/10


   The demo page:
   
   https://demo.kibble.apache.org/organisations.html?page=sources
   
   is showing lost of failed scans, as well as two that have been running for 
several hours


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sebbASF opened a new issue #11: Demo: radio button does not stay on same line as its text

[GitBox]

sebbASF opened a new issue #11:
URL: https://github.com/apache/kibble/issues/11


   The Add source box on the sources page
   https://demo.kibble.apache.org/organisations.html?page=sources
   has several entries with radio buttons and logos.
   
   The radio buttons ought to stay with their logos when the browser window is 
resized or zoomed, but they don't:
   
   ![Screenshot 2021-09-23 at 11 20 
13](https://user-images.githubusercontent.com/16689231/134491256-e1c170a9-623f-4468-9939-e653041a3409.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] rombert opened a new issue #12: Allow to merge multiple contributors into a single one

[GitBox]

rombert opened a new issue #12:
URL: https://github.com/apache/kibble/issues/12


   
   
   **Description**
   
   
   People are mapped by email address but we usually get multiple ones and that 
makes it hard get proper email addresses. I
   would be happy with a way to manually say 
per...@apache.org/per...@employer.com/per...@gmail.com are the same.
   
   **Use case**
   
   
   Get more meaningful representations of contributors
   
   **Related Issues**
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] timshen opened a new issue #13: There is no setup/requirements.txt file

[GitBox]

timshen opened a new issue #13:
URL: https://github.com/apache/kibble/issues/13


   
   
   **Description:**
   In document 
https://apache-kibble.readthedocs.io/en/latest/setup.html#installing-the-server,
 a step is mentioned for installing the server. 
   "pip install -r setup/requirements.txt", but after cloning the code, I 
couldn't file the requirements.txt file.
   
   **Reproduction steps:**
   
   1. Execute the commands:
   git clone https://github.com/apache/kibble.git /var/www/kibble
   cd /var/www/kibble
   pip install -r setup/requirements.txt
   
   
   **Actual result:**
   No setup/requirements.txt is found
   
   **OS:**
   Ubuntu 18.04.5 LTS 
   
   **Logs:**
   NA
   
   **Other:**
   NA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] fiveohhh commented on issue #13: There is no setup/requirements.txt file

[GitBox]

fiveohhh commented on issue #13:
URL: https://github.com/apache/kibble/issues/13#issuecomment-952033218


   There seems to be some mismatch between doc versions and kibble versions.
   
   This repository is for a new kibble version that doesn't seem to have any 
public docs?
   There is a https://github.com/apache/kibble-1 repository that mostly matches 
what the readthedocs site is showing for latest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] pbrubaker commented on issue #7: Current installation instructions do not work

[GitBox]

pbrubaker commented on issue #7:
URL: https://github.com/apache/kibble/issues/7#issuecomment-1146549262

   Has this project died?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] pbrubaker opened a new issue, #14: Has this project died?

[GitBox]

pbrubaker opened a new issue, #14:
URL: https://github.com/apache/kibble/issues/14

   There aren't any recent (<9mo) commits to this repository.  Has this project 
been abandoned?  If so, it's incredibly confusing that all websites refer to 
this repository that has code that does nothing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sharanf commented on issue #14: Has this project died?

[GitBox]

sharanf commented on issue #14:
URL: https://github.com/apache/kibble/issues/14#issuecomment-1146837112

   Hi @pbrubaker. The answer to the question is no - not yet :-). Unfortunately 
we don't have any active volunteer developers in the community at the moment so 
this is why there is a lack of commit activity. Thank you for raising a very 
valid point regarding the confusion caused by the website and the documentation 
so I'll see what I can do to get this tidied up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sharanf commented on issue #10: Demo: lots of failed scans

[GitBox]

sharanf commented on issue #10:
URL: https://github.com/apache/kibble/issues/10#issuecomment-1146839642

   I started investigating the failed sources. We had around 150 to start with. 
It looked like some were caused by default branches with unsual names so I 
created an issue in the kibble-scanners repo 
[https://github.com/apache/kibble-scanners/issues/7](url). I posted an update 
here [https://s.apache.org/lxp6j](url). At the moment we still have approx 90 
failing scans so will continue to work on identifying the cause. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sebbASF commented on issue #10: Demo: lots of failed scans

[GitBox]

sebbASF commented on issue #10:
URL: https://github.com/apache/kibble/issues/10#issuecomment-1146841976

   The URLs in the previous comment both resolve to 
https://github.com/apache/kibble/issues/url which does not lead anywhere useful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] esmiralhaibm commented on issue #14: Has this project died?

[GitBox]

esmiralhaibm commented on issue #14:
URL: https://github.com/apache/kibble/issues/14#issuecomment-1146859080

   > Hi @pbrubaker. The answer to the question is no - not yet :-). 
Unfortunately we don't have any active volunteer developers in the community at 
the moment so this is why there is a lack of commit activity. Thank you for 
raising a very valid point regarding the confusion caused by the website and 
the documentation so I'll see what I can do to get this tidied up.
   
   Are you people looking for help on development?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sharanf commented on issue #10: Demo: lots of failed scans

[GitBox]

sharanf commented on issue #10:
URL: https://github.com/apache/kibble/issues/10#issuecomment-1146876855

   Thanks @sebbASF. Hope they are fixed and working now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sharanf commented on issue #14: Has this project died?

[GitBox]

sharanf commented on issue #14:
URL: https://github.com/apache/kibble/issues/14#issuecomment-1146877297

   Hi @esmiralhaibm Yes we are!. If you are interested then come along and join 
our mailing list at dev@kibble.apache.org


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] sebbASF commented on issue #10: Demo: lots of failed scans

[GitBox]

sebbASF commented on issue #10:
URL: https://github.com/apache/kibble/issues/10#issuecomment-1146890125

   Yes, the URLs are OK now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] pbrubaker commented on issue #14: Has this project died?

[GitBox]

pbrubaker commented on issue #14:
URL: https://github.com/apache/kibble/issues/14#issuecomment-1150460767

   Thanks much @sharanf!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kibble] pbrubaker closed issue #14: Has this project died?

[GitBox]

pbrubaker closed issue #14: Has this project died?
URL: https://github.com/apache/kibble/issues/14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kibble.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org