[jira] [Updated] (KNOX-488) If any failure during deletion of alias from a cluster , exception thrown is misleading
[
https://issues.apache.org/jira/browse/KNOX-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
J.Andreina updated KNOX-488:
Attachment: KNOX-488.1.patch
Hi Larry McCay,
Attached a patch . Did not add a testcase since it's just a Log
Message update. Please review and let me know if it is fine
If any failure during deletion of alias from a cluster , exception thrown is
misleading
---
Key: KNOX-488
URL: https://issues.apache.org/jira/browse/KNOX-488
Project: Apache Knox
Issue Type: Bug
Components: KnoxCLI
Reporter: J.Andreina
Priority: Minor
Attachments: KNOX-488.1.patch
I was doing testing on basic error scenarios and found that :
If any exception occurs during deletion of aliasname from a cluster , error
message displays Failed to add credential ( which is misleading).
{noformat}
public void removeCredential(String alias, KeyStore ks) {
if (ks != null) {
try {
if (ks.containsAlias(alias)) {
ks.deleteEntry(alias);
}
} catch (KeyStoreException e) {
LOG.failedToAddCredential(e);
}
}
}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (KNOX-488) If any failure during deletion of alias from a cluster , exception thrown is misleading
[
https://issues.apache.org/jira/browse/KNOX-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
J.Andreina updated KNOX-488:
Affects Version/s: 0.6.0
0.5.0
Status: Patch Available (was: Open)
If any failure during deletion of alias from a cluster , exception thrown is
misleading
---
Key: KNOX-488
URL: https://issues.apache.org/jira/browse/KNOX-488
Project: Apache Knox
Issue Type: Bug
Components: KnoxCLI
Affects Versions: 0.5.0, 0.6.0
Reporter: J.Andreina
Priority: Minor
Attachments: KNOX-488.1.patch
I was doing testing on basic error scenarios and found that :
If any exception occurs during deletion of aliasname from a cluster , error
message displays Failed to add credential ( which is misleading).
{noformat}
public void removeCredential(String alias, KeyStore ks) {
if (ks != null) {
try {
if (ks.containsAlias(alias)) {
ks.deleteEntry(alias);
}
} catch (KeyStoreException e) {
LOG.failedToAddCredential(e);
}
}
}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (KNOX-485) Gateway deployment directory value is been hardcoded , instead of value being read from exposed configuration.
[
https://issues.apache.org/jira/browse/KNOX-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
J.Andreina updated KNOX-485:
Attachment: KNOX-485.2.patch
Gateway deployment directory value is been hardcoded , instead of value being
read from exposed configuration.
--
Key: KNOX-485
URL: https://issues.apache.org/jira/browse/KNOX-485
Project: Apache Knox
Issue Type: Bug
Components: Server
Affects Versions: 0.5.0
Reporter: J.Andreina
Attachments: KNOX-485.1.patch, KNOX-485.2.patch
Issue1 :
==
During Gateway startup , deployment directory value is been hardcoded ,
instead of value being read from available configuration .
{noformat}
@Override
public String getGatewayDeploymentDir() {
return getGatewayDataDir() + File.separator + deployments;
}
{noformat}
Issue2:
==
Configuration Name in gateway-default.xml is not same as the name used in
org.apache.hadoop.gateway.config.impl.GatewayConfigImpl
{noformat}
private static final String GATEWAY_CONFIG_FILE_PREFIX = gateway;
public static final String DEPLOYMENT_DIR = GATEWAY_CONFIG_FILE_PREFIX +
.deployment.dir;
{noformat}
Incorrect Configuration name in gateway-default.xml
{noformat}
property
namegateway.gateway.conf.dir/name
valuedeployments/value
descriptionThe directory within GATEWAY_HOME that contains gateway
topology deployments./description
/property
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KNOX-485) Gateway deployment directory value is been hardcoded , instead of value being read from exposed configuration.
[
https://issues.apache.org/jira/browse/KNOX-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285438#comment-14285438
]
J.Andreina commented on KNOX-485:
-
Hi Larry McCay ,
Thanks for your comments. I have updated the patch as per your
suggestions along with couple of testcases and have attached it .
Please review the same.
Gateway deployment directory value is been hardcoded , instead of value being
read from exposed configuration.
--
Key: KNOX-485
URL: https://issues.apache.org/jira/browse/KNOX-485
Project: Apache Knox
Issue Type: Bug
Components: Server
Affects Versions: 0.5.0
Reporter: J.Andreina
Attachments: KNOX-485.1.patch
Issue1 :
==
During Gateway startup , deployment directory value is been hardcoded ,
instead of value being read from available configuration .
{noformat}
@Override
public String getGatewayDeploymentDir() {
return getGatewayDataDir() + File.separator + deployments;
}
{noformat}
Issue2:
==
Configuration Name in gateway-default.xml is not same as the name used in
org.apache.hadoop.gateway.config.impl.GatewayConfigImpl
{noformat}
private static final String GATEWAY_CONFIG_FILE_PREFIX = gateway;
public static final String DEPLOYMENT_DIR = GATEWAY_CONFIG_FILE_PREFIX +
.deployment.dir;
{noformat}
Incorrect Configuration name in gateway-default.xml
{noformat}
property
namegateway.gateway.conf.dir/name
valuedeployments/value
descriptionThe directory within GATEWAY_HOME that contains gateway
topology deployments./description
/property
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Notes for publishing releases to the Apache maven repo
Thanks! On Tue, Jan 20, 2015 at 11:40 PM, Kevin Minder kevin.min...@hortonworks.com wrote: Hi Everyone, I wanted to quickly capture my notes on publishing to the Apache Maven repo. I dumped this into the release process wiki too. I did this for 0.5.1 so this should be the last step of getting that out. Get your gpg passphrase in your paste buffer you will need it MANY times. If someone can figure out how to use gpg-agent properly they should document it. mvn -Papache-release -Drepo.id=apache.releases.https deploy Visit https://repository.apache.org/#stagingRepositories and: 1. Select Stging Repositories from Build Promotion on the left. 1. Close the stage with the Close button. For the Description field use Apache Knox 0.5.1 Staged 2. Release the stage with the Release button. For the Description field Apache Knox 0.5.1 Release Kevin. -- CONFIDENTIALITY NOTICE NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, you are hereby notified that any printing, copying, dissemination, distribution, disclosure or forwarding of this communication is strictly prohibited. If you have received this communication in error, please contact the sender immediately and delete it from your system. Thank You.
[jira] [Commented] (KNOX-488) If any failure during deletion of alias from a cluster , exception thrown is misleading
[
https://issues.apache.org/jira/browse/KNOX-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285591#comment-14285591
]
J.Andreina commented on KNOX-488:
-
Please check the issue . If its sounds good let me provide a patch for the same.
If any failure during deletion of alias from a cluster , exception thrown is
misleading
---
Key: KNOX-488
URL: https://issues.apache.org/jira/browse/KNOX-488
Project: Apache Knox
Issue Type: Bug
Components: KnoxCLI
Reporter: J.Andreina
Priority: Minor
I was doing testing on basic error scenarios and found that :
If any exception occurs during deletion of aliasname from a cluster , error
message displays Failed to add credential ( which is misleading).
{noformat}
public void removeCredential(String alias, KeyStore ks) {
if (ks != null) {
try {
if (ks.containsAlias(alias)) {
ks.deleteEntry(alias);
}
} catch (KeyStoreException e) {
LOG.failedToAddCredential(e);
}
}
}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jira] [Commented] (KNOX-488) If any failure during deletion of alias from a cluster , exception thrown is misleading
Good catch! Please do provide a patch.
Thank you for your contributions!
On Jan 21, 2015 7:58 AM, J.Andreina (JIRA) j...@apache.org wrote:
[
https://issues.apache.org/jira/browse/KNOX-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285591#comment-14285591
]
J.Andreina commented on KNOX-488:
-
Please check the issue . If its sounds good let me provide a patch for the
same.
If any failure during deletion of alias from a cluster , exception
thrown is misleading
---
Key: KNOX-488
URL: https://issues.apache.org/jira/browse/KNOX-488
Project: Apache Knox
Issue Type: Bug
Components: KnoxCLI
Reporter: J.Andreina
Priority: Minor
I was doing testing on basic error scenarios and found that :
If any exception occurs during deletion of aliasname from a cluster ,
error message displays Failed to add credential ( which is misleading).
{noformat}
public void removeCredential(String alias, KeyStore ks) {
if (ks != null) {
try {
if (ks.containsAlias(alias)) {
ks.deleteEntry(alias);
}
} catch (KeyStoreException e) {
LOG.failedToAddCredential(e);
}
}
}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KNOX-488) If any failure during deletion of alias from a cluster , exception thrown is misleading
[
https://issues.apache.org/jira/browse/KNOX-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285691#comment-14285691
]
Larry McCay commented on KNOX-488:
--
Good catch! Please do provide a patch.
Thank you for your contributions!
If any failure during deletion of alias from a cluster , exception thrown is
misleading
---
Key: KNOX-488
URL: https://issues.apache.org/jira/browse/KNOX-488
Project: Apache Knox
Issue Type: Bug
Components: KnoxCLI
Reporter: J.Andreina
Priority: Minor
I was doing testing on basic error scenarios and found that :
If any exception occurs during deletion of aliasname from a cluster , error
message displays Failed to add credential ( which is misleading).
{noformat}
public void removeCredential(String alias, KeyStore ks) {
if (ks != null) {
try {
if (ks.containsAlias(alias)) {
ks.deleteEntry(alias);
}
} catch (KeyStoreException e) {
LOG.failedToAddCredential(e);
}
}
}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
