Re: checkstyle on console during precommit builds

[William Berkeley]

Thanks for fixing this, Jordan.

-Will

On Mon, Nov 28, 2016 at 1:41 PM, Dan Burkert  wrote:

> Thanks, Jordan!
>
> On Mon, Nov 28, 2016 at 10:17 AM, Jordan Birdsell 
> wrote:
>
> > This has gone in, you will need to rebase any patches if you want to
> avoid
> > the extra large build output.
> >
> > On Fri, Nov 25, 2016, 4:25 PM Jordan Birdsell  >
> > wrote:
> >
> > > This appears to have done it https://gerrit.cloudera.org/#/c/5225/.
> > >
> > > Used a SuppressionFilter module in the style config and that seemed to
> > > work.
> > >
> > > On Fri, Nov 25, 2016 at 12:02 PM Mike Percy  wrote:
> > >
> > > I am familiar with checkstyle on Maven and could potentially take a
> look
> > at
> > > this, but it won't be before Tuesday.
> > >
> > > Mike
> > >
> > > On Wed, Nov 23, 2016 at 8:08 PM, Dan Burkert  wrote:
> > >
> > > > Nevermind, that didn't fix it.
> > > >
> > > > On Wed, Nov 23, 2016 at 11:59 AM, Dan Burkert 
> > wrote:
> > > >
> > > > > Still double checking, but this seems to have done the trick:
> > > > > https://gerrit.cloudera.org/#/c/5206/.  Not sure why, probably
> never
> > > > will.
> > > > >
> > > > > - Dan
> > > > >
> > > > > On Wed, Nov 23, 2016 at 11:50 AM, Todd Lipcon 
> > > wrote:
> > > > >
> > > > >> On Wed, Nov 23, 2016 at 11:13 AM, Dan Burkert 
> > > wrote:
> > > > >>
> > > > >>> I'm looking into this a bit.  It does get disabled on generated
> > > sources
> > > > >>> when I run it locally, and there is a line in the pom.xml
> > > > >>> 
> > > calling
> > > > >>> that out.  I haven't been able to pinpoint what is different on
> the
> > > > build
> > > > >>> slaves yet.  The version of checkstyle appears to match.
> > > > >>>
> > > > >>
> > > > >> hrm, that's odd... are we pinning the maven plugin version? I
> doubt
> > > JVM
> > > > >> version makes a difference, but perhaps...
> > > > >>
> > > > >> When you run locally using the same invocation as
> > > > >> build-support/jenkins/build-and-test.sh it does the same?
> > > > >>
> > > > >>
> > > > >>>
> > > > >>> - Dan
> > > > >>>
> > > > >>> On Wed, Nov 23, 2016 at 10:45 AM, William Berkeley <
> > > > >>> wdberke...@cloudera.com> wrote:
> > > > >>>
> > > >  Sorry. Will get to it asap. Away from home right now. Should be
> > able
> > > > to
> > > >  disable on generated source.
> > > > 
> > > >  On Wed, Nov 23, 2016 at 12:59 Todd Lipcon 
> > > wrote:
> > > > 
> > > >  > Ping?
> > > >  >
> > > >  > On Sun, Nov 20, 2016 at 7:53 PM, Todd Lipcon <
> t...@cloudera.com
> > >
> > > >  wrote:
> > > >  >
> > > >  > Hey folks,
> > > >  >
> > > >  > It seems after we enabled checkstyle on java builds, there's
> > now a
> > > >  ton of
> > > >  > spew in the log for precommit builds, eg:
> > > >  > http://104.196.14.100/job/kudu-gerrit/4670/BUILD_TYPE=TSAN/c
> > > >  onsoleText
> > > >  >
> > > >  > the build log is now 12MB, about 11MB of which appears to be
> > > 52,045
> > > >  > checkstyle warnings. Of those, 51962 appear to be in generated
> > > code
> > > > :)
> > > >  >
> > > >  > So, a few questions:
> > > >  > 1) can we get the checkstyle output to go to a separate file
> > > instead
> > > >  of
> > > >  > the console?
> > > >  > 2) can we disable checkstyle on generated sources?
> > > >  >
> > > >  > -Todd
> > > >  > --
> > > >  > Todd Lipcon
> > > >  > Software Engineer, Cloudera
> > > >  >
> > > >  >
> > > >  >
> > > >  >
> > > >  > --
> > > >  > Todd Lipcon
> > > >  > Software Engineer, Cloudera
> > > >  >
> > > > 
> > > > >>>
> > > > >>>
> > > > >>
> > > > >>
> > > > >> --
> > > > >> Todd Lipcon
> > > > >> Software Engineer, Cloudera
> > > > >>
> > > > >
> > > > >
> > > >
> > >
> > >
> >
>

Re: checkstyle on console during precommit builds

[Dan Burkert]

Thanks, Jordan!

On Mon, Nov 28, 2016 at 10:17 AM, Jordan Birdsell 
wrote:

> This has gone in, you will need to rebase any patches if you want to avoid
> the extra large build output.
>
> On Fri, Nov 25, 2016, 4:25 PM Jordan Birdsell 
> wrote:
>
> > This appears to have done it https://gerrit.cloudera.org/#/c/5225/.
> >
> > Used a SuppressionFilter module in the style config and that seemed to
> > work.
> >
> > On Fri, Nov 25, 2016 at 12:02 PM Mike Percy  wrote:
> >
> > I am familiar with checkstyle on Maven and could potentially take a look
> at
> > this, but it won't be before Tuesday.
> >
> > Mike
> >
> > On Wed, Nov 23, 2016 at 8:08 PM, Dan Burkert  wrote:
> >
> > > Nevermind, that didn't fix it.
> > >
> > > On Wed, Nov 23, 2016 at 11:59 AM, Dan Burkert 
> wrote:
> > >
> > > > Still double checking, but this seems to have done the trick:
> > > > https://gerrit.cloudera.org/#/c/5206/.  Not sure why, probably never
> > > will.
> > > >
> > > > - Dan
> > > >
> > > > On Wed, Nov 23, 2016 at 11:50 AM, Todd Lipcon 
> > wrote:
> > > >
> > > >> On Wed, Nov 23, 2016 at 11:13 AM, Dan Burkert 
> > wrote:
> > > >>
> > > >>> I'm looking into this a bit.  It does get disabled on generated
> > sources
> > > >>> when I run it locally, and there is a line in the pom.xml
> > > >>> 
> > calling
> > > >>> that out.  I haven't been able to pinpoint what is different on the
> > > build
> > > >>> slaves yet.  The version of checkstyle appears to match.
> > > >>>
> > > >>
> > > >> hrm, that's odd... are we pinning the maven plugin version? I doubt
> > JVM
> > > >> version makes a difference, but perhaps...
> > > >>
> > > >> When you run locally using the same invocation as
> > > >> build-support/jenkins/build-and-test.sh it does the same?
> > > >>
> > > >>
> > > >>>
> > > >>> - Dan
> > > >>>
> > > >>> On Wed, Nov 23, 2016 at 10:45 AM, William Berkeley <
> > > >>> wdberke...@cloudera.com> wrote:
> > > >>>
> > >  Sorry. Will get to it asap. Away from home right now. Should be
> able
> > > to
> > >  disable on generated source.
> > > 
> > >  On Wed, Nov 23, 2016 at 12:59 Todd Lipcon 
> > wrote:
> > > 
> > >  > Ping?
> > >  >
> > >  > On Sun, Nov 20, 2016 at 7:53 PM, Todd Lipcon  >
> > >  wrote:
> > >  >
> > >  > Hey folks,
> > >  >
> > >  > It seems after we enabled checkstyle on java builds, there's
> now a
> > >  ton of
> > >  > spew in the log for precommit builds, eg:
> > >  > http://104.196.14.100/job/kudu-gerrit/4670/BUILD_TYPE=TSAN/c
> > >  onsoleText
> > >  >
> > >  > the build log is now 12MB, about 11MB of which appears to be
> > 52,045
> > >  > checkstyle warnings. Of those, 51962 appear to be in generated
> > code
> > > :)
> > >  >
> > >  > So, a few questions:
> > >  > 1) can we get the checkstyle output to go to a separate file
> > instead
> > >  of
> > >  > the console?
> > >  > 2) can we disable checkstyle on generated sources?
> > >  >
> > >  > -Todd
> > >  > --
> > >  > Todd Lipcon
> > >  > Software Engineer, Cloudera
> > >  >
> > >  >
> > >  >
> > >  >
> > >  > --
> > >  > Todd Lipcon
> > >  > Software Engineer, Cloudera
> > >  >
> > > 
> > > >>>
> > > >>>
> > > >>
> > > >>
> > > >> --
> > > >> Todd Lipcon
> > > >> Software Engineer, Cloudera
> > > >>
> > > >
> > > >
> > >
> >
> >
>

Re: checkstyle on console during precommit builds

[Jordan Birdsell]

This has gone in, you will need to rebase any patches if you want to avoid
the extra large build output.

On Fri, Nov 25, 2016, 4:25 PM Jordan Birdsell 
wrote:

> This appears to have done it https://gerrit.cloudera.org/#/c/5225/.
>
> Used a SuppressionFilter module in the style config and that seemed to
> work.
>
> On Fri, Nov 25, 2016 at 12:02 PM Mike Percy  wrote:
>
> I am familiar with checkstyle on Maven and could potentially take a look at
> this, but it won't be before Tuesday.
>
> Mike
>
> On Wed, Nov 23, 2016 at 8:08 PM, Dan Burkert  wrote:
>
> > Nevermind, that didn't fix it.
> >
> > On Wed, Nov 23, 2016 at 11:59 AM, Dan Burkert  wrote:
> >
> > > Still double checking, but this seems to have done the trick:
> > > https://gerrit.cloudera.org/#/c/5206/.  Not sure why, probably never
> > will.
> > >
> > > - Dan
> > >
> > > On Wed, Nov 23, 2016 at 11:50 AM, Todd Lipcon 
> wrote:
> > >
> > >> On Wed, Nov 23, 2016 at 11:13 AM, Dan Burkert 
> wrote:
> > >>
> > >>> I'm looking into this a bit.  It does get disabled on generated
> sources
> > >>> when I run it locally, and there is a line in the pom.xml
> > >>> 
> calling
> > >>> that out.  I haven't been able to pinpoint what is different on the
> > build
> > >>> slaves yet.  The version of checkstyle appears to match.
> > >>>
> > >>
> > >> hrm, that's odd... are we pinning the maven plugin version? I doubt
> JVM
> > >> version makes a difference, but perhaps...
> > >>
> > >> When you run locally using the same invocation as
> > >> build-support/jenkins/build-and-test.sh it does the same?
> > >>
> > >>
> > >>>
> > >>> - Dan
> > >>>
> > >>> On Wed, Nov 23, 2016 at 10:45 AM, William Berkeley <
> > >>> wdberke...@cloudera.com> wrote:
> > >>>
> >  Sorry. Will get to it asap. Away from home right now. Should be able
> > to
> >  disable on generated source.
> > 
> >  On Wed, Nov 23, 2016 at 12:59 Todd Lipcon 
> wrote:
> > 
> >  > Ping?
> >  >
> >  > On Sun, Nov 20, 2016 at 7:53 PM, Todd Lipcon 
> >  wrote:
> >  >
> >  > Hey folks,
> >  >
> >  > It seems after we enabled checkstyle on java builds, there's now a
> >  ton of
> >  > spew in the log for precommit builds, eg:
> >  > http://104.196.14.100/job/kudu-gerrit/4670/BUILD_TYPE=TSAN/c
> >  onsoleText
> >  >
> >  > the build log is now 12MB, about 11MB of which appears to be
> 52,045
> >  > checkstyle warnings. Of those, 51962 appear to be in generated
> code
> > :)
> >  >
> >  > So, a few questions:
> >  > 1) can we get the checkstyle output to go to a separate file
> instead
> >  of
> >  > the console?
> >  > 2) can we disable checkstyle on generated sources?
> >  >
> >  > -Todd
> >  > --
> >  > Todd Lipcon
> >  > Software Engineer, Cloudera
> >  >
> >  >
> >  >
> >  >
> >  > --
> >  > Todd Lipcon
> >  > Software Engineer, Cloudera
> >  >
> > 
> > >>>
> > >>>
> > >>
> > >>
> > >> --
> > >> Todd Lipcon
> > >> Software Engineer, Cloudera
> > >>
> > >
> > >
> >
>
>

Re: checkstyle on console during precommit builds

[Jordan Birdsell]

This appears to have done it https://gerrit.cloudera.org/#/c/5225/.

Used a SuppressionFilter module in the style config and that seemed to work.

On Fri, Nov 25, 2016 at 12:02 PM Mike Percy  wrote:

> I am familiar with checkstyle on Maven and could potentially take a look at
> this, but it won't be before Tuesday.
>
> Mike
>
> On Wed, Nov 23, 2016 at 8:08 PM, Dan Burkert  wrote:
>
> > Nevermind, that didn't fix it.
> >
> > On Wed, Nov 23, 2016 at 11:59 AM, Dan Burkert  wrote:
> >
> > > Still double checking, but this seems to have done the trick:
> > > https://gerrit.cloudera.org/#/c/5206/.  Not sure why, probably never
> > will.
> > >
> > > - Dan
> > >
> > > On Wed, Nov 23, 2016 at 11:50 AM, Todd Lipcon 
> wrote:
> > >
> > >> On Wed, Nov 23, 2016 at 11:13 AM, Dan Burkert 
> wrote:
> > >>
> > >>> I'm looking into this a bit.  It does get disabled on generated
> sources
> > >>> when I run it locally, and there is a line in the pom.xml
> > >>> 
> calling
> > >>> that out.  I haven't been able to pinpoint what is different on the
> > build
> > >>> slaves yet.  The version of checkstyle appears to match.
> > >>>
> > >>
> > >> hrm, that's odd... are we pinning the maven plugin version? I doubt
> JVM
> > >> version makes a difference, but perhaps...
> > >>
> > >> When you run locally using the same invocation as
> > >> build-support/jenkins/build-and-test.sh it does the same?
> > >>
> > >>
> > >>>
> > >>> - Dan
> > >>>
> > >>> On Wed, Nov 23, 2016 at 10:45 AM, William Berkeley <
> > >>> wdberke...@cloudera.com> wrote:
> > >>>
> >  Sorry. Will get to it asap. Away from home right now. Should be able
> > to
> >  disable on generated source.
> > 
> >  On Wed, Nov 23, 2016 at 12:59 Todd Lipcon 
> wrote:
> > 
> >  > Ping?
> >  >
> >  > On Sun, Nov 20, 2016 at 7:53 PM, Todd Lipcon 
> >  wrote:
> >  >
> >  > Hey folks,
> >  >
> >  > It seems after we enabled checkstyle on java builds, there's now a
> >  ton of
> >  > spew in the log for precommit builds, eg:
> >  > http://104.196.14.100/job/kudu-gerrit/4670/BUILD_TYPE=TSAN/c
> >  onsoleText
> >  >
> >  > the build log is now 12MB, about 11MB of which appears to be
> 52,045
> >  > checkstyle warnings. Of those, 51962 appear to be in generated
> code
> > :)
> >  >
> >  > So, a few questions:
> >  > 1) can we get the checkstyle output to go to a separate file
> instead
> >  of
> >  > the console?
> >  > 2) can we disable checkstyle on generated sources?
> >  >
> >  > -Todd
> >  > --
> >  > Todd Lipcon
> >  > Software Engineer, Cloudera
> >  >
> >  >
> >  >
> >  >
> >  > --
> >  > Todd Lipcon
> >  > Software Engineer, Cloudera
> >  >
> > 
> > >>>
> > >>>
> > >>
> > >>
> > >> --
> > >> Todd Lipcon
> > >> Software Engineer, Cloudera
> > >>
> > >
> > >
> >
>

Re: checkstyle on console during precommit builds

[Mike Percy]

I am familiar with checkstyle on Maven and could potentially take a look at
this, but it won't be before Tuesday.

Mike

On Wed, Nov 23, 2016 at 8:08 PM, Dan Burkert  wrote:

> Nevermind, that didn't fix it.
>
> On Wed, Nov 23, 2016 at 11:59 AM, Dan Burkert  wrote:
>
> > Still double checking, but this seems to have done the trick:
> > https://gerrit.cloudera.org/#/c/5206/.  Not sure why, probably never
> will.
> >
> > - Dan
> >
> > On Wed, Nov 23, 2016 at 11:50 AM, Todd Lipcon  wrote:
> >
> >> On Wed, Nov 23, 2016 at 11:13 AM, Dan Burkert  wrote:
> >>
> >>> I'm looking into this a bit.  It does get disabled on generated sources
> >>> when I run it locally, and there is a line in the pom.xml
> >>>  calling
> >>> that out.  I haven't been able to pinpoint what is different on the
> build
> >>> slaves yet.  The version of checkstyle appears to match.
> >>>
> >>
> >> hrm, that's odd... are we pinning the maven plugin version? I doubt JVM
> >> version makes a difference, but perhaps...
> >>
> >> When you run locally using the same invocation as
> >> build-support/jenkins/build-and-test.sh it does the same?
> >>
> >>
> >>>
> >>> - Dan
> >>>
> >>> On Wed, Nov 23, 2016 at 10:45 AM, William Berkeley <
> >>> wdberke...@cloudera.com> wrote:
> >>>
>  Sorry. Will get to it asap. Away from home right now. Should be able
> to
>  disable on generated source.
> 
>  On Wed, Nov 23, 2016 at 12:59 Todd Lipcon  wrote:
> 
>  > Ping?
>  >
>  > On Sun, Nov 20, 2016 at 7:53 PM, Todd Lipcon 
>  wrote:
>  >
>  > Hey folks,
>  >
>  > It seems after we enabled checkstyle on java builds, there's now a
>  ton of
>  > spew in the log for precommit builds, eg:
>  > http://104.196.14.100/job/kudu-gerrit/4670/BUILD_TYPE=TSAN/c
>  onsoleText
>  >
>  > the build log is now 12MB, about 11MB of which appears to be 52,045
>  > checkstyle warnings. Of those, 51962 appear to be in generated code
> :)
>  >
>  > So, a few questions:
>  > 1) can we get the checkstyle output to go to a separate file instead
>  of
>  > the console?
>  > 2) can we disable checkstyle on generated sources?
>  >
>  > -Todd
>  > --
>  > Todd Lipcon
>  > Software Engineer, Cloudera
>  >
>  >
>  >
>  >
>  > --
>  > Todd Lipcon
>  > Software Engineer, Cloudera
>  >
> 
> >>>
> >>>
> >>
> >>
> >> --
> >> Todd Lipcon
> >> Software Engineer, Cloudera
> >>
> >
> >
>

Re: checkstyle on console during precommit builds

[Dan Burkert]

Nevermind, that didn't fix it.

On Wed, Nov 23, 2016 at 11:59 AM, Dan Burkert  wrote:

> Still double checking, but this seems to have done the trick:
> https://gerrit.cloudera.org/#/c/5206/.  Not sure why, probably never will.
>
> - Dan
>
> On Wed, Nov 23, 2016 at 11:50 AM, Todd Lipcon  wrote:
>
>> On Wed, Nov 23, 2016 at 11:13 AM, Dan Burkert  wrote:
>>
>>> I'm looking into this a bit.  It does get disabled on generated sources
>>> when I run it locally, and there is a line in the pom.xml
>>>  calling
>>> that out.  I haven't been able to pinpoint what is different on the build
>>> slaves yet.  The version of checkstyle appears to match.
>>>
>>
>> hrm, that's odd... are we pinning the maven plugin version? I doubt JVM
>> version makes a difference, but perhaps...
>>
>> When you run locally using the same invocation as
>> build-support/jenkins/build-and-test.sh it does the same?
>>
>>
>>>
>>> - Dan
>>>
>>> On Wed, Nov 23, 2016 at 10:45 AM, William Berkeley <
>>> wdberke...@cloudera.com> wrote:
>>>
 Sorry. Will get to it asap. Away from home right now. Should be able to
 disable on generated source.

 On Wed, Nov 23, 2016 at 12:59 Todd Lipcon  wrote:

 > Ping?
 >
 > On Sun, Nov 20, 2016 at 7:53 PM, Todd Lipcon 
 wrote:
 >
 > Hey folks,
 >
 > It seems after we enabled checkstyle on java builds, there's now a
 ton of
 > spew in the log for precommit builds, eg:
 > http://104.196.14.100/job/kudu-gerrit/4670/BUILD_TYPE=TSAN/c
 onsoleText
 >
 > the build log is now 12MB, about 11MB of which appears to be 52,045
 > checkstyle warnings. Of those, 51962 appear to be in generated code :)
 >
 > So, a few questions:
 > 1) can we get the checkstyle output to go to a separate file instead
 of
 > the console?
 > 2) can we disable checkstyle on generated sources?
 >
 > -Todd
 > --
 > Todd Lipcon
 > Software Engineer, Cloudera
 >
 >
 >
 >
 > --
 > Todd Lipcon
 > Software Engineer, Cloudera
 >

>>>
>>>
>>
>>
>> --
>> Todd Lipcon
>> Software Engineer, Cloudera
>>
>
>

Re: checkstyle on console during precommit builds

[Dan Burkert]

Still double checking, but this seems to have done the trick:
https://gerrit.cloudera.org/#/c/5206/.  Not sure why, probably never will.

- Dan

On Wed, Nov 23, 2016 at 11:50 AM, Todd Lipcon  wrote:

> On Wed, Nov 23, 2016 at 11:13 AM, Dan Burkert  wrote:
>
>> I'm looking into this a bit.  It does get disabled on generated sources
>> when I run it locally, and there is a line in the pom.xml
>>  calling
>> that out.  I haven't been able to pinpoint what is different on the build
>> slaves yet.  The version of checkstyle appears to match.
>>
>
> hrm, that's odd... are we pinning the maven plugin version? I doubt JVM
> version makes a difference, but perhaps...
>
> When you run locally using the same invocation as
> build-support/jenkins/build-and-test.sh it does the same?
>
>
>>
>> - Dan
>>
>> On Wed, Nov 23, 2016 at 10:45 AM, William Berkeley <
>> wdberke...@cloudera.com> wrote:
>>
>>> Sorry. Will get to it asap. Away from home right now. Should be able to
>>> disable on generated source.
>>>
>>> On Wed, Nov 23, 2016 at 12:59 Todd Lipcon  wrote:
>>>
>>> > Ping?
>>> >
>>> > On Sun, Nov 20, 2016 at 7:53 PM, Todd Lipcon 
>>> wrote:
>>> >
>>> > Hey folks,
>>> >
>>> > It seems after we enabled checkstyle on java builds, there's now a ton
>>> of
>>> > spew in the log for precommit builds, eg:
>>> > http://104.196.14.100/job/kudu-gerrit/4670/BUILD_TYPE=TSAN/consoleText
>>> >
>>> > the build log is now 12MB, about 11MB of which appears to be 52,045
>>> > checkstyle warnings. Of those, 51962 appear to be in generated code :)
>>> >
>>> > So, a few questions:
>>> > 1) can we get the checkstyle output to go to a separate file instead of
>>> > the console?
>>> > 2) can we disable checkstyle on generated sources?
>>> >
>>> > -Todd
>>> > --
>>> > Todd Lipcon
>>> > Software Engineer, Cloudera
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > Todd Lipcon
>>> > Software Engineer, Cloudera
>>> >
>>>
>>
>>
>
>
> --
> Todd Lipcon
> Software Engineer, Cloudera
>

Re: checkstyle on console during precommit builds

[Todd Lipcon]

On Wed, Nov 23, 2016 at 11:13 AM, Dan Burkert  wrote:

> I'm looking into this a bit.  It does get disabled on generated sources
> when I run it locally, and there is a line in the pom.xml
>  calling
> that out.  I haven't been able to pinpoint what is different on the build
> slaves yet.  The version of checkstyle appears to match.
>

hrm, that's odd... are we pinning the maven plugin version? I doubt JVM
version makes a difference, but perhaps...

When you run locally using the same invocation as
build-support/jenkins/build-and-test.sh it does the same?


>
> - Dan
>
> On Wed, Nov 23, 2016 at 10:45 AM, William Berkeley <
> wdberke...@cloudera.com> wrote:
>
>> Sorry. Will get to it asap. Away from home right now. Should be able to
>> disable on generated source.
>>
>> On Wed, Nov 23, 2016 at 12:59 Todd Lipcon  wrote:
>>
>> > Ping?
>> >
>> > On Sun, Nov 20, 2016 at 7:53 PM, Todd Lipcon  wrote:
>> >
>> > Hey folks,
>> >
>> > It seems after we enabled checkstyle on java builds, there's now a ton
>> of
>> > spew in the log for precommit builds, eg:
>> > http://104.196.14.100/job/kudu-gerrit/4670/BUILD_TYPE=TSAN/consoleText
>> >
>> > the build log is now 12MB, about 11MB of which appears to be 52,045
>> > checkstyle warnings. Of those, 51962 appear to be in generated code :)
>> >
>> > So, a few questions:
>> > 1) can we get the checkstyle output to go to a separate file instead of
>> > the console?
>> > 2) can we disable checkstyle on generated sources?
>> >
>> > -Todd
>> > --
>> > Todd Lipcon
>> > Software Engineer, Cloudera
>> >
>> >
>> >
>> >
>> > --
>> > Todd Lipcon
>> > Software Engineer, Cloudera
>> >
>>
>
>


-- 
Todd Lipcon
Software Engineer, Cloudera

Re: checkstyle on console during precommit builds

[Dan Burkert]

I'm looking into this a bit.  It does get disabled on generated sources
when I run it locally, and there is a line in the pom.xml
 calling that
out.  I haven't been able to pinpoint what is different on the build slaves
yet.  The version of checkstyle appears to match.

- Dan

On Wed, Nov 23, 2016 at 10:45 AM, William Berkeley 
wrote:

> Sorry. Will get to it asap. Away from home right now. Should be able to
> disable on generated source.
>
> On Wed, Nov 23, 2016 at 12:59 Todd Lipcon  wrote:
>
> > Ping?
> >
> > On Sun, Nov 20, 2016 at 7:53 PM, Todd Lipcon  wrote:
> >
> > Hey folks,
> >
> > It seems after we enabled checkstyle on java builds, there's now a ton of
> > spew in the log for precommit builds, eg:
> > http://104.196.14.100/job/kudu-gerrit/4670/BUILD_TYPE=TSAN/consoleText
> >
> > the build log is now 12MB, about 11MB of which appears to be 52,045
> > checkstyle warnings. Of those, 51962 appear to be in generated code :)
> >
> > So, a few questions:
> > 1) can we get the checkstyle output to go to a separate file instead of
> > the console?
> > 2) can we disable checkstyle on generated sources?
> >
> > -Todd
> > --
> > Todd Lipcon
> > Software Engineer, Cloudera
> >
> >
> >
> >
> > --
> > Todd Lipcon
> > Software Engineer, Cloudera
> >
>

Re: checkstyle on console during precommit builds

[William Berkeley]

Sorry. Will get to it asap. Away from home right now. Should be able to
disable on generated source.

On Wed, Nov 23, 2016 at 12:59 Todd Lipcon  wrote:

> Ping?
>
> On Sun, Nov 20, 2016 at 7:53 PM, Todd Lipcon  wrote:
>
> Hey folks,
>
> It seems after we enabled checkstyle on java builds, there's now a ton of
> spew in the log for precommit builds, eg:
> http://104.196.14.100/job/kudu-gerrit/4670/BUILD_TYPE=TSAN/consoleText
>
> the build log is now 12MB, about 11MB of which appears to be 52,045
> checkstyle warnings. Of those, 51962 appear to be in generated code :)
>
> So, a few questions:
> 1) can we get the checkstyle output to go to a separate file instead of
> the console?
> 2) can we disable checkstyle on generated sources?
>
> -Todd
> --
> Todd Lipcon
> Software Engineer, Cloudera
>
>
>
>
> --
> Todd Lipcon
> Software Engineer, Cloudera
>

Re: checkstyle on console during precommit builds

[Todd Lipcon]

Ping?

On Sun, Nov 20, 2016 at 7:53 PM, Todd Lipcon  wrote:

> Hey folks,
>
> It seems after we enabled checkstyle on java builds, there's now a ton of
> spew in the log for precommit builds, eg: http://104.196.14.100/job/
> kudu-gerrit/4670/BUILD_TYPE=TSAN/consoleText
>
> the build log is now 12MB, about 11MB of which appears to be 52,045
> checkstyle warnings. Of those, 51962 appear to be in generated code :)
>
> So, a few questions:
> 1) can we get the checkstyle output to go to a separate file instead of
> the console?
> 2) can we disable checkstyle on generated sources?
>
> -Todd
> --
> Todd Lipcon
> Software Engineer, Cloudera
>



-- 
Todd Lipcon
Software Engineer, Cloudera