Re: Review Request 40863: LENS-552: Union support across storage tables in multi fact query

2015-12-13 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40863/
---

(Updated Dec. 13, 2015, 3:36 p.m.)


Review request for lens.


Bugs: LENS-552
https://issues.apache.org/jira/browse/LENS-552


Repository: lens


Description
---

includes LENS-851 changes, since I expect this to be merged after LENS-851


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
b544a670a27f65b65a66affde55c7276438d4daa 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
0656049dafc0b974104ff1c2f79a98fac934901d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 
94725063c0f9f64682bc0741c409bcefdf0be8ec 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
2338ba70bbdeae90c7a0270f63f5d2c1255b5529 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 
b95595ade6120c0073c286e073715800b6cdd915 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
cf114c91f103d40c1f0fe9886b15820bb7ef7614 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
e0759b0b8894ec1d0cca41fa6f897576f8090070 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
PRE-CREATION 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 
a576f3a6720e5e4454faf0188a43091191b0c787 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
bcfc1f6202da5c4377cf6710525c9655a08ce4cc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 
0c43d9800d27b6c343af2b200ebeff9cf20fa816 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
776021d94cfb3c724970bc81a5d03c58459c7911 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 
6c442333fb42beafac1839907159d775b6f97dce 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
da74713e5656a10144a6298a2a6fea266a11e156 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
7cea7d5a4491d1185cae845415d90d46cfd825c0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
1385584e033abe904279a8fd6dfa299f4e48665c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 
113d8deb8284443ae45151aa27852ab97570591e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
de52b0a50b8cec580eb7807669d652a85b71e5f9 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
 96b1d054a3c444960c69298d878784a819defd53 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactSingleStorageHQLContext.java
 PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
62cc071237b84c46d69d78eea694eb9b8e9b2fd4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
3f01dbeb1e27248071ecd78c48daea8b77c87459 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
97c6d08a6d4ab53a49d9e205d1b4013b08da3658 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
0f05556decc24cd5101e75b0851d1f9ff14d4b95 

Diff: https://reviews.apache.org/r/40863/diff/


Testing
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.211s]
[INFO] Lens .. SUCCESS [4.133s]
[INFO] Lens API .. SUCCESS [26.669s]
[INFO] Lens API for server and extensions  SUCCESS [24.038s]
[INFO] Lens Cube . SUCCESS [6:30.318s]
[INFO] Lens DB storage ... SUCCESS [19.100s]
[INFO] Lens Query Library  SUCCESS [14.772s]
[INFO] Lens Hive Driver .. SUCCESS [3:00.020s]
[INFO] Lens Driver for JDBC .. SUCCESS [40.555s]
[INFO] Lens Elastic Search Driver  SUCCESS [18.922s]
[INFO] Lens Server ... SUCCESS [10:23.992s]
[INFO] Lens client ... SUCCESS [40.087s]
[INFO] Lens CLI .. SUCCESS [54.969s]
[INFO] Lens Examples . SUCCESS [11.468s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.983s]
[INFO] Lens Distribution . SUCCESS [9.764s]
[INFO] Lens ML Lib ... SUCCESS [1:31.190s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.913s]
[INFO] Lens Regression

Re: Review Request 40761: Query Completion email missing for some queries

2015-12-13 Thread Puneet Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40761/
---

(Updated Dec. 14, 2015, 4:10 a.m.)


Review request for lens.


Changes
---

- AsyncEventListener Therad pool to honor corePool and also MaxPool(new)
- Updated core pool and max pool size for result formatter and Query End 
Notifier ( As of now the pool size is static. It can be read form configuration 
later if required)
- Added a test case to check thread naming in AsyncEventListener pool and also 
core pool size.

Build passed (mvn clean install -DskipTests)
Test run in progress. Will post the test status soon .


Bugs: LENS-887
https://issues.apache.org/jira/browse/LENS-887


Repository: lens


Description
---

Initial Changes (as discussed in JIRA) 
+ disabled core pool timeout for AsyncEventListeners (since pool had only 
single thread)


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java
 547c008 
  lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 
a276828 
  lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
110624a 
  lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 
f568b17 
  lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 
702a529 

Diff: https://reviews.apache.org/r/40761/diff/


Testing
---

> Verified Build .
> Verified new Thread Names while debugging.

[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.085s]
[INFO] Lens .. SUCCESS [2.889s]
[INFO] Lens API .. SUCCESS [25.083s]
[INFO] Lens API for server and extensions  SUCCESS [23.336s]
[INFO] Lens Cube . SUCCESS [5:57.544s]
[INFO] Lens DB storage ... SUCCESS [20.762s]
[INFO] Lens Query Library  SUCCESS [15.393s]
[INFO] Lens Hive Driver .. SUCCESS [2:50.461s]
[INFO] Lens Driver for JDBC .. SUCCESS [35.760s]
[INFO] Lens Elastic Search Driver  SUCCESS [17.248s]
[INFO] Lens Server ... SUCCESS [9:50.223s]
[INFO] Lens client ... SUCCESS [36.590s]
[INFO] Lens CLI .. SUCCESS [51.185s]
[INFO] Lens Examples . SUCCESS [9.779s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.037s]
[INFO] Lens Distribution . SUCCESS [8.573s]
[INFO] Lens ML Lib ... SUCCESS [1:20.846s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.013s]
[INFO] Lens Regression ... SUCCESS [12.349s]
[INFO] Lens UI ... SUCCESS [27.294s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 24:51.394s
[INFO] Finished at: Sat Nov 28 04:07:51 UTC 2015
[INFO] Final Memory: 199M/2040M
[INFO] 


Thanks,

Puneet Gupta

Re: Review Request 40761: Query Completion email missing for some queries

2015-12-13 Thread Puneet Gupta 


> On Nov. 28, 2015, 8:53 a.m., Ajay Yadava wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java,
> >  line 115
> > 
> >
> > It will be useful to log the exception/error as well.

Right. Missed it . Will update.


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40761/#review108254
---


On Dec. 14, 2015, 4:10 a.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40761/
> ---
> 
> (Updated Dec. 14, 2015, 4:10 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-887
> https://issues.apache.org/jira/browse/LENS-887
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Initial Changes (as discussed in JIRA) 
> + disabled core pool timeout for AsyncEventListeners (since pool had only 
> single thread)
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java
>  547c008 
>   lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 
> a276828 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
> 110624a 
>   lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 
> f568b17 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 
> 702a529 
> 
> Diff: https://reviews.apache.org/r/40761/diff/
> 
> 
> Testing
> ---
> 
> > Verified Build .
> > Verified new Thread Names while debugging.
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.085s]
> [INFO] Lens .. SUCCESS [2.889s]
> [INFO] Lens API .. SUCCESS [25.083s]
> [INFO] Lens API for server and extensions  SUCCESS [23.336s]
> [INFO] Lens Cube . SUCCESS [5:57.544s]
> [INFO] Lens DB storage ... SUCCESS [20.762s]
> [INFO] Lens Query Library  SUCCESS [15.393s]
> [INFO] Lens Hive Driver .. SUCCESS [2:50.461s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.760s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.248s]
> [INFO] Lens Server ... SUCCESS [9:50.223s]
> [INFO] Lens client ... SUCCESS [36.590s]
> [INFO] Lens CLI .. SUCCESS [51.185s]
> [INFO] Lens Examples . SUCCESS [9.779s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.037s]
> [INFO] Lens Distribution . SUCCESS [8.573s]
> [INFO] Lens ML Lib ... SUCCESS [1:20.846s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.013s]
> [INFO] Lens Regression ... SUCCESS [12.349s]
> [INFO] Lens UI ... SUCCESS [27.294s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:51.394s
> [INFO] Finished at: Sat Nov 28 04:07:51 UTC 2015
> [INFO] Final Memory: 199M/2040M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>

Re: Review Request 40761: Query Completion email missing for some queries

2015-12-13 Thread Puneet Gupta 


> On Nov. 30, 2015, 5:22 a.m., Amareshwari Sriramadasu wrote:
> > Can you add unit tests?

Added one test case for AyncListener pool creation and thread naming. 

Our initail analysis that if QueryEndNotifier.process(QueryEnded) fails with 
some exception , the AyncEventListener thread may exit is partailly correct . 
The therad will exit but the thread pool will cteare a new worker thread 
automatically. So not adding test case for this scenario.


> On Nov. 30, 2015, 5:22 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java,
> >  line 114
> > 
> >
> > Might result in checkstyle issue with {

Did not find this in mvn run


> On Nov. 30, 2015, 5:22 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java,
> >  line 115
> > 
> >
> > Should we add error counters for knowing these exception?
> > 
> > Error name can be getName()_"event_process_errors"
> 
> Puneet Gupta wrote:
> I feel its not required separately for each AsyncHandler
> We can have at uber level.
> In rare cases we will get the value >0 and when that happens we can grep 
> logs for further details.

Drpped at uber level also as each listener is already publishing stats if 
required. Also the excption behaviour is different for each listerenr. Some 
catch all execptions and nothing is visible to above layers and some don't.


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40761/#review108283
---


On Dec. 14, 2015, 4:10 a.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40761/
> ---
> 
> (Updated Dec. 14, 2015, 4:10 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-887
> https://issues.apache.org/jira/browse/LENS-887
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Initial Changes (as discussed in JIRA) 
> + disabled core pool timeout for AsyncEventListeners (since pool had only 
> single thread)
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java
>  547c008 
>   lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 
> a276828 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
> 110624a 
>   lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 
> f568b17 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 
> 702a529 
> 
> Diff: https://reviews.apache.org/r/40761/diff/
> 
> 
> Testing
> ---
> 
> > Verified Build .
> > Verified new Thread Names while debugging.
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.085s]
> [INFO] Lens .. SUCCESS [2.889s]
> [INFO] Lens API .. SUCCESS [25.083s]
> [INFO] Lens API for server and extensions  SUCCESS [23.336s]
> [INFO] Lens Cube . SUCCESS [5:57.544s]
> [INFO] Lens DB storage ... SUCCESS [20.762s]
> [INFO] Lens Query Library  SUCCESS [15.393s]
> [INFO] Lens Hive Driver .. SUCCESS [2:50.461s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.760s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.248s]
> [INFO] Lens Server ... SUCCESS [9:50.223s]
> [INFO] Lens client ... SUCCESS [36.590s]
> [INFO] Lens CLI .. SUCCESS [51.185s]
> [INFO] Lens Examples . SUCCESS [9.779s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.037s]
> [INFO] Lens Distribution . SUCCESS [8.573s]
> [INFO] Lens ML Lib ... SUCCESS [1:20.846s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.013s]
> [INFO] Lens Regression ... SUCCESS [12.349s]
> [INFO] Lens UI ... SUCCESS [27.294s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:51.394s
>

Re: Review Request 40761: Query Completion email missing for some queries

2015-12-13 Thread Puneet Gupta 


> On Dec. 7, 2015, 7:48 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java,
> >  line 97
> > 
> >
> > Remove commented code.

Thought it would be helpful to initial review as the core pool will not time 
out after this change. Removed.


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40761/#review109128
---


On Dec. 14, 2015, 4:10 a.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40761/
> ---
> 
> (Updated Dec. 14, 2015, 4:10 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-887
> https://issues.apache.org/jira/browse/LENS-887
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Initial Changes (as discussed in JIRA) 
> + disabled core pool timeout for AsyncEventListeners (since pool had only 
> single thread)
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java
>  547c008 
>   lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 
> a276828 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
> 110624a 
>   lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 
> f568b17 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 
> 702a529 
> 
> Diff: https://reviews.apache.org/r/40761/diff/
> 
> 
> Testing
> ---
> 
> > Verified Build .
> > Verified new Thread Names while debugging.
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.085s]
> [INFO] Lens .. SUCCESS [2.889s]
> [INFO] Lens API .. SUCCESS [25.083s]
> [INFO] Lens API for server and extensions  SUCCESS [23.336s]
> [INFO] Lens Cube . SUCCESS [5:57.544s]
> [INFO] Lens DB storage ... SUCCESS [20.762s]
> [INFO] Lens Query Library  SUCCESS [15.393s]
> [INFO] Lens Hive Driver .. SUCCESS [2:50.461s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.760s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.248s]
> [INFO] Lens Server ... SUCCESS [9:50.223s]
> [INFO] Lens client ... SUCCESS [36.590s]
> [INFO] Lens CLI .. SUCCESS [51.185s]
> [INFO] Lens Examples . SUCCESS [9.779s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.037s]
> [INFO] Lens Distribution . SUCCESS [8.573s]
> [INFO] Lens ML Lib ... SUCCESS [1:20.846s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.013s]
> [INFO] Lens Regression ... SUCCESS [12.349s]
> [INFO] Lens UI ... SUCCESS [27.294s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:51.394s
> [INFO] Finished at: Sat Nov 28 04:07:51 UTC 2015
> [INFO] Final Memory: 199M/2040M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>

[jira] [Updated] (LENS-270) The exception thrown for no candidate fact should contain only brief error

2015-12-13 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-270:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Committed. Thanks [~sushilmohanty]

> The exception thrown for no candidate fact should contain only brief error
> --
>
> Key: LENS-270
> URL: https://issues.apache.org/jira/browse/LENS-270
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Sushil Mohanty
> Fix For: 2.5
>
> Attachments: LENS-270_2.patch, LENS-270_3.patch, LENS-270_4.patch
>
>
> The exception thrown for no candidate fact table can answer should contain 
> only brief error and detail error should be part of query status details.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-270) The exception thrown for no candidate fact should contain only brief error

2015-12-13 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055501#comment-15055501
 ] 

Hudson commented on LENS-270:
-

SUCCESS: Integrated in Lens-Commit-Java8 #68 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/68/])
LENS-270 : The exception thrown for no candidate fact should contain 
(amareshwari: rev 36166a2e58a2a89bd97dc8595cb7920fbf4253d8)
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java
* 
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java
* 
lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java


> The exception thrown for no candidate fact should contain only brief error
> --
>
> Key: LENS-270
> URL: https://issues.apache.org/jira/browse/LENS-270
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Sushil Mohanty
> Fix For: 2.5
>
> Attachments: LENS-270_2.patch, LENS-270_3.patch, LENS-270_4.patch
>
>
> The exception thrown for no candidate fact table can answer should contain 
> only brief error and detail error should be part of query status details.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40761: Query Completion email missing for some queries

2015-12-13 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40761/#review110176
---



lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java
 (lines 112 - 116)


possible checkstyle error with no whitespace around `{` and `}`.



lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java
 (lines 145 - 147)


suggestion: `@getter`


- Rajat Khandelwal


On Dec. 14, 2015, 9:40 a.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40761/
> ---
> 
> (Updated Dec. 14, 2015, 9:40 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-887
> https://issues.apache.org/jira/browse/LENS-887
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Initial Changes (as discussed in JIRA) 
> + disabled core pool timeout for AsyncEventListeners (since pool had only 
> single thread)
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java
>  547c008 
>   lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 
> a276828 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 
> 110624a 
>   lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 
> f568b17 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 
> 702a529 
> 
> Diff: https://reviews.apache.org/r/40761/diff/
> 
> 
> Testing
> ---
> 
> > Verified Build .
> > Verified new Thread Names while debugging.
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.085s]
> [INFO] Lens .. SUCCESS [2.889s]
> [INFO] Lens API .. SUCCESS [25.083s]
> [INFO] Lens API for server and extensions  SUCCESS [23.336s]
> [INFO] Lens Cube . SUCCESS [5:57.544s]
> [INFO] Lens DB storage ... SUCCESS [20.762s]
> [INFO] Lens Query Library  SUCCESS [15.393s]
> [INFO] Lens Hive Driver .. SUCCESS [2:50.461s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.760s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.248s]
> [INFO] Lens Server ... SUCCESS [9:50.223s]
> [INFO] Lens client ... SUCCESS [36.590s]
> [INFO] Lens CLI .. SUCCESS [51.185s]
> [INFO] Lens Examples . SUCCESS [9.779s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [1.037s]
> [INFO] Lens Distribution . SUCCESS [8.573s]
> [INFO] Lens ML Lib ... SUCCESS [1:20.846s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.013s]
> [INFO] Lens Regression ... SUCCESS [12.349s]
> [INFO] Lens UI ... SUCCESS [27.294s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:51.394s
> [INFO] Finished at: Sat Nov 28 04:07:51 UTC 2015
> [INFO] Final Memory: 199M/2040M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>