[jira] [Commented] (LENS-1325) Support encoded urls for query HTTP notifications

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590926#comment-15590926
 ] 

Hudson commented on LENS-1325:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit #1363 (See 
[https://builds.apache.org/job/Lens-Commit/1363/])
LENS-1325 : Add tests and document passing encoded urls for query http 
(amareshwari: rev 54961853fb6762431f5e20d0af95be3bb00d2afa)
* (edit) src/site/apt/admin/session-config.apt
* (edit) lens-server/src/main/resources/lenssession-default.xml
* (edit) 
lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java
* (edit) 
lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java
* (edit) 
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java


> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1325.v2.patch
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123&abs=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1325) Support encoded urls for query HTTP notifications

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590838#comment-15590838
 ] 

Hudson commented on LENS-1325:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit-Java8 #280 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/280/])
LENS-1325 : Add tests and document passing encoded urls for query http 
(amareshwari: rev 54961853fb6762431f5e20d0af95be3bb00d2afa)
* (edit) src/site/apt/admin/session-config.apt
* (edit) 
lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java
* (edit) lens-server/src/main/resources/lenssession-default.xml
* (edit) 
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
* (edit) 
lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java


> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1325.v2.patch
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123&abs=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1325) Support encoded urls for query HTTP notifications

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1325:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Committed. Thanks [~puneet884]

> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1325.v2.patch
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123&abs=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1357) Seeing NPE in stop lens services after a failed attempt of start

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1357:
--
Status: Open  (was: Patch Available)

[~prongs] Seems test failures are related. please look at them.

> Seeing NPE in stop lens services after a failed attempt of start
> 
>
> Key: LENS-1357
> URL: https://issues.apache.org/jira/browse/LENS-1357
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1357.01.patch, LENS-1357.02.patch, 
> LENS-1357.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1361) Ignore DB failure while scheduler startup.

[Amareshwari Sriramadasu (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590699#comment-15590699
 ] 

Amareshwari Sriramadasu commented on LENS-1361:
---

bq.   log.error("Error Initialising Scheduler-service", e);
bq.+  throw new IllegalStateException("Exception happened while 
Initialising Scheduler-Service", e);

This would make lens server not to come up. I don't think we want to do that, 
instead it should mark scheduler service unhealthy. 

> Ignore DB failure while scheduler startup.
> --
>
> Key: LENS-1361
> URL: https://issues.apache.org/jira/browse/LENS-1361
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: ignore-db.patch, ignore-db.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1325) Support encoded urls for query HTTP notifications

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589106#comment-15589106
 ] 

Hadoop QA commented on LENS-1325:
-

Applied patch: 
[lens-1325.v2.patch|https://issues.apache.org/jira/secure/attachment/12834150/lens-1325.v2.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1123/

> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1325.v2.patch
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123&abs=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1361) Ignore DB failure while scheduler startup.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589101#comment-15589101
 ] 

Hadoop QA commented on LENS-1361:
-

Applied patch: 
[ignore-db.patch|https://issues.apache.org/jira/secure/attachment/12834158/ignore-db.patch],
 
[LENS-1360.05.patch|https://issues.apache.org/jira/secure/attachment/12834181/LENS-1360.05.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1119/

> Ignore DB failure while scheduler startup.
> --
>
> Key: LENS-1361
> URL: https://issues.apache.org/jira/browse/LENS-1361
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: ignore-db.patch, ignore-db.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589083#comment-15589083
 ] 

Hadoop QA commented on LENS-1359:
-

Applied patch: 
[LENS-1359.08.patch|https://issues.apache.org/jira/secure/attachment/12834157/LENS-1359.08.patch],
 
[LENS-1360.05.patch|https://issues.apache.org/jira/secure/attachment/12834181/LENS-1360.05.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1120/

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch, LENS-1359.08.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1325) Support encoded urls for query HTTP notifications

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589059#comment-15589059
 ] 

Hadoop QA commented on LENS-1325:
-

Applied patch: 
[lens-1325.v2.patch|https://issues.apache.org/jira/secure/attachment/12834150/lens-1325.v2.patch],
 
[LENS-1360.05.patch|https://issues.apache.org/jira/secure/attachment/12834181/LENS-1360.05.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1121/

> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1325.v2.patch
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123&abs=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589051#comment-15589051
 ] 

Hadoop QA commented on LENS-1360:
-

Applied patch: 
[LENS-1360.05.patch|https://issues.apache.org/jira/secure/attachment/12834181/LENS-1360.05.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1122/

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch, 
> LENS-1360.04.patch, LENS-1360.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1325) Support encoded urls for query HTTP notifications

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589046#comment-15589046
 ] 

Hadoop QA commented on LENS-1325:
-

Applied patch: 
[lens-1325.v2.patch|https://issues.apache.org/jira/secure/attachment/12834150/lens-1325.v2.patch],
 
[LENS-1360.05.patch|https://issues.apache.org/jira/secure/attachment/12834181/LENS-1360.05.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1124/

> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1325.v2.patch
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123&abs=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1325) Support encoded urls for query HTTP notifications

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589005#comment-15589005
 ] 

Hadoop QA commented on LENS-1325:
-

Applied patch: 
[lens-1325.v2.patch|https://issues.apache.org/jira/secure/attachment/12834150/lens-1325.v2.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1115/

> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1325.v2.patch
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123&abs=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589001#comment-15589001
 ] 

Rajat Khandelwal commented on LENS-1360:


Taking patch from reviewboard and attaching

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch, 
> LENS-1360.04.patch, LENS-1360.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1360:
---
Attachment: LENS-1360.05.patch

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch, 
> LENS-1360.04.patch, LENS-1360.05.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52926: LENS-1360: org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52926/
---

(Updated Oct. 19, 2016, 8:33 p.m.)


Review request for lens.


Bugs: LENS-1360
https://issues.apache.org/jira/browse/LENS-1360


Repository: lens


Description
---


Diffs (updated)
-

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
82e023146c0290b5a1e0146a550b6f7a55e7e1b2 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
a402f91832bbb7340dfe1ec271f7eee36ce6d758 
  lens-driver-jdbc/src/test/resources/logback.xml PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 64c7145e5136124093ba2b468b959bde3eacd97e 

Diff: https://reviews.apache.org/r/52926/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588970#comment-15588970
 ] 

Hadoop QA commented on LENS-1359:
-

Applied patch: 
[LENS-1359.08.patch|https://issues.apache.org/jira/secure/attachment/12834157/LENS-1359.08.patch],
 
[LENS-1360.04.patch|https://issues.apache.org/jira/secure/attachment/12834168/LENS-1360.04.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1116/

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch, LENS-1359.08.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1325) Support encoded urls for query HTTP notifications

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588969#comment-15588969
 ] 

Hadoop QA commented on LENS-1325:
-

Applied patch: 
[lens-1325.v2.patch|https://issues.apache.org/jira/secure/attachment/12834150/lens-1325.v2.patch],
 
[LENS-1360.04.patch|https://issues.apache.org/jira/secure/attachment/12834168/LENS-1360.04.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1113/

> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1325.v2.patch
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123&abs=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588967#comment-15588967
 ] 

Hadoop QA commented on LENS-1360:
-

Applied patch: 
[LENS-1360.04.patch|https://issues.apache.org/jira/secure/attachment/12834168/LENS-1360.04.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1114/

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch, 
> LENS-1360.04.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1361) Ignore DB failure while scheduler startup.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588962#comment-15588962
 ] 

Hadoop QA commented on LENS-1361:
-

Applied patch: 
[ignore-db.patch|https://issues.apache.org/jira/secure/attachment/12834158/ignore-db.patch],
 
[LENS-1360.04.patch|https://issues.apache.org/jira/secure/attachment/12834168/LENS-1360.04.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1112/

> Ignore DB failure while scheduler startup.
> --
>
> Key: LENS-1361
> URL: https://issues.apache.org/jira/browse/LENS-1361
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: ignore-db.patch, ignore-db.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1325) Support encoded urls for query HTTP notifications

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588891#comment-15588891
 ] 

Hadoop QA commented on LENS-1325:
-

Applied patch: 
[lens-1325.v2.patch|https://issues.apache.org/jira/secure/attachment/12834150/lens-1325.v2.patch],
 
[LENS-1360.03.patch|https://issues.apache.org/jira/secure/attachment/12834144/LENS-1360.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1107/

> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1325.v2.patch
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123&abs=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588911#comment-15588911
 ] 

Hadoop QA commented on LENS-1360:
-

Applied patch: 
[LENS-1360.04.patch|https://issues.apache.org/jira/secure/attachment/12834168/LENS-1360.04.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build//

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch, 
> LENS-1360.04.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588907#comment-15588907
 ] 

Hadoop QA commented on LENS-1359:
-

Applied patch: 
[LENS-1359.08.patch|https://issues.apache.org/jira/secure/attachment/12834157/LENS-1359.08.patch],
 
[LENS-1360.03.patch|https://issues.apache.org/jira/secure/attachment/12834144/LENS-1360.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1108/

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch, LENS-1359.08.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588866#comment-15588866
 ] 

Hadoop QA commented on LENS-1360:
-

Applied patch: 
[LENS-1360.03.patch|https://issues.apache.org/jira/secure/attachment/12834144/LENS-1360.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1109/

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch, 
> LENS-1360.04.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1361) Ignore DB failure while scheduler startup.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588844#comment-15588844
 ] 

Hadoop QA commented on LENS-1361:
-

Applied patch: 
[ignore-db.patch|https://issues.apache.org/jira/secure/attachment/12834158/ignore-db.patch],
 
[LENS-1360.04.patch|https://issues.apache.org/jira/secure/attachment/12834168/LENS-1360.04.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1110/

> Ignore DB failure while scheduler startup.
> --
>
> Key: LENS-1361
> URL: https://issues.apache.org/jira/browse/LENS-1361
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: ignore-db.patch, ignore-db.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588794#comment-15588794
 ] 

Rajat Khandelwal commented on LENS-1360:


Taking patch from reviewboard and attaching

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch, 
> LENS-1360.04.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1360:
---
Attachment: LENS-1360.04.patch

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch, 
> LENS-1360.04.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52926: LENS-1360: org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52926/
---

(Updated Oct. 19, 2016, 7:06 p.m.)


Review request for lens.


Bugs: LENS-1360
https://issues.apache.org/jira/browse/LENS-1360


Repository: lens


Description
---


Diffs (updated)
-

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
82e023146c0290b5a1e0146a550b6f7a55e7e1b2 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
a402f91832bbb7340dfe1ec271f7eee36ce6d758 
  lens-driver-jdbc/src/test/resources/logback.xml PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 64c7145e5136124093ba2b468b959bde3eacd97e 

Diff: https://reviews.apache.org/r/52926/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-1361) Ignore DB failure while scheduler startup.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588780#comment-15588780
 ] 

Hadoop QA commented on LENS-1361:
-

Applied patch: 
[ignore-db.patch|https://issues.apache.org/jira/secure/attachment/12834158/ignore-db.patch],
 
[LENS-1360.03.patch|https://issues.apache.org/jira/secure/attachment/12834144/LENS-1360.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1106/

> Ignore DB failure while scheduler startup.
> --
>
> Key: LENS-1361
> URL: https://issues.apache.org/jira/browse/LENS-1361
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: ignore-db.patch, ignore-db.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1325) Support encoded urls for query HTTP notifications

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588698#comment-15588698
 ] 

Hadoop QA commented on LENS-1325:
-

Applied patch: 
[lens-1325.v2.patch|https://issues.apache.org/jira/secure/attachment/12834150/lens-1325.v2.patch],
 
[LENS-1360.03.patch|https://issues.apache.org/jira/secure/attachment/12834144/LENS-1360.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1105/

> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1325.v2.patch
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123&abs=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1327) Handle Data delay for scheduled jobs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588688#comment-15588688
 ] 

Hadoop QA commented on LENS-1327:
-

Applied patch: 
[0001-Data-dealy.patch|https://issues.apache.org/jira/secure/attachment/12833686/0001-Data-dealy.patch],
 
[LENS-1360.03.patch|https://issues.apache.org/jira/secure/attachment/12834144/LENS-1360.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1104/

> Handle Data delay for scheduled jobs
> 
>
> Key: LENS-1327
> URL: https://issues.apache.org/jira/browse/LENS-1327
> Project: Apache Lens
>  Issue Type: Sub-task
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: 0001-Data-dealy.patch, data-delay.patch, 
> data-delay.patch, data-delay.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588673#comment-15588673
 ] 

Hadoop QA commented on LENS-1359:
-

Applied patch: 
[LENS-1359.08.patch|https://issues.apache.org/jira/secure/attachment/12834157/LENS-1359.08.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1102/

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch, LENS-1359.08.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1361) Ignore DB failure while scheduler startup.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588671#comment-15588671
 ] 

Hadoop QA commented on LENS-1361:
-

Applied patch: 
[ignore-db.patch|https://issues.apache.org/jira/secure/attachment/12833930/ignore-db.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1101/

> Ignore DB failure while scheduler startup.
> --
>
> Key: LENS-1361
> URL: https://issues.apache.org/jira/browse/LENS-1361
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: ignore-db.patch, ignore-db.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1327) Handle Data delay for scheduled jobs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588650#comment-15588650
 ] 

Hadoop QA commented on LENS-1327:
-

Applied patch: 
[0001-Data-dealy.patch|https://issues.apache.org/jira/secure/attachment/12833686/0001-Data-dealy.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1103/

> Handle Data delay for scheduled jobs
> 
>
> Key: LENS-1327
> URL: https://issues.apache.org/jira/browse/LENS-1327
> Project: Apache Lens
>  Issue Type: Sub-task
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: 0001-Data-dealy.patch, data-delay.patch, 
> data-delay.patch, data-delay.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588611#comment-15588611
 ] 

Hadoop QA commented on LENS-1360:
-

Applied patch: 
[LENS-1360.03.patch|https://issues.apache.org/jira/secure/attachment/12834144/LENS-1360.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1098/

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1327) Handle Data delay for scheduled jobs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588600#comment-15588600
 ] 

Hadoop QA commented on LENS-1327:
-

Applied patch: 
[0001-Data-dealy.patch|https://issues.apache.org/jira/secure/attachment/12833686/0001-Data-dealy.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1100/

> Handle Data delay for scheduled jobs
> 
>
> Key: LENS-1327
> URL: https://issues.apache.org/jira/browse/LENS-1327
> Project: Apache Lens
>  Issue Type: Sub-task
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: 0001-Data-dealy.patch, data-delay.patch, 
> data-delay.patch, data-delay.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1325) Support encoded urls for query HTTP notifications

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588585#comment-15588585
 ] 

Hadoop QA commented on LENS-1325:
-

Applied patch: 
[lens-1325.v2.patch|https://issues.apache.org/jira/secure/attachment/12834150/lens-1325.v2.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1099/

> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1325.v2.patch
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123&abs=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1361) Ignore DB failure while scheduler startup.

[Lavkesh Lahngir (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588586#comment-15588586
 ] 

Lavkesh Lahngir commented on LENS-1361:
---

Init() should throw an error if there are errors. Table creation will not throw 
an error, that will result in internal server error while API calls. 

 

> Ignore DB failure while scheduler startup.
> --
>
> Key: LENS-1361
> URL: https://issues.apache.org/jira/browse/LENS-1361
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: ignore-db.patch, ignore-db.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1361) Ignore DB failure while scheduler startup.

[Lavkesh Lahngir (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1361:
--
Attachment: ignore-db.patch

> Ignore DB failure while scheduler startup.
> --
>
> Key: LENS-1361
> URL: https://issues.apache.org/jira/browse/LENS-1361
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: ignore-db.patch, ignore-db.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1361) Ignore DB failure while scheduler startup.

[Lavkesh Lahngir (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1361:
--
Attachment: (was: ignore-db.patch)

> Ignore DB failure while scheduler startup.
> --
>
> Key: LENS-1361
> URL: https://issues.apache.org/jira/browse/LENS-1361
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: ignore-db.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588578#comment-15588578
 ] 

Rajat Khandelwal commented on LENS-1359:


Taking patch from reviewboard and attaching

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch, LENS-1359.08.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1359:
---
Attachment: LENS-1359.08.patch

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch, LENS-1359.08.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1361) Ignore DB failure while scheduler startup.

[Lavkesh Lahngir (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1361:
--
Status: Open  (was: Patch Available)

> Ignore DB failure while scheduler startup.
> --
>
> Key: LENS-1361
> URL: https://issues.apache.org/jira/browse/LENS-1361
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: ignore-db.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1361) Ignore DB failure while scheduler startup.

[Lavkesh Lahngir (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1361:
--
Attachment: ignore-db.patch

> Ignore DB failure while scheduler startup.
> --
>
> Key: LENS-1361
> URL: https://issues.apache.org/jira/browse/LENS-1361
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: ignore-db.patch, ignore-db.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52924: LENS-1359: Add driver hooks for user based filtering of queries

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/
---

(Updated Oct. 19, 2016, 5:36 p.m.)


Review request for lens.


Bugs: LENS-1359
https://issues.apache.org/jira/browse/LENS-1359


Repository: lens


Description
---


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/parse/Parser.java PRE-CREATION 
  lens-driver-hive/src/main/resources/hivedriver-default.xml 
f5fd3bb20b9d6b82292c4483d860ea14c8104c5c 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 
43b33f331f4d9017d76bccbe0f6936aaeb184f8f 
  
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
 961ec4ec781d3d7fd0f28edc4f23e9b39549592f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
3ae59c6ca126f0a3535974352adf97e7a495838f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 8f30aa06ab234cedb53acb17544210ba4190ab53 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
 69a1a0b7ce57c24602a17ea7c97c0664a77c6568 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
 f8a9ee07d8c8b737a41de339ab44ca7752c90748 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
146223942d05cfd952599297144e2a6bc02df273 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
 4f1f2eb99ed0bec8e6e471a9723a6b002a092202 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java
 476855021288ff0d91762d240cb04c8aea9d302b 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java
 4712f11e94f93d34b71f4f3ddb7c19af003d9fca 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java
 PRE-CREATION 
  
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
 f70979abf7c44d3b4ed3588628de5a7517adfa81 
  lens-server/src/main/resources/lensserver-default.xml 
8e5fe8a2b7f9ddfcadef104189b89c40ca1b3df6 
  pom.xml 4928c1fa840fc51e4383ed4803f94102aa833221 
  src/site/apt/admin/config.apt f22fc0c36f53fa7227dc990c58a079e66630a2a1 
  src/site/apt/admin/hivedriver-config.apt 
b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 

Diff: https://reviews.apache.org/r/52924/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588560#comment-15588560
 ] 

Rajat Khandelwal commented on LENS-1359:


The change is incompatible, as the package name of DriverQueryHook and 
NoOpDriverQueryHook is changed from org.apache.lens.server.api.driver to 
org.apache.lens.server.api.driver.hooks


> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1359) Add driver hooks for user based filtering of queries

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1359:
---
Labels: incompatible  (was: )

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1361) Ignore DB failure while scheduler startup.

[Amareshwari Sriramadasu (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588504#comment-15588504
 ] 

Amareshwari Sriramadasu commented on LENS-1361:
---

[~lavkesh], Can you take care of the consequences of not throwing exception? 
For ex : SchedulerServiceImpl.start()'s schedulerDAO.getInstanceRuns can throw 
NPE.

> Ignore DB failure while scheduler startup.
> --
>
> Key: LENS-1361
> URL: https://issues.apache.org/jira/browse/LENS-1361
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: ignore-db.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52924: LENS-1359: Add driver hooks for user based filtering of queries

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/#review153254
---




lens-driver-hive/src/main/resources/hivedriver-default.xml (line 38)






lens-driver-hive/src/main/resources/hivedriver-default.xml (line 38)


We can stop supporting the old property "lens.driver.hive.query.hook.class" 
since we are chnaging the package anyway (incomptible change)



lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java
 (line 22)


Package change is an incompatible change for people implementing their 
hooks. Can we leave and comment of JIRA and also tag it incompatible



lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java
 (line 36)


Comment needs update.



lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java
 (line 131)


This  should be the driver that created this hook (and not selected driver)



lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java
 (line 74)


Can we move the  parser to non error package ?


- Puneet Gupta


On Oct. 18, 2016, 2:35 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52924/
> ---
> 
> (Updated Oct. 18, 2016, 2:35 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1359
> https://issues.apache.org/jira/browse/LENS-1359
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/parse/Parser.java 
> PRE-CREATION 
>   lens-driver-hive/src/main/resources/hivedriver-default.xml 
> f5fd3bb20b9d6b82292c4483d860ea14c8104c5c 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  43b33f331f4d9017d76bccbe0f6936aaeb184f8f 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
>  961ec4ec781d3d7fd0f28edc4f23e9b39549592f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  3ae59c6ca126f0a3535974352adf97e7a495838f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
>  8f30aa06ab234cedb53acb17544210ba4190ab53 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
>  69a1a0b7ce57c24602a17ea7c97c0664a77c6568 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
>  f8a9ee07d8c8b737a41de339ab44ca7752c90748 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java
>  146223942d05cfd952599297144e2a6bc02df273 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
>  4f1f2eb99ed0bec8e6e471a9723a6b002a092202 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java
>  476855021288ff0d91762d240cb04c8aea9d302b 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java
>  4712f11e94f93d34b71f4f3ddb7c19af003d9fca 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
>  f70979abf7c44d3b4ed3588628de5a7517adfa81 
>   lens-server/src/main/resources/lensserver-default.xml 
> 8e5fe8a2b7f9ddf

[jira] [Updated] (LENS-1325) Support encoded urls for query HTTP notifications

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1325:
---
Status: Patch Available  (was: In Progress)

> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1325.v2.patch
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123&abs=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1325) Support encoded urls for query HTTP notifications

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1325:
---
Attachment: lens-1325.v2.patch

> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1325.v2.patch
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123&abs=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1325) Support encoded urls for query HTTP notifications

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588492#comment-15588492
 ] 

Puneet Gupta commented on LENS-1325:


https://reviews.apache.org/r/52341

> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123&abs=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52926: LENS-1360: org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52926/#review153266
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Oct. 19, 2016, 11:03 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52926/
> ---
> 
> (Updated Oct. 19, 2016, 11:03 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1360
> https://issues.apache.org/jira/browse/LENS-1360
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 82e023146c0290b5a1e0146a550b6f7a55e7e1b2 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  a402f91832bbb7340dfe1ec271f7eee36ce6d758 
>   lens-driver-jdbc/src/test/resources/logback.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52926/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Updated] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1360:
---
Attachment: LENS-1360.03.patch

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588433#comment-15588433
 ] 

Rajat Khandelwal commented on LENS-1360:


Taking patch from reviewboard and attaching

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52926: LENS-1360: org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52926/
---

(Updated Oct. 19, 2016, 4:33 p.m.)


Review request for lens.


Bugs: LENS-1360
https://issues.apache.org/jira/browse/LENS-1360


Repository: lens


Description
---


Diffs (updated)
-

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
82e023146c0290b5a1e0146a550b6f7a55e7e1b2 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
a402f91832bbb7340dfe1ec271f7eee36ce6d758 
  lens-driver-jdbc/src/test/resources/logback.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/52926/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-1361) Ignore DB failure while scheduler startup.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588425#comment-15588425
 ] 

Hadoop QA commented on LENS-1361:
-

Applied patch: 
[ignore-db.patch|https://issues.apache.org/jira/secure/attachment/12833930/ignore-db.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1096/

> Ignore DB failure while scheduler startup.
> --
>
> Key: LENS-1361
> URL: https://issues.apache.org/jira/browse/LENS-1361
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: ignore-db.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1327) Handle Data delay for scheduled jobs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588353#comment-15588353
 ] 

Hadoop QA commented on LENS-1327:
-

Applied patch: 
[0001-Data-dealy.patch|https://issues.apache.org/jira/secure/attachment/12833686/0001-Data-dealy.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1097/

> Handle Data delay for scheduled jobs
> 
>
> Key: LENS-1327
> URL: https://issues.apache.org/jira/browse/LENS-1327
> Project: Apache Lens
>  Issue Type: Sub-task
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: 0001-Data-dealy.patch, data-delay.patch, 
> data-delay.patch, data-delay.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52341/#review153263
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Oct. 19, 2016, 9:50 a.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52341/
> ---
> 
> (Updated Oct. 19, 2016, 9:50 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-1325
> https://issues.apache.org/jira/browse/lens-1325
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 1. Added test cases to test multiple query parsms 
> 2. Test with complex param value that requires encoding at the time of 
> submission
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java
>  1760bec 
>   lens-server/src/main/resources/lenssession-default.xml b6bfa2e 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java
>  6a57b20 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 415f56f 
>   src/site/apt/admin/session-config.apt c4b3c04 
> 
> Diff: https://reviews.apache.org/r/52341/diff/
> 
> 
> Testing
> ---
> 
> mvn  test 
> -Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion"
>  -pl lens-server
> 
> 
>  T E S T S
> ---
> Running org.apache.lens.server.query.TestQueryService
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - 
> in org.apache.lens.server.query.TestQueryService
> 
> Results :
> 
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> **Logs form TestQueryNotifictaionResource show params access_token and data 
> are recived correctly** 
> 
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
>  Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
> queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
>  SUCCESSFUL
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
>  Message: Query is successful!
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
>  Result Set Available: true
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
>  eventtype:FINISHED access_token:ABC123 data:null
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
>  28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
> --
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
>  Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
> queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
>  SUCCESSFUL
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
>  Message: Query is successful!
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
>  Result Set Available: true
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
>  eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc
> lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
>  28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
> 
> 
> **Logs from lens server show succes for both the urls**
> 
> puneet.gupta$ grep "QueryEventHttpNotifier - FINISHED HTTP Notification sent 
> successfully" lens-server/target/test.log
> 28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
> [QueryEndHttpNotifier_AsyncThread-2] INFO  
> org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
> Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
> to 
> http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123.
>  Response code 204
> 28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
> [QueryEndHttpNotifier_AsyncThread-2] INFO  
> org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
> Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
> to 
> http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123&data=x%3C%3Eyz%2C%22abc.
>  Response code 204
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>

Re: Review Request 52926: LENS-1360: org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52926/#review153259
---




lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
(line 885)


It is almost impossible for this query to finish successfully, before user 
can call cancel.


- Amareshwari Sriramadasu


On Oct. 17, 2016, 11:09 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52926/
> ---
> 
> (Updated Oct. 17, 2016, 11:09 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1360
> https://issues.apache.org/jira/browse/LENS-1360
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
> 82e023146c0290b5a1e0146a550b6f7a55e7e1b2 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
>  a402f91832bbb7340dfe1ec271f7eee36ce6d758 
>   lens-driver-jdbc/src/test/resources/logback.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52926/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52341/
---

(Updated Oct. 19, 2016, 9:50 a.m.)


Review request for lens.


Changes
---

- Fixed Review comment 
- Merged with master again


Bugs: lens-1325
https://issues.apache.org/jira/browse/lens-1325


Repository: lens


Description
---

1. Added test cases to test multiple query parsms 
2. Test with complex param value that requires encoding at the time of 
submission


Diffs (updated)
-

  
lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java
 1760bec 
  lens-server/src/main/resources/lenssession-default.xml b6bfa2e 
  
lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java
 6a57b20 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
415f56f 
  src/site/apt/admin/session-config.apt c4b3c04 

Diff: https://reviews.apache.org/r/52341/diff/


Testing
---

mvn  test 
-Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion" 
-pl lens-server


 T E S T S
---
Running org.apache.lens.server.query.TestQueryService
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - in 
org.apache.lens.server.query.TestQueryService

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0


**Logs form TestQueryNotifictaionResource show params access_token and data are 
recived correctly** 

lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
 Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
 SUCCESSFUL
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
 Message: Query is successful!
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
 Result Set Available: true
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
 eventtype:FINISHED access_token:ABC123 data:null
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log
--
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt:
 Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a 
queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status:
 SUCCESSFUL
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status
 Message: Query is successful!
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is
 Result Set Available: true
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-
 eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc
lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep
 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log


**Logs from lens server show succes for both the urls**

puneet.gupta$ grep "QueryEventHttpNotifier - FINISHED HTTP Notification sent 
successfully" lens-server/target/test.log
28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
[QueryEndHttpNotifier_AsyncThread-2] INFO  
org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
to 
http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123.
 Response code 204
28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a 
[QueryEndHttpNotifier_AsyncThread-2] INFO  
org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP 
Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a 
to 
http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123&data=x%3C%3Eyz%2C%22abc.
 Response code 204


Thanks,

Puneet Gupta

Re: Review Request 52819: LENS-1357: Seeing NPE in stop lens services after a failed attempt of start

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52819/#review153256
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Oct. 17, 2016, 5:47 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52819/
> ---
> 
> (Updated Oct. 17, 2016, 5:47 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1357
> https://issues.apache.org/jira/browse/LENS-1357
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 
> 7ff5cbbb87a0093b0a708ddf3c580e1aebf23d45 
> 
> Diff: https://reviews.apache.org/r/52819/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>