Re: Review Request 53217: LENS-968 : Timeout long running queries

2016-11-02 Thread Amareshwari Sriramadasu 


> On Oct. 31, 2016, 12:46 a.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java,
> >  line 218
> > 
> >
> > Can we add it to health status as well?
> > 
> > Can we termintate queryExpirer when query service is stopped?  Seems 
> > thread is not getting terminated now.

Thanks for checking this. Fixed it now.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/#review154240
---


On Nov. 2, 2016, 7:44 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53217/
> ---
> 
> (Updated Nov. 2, 2016, 7:44 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-968
> https://issues.apache.org/jira/browse/LENS-968
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Adds configurable timeout for queries, which is overridable at driver level 
> and even at query level.
> Adds a period checker which checks if any of queries timedout and canel them.
> 
> 
> Diffs
> -
> 
>   lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  3ae59c6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  64c7145 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java
>  2a2963f 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  b5e996f 
>   lens-server/src/main/resources/lensserver-default.xml 8e5fe8a 
>   lens-server/src/main/resources/lenssession-default.xml 9a8f9da 
>   
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java
>  5a8d5e6 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> ecbd689 
>   lens-server/src/test/resources/lens-site.xml d96659f 
>   lens-server/src/test/resources/logback.xml 6b91a77 
>   src/site/apt/admin/config.apt f22fc0c 
>   src/site/apt/admin/esdriver-config.apt ce952ae 
>   src/site/apt/admin/jdbcdriver-config.apt c64d6ee 
>   src/site/apt/admin/session-config.apt d480f88 
> 
> Diff: https://reviews.apache.org/r/53217/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.484s]
> [INFO] Lens .. SUCCESS [2.843s]
> [INFO] Lens API .. SUCCESS [21.049s]
> [INFO] Lens API for server and extensions  SUCCESS [19.230s]
> [INFO] Lens Cube . SUCCESS 
> [14:06.805s]
> [INFO] Lens DB storage ... SUCCESS [16.439s]
> [INFO] Lens Query Library  SUCCESS [12.739s]
> [INFO] Lens Hive Driver .. SUCCESS [1:15.184s]
> [INFO] Lens Driver for JDBC .. SUCCESS [39.351s]
> [INFO] Lens Elastic Search Driver  SUCCESS [19.958s]
> [INFO] Lens Server ... SUCCESS 
> [16:28.932s]
> [INFO] Lens client ... SUCCESS [1:21.876s]
> [INFO] Lens CLI .. SUCCESS [1:12.501s]
> [INFO] Lens Examples . SUCCESS [8.167s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.618s]
> [INFO] Lens Distribution . SUCCESS [8.981s]
> [INFO] Lens ML Lib ... SUCCESS [1:02.132s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.106s]
> [INFO] Lens Regression ... SUCCESS [12.315s]
> [INFO] Lens UI ... SUCCESS [30.001s]
> [INFO] Lens Contrib .. SUCCESS [0.328s]
> [INFO] Lens Contributed Clients .. SUCCESS [0.325s]
> [INFO] Lens Python Client  SUCCESS [0.334s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 38:44.416s
> [INFO] Finished at: Thu Oct 27 07:21:56 UTC 2016
> [INFO] Final Memory: 272M/3119M
> [INFO] 
> --

Re: Review Request 53217: LENS-968 : Timeout long running queries

2016-11-02 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/
---

(Updated Nov. 2, 2016, 7:44 a.m.)


Review request for lens.


Changes
---

Fixed review comments


Bugs: LENS-968
https://issues.apache.org/jira/browse/LENS-968


Repository: lens


Description
---

Adds configurable timeout for queries, which is overridable at driver level and 
even at query level.
Adds a period checker which checks if any of queries timedout and canel them.


Diffs (updated)
-

  lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3 
  lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
3ae59c6 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 64c7145 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 
2a2963f 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 b5e996f 
  lens-server/src/main/resources/lensserver-default.xml 8e5fe8a 
  lens-server/src/main/resources/lenssession-default.xml 9a8f9da 
  
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 
5a8d5e6 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
ecbd689 
  lens-server/src/test/resources/lens-site.xml d96659f 
  lens-server/src/test/resources/logback.xml 6b91a77 
  src/site/apt/admin/config.apt f22fc0c 
  src/site/apt/admin/esdriver-config.apt ce952ae 
  src/site/apt/admin/jdbcdriver-config.apt c64d6ee 
  src/site/apt/admin/session-config.apt d480f88 

Diff: https://reviews.apache.org/r/53217/diff/


Testing
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.484s]
[INFO] Lens .. SUCCESS [2.843s]
[INFO] Lens API .. SUCCESS [21.049s]
[INFO] Lens API for server and extensions  SUCCESS [19.230s]
[INFO] Lens Cube . SUCCESS [14:06.805s]
[INFO] Lens DB storage ... SUCCESS [16.439s]
[INFO] Lens Query Library  SUCCESS [12.739s]
[INFO] Lens Hive Driver .. SUCCESS [1:15.184s]
[INFO] Lens Driver for JDBC .. SUCCESS [39.351s]
[INFO] Lens Elastic Search Driver  SUCCESS [19.958s]
[INFO] Lens Server ... SUCCESS [16:28.932s]
[INFO] Lens client ... SUCCESS [1:21.876s]
[INFO] Lens CLI .. SUCCESS [1:12.501s]
[INFO] Lens Examples . SUCCESS [8.167s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.618s]
[INFO] Lens Distribution . SUCCESS [8.981s]
[INFO] Lens ML Lib ... SUCCESS [1:02.132s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.106s]
[INFO] Lens Regression ... SUCCESS [12.315s]
[INFO] Lens UI ... SUCCESS [30.001s]
[INFO] Lens Contrib .. SUCCESS [0.328s]
[INFO] Lens Contributed Clients .. SUCCESS [0.325s]
[INFO] Lens Python Client  SUCCESS [0.334s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 38:44.416s
[INFO] Finished at: Thu Oct 27 07:21:56 UTC 2016
[INFO] Final Memory: 272M/3119M
[INFO] 


Thanks,

Amareshwari Sriramadasu

Re: Review Request 53217: LENS-968 : Timeout long running queries

2016-11-02 Thread Amareshwari Sriramadasu 


> On Nov. 2, 2016, 6:58 a.m., Puneet Gupta wrote:
> > lens-server/src/main/resources/lensserver-default.xml, line 296
> > 
> >
> > We might need a smaller default check interval if in most cases "query 
> > lens.query.timeout.millis" is very small.

Have kept the default to 1hr, as the default of query timeout is 1day. Have 
updated documentation to reduce the value if deployment expects lower values 
for query timeout. Otherwise, should we make the default to few seconds?


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/#review154118
---


On Nov. 2, 2016, 7:44 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53217/
> ---
> 
> (Updated Nov. 2, 2016, 7:44 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-968
> https://issues.apache.org/jira/browse/LENS-968
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Adds configurable timeout for queries, which is overridable at driver level 
> and even at query level.
> Adds a period checker which checks if any of queries timedout and canel them.
> 
> 
> Diffs
> -
> 
>   lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  3ae59c6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  64c7145 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java
>  2a2963f 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  b5e996f 
>   lens-server/src/main/resources/lensserver-default.xml 8e5fe8a 
>   lens-server/src/main/resources/lenssession-default.xml 9a8f9da 
>   
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java
>  5a8d5e6 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> ecbd689 
>   lens-server/src/test/resources/lens-site.xml d96659f 
>   lens-server/src/test/resources/logback.xml 6b91a77 
>   src/site/apt/admin/config.apt f22fc0c 
>   src/site/apt/admin/esdriver-config.apt ce952ae 
>   src/site/apt/admin/jdbcdriver-config.apt c64d6ee 
>   src/site/apt/admin/session-config.apt d480f88 
> 
> Diff: https://reviews.apache.org/r/53217/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.484s]
> [INFO] Lens .. SUCCESS [2.843s]
> [INFO] Lens API .. SUCCESS [21.049s]
> [INFO] Lens API for server and extensions  SUCCESS [19.230s]
> [INFO] Lens Cube . SUCCESS 
> [14:06.805s]
> [INFO] Lens DB storage ... SUCCESS [16.439s]
> [INFO] Lens Query Library  SUCCESS [12.739s]
> [INFO] Lens Hive Driver .. SUCCESS [1:15.184s]
> [INFO] Lens Driver for JDBC .. SUCCESS [39.351s]
> [INFO] Lens Elastic Search Driver  SUCCESS [19.958s]
> [INFO] Lens Server ... SUCCESS 
> [16:28.932s]
> [INFO] Lens client ... SUCCESS [1:21.876s]
> [INFO] Lens CLI .. SUCCESS [1:12.501s]
> [INFO] Lens Examples . SUCCESS [8.167s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.618s]
> [INFO] Lens Distribution . SUCCESS [8.981s]
> [INFO] Lens ML Lib ... SUCCESS [1:02.132s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.106s]
> [INFO] Lens Regression ... SUCCESS [12.315s]
> [INFO] Lens UI ... SUCCESS [30.001s]
> [INFO] Lens Contrib .. SUCCESS [0.328s]
> [INFO] Lens Contributed Clients .. SUCCESS [0.325s]
> [INFO] Lens Python Client  SUCCESS [0.334s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 38:44.416s
> [INFO] Finished at: Thu Oct 27 07:21:56 UTC

Re: Review Request 53217: LENS-968 : Timeout long running queries

2016-11-02 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/
---

(Updated Nov. 2, 2016, 7:47 a.m.)


Review request for lens.


Bugs: LENS-968
https://issues.apache.org/jira/browse/LENS-968


Repository: lens


Description
---

Adds configurable timeout for queries, which is overridable at driver level and 
even at query level.
Adds a period checker which checks if any of queries timedout and canel them.


Diffs (updated)
-

  lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3 
  lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
3ae59c6 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 64c7145 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 
2a2963f 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 b5e996f 
  lens-server/src/main/resources/lensserver-default.xml 8e5fe8a 
  lens-server/src/main/resources/lenssession-default.xml 9a8f9da 
  
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 
5a8d5e6 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
ecbd689 
  lens-server/src/test/resources/lens-site.xml d96659f 
  lens-server/src/test/resources/logback.xml 6b91a77 
  src/site/apt/admin/config.apt f22fc0c 
  src/site/apt/admin/esdriver-config.apt ce952ae 
  src/site/apt/admin/jdbcdriver-config.apt c64d6ee 
  src/site/apt/admin/session-config.apt d480f88 

Diff: https://reviews.apache.org/r/53217/diff/


Testing
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.484s]
[INFO] Lens .. SUCCESS [2.843s]
[INFO] Lens API .. SUCCESS [21.049s]
[INFO] Lens API for server and extensions  SUCCESS [19.230s]
[INFO] Lens Cube . SUCCESS [14:06.805s]
[INFO] Lens DB storage ... SUCCESS [16.439s]
[INFO] Lens Query Library  SUCCESS [12.739s]
[INFO] Lens Hive Driver .. SUCCESS [1:15.184s]
[INFO] Lens Driver for JDBC .. SUCCESS [39.351s]
[INFO] Lens Elastic Search Driver  SUCCESS [19.958s]
[INFO] Lens Server ... SUCCESS [16:28.932s]
[INFO] Lens client ... SUCCESS [1:21.876s]
[INFO] Lens CLI .. SUCCESS [1:12.501s]
[INFO] Lens Examples . SUCCESS [8.167s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.618s]
[INFO] Lens Distribution . SUCCESS [8.981s]
[INFO] Lens ML Lib ... SUCCESS [1:02.132s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.106s]
[INFO] Lens Regression ... SUCCESS [12.315s]
[INFO] Lens UI ... SUCCESS [30.001s]
[INFO] Lens Contrib .. SUCCESS [0.328s]
[INFO] Lens Contributed Clients .. SUCCESS [0.325s]
[INFO] Lens Python Client  SUCCESS [0.334s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 38:44.416s
[INFO] Finished at: Thu Oct 27 07:21:56 UTC 2016
[INFO] Final Memory: 272M/3119M
[INFO] 


Thanks,

Amareshwari Sriramadasu

[jira] [Updated] (LENS-1357) Seeing NPE in stop lens services after a failed attempt of start

2016-11-02 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1357:
--
Status: Patch Available  (was: Open)

Resubmitting to check test failures.

> Seeing NPE in stop lens services after a failed attempt of start
> 
>
> Key: LENS-1357
> URL: https://issues.apache.org/jira/browse/LENS-1357
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1357.01.patch, LENS-1357.02.patch, 
> LENS-1357.03.patch, screenshot-1.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1327) Handle Data delay for scheduled jobs

2016-11-02 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1327:
--
   Resolution: Fixed
Fix Version/s: 2.7
   Status: Resolved  (was: Patch Available)

Committed. Thanks [~lavkesh]

> Handle Data delay for scheduled jobs
> 
>
> Key: LENS-1327
> URL: https://issues.apache.org/jira/browse/LENS-1327
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: 0001-Data-dealy.patch, 0001-data-delay.patch, 
> data-delay.patch, data-delay.patch, data-delay.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1327) Handle Data delay for scheduled jobs

2016-11-02 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1327:
--
Component/s: server

> Handle Data delay for scheduled jobs
> 
>
> Key: LENS-1327
> URL: https://issues.apache.org/jira/browse/LENS-1327
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: 0001-Data-dealy.patch, 0001-data-delay.patch, 
> data-delay.patch, data-delay.patch, data-delay.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1354) Timeout and test failures in lens-cube module

2016-11-02 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1354:
--
Status: Open  (was: Patch Available)

[~prongs] Latest patch still timed out the tests.

[INFO] Lens Cube .. FAILURE [40:22 min]


> Timeout and test failures in lens-cube module
> -
>
> Key: LENS-1354
> URL: https://issues.apache.org/jira/browse/LENS-1354
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1354.01.patch, LENS-1354.02.patch, 
> LENS-1354.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1342) Unclosed InputStreamReader in PropertyBasedUserConfigLoader

2016-11-02 Thread Puneet Gupta (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628238#comment-15628238
 ] 

Puneet Gupta commented on LENS-1342:


Resubmitting to check failures 
https://builds.apache.org/job/PreCommit-Lens-Build/1143/

> Unclosed InputStreamReader in PropertyBasedUserConfigLoader
> ---
>
> Key: LENS-1342
> URL: https://issues.apache.org/jira/browse/LENS-1342
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Attachments: 1342.v1.txt
>
>
> {code}
> try {
>   properties.load(new InputStreamReader(new FileInputStream(new 
> File(filename)), "UTF-8"));
> } catch (IOException e) {
>   throw new UserConfigLoaderException("property file not found. Provided 
> path was: " + filename);
> }
> {code}
> The InputStreamReader should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1342) Unclosed InputStreamReader in PropertyBasedUserConfigLoader

2016-11-02 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628248#comment-15628248
 ] 

Hadoop QA commented on LENS-1342:
-

Applied patch: 
[1342.v1.txt|https://issues.apache.org/jira/secure/attachment/12833671/1342.v1.txt]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1143/

> Unclosed InputStreamReader in PropertyBasedUserConfigLoader
> ---
>
> Key: LENS-1342
> URL: https://issues.apache.org/jira/browse/LENS-1342
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Attachments: 1342.v1.txt
>
>
> {code}
> try {
>   properties.load(new InputStreamReader(new FileInputStream(new 
> File(filename)), "UTF-8"));
> } catch (IOException e) {
>   throw new UserConfigLoaderException("property file not found. Provided 
> path was: " + filename);
> }
> {code}
> The InputStreamReader should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1357) Seeing NPE in stop lens services after a failed attempt of start

2016-11-02 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628313#comment-15628313
 ] 

Hadoop QA commented on LENS-1357:
-

Applied patch: 
[LENS-1357.03.patch|https://issues.apache.org/jira/secure/attachment/12833678/LENS-1357.03.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1144/

> Seeing NPE in stop lens services after a failed attempt of start
> 
>
> Key: LENS-1357
> URL: https://issues.apache.org/jira/browse/LENS-1357
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1357.01.patch, LENS-1357.02.patch, 
> LENS-1357.03.patch, screenshot-1.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1327) Handle Data delay for scheduled jobs

2016-11-02 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628374#comment-15628374
 ] 

Hudson commented on LENS-1327:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit #1368 (See 
[https://builds.apache.org/job/Lens-Commit/1368/])
LENS-1327 : Handle data delay for scheduled jobs (amareshwari: rev 
95a4f596c42f57647b2eb12c0419175c9c87de8e)
* (edit) 
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java
* (edit) 
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
* (edit) 
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
* (edit) 
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
* (edit) 
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
* (edit) 
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
* (edit) lens-server/src/main/resources/lensserver-default.xml
* (edit) src/site/apt/admin/config.apt
* (edit) 
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
* (edit) 
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerRestartTest.java


> Handle Data delay for scheduled jobs
> 
>
> Key: LENS-1327
> URL: https://issues.apache.org/jira/browse/LENS-1327
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: 0001-Data-dealy.patch, 0001-data-delay.patch, 
> data-delay.patch, data-delay.patch, data-delay.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1327) Handle Data delay for scheduled jobs

2016-11-02 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628379#comment-15628379
 ] 

Hudson commented on LENS-1327:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit-Java8 #285 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/285/])
LENS-1327 : Handle data delay for scheduled jobs (amareshwari: rev 
95a4f596c42f57647b2eb12c0419175c9c87de8e)
* (edit) 
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerRestartTest.java
* (edit) 
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
* (edit) 
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
* (edit) 
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java
* (edit) src/site/apt/admin/config.apt
* (edit) 
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
* (edit) lens-server/src/main/resources/lensserver-default.xml
* (edit) 
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
* (edit) 
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
* (edit) 
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java


> Handle Data delay for scheduled jobs
> 
>
> Key: LENS-1327
> URL: https://issues.apache.org/jira/browse/LENS-1327
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: 0001-Data-dealy.patch, 0001-data-delay.patch, 
> data-delay.patch, data-delay.patch, data-delay.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1342) Unclosed InputStreamReader in PropertyBasedUserConfigLoader

2016-11-02 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628392#comment-15628392
 ] 

Hadoop QA commented on LENS-1342:
-

Applied patch: 
[1342.v1.txt|https://issues.apache.org/jira/secure/attachment/12833671/1342.v1.txt]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1145/

> Unclosed InputStreamReader in PropertyBasedUserConfigLoader
> ---
>
> Key: LENS-1342
> URL: https://issues.apache.org/jira/browse/LENS-1342
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Attachments: 1342.v1.txt
>
>
> {code}
> try {
>   properties.load(new InputStreamReader(new FileInputStream(new 
> File(filename)), "UTF-8"));
> } catch (IOException e) {
>   throw new UserConfigLoaderException("property file not found. Provided 
> path was: " + filename);
> }
> {code}
> The InputStreamReader should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1342) Unclosed InputStreamReader in PropertyBasedUserConfigLoader

2016-11-02 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628499#comment-15628499
 ] 

Hadoop QA commented on LENS-1342:
-

Applied patch: 
[1342.v1.txt|https://issues.apache.org/jira/secure/attachment/12833671/1342.v1.txt]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1147/

> Unclosed InputStreamReader in PropertyBasedUserConfigLoader
> ---
>
> Key: LENS-1342
> URL: https://issues.apache.org/jira/browse/LENS-1342
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Attachments: 1342.v1.txt
>
>
> {code}
> try {
>   properties.load(new InputStreamReader(new FileInputStream(new 
> File(filename)), "UTF-8"));
> } catch (IOException e) {
>   throw new UserConfigLoaderException("property file not found. Provided 
> path was: " + filename);
> }
> {code}
> The InputStreamReader should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1357) Seeing NPE in stop lens services after a failed attempt of start

2016-11-02 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628500#comment-15628500
 ] 

Hadoop QA commented on LENS-1357:
-

Applied patch: 
[LENS-1357.03.patch|https://issues.apache.org/jira/secure/attachment/12833678/LENS-1357.03.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1146/

> Seeing NPE in stop lens services after a failed attempt of start
> 
>
> Key: LENS-1357
> URL: https://issues.apache.org/jira/browse/LENS-1357
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1357.01.patch, LENS-1357.02.patch, 
> LENS-1357.03.patch, screenshot-1.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1342) Unclosed InputStreamReader in PropertyBasedUserConfigLoader

2016-11-02 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628611#comment-15628611
 ] 

Hadoop QA commented on LENS-1342:
-

Applied patch: 
[1342.v1.txt|https://issues.apache.org/jira/secure/attachment/12833671/1342.v1.txt]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1148/

> Unclosed InputStreamReader in PropertyBasedUserConfigLoader
> ---
>
> Key: LENS-1342
> URL: https://issues.apache.org/jira/browse/LENS-1342
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Attachments: 1342.v1.txt
>
>
> {code}
> try {
>   properties.load(new InputStreamReader(new FileInputStream(new 
> File(filename)), "UTF-8"));
> } catch (IOException e) {
>   throw new UserConfigLoaderException("property file not found. Provided 
> path was: " + filename);
> }
> {code}
> The InputStreamReader should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1342) Unclosed InputStreamReader in PropertyBasedUserConfigLoader

2016-11-02 Thread Amareshwari Sriramadasu (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628760#comment-15628760
 ] 

Amareshwari Sriramadasu commented on LENS-1342:
---

Finally there is one successful build - 
https://builds.apache.org/job/PreCommit-Lens-Build/1147/. We need to track 
other errors in pre-commit builds and close them to help simpler patches like 
this to get in faster.

> Unclosed InputStreamReader in PropertyBasedUserConfigLoader
> ---
>
> Key: LENS-1342
> URL: https://issues.apache.org/jira/browse/LENS-1342
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Attachments: 1342.v1.txt
>
>
> {code}
> try {
>   properties.load(new InputStreamReader(new FileInputStream(new 
> File(filename)), "UTF-8"));
> } catch (IOException e) {
>   throw new UserConfigLoaderException("property file not found. Provided 
> path was: " + filename);
> }
> {code}
> The InputStreamReader should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52514: Add data completeness checker

2016-11-02 Thread Narayan Periwal 


> On Oct. 21, 2016, 9:06 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/DefaultCompletenessChecker.java,
> >  line 25
> > 
> >
> > Instead of calling it DefaultCompletenessChecker,please call Mock or 
> > something else.

Will rename it as MockCompletenessChecker


> On Oct. 21, 2016, 9:06 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, 
> > line 939
> > 
> >
> > Please add appropriate asserts for the test.

Will add the asserts for the hql query and the expected query.


> On Oct. 21, 2016, 9:06 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, 
> > line 950
> > 
> >
> > Please add appropriate asserts for the test.

Will add the asserts for the hql query and the expected query.


> On Oct. 21, 2016, 9:06 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, 
> > line 969
> > 
> >
> > Not clear whats the expected and actual value here.

Here we are expecting the prune cause to be the Incomplete Data. Hence to 
assert this, we do a substring of INCOMPLETE_PARTITION.errorFormat


> On Oct. 21, 2016, 9:06 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/resources/olap-query-conf.xml, line 111
> > 
> >
> > Should we make default to 100% ?

Agreed. We can give default value as 100%.


> On Oct. 21, 2016, 9:06 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java,
> >  line 526
> > 
> >
> > This might skip expressions containing measures. We might have to 
> > iterate over queriedPhrases and look for measures in them.

Will add the measures after iterating over the queriedPhrases


> On Oct. 21, 2016, 9:06 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java,
> >  line 118
> > 
> >
> > Should we make default to 100% ? Also move the default value also as a 
> > constant to CubeQueryConfUtil .

Agreed. Will move this to CubeQueryConfUtil.


> On Oct. 21, 2016, 9:06 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java, 
> > line 49
> > 
> >
> > Minor :
> > 
> > Can we avoid the string concat with " + " ?

Agreed.


- Narayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52514/#review153514
---


On Oct. 10, 2016, 7:45 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52514/
> ---
> 
> (Updated Oct. 10, 2016, 7:45 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1333
> https://issues.apache.org/jira/browse/LENS-1333
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Though lens has partition registration being done whenever data is available, 
> there is no guarantee the partition registered is complete. There can be 
> different ways to know if the data is complete for partition. One option 
> could be to have a partition property saying whether it is complete or not. 
> Other could be to do a http call to another hosted service and more.
> 
> Proposal here is to add an interface for DataCompletenessChecker and do the 
> check while resolving partitions.
> 
> Here are some of the capabilities we would like to add in Lens :
> # Lens will check partition existence first, if it exists, then check the 
> completeness percentage. If the completeness percentage is less than a 
> configured threshold (default should be 98, 99 or even 100), Lens will fail 
> the query.
> # Lens's accept query on partial data will accept on incomplete data as well.
> # Lens will also option to override the completeness percentage threshold 
> value at query level
> # Lens will still have look ahead capability of daily being incomplete, then 
> it will union with hourly. 
> # If same measure is there in two different facts , Lens will we pick the one 
> with higher availability.
> # In case of completeness

[jira] [Commented] (LENS-1342) Unclosed InputStreamReader in PropertyBasedUserConfigLoader

2016-11-02 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15629447#comment-15629447
 ] 

Ted Yu commented on LENS-1342:
--

Logged LENS-1372 for QueryRetryTest failure

> Unclosed InputStreamReader in PropertyBasedUserConfigLoader
> ---
>
> Key: LENS-1342
> URL: https://issues.apache.org/jira/browse/LENS-1342
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Attachments: 1342.v1.txt
>
>
> {code}
> try {
>   properties.load(new InputStreamReader(new FileInputStream(new 
> File(filename)), "UTF-8"));
> } catch (IOException e) {
>   throw new UserConfigLoaderException("property file not found. Provided 
> path was: " + filename);
> }
> {code}
> The InputStreamReader should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-1372) QueryRetryTest is flaky

2016-11-02 Thread Ted Yu (JIRA) 
Ted Yu created LENS-1372:


 Summary: QueryRetryTest is flaky
 Key: LENS-1372
 URL: https://issues.apache.org/jira/browse/LENS-1372
 Project: Apache Lens
  Issue Type: Test
Reporter: Ted Yu
Priority: Minor


>From 
>https://builds.apache.org/job/PreCommit-Lens-Build/1145/testReport/junit/org.apache.lens.server.query.retry/QueryRetryTest/testRestartWhileRetry/
> :
{code}
java.lang.NullPointerException: null
at 
org.apache.lens.server.query.retry.QueryRetryTest.testRestartWhileRetry(QueryRetryTest.java:201)
{code}
Here is related code:
{code}
ctx = getQueryService().getQueryContext(handle);
while (!ctx.getStatus().finished()) {
{code}
The test should handle the case where status is null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1342) Unclosed InputStreamReader in PropertyBasedUserConfigLoader

2016-11-02 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1342:
--
 Assignee: Ted Yu
Fix Version/s: 2.7
  Component/s: server

> Unclosed InputStreamReader in PropertyBasedUserConfigLoader
> ---
>
> Key: LENS-1342
> URL: https://issues.apache.org/jira/browse/LENS-1342
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 2.7
>
> Attachments: 1342.v1.txt
>
>
> {code}
> try {
>   properties.load(new InputStreamReader(new FileInputStream(new 
> File(filename)), "UTF-8"));
> } catch (IOException e) {
>   throw new UserConfigLoaderException("property file not found. Provided 
> path was: " + filename);
> }
> {code}
> The InputStreamReader should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1342) Unclosed InputStreamReader in PropertyBasedUserConfigLoader

2016-11-02 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1342:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Committed. Thanks [~yuzhih...@gmail.com] for reporting and fixing the issue.

> Unclosed InputStreamReader in PropertyBasedUserConfigLoader
> ---
>
> Key: LENS-1342
> URL: https://issues.apache.org/jira/browse/LENS-1342
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 2.7
>
> Attachments: 1342.v1.txt
>
>
> {code}
> try {
>   properties.load(new InputStreamReader(new FileInputStream(new 
> File(filename)), "UTF-8"));
> } catch (IOException e) {
>   throw new UserConfigLoaderException("property file not found. Provided 
> path was: " + filename);
> }
> {code}
> The InputStreamReader should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1357) Seeing NPE in stop lens services after a failed attempt of start

2016-11-02 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1357:
--
   Resolution: Fixed
Fix Version/s: 2.7
   Status: Resolved  (was: Patch Available)

Committed. Thanks [~prongs]

> Seeing NPE in stop lens services after a failed attempt of start
> 
>
> Key: LENS-1357
> URL: https://issues.apache.org/jira/browse/LENS-1357
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1357.01.patch, LENS-1357.02.patch, 
> LENS-1357.03.patch, screenshot-1.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1360) org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in pre-commit

2016-11-02 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1360:
--
Status: Open  (was: Patch Available)

Canceling patch to get to actual cause.

> org.apache.lens.driver.jdbc.TestJdbcDriver#testCancelQuery failing in 
> pre-commit 
> -
>
> Key: LENS-1360
> URL: https://issues.apache.org/jira/browse/LENS-1360
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1360.02.patch, LENS-1360.03.patch, 
> LENS-1360.04.patch, LENS-1360.05.patch, LENS-1360.logging.patch, 
> LENS-1360.logging.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1359) Add driver hooks for user based filtering of queries

2016-11-02 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1359:
--
Status: Open  (was: Patch Available)

Canceling patch for test failures

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch, LENS-1359.08.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1370) Queries persisted before retry framework upgrade are not getting purged

2016-11-02 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1370:
--
Affects Version/s: 2.7
Fix Version/s: 2.7
  Component/s: server

> Queries persisted before retry framework upgrade are not getting purged
> ---
>
> Key: LENS-1370
> URL: https://issues.apache.org/jira/browse/LENS-1370
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Affects Versions: 2.7
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1370.2016-10-27_13:00:23.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1370) Queries persisted before retry framework upgrade are not getting purged

2016-11-02 Thread Amareshwari Sriramadasu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1370:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Committed. Thanks [~prongs]

> Queries persisted before retry framework upgrade are not getting purged
> ---
>
> Key: LENS-1370
> URL: https://issues.apache.org/jira/browse/LENS-1370
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Affects Versions: 2.7
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1370.2016-10-27_13:00:23.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1357) Seeing NPE in stop lens services after a failed attempt of start

2016-11-02 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631850#comment-15631850
 ] 

Hudson commented on LENS-1357:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit-Java8 #287 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/287/])
LENS-1357 : Fix NPE in stop lens services after a failed attempt of 
(amareshwari: rev 9b0a453de7059bf453a84f2c5945095151a6a9d7)
* (edit) lens-server/src/main/java/org/apache/lens/server/LensServices.java


> Seeing NPE in stop lens services after a failed attempt of start
> 
>
> Key: LENS-1357
> URL: https://issues.apache.org/jira/browse/LENS-1357
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1357.01.patch, LENS-1357.02.patch, 
> LENS-1357.03.patch, screenshot-1.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1342) Unclosed InputStreamReader in PropertyBasedUserConfigLoader

2016-11-02 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15631849#comment-15631849
 ] 

Hudson commented on LENS-1342:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit-Java8 #287 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/287/])
LENS-1342 : Close InputStreamReader in PropertyBasedUserConfigLoader 
(amareshwari: rev d1a0e0e266b5f7ffd0ad1d5b742fb92e4a91eeb3)
* (edit) 
lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java


> Unclosed InputStreamReader in PropertyBasedUserConfigLoader
> ---
>
> Key: LENS-1342
> URL: https://issues.apache.org/jira/browse/LENS-1342
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Minor
> Fix For: 2.7
>
> Attachments: 1342.v1.txt
>
>
> {code}
> try {
>   properties.load(new InputStreamReader(new FileInputStream(new 
> File(filename)), "UTF-8"));
> } catch (IOException e) {
>   throw new UserConfigLoaderException("property file not found. Provided 
> path was: " + filename);
> }
> {code}
> The InputStreamReader should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)