[jira] [Created] (LENS-1384) Update error message for data availability check

[Narayan Periwal (JIRA)]

Narayan Periwal created LENS-1384:
-

 Summary: Update error message for data availability check
 Key: LENS-1384
 URL: https://issues.apache.org/jira/browse/LENS-1384
 Project: Apache Lens
  Issue Type: Task
  Components: cube
Reporter: Narayan Periwal
Assignee: Narayan Periwal
Priority: Minor


We can make the error message for the data availability check less verbose.
New message can be something like -  Requested metrics are only partially 
available. Partially available metrics: . Try 
again later or remove metric and re-run report.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1384) Update error message for data completeness check

[Narayan Periwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Narayan Periwal updated LENS-1384:
--
Summary: Update error message for data completeness check  (was: Update 
error message for data availability check)

> Update error message for data completeness check
> 
>
> Key: LENS-1384
> URL: https://issues.apache.org/jira/browse/LENS-1384
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube
>Reporter: Narayan Periwal
>Assignee: Narayan Periwal
>Priority: Minor
>
> We can make the error message for the data availability check less verbose.
> New message can be something like -  Requested metrics are only partially 
> available. Partially available metrics: . 
> Try again later or remove metric and re-run report.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-1385) Dateformat not being passed in prev and next calls of FactPartition

[Rajitha R (JIRA)]

Rajitha R created LENS-1385:
---

 Summary: Dateformat not being passed in prev and next calls of 
FactPartition 
 Key: LENS-1385
 URL: https://issues.apache.org/jira/browse/LENS-1385
 Project: Apache Lens
  Issue Type: Improvement
Reporter: Rajitha R
Assignee: Rajitha R


Dateformat is not being passed in prev and next calls of FactPartition. This is 
resulting in the date format of Update period to be used for the newly created 
previous/next partitions.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work started] (LENS-1385) Dateformat not being passed in prev and next calls of FactPartition

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1385 started by Rajitha R.
---
> Dateformat not being passed in prev and next calls of FactPartition 
> 
>
> Key: LENS-1385
> URL: https://issues.apache.org/jira/browse/LENS-1385
> Project: Apache Lens
>  Issue Type: Improvement
>Reporter: Rajitha R
>Assignee: Rajitha R
>
> Dateformat is not being passed in prev and next calls of FactPartition. This 
> is resulting in the date format of Update period to be used for the newly 
> created previous/next partitions.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1384) Update error message for data completeness check

[Narayan Periwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Narayan Periwal updated LENS-1384:
--
Description: 
We can make the error message for the data completeness check less verbose.
New message can be something like -  Requested metrics are only partially 
complete. Partially complete metrics: . Try 
again later or remove metric and re-run report.

  was:
We can make the error message for the data availability check less verbose.
New message can be something like -  Requested metrics are only partially 
available. Partially available metrics: . Try 
again later or remove metric and re-run report.


> Update error message for data completeness check
> 
>
> Key: LENS-1384
> URL: https://issues.apache.org/jira/browse/LENS-1384
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube
>Reporter: Narayan Periwal
>Assignee: Narayan Periwal
>Priority: Minor
>
> We can make the error message for the data completeness check less verbose.
> New message can be something like -  Requested metrics are only partially 
> complete. Partially complete metrics: . Try 
> again later or remove metric and re-run report.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work started] (LENS-1384) Update error message for data completeness check

[Narayan Periwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1384 started by Narayan Periwal.
-
> Update error message for data completeness check
> 
>
> Key: LENS-1384
> URL: https://issues.apache.org/jira/browse/LENS-1384
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube
>Reporter: Narayan Periwal
>Assignee: Narayan Periwal
>Priority: Minor
>
> We can make the error message for the data completeness check less verbose.
> New message can be something like -  Requested metrics are only partially 
> complete. Partially complete metrics: . Try 
> again later or remove metric and re-run report.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-1386) Vertica Fact Schema change to support all update periods in one storage

[Lavkesh Lahngir (JIRA)]

Lavkesh Lahngir created LENS-1386:
-

 Summary: Vertica Fact Schema change to support all update periods 
in one storage
 Key: LENS-1386
 URL: https://issues.apache.org/jira/browse/LENS-1386
 Project: Apache Lens
  Issue Type: Task
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir


Xsd and Metastore changes:
(1) New Xsd construct
(2) Create Fact Changes
(3) CubeMetastoreClient changes for update period table name
(4) Validation that TableDescription should only be available at either table 
level or at update period level



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work stopped] (LENS-1385) Dateformat not being passed in prev and next calls of FactPartition

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1385 stopped by Rajitha R.
---
> Dateformat not being passed in prev and next calls of FactPartition 
> 
>
> Key: LENS-1385
> URL: https://issues.apache.org/jira/browse/LENS-1385
> Project: Apache Lens
>  Issue Type: Improvement
>Reporter: Rajitha R
>Assignee: Rajitha R
>
> Dateformat is not being passed in prev and next calls of FactPartition. This 
> is resulting in the date format of Update period to be used for the newly 
> created previous/next partitions.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 55712: Vertica Fact Schema change to support all update periods in one storage

[Lavkesh Lahngir]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55712/
---

Review request for lens.


Bugs: LENS-1386
https://issues.apache.org/jira/browse/LENS-1386


Repository: lens


Description
---

An new data structure XUpdatePeriodTableDescriptor is introduced which contains 
an update period and table descriptor. Now the XUpdatePeriods will contain a 
list of XUpdatePeriodTableDescriptor or XUpdatePeriod


Diffs
-

  lens-api/src/main/resources/cube-0.1.xsd f438f48 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
adb6c92 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
6c9cde2 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
53cf8af 
  
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 8b10d1d 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
51fcb43 

Diff: https://reviews.apache.org/r/55712/diff/


Testing
---


Thanks,

Lavkesh Lahngir

[jira] [Updated] (LENS-1386) Fact Schema change to support all update periods in one storage

[Lavkesh Lahngir (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1386:
--
Summary: Fact Schema change to support all update periods in one storage  
(was: Vertica Fact Schema change to support all update periods in one storage)

> Fact Schema change to support all update periods in one storage
> ---
>
> Key: LENS-1386
> URL: https://issues.apache.org/jira/browse/LENS-1386
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
>
> Xsd and Metastore changes:
> (1) New Xsd construct
> (2) Create Fact Changes
> (3) CubeMetastoreClient changes for update period table name
> (4) Validation that TableDescription should only be available at either table 
> level or at update period level



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 55712: Fact Schema change to support all update periods in one storage

[Lavkesh Lahngir]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55712/
---

(Updated Jan. 19, 2017, 12:08 p.m.)


Review request for lens.


Summary (updated)
-

 Fact Schema change to support all update periods in one storage


Bugs: LENS-1386
https://issues.apache.org/jira/browse/LENS-1386


Repository: lens


Description (updated)
---

A new data structure XUpdatePeriodTableDescriptor is introduced which contains 
an update period and table descriptor. Now the XUpdatePeriods will contain a 
list of XUpdatePeriodTableDescriptor or XUpdatePeriod


Diffs
-

  lens-api/src/main/resources/cube-0.1.xsd f438f48 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
adb6c92 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
6c9cde2 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
53cf8af 
  
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 8b10d1d 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
51fcb43 

Diff: https://reviews.apache.org/r/55712/diff/


Testing
---


Thanks,

Lavkesh Lahngir

Review Request 55715: Update error message for data completeness check

[Narayan Periwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/
---

Review request for lens.


Bugs: LENS-1384
https://issues.apache.org/jira/browse/LENS-1384


Repository: lens


Description
---

We can make the error message for the data completeness check less verbose.
New message can be something like -  Requested metrics are only partially 
complete. Partially complete metrics: . Try 
again later or remove metric and re-run report.


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 2ad6e20 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
c9e7c29 

Diff: https://reviews.apache.org/r/55715/diff/


Testing
---


Thanks,

Narayan Periwal

Re: Review Request 55715: Update error message for data completeness check

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/#review162281
---




lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 (line 151)


Should we say  

"Data for the requested metrics is only partially available. Partially 
available metrics are : %s. Please try again later."



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 (line 154)


Are we logging the old more verbose message( metric - time - %completion) 
somewhere ? It would be required for debugging the issue or to answer user 
queries when they pour in .


- Puneet Gupta


On Jan. 19, 2017, 12:25 p.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55715/
> ---
> 
> (Updated Jan. 19, 2017, 12:25 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1384
> https://issues.apache.org/jira/browse/LENS-1384
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> We can make the error message for the data completeness check less verbose.
> New message can be something like -  Requested metrics are only partially 
> complete. Partially complete metrics: . Try 
> again later or remove metric and re-run report.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  2ad6e20 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> c9e7c29 
> 
> Diff: https://reviews.apache.org/r/55715/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

[jira] [Updated] (LENS-1386) Add support for separate tables for update periods in one storage

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1386:
--
Summary: Add support for separate tables for update periods in one storage  
(was: Fact Schema change to support all update periods in one storage)

> Add support for separate tables for update periods in one storage
> -
>
> Key: LENS-1386
> URL: https://issues.apache.org/jira/browse/LENS-1386
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
>
> Xsd and Metastore changes:
> (1) New Xsd construct
> (2) Create Fact Changes
> (3) CubeMetastoreClient changes for update period table name
> (4) Validation that TableDescription should only be available at either table 
> level or at update period level



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 55712: Fact Schema change to support all update periods in one storage

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55712/#review162385
---




lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
(lines 225 - 226)


empty if?



lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java (line 
594)


Should we call it updatePeriodTableKey?



lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 (lines 664 - 668)


Can addPartition in CubeMetastoreClient access updatePeriod from partition 
spec to find final storage table, instead of creating a temp storage name? That 
would be cleaner.



lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 (lines 685 - 697)


Same as above, can we move this cubemetastoreclient?



lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (line 
867)


Changing storage name to updatePeriod_storage is looking more like a hack.


- Amareshwari Sriramadasu


On Jan. 19, 2017, 12:08 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55712/
> ---
> 
> (Updated Jan. 19, 2017, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1386
> https://issues.apache.org/jira/browse/LENS-1386
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> A new data structure XUpdatePeriodTableDescriptor is introduced which 
> contains an update period and table descriptor. Now the XUpdatePeriods will 
> contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd f438f48 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> adb6c92 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  6c9cde2 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 53cf8af 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  8b10d1d 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
> 51fcb43 
> 
> Diff: https://reviews.apache.org/r/55712/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 55712: Fact Schema change to support all update periods in one storage

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55712/#review162386
---



I see we are creating  map> in 
some places and I see map in some 
places.

I feel it can degrade code readability;  and whenever storage names have to be 
pulled, we need to understand where is actual storage names vs modified storage 
names. Can we be consistent in creating storage name as actual storage name 
alone, no other storage names - and move all the prefixing to final place of 
physical table name creation.

- Amareshwari Sriramadasu


On Jan. 19, 2017, 12:08 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55712/
> ---
> 
> (Updated Jan. 19, 2017, 12:08 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1386
> https://issues.apache.org/jira/browse/LENS-1386
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> A new data structure XUpdatePeriodTableDescriptor is introduced which 
> contains an update period and table descriptor. Now the XUpdatePeriods will 
> contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd f438f48 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> adb6c92 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  6c9cde2 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 53cf8af 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  8b10d1d 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
> 51fcb43 
> 
> Diff: https://reviews.apache.org/r/55712/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

[jira] [Assigned] (LENS-773) Wrong Cost Calculation in case of HIVE Dimension Query

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu reassigned LENS-773:


Assignee: Amareshwari Sriramadasu

> Wrong Cost Calculation in case of HIVE Dimension Query
> --
>
> Key: LENS-773
> URL: https://issues.apache.org/jira/browse/LENS-773
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Arshad Matin
>Assignee: Amareshwari Sriramadasu
>
> Query : cube select id,name from sample_dim2 where name != 'first'
> This should be answerable from hive and hence its cost should be non-zero.
> But getting the cost as zero.
> {noformat}
> 580cf6df-35b3-4f73-9013-c304418a3904 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
> xsi:type="queryCostTO">0.0LOW
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)