[jira] [Updated] (LENS-1386) Add support for separate tables for update periods in one storage

[Lavkesh Lahngir (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1386:
--
Attachment: LENS-1386.patch

> Add support for separate tables for update periods in one storage
> -
>
> Key: LENS-1386
> URL: https://issues.apache.org/jira/browse/LENS-1386
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1386.patch
>
>
> Xsd and Metastore changes:
> (1) New Xsd construct
> (2) Create Fact Changes
> (3) CubeMetastoreClient changes for update period table name
> (4) Validation that TableDescription should only be available at either table 
> level or at update period level



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1386) Add support for separate tables for update periods in one storage

[Lavkesh Lahngir (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1386:
--
Status: Patch Available  (was: Open)

> Add support for separate tables for update periods in one storage
> -
>
> Key: LENS-1386
> URL: https://issues.apache.org/jira/browse/LENS-1386
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1386.patch
>
>
> Xsd and Metastore changes:
> (1) New Xsd construct
> (2) Create Fact Changes
> (3) CubeMetastoreClient changes for update period table name
> (4) Validation that TableDescription should only be available at either table 
> level or at update period level



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 55712: Fact Schema change to support all update periods in one storage

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55712/#review166063
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Feb. 19, 2017, 4:26 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55712/
> ---
> 
> (Updated Feb. 19, 2017, 4:26 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1386
> https://issues.apache.org/jira/browse/LENS-1386
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> A new data structure XUpdatePeriodTableDescriptor is introduced which 
> contains an update period and table descriptor. Now the XUpdatePeriods will 
> contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd f438f48 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> adb6c92 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  6c9cde2 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 53cf8af 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  e21dc2a 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  8b10d1d 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
> 51fcb43 
>   
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
>  0e6a4a1 
> 
> Diff: https://reviews.apache.org/r/55712/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

[jira] [Commented] (LENS-1386) Add support for separate tables for update periods in one storage

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874226#comment-15874226
 ] 

Hadoop QA commented on LENS-1386:
-

Applied patch: 
[LENS-1386.patch|https://issues.apache.org/jira/secure/attachment/12853535/LENS-1386.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1222/

> Add support for separate tables for update periods in one storage
> -
>
> Key: LENS-1386
> URL: https://issues.apache.org/jira/browse/LENS-1386
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1386.patch
>
>
> Xsd and Metastore changes:
> (1) New Xsd construct
> (2) Create Fact Changes
> (3) CubeMetastoreClient changes for update period table name
> (4) Validation that TableDescription should only be available at either table 
> level or at update period level



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (LENS-1389) Valid Update periods for a storage candidate should not be bigger than query time range

[Rajat Khandelwal (JIRA)]

Rajat Khandelwal created LENS-1389:
--

 Summary: Valid Update periods for a storage candidate should not 
be bigger than query time range
 Key: LENS-1389
 URL: https://issues.apache.org/jira/browse/LENS-1389
 Project: Apache Lens
  Issue Type: Sub-task
  Components: cube
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal


This is causing test failure in lens-1381 branch. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 56842: LENS-1389: Valid Update periods for a storage candidate should not be bigger than query time range

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56842/
---

Review request for lens.


Bugs: LENS-1389
https://issues.apache.org/jira/browse/LENS-1389


Repository: lens


Description
---

This is causing test failure in lens-1381 branch.


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
771708132a7e9dfbcb1148329647a946425b9d42 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
bf6cc5c3e6d8fc6521a5b0f1ef3e0212f0111c7a 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 c7f2047b57ebc26244891d9bc48ad18ab0176fdd 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
fca86ec88b1dd0507d21ca1b414dcc6fb68317e3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
3029589ae1db24330aebb6eaa34aa127c3576a04 
  pom.xml 8ea64b77fff11d9f46be56437aed3b527bde0ff8 

Diff: https://reviews.apache.org/r/56842/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Work started] (LENS-1389) Valid Update periods for a storage candidate should not be bigger than query time range

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1389 started by Rajat Khandelwal.
--
> Valid Update periods for a storage candidate should not be bigger than query 
> time range
> ---
>
> Key: LENS-1389
> URL: https://issues.apache.org/jira/browse/LENS-1389
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> This is causing test failure in lens-1381 branch. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1389) Valid Update periods for a storage candidate should not be bigger than query time range

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874243#comment-15874243
 ] 

Rajat Khandelwal commented on LENS-1389:


Created https://reviews.apache.org/r/56842/

> Valid Update periods for a storage candidate should not be bigger than query 
> time range
> ---
>
> Key: LENS-1389
> URL: https://issues.apache.org/jira/browse/LENS-1389
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> This is causing test failure in lens-1381 branch. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1386) Add support for separate tables for update periods in one storage

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1386:
--
Component/s: server
 cube
 api

> Add support for separate tables for update periods in one storage
> -
>
> Key: LENS-1386
> URL: https://issues.apache.org/jira/browse/LENS-1386
> Project: Apache Lens
>  Issue Type: Task
>  Components: api, cube, server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: LENS-1386.patch
>
>
> Xsd and Metastore changes:
> (1) New Xsd construct
> (2) Create Fact Changes
> (3) CubeMetastoreClient changes for update period table name
> (4) Validation that TableDescription should only be available at either table 
> level or at update period level



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1386) Add support for separate tables for update periods in one storage

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1386:
--
   Resolution: Fixed
Fix Version/s: 2.7
   Status: Resolved  (was: Patch Available)

Committed. Thanks [~lavkesh]

> Add support for separate tables for update periods in one storage
> -
>
> Key: LENS-1386
> URL: https://issues.apache.org/jira/browse/LENS-1386
> Project: Apache Lens
>  Issue Type: Task
>  Components: api, cube, server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: LENS-1386.patch
>
>
> Xsd and Metastore changes:
> (1) New Xsd construct
> (2) Create Fact Changes
> (3) CubeMetastoreClient changes for update period table name
> (4) Validation that TableDescription should only be available at either table 
> level or at update period level



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1386) Add support for separate tables for update periods in one storage

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874264#comment-15874264
 ] 

Hadoop QA commented on LENS-1386:
-

Patch does not apply. Build job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1223/

> Add support for separate tables for update periods in one storage
> -
>
> Key: LENS-1386
> URL: https://issues.apache.org/jira/browse/LENS-1386
> Project: Apache Lens
>  Issue Type: Task
>  Components: api, cube, server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: LENS-1386.patch
>
>
> Xsd and Metastore changes:
> (1) New Xsd construct
> (2) Create Fact Changes
> (3) CubeMetastoreClient changes for update period table name
> (4) Validation that TableDescription should only be available at either table 
> level or at update period level



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1386) Add support for separate tables for update periods in one storage

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874337#comment-15874337
 ] 

Hudson commented on LENS-1386:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit #1385 (See 
[https://builds.apache.org/job/Lens-Commit/1385/])
LENS-1386 : Add support for separate tables for update periods in one 
(amareshwari: rev f0dadd79bb626fe6f8bbf21569e3062aeb9be070)
* (edit) 
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
* (edit) 
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
* (edit) 
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
* (edit) lens-api/src/main/resources/cube-0.1.xsd
* (edit) 
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java
* (edit) 
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java
* (edit) 
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java
* (edit) lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java
* (edit) 
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java


> Add support for separate tables for update periods in one storage
> -
>
> Key: LENS-1386
> URL: https://issues.apache.org/jira/browse/LENS-1386
> Project: Apache Lens
>  Issue Type: Task
>  Components: api, cube, server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: LENS-1386.patch
>
>
> Xsd and Metastore changes:
> (1) New Xsd construct
> (2) Create Fact Changes
> (3) CubeMetastoreClient changes for update period table name
> (4) Validation that TableDescription should only be available at either table 
> level or at update period level



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1386) Add support for separate tables for update periods in one storage

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874340#comment-15874340
 ] 

Hudson commented on LENS-1386:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit-Java8 #305 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/305/])
LENS-1386 : Add support for separate tables for update periods in one 
(amareshwari: rev f0dadd79bb626fe6f8bbf21569e3062aeb9be070)
* (edit) 
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
* (edit) lens-api/src/main/resources/cube-0.1.xsd
* (edit) 
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java
* (edit) 
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
* (edit) 
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java
* (edit) 
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java
* (edit) lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java
* (edit) 
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
* (edit) 
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java


> Add support for separate tables for update periods in one storage
> -
>
> Key: LENS-1386
> URL: https://issues.apache.org/jira/browse/LENS-1386
> Project: Apache Lens
>  Issue Type: Task
>  Components: api, cube, server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: LENS-1386.patch
>
>
> Xsd and Metastore changes:
> (1) New Xsd construct
> (2) Create Fact Changes
> (3) CubeMetastoreClient changes for update period table name
> (4) Validation that TableDescription should only be available at either table 
> level or at update period level



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56842: LENS-1389: Valid Update periods for a storage candidate should not be bigger than query time range

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56842/#review166068
---




lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 (line 230)


Can we fix TODO



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java (line 
748)


Unused ?



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java (line 
751)


unused ?



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
(line 303)


can we update the message to replace fact with storage. 
Also can we log max interval in this message .



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
(line 305)


Should we rename QUERY_INTERVAL_BIGGER_THAN_MAX to 
UPDATE_PERIOD_BIGGER_THAN_MAX ?



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
(line 310)


It seems wrong to prune an undate period if it can not cover a time range . 
We shuld keep it if it can partially cover a time range. 

Example Month + Day can cover time Range . 
Month alone can not cover the time range.



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
(line 313)


Should we call this QUERY_INTERVAL_SMALLER_THAN_UPDATE_PERIOD ?


- Puneet Gupta


On Feb. 20, 2017, 9:17 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56842/
> ---
> 
> (Updated Feb. 20, 2017, 9:17 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1389
> https://issues.apache.org/jira/browse/LENS-1389
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> This is causing test failure in lens-1381 branch.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> 771708132a7e9dfbcb1148329647a946425b9d42 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> bf6cc5c3e6d8fc6521a5b0f1ef3e0212f0111c7a 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  c7f2047b57ebc26244891d9bc48ad18ab0176fdd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fca86ec88b1dd0507d21ca1b414dcc6fb68317e3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> 3029589ae1db24330aebb6eaa34aa127c3576a04 
>   pom.xml 8ea64b77fff11d9f46be56437aed3b527bde0ff8 
> 
> Diff: https://reviews.apache.org/r/56842/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Created] (LENS-1390) Bug fixes after LENS-1386

[Lavkesh Lahngir (JIRA)]

Lavkesh Lahngir created LENS-1390:
-

 Summary: Bug fixes after LENS-1386
 Key: LENS-1390
 URL: https://issues.apache.org/jira/browse/LENS-1390
 Project: Apache Lens
  Issue Type: Bug
  Components: server
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir


Few necessary fixes to complete Lens-1386



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1390) Bug fixes after LENS-1386

[Lavkesh Lahngir (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1390:
--
Status: Patch Available  (was: Open)

> Bug fixes after LENS-1386
> -
>
> Key: LENS-1390
> URL: https://issues.apache.org/jira/browse/LENS-1390
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1390.patch
>
>
> Few necessary fixes to complete Lens-1386



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1390) Bug fixes after LENS-1386

[Lavkesh Lahngir (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1390:
--
Attachment: LENS-1390.patch

> Bug fixes after LENS-1386
> -
>
> Key: LENS-1390
> URL: https://issues.apache.org/jira/browse/LENS-1390
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1390.patch
>
>
> Few necessary fixes to complete Lens-1386



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On brach lens-1381

[Lavkesh Lahngir (JIRA)]

Lavkesh Lahngir created LENS-1391:
-

 Summary: Review comments for MaxCoveringFactResolver and 
LeastPartitionResolver On brach lens-1381
 Key: LENS-1391
 URL: https://issues.apache.org/jira/browse/LENS-1391
 Project: Apache Lens
  Issue Type: Task
  Components: server
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir


Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver

[Lavkesh Lahngir]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56858/
---

Review request for lens.


Bugs: LENS-1391
https://issues.apache.org/jira/browse/LENS-1391


Repository: lens


Description
---

MaxCoveringFactResolver and LeastPartitionResolver review comments


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 c7f2047b57ebc26244891d9bc48ad18ab0176fdd 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 
153df245cd2b79ee29991f98df36f57e4e029d2f 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
4664cde1786c2e6217a0d7aa7a26d1cc248bf532 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
fca86ec88b1dd0507d21ca1b414dcc6fb68317e3 

Diff: https://reviews.apache.org/r/56858/diff/


Testing
---


Thanks,

Lavkesh Lahngir

[jira] [Commented] (LENS-1390) Bug fixes after LENS-1386

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874886#comment-15874886
 ] 

Hadoop QA commented on LENS-1390:
-

Applied patch: 
[LENS-1390.patch|https://issues.apache.org/jira/secure/attachment/12853585/LENS-1390.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1224/

> Bug fixes after LENS-1386
> -
>
> Key: LENS-1390
> URL: https://issues.apache.org/jira/browse/LENS-1390
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1390.patch
>
>
> Few necessary fixes to complete Lens-1386



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1390) Bug fixes after LENS-1386

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1390:
--
   Resolution: Fixed
Fix Version/s: 2.7
   Status: Resolved  (was: Patch Available)

Committed. Thanks [~lavkesh]

> Bug fixes after LENS-1386
> -
>
> Key: LENS-1390
> URL: https://issues.apache.org/jira/browse/LENS-1390
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Affects Versions: 2.7
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: LENS-1390.patch
>
>
> Few necessary fixes to complete Lens-1386



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1390) Bug fixes after LENS-1386

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1390:
--
Affects Version/s: 2.7

> Bug fixes after LENS-1386
> -
>
> Key: LENS-1390
> URL: https://issues.apache.org/jira/browse/LENS-1390
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Affects Versions: 2.7
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: LENS-1390.patch
>
>
> Few necessary fixes to complete Lens-1386



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1390) Bug fixes after LENS-1386

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875358#comment-15875358
 ] 

Hudson commented on LENS-1390:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit #1386 (See 
[https://builds.apache.org/job/Lens-Commit/1386/])
LENS-1390 : Fix issues with updatePeriodTableDescriptor (amareshwari: rev 
bd344c7ff0f7f3eebe16ca9457d2fed2f29b61da)
* (edit) lens-examples/src/test/resources/yaml/dim_table2.yaml
* (edit) lens-examples/src/test/resources/yaml/customer_table.yaml
* (edit) lens-examples/src/test/resources/yaml/fact2.yaml
* (edit) lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml
* (edit) 
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java
* (edit) lens-examples/src/test/resources/yaml/rawfact.yaml
* (edit) lens-examples/src/test/resources/yaml/city_table.yaml
* (edit) lens-examples/src/test/resources/yaml/sales-raw-fact.yaml
* (edit) lens-api/src/main/resources/cube-0.1.xsd
* (edit) lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml
* (edit) lens-examples/src/test/resources/yaml/dim_table4.yaml
* (edit) lens-examples/src/test/resources/yaml/fact1.yaml
* (edit) lens-examples/src/test/resources/yaml/dim_table.yaml
* (edit) lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml
* (edit) lens-examples/src/test/resources/yaml/product_table.yaml


> Bug fixes after LENS-1386
> -
>
> Key: LENS-1390
> URL: https://issues.apache.org/jira/browse/LENS-1390
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Affects Versions: 2.7
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: LENS-1390.patch
>
>
> Few necessary fixes to complete Lens-1386



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1390) Bug fixes after LENS-1386

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875357#comment-15875357
 ] 

Hudson commented on LENS-1390:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit-Java8 #306 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/306/])
LENS-1390 : Fix issues with updatePeriodTableDescriptor (amareshwari: rev 
bd344c7ff0f7f3eebe16ca9457d2fed2f29b61da)
* (edit) lens-examples/src/test/resources/yaml/sales-raw-fact.yaml
* (edit) lens-examples/src/test/resources/yaml/fact1.yaml
* (edit) lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml
* (edit) lens-examples/src/test/resources/yaml/customer_table.yaml
* (edit) lens-examples/src/test/resources/yaml/dim_table2.yaml
* (edit) lens-examples/src/test/resources/yaml/dim_table4.yaml
* (edit) lens-examples/src/test/resources/yaml/city_table.yaml
* (edit) 
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java
* (edit) lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml
* (edit) lens-examples/src/test/resources/yaml/rawfact.yaml
* (edit) lens-examples/src/test/resources/yaml/dim_table.yaml
* (edit) lens-api/src/main/resources/cube-0.1.xsd
* (edit) lens-examples/src/test/resources/yaml/fact2.yaml
* (edit) lens-examples/src/test/resources/yaml/product_table.yaml
* (edit) lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml


> Bug fixes after LENS-1386
> -
>
> Key: LENS-1390
> URL: https://issues.apache.org/jira/browse/LENS-1390
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Affects Versions: 2.7
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: LENS-1390.patch
>
>
> Few necessary fixes to complete Lens-1386



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1387) Move Lens to java 8

[Amareshwari Sriramadasu (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875364#comment-15875364
 ] 

Amareshwari Sriramadasu commented on LENS-1387:
---

Have disabled build on https://builds.apache.org/job/Lens-Commit-Java8/, as 
Lens-commit build is now with java8.

> Move Lens to java 8
> ---
>
> Key: LENS-1387
> URL: https://issues.apache.org/jira/browse/LENS-1387
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: 2.7, build
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1387.01.patch, LENS-1387.02.patch
>
>
> Deprecating java7 and restricting lens to only compile with java 8 + 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1391:
---
Summary: Review comments for MaxCoveringFactResolver and 
LeastPartitionResolver On branch lens-1381  (was: Review comments for 
MaxCoveringFactResolver and LeastPartitionResolver On brach lens-1381)

> Review comments for MaxCoveringFactResolver and LeastPartitionResolver On 
> branch lens-1381
> --
>
> Key: LENS-1391
> URL: https://issues.apache.org/jira/browse/LENS-1391
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
>
> Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56858/#review166126
---



1. Can you commnet on https://github.com/sushilmohanty/incubator-lens/pull/4 
and metion which all comments are resolved 
2. Can you run test cases for lens-cube


lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 (line 257)


Comment is redundant ?



lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 


Removed ?



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 


Removed ?



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 


Removed ?


- Puneet Gupta


On Feb. 20, 2017, 5:39 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56858/
> ---
> 
> (Updated Feb. 20, 2017, 5:39 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1391
> https://issues.apache.org/jira/browse/LENS-1391
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> MaxCoveringFactResolver and LeastPartitionResolver review comments
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  c7f2047b57ebc26244891d9bc48ad18ab0176fdd 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java
>  153df245cd2b79ee29991f98df36f57e4e029d2f 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  4664cde1786c2e6217a0d7aa7a26d1cc248bf532 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fca86ec88b1dd0507d21ca1b414dcc6fb68317e3 
> 
> Diff: https://reviews.apache.org/r/56858/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>