[jira] [Created] (LENS-1395) Query launching fails with NPE because of schema inconsistency with derived cube

[Amareshwari Sriramadasu (JIRA)]

Amareshwari Sriramadasu created LENS-1395:
-

 Summary: Query launching fails with NPE because of schema 
inconsistency with derived cube
 Key: LENS-1395
 URL: https://issues.apache.org/jira/browse/LENS-1395
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Amareshwari Sriramadasu


If derived cube has an attribute or measure, which is not part of base cube, 
query launching fails with NPE without any trace for NPE.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56878: LENS-1394: Create DOAP file

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56878/#review166316
---



As suggested at https://projects.apache.org/create.html, shall we put the DOAP 
file in svn repository, instead of github? As including in github can make 
multiple copies of it going to different branches and tags, and will be part of 
our source releases.


doap_lens.rdf (line 37)


Lets point to http://lens.apache.org/mail-lists.html instead.



doap_lens.rdf (line 40)


Yes. Lets change it to http://projects.apache.org/category/big-data



doap_lens.rdf (line 41)


Lets update 'How to release' wiki to add entry in this file.


- Amareshwari Sriramadasu


On Feb. 21, 2017, 11:56 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56878/
> ---
> 
> (Updated Feb. 21, 2017, 11:56 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1394
> https://issues.apache.org/jira/browse/LENS-1394
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Create doap file for project to appear in projects.apache.org
> 
> 
> Diffs
> -
> 
>   doap_lens.rdf PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56878/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 56878: LENS-1394: Create DOAP file

[Raju Bairishetti]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56878/#review166293
---




doap_lens.rdf (line 30)


Analytic**s** instead of `Analytic` ?



doap_lens.rdf (line 40)


Must be under big-data category  
http://projects.apache.org/category/big-data


- Raju Bairishetti


On Feb. 21, 2017, 11:56 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56878/
> ---
> 
> (Updated Feb. 21, 2017, 11:56 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1394
> https://issues.apache.org/jira/browse/LENS-1394
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Create doap file for project to appear in projects.apache.org
> 
> 
> Diffs
> -
> 
>   doap_lens.rdf PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56878/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-1393) Update the javax mail version to current

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877275#comment-15877275
 ] 

Puneet Gupta commented on LENS-1393:


+1

> Update the javax mail version to current
> 
>
> Key: LENS-1393
> URL: https://issues.apache.org/jira/browse/LENS-1393
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
>
> Sending mail with the older version of javax mail was causing threads to 
> stuck because of connection timeout to the mail server was not honored. 
> Updating to the new version solves the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56878: LENS-1394: Create DOAP file

[Puneet Gupta]

> On Feb. 21, 2017, 3:33 p.m., Puneet Gupta wrote:
> > doap_lens.rdf, line 37
> > 
> >
> > Is this correct url for mailing list?
> 
> Rajat Khandelwal wrote:
> This is a link where mailing lists are mentioned. I copied the rdf file 
> from another project and replaced with corresponding values for our case.

ok


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56878/#review166170
---


On Feb. 21, 2017, 11:56 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56878/
> ---
> 
> (Updated Feb. 21, 2017, 11:56 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1394
> https://issues.apache.org/jira/browse/LENS-1394
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Create doap file for project to appear in projects.apache.org
> 
> 
> Diffs
> -
> 
>   doap_lens.rdf PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56878/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 56878: LENS-1394: Create DOAP file

[Rajat Khandelwal]

> On Feb. 21, 2017, 9:03 p.m., Puneet Gupta wrote:
> > doap_lens.rdf, line 37
> > 
> >
> > Is this correct url for mailing list?

This is a link where mailing lists are mentioned. I copied the rdf file from 
another project and replaced with corresponding values for our case.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56878/#review166170
---


On Feb. 21, 2017, 5:26 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56878/
> ---
> 
> (Updated Feb. 21, 2017, 5:26 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1394
> https://issues.apache.org/jira/browse/LENS-1394
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Create doap file for project to appear in projects.apache.org
> 
> 
> Diffs
> -
> 
>   doap_lens.rdf PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56878/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 56878: LENS-1394: Create DOAP file

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56878/#review166170
---




doap_lens.rdf (line 37)


Is this correct url for mailing list?



doap_lens.rdf (line 94)


This is a GA release



doap_lens.rdf (lines 99 - 100)


Can these be same ?

I think 

https://git-wip-us.apache.org/repos/asf/lens.git 
redirects to 
https://git-wip-us.apache.org/repos/asf?p=lens.git


- Puneet Gupta


On Feb. 21, 2017, 11:56 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56878/
> ---
> 
> (Updated Feb. 21, 2017, 11:56 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1394
> https://issues.apache.org/jira/browse/LENS-1394
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Create doap file for project to appear in projects.apache.org
> 
> 
> Diffs
> -
> 
>   doap_lens.rdf PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56878/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56858/#review166167
---




lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
(line 122)


But null does not make sense. We should pass the incomplete partitions. 
Lets have an online discussion on this if you feel otherwise.

cubeql.addCandidatePruningMsg() actually adds the message at 
StorageCandidate Level .


- Puneet Gupta


On Feb. 21, 2017, 12:12 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56858/
> ---
> 
> (Updated Feb. 21, 2017, 12:12 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1391
> https://issues.apache.org/jira/browse/LENS-1391
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> MaxCoveringFactResolver and LeastPartitionResolver review comments
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  c7f2047 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java
>  153df24 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  4664cde 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fca86ec 
> 
> Diff: https://reviews.apache.org/r/56858/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

[jira] [Commented] (LENS-1394) Create DOAP file

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875905#comment-15875905
 ] 

Hadoop QA commented on LENS-1394:
-

Applied patch: 
[LENS-1394.01.patch|https://issues.apache.org/jira/secure/attachment/12853730/LENS-1394.01.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1225/

> Create DOAP file
> 
>
> Key: LENS-1394
> URL: https://issues.apache.org/jira/browse/LENS-1394
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1394.01.patch
>
>
> Create doap file for project to appear in projects.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver

[Lavkesh Lahngir]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56858/
---

(Updated Feb. 21, 2017, 12:12 p.m.)


Review request for lens.


Bugs: LENS-1391
https://issues.apache.org/jira/browse/LENS-1391


Repository: lens


Description
---

MaxCoveringFactResolver and LeastPartitionResolver review comments


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 c7f2047 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 
153df24 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
4664cde 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
fca86ec 

Diff: https://reviews.apache.org/r/56858/diff/


Testing
---


Thanks,

Lavkesh Lahngir

[jira] [Updated] (LENS-1394) Create DOAP file

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1394:
---
Attachment: LENS-1394.01.patch

> Create DOAP file
> 
>
> Key: LENS-1394
> URL: https://issues.apache.org/jira/browse/LENS-1394
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1394.01.patch
>
>
> Create doap file for project to appear in projects.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1394) Create DOAP file

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875865#comment-15875865
 ] 

Rajat Khandelwal commented on LENS-1394:


Taking patch from reviewboard and attaching

> Create DOAP file
> 
>
> Key: LENS-1394
> URL: https://issues.apache.org/jira/browse/LENS-1394
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1394.01.patch
>
>
> Create doap file for project to appear in projects.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1394) Create DOAP file

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875864#comment-15875864
 ] 

Rajat Khandelwal commented on LENS-1394:


Created https://reviews.apache.org/r/56878/

> Create DOAP file
> 
>
> Key: LENS-1394
> URL: https://issues.apache.org/jira/browse/LENS-1394
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>Reporter: Rajat Khandelwal
>
> Create doap file for project to appear in projects.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (LENS-1394) Create DOAP file

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal reassigned LENS-1394:
--

Assignee: Rajat Khandelwal

> Create DOAP file
> 
>
> Key: LENS-1394
> URL: https://issues.apache.org/jira/browse/LENS-1394
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> Create doap file for project to appear in projects.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1394) Create DOAP file

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1394:
---
Status: Patch Available  (was: Open)

> Create DOAP file
> 
>
> Key: LENS-1394
> URL: https://issues.apache.org/jira/browse/LENS-1394
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> Create doap file for project to appear in projects.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 56878: LENS-1394: Create DOAP file

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56878/
---

Review request for lens.


Bugs: LENS-1394
https://issues.apache.org/jira/browse/LENS-1394


Repository: lens


Description
---

Create doap file for project to appear in projects.apache.org


Diffs
-

  doap_lens.rdf PRE-CREATION 

Diff: https://reviews.apache.org/r/56878/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 56842: LENS-1389: Valid Update periods for a storage candidate should not be bigger than query time range

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56842/
---

(Updated Feb. 21, 2017, 5:25 p.m.)


Review request for lens.


Bugs: LENS-1389
https://issues.apache.org/jira/browse/LENS-1389


Repository: lens


Description
---

This is causing test failure in lens-1381 branch.


Diffs (updated)
-

  doap_lens.rdf PRE-CREATION 
  
lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
 bdfa3a065bd24b507d26f3048dce42a58667be25 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
771708132a7e9dfbcb1148329647a946425b9d42 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
bf6cc5c3e6d8fc6521a5b0f1ef3e0212f0111c7a 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 c7f2047b57ebc26244891d9bc48ad18ab0176fdd 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
2ab7f4bee68f05d46a625b50de90e07874d21b81 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 
bb290346b23c6a2088cacd7834bc8a2a3e96fc07 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 
0c6465ac725b0b801a34818e114bbfdd065e972d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
fca86ec88b1dd0507d21ca1b414dcc6fb68317e3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
3029589ae1db24330aebb6eaa34aa127c3576a04 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
44847484d5558742be2ae7a0f4d62c6390f94977 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
cf937a8644501c879598e4d16ef8477b5d44a408 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
 15a8c383fff31e1b45aac85bf36189403372f251 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
d1a17b22a84eba825e24975b2ec82c17f2b334fe 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java 
e41502ba0c6e40cc134a74fb9abe2270c29d91e2 
  pom.xml 8ea64b77fff11d9f46be56437aed3b527bde0ff8 

Diff: https://reviews.apache.org/r/56842/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Created] (LENS-1394) Create DOAP file

[Rajat Khandelwal (JIRA)]

Rajat Khandelwal created LENS-1394:
--

 Summary: Create DOAP file
 Key: LENS-1394
 URL: https://issues.apache.org/jira/browse/LENS-1394
 Project: Apache Lens
  Issue Type: Task
  Components: docs
Reporter: Rajat Khandelwal


Create doap file for project to appear in projects.apache.org




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56858/#review166148
---




lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 
(line 70)


This should be done at candidate level and not at storage candidate level. 
Candidate.getParticipatingPartitions().size()



lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
(line 122)


passing null ? 
Should pass the incomplete partition details . This info will be stored in 
CandidateTablePruneCause#incompletePartitions and will be used for error 
message construction.



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 


Older comments seem more readable. Can you check once.



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 


Why this comment is dropped ?


- Puneet Gupta


On Feb. 21, 2017, 11:19 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56858/
> ---
> 
> (Updated Feb. 21, 2017, 11:19 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1391
> https://issues.apache.org/jira/browse/LENS-1391
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> MaxCoveringFactResolver and LeastPartitionResolver review comments
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  c7f2047 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java
>  153df24 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  4664cde 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fca86ec 
> 
> Diff: https://reviews.apache.org/r/56858/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver

[Lavkesh Lahngir]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56858/
---

(Updated Feb. 21, 2017, 11:19 a.m.)


Review request for lens.


Bugs: LENS-1391
https://issues.apache.org/jira/browse/LENS-1391


Repository: lens


Description
---

MaxCoveringFactResolver and LeastPartitionResolver review comments


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 c7f2047 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 
153df24 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
4664cde 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
fca86ec 

Diff: https://reviews.apache.org/r/56858/diff/


Testing
---


Thanks,

Lavkesh Lahngir

Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver

[Lavkesh Lahngir]

> On Feb. 21, 2017, 7:11 a.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java,
> >  line 156
> > 
> >
> > Removed ?

This is being calculated unnecessary.


- Lavkesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56858/#review166126
---


On Feb. 21, 2017, 10:10 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56858/
> ---
> 
> (Updated Feb. 21, 2017, 10:10 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1391
> https://issues.apache.org/jira/browse/LENS-1391
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> MaxCoveringFactResolver and LeastPartitionResolver review comments
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  c7f2047 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java
>  153df24 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  4664cde 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fca86ec 
> 
> Diff: https://reviews.apache.org/r/56858/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

[jira] [Updated] (LENS-1392) Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1392:
---
Status: Patch Available  (was: In Progress)

> Fix  failing TestCases in 
> org.apache.lens.server.query.QueryAPIErrorResponseTest
> 
>
> Key: LENS-1392
> URL: https://issues.apache.org/jira/browse/LENS-1392
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: lens-1392.patch
>
>
> Failed tests:
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield8d6e29df822945c49ea03d3533806cca can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield8d6e29df822945c49ea03d3533806cca]]
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield16cc374b445443a6ae8fce39fad190d1 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield16cc374b445443a6ae8fce39fad190d1]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfieldc7f0b34c257d4fde80dacaaf0d61d600 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfieldc7f0b34c257d4fde80dacaaf0d61d600]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfield3931859c8fdf47a49beaadba222915d6 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfield3931859c8fdf47a49beaadba222915d6]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield4b536214dcf0413e9bd7190d9efa139b can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield4b536214dcf0413e9bd7190d9efa139b]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield85771da365a44789a42fd8f800fbbe50 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield85771da365a44789a42fd8f800fbbe50]]
> Tests run: 321, Failures: 6, Errors: 0, Skipped: 18



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1392) Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1392:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Fix  failing TestCases in 
> org.apache.lens.server.query.QueryAPIErrorResponseTest
> 
>
> Key: LENS-1392
> URL: https://issues.apache.org/jira/browse/LENS-1392
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: lens-1392.patch
>
>
> Failed tests:
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield8d6e29df822945c49ea03d3533806cca can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield8d6e29df822945c49ea03d3533806cca]]
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield16cc374b445443a6ae8fce39fad190d1 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield16cc374b445443a6ae8fce39fad190d1]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfieldc7f0b34c257d4fde80dacaaf0d61d600 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfieldc7f0b34c257d4fde80dacaaf0d61d600]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfield3931859c8fdf47a49beaadba222915d6 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfield3931859c8fdf47a49beaadba222915d6]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield4b536214dcf0413e9bd7190d9efa139b can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield4b536214dcf0413e9bd7190d9efa139b]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield85771da365a44789a42fd8f800fbbe50 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield85771da365a44789a42fd8f800fbbe50]]
> Tests run: 321, Failures: 6, Errors: 0, Skipped: 18



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1392) Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875792#comment-15875792
 ] 

Puneet Gupta commented on LENS-1392:


Committed myself. 

> Fix  failing TestCases in 
> org.apache.lens.server.query.QueryAPIErrorResponseTest
> 
>
> Key: LENS-1392
> URL: https://issues.apache.org/jira/browse/LENS-1392
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: lens-1392.patch
>
>
> Failed tests:
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield8d6e29df822945c49ea03d3533806cca can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield8d6e29df822945c49ea03d3533806cca]]
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield16cc374b445443a6ae8fce39fad190d1 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield16cc374b445443a6ae8fce39fad190d1]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfieldc7f0b34c257d4fde80dacaaf0d61d600 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfieldc7f0b34c257d4fde80dacaaf0d61d600]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfield3931859c8fdf47a49beaadba222915d6 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfield3931859c8fdf47a49beaadba222915d6]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield4b536214dcf0413e9bd7190d9efa139b can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield4b536214dcf0413e9bd7190d9efa139b]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield85771da365a44789a42fd8f800fbbe50 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield85771da365a44789a42fd8f800fbbe50]]
> Tests run: 321, Failures: 6, Errors: 0, Skipped: 18



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1392) Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1392:
---
Attachment: lens-1392.patch

Taking patch form review board and attaching 

https://reviews.apache.org/r/56877/

> Fix  failing TestCases in 
> org.apache.lens.server.query.QueryAPIErrorResponseTest
> 
>
> Key: LENS-1392
> URL: https://issues.apache.org/jira/browse/LENS-1392
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: lens-1392.patch
>
>
> Failed tests:
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield8d6e29df822945c49ea03d3533806cca can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield8d6e29df822945c49ea03d3533806cca]]
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield16cc374b445443a6ae8fce39fad190d1 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield16cc374b445443a6ae8fce39fad190d1]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfieldc7f0b34c257d4fde80dacaaf0d61d600 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfieldc7f0b34c257d4fde80dacaaf0d61d600]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfield3931859c8fdf47a49beaadba222915d6 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfield3931859c8fdf47a49beaadba222915d6]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield4b536214dcf0413e9bd7190d9efa139b can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield4b536214dcf0413e9bd7190d9efa139b]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield85771da365a44789a42fd8f800fbbe50 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield85771da365a44789a42fd8f800fbbe50]]
> Tests run: 321, Failures: 6, Errors: 0, Skipped: 18



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56877: LENS-1392: Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56877/#review166147
---


Ship it!




Ship It!

- Rajat Khandelwal


On Feb. 21, 2017, 4:23 p.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56877/
> ---
> 
> (Updated Feb. 21, 2017, 4:23 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: lens-1392
> https://issues.apache.org/jira/browse/lens-1392
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 1. Fix for test failures in QueryAPIErrorResponseTest. 
> 2. Promoted JoinResolver and TimeRangeChecker above storageTableResolver 
> CubeQueryRewriter#setupRewriters
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 4dd3d007e1629331bdffdbfc67801b3dbe573630 
>   
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 
> 02e2f8b173848f1688cfaad1ba19483d5470ceed 
>   lens-server/src/test/java/org/apache/lens/server/common/TestDataUtils.java 
> 040051955a9b83e4b4fd1ebb99194b46db569924 
>   
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
>  567c92934fdaa58252ebe6726712dc76ac3edd0d 
> 
> Diff: https://reviews.apache.org/r/56877/diff/
> 
> 
> Testing
> ---
> 
> QueryAPIErrorResponseTest Test cases
> 
> 
> Thanks,
> 
> Puneet Gupta
> 
>

Review Request 56877: LENS-1392: Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56877/
---

Review request for lens.


Bugs: lens-1392
https://issues.apache.org/jira/browse/lens-1392


Repository: lens


Description
---

1. Fix for test failures in QueryAPIErrorResponseTest. 
2. Promoted JoinResolver and TimeRangeChecker above storageTableResolver 
CubeQueryRewriter#setupRewriters


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
4dd3d007e1629331bdffdbfc67801b3dbe573630 
  lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 
02e2f8b173848f1688cfaad1ba19483d5470ceed 
  lens-server/src/test/java/org/apache/lens/server/common/TestDataUtils.java 
040051955a9b83e4b4fd1ebb99194b46db569924 
  
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
 567c92934fdaa58252ebe6726712dc76ac3edd0d 

Diff: https://reviews.apache.org/r/56877/diff/


Testing
---

QueryAPIErrorResponseTest Test cases


Thanks,

Puneet Gupta

[jira] [Work started] (LENS-1392) Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1392 started by Puneet Gupta.
--
> Fix  failing TestCases in 
> org.apache.lens.server.query.QueryAPIErrorResponseTest
> 
>
> Key: LENS-1392
> URL: https://issues.apache.org/jira/browse/LENS-1392
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
>
> Failed tests:
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield8d6e29df822945c49ea03d3533806cca can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield8d6e29df822945c49ea03d3533806cca]]
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield16cc374b445443a6ae8fce39fad190d1 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield16cc374b445443a6ae8fce39fad190d1]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfieldc7f0b34c257d4fde80dacaaf0d61d600 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfieldc7f0b34c257d4fde80dacaaf0d61d600]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfield3931859c8fdf47a49beaadba222915d6 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfield3931859c8fdf47a49beaadba222915d6]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield4b536214dcf0413e9bd7190d9efa139b can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield4b536214dcf0413e9bd7190d9efa139b]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield85771da365a44789a42fd8f800fbbe50 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield85771da365a44789a42fd8f800fbbe50]]
> Tests run: 321, Failures: 6, Errors: 0, Skipped: 18



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (LENS-1393) Update the javax mail version to current

[Lavkesh Lahngir (JIRA)]

Lavkesh Lahngir created LENS-1393:
-

 Summary: Update the javax mail version to current
 Key: LENS-1393
 URL: https://issues.apache.org/jira/browse/LENS-1393
 Project: Apache Lens
  Issue Type: Task
  Components: server
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir


Sending mail with the older version of javax mail was causing threads to stuck 
because of connection timeout to the mail server was not honored. Updating to 
the new version solves the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (LENS-1392) Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-1392:
--

 Summary: Fix  failing TestCases in 
org.apache.lens.server.query.QueryAPIErrorResponseTest
 Key: LENS-1392
 URL: https://issues.apache.org/jira/browse/LENS-1392
 Project: Apache Lens
  Issue Type: Sub-task
  Components: server
Reporter: Puneet Gupta
Assignee: Puneet Gupta


Failed tests:
QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
 expected [dimfield8d6e29df822945c49ea03d3533806cca can only be queried after 
Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
11:00:00 PM UTC. Please adjust the selected time range accordingly.] but found 
[No fact table has the queried columns : 
[dimfield8d6e29df822945c49ea03d3533806cca]]
QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
 expected [dimfield16cc374b445443a6ae8fce39fad190d1 can only be queried after 
Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
11:00:00 PM UTC. Please adjust the selected time range accordingly.] but found 
[No fact table has the queried columns : 
[dimfield16cc374b445443a6ae8fce39fad190d1]]
QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
 expected [dimfieldc7f0b34c257d4fde80dacaaf0d61d600 can only be queried before 
Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected time range 
accordingly.] but found [No fact table has the queried columns : 
[dimfieldc7f0b34c257d4fde80dacaaf0d61d600]]
QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
 expected [dimfield3931859c8fdf47a49beaadba222915d6 can only be queried before 
Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected time range 
accordingly.] but found [No fact table has the queried columns : 
[dimfield3931859c8fdf47a49beaadba222915d6]]
QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
 expected [dimfield4b536214dcf0413e9bd7190d9efa139b can only be queried after 
Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
range accordingly.] but found [No fact table has the queried columns : 
[dimfield4b536214dcf0413e9bd7190d9efa139b]]
QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
 expected [dimfield85771da365a44789a42fd8f800fbbe50 can only be queried after 
Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
range accordingly.] but found [No fact table has the queried columns : 
[dimfield85771da365a44789a42fd8f800fbbe50]]
Tests run: 321, Failures: 6, Errors: 0, Skipped: 18



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver

[Lavkesh Lahngir]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56858/
---

(Updated Feb. 21, 2017, 10:10 a.m.)


Review request for lens.


Bugs: LENS-1391
https://issues.apache.org/jira/browse/LENS-1391


Repository: lens


Description
---

MaxCoveringFactResolver and LeastPartitionResolver review comments


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 c7f2047 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 
153df24 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
4664cde 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
fca86ec 

Diff: https://reviews.apache.org/r/56858/diff/


Testing
---


Thanks,

Lavkesh Lahngir