[jira] [Commented] (LENS-615) Refactoring of testQueryCommands test case

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964649#comment-14964649
 ] 

Hudson commented on LENS-615:
-

UNSTABLE: Integrated in Lens-Commit-Java8 #23 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/23/])
LENS-615 : Refactor TestLensQueryCommands.testQueryCommands testcase 
(amareshwari: rev ae02b8f5f41162ef9ad33f1da7bbbee48d499926)
* lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java


> Refactoring of testQueryCommands test case
> --
>
> Key: LENS-615
> URL: https://issues.apache.org/jira/browse/LENS-615
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: client
>Reporter: Himanshu Gahlaut
>Assignee: Gabor Liptak
>  Labels: newbie
> Fix For: 2.5
>
> Attachments: rb39191.1.patch, rb39191.patch
>
>
> There are too many test cases running in testQueryCommands test case. It is 
> considerably time consuming to debug a failing test case within  
> testQueryCommands. If these test cases are modularized and broken into 
> separate test cases, it will be much helpful in faster debugging.
> {code}
> @Test
>   public void testQueryCommands() throws Exception {
> client = new LensClient();
> 
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver", 
> "false");
> setup(client);
> LensQueryCommands qCom = new LensQueryCommands();
> qCom.setClient(client);
> resDir = new File("target/results");
> assertTrue(resDir.exists() || resDir.mkdirs());
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
> // run all query commands with query metrics enabled.
> client = new LensClient();
> 
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver", 
> "false");
> client.setConnectionParam("lens.query.enable.metrics.per.query", "true");
> qCom.setClient(client);
> String result = qCom.getAllPreparedQueries("all", "", -1, -1);
> assertEquals(result, "No prepared queries");
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-615) Refactoring of testQueryCommands test case

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964615#comment-14964615
 ] 

Hudson commented on LENS-615:
-

FAILURE: Integrated in Lens-Commit #1113 (See 
[https://builds.apache.org/job/Lens-Commit/1113/])
LENS-615 : Refactor TestLensQueryCommands.testQueryCommands testcase 
(amareshwari: rev ae02b8f5f41162ef9ad33f1da7bbbee48d499926)
* lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java


> Refactoring of testQueryCommands test case
> --
>
> Key: LENS-615
> URL: https://issues.apache.org/jira/browse/LENS-615
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: client
>Reporter: Himanshu Gahlaut
>Assignee: Gabor Liptak
>  Labels: newbie
> Fix For: 2.5
>
> Attachments: rb39191.1.patch, rb39191.patch
>
>
> There are too many test cases running in testQueryCommands test case. It is 
> considerably time consuming to debug a failing test case within  
> testQueryCommands. If these test cases are modularized and broken into 
> separate test cases, it will be much helpful in faster debugging.
> {code}
> @Test
>   public void testQueryCommands() throws Exception {
> client = new LensClient();
> 
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver", 
> "false");
> setup(client);
> LensQueryCommands qCom = new LensQueryCommands();
> qCom.setClient(client);
> resDir = new File("target/results");
> assertTrue(resDir.exists() || resDir.mkdirs());
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
> // run all query commands with query metrics enabled.
> client = new LensClient();
> 
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver", 
> "false");
> client.setConnectionParam("lens.query.enable.metrics.per.query", "true");
> qCom.setClient(client);
> String result = qCom.getAllPreparedQueries("all", "", -1, -1);
> assertEquals(result, "No prepared queries");
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-615) Refactoring of testQueryCommands test case

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962740#comment-14962740
 ] 

Hadoop QA commented on LENS-615:


Applied patch: 
[rb39191.1.patch|https://issues.apache.org/jira/secure/attachment/12767273/rb39191.1.patch]
 and ran command: mvn clean install. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/137/

> Refactoring of testQueryCommands test case
> --
>
> Key: LENS-615
> URL: https://issues.apache.org/jira/browse/LENS-615
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: client
>Reporter: Himanshu Gahlaut
>Assignee: Gabor Liptak
>  Labels: newbie
> Attachments: rb39191.1.patch, rb39191.patch
>
>
> There are too many test cases running in testQueryCommands test case. It is 
> considerably time consuming to debug a failing test case within  
> testQueryCommands. If these test cases are modularized and broken into 
> separate test cases, it will be much helpful in faster debugging.
> {code}
> @Test
>   public void testQueryCommands() throws Exception {
> client = new LensClient();
> 
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver", 
> "false");
> setup(client);
> LensQueryCommands qCom = new LensQueryCommands();
> qCom.setClient(client);
> resDir = new File("target/results");
> assertTrue(resDir.exists() || resDir.mkdirs());
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
> // run all query commands with query metrics enabled.
> client = new LensClient();
> 
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver", 
> "false");
> client.setConnectionParam("lens.query.enable.metrics.per.query", "true");
> qCom.setClient(client);
> String result = qCom.getAllPreparedQueries("all", "", -1, -1);
> assertEquals(result, "No prepared queries");
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-615) Refactoring of testQueryCommands test case

[Raju Bairishetti (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962719#comment-14962719
 ] 

Raju Bairishetti commented on LENS-615:
---

[~gliptak] Could you please fix the check style errors in the attached patch?

Errors: https://builds.apache.org/job/PreCommit-Lens-Build/136/

[INFO] Starting audit...
/home/jenkins/jenkins-slave/workspace/PreCommit-Lens-Build/lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:79:
 array initialization lcurly at indentation level 12 not at correct 
indentation, 6
/home/jenkins/jenkins-slave/workspace/PreCommit-Lens-Build/lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:80:
 array initialization lcurly at indentation level 12 not at correct 
indentation, 6
/home/jenkins/jenkins-slave/workspace/PreCommit-Lens-Build/lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java:81:
 Array should contain trailing comma.
Audit done.

[INFO] There are 3 checkstyle errors.
[INFO] ---


> Refactoring of testQueryCommands test case
> --
>
> Key: LENS-615
> URL: https://issues.apache.org/jira/browse/LENS-615
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: client
>Reporter: Himanshu Gahlaut
>Assignee: Gabor Liptak
>  Labels: newbie
> Attachments: rb39191.patch
>
>
> There are too many test cases running in testQueryCommands test case. It is 
> considerably time consuming to debug a failing test case within  
> testQueryCommands. If these test cases are modularized and broken into 
> separate test cases, it will be much helpful in faster debugging.
> {code}
> @Test
>   public void testQueryCommands() throws Exception {
> client = new LensClient();
> 
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver", 
> "false");
> setup(client);
> LensQueryCommands qCom = new LensQueryCommands();
> qCom.setClient(client);
> resDir = new File("target/results");
> assertTrue(resDir.exists() || resDir.mkdirs());
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
> // run all query commands with query metrics enabled.
> client = new LensClient();
> 
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver", 
> "false");
> client.setConnectionParam("lens.query.enable.metrics.per.query", "true");
> qCom.setClient(client);
> String result = qCom.getAllPreparedQueries("all", "", -1, -1);
> assertEquals(result, "No prepared queries");
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-615) Refactoring of testQueryCommands test case

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960834#comment-14960834
 ] 

Hadoop QA commented on LENS-615:


Applied patch: 
[rb39191.patch|https://issues.apache.org/jira/secure/attachment/12767079/rb39191.patch]
 and ran command: mvn clean install. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/136/

> Refactoring of testQueryCommands test case
> --
>
> Key: LENS-615
> URL: https://issues.apache.org/jira/browse/LENS-615
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: client
>Reporter: Himanshu Gahlaut
>Assignee: Gabor Liptak
>  Labels: newbie
> Attachments: rb39191.patch
>
>
> There are too many test cases running in testQueryCommands test case. It is 
> considerably time consuming to debug a failing test case within  
> testQueryCommands. If these test cases are modularized and broken into 
> separate test cases, it will be much helpful in faster debugging.
> {code}
> @Test
>   public void testQueryCommands() throws Exception {
> client = new LensClient();
> 
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver", 
> "false");
> setup(client);
> LensQueryCommands qCom = new LensQueryCommands();
> qCom.setClient(client);
> resDir = new File("target/results");
> assertTrue(resDir.exists() || resDir.mkdirs());
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
> // run all query commands with query metrics enabled.
> client = new LensClient();
> 
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver", 
> "false");
> client.setConnectionParam("lens.query.enable.metrics.per.query", "true");
> qCom.setClient(client);
> String result = qCom.getAllPreparedQueries("all", "", -1, -1);
> assertEquals(result, "No prepared queries");
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-615) Refactoring of testQueryCommands test case

[Gabor Liptak (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951292#comment-14951292
 ] 

Gabor Liptak commented on LENS-615:
---

I published to RB as

https://reviews.apache.org/r/39191/

(The link on the right side doesn't get there ...)

> Refactoring of testQueryCommands test case
> --
>
> Key: LENS-615
> URL: https://issues.apache.org/jira/browse/LENS-615
> Project: Apache Lens
>  Issue Type: Improvement
>Reporter: Himanshu Gahlaut
>Assignee: Gabor Liptak
>  Labels: newbie
>
> There are too many test cases running in testQueryCommands test case. It is 
> considerably time consuming to debug a failing test case within  
> testQueryCommands. If these test cases are modularized and broken into 
> separate test cases, it will be much helpful in faster debugging.
> {code}
> @Test
>   public void testQueryCommands() throws Exception {
> client = new LensClient();
> 
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver", 
> "false");
> setup(client);
> LensQueryCommands qCom = new LensQueryCommands();
> qCom.setClient(client);
> resDir = new File("target/results");
> assertTrue(resDir.exists() || resDir.mkdirs());
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
> // run all query commands with query metrics enabled.
> client = new LensClient();
> 
> client.setConnectionParam("lens.query.enable.persistent.resultset.indriver", 
> "false");
> client.setConnectionParam("lens.query.enable.metrics.per.query", "true");
> qCom.setClient(client);
> String result = qCom.getAllPreparedQueries("all", "", -1, -1);
> assertEquals(result, "No prepared queries");
> testExecuteSyncQuery(qCom);
> testExecuteAsyncQuery(qCom);
> testSyncResults(qCom);
> testExplainQuery(qCom);
> testExplainFailQuery(qCom);
> testPreparedQuery(qCom);
> testShowPersistentResultSet(qCom);
> testPurgedFinishedResultSet(qCom);
> testFailPreparedQuery(qCom);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)