subject:"Re\: Review Request 38889\: LENS\-795\: Look ahead is failing with partition not found if any process time partitions are absent"

Re: Review Request 38889: LENS-795: Look ahead is failing with partition not found if any process time partitions are absent

2015-09-30 Thread Sushil Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38889/#review101108
---

Ship it!


Ship It!

- Sushil Mohanty


On Sept. 30, 2015, 12:14 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38889/
> ---
> 
> (Updated Sept. 30, 2015, 12:14 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-795
> https://issues.apache.org/jira/browse/LENS-795
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes:
> 
> 1. Missing partition should not matter if the partition is missing on a part 
> column not required.
> 1.1. Look ahead part column's missing partitions are okay
> 1.2. Fallback partition columns' missing partitions are to be considered 
> as missing
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java
>  b389a8f3a5257833834f389163b27c7040aedf69 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> 68ab5ab8a7441635f7acbe61e4ab9192056118cc 
> 
> Diff: https://reviews.apache.org/r/38889/diff/
> 
> 
> Testing
> ---
> 
> ---
>  T E S T S
> ---
> Running TestSuite
> Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 508.822 sec 
> <<< FAILURE! - in TestSuite
> trainAndEvalFromDir(org.apache.lens.ml.TestMLRunner)  Time elapsed: 2.21 sec  
> <<< FAILURE!
> java.lang.AssertionError: expected [SUCCESSFUL] but found [FAILED]
>   at org.testng.Assert.fail(Assert.java:94)
>   at org.testng.Assert.failNotEquals(Assert.java:494)
>   at org.testng.Assert.assertEquals(Assert.java:123)
>   at org.testng.Assert.assertEquals(Assert.java:165)
>   at 
> org.apache.lens.ml.TestMLRunner.trainAndEvalFromDir(TestMLRunner.java:132)
> 
> 
> Results :
> 
> Failed tests: 
>   TestMLRunner.trainAndEvalFromDir:132 expected [SUCCESSFUL] but found 
> [FAILED]
> 
> Tests run: 6, Failures: 1, Errors: 0, Skipped: 0
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1:08.377s]
> [INFO] Lens .. SUCCESS [38.321s]
> [INFO] Lens API .. SUCCESS [1:54.490s]
> [INFO] Lens API for server and extensions  SUCCESS [1:44.559s]
> [INFO] Lens Cube . SUCCESS 
> [26:20.812s]
> [INFO] Lens DB storage ... SUCCESS [2:37.722s]
> [INFO] Lens Query Library  SUCCESS [49.289s]
> [INFO] Lens Hive Driver .. SUCCESS [9:33.923s]
> [INFO] Lens Driver for JDBC .. SUCCESS [4:48.278s]
> [INFO] Lens Elastic Search Driver  SUCCESS [1:00.712s]
> [INFO] Lens Server ... SUCCESS 
> [43:09.453s]
> [INFO] Lens client ... SUCCESS [3:28.307s]
> [INFO] Lens CLI .. SUCCESS 
> [12:21.291s]
> [INFO] Lens Examples . SUCCESS [29.909s]
> [INFO] Lens Distribution . SUCCESS [1:04.494s]
> [INFO] Lens ML Lib ... FAILURE [9:25.823s]
> [INFO] Lens ML Ext Distribution .. SKIPPED
> [INFO] Lens Regression ... SKIPPED
> [INFO] Lens UI ... SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 2:01:17.504s
> [INFO] Finished at: Wed Sep 30 11:56:50 UTC 2015
> [INFO] Final Memory: 136M/347M
> [INFO] 
> 
> 
> 
> The failure is unrelated and seems intermittent. When run separately, the 
> test case passed. Running again though.
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 38889: LENS-795: Look ahead is failing with partition not found if any process time partitions are absent

2015-09-30 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38889/
---

(Updated Sept. 30, 2015, 6:26 p.m.)


Review request for lens.


Bugs: LENS-795
https://issues.apache.org/jira/browse/LENS-795


Repository: lens


Description
---

Changes:

1. Missing partition should not matter if the partition is missing on a part 
column not required.
1.1. Look ahead part column's missing partitions are okay
1.2. Fallback partition columns' missing partitions are to be considered as 
missing


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java
 b389a8f3a5257833834f389163b27c7040aedf69 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
68ab5ab8a7441635f7acbe61e4ab9192056118cc 

Diff: https://reviews.apache.org/r/38889/diff/


Testing
---

---
 T E S T S
---
Running TestSuite
Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 508.822 sec <<< 
FAILURE! - in TestSuite
trainAndEvalFromDir(org.apache.lens.ml.TestMLRunner)  Time elapsed: 2.21 sec  
<<< FAILURE!
java.lang.AssertionError: expected [SUCCESSFUL] but found [FAILED]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:494)
at org.testng.Assert.assertEquals(Assert.java:123)
at org.testng.Assert.assertEquals(Assert.java:165)
at 
org.apache.lens.ml.TestMLRunner.trainAndEvalFromDir(TestMLRunner.java:132)


Results :

Failed tests: 
  TestMLRunner.trainAndEvalFromDir:132 expected [SUCCESSFUL] but found [FAILED]

Tests run: 6, Failures: 1, Errors: 0, Skipped: 0

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1:08.377s]
[INFO] Lens .. SUCCESS [38.321s]
[INFO] Lens API .. SUCCESS [1:54.490s]
[INFO] Lens API for server and extensions  SUCCESS [1:44.559s]
[INFO] Lens Cube . SUCCESS [26:20.812s]
[INFO] Lens DB storage ... SUCCESS [2:37.722s]
[INFO] Lens Query Library  SUCCESS [49.289s]
[INFO] Lens Hive Driver .. SUCCESS [9:33.923s]
[INFO] Lens Driver for JDBC .. SUCCESS [4:48.278s]
[INFO] Lens Elastic Search Driver  SUCCESS [1:00.712s]
[INFO] Lens Server ... SUCCESS [43:09.453s]
[INFO] Lens client ... SUCCESS [3:28.307s]
[INFO] Lens CLI .. SUCCESS [12:21.291s]
[INFO] Lens Examples . SUCCESS [29.909s]
[INFO] Lens Distribution . SUCCESS [1:04.494s]
[INFO] Lens ML Lib ... FAILURE [9:25.823s]
[INFO] Lens ML Ext Distribution .. SKIPPED
[INFO] Lens Regression ... SKIPPED
[INFO] Lens UI ... SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 2:01:17.504s
[INFO] Finished at: Wed Sep 30 11:56:50 UTC 2015
[INFO] Final Memory: 136M/347M
[INFO] 


The failure is unrelated and seems intermittent. When run separately, the test 
case passed. Running again though.


Thanks,

Rajat Khandelwal

Re: Review Request 38889: LENS-795: Look ahead is failing with partition not found if any process time partitions are absent

2015-09-30 Thread Raju Bairishetti


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38889/#review101107
---



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
(line 696)


can we make it private instead of package private?

Patch looks good to me otherwise.


- Raju Bairishetti


On Sept. 30, 2015, 9:50 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38889/
> ---
> 
> (Updated Sept. 30, 2015, 9:50 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-795
> https://issues.apache.org/jira/browse/LENS-795
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes:
> 
> 1. Missing partition should not matter if the partition is missing on a part 
> column not required.
> 1.1. Look ahead part column's missing partitions are okay
> 1.2. Fallback partition columns' missing partitions are to be considered 
> as missing
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java
>  b389a8f3a5257833834f389163b27c7040aedf69 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> 68ab5ab8a7441635f7acbe61e4ab9192056118cc 
> 
> Diff: https://reviews.apache.org/r/38889/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 38889: LENS-795: Look ahead is failing with partition not found if any process time partitions are absent

2015-09-30 Thread Rajat Khandelwal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38889/
---

(Updated Sept. 30, 2015, 5:44 p.m.)


Review request for lens.


Bugs: LENS-795
https://issues.apache.org/jira/browse/LENS-795


Repository: lens


Description
---

Changes:

1. Missing partition should not matter if the partition is missing on a part 
column not required.
1.1. Look ahead part column's missing partitions are okay
1.2. Fallback partition columns' missing partitions are to be considered as 
missing


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java
 b389a8f3a5257833834f389163b27c7040aedf69 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
68ab5ab8a7441635f7acbe61e4ab9192056118cc 

Diff: https://reviews.apache.org/r/38889/diff/


Testing (updated)
---

---
 T E S T S
---
Running TestSuite
Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 508.822 sec <<< 
FAILURE! - in TestSuite
trainAndEvalFromDir(org.apache.lens.ml.TestMLRunner)  Time elapsed: 2.21 sec  
<<< FAILURE!
java.lang.AssertionError: expected [SUCCESSFUL] but found [FAILED]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:494)
at org.testng.Assert.assertEquals(Assert.java:123)
at org.testng.Assert.assertEquals(Assert.java:165)
at 
org.apache.lens.ml.TestMLRunner.trainAndEvalFromDir(TestMLRunner.java:132)


Results :

Failed tests: 
  TestMLRunner.trainAndEvalFromDir:132 expected [SUCCESSFUL] but found [FAILED]

Tests run: 6, Failures: 1, Errors: 0, Skipped: 0

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1:08.377s]
[INFO] Lens .. SUCCESS [38.321s]
[INFO] Lens API .. SUCCESS [1:54.490s]
[INFO] Lens API for server and extensions  SUCCESS [1:44.559s]
[INFO] Lens Cube . SUCCESS [26:20.812s]
[INFO] Lens DB storage ... SUCCESS [2:37.722s]
[INFO] Lens Query Library  SUCCESS [49.289s]
[INFO] Lens Hive Driver .. SUCCESS [9:33.923s]
[INFO] Lens Driver for JDBC .. SUCCESS [4:48.278s]
[INFO] Lens Elastic Search Driver  SUCCESS [1:00.712s]
[INFO] Lens Server ... SUCCESS [43:09.453s]
[INFO] Lens client ... SUCCESS [3:28.307s]
[INFO] Lens CLI .. SUCCESS [12:21.291s]
[INFO] Lens Examples . SUCCESS [29.909s]
[INFO] Lens Distribution . SUCCESS [1:04.494s]
[INFO] Lens ML Lib ... FAILURE [9:25.823s]
[INFO] Lens ML Ext Distribution .. SKIPPED
[INFO] Lens Regression ... SKIPPED
[INFO] Lens UI ... SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 2:01:17.504s
[INFO] Finished at: Wed Sep 30 11:56:50 UTC 2015
[INFO] Final Memory: 136M/347M
[INFO] 


The failure is unrelated and seems intermittent. When run separately, the test 
case passed. Running again though.


Thanks,

Rajat Khandelwal

Re: Review Request 38889: LENS-795: Look ahead is failing with partition not found if any process time partitions are absent

2015-09-30 Thread Raju Bairishetti


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38889/#review101109
---

Ship it!


Test failed in ML module. Tracking already at 
[LENS-660|https://issues.apache.org/jira/browse/LENS-660].

- Raju Bairishetti


On Sept. 30, 2015, 12:14 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38889/
> ---
> 
> (Updated Sept. 30, 2015, 12:14 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-795
> https://issues.apache.org/jira/browse/LENS-795
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Changes:
> 
> 1. Missing partition should not matter if the partition is missing on a part 
> column not required.
> 1.1. Look ahead part column's missing partitions are okay
> 1.2. Fallback partition columns' missing partitions are to be considered 
> as missing
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/PartitionRangesForPartitionColumns.java
>  b389a8f3a5257833834f389163b27c7040aedf69 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> 68ab5ab8a7441635f7acbe61e4ab9192056118cc 
> 
> Diff: https://reviews.apache.org/r/38889/diff/
> 
> 
> Testing
> ---
> 
> ---
>  T E S T S
> ---
> Running TestSuite
> Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 508.822 sec 
> <<< FAILURE! - in TestSuite
> trainAndEvalFromDir(org.apache.lens.ml.TestMLRunner)  Time elapsed: 2.21 sec  
> <<< FAILURE!
> java.lang.AssertionError: expected [SUCCESSFUL] but found [FAILED]
>   at org.testng.Assert.fail(Assert.java:94)
>   at org.testng.Assert.failNotEquals(Assert.java:494)
>   at org.testng.Assert.assertEquals(Assert.java:123)
>   at org.testng.Assert.assertEquals(Assert.java:165)
>   at 
> org.apache.lens.ml.TestMLRunner.trainAndEvalFromDir(TestMLRunner.java:132)
> 
> 
> Results :
> 
> Failed tests: 
>   TestMLRunner.trainAndEvalFromDir:132 expected [SUCCESSFUL] but found 
> [FAILED]
> 
> Tests run: 6, Failures: 1, Errors: 0, Skipped: 0
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1:08.377s]
> [INFO] Lens .. SUCCESS [38.321s]
> [INFO] Lens API .. SUCCESS [1:54.490s]
> [INFO] Lens API for server and extensions  SUCCESS [1:44.559s]
> [INFO] Lens Cube . SUCCESS 
> [26:20.812s]
> [INFO] Lens DB storage ... SUCCESS [2:37.722s]
> [INFO] Lens Query Library  SUCCESS [49.289s]
> [INFO] Lens Hive Driver .. SUCCESS [9:33.923s]
> [INFO] Lens Driver for JDBC .. SUCCESS [4:48.278s]
> [INFO] Lens Elastic Search Driver  SUCCESS [1:00.712s]
> [INFO] Lens Server ... SUCCESS 
> [43:09.453s]
> [INFO] Lens client ... SUCCESS [3:28.307s]
> [INFO] Lens CLI .. SUCCESS 
> [12:21.291s]
> [INFO] Lens Examples . SUCCESS [29.909s]
> [INFO] Lens Distribution . SUCCESS [1:04.494s]
> [INFO] Lens ML Lib ... FAILURE [9:25.823s]
> [INFO] Lens ML Ext Distribution .. SKIPPED
> [INFO] Lens Regression ... SKIPPED
> [INFO] Lens UI ... SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 2:01:17.504s
> [INFO] Finished at: Wed Sep 30 11:56:50 UTC 2015
> [INFO] Final Memory: 136M/347M
> [INFO] 
> 
> 
> 
> The failure is unrelated and seems intermittent. When run separately, the 
> test case passed. Running again though.
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 38889: LENS-795: Look ahead is failing with partition not found if any process time partitions are absent

Re: Review Request 38889: LENS-795: Look ahead is failing with partition not found if any process time partitions are absent

Re: Review Request 38889: LENS-795: Look ahead is failing with partition not found if any process time partitions are absent

Re: Review Request 38889: LENS-795: Look ahead is failing with partition not found if any process time partitions are absent

Re: Review Request 38889: LENS-795: Look ahead is failing with partition not found if any process time partitions are absent

5 matches

Site Navigation

Mail list logo

Footer information