Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-22 Thread Rajat Khandelwal


> On Dec. 22, 2015, 2:29 p.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java, 
> > line 289
> > 
> >
> > seems doc need change. By default async is false - unspecified default 
> > value is true.
> 
> Rajat Khandelwal wrote:
> if unspecified value is true then the default is true. unspecified value 
> is the value assumed when value is not provided for this argument.
> 
> Amareshwari Sriramadasu wrote:
> Rajat, What i meant here is the following :
> 
> If we do :
> 
> 
> *  "query execute  " # excutes synchronously.  As the 
> default value for async is false
> 
> *  "query execute  --async" # executes asynchronously. As 
> the unspecified default value for async is true
> 
> *  "query execute  --async true" # executes asynchronously. 
> value is specified explicitly.
> 
> *  "query execute  --async false" # executes synchronously. 
> value is specified explicitly.
> 
> 
> Please validate the above and update doc accordingly.

You are correct, but Line 287 is not `query execute` command, it's `query 
results` command. For that, async is by default true, and async false means 
wait for completion and then show results.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/#review111586
---


On Dec. 23, 2015, 10:34 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41033/
> ---
> 
> (Updated Dec. 23, 2015, 10:34 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-836
> https://issues.apache.org/jira/browse/LENS-836
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> e3c08ff1e17feeb6b7d3a5e4253350e7d166 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 6ebfff7f47a8c98350dbc9466f86312334898b15 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 8f197e4ec5f9c0cc050643cf7333aeba5eec6e08 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
> 71caa48e7926e6d0f9b486ece71b292ba598be3c 
>   src/site/apt/user/cli.apt 3db53c44900176dc7f062267a200ec5c8ced5f6a 
> 
> Diff: https://reviews.apache.org/r/41033/diff/
> 
> 
> Testing
> ---
> 
> http://showterm.io/2bbd961fd3bcc859adbc8
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-22 Thread Amareshwari Sriramadasu


> On Dec. 22, 2015, 8:59 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java, 
> > line 289
> > 
> >
> > seems doc need change. By default async is false - unspecified default 
> > value is true.
> 
> Rajat Khandelwal wrote:
> if unspecified value is true then the default is true. unspecified value 
> is the value assumed when value is not provided for this argument.

Rajat, What i meant here is the following :

If we do :


*  "query execute  " # excutes synchronously.  As the default 
value for async is false

*  "query execute  --async" # executes asynchronously. As the 
unspecified default value for async is true

*  "query execute  --async true" # executes asynchronously. value 
is specified explicitly.

*  "query execute  --async false" # executes synchronously. value 
is specified explicitly.


Please validate the above and update doc accordingly.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/#review111586
---


On Dec. 23, 2015, 5:04 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41033/
> ---
> 
> (Updated Dec. 23, 2015, 5:04 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-836
> https://issues.apache.org/jira/browse/LENS-836
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> e3c08ff1e17feeb6b7d3a5e4253350e7d166 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 6ebfff7f47a8c98350dbc9466f86312334898b15 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 8f197e4ec5f9c0cc050643cf7333aeba5eec6e08 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
> 71caa48e7926e6d0f9b486ece71b292ba598be3c 
>   src/site/apt/user/cli.apt 3db53c44900176dc7f062267a200ec5c8ced5f6a 
> 
> Diff: https://reviews.apache.org/r/41033/diff/
> 
> 
> Testing
> ---
> 
> http://showterm.io/2bbd961fd3bcc859adbc8
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-22 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/
---

(Updated Dec. 23, 2015, 10:34 a.m.)


Review request for lens.


Bugs: LENS-836
https://issues.apache.org/jira/browse/LENS-836


Repository: lens


Description
---


Diffs (updated)
-

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
e3c08ff1e17feeb6b7d3a5e4253350e7d166 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
6ebfff7f47a8c98350dbc9466f86312334898b15 
  lens-client/src/main/java/org/apache/lens/client/LensClient.java 
8f197e4ec5f9c0cc050643cf7333aeba5eec6e08 
  lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
71caa48e7926e6d0f9b486ece71b292ba598be3c 
  src/site/apt/user/cli.apt 3db53c44900176dc7f062267a200ec5c8ced5f6a 

Diff: https://reviews.apache.org/r/41033/diff/


Testing
---

http://showterm.io/2bbd961fd3bcc859adbc8


Thanks,

Rajat Khandelwal



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-22 Thread Rajat Khandelwal


> On Dec. 22, 2015, 2:29 p.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java, 
> > line 289
> > 
> >
> > seems doc need change. By default async is false - unspecified default 
> > value is true.

if unspecified value is true then the default is true. unspecified value is the 
value assumed when value is not provided for this argument.


> On Dec. 22, 2015, 2:29 p.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java, 
> > line 160
> > 
> >
> > Need to update the cli docs.

done.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/#review111586
---


On Dec. 21, 2015, 4:54 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41033/
> ---
> 
> (Updated Dec. 21, 2015, 4:54 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-836
> https://issues.apache.org/jira/browse/LENS-836
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> e3c08ff1e17feeb6b7d3a5e4253350e7d166 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 6ebfff7f47a8c98350dbc9466f86312334898b15 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 8f197e4ec5f9c0cc050643cf7333aeba5eec6e08 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
> 71caa48e7926e6d0f9b486ece71b292ba598be3c 
> 
> Diff: https://reviews.apache.org/r/41033/diff/
> 
> 
> Testing
> ---
> 
> http://showterm.io/2bbd961fd3bcc859adbc8
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-22 Thread Amareshwari Sriramadasu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/#review111586
---

Ship it!



lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
(line 159)


Need to update the cli docs.



lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
(line 287)


seems doc need change. By default async is false - unspecified default 
value is true.


- Amareshwari Sriramadasu


On Dec. 21, 2015, 11:24 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41033/
> ---
> 
> (Updated Dec. 21, 2015, 11:24 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-836
> https://issues.apache.org/jira/browse/LENS-836
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> e3c08ff1e17feeb6b7d3a5e4253350e7d166 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 6ebfff7f47a8c98350dbc9466f86312334898b15 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 8f197e4ec5f9c0cc050643cf7333aeba5eec6e08 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
> 71caa48e7926e6d0f9b486ece71b292ba598be3c 
> 
> Diff: https://reviews.apache.org/r/41033/diff/
> 
> 
> Testing
> ---
> 
> http://showterm.io/2bbd961fd3bcc859adbc8
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-21 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/
---

(Updated Dec. 21, 2015, 4:54 p.m.)


Review request for lens.


Bugs: LENS-836
https://issues.apache.org/jira/browse/LENS-836


Repository: lens


Description
---


Diffs (updated)
-

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
e3c08ff1e17feeb6b7d3a5e4253350e7d166 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
6ebfff7f47a8c98350dbc9466f86312334898b15 
  lens-client/src/main/java/org/apache/lens/client/LensClient.java 
8f197e4ec5f9c0cc050643cf7333aeba5eec6e08 
  lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
71caa48e7926e6d0f9b486ece71b292ba598be3c 

Diff: https://reviews.apache.org/r/41033/diff/


Testing
---

http://showterm.io/2bbd961fd3bcc859adbc8


Thanks,

Rajat Khandelwal



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-21 Thread Rajat Khandelwal


> On Dec. 11, 2015, 9:52 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java, 
> > line 144
> > 
> >
> > Can you add a unit test?

Added


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/#review109913
---


On Dec. 9, 2015, 3:35 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41033/
> ---
> 
> (Updated Dec. 9, 2015, 3:35 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-836
> https://issues.apache.org/jira/browse/LENS-836
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 5fd04c4591264ac2e5082f1a60281b15fac9 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
> 40e6d76d20dbb1359d4d6dc64ff7c41f324c7662 
> 
> Diff: https://reviews.apache.org/r/41033/diff/
> 
> 
> Testing
> ---
> 
> http://showterm.io/2bbd961fd3bcc859adbc8
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-10 Thread Amareshwari Sriramadasu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/#review109913
---



lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
(line 143)


Can you add a unit test?


- Amareshwari Sriramadasu


On Dec. 9, 2015, 10:05 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41033/
> ---
> 
> (Updated Dec. 9, 2015, 10:05 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-836
> https://issues.apache.org/jira/browse/LENS-836
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 5fd04c4591264ac2e5082f1a60281b15fac9 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
> 40e6d76d20dbb1359d4d6dc64ff7c41f324c7662 
> 
> Diff: https://reviews.apache.org/r/41033/diff/
> 
> 
> Testing
> ---
> 
> http://showterm.io/2bbd961fd3bcc859adbc8
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-09 Thread Rajat Khandelwal


> On Dec. 8, 2015, 9:08 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java,
> >  line 54
> > 
> >
> > Not sure why this is changed only to weekly

Seems I mixed up some code while finding the root cause of build failures 
(LENS-891 was the cause). Reverting.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/#review109333
---


On Dec. 8, 2015, 1:09 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41033/
> ---
> 
> (Updated Dec. 8, 2015, 1:09 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-836
> https://issues.apache.org/jira/browse/LENS-836
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 5fd04c4591264ac2e5082f1a60281b15fac9 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
> 40e6d76d20dbb1359d4d6dc64ff7c41f324c7662 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java
>  3f9e1258536da5955ed6a846fbe25ce074547625 
> 
> Diff: https://reviews.apache.org/r/41033/diff/
> 
> 
> Testing
> ---
> 
> http://showterm.io/2bbd961fd3bcc859adbc8
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-09 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/
---

(Updated Dec. 9, 2015, 3:35 p.m.)


Review request for lens.


Bugs: LENS-836
https://issues.apache.org/jira/browse/LENS-836


Repository: lens


Description
---


Diffs (updated)
-

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
  lens-client/src/main/java/org/apache/lens/client/LensClient.java 
5fd04c4591264ac2e5082f1a60281b15fac9 
  lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
40e6d76d20dbb1359d4d6dc64ff7c41f324c7662 

Diff: https://reviews.apache.org/r/41033/diff/


Testing
---

http://showterm.io/2bbd961fd3bcc859adbc8


Thanks,

Rajat Khandelwal



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-08 Thread Amareshwari Sriramadasu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/#review109333
---



lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java
 (line 53)


Not sure why this is changed only to weekly


- Amareshwari Sriramadasu


On Dec. 8, 2015, 7:39 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41033/
> ---
> 
> (Updated Dec. 8, 2015, 7:39 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-836
> https://issues.apache.org/jira/browse/LENS-836
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 5fd04c4591264ac2e5082f1a60281b15fac9 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
> 40e6d76d20dbb1359d4d6dc64ff7c41f324c7662 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java
>  3f9e1258536da5955ed6a846fbe25ce074547625 
> 
> Diff: https://reviews.apache.org/r/41033/diff/
> 
> 
> Testing
> ---
> 
> http://showterm.io/2bbd961fd3bcc859adbc8
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-07 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/
---

(Updated Dec. 8, 2015, 1:09 p.m.)


Review request for lens.


Bugs: LENS-836
https://issues.apache.org/jira/browse/LENS-836


Repository: lens


Description
---


Diffs (updated)
-

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
  lens-client/src/main/java/org/apache/lens/client/LensClient.java 
5fd04c4591264ac2e5082f1a60281b15fac9 
  lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
40e6d76d20dbb1359d4d6dc64ff7c41f324c7662 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java
 3f9e1258536da5955ed6a846fbe25ce074547625 

Diff: https://reviews.apache.org/r/41033/diff/


Testing (updated)
---

http://showterm.io/2bbd961fd3bcc859adbc8


Thanks,

Rajat Khandelwal



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-07 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/
---

(Updated Dec. 8, 2015, 12:58 p.m.)


Review request for lens.


Bugs: LENS-836
https://issues.apache.org/jira/browse/LENS-836


Repository: lens


Description
---


Diffs (updated)
-

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
  lens-client/src/main/java/org/apache/lens/client/LensClient.java 
5fd04c4591264ac2e5082f1a60281b15fac9 
  lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
40e6d76d20dbb1359d4d6dc64ff7c41f324c7662 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java
 3f9e1258536da5955ed6a846fbe25ce074547625 

Diff: https://reviews.apache.org/r/41033/diff/


Testing (updated)
---

lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java


Thanks,

Rajat Khandelwal



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-07 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/
---

(Updated Dec. 8, 2015, 12:39 p.m.)


Review request for lens.


Bugs: LENS-836
https://issues.apache.org/jira/browse/LENS-836


Repository: lens


Description
---


Diffs (updated)
-

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
  lens-client/src/main/java/org/apache/lens/client/LensClient.java 
5fd04c4591264ac2e5082f1a60281b15fac9 
  lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
40e6d76d20dbb1359d4d6dc64ff7c41f324c7662 

Diff: https://reviews.apache.org/r/41033/diff/


Testing
---

http://showterm.io/ec9c4280efd6a72e03143


Thanks,

Rajat Khandelwal



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-07 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/
---

(Updated Dec. 8, 2015, 12:20 p.m.)


Review request for lens.


Bugs: LENS-836
https://issues.apache.org/jira/browse/LENS-836


Repository: lens


Description
---


Diffs (updated)
-

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
  lens-client/src/main/java/org/apache/lens/client/LensClient.java 
5fd04c4591264ac2e5082f1a60281b15fac9 
  lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
40e6d76d20dbb1359d4d6dc64ff7c41f324c7662 

Diff: https://reviews.apache.org/r/41033/diff/


Testing (updated)
---

http://showterm.io/ec9c4280efd6a72e03143


Thanks,

Rajat Khandelwal



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-07 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/
---

(Updated Dec. 8, 2015, 12:10 p.m.)


Review request for lens.


Bugs: LENS-836
https://issues.apache.org/jira/browse/LENS-836


Repository: lens


Description
---


Diffs (updated)
-

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
  lens-client/src/main/java/org/apache/lens/client/LensClient.java 
5fd04c4591264ac2e5082f1a60281b15fac9 
  lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
40e6d76d20dbb1359d4d6dc64ff7c41f324c7662 

Diff: https://reviews.apache.org/r/41033/diff/


Testing
---


Thanks,

Rajat Khandelwal



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-07 Thread Rajat Khandelwal


> On Dec. 8, 2015, 7:22 a.m., Puneet Gupta wrote:
> > lens-client/src/main/java/org/apache/lens/client/LensClient.java, line 61
> > 
> >
> > Some methods are not updating this variable. 
> > 
> > Example, if we execute  query1 followed by query2 and then call get 
> > status on query1, what will lastLesnStatement point to ? 
> > 
> > Should get status / get details /etc also update the last statement ?

The statement variable is once set and never updated. `statement.query` is the 
one that's updated on each `statement.getQuery` call. I checked the methods and 
all the methods of `LensQueryCommand` which are changed to pick default value 
are leading to `statement.getQuery`, hence updating the `statement.query` 
variable for next use. So any of the methods can set the `last executed query` 
for next use. 

Another place where `statement.query` is being updated is in `execute` call, 
which again, suits us well. 

So the description I've put: `"If not provided, takes last query handle 
interacted with."`, is precise.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/#review109248
---


On Dec. 7, 2015, 4:43 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41033/
> ---
> 
> (Updated Dec. 7, 2015, 4:43 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-836
> https://issues.apache.org/jira/browse/LENS-836
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 5fd04c4591264ac2e5082f1a60281b15fac9 
> 
> Diff: https://reviews.apache.org/r/41033/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>



Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

2015-12-07 Thread Puneet Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/#review109248
---



lens-client/src/main/java/org/apache/lens/client/LensClient.java (line 61)


Some methods are not updating this variable. 

Example, if we execute  query1 followed by query2 and then call get status 
on query1, what will lastLesnStatement point to ? 

Should get status / get details /etc also update the last statement ?


- Puneet Gupta


On Dec. 7, 2015, 11:13 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41033/
> ---
> 
> (Updated Dec. 7, 2015, 11:13 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-836
> https://issues.apache.org/jira/browse/LENS-836
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 5fd04c4591264ac2e5082f1a60281b15fac9 
> 
> Diff: https://reviews.apache.org/r/41033/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>