Re: Review Request 49096: State Store for the Lens scheduler.

2016-06-24 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49096/#review139362
---


Ship it!




Ship It!

- Rajat Khandelwal


On June 23, 2016, 7:29 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49096/
> ---
> 
> (Updated June 23, 2016, 7:29 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-988
> https://issues.apache.org/jira/browse/LENS-988
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Stores the Job definitions and job instance definitions.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  0a81f7b 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 5492132 
>   src/site/apt/admin/config.apt 7ad1843 
> 
> Diff: https://reviews.apache.org/r/49096/diff/
> 
> 
> Testing
> ---
> 
> To be updated.
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 49096: State Store for the Lens scheduler.

2016-06-23 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49096/
---

(Updated June 23, 2016, 1:59 p.m.)


Review request for lens.


Bugs: LENS-988
https://issues.apache.org/jira/browse/LENS-988


Repository: lens


Description
---

Stores the Job definitions and job instance definitions.


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
0a81f7b 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 PRE-CREATION 
  lens-server/src/main/resources/lensserver-default.xml 5492132 
  src/site/apt/admin/config.apt 7ad1843 

Diff: https://reviews.apache.org/r/49096/diff/


Testing
---

To be updated.


Thanks,

Lavkesh Lahngir

Re: Review Request 49096: State Store for the Lens scheduler.

2016-06-23 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49096/
---

(Updated June 23, 2016, 1:43 p.m.)


Review request for lens.


Bugs: LENS-988
https://issues.apache.org/jira/browse/LENS-988


Repository: lens


Description
---

Stores the Job definitions and job instance definitions.


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
0a81f7b 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 PRE-CREATION 
  lens-server/src/main/resources/lensserver-default.xml 5492132 

Diff: https://reviews.apache.org/r/49096/diff/


Testing
---

To be updated.


Thanks,

Lavkesh Lahngir

Re: Review Request 49096: State Store for the Lens scheduler.

2016-06-23 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49096/
---

(Updated June 23, 2016, 12:24 p.m.)


Review request for lens.


Changes
---

Separated the patch for cleanup and implementation


Bugs: LENS-988
https://issues.apache.org/jira/browse/LENS-988


Repository: lens


Description
---

Stores the Job definitions and job instance definitions.


Diffs (updated)
-

  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/49096/diff/


Testing
---

To be updated.


Thanks,

Lavkesh Lahngir

Re: Review Request 49096: State Store for the Lens scheduler.

2016-06-23 Thread Amareshwari Sriramadasu 


> On June 23, 2016, 8:12 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobHandle.java,
> >  line 45
> > 
> >
> > Why is this moved to `lens-server-api`? All client facing classes are 
> > commonly present in `lens-api` module.

Did not notice that. These classes should be in lens-api itself, as they are 
client facing.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49096/#review139223
---


On June 22, 2016, 4:04 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49096/
> ---
> 
> (Updated June 22, 2016, 4:04 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-988
> https://issues.apache.org/jira/browse/LENS-988
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Stores the Job definitions and job instance definitions.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> 4a2baba 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
> 92260b5 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  f19d3f0 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java
>  9146cf0 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  0a81f7b 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  2bcf0d6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobHandle.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  f575bc8 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
>  838b9b8 
> 
> Diff: https://reviews.apache.org/r/49096/diff/
> 
> 
> Testing
> ---
> 
> To be updated.
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 49096: State Store for the Lens scheduler.

2016-06-23 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49096/#review139223
---




lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
(line 1127)


I agree with Amareshwari. Let's use the lens server db directly.



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobHandle.java
 (line 45)


Why is this moved to `lens-server-api`? All client facing classes are 
commonly present in `lens-api` module.



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
(line 51)


Non-zero return in case of error?



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
(line 347)


Let's follow half open ranges. `[startTime, endTime)`



lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 (line 20)


`ToXMLString.toString(XJob)` should be sufficient. No need to write a new 
method.



lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 (line 34)


`ToXMLString.valueOf(String)` should work.


- Rajat Khandelwal


On June 22, 2016, 9:34 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49096/
> ---
> 
> (Updated June 22, 2016, 9:34 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-988
> https://issues.apache.org/jira/browse/LENS-988
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Stores the Job definitions and job instance definitions.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> 4a2baba 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
> 92260b5 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  f19d3f0 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java
>  9146cf0 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  0a81f7b 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  2bcf0d6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobHandle.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  f575bc8 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
>  838b9b8 
> 
> Diff: https://reviews.apache.org/r/49096/diff/
> 
> 
> Testing
> ---
> 
> To be updated.
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 49096: State Store for the Lens scheduler.

2016-06-23 Thread Lavkesh Lahngir 


> On June 23, 2016, 5:35 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java,
> >  line 1127
> > 
> >
> > Should we have separate driver and end point for scheduler? I'm 
> > thinking, We should use the server db directly and talk to so many end 
> > points.
> 
> Amareshwari Sriramadasu wrote:
> I meant why talk to so many end points.

Okay. I mean it's just the configuration, to just make it clear that we are 
using sheduler or server. We will use the same DB I guess. Does this makes 
sense?


> On June 23, 2016, 5:35 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java,
> >  line 30
> > 
> >
> > We should create this through configuration and default should be HSQL

Yes. I will fix it.


> On June 23, 2016, 5:35 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobHandle.java,
> >  line 71
> > 
> >
> > handleId should never be null. Do you want to give a @NonNull 
> > annotation instead of this check ?

Sure.


- Lavkesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49096/#review139213
---


On June 22, 2016, 4:04 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49096/
> ---
> 
> (Updated June 22, 2016, 4:04 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-988
> https://issues.apache.org/jira/browse/LENS-988
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Stores the Job definitions and job instance definitions.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> 4a2baba 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
> 92260b5 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  f19d3f0 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java
>  9146cf0 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  0a81f7b 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  2bcf0d6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobHandle.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  f575bc8 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
>  838b9b8 
> 
> Diff: https://reviews.apache.org/r/49096/diff/
> 
> 
> Testing
> ---
> 
> To be updated.
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 49096: State Store for the Lens scheduler.

2016-06-23 Thread Amareshwari Sriramadasu 


> On June 23, 2016, 5:35 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java,
> >  line 1127
> > 
> >
> > Should we have separate driver and end point for scheduler? I'm 
> > thinking, We should use the server db directly and talk to so many end 
> > points.

I meant why talk to so many end points.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49096/#review139213
---


On June 22, 2016, 4:04 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49096/
> ---
> 
> (Updated June 22, 2016, 4:04 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-988
> https://issues.apache.org/jira/browse/LENS-988
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Stores the Job definitions and job instance definitions.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> 4a2baba 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
> 92260b5 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  f19d3f0 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java
>  9146cf0 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  0a81f7b 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  2bcf0d6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobHandle.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  f575bc8 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
>  838b9b8 
> 
> Diff: https://reviews.apache.org/r/49096/diff/
> 
> 
> Testing
> ---
> 
> To be updated.
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 49096: State Store for the Lens scheduler.

2016-06-22 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49096/#review139213
---




lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
(line 1127)


Should we have separate driver and end point for scheduler? I'm thinking, 
We should use the server db directly and talk to so many end points.



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobHandle.java
 (line 71)


handleId should never be null. Do you want to give a @NonNull annotation 
instead of this check ?



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceHandle.java
 (line 75)


Same as above, should never be null.



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
(line 30)


We should create this through configuration and default should be HSQL


- Amareshwari Sriramadasu


On June 22, 2016, 4:04 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49096/
> ---
> 
> (Updated June 22, 2016, 4:04 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-988
> https://issues.apache.org/jira/browse/LENS-988
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Stores the Job definitions and job instance definitions.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
> 4a2baba 
>   lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
> 92260b5 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
>  f19d3f0 
>   
> lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java
>  9146cf0 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  0a81f7b 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  2bcf0d6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobHandle.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceHandle.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  f575bc8 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
>  838b9b8 
> 
> Diff: https://reviews.apache.org/r/49096/diff/
> 
> 
> Testing
> ---
> 
> To be updated.
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Review Request 49096: State Store for the Lens scheduler.

2016-06-22 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49096/
---

Review request for lens.


Bugs: LENS-988
https://issues.apache.org/jira/browse/LENS-988


Repository: lens


Description
---

Stores the Job definitions and job instance definitions.


Diffs
-

  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
4a2baba 
  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
92260b5 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
 f19d3f0 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java 
9146cf0 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
0a81f7b 
  
lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
 2bcf0d6 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobHandle.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceHandle.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
 f575bc8 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
 838b9b8 

Diff: https://reviews.apache.org/r/49096/diff/


Testing
---

To be updated.


Thanks,

Lavkesh Lahngir