Re: GitHub emails on dev

2018-10-08 Thread Jean-Baptiste Onofré 
+1

and the lists can be created using the selfserve.

Regards
JB

On 09/10/2018 03:02, Luciano Resende wrote:
> You guys should create a list and have these forwarded to the new list.
> Some projects use notifications@
> 
> On Mon, Oct 8, 2018 at 17:46 Alex Bozarth  wrote:
> 
>> I opened https://issues.apache.org/jira/browse/INFRA-17121 for INFRA to
>> take a look into it.
>>
>>
>> *Alex Bozarth*
>> Software Engineer
>> Center for Open-Source Data & AI Technologies
>> --
>> *E-mail:* *ajboz...@us.ibm.com* 
>> *GitHub: **github.com/ajbozarth* 
>>
>>
>> 505 Howard Street
>> 
>> San Francisco, CA 94105
>> 
>> United States
>> 
>>
>>
>>
>> [image: Inactive hide details for Marcelo Vanzin ---10/08/2018 04:23:04
>> PM---Maybe infra did something to re-enable it. We asked them t]Marcelo
>> Vanzin ---10/08/2018 04:23:04 PM---Maybe infra did something to re-enable
>> it. We asked them to disable it way back (INFRA-14973). Maybe
>>
>> From: Marcelo Vanzin 
>> To: dev@livy.incubator.apache.org
>> Date: 10/08/2018 04:23 PM
>> Subject: Re: GitHub emails on dev
>> --
>>
>>
>>
>>
>> Maybe infra did something to re-enable it. We asked them to disable it
>> way back (INFRA-14973). Maybe reopen that ticket or file a new one.
>> On Mon, Oct 8, 2018 at 4:19 PM Alex Bozarth  wrote:
>>>
>>>
>>>
>>> Is there a reason we've begun getting GitHub PR emails on the dev list?
>> The
>>> regular glut of emails for every comment on every PR probably shouldn't
>> be
>>> CC'd to dev@
>>>
>>>
>>>  Alex Bozarth
>>>  Software Engineer
>>>  Center for Open-Source Data & AI Technologies
>>>
>>>
>>>
>>>
>>>  E-mail: ajboz...@us.ibm.com
>>>  GitHub: github.com/ajbozarth
>>>505
>> Howard Street
>> 
>>>  San
>> Francisco, CA 94105
>> 
>>>
>>> United
>> States
>> 
>>>
>>>
>>>
>>>
>>>
>>
>>
>> --
>> Marcelo
>>
>>
>>
>>
>> --
> Sent from my Mobile device
> 

-- 
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: GitHub emails on dev

2018-10-08 Thread Luciano Resende 
I will create the list in the morning and then we can ask infra to switch
the configured mailing list.

On Mon, Oct 8, 2018 at 18:05 Alex Bozarth  wrote:

> That's a good idea, how would we go about doing that? Ask infra or can a
> mentor do it? And what kind of approval would we need?
>
>
> *Alex Bozarth*
> Software Engineer
> Center for Open-Source Data & AI Technologies
> --
> *E-mail:* *ajboz...@us.ibm.com* 
> *GitHub: **github.com/ajbozarth* 
>
>
> 505 Howard Street
> 
> San Francisco, CA 94105
> 
> United States
> 
>
>
>
> [image: Inactive hide details for Luciano Resende ---10/08/2018 06:02:30
> PM---You guys should create a list and have these forwarded to]Luciano
> Resende ---10/08/2018 06:02:30 PM---You guys should create a list and have
> these forwarded to the new list. Some projects use notificati
>
> From: Luciano Resende 
> To: dev@livy.incubator.apache.org
> Date: 10/08/2018 06:02 PM
> Subject: Re: GitHub emails on dev
> --
>
>
>
> You guys should create a list and have these forwarded to the new list.
> Some projects use notifications@
>
> On Mon, Oct 8, 2018 at 17:46 Alex Bozarth  wrote:
>
> > I opened https://issues.apache.org/jira/browse/INFRA-17121 for INFRA to
> > take a look into it.
> >
> >
> > *Alex Bozarth*
> > Software Engineer
> > Center for Open-Source Data & AI Technologies
> > --
> > *E-mail:* *ajboz...@us.ibm.com* 
> > *GitHub: **github.com/ajbozarth* 
> >
> >
> > 505 Howard Street
> 
> > <
> https://maps.google.com/?q=505+Howard+Street+San+Francisco,+CA+94105+United+States=gmail=g
> >
> > San Francisco, CA 94105
> > <
> https://maps.google.com/?q=505+Howard+Street+San+Francisco,+CA+94105+United+States=gmail=g
> >
> > United States
> > <
> https://maps.google.com/?q=505+Howard+Street+San+Francisco,+CA+94105+United+States=gmail=g
> >
> >
> >
> >
> > [image: Inactive hide details for Marcelo Vanzin ---10/08/2018 04:23:04
> > PM---Maybe infra did something to re-enable it. We asked them t]Marcelo
> > Vanzin ---10/08/2018 04:23:04 PM---Maybe infra did something to re-enable
> > it. We asked them to disable it way back (INFRA-14973). Maybe
> >
> > From: Marcelo Vanzin 
> > To: dev@livy.incubator.apache.org
> > Date: 10/08/2018 04:23 PM
> > Subject: Re: GitHub emails on dev
> > --
> >
> >
> >
> >
> > Maybe infra did something to re-enable it. We asked them to disable it
> > way back (INFRA-14973). Maybe reopen that ticket or file a new one.
> > On Mon, Oct 8, 2018 at 4:19 PM Alex Bozarth  wrote:
> > >
> > >
> > >
> > > Is there a reason we've begun getting GitHub PR emails on the dev list?
> > The
> > > regular glut of emails for every comment on every PR probably shouldn't
> > be
> > > CC'd to dev@
> > >
> > >
> > >  Alex Bozarth
> > >  Software Engineer
> > >  Center for Open-Source Data & AI Technologies
> > >
> > >
> > >
> > >
> > >  E-mail: ajboz...@us.ibm.com
> > >  GitHub: github.com/ajbozarth
> > >505
> > Howard Street
> 
> > <
> https://maps.google.com/?q=505+Howard+Street+San+Francisco,+CA+94105+United+States=gmail=g
> >
> > >  San
> > Francisco, CA 94105
> > <
> https://maps.google.com/?q=505+Howard+Street+San+Francisco,+CA+94105+United+States=gmail=g
> >
> > >
>  United
> > States
> > <
> https://maps.google.com/?q=505+Howard+Street+San+Francisco,+CA+94105+United+States=gmail=g
> >
>
>
> > >
> > >
> > >
> > >
> > >
> >
> >
> > --
> > Marcelo
> >
> >
> >
> >
> > --
> Sent from my Mobile device
>
>
>
> --
Sent from my Mobile device

[GitHub] incubator-livy issue #119: added autocompletion api and implementation for i...

2018-10-08 Thread wangqiaoshi 
Github user wangqiaoshi commented on the issue:

https://github.com/apache/incubator-livy/pull/119
  
### Fix the bug : The completion function doesn't work in pyspark kind.
description:
when pyspark run in  ipython environment , kind pyspark completion work.
this pr add  complete function in PySparkJobProcessor interface,  so 
ReplDriver can get completion message from python

### How was this patch tested?

1. post /sessions/{sessionId}/completion
set kind=pyspark


---

Re: GitHub emails on dev

2018-10-08 Thread Alex Bozarth 

That's a good idea, how would we go about doing that? Ask infra or can a
mentor do it? And what kind of approval would we need?


   
 Alex Bozarth   
   
 Software Engineer  
   
 Center for Open-Source Data & AI Technologies  
   

   

 

 

 
 E-mail: ajboz...@us.ibm.com
 
 GitHub: github.com/ajbozarth   
 
   505 Howard 
Street 
 San Francisco, CA 
94105 
   United 
States 

 








From:   Luciano Resende 
To: dev@livy.incubator.apache.org
Date:   10/08/2018 06:02 PM
Subject:Re: GitHub emails on dev



You guys should create a list and have these forwarded to the new list.
Some projects use notifications@

On Mon, Oct 8, 2018 at 17:46 Alex Bozarth  wrote:

> I opened
https://issues.apache.org/jira/browse/INFRA-17121
 for INFRA to
> take a look into it.
>
>
> *Alex Bozarth*
> Software Engineer
> Center for Open-Source Data & AI Technologies
> --
> *E-mail:* *ajboz...@us.ibm.com* 
> *GitHub: **github.com/ajbozarth* <
https://github.com/ajbozarth
>
>
>
> 505 Howard Street
> <
https://maps.google.com/?q=505+Howard+Street+San+Francisco,+CA+94105+United+States=gmail=g
>
> San Francisco, CA 94105
> <
https://maps.google.com/?q=505+Howard+Street+San+Francisco,+CA+94105+United+States=gmail=g
>
> United States
> <
https://maps.google.com/?q=505+Howard+Street+San+Francisco,+CA+94105+United+States=gmail=g
>
>
>
>
> [image: Inactive hide details for Marcelo Vanzin ---10/08/2018 04:23:04
> PM---Maybe infra did something to re-enable it. We asked them t]Marcelo
> Vanzin ---10/08/2018 04:23:04 PM---Maybe infra did something to re-enable
> it. We asked them to disable it way back (INFRA-14973). Maybe
>
> From: Marcelo Vanzin 
> To: dev@livy.incubator.apache.org
> Date: 10/08/2018 04:23 PM
> Subject: Re: GitHub emails on dev
> --
>
>
>
>
> Maybe infra did something to re-enable it. We asked them to disable it
> way back (INFRA-14973). Maybe reopen that ticket or file a new one.
> On Mon, Oct 8, 2018 at 4:19 PM Alex Bozarth  wrote:
> >
> >
> >
> > Is there a reason we've begun getting GitHub PR emails on the dev list?
> The
> > regular glut of emails for every comment on every PR probably shouldn't
> be
> > CC'd to dev@
> >
> >
> >  Alex Bozarth
> >  Software Engineer
> >  Center for Open-Source Data & AI Technologies
> >
> >
> >
> >
> >  E-mail: ajboz...@us.ibm.com
> >  GitHub: github.com/ajbozarth
> >505
> Howard Street
> <
https://maps.google.com/?q=505+Howard+Street+San+Francisco,+CA+94105+United+States=gmail=g
>
> >  San
> Francisco, CA 94105
> <
https://maps.google.com/?q=505+Howard+Street+San+Francisco,+CA+94105+United+States=gmail=g
>
> >
United
> States
> <
https://maps.google.com/?q=505+Howard+Street+San+Francisco,+CA+94105+United+States=gmail=g
>
> >
> >
> >
> >
> >
>
>
> --
> Marcelo
>
>
>
>
> --
Sent from my Mobile device

Re: GitHub emails on dev

2018-10-08 Thread Luciano Resende 
You guys should create a list and have these forwarded to the new list.
Some projects use notifications@

On Mon, Oct 8, 2018 at 17:46 Alex Bozarth  wrote:

> I opened https://issues.apache.org/jira/browse/INFRA-17121 for INFRA to
> take a look into it.
>
>
> *Alex Bozarth*
> Software Engineer
> Center for Open-Source Data & AI Technologies
> --
> *E-mail:* *ajboz...@us.ibm.com* 
> *GitHub: **github.com/ajbozarth* 
>
>
> 505 Howard Street
> 
> San Francisco, CA 94105
> 
> United States
> 
>
>
>
> [image: Inactive hide details for Marcelo Vanzin ---10/08/2018 04:23:04
> PM---Maybe infra did something to re-enable it. We asked them t]Marcelo
> Vanzin ---10/08/2018 04:23:04 PM---Maybe infra did something to re-enable
> it. We asked them to disable it way back (INFRA-14973). Maybe
>
> From: Marcelo Vanzin 
> To: dev@livy.incubator.apache.org
> Date: 10/08/2018 04:23 PM
> Subject: Re: GitHub emails on dev
> --
>
>
>
>
> Maybe infra did something to re-enable it. We asked them to disable it
> way back (INFRA-14973). Maybe reopen that ticket or file a new one.
> On Mon, Oct 8, 2018 at 4:19 PM Alex Bozarth  wrote:
> >
> >
> >
> > Is there a reason we've begun getting GitHub PR emails on the dev list?
> The
> > regular glut of emails for every comment on every PR probably shouldn't
> be
> > CC'd to dev@
> >
> >
> >  Alex Bozarth
> >  Software Engineer
> >  Center for Open-Source Data & AI Technologies
> >
> >
> >
> >
> >  E-mail: ajboz...@us.ibm.com
> >  GitHub: github.com/ajbozarth
> >505
> Howard Street
> 
> >  San
> Francisco, CA 94105
> 
> >
> > United
> States
> 
> >
> >
> >
> >
> >
>
>
> --
> Marcelo
>
>
>
>
> --
Sent from my Mobile device

Re: GitHub emails on dev

2018-10-08 Thread Alex Bozarth 

I opened https://issues.apache.org/jira/browse/INFRA-17121 for INFRA to
take a look into it.


   
 Alex Bozarth   
   
 Software Engineer  
   
 Center for Open-Source Data & AI Technologies  
   

   

 

 

 
 E-mail: ajboz...@us.ibm.com
 
 GitHub: github.com/ajbozarth   
 
   505 Howard 
Street 
 San Francisco, CA 
94105 
   United 
States 

 








From:   Marcelo Vanzin 
To: dev@livy.incubator.apache.org
Date:   10/08/2018 04:23 PM
Subject:Re: GitHub emails on dev



Maybe infra did something to re-enable it. We asked them to disable it
way back (INFRA-14973). Maybe reopen that ticket or file a new one.
On Mon, Oct 8, 2018 at 4:19 PM Alex Bozarth  wrote:
>
>
>
> Is there a reason we've begun getting GitHub PR emails on the dev list?
The
> regular glut of emails for every comment on every PR probably shouldn't
be
> CC'd to dev@
>
>
>  Alex Bozarth
>  Software Engineer
>  Center for Open-Source Data & AI Technologies
>
>
>
>
>  E-mail: ajboz...@us.ibm.com
>  GitHub: github.com/ajbozarth
>505
Howard Street
>  San
Francisco, CA 94105
>
United States
>
>
>
>
>


--
Marcelo

[GitHub] incubator-livy pull request #114: [LIVY-495] Add thriftserver UI

2018-10-08 Thread vanzin 
Github user vanzin commented on a diff in the pull request:

https://github.com/apache/incubator-livy/pull/114#discussion_r223523654
  
--- Diff: 
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/ui/ThriftUIServlet.scala
 ---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.thriftserver.ui
+
+import java.text.SimpleDateFormat
+
+import scala.collection.JavaConverters._
+import scala.xml.Node
+
+import org.json4s.{DefaultFormats, Formats}
+import org.scalatra.json._
+
+import org.apache.livy.server.ui.BaseServlet
+import org.apache.livy.thriftserver.LivyThriftServer
+
+class ThriftUIServlet(val basePath: String) extends BaseServlet with 
JacksonJsonSupport {
+
+  protected implicit val jsonFormats: Formats = DefaultFormats
+
+  private val df = new SimpleDateFormat("-MM-dd HH:mm:ss")
+
+  private case class ThriftSessionsPage(name: String = "JDBC Sessions") 
extends Page {
+override def getNavTabs: Seq[Node] = {
--- End diff --

Another option would be to expose Thrift session-related information in the 
existing sessions page. But not sure how easy that would be.


---

Re: GitHub emails on dev

2018-10-08 Thread Marcelo Vanzin 
Maybe infra did something to re-enable it. We asked them to disable it
way back (INFRA-14973). Maybe reopen that ticket or file a new one.
On Mon, Oct 8, 2018 at 4:19 PM Alex Bozarth  wrote:
>
>
>
> Is there a reason we've begun getting GitHub PR emails on the dev list? The
> regular glut of emails for every comment on every PR probably shouldn't be
> CC'd to dev@
>
>
>  Alex Bozarth
>  Software Engineer
>  Center for Open-Source Data & AI Technologies
>
>
>
>
>  E-mail: ajboz...@us.ibm.com
>  GitHub: github.com/ajbozarth
>505 Howard 
> Street
>  San Francisco, 
> CA 94105
>United 
> States
>
>
>
>
>


-- 
Marcelo

[GitHub] incubator-livy pull request #114: [LIVY-495] Add thriftserver UI

2018-10-08 Thread ajbozarth 
Github user ajbozarth commented on a diff in the pull request:

https://github.com/apache/incubator-livy/pull/114#discussion_r223523441
  
--- Diff: 
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/ui/ThriftUIServlet.scala
 ---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.thriftserver.ui
+
+import java.text.SimpleDateFormat
+
+import scala.collection.JavaConverters._
+import scala.xml.Node
+
+import org.json4s.{DefaultFormats, Formats}
+import org.scalatra.json._
+
+import org.apache.livy.server.ui.BaseServlet
+import org.apache.livy.thriftserver.LivyThriftServer
+
+class ThriftUIServlet(val basePath: String) extends BaseServlet with 
JacksonJsonSupport {
+
+  protected implicit val jsonFormats: Formats = DefaultFormats
+
+  private val df = new SimpleDateFormat("-MM-dd HH:mm:ss")
+
+  private case class ThriftSessionsPage(name: String = "JDBC Sessions") 
extends Page {
+override def getNavTabs: Seq[Node] = {
--- End diff --

yeah when originally designing the UI I went back and forth a lot trying to 
get the L right and ended up using a tabbed looked even through they were 
breadcrumbs. Actually on that thought I have an idea. I'll type it up as a full 
comment below


---

[GitHub] incubator-livy pull request #114: [LIVY-495] Add thriftserver UI

2018-10-08 Thread vanzin 
Github user vanzin commented on a diff in the pull request:

https://github.com/apache/incubator-livy/pull/114#discussion_r223522910
  
--- Diff: 
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/ui/ThriftUIServlet.scala
 ---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.thriftserver.ui
+
+import java.text.SimpleDateFormat
+
+import scala.collection.JavaConverters._
+import scala.xml.Node
+
+import org.json4s.{DefaultFormats, Formats}
+import org.scalatra.json._
+
+import org.apache.livy.server.ui.BaseServlet
+import org.apache.livy.thriftserver.LivyThriftServer
+
+class ThriftUIServlet(val basePath: String) extends BaseServlet with 
JacksonJsonSupport {
+
+  protected implicit val jsonFormats: Formats = DefaultFormats
+
+  private val df = new SimpleDateFormat("-MM-dd HH:mm:ss")
+
+  private case class ThriftSessionsPage(name: String = "JDBC Sessions") 
extends Page {
+override def getNavTabs: Seq[Node] = {
--- End diff --

Yeah, mixing breadcrumb-like tabs with static navigation tabs would be 
confusing.

Perhaps have two rows of tabs but I dislike that idea even as I'm typing it.


---

[GitHub] incubator-livy pull request #114: [LIVY-495] Add thriftserver UI

2018-10-08 Thread ajbozarth 
Github user ajbozarth commented on a diff in the pull request:

https://github.com/apache/incubator-livy/pull/114#discussion_r223522428
  
--- Diff: 
thriftserver/server/src/main/scala/org/apache/livy/thriftserver/ui/ThriftUIServlet.scala
 ---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.thriftserver.ui
+
+import java.text.SimpleDateFormat
+
+import scala.collection.JavaConverters._
+import scala.xml.Node
+
+import org.json4s.{DefaultFormats, Formats}
+import org.scalatra.json._
+
+import org.apache.livy.server.ui.BaseServlet
+import org.apache.livy.thriftserver.LivyThriftServer
+
+class ThriftUIServlet(val basePath: String) extends BaseServlet with 
JacksonJsonSupport {
+
+  protected implicit val jsonFormats: Formats = DefaultFormats
+
+  private val df = new SimpleDateFormat("-MM-dd HH:mm:ss")
+
+  private case class ThriftSessionsPage(name: String = "JDBC Sessions") 
extends Page {
+override def getNavTabs: Seq[Node] = {
--- End diff --

@vanzin because of how I designed the original UI the tabs were actually 
closer to a breadcrumb than tabs. With the addition of the Thrift server UI 
this changes. So before the "tabs" were:
- Sessions Page: `Sessions`
- Session Page: `Sessions | Session #`
- Session Log Page: `Sessions | Session # | Log`
but now the thrift server "tab" is always visible when it's running, based 
on this misunderstanding maybe we should update how the nav bar functions based 
on this new addition


---

[GitHub] incubator-livy issue #119: added autocompletion api and implementation for i...

2018-10-08 Thread vanzin 
Github user vanzin commented on the issue:

https://github.com/apache/incubator-livy/pull/119
  
Please follow the guidelines in the contribution guide (linked in the PR 
template). Mainly:
- file a bug with a description of the problem / feature
- provide a proper description of your PR (which will be the commit message 
when merged).


---

[GitHub] incubator-livy issue #119: added autocompletion api and implementation for i...

2018-10-08 Thread wangqiaoshi 
Github user wangqiaoshi commented on the issue:

https://github.com/apache/incubator-livy/pull/119
  
should set 
spark.pyspark.python ${ipython-path}


---