Re: Review request for LOG4J2-2972

[Volkan Yazıcı]

After incorporating changes requested by Carter and Gary, I have merged
this branch.

I want to take this opportunity to thank Carter for his great patience,
kind help, and terrific assistance!

On Thu, Jan 7, 2021 at 12:12 PM Volkan Yazıcı 
wrote:

> Hello,
>
> Carter and I have spent some time on overhauling the AsyncAppender
> background thread. The last state of the changes are available in the
> GitHub PR . In a
> nutshell, the incorporated changes are as follows:
>
>
>- AppenderControl catch clauses is demoted from Throwable to Exception.
>(Aligned with the pre-2.14.0 behaviour.)
>- AsyncAppender.AsyncThread is moved to AsyncAppenderEventForwarder with
>plenty of refactoring for simplification.
>- On shutdown, AsyncAppenderEventForwarder forwards all the remaining
>LogEvents, whereas AsyncAppender.AsyncThread was ignoring non-
>Log4LogEvents.
>- AsyncAppenderExceptionHandlingTest is improved for ThreadDeath.
>
>
> I would appreciate it if somebody can review the work. I want to get this
> in, fix any broken tests (if necessary), and make a new release.
>
> Kind regards.
>
>

Putting a ribbon around 2.14.1?

[Volkan Yazıcı]

Hello,

Shall we release 2.14.1? I really want to get the next release out of the
door in particular for the following changes:

LOG4J2-2972 Refactor AsyncAppender and AppenderControl for handling of
Throwables.
LOG4J2-2985 Add eventTemplateRootObjectKey parameter to JsonTemplateLayout.
LOG4J2-2962 Enrich "map" resolver by unifying its backend with "mdc"
resolver.
LOG4J2-2961 Fix reading of JsonTemplateLayout event additional fields from
config.
LOG4J2-2916 Avoid redundant Kafka producer instantiation causing thread
leaks.
LOG4J2-2967 Fix JsonTemplateLayout index based parameter resolution when
messages contain too few parameters.
LOG4J2-2976 JdbcAppender composes an incorrect INSERT statement without a
ColumnMapping element.

@Ralph, given you are the (unofficial?) release manager, what do you think?
Can we have an ETA for the release?

Kind regards.

Re: Putting a ribbon around 2.14.1?

[Gary Gregory]

Since we are adding adding a feature, we should be at 2.15.0 IMO.

Gary

On Sat, Jan 9, 2021, 11:23 Volkan Yazıcı  wrote:

> Hello,
>
> Shall we release 2.14.1? I really want to get the next release out of the
> door in particular for the following changes:
>
> LOG4J2-2972 Refactor AsyncAppender and AppenderControl for handling of
> Throwables.
> LOG4J2-2985 Add eventTemplateRootObjectKey parameter to JsonTemplateLayout.
> LOG4J2-2962 Enrich "map" resolver by unifying its backend with "mdc"
> resolver.
> LOG4J2-2961 Fix reading of JsonTemplateLayout event additional fields from
> config.
> LOG4J2-2916 Avoid redundant Kafka producer instantiation causing thread
> leaks.
> LOG4J2-2967 Fix JsonTemplateLayout index based parameter resolution when
> messages contain too few parameters.
> LOG4J2-2976 JdbcAppender composes an incorrect INSERT statement without a
> ColumnMapping element.
>
> @Ralph, given you are the (unofficial?) release manager, what do you think?
> Can we have an ETA for the release?
>
> Kind regards.
>

Re: Putting a ribbon around 2.14.1?

[Ralph Goers]

What feature? I haven’t looked at the changes.xml but all the below sound like 
fixes or very minor enhancements.

Volkan, as always I will want to go through my list of Jira issues and see if 
there is any low hanging fruit or serious issues I need to fix.

Ralph

> On Jan 9, 2021, at 12:07 PM, Gary Gregory  wrote:
> 
> Since we are adding adding a feature, we should be at 2.15.0 IMO.
> 
> Gary
> 
> On Sat, Jan 9, 2021, 11:23 Volkan Yazıcı  wrote:
> 
>> Hello,
>> 
>> Shall we release 2.14.1? I really want to get the next release out of the
>> door in particular for the following changes:
>> 
>> LOG4J2-2972 Refactor AsyncAppender and AppenderControl for handling of
>> Throwables.
>> LOG4J2-2985 Add eventTemplateRootObjectKey parameter to JsonTemplateLayout.
>> LOG4J2-2962 Enrich "map" resolver by unifying its backend with "mdc"
>> resolver.
>> LOG4J2-2961 Fix reading of JsonTemplateLayout event additional fields from
>> config.
>> LOG4J2-2916 Avoid redundant Kafka producer instantiation causing thread
>> leaks.
>> LOG4J2-2967 Fix JsonTemplateLayout index based parameter resolution when
>> messages contain too few parameters.
>> LOG4J2-2976 JdbcAppender composes an incorrect INSERT statement without a
>> ColumnMapping element.
>> 
>> @Ralph, given you are the (unofficial?) release manager, what do you think?
>> Can we have an ETA for the release?
>> 
>> Kind regards.
>> 

Re: Review request for LOG4J2-2972

[Carter Kozak]

You’re too kind, you did all the work! This is what open source development is 
all about!

Carter

> On Jan 9, 2021, at 10:01 AM, Volkan Yazıcı  wrote:
> 
> After incorporating changes requested by Carter and Gary, I have merged
> this branch.
> 
> I want to take this opportunity to thank Carter for his great patience,
> kind help, and terrific assistance!
> 
>> On Thu, Jan 7, 2021 at 12:12 PM Volkan Yazıcı 
>> wrote:
>> 
>> Hello,
>> 
>> Carter and I have spent some time on overhauling the AsyncAppender
>> background thread. The last state of the changes are available in the
>> GitHub PR . In a
>> nutshell, the incorporated changes are as follows:
>> 
>> 
>>   - AppenderControl catch clauses is demoted from Throwable to Exception.
>>   (Aligned with the pre-2.14.0 behaviour.)
>>   - AsyncAppender.AsyncThread is moved to AsyncAppenderEventForwarder with
>>   plenty of refactoring for simplification.
>>   - On shutdown, AsyncAppenderEventForwarder forwards all the remaining
>>   LogEvents, whereas AsyncAppender.AsyncThread was ignoring non-
>>   Log4LogEvents.
>>   - AsyncAppenderExceptionHandlingTest is improved for ThreadDeath.
>> 
>> 
>> I would appreciate it if somebody can review the work. I want to get this
>> in, fix any broken tests (if necessary), and make a new release.
>> 
>> Kind regards.
>> 
>>