Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

[Volkan Yazıcı]

I have gotten in touch with the author of the
maven-shaded-log4j-transformer plugin, Eduard Gizatullin. He has kindly
accepted to contribute this plugin in the form of a PR to the project. I
gave him a briefing about the ICLA, Jira ticket, GitHub PR, etc. process
and told him to first send an email to this list laying out the details of
the plan. Let's see how it will pan out.

On Wed, Oct 13, 2021 at 7:11 PM Matt Sicker  wrote:

> The 3.x code loads plugins from generated Java classes that correspond
> to ServiceLoader-loadable classes. Since each jar tends to end up with
> their generated plugin class going into different package names, the
> result of shading them together works naturally with combining the
> META-INF/services/ files. For the .dat file, that's a custom format
> that's essentially a light serialized form of the plugin metadata
> which has to be programmatically combined together. The ServiceLoader
> approach was eventually adopted as it works much better with the Java
> module system, though it also helps solve the shading problem, too,
> without additional tooling.
>
> In the meantime, we could publish a Maven plugin or something to
> combine 2.x plugin .dat files into a single one.
>
> On Wed, Oct 13, 2021 at 9:34 AM Volkan Yazıcı  wrote:
> >
> > It works on `master`. Matt, mind shedding some light on why it works on
> > `master`, but doesn't on `release-2.x`? Maybe we can backport the trick
> on
> > `master` to `release-2.x`?
> >
> > On Wed, Oct 13, 2021 at 4:05 PM Apache 
> wrote:
> >
> > > We could include it in Log4J. Does master work out of the box?
> > >
> > > Ralph
> > >
> > > > On Oct 13, 2021, at 12:23 AM, Volkan Yazıcı  wrote:
> > > >
> > > > 
> > > > I have done something really nasty in the release-2.x branch to fix
> > > benchmarks.jar generated by log4j-perf. Since a picture is worth a
> thousand
> > > words, I am sharing two:
> > > >
> > > >
> > > >
> > > > (In case images get truncated, see commit 4049240c.)
> > > >
> > > > In a nutshell, Log4j2Plugins.dat of the shaded benchmarks.jar doesn't
> > > contain log4j-layout-template-json plugins due to overrides taking
> place
> > > during shading. This problem rendered the JsonTemplateLayout benchmarks
> > > broken after JTLs migration to plugins. Using a 3rd party Maven plugin
> > > circumventing a Log4j bug in the Log4j project itself felt pretty
> > > unpleasant to me. Is there any other way I could have solved this?
> > >
> > >
> > >
>

Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

[Volkan Yazıcı]

I long had the ambition to move the entire site & manual to gh-pages.
In an ideal world, I would even move the release process to GitHub Actions
too.
But these are, for now, pretty ambitious goals.
What I would really appreciate is to access gh-pages content via, say,
https://beta.logging.apache.org/log4j URL.
Matt, mind helping me with setting this up please?

On Wed, Oct 13, 2021 at 7:12 PM Matt Sicker  wrote:

> That's really cool! Do note that we can publish to the ASF-specific
> branches, too, for hosting a site.
>
> On Wed, Oct 13, 2021 at 10:37 AM Volkan Yazıcı  wrote:
> >
> > Do this:
> >
> > git fetch -p
> > git checkout -B gh-pages origin/gh-pages
> > python -m http.server
> > open http://localhost:8000/benchmark/results/index.html
> >
> > *The magic:*
> >
> https://github.com/apache/logging-log4j2/blob/release-2.x/.github/workflows/benchmark.yml
> >
> > *Disadvantages:* Runner specs are on the flux, though mostly pretty
> stable.
> >
> > *Future work:*
> >
> >- Enable GitHub pages for the project?
> >- Incorporate more from log4j-perf to here.
> >- Put the workflow onto a cron schedule.
>

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

[Carter Kozak]

This sounds great. Thanks, Volkan!

-ck

> On Oct 15, 2021, at 6:42 AM, Volkan Yazıcı  wrote:
> 
> I have gotten in touch with the author of the
> maven-shaded-log4j-transformer plugin, Eduard Gizatullin. He has kindly
> accepted to contribute this plugin in the form of a PR to the project. I
> gave him a briefing about the ICLA, Jira ticket, GitHub PR, etc. process
> and told him to first send an email to this list laying out the details of
> the plan. Let's see how it will pan out.
> 
>> On Wed, Oct 13, 2021 at 7:11 PM Matt Sicker  wrote:
>> 
>> The 3.x code loads plugins from generated Java classes that correspond
>> to ServiceLoader-loadable classes. Since each jar tends to end up with
>> their generated plugin class going into different package names, the
>> result of shading them together works naturally with combining the
>> META-INF/services/ files. For the .dat file, that's a custom format
>> that's essentially a light serialized form of the plugin metadata
>> which has to be programmatically combined together. The ServiceLoader
>> approach was eventually adopted as it works much better with the Java
>> module system, though it also helps solve the shading problem, too,
>> without additional tooling.
>> 
>> In the meantime, we could publish a Maven plugin or something to
>> combine 2.x plugin .dat files into a single one.
>> 
>>> On Wed, Oct 13, 2021 at 9:34 AM Volkan Yazıcı  wrote:
>>> 
>>> It works on `master`. Matt, mind shedding some light on why it works on
>>> `master`, but doesn't on `release-2.x`? Maybe we can backport the trick
>> on
>>> `master` to `release-2.x`?
>>> 
>>> On Wed, Oct 13, 2021 at 4:05 PM Apache 
>> wrote:
>>> 
 We could include it in Log4J. Does master work out of the box?
 
 Ralph
 
> On Oct 13, 2021, at 12:23 AM, Volkan Yazıcı  wrote:
> 
> 
> I have done something really nasty in the release-2.x branch to fix
 benchmarks.jar generated by log4j-perf. Since a picture is worth a
>> thousand
 words, I am sharing two:
> 
> 
> 
> (In case images get truncated, see commit 4049240c.)
> 
> In a nutshell, Log4j2Plugins.dat of the shaded benchmarks.jar doesn't
 contain log4j-layout-template-json plugins due to overrides taking
>> place
 during shading. This problem rendered the JsonTemplateLayout benchmarks
 broken after JTLs migration to plugins. Using a 3rd party Maven plugin
 circumventing a Log4j bug in the Log4j project itself felt pretty
 unpleasant to me. Is there any other way I could have solved this?
 
 
 
>> 

Re: Cek's new log4j vs logback benchmark

[Carter Kozak]

I’ve been on vacation with limited network access since Saturday, but I’ll be 
back on Sunday. My PR is ready to merge into release-2.x, I haven’t done so yet 
because I began the cherry-pick to master but was unable to complete the 
relatively painful conflict resolution before my flight out. Hoping to get that 
settled early next week.

Re: Cek's new log4j vs logback benchmark

[Volkan Yazıcı]

Welcome back and great work Carter! I am inclined to merge the
`release-2.x` changes to clear out the way for the 2.15.0 release. (I guess
Ralph's changes will be the only blocker after that.) Porting those to
`master` can be tackled in parallel.

On Fri, Oct 15, 2021 at 1:03 PM Carter Kozak  wrote:

> I’ve been on vacation with limited network access since Saturday, but I’ll
> be back on Sunday. My PR is ready to merge into release-2.x, I haven’t done
> so yet because I began the cherry-pick to master but was unable to complete
> the relatively painful conflict resolution before my flight out. Hoping to
> get that settled early next week.
>

Continuous Log4j-vs-Logback benchmarks

[Volkan Yazıcı]

I am looking for certain JMH benchmarks to assess the Log4j-vs-Logback
performance. I plan to integrate these into the `benchmark` CI workflow I
have recently added. `log4j-perf` is an endless well, difficult to pinpoint
the crucial ones.

Carter, given you have the most up-to-date knowledge on the issue, mind
helping me out with these? I see some in
https://github.com/ceki/logback-perf/tree/master/src/main/java/ch/qos/logback/perf,
yet I don't know which ones are relevant. I need pointers in the form of *"use
benchmark method X in file Y"*.

Re: Cek's new log4j vs logback benchmark

[Carter Kozak]

Thanks :-) That works for me.

-ck

> On Oct 15, 2021, at 7:07 AM, Volkan Yazıcı  wrote:
> 
> Welcome back and great work Carter! I am inclined to merge the
> `release-2.x` changes to clear out the way for the 2.15.0 release. (I guess
> Ralph's changes will be the only blocker after that.) Porting those to
> `master` can be tackled in parallel.
> 
>> On Fri, Oct 15, 2021 at 1:03 PM Carter Kozak  wrote:
>> 
>> I’ve been on vacation with limited network access since Saturday, but I’ll
>> be back on Sunday. My PR is ready to merge into release-2.x, I haven’t done
>> so yet because I began the cherry-pick to master but was unable to complete
>> the relatively painful conflict resolution before my flight out. Hoping to
>> get that settled early next week.
>> 

Re: Continuous Log4j-vs-Logback benchmarks

[Carter Kozak]

I won’t be back to a dev machine until Sunday, but I’d be happy to put together 
a list at that point!

-ck

> On Oct 15, 2021, at 7:16 AM, Volkan Yazıcı  wrote:
> 
> I am looking for certain JMH benchmarks to assess the Log4j-vs-Logback
> performance. I plan to integrate these into the `benchmark` CI workflow I
> have recently added. `log4j-perf` is an endless well, difficult to pinpoint
> the crucial ones.
> 
> Carter, given you have the most up-to-date knowledge on the issue, mind
> helping me out with these? I see some in
> https://github.com/ceki/logback-perf/tree/master/src/main/java/ch/qos/logback/perf,
> yet I don't know which ones are relevant. I need pointers in the form of *"use
> benchmark method X in file Y"*.

Re: maven-shaded-log4j-transformer

[Eduard Gizatullin]

Hello dear log4j team

Volkan Yazıcı asked me to make  maven-shaded-log4j-transformer
 a part of
log4j2  and I tend to accomplish the proposal.

Can you please confirm that
new sub-module name  log4j-maven-shade-plugin is ok

Any preliminary advice will be appreciated


--
Best regards,
Ed


On Fri, Oct 15, 2021 at 1:39 PM Volkan Yazıcı  wrote:

> Thanks for the prompt (and positive!) reply Eduard!
> I think it is best to first lay out the details of the plan in a post to the
> dev mailing list .
> For instance, the module name, transformer name, documentation changes,
> etc.
> This will give others an opportunity to share their feedback and remarks.
> Then simply create a JIRA 
> ticket and submit a GitHub  PR.
>
> `master` branch targets Log4j 3, which is not released yet.
> It uses a different plugin loading mechanism than the one used in Log4j 2.
> Log4j 3 doesn't suffer from this "override of plugins after shading"
> problem.
> Hence, the PR needs to target the `release-2.x` branch.
>
> Also note that since this is a non-trivial contribution, you need to sign the
> ICLA document  and email it to
> the ASF .
> Once you have done this, it is good to mention this in the dev mailing
> list.
>
> On Fri, Oct 15, 2021 at 12:26 PM Eduard Gizatullin 
> wrote:
>
>> Hello Volkan,
>>
>> Thank you for letting me know, I'm all for it.
>>
>> Couldn't you please confirm that target branch is master
>> and log4j-maven-plugins is ok as new name of submodule
>>
>> Any other advices will be appreciated,
>>
>> --
>> Best regards,
>> Ed
>>
>>
>> On Fri, Oct 15, 2021 at 10:10 AM Volkan Yazıcı  wrote:
>>
>>> Hello,
>>>
>>> My name is Volkan Yazici and I am a PMC committee member of the ASF
>>> Logging Services, which develops Log4j too.
>>> maven-shaded-log4j-transformer
>>>  plugin
>>> addresses an important shortcoming of the Log4j 2.x plugin design surfacing
>>> when users want to shade it. We have recently had a chat about it in
>>> the mailing list
>>> ,
>>> and the maintainers (incl. me) are inclined to ship it as a part of the
>>> Log4j project. Would you like to contribute it yourself in the form of a
>>> GitHub PR? Note that this route is subject to update-push-review cycles,
>>> yet they are pretty rewarding for both parties, IMHO. What do you think?
>>>
>>> Kind regards.
>>>
>>

Re: maven-shaded-log4j-transformer

[Apache]

Question: Do we want it as a sub-module or as a new git repo with its own 
release?

Ralph

> On Oct 15, 2021, at 6:50 AM, Eduard Gizatullin  wrote:
> 
> Hello dear log4j team
> 
> Volkan Yazıcı asked me to make  maven-shaded-log4j-transformer
>  a part of
> log4j2  and I tend to accomplish the proposal.
> 
> Can you please confirm that
> new sub-module name  log4j-maven-shade-plugin is ok
> 
> Any preliminary advice will be appreciated
> 
> 
> --
> Best regards,
> Ed
> 
> 
>> On Fri, Oct 15, 2021 at 1:39 PM Volkan Yazıcı  wrote:
>> 
>> Thanks for the prompt (and positive!) reply Eduard!
>> I think it is best to first lay out the details of the plan in a post to the
>> dev mailing list .
>> For instance, the module name, transformer name, documentation changes,
>> etc.
>> This will give others an opportunity to share their feedback and remarks.
>> Then simply create a JIRA 
>> ticket and submit a GitHub  PR.
>> 
>> `master` branch targets Log4j 3, which is not released yet.
>> It uses a different plugin loading mechanism than the one used in Log4j 2.
>> Log4j 3 doesn't suffer from this "override of plugins after shading"
>> problem.
>> Hence, the PR needs to target the `release-2.x` branch.
>> 
>> Also note that since this is a non-trivial contribution, you need to sign the
>> ICLA document  and email it to
>> the ASF .
>> Once you have done this, it is good to mention this in the dev mailing
>> list.
>> 
>> On Fri, Oct 15, 2021 at 12:26 PM Eduard Gizatullin 
>> wrote:
>> 
>>> Hello Volkan,
>>> 
>>> Thank you for letting me know, I'm all for it.
>>> 
>>> Couldn't you please confirm that target branch is master
>>> and log4j-maven-plugins is ok as new name of submodule
>>> 
>>> Any other advices will be appreciated,
>>> 
>>> --
>>> Best regards,
>>> Ed
>>> 
>>> 
 On Fri, Oct 15, 2021 at 10:10 AM Volkan Yazıcı  wrote:
>>> 
 Hello,
 
 My name is Volkan Yazici and I am a PMC committee member of the ASF
 Logging Services, which develops Log4j too.
 maven-shaded-log4j-transformer
  plugin
 addresses an important shortcoming of the Log4j 2.x plugin design surfacing
 when users want to shade it. We have recently had a chat about it in
 the mailing list
 ,
 and the maintainers (incl. me) are inclined to ship it as a part of the
 Log4j project. Would you like to contribute it yourself in the form of a
 GitHub PR? Note that this route is subject to update-push-review cycles,
 yet they are pretty rewarding for both parties, IMHO. What do you think?
 
 Kind regards.
 
>>> 

Re: broken Log4j2Plugins.dat in the shaded benchmarks.jar of log4j-perf

[Gary Gregory]

I've had to use this plugin in the past. I'm glad to hear of this
agreement!: -)

Gary

On Fri, Oct 15, 2021, 06:42 Volkan Yazıcı  wrote:

> I have gotten in touch with the author of the
> maven-shaded-log4j-transformer plugin, Eduard Gizatullin. He has kindly
> accepted to contribute this plugin in the form of a PR to the project. I
> gave him a briefing about the ICLA, Jira ticket, GitHub PR, etc. process
> and told him to first send an email to this list laying out the details of
> the plan. Let's see how it will pan out.
>
> On Wed, Oct 13, 2021 at 7:11 PM Matt Sicker  wrote:
>
> > The 3.x code loads plugins from generated Java classes that correspond
> > to ServiceLoader-loadable classes. Since each jar tends to end up with
> > their generated plugin class going into different package names, the
> > result of shading them together works naturally with combining the
> > META-INF/services/ files. For the .dat file, that's a custom format
> > that's essentially a light serialized form of the plugin metadata
> > which has to be programmatically combined together. The ServiceLoader
> > approach was eventually adopted as it works much better with the Java
> > module system, though it also helps solve the shading problem, too,
> > without additional tooling.
> >
> > In the meantime, we could publish a Maven plugin or something to
> > combine 2.x plugin .dat files into a single one.
> >
> > On Wed, Oct 13, 2021 at 9:34 AM Volkan Yazıcı  wrote:
> > >
> > > It works on `master`. Matt, mind shedding some light on why it works on
> > > `master`, but doesn't on `release-2.x`? Maybe we can backport the trick
> > on
> > > `master` to `release-2.x`?
> > >
> > > On Wed, Oct 13, 2021 at 4:05 PM Apache 
> > wrote:
> > >
> > > > We could include it in Log4J. Does master work out of the box?
> > > >
> > > > Ralph
> > > >
> > > > > On Oct 13, 2021, at 12:23 AM, Volkan Yazıcı 
> wrote:
> > > > >
> > > > > 
> > > > > I have done something really nasty in the release-2.x branch to fix
> > > > benchmarks.jar generated by log4j-perf. Since a picture is worth a
> > thousand
> > > > words, I am sharing two:
> > > > >
> > > > >
> > > > >
> > > > > (In case images get truncated, see commit 4049240c.)
> > > > >
> > > > > In a nutshell, Log4j2Plugins.dat of the shaded benchmarks.jar
> doesn't
> > > > contain log4j-layout-template-json plugins due to overrides taking
> > place
> > > > during shading. This problem rendered the JsonTemplateLayout
> benchmarks
> > > > broken after JTLs migration to plugins. Using a 3rd party Maven
> plugin
> > > > circumventing a Log4j bug in the Log4j project itself felt pretty
> > > > unpleasant to me. Is there any other way I could have solved this?
> > > >
> > > >
> > > >
> >
>

Re: maven-shaded-log4j-transformer

[Volkan Yazıcı]

I also support the idea of moving it to a separate project.
`logging-log4j2` is already bloated a lot and it hurts compilation & test
times, severely.
I think we have already agreed on breaking up the project into individual
projects.
My proposal:

   - *GitHub project name:* logging-log4j2-maven-plugins
   - *Group ID:* org.apache.logging.maven
   - *Artifact ID:* maven-log4j-transformer-plugin (in a submodule, and
   note the `maven-*-plugin` convention for unofficial Maven plugins)
   - *Transformer class name:* Log4jPluginCacheFileCombiner



On Fri, Oct 15, 2021 at 4:04 PM Apache  wrote:

> Question: Do we want it as a sub-module or as a new git repo with its own
> release?
>
> Ralph
>
> > On Oct 15, 2021, at 6:50 AM, Eduard Gizatullin  wrote:
> >
> > Hello dear log4j team
> >
> > Volkan Yazıcı asked me to make  maven-shaded-log4j-transformer
> >  a part of
> > log4j2  and I tend to accomplish the proposal.
> >
> > Can you please confirm that
> > new sub-module name  log4j-maven-shade-plugin is ok
> >
> > Any preliminary advice will be appreciated
> >
> >
> > --
> > Best regards,
> > Ed
> >
> >
> >> On Fri, Oct 15, 2021 at 1:39 PM Volkan Yazıcı  wrote:
> >>
> >> Thanks for the prompt (and positive!) reply Eduard!
> >> I think it is best to first lay out the details of the plan in a post
> to the
> >> dev mailing list  >.
> >> For instance, the module name, transformer name, documentation changes,
> >> etc.
> >> This will give others an opportunity to share their feedback and
> remarks.
> >> Then simply create a JIRA <
> https://issues.apache.org/jira/projects/LOG4J2>
> >> ticket and submit a GitHub 
> PR.
> >>
> >> `master` branch targets Log4j 3, which is not released yet.
> >> It uses a different plugin loading mechanism than the one used in Log4j
> 2.
> >> Log4j 3 doesn't suffer from this "override of plugins after shading"
> >> problem.
> >> Hence, the PR needs to target the `release-2.x` branch.
> >>
> >> Also note that since this is a non-trivial contribution, you need to
> sign the
> >> ICLA document  and email it
> to
> >> the ASF .
> >> Once you have done this, it is good to mention this in the dev mailing
> >> list.
> >>
> >> On Fri, Oct 15, 2021 at 12:26 PM Eduard Gizatullin 
> >> wrote:
> >>
> >>> Hello Volkan,
> >>>
> >>> Thank you for letting me know, I'm all for it.
> >>>
> >>> Couldn't you please confirm that target branch is master
> >>> and log4j-maven-plugins is ok as new name of submodule
> >>>
> >>> Any other advices will be appreciated,
> >>>
> >>> --
> >>> Best regards,
> >>> Ed
> >>>
> >>>
>  On Fri, Oct 15, 2021 at 10:10 AM Volkan Yazıcı 
> wrote:
> >>>
>  Hello,
> 
>  My name is Volkan Yazici and I am a PMC committee member of the ASF
>  Logging Services, which develops Log4j too.
>  maven-shaded-log4j-transformer
>   plugin
>  addresses an important shortcoming of the Log4j 2.x plugin design
> surfacing
>  when users want to shade it. We have recently had a chat about it in
>  the mailing list
>  <
> https://lists.apache.org/thread.html/rcfa4fc8678642a51e3a69dd2b14848fe4e1e5b71de7c99a7b55ff182%40%3Cdev.logging.apache.org%3E
> >,
>  and the maintainers (incl. me) are inclined to ship it as a part of
> the
>  Log4j project. Would you like to contribute it yourself in the form
> of a
>  GitHub PR? Note that this route is subject to update-push-review
> cycles,
>  yet they are pretty rewarding for both parties, IMHO. What do you
> think?
> 
>  Kind regards.
> 
> >>>
>
>
>

Re: maven-shaded-log4j-transformer

[Gary Gregory]

Hi Ed,

Your files must have the Apache License header comment, otherwise running
'mvn apache-rat:check' will fail.

Gary


On Fri, Oct 15, 2021, 09:49 Eduard Gizatullin  wrote:

> Hello dear log4j team
>
> Volkan Yazıcı asked me to make  maven-shaded-log4j-transformer
>  a part of
> log4j2  and I tend to accomplish the proposal.
>
> Can you please confirm that
> new sub-module name  log4j-maven-shade-plugin is ok
>
> Any preliminary advice will be appreciated
>
>
> --
> Best regards,
> Ed
>
>
> On Fri, Oct 15, 2021 at 1:39 PM Volkan Yazıcı  wrote:
>
> > Thanks for the prompt (and positive!) reply Eduard!
> > I think it is best to first lay out the details of the plan in a post to
> the
> > dev mailing list .
> > For instance, the module name, transformer name, documentation changes,
> > etc.
> > This will give others an opportunity to share their feedback and remarks.
> > Then simply create a JIRA <
> https://issues.apache.org/jira/projects/LOG4J2>
> > ticket and submit a GitHub 
> PR.
> >
> > `master` branch targets Log4j 3, which is not released yet.
> > It uses a different plugin loading mechanism than the one used in Log4j
> 2.
> > Log4j 3 doesn't suffer from this "override of plugins after shading"
> > problem.
> > Hence, the PR needs to target the `release-2.x` branch.
> >
> > Also note that since this is a non-trivial contribution, you need to
> sign the
> > ICLA document  and email it to
> > the ASF .
> > Once you have done this, it is good to mention this in the dev mailing
> > list.
> >
> > On Fri, Oct 15, 2021 at 12:26 PM Eduard Gizatullin 
> > wrote:
> >
> >> Hello Volkan,
> >>
> >> Thank you for letting me know, I'm all for it.
> >>
> >> Couldn't you please confirm that target branch is master
> >> and log4j-maven-plugins is ok as new name of submodule
> >>
> >> Any other advices will be appreciated,
> >>
> >> --
> >> Best regards,
> >> Ed
> >>
> >>
> >> On Fri, Oct 15, 2021 at 10:10 AM Volkan Yazıcı  wrote:
> >>
> >>> Hello,
> >>>
> >>> My name is Volkan Yazici and I am a PMC committee member of the ASF
> >>> Logging Services, which develops Log4j too.
> >>> maven-shaded-log4j-transformer
> >>>  plugin
> >>> addresses an important shortcoming of the Log4j 2.x plugin design
> surfacing
> >>> when users want to shade it. We have recently had a chat about it in
> >>> the mailing list
> >>> <
> https://lists.apache.org/thread.html/rcfa4fc8678642a51e3a69dd2b14848fe4e1e5b71de7c99a7b55ff182%40%3Cdev.logging.apache.org%3E
> >,
> >>> and the maintainers (incl. me) are inclined to ship it as a part of the
> >>> Log4j project. Would you like to contribute it yourself in the form of
> a
> >>> GitHub PR? Note that this route is subject to update-push-review
> cycles,
> >>> yet they are pretty rewarding for both parties, IMHO. What do you
> think?
> >>>
> >>> Kind regards.
> >>>
> >>
>

Re: maven-shaded-log4j-transformer

[edwgiz]

Hello Gary,

thanks for note, it's simple to add

--
Best regards,
Ed

On Fri, Oct 15, 2021 at 5:48 PM Gary Gregory  wrote:

> Hi Ed,
>
> Your files must have the Apache License header comment, otherwise running
> 'mvn apache-rat:check' will fail.
>
> Gary
>
>
> On Fri, Oct 15, 2021, 09:49 Eduard Gizatullin  wrote:
>
> > Hello dear log4j team
> >
> > Volkan Yazıcı asked me to make  maven-shaded-log4j-transformer
> >  a part of
> > log4j2  and I tend to accomplish the proposal.
> >
> > Can you please confirm that
> > new sub-module name  log4j-maven-shade-plugin is ok
> >
> > Any preliminary advice will be appreciated
> >
> >
> > --
> > Best regards,
> > Ed
> >
> >
> > On Fri, Oct 15, 2021 at 1:39 PM Volkan Yazıcı  wrote:
> >
> > > Thanks for the prompt (and positive!) reply Eduard!
> > > I think it is best to first lay out the details of the plan in a post
> to
> > the
> > > dev mailing list  >.
> > > For instance, the module name, transformer name, documentation changes,
> > > etc.
> > > This will give others an opportunity to share their feedback and
> remarks.
> > > Then simply create a JIRA <
> > https://issues.apache.org/jira/projects/LOG4J2>
> > > ticket and submit a GitHub 
> > PR.
> > >
> > > `master` branch targets Log4j 3, which is not released yet.
> > > It uses a different plugin loading mechanism than the one used in Log4j
> > 2.
> > > Log4j 3 doesn't suffer from this "override of plugins after shading"
> > > problem.
> > > Hence, the PR needs to target the `release-2.x` branch.
> > >
> > > Also note that since this is a non-trivial contribution, you need to
> > sign the
> > > ICLA document  and email it
> to
> > > the ASF .
> > > Once you have done this, it is good to mention this in the dev mailing
> > > list.
> > >
> > > On Fri, Oct 15, 2021 at 12:26 PM Eduard Gizatullin 
> > > wrote:
> > >
> > >> Hello Volkan,
> > >>
> > >> Thank you for letting me know, I'm all for it.
> > >>
> > >> Couldn't you please confirm that target branch is master
> > >> and log4j-maven-plugins is ok as new name of submodule
> > >>
> > >> Any other advices will be appreciated,
> > >>
> > >> --
> > >> Best regards,
> > >> Ed
> > >>
> > >>
> > >> On Fri, Oct 15, 2021 at 10:10 AM Volkan Yazıcı 
> wrote:
> > >>
> > >>> Hello,
> > >>>
> > >>> My name is Volkan Yazici and I am a PMC committee member of the ASF
> > >>> Logging Services, which develops Log4j too.
> > >>> maven-shaded-log4j-transformer
> > >>>  plugin
> > >>> addresses an important shortcoming of the Log4j 2.x plugin design
> > surfacing
> > >>> when users want to shade it. We have recently had a chat about it in
> > >>> the mailing list
> > >>> <
> >
> https://lists.apache.org/thread.html/rcfa4fc8678642a51e3a69dd2b14848fe4e1e5b71de7c99a7b55ff182%40%3Cdev.logging.apache.org%3E
> > >,
> > >>> and the maintainers (incl. me) are inclined to ship it as a part of
> the
> > >>> Log4j project. Would you like to contribute it yourself in the form
> of
> > a
> > >>> GitHub PR? Note that this route is subject to update-push-review
> > cycles,
> > >>> yet they are pretty rewarding for both parties, IMHO. What do you
> > think?
> > >>>
> > >>> Kind regards.
> > >>>
> > >>
> >
>

Re: maven-shaded-log4j-transformer

[Volkan Yazıcı]

License headers, `changes.xml` integration, JPMS shizzle(?), etc. I guess
we will need to copy quite some plumbing code from Log4j 2. Nevertheless,
they are all doable.
I am also in favor of using GitHub all the way down: GitHub Issues for
issue tracking, GitHub Actions for CI/CD (yes, even CD!), GitHub pages for
publishing the Maven-generated site, etc.


On Fri, Oct 15, 2021 at 4:48 PM Gary Gregory  wrote:

> Hi Ed,
>
> Your files must have the Apache License header comment, otherwise running
> 'mvn apache-rat:check' will fail.
>
> Gary
>
>
> On Fri, Oct 15, 2021, 09:49 Eduard Gizatullin  wrote:
>
>> Hello dear log4j team
>>
>> Volkan Yazıcı asked me to make  maven-shaded-log4j-transformer
>>  a part of
>> log4j2  and I tend to accomplish the proposal.
>>
>> Can you please confirm that
>> new sub-module name  log4j-maven-shade-plugin is ok
>>
>> Any preliminary advice will be appreciated
>>
>>
>> --
>> Best regards,
>> Ed
>>
>>
>> On Fri, Oct 15, 2021 at 1:39 PM Volkan Yazıcı  wrote:
>>
>> > Thanks for the prompt (and positive!) reply Eduard!
>> > I think it is best to first lay out the details of the plan in a post
>> to the
>> > dev mailing list > >.
>> > For instance, the module name, transformer name, documentation changes,
>> > etc.
>> > This will give others an opportunity to share their feedback and
>> remarks.
>> > Then simply create a JIRA <
>> https://issues.apache.org/jira/projects/LOG4J2>
>> > ticket and submit a GitHub 
>> PR.
>> >
>> > `master` branch targets Log4j 3, which is not released yet.
>> > It uses a different plugin loading mechanism than the one used in Log4j
>> 2.
>> > Log4j 3 doesn't suffer from this "override of plugins after shading"
>> > problem.
>> > Hence, the PR needs to target the `release-2.x` branch.
>> >
>> > Also note that since this is a non-trivial contribution, you need to
>> sign the
>> > ICLA document  and email it
>> to
>> > the ASF .
>> > Once you have done this, it is good to mention this in the dev mailing
>> > list.
>> >
>> > On Fri, Oct 15, 2021 at 12:26 PM Eduard Gizatullin 
>> > wrote:
>> >
>> >> Hello Volkan,
>> >>
>> >> Thank you for letting me know, I'm all for it.
>> >>
>> >> Couldn't you please confirm that target branch is master
>> >> and log4j-maven-plugins is ok as new name of submodule
>> >>
>> >> Any other advices will be appreciated,
>> >>
>> >> --
>> >> Best regards,
>> >> Ed
>> >>
>> >>
>> >> On Fri, Oct 15, 2021 at 10:10 AM Volkan Yazıcı  wrote:
>> >>
>> >>> Hello,
>> >>>
>> >>> My name is Volkan Yazici and I am a PMC committee member of the ASF
>> >>> Logging Services, which develops Log4j too.
>> >>> maven-shaded-log4j-transformer
>> >>>  plugin
>> >>> addresses an important shortcoming of the Log4j 2.x plugin design
>> surfacing
>> >>> when users want to shade it. We have recently had a chat about it in
>> >>> the mailing list
>> >>> <
>> https://lists.apache.org/thread.html/rcfa4fc8678642a51e3a69dd2b14848fe4e1e5b71de7c99a7b55ff182%40%3Cdev.logging.apache.org%3E
>> >,
>> >>> and the maintainers (incl. me) are inclined to ship it as a part of
>> the
>> >>> Log4j project. Would you like to contribute it yourself in the form
>> of a
>> >>> GitHub PR? Note that this route is subject to update-push-review
>> cycles,
>> >>> yet they are pretty rewarding for both parties, IMHO. What do you
>> think?
>> >>>
>> >>> Kind regards.
>> >>>
>> >>
>>
>

Re: maven-shaded-log4j-transformer

[Matt Sicker]

I’m in favor of making this its own repo. Making the build, site, and release 
process as simple as possible would be great. I can help with the release 
process at least.

Matt Sicker

> On Oct 15, 2021, at 09:56, Volkan Yazıcı  wrote:
> 
> License headers, `changes.xml` integration, JPMS shizzle(?), etc. I guess
> we will need to copy quite some plumbing code from Log4j 2. Nevertheless,
> they are all doable.
> I am also in favor of using GitHub all the way down: GitHub Issues for
> issue tracking, GitHub Actions for CI/CD (yes, even CD!), GitHub pages for
> publishing the Maven-generated site, etc.
> 
> 
>> On Fri, Oct 15, 2021 at 4:48 PM Gary Gregory  wrote:
>> 
>> Hi Ed,
>> 
>> Your files must have the Apache License header comment, otherwise running
>> 'mvn apache-rat:check' will fail.
>> 
>> Gary
>> 
>> 
>>> On Fri, Oct 15, 2021, 09:49 Eduard Gizatullin  wrote:
>>> 
>>> Hello dear log4j team
>>> 
>>> Volkan Yazıcı asked me to make  maven-shaded-log4j-transformer
>>>  a part of
>>> log4j2  and I tend to accomplish the proposal.
>>> 
>>> Can you please confirm that
>>> new sub-module name  log4j-maven-shade-plugin is ok
>>> 
>>> Any preliminary advice will be appreciated
>>> 
>>> 
>>> --
>>> Best regards,
>>> Ed
>>> 
>>> 
 On Fri, Oct 15, 2021 at 1:39 PM Volkan Yazıcı  wrote:
>>> 
 Thanks for the prompt (and positive!) reply Eduard!
 I think it is best to first lay out the details of the plan in a post
>>> to the
 dev mailing list >> remarks.
 Then simply create a JIRA <
>>> https://issues.apache.org/jira/projects/LOG4J2>
 ticket and submit a GitHub 
>>> PR.
 
 `master` branch targets Log4j 3, which is not released yet.
 It uses a different plugin loading mechanism than the one used in Log4j
>>> 2.
 Log4j 3 doesn't suffer from this "override of plugins after shading"
 problem.
 Hence, the PR needs to target the `release-2.x` branch.
 
 Also note that since this is a non-trivial contribution, you need to
>>> sign the
 ICLA document  and email it
>>> to
 the ASF .
 Once you have done this, it is good to mention this in the dev mailing
 list.
 
 On Fri, Oct 15, 2021 at 12:26 PM Eduard Gizatullin 
 wrote:
 
> Hello Volkan,
> 
> Thank you for letting me know, I'm all for it.
> 
> Couldn't you please confirm that target branch is master
> and log4j-maven-plugins is ok as new name of submodule
> 
> Any other advices will be appreciated,
> 
> --
> Best regards,
> Ed
> 
> 
> On Fri, Oct 15, 2021 at 10:10 AM Volkan Yazıcı  wrote:
> 
>> Hello,
>> 
>> My name is Volkan Yazici and I am a PMC committee member of the ASF
>> Logging Services, which develops Log4j too.
>> maven-shaded-log4j-transformer
>>  plugin
>> addresses an important shortcoming of the Log4j 2.x plugin design
>>> surfacing
>> when users want to shade it. We have recently had a chat about it in
>> the mailing list
>> <
>>> https://lists.apache.org/thread.html/rcfa4fc8678642a51e3a69dd2b14848fe4e1e5b71de7c99a7b55ff182%40%3Cdev.logging.apache.org%3E
 ,
>> and the maintainers (incl. me) are inclined to ship it as a part of
>>> the
>> Log4j project. Would you like to contribute it yourself in the form
>>> of a
>> GitHub PR? Note that this route is subject to update-push-review
>>> cycles,
>> yet they are pretty rewarding for both parties, IMHO. What do you
>>> think?
>> 
>> Kind regards.
>> 
> 
>>> 
>> 

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

[Matt Sicker]

I’m not exactly sure how we can get a beta subdomain, though the staging one is 
built in. And while it would be great to automate as much as possible about the 
release process in GHA, the code signing aspect is still not possible (though 
we might be able to integrate with another service at Apache for that, but it 
doesn’t cover the GPG signature). There’s also some ASF rule I think about 
releases needing to be done by a human, but that might be more about 
reproducible builds.

Matt Sicker

> On Oct 15, 2021, at 05:57, Volkan Yazıcı  wrote:
> 
> I long had the ambition to move the entire site & manual to gh-pages.
> In an ideal world, I would even move the release process to GitHub Actions
> too.
> But these are, for now, pretty ambitious goals.
> What I would really appreciate is to access gh-pages content via, say,
> https://beta.logging.apache.org/log4j URL.
> Matt, mind helping me with setting this up please?
> 
>> On Wed, Oct 13, 2021 at 7:12 PM Matt Sicker  wrote:
>> 
>> That's really cool! Do note that we can publish to the ASF-specific
>> branches, too, for hosting a site.
>> 
>>> On Wed, Oct 13, 2021 at 10:37 AM Volkan Yazıcı  wrote:
>>> 
>>> Do this:
>>> 
>>> git fetch -p
>>> git checkout -B gh-pages origin/gh-pages
>>> python -m http.server
>>> open http://localhost:8000/benchmark/results/index.html
>>> 
>>> *The magic:*
>>> 
>> https://github.com/apache/logging-log4j2/blob/release-2.x/.github/workflows/benchmark.yml
>>> 
>>> *Disadvantages:* Runner specs are on the flux, though mostly pretty
>> stable.
>>> 
>>> *Future work:*
>>> 
>>>   - Enable GitHub pages for the project?
>>>   - Incorporate more from log4j-perf to here.
>>>   - Put the workflow onto a cron schedule.
>> 

Re: maven-shaded-log4j-transformer

[edwgiz]

Hello Volkan, Ralph

Please let me mention that the transformer is quite tiny (3 java classes)
extension for the existing Maven Shade Plugin

therefore I would suggest *Artifact ID:* shade-plugin-log4j-transformer


Regarding the class name please take into account the existing transformer
implementations
org.apache.maven.plugins.shade.resource.AppendingTransformer
org.apache.maven.plugins.shade.resource.XmlAppendingTransformer
org.apache.maven.plugins.shade.resource.properties.PropertiesTransformer

It's good to determine the full class name, for example
- *Transformer class name:*
org.apache.logging.maven.plugins.shade.Log4j2PluginCacheFileTransformer


Also I hope it's not hard to create new project with all related
infrastructure


--
Best regards,
Ed



maven-log4j-shade-plugin-transformer'

   - *GitHub project name:* logging-log4j2-maven-plugins
   - *Group ID:* org.apache.logging.maven
   - *Artifact ID:* maven-log4j-shade-plugin-transformer (in a submodule,
and
   note the `maven-*-plugin` convention for unofficial Maven plugins)
   - *Transformer class name:* Log4jPluginCacheFileCombiner

On Fri, Oct 15, 2021 at 5:27 PM Volkan Yazıcı  wrote:

> I also support the idea of moving it to a separate project.
> `logging-log4j2` is already bloated a lot and it hurts compilation & test
> times, severely.
> I think we have already agreed on breaking up the project into individual
> projects.
> My proposal:
>
>- *GitHub project name:* logging-log4j2-maven-plugins
>- *Group ID:* org.apache.logging.maven
>- *Artifact ID:* maven-log4j-transformer-plugin (in a submodule, and
>note the `maven-*-plugin` convention for unofficial Maven plugins)
>- *Transformer class name:* Log4jPluginCacheFileCombiner
>
>
>
> On Fri, Oct 15, 2021 at 4:04 PM Apache  wrote:
>
> > Question: Do we want it as a sub-module or as a new git repo with its own
> > release?
> >
> > Ralph
> >
> > > On Oct 15, 2021, at 6:50 AM, Eduard Gizatullin 
> wrote:
> > >
> > > Hello dear log4j team
> > >
> > > Volkan Yazıcı asked me to make  maven-shaded-log4j-transformer
> > >  a part of
> > > log4j2  and I tend to accomplish the proposal.
> > >
> > > Can you please confirm that
> > > new sub-module name  log4j-maven-shade-plugin is ok
> > >
> > > Any preliminary advice will be appreciated
> > >
> > >
> > > --
> > > Best regards,
> > > Ed
> > >
> > >
> > >> On Fri, Oct 15, 2021 at 1:39 PM Volkan Yazıcı  wrote:
> > >>
> > >> Thanks for the prompt (and positive!) reply Eduard!
> > >> I think it is best to first lay out the details of the plan in a post
> > to the
> > >> dev mailing list <
> https://logging.apache.org/log4j/2.x/mail-lists.html
> > >.
> > >> For instance, the module name, transformer name, documentation
> changes,
> > >> etc.
> > >> This will give others an opportunity to share their feedback and
> > remarks.
> > >> Then simply create a JIRA <
> > https://issues.apache.org/jira/projects/LOG4J2>
> > >> ticket and submit a GitHub 
> > PR.
> > >>
> > >> `master` branch targets Log4j 3, which is not released yet.
> > >> It uses a different plugin loading mechanism than the one used in
> Log4j
> > 2.
> > >> Log4j 3 doesn't suffer from this "override of plugins after shading"
> > >> problem.
> > >> Hence, the PR needs to target the `release-2.x` branch.
> > >>
> > >> Also note that since this is a non-trivial contribution, you need to
> > sign the
> > >> ICLA document  and email it
> > to
> > >> the ASF .
> > >> Once you have done this, it is good to mention this in the dev mailing
> > >> list.
> > >>
> > >> On Fri, Oct 15, 2021 at 12:26 PM Eduard Gizatullin 
> > >> wrote:
> > >>
> > >>> Hello Volkan,
> > >>>
> > >>> Thank you for letting me know, I'm all for it.
> > >>>
> > >>> Couldn't you please confirm that target branch is master
> > >>> and log4j-maven-plugins is ok as new name of submodule
> > >>>
> > >>> Any other advices will be appreciated,
> > >>>
> > >>> --
> > >>> Best regards,
> > >>> Ed
> > >>>
> > >>>
> >  On Fri, Oct 15, 2021 at 10:10 AM Volkan Yazıcı 
> > wrote:
> > >>>
> >  Hello,
> > 
> >  My name is Volkan Yazici and I am a PMC committee member of the ASF
> >  Logging Services, which develops Log4j too.
> >  maven-shaded-log4j-transformer
> >   plugin
> >  addresses an important shortcoming of the Log4j 2.x plugin design
> > surfacing
> >  when users want to shade it. We have recently had a chat about it in
> >  the mailing list
> >  <
> >
> https://lists.apache.org/thread.html/rcfa4fc8678642a51e3a69dd2b14848fe4e1e5b71de7c99a7b55ff182%40%3Cdev.logging.apache.org%3E
> > >,
> >  and the maintainers (incl. me) are inclined to ship it as a part of
> > the
> >  Log4j project. Would you like to contribute it 

Re: maven-shaded-log4j-transformer

[Ralph Goers]

The ASF has automated creating new git repos. PMC members can do it on a 
simple web form. We just have to have consensus on what we want to do.

Whatever we decide to do, you can either make the changes needed in your 
PR or it can be done after the fact. 

Although I like Volkan’s idea of using logging-log4j2-maven-plugins I have no 
idea what other plugins we might ever have.

As for the artifact id I am fine with the name you propose.

Ralph



> On Oct 15, 2021, at 8:40 AM, edwgiz  wrote:
> 
> Hello Volkan, Ralph
> 
> Please let me mention that the transformer is quite tiny (3 java classes)
> extension for the existing Maven Shade Plugin
> 
> therefore I would suggest *Artifact ID:* shade-plugin-log4j-transformer
> 
> 
> Regarding the class name please take into account the existing transformer
> implementations
> org.apache.maven.plugins.shade.resource.AppendingTransformer
> org.apache.maven.plugins.shade.resource.XmlAppendingTransformer
> org.apache.maven.plugins.shade.resource.properties.PropertiesTransformer
> 
> It's good to determine the full class name, for example
> - *Transformer class name:*
> org.apache.logging.maven.plugins.shade.Log4j2PluginCacheFileTransformer
> 
> 
> Also I hope it's not hard to create new project with all related
> infrastructure
> 
> 
> --
> Best regards,
> Ed
> 
> 
> 
> maven-log4j-shade-plugin-transformer'
> 
>   - *GitHub project name:* logging-log4j2-maven-plugins
>   - *Group ID:* org.apache.logging.maven
>   - *Artifact ID:* maven-log4j-shade-plugin-transformer (in a submodule,
> and
>   note the `maven-*-plugin` convention for unofficial Maven plugins)
>   - *Transformer class name:* Log4jPluginCacheFileCombiner
> 
> On Fri, Oct 15, 2021 at 5:27 PM Volkan Yazıcı  wrote:
> 
>> I also support the idea of moving it to a separate project.
>> `logging-log4j2` is already bloated a lot and it hurts compilation & test
>> times, severely.
>> I think we have already agreed on breaking up the project into individual
>> projects.
>> My proposal:
>> 
>>   - *GitHub project name:* logging-log4j2-maven-plugins
>>   - *Group ID:* org.apache.logging.maven
>>   - *Artifact ID:* maven-log4j-transformer-plugin (in a submodule, and
>>   note the `maven-*-plugin` convention for unofficial Maven plugins)
>>   - *Transformer class name:* Log4jPluginCacheFileCombiner
>> 
>> 
>> 
>> On Fri, Oct 15, 2021 at 4:04 PM Apache  wrote:
>> 
>>> Question: Do we want it as a sub-module or as a new git repo with its own
>>> release?
>>> 
>>> Ralph
>>> 
 On Oct 15, 2021, at 6:50 AM, Eduard Gizatullin 
>> wrote:
 
 Hello dear log4j team
 
 Volkan Yazıcı asked me to make  maven-shaded-log4j-transformer
  a part of
 log4j2  and I tend to accomplish the proposal.
 
 Can you please confirm that
 new sub-module name  log4j-maven-shade-plugin is ok
 
 Any preliminary advice will be appreciated
 
 
 --
 Best regards,
 Ed
 
 
> On Fri, Oct 15, 2021 at 1:39 PM Volkan Yazıcı  wrote:
> 
> Thanks for the prompt (and positive!) reply Eduard!
> I think it is best to first lay out the details of the plan in a post
>>> to the
> dev mailing list <
>> https://logging.apache.org/log4j/2.x/mail-lists.html
 .
> For instance, the module name, transformer name, documentation
>> changes,
> etc.
> This will give others an opportunity to share their feedback and
>>> remarks.
> Then simply create a JIRA <
>>> https://issues.apache.org/jira/projects/LOG4J2>
> ticket and submit a GitHub 
>>> PR.
> 
> `master` branch targets Log4j 3, which is not released yet.
> It uses a different plugin loading mechanism than the one used in
>> Log4j
>>> 2.
> Log4j 3 doesn't suffer from this "override of plugins after shading"
> problem.
> Hence, the PR needs to target the `release-2.x` branch.
> 
> Also note that since this is a non-trivial contribution, you need to
>>> sign the
> ICLA document  and email it
>>> to
> the ASF .
> Once you have done this, it is good to mention this in the dev mailing
> list.
> 
> On Fri, Oct 15, 2021 at 12:26 PM Eduard Gizatullin 
> wrote:
> 
>> Hello Volkan,
>> 
>> Thank you for letting me know, I'm all for it.
>> 
>> Couldn't you please confirm that target branch is master
>> and log4j-maven-plugins is ok as new name of submodule
>> 
>> Any other advices will be appreciated,
>> 
>> --
>> Best regards,
>> Ed
>> 
>> 
>>> On Fri, Oct 15, 2021 at 10:10 AM Volkan Yazıcı 
>>> wrote:
>> 
>>> Hello,
>>> 
>>> My name is Volkan Yazici and I am a PMC committee member of the ASF
>>> Logging Services, which develops Log4j too.
>>> maven-shaded-log4j-transformer

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

[Ralph Goers]

I don’t really understand this. When I was migrating the web site from the ASF 
CMS to GitHub 
it was made clear that web site hosting using GitHub Pages wasn’t supported. I 
am not sure 
what the proposal here is.

Ralph

> On Oct 15, 2021, at 8:27 AM, Matt Sicker  wrote:
> 
> I’m not exactly sure how we can get a beta subdomain, though the staging one 
> is built in. And while it would be great to automate as much as possible 
> about the release process in GHA, the code signing aspect is still not 
> possible (though we might be able to integrate with another service at Apache 
> for that, but it doesn’t cover the GPG signature). There’s also some ASF rule 
> I think about releases needing to be done by a human, but that might be more 
> about reproducible builds.
> 
> Matt Sicker
> 
>> On Oct 15, 2021, at 05:57, Volkan Yazıcı  wrote:
>> 
>> I long had the ambition to move the entire site & manual to gh-pages.
>> In an ideal world, I would even move the release process to GitHub Actions
>> too.
>> But these are, for now, pretty ambitious goals.
>> What I would really appreciate is to access gh-pages content via, say,
>> https://beta.logging.apache.org/log4j URL.
>> Matt, mind helping me with setting this up please?
>> 
>>> On Wed, Oct 13, 2021 at 7:12 PM Matt Sicker  wrote:
>>> 
>>> That's really cool! Do note that we can publish to the ASF-specific
>>> branches, too, for hosting a site.
>>> 
 On Wed, Oct 13, 2021 at 10:37 AM Volkan Yazıcı  wrote:
 
 Do this:
 
 git fetch -p
 git checkout -B gh-pages origin/gh-pages
 python -m http.server
 open http://localhost:8000/benchmark/results/index.html
 
 *The magic:*
 
>>> https://github.com/apache/logging-log4j2/blob/release-2.x/.github/workflows/benchmark.yml
 
 *Disadvantages:* Runner specs are on the flux, though mostly pretty
>>> stable.
 
 *Future work:*
 
  - Enable GitHub pages for the project?
  - Incorporate more from log4j-perf to here.
  - Put the workflow onto a cron schedule.
>>> 
> 

Re: maven-shaded-log4j-transformer

[Gary Gregory]

I think Ralph started a tools repo which we should reuse for this component
IMO.

Gary

On Fri, Oct 15, 2021, 11:22 Matt Sicker  wrote:

> I’m in favor of making this its own repo. Making the build, site, and
> release process as simple as possible would be great. I can help with the
> release process at least.
>
> Matt Sicker
>
> > On Oct 15, 2021, at 09:56, Volkan Yazıcı  wrote:
> >
> > License headers, `changes.xml` integration, JPMS shizzle(?), etc. I
> guess
> > we will need to copy quite some plumbing code from Log4j 2. Nevertheless,
> > they are all doable.
> > I am also in favor of using GitHub all the way down: GitHub Issues for
> > issue tracking, GitHub Actions for CI/CD (yes, even CD!), GitHub pages
> for
> > publishing the Maven-generated site, etc.
> >
> >
> >> On Fri, Oct 15, 2021 at 4:48 PM Gary Gregory 
> wrote:
> >>
> >> Hi Ed,
> >>
> >> Your files must have the Apache License header comment, otherwise
> running
> >> 'mvn apache-rat:check' will fail.
> >>
> >> Gary
> >>
> >>
> >>> On Fri, Oct 15, 2021, 09:49 Eduard Gizatullin 
> wrote:
> >>>
> >>> Hello dear log4j team
> >>>
> >>> Volkan Yazıcı asked me to make  maven-shaded-log4j-transformer
> >>>  a part of
> >>> log4j2  and I tend to accomplish the proposal.
> >>>
> >>> Can you please confirm that
> >>> new sub-module name  log4j-maven-shade-plugin is ok
> >>>
> >>> Any preliminary advice will be appreciated
> >>>
> >>>
> >>> --
> >>> Best regards,
> >>> Ed
> >>>
> >>>
>  On Fri, Oct 15, 2021 at 1:39 PM Volkan Yazıcı  wrote:
> >>>
>  Thanks for the prompt (and positive!) reply Eduard!
>  I think it is best to first lay out the details of the plan in a post
> >>> to the
>  dev mailing list <
> https://logging.apache.org/log4j/2.x/mail-lists.html
>  .
>  For instance, the module name, transformer name, documentation
> changes,
>  etc.
>  This will give others an opportunity to share their feedback and
> >>> remarks.
>  Then simply create a JIRA <
> >>> https://issues.apache.org/jira/projects/LOG4J2>
>  ticket and submit a GitHub 
> >>> PR.
> 
>  `master` branch targets Log4j 3, which is not released yet.
>  It uses a different plugin loading mechanism than the one used in
> Log4j
> >>> 2.
>  Log4j 3 doesn't suffer from this "override of plugins after shading"
>  problem.
>  Hence, the PR needs to target the `release-2.x` branch.
> 
>  Also note that since this is a non-trivial contribution, you need to
> >>> sign the
>  ICLA document  and email it
> >>> to
>  the ASF .
>  Once you have done this, it is good to mention this in the dev mailing
>  list.
> 
>  On Fri, Oct 15, 2021 at 12:26 PM Eduard Gizatullin 
>  wrote:
> 
> > Hello Volkan,
> >
> > Thank you for letting me know, I'm all for it.
> >
> > Couldn't you please confirm that target branch is master
> > and log4j-maven-plugins is ok as new name of submodule
> >
> > Any other advices will be appreciated,
> >
> > --
> > Best regards,
> > Ed
> >
> >
> > On Fri, Oct 15, 2021 at 10:10 AM Volkan Yazıcı 
> wrote:
> >
> >> Hello,
> >>
> >> My name is Volkan Yazici and I am a PMC committee member of the ASF
> >> Logging Services, which develops Log4j too.
> >> maven-shaded-log4j-transformer
> >>  plugin
> >> addresses an important shortcoming of the Log4j 2.x plugin design
> >>> surfacing
> >> when users want to shade it. We have recently had a chat about it in
> >> the mailing list
> >> <
> >>>
> https://lists.apache.org/thread.html/rcfa4fc8678642a51e3a69dd2b14848fe4e1e5b71de7c99a7b55ff182%40%3Cdev.logging.apache.org%3E
>  ,
> >> and the maintainers (incl. me) are inclined to ship it as a part of
> >>> the
> >> Log4j project. Would you like to contribute it yourself in the form
> >>> of a
> >> GitHub PR? Note that this route is subject to update-push-review
> >>> cycles,
> >> yet they are pretty rewarding for both parties, IMHO. What do you
> >>> think?
> >>
> >> Kind regards.
> >>
> >
> >>>
> >>
>

Re: maven-shaded-log4j-transformer

[Ralph Goers]

Yeah, that makes sense.  It is less specific than just Maven plugins.

Ralph

> On Oct 15, 2021, at 9:51 AM, Gary Gregory  wrote:
> 
> I think Ralph started a tools repo which we should reuse for this component
> IMO.
> 
> Gary
> 
> On Fri, Oct 15, 2021, 11:22 Matt Sicker  wrote:
> 
>> I’m in favor of making this its own repo. Making the build, site, and
>> release process as simple as possible would be great. I can help with the
>> release process at least.
>> 
>> Matt Sicker
>> 
>>> On Oct 15, 2021, at 09:56, Volkan Yazıcı  wrote:
>>> 
>>> License headers, `changes.xml` integration, JPMS shizzle(?), etc. I
>> guess
>>> we will need to copy quite some plumbing code from Log4j 2. Nevertheless,
>>> they are all doable.
>>> I am also in favor of using GitHub all the way down: GitHub Issues for
>>> issue tracking, GitHub Actions for CI/CD (yes, even CD!), GitHub pages
>> for
>>> publishing the Maven-generated site, etc.
>>> 
>>> 
 On Fri, Oct 15, 2021 at 4:48 PM Gary Gregory 
>> wrote:
 
 Hi Ed,
 
 Your files must have the Apache License header comment, otherwise
>> running
 'mvn apache-rat:check' will fail.
 
 Gary
 
 
> On Fri, Oct 15, 2021, 09:49 Eduard Gizatullin 
>> wrote:
> 
> Hello dear log4j team
> 
> Volkan Yazıcı asked me to make  maven-shaded-log4j-transformer
>  a part of
> log4j2  and I tend to accomplish the proposal.
> 
> Can you please confirm that
> new sub-module name  log4j-maven-shade-plugin is ok
> 
> Any preliminary advice will be appreciated
> 
> 
> --
> Best regards,
> Ed
> 
> 
>> On Fri, Oct 15, 2021 at 1:39 PM Volkan Yazıcı  wrote:
> 
>> Thanks for the prompt (and positive!) reply Eduard!
>> I think it is best to first lay out the details of the plan in a post
> to the
>> dev mailing list <
>> https://logging.apache.org/log4j/2.x/mail-lists.html
>> .
>> For instance, the module name, transformer name, documentation
>> changes,
>> etc.
>> This will give others an opportunity to share their feedback and
> remarks.
>> Then simply create a JIRA <
> https://issues.apache.org/jira/projects/LOG4J2>
>> ticket and submit a GitHub 
> PR.
>> 
>> `master` branch targets Log4j 3, which is not released yet.
>> It uses a different plugin loading mechanism than the one used in
>> Log4j
> 2.
>> Log4j 3 doesn't suffer from this "override of plugins after shading"
>> problem.
>> Hence, the PR needs to target the `release-2.x` branch.
>> 
>> Also note that since this is a non-trivial contribution, you need to
> sign the
>> ICLA document  and email it
> to
>> the ASF .
>> Once you have done this, it is good to mention this in the dev mailing
>> list.
>> 
>> On Fri, Oct 15, 2021 at 12:26 PM Eduard Gizatullin 
>> wrote:
>> 
>>> Hello Volkan,
>>> 
>>> Thank you for letting me know, I'm all for it.
>>> 
>>> Couldn't you please confirm that target branch is master
>>> and log4j-maven-plugins is ok as new name of submodule
>>> 
>>> Any other advices will be appreciated,
>>> 
>>> --
>>> Best regards,
>>> Ed
>>> 
>>> 
>>> On Fri, Oct 15, 2021 at 10:10 AM Volkan Yazıcı 
>> wrote:
>>> 
 Hello,
 
 My name is Volkan Yazici and I am a PMC committee member of the ASF
 Logging Services, which develops Log4j too.
 maven-shaded-log4j-transformer
  plugin
 addresses an important shortcoming of the Log4j 2.x plugin design
> surfacing
 when users want to shade it. We have recently had a chat about it in
 the mailing list
 <
> 
>> https://lists.apache.org/thread.html/rcfa4fc8678642a51e3a69dd2b14848fe4e1e5b71de7c99a7b55ff182%40%3Cdev.logging.apache.org%3E
>> ,
 and the maintainers (incl. me) are inclined to ship it as a part of
> the
 Log4j project. Would you like to contribute it yourself in the form
> of a
 GitHub PR? Note that this route is subject to update-push-review
> cycles,
 yet they are pretty rewarding for both parties, IMHO. What do you
> think?
 
 Kind regards.
 
>>> 
> 
 
>> 

Re: maven-shaded-log4j-transformer

[Gary Gregory]

Here it is: https://github.com/apache/logging-log4j-tools

Gary


On Fri, Oct 15, 2021, 14:12 Ralph Goers  wrote:

> Yeah, that makes sense.  It is less specific than just Maven plugins.
>
> Ralph
>
> > On Oct 15, 2021, at 9:51 AM, Gary Gregory 
> wrote:
> >
> > I think Ralph started a tools repo which we should reuse for this
> component
> > IMO.
> >
> > Gary
> >
> > On Fri, Oct 15, 2021, 11:22 Matt Sicker  wrote:
> >
> >> I’m in favor of making this its own repo. Making the build, site, and
> >> release process as simple as possible would be great. I can help with
> the
> >> release process at least.
> >>
> >> Matt Sicker
> >>
> >>> On Oct 15, 2021, at 09:56, Volkan Yazıcı  wrote:
> >>>
> >>> License headers, `changes.xml` integration, JPMS shizzle(?), etc. I
> >> guess
> >>> we will need to copy quite some plumbing code from Log4j 2.
> Nevertheless,
> >>> they are all doable.
> >>> I am also in favor of using GitHub all the way down: GitHub Issues for
> >>> issue tracking, GitHub Actions for CI/CD (yes, even CD!), GitHub pages
> >> for
> >>> publishing the Maven-generated site, etc.
> >>>
> >>>
>  On Fri, Oct 15, 2021 at 4:48 PM Gary Gregory 
> >> wrote:
> 
>  Hi Ed,
> 
>  Your files must have the Apache License header comment, otherwise
> >> running
>  'mvn apache-rat:check' will fail.
> 
>  Gary
> 
> 
> > On Fri, Oct 15, 2021, 09:49 Eduard Gizatullin 
> >> wrote:
> >
> > Hello dear log4j team
> >
> > Volkan Yazıcı asked me to make  maven-shaded-log4j-transformer
> >  a part of
> > log4j2  and I tend to accomplish the proposal.
> >
> > Can you please confirm that
> > new sub-module name  log4j-maven-shade-plugin is ok
> >
> > Any preliminary advice will be appreciated
> >
> >
> > --
> > Best regards,
> > Ed
> >
> >
> >> On Fri, Oct 15, 2021 at 1:39 PM Volkan Yazıcı 
> wrote:
> >
> >> Thanks for the prompt (and positive!) reply Eduard!
> >> I think it is best to first lay out the details of the plan in a
> post
> > to the
> >> dev mailing list <
> >> https://logging.apache.org/log4j/2.x/mail-lists.html
> >> .
> >> For instance, the module name, transformer name, documentation
> >> changes,
> >> etc.
> >> This will give others an opportunity to share their feedback and
> > remarks.
> >> Then simply create a JIRA <
> > https://issues.apache.org/jira/projects/LOG4J2>
> >> ticket and submit a GitHub <
> https://github.com/apache/logging-log4j2>
> > PR.
> >>
> >> `master` branch targets Log4j 3, which is not released yet.
> >> It uses a different plugin loading mechanism than the one used in
> >> Log4j
> > 2.
> >> Log4j 3 doesn't suffer from this "override of plugins after shading"
> >> problem.
> >> Hence, the PR needs to target the `release-2.x` branch.
> >>
> >> Also note that since this is a non-trivial contribution, you need to
> > sign the
> >> ICLA document  and email
> it
> > to
> >> the ASF .
> >> Once you have done this, it is good to mention this in the dev
> mailing
> >> list.
> >>
> >> On Fri, Oct 15, 2021 at 12:26 PM Eduard Gizatullin <
> edw...@gmail.com>
> >> wrote:
> >>
> >>> Hello Volkan,
> >>>
> >>> Thank you for letting me know, I'm all for it.
> >>>
> >>> Couldn't you please confirm that target branch is master
> >>> and log4j-maven-plugins is ok as new name of submodule
> >>>
> >>> Any other advices will be appreciated,
> >>>
> >>> --
> >>> Best regards,
> >>> Ed
> >>>
> >>>
> >>> On Fri, Oct 15, 2021 at 10:10 AM Volkan Yazıcı 
> >> wrote:
> >>>
>  Hello,
> 
>  My name is Volkan Yazici and I am a PMC committee member of the
> ASF
>  Logging Services, which develops Log4j too.
>  maven-shaded-log4j-transformer
>   plugin
>  addresses an important shortcoming of the Log4j 2.x plugin design
> > surfacing
>  when users want to shade it. We have recently had a chat about it
> in
>  the mailing list
>  <
> >
> >>
> https://lists.apache.org/thread.html/rcfa4fc8678642a51e3a69dd2b14848fe4e1e5b71de7c99a7b55ff182%40%3Cdev.logging.apache.org%3E
> >> ,
>  and the maintainers (incl. me) are inclined to ship it as a part
> of
> > the
>  Log4j project. Would you like to contribute it yourself in the
> form
> > of a
>  GitHub PR? Note that this route is subject to update-push-review
> > cycles,
>  yet they are pretty rewarding for both parties, IMHO. What do you
> > think?
> 
>  Kind regards.
> 
> >>>
> >
> 
> >>
>
>
>