[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117855#comment-16117855
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user kpm1985 closed the pull request at:

https://github.com/apache/logging-log4j2/pull/106


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117854#comment-16117854
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user kpm1985 commented on the issue:

https://github.com/apache/logging-log4j2/pull/106
  
And thanks for your input, but I think my time would be better served 
somewhere else where people don't refer the COD for calling out some childish 
commenting and capital letters. Take care!


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117665#comment-16117665
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797686
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/HostNameTest.java ---
@@ -16,21 +16,24 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.hamcrest.Matchers.endsWith;
+import static org.hamcrest.Matchers.hasSize;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertThat;
+
 import java.util.List;
 
 import org.apache.logging.log4j.core.appender.RollingFileAppender;
 import org.apache.logging.log4j.core.util.NetUtils;
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.test.appender.ListAppender;
 import org.apache.logging.log4j.util.Strings;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117654#comment-16117654
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798431
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/ShutdownTimeoutConfigurationTest.java
 ---
@@ -16,13 +16,14 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117648#comment-16117648
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797278
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/GcFreeAsynchronousLoggingTest.java
 ---
@@ -18,6 +18,7 @@
 
 import org.apache.logging.log4j.categories.AsyncLoggers;
 import org.apache.logging.log4j.core.async.AsyncLoggerContextSelector;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117646#comment-16117646
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797459
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/HostNameTest.java ---
@@ -16,21 +16,24 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.hamcrest.Matchers.endsWith;
+import static org.hamcrest.Matchers.hasSize;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertThat;
+
--- End diff --

static imports go last. We also allow wildcard imports of static imports so 
this change isn't required.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117639#comment-16117639
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797094
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/DeadlockTest.java ---
@@ -17,6 +17,7 @@
 package org.apache.logging.log4j.core;
 
 import org.apache.logging.log4j.junit.LoggerContextRule;
+
--- End diff --

We don't require whitespace here.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117643#comment-16117643
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797043
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsOverrideTest.java
 ---
@@ -83,9 +83,9 @@ public void testLog() {
 final Logger logger = context.getLogger();
 final List events = listAppender.getEvents();
 assertThat(events, hasSize(0));
-logger.debug("Hello, {}", "World");
+logger.debug("Hello, {}", "World Debug");
--- End diff --

Why is the message being changed?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117645#comment-16117645
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797698
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LateConfigTest.java ---
@@ -26,6 +26,7 @@
 import org.apache.logging.log4j.core.config.DefaultConfiguration;
 import org.apache.logging.log4j.core.config.xml.XmlConfiguration;
 import org.apache.logging.log4j.status.StatusLogger;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117659#comment-16117659
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797863
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventFactoryTest.java 
---
@@ -52,7 +53,7 @@
 
 private ListAppender app;
 
-// this would look so cool using lambdas
+// consider using lambdas
--- End diff --

Why is this change required?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117649#comment-16117649
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797604
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CollectionLoggingTest.java
 ---
@@ -26,6 +26,7 @@
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.message.StringMapMessage;
 import org.apache.logging.log4j.test.appender.ListAppender;
+
--- End diff --

We don't require whitespace here.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117652#comment-16117652
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797908
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventTest.java ---
@@ -27,6 +27,7 @@
 import org.apache.logging.log4j.core.impl.Log4jLogEvent;
 import org.apache.logging.log4j.message.Message;
 import org.apache.logging.log4j.message.SimpleMessage;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117666#comment-16117666
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798474
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/TimestampMessageTest.java
 ---
@@ -16,6 +16,9 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117651#comment-16117651
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797263
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/ExtendedLevelTest.java 
---
@@ -22,6 +22,7 @@
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.test.ExtendedLevels;
 import org.apache.logging.log4j.test.appender.ListAppender;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117640#comment-16117640
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131796906
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/BasicLoggingTest.java ---
@@ -28,7 +29,7 @@
 @Test
 public void test1() {
 final Logger logger = 
LogManager.getLogger(BasicLoggingTest.class.getName());
-logger.debug("debug not set");
+logger.debug("Debug not set");
--- End diff --

Why is the message being changed?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117664#comment-16117664
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798273
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LoggerUpdateTest.java ---
@@ -16,11 +16,15 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertSame;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117656#comment-16117656
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798101
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LoggerDateTest.java ---
@@ -16,6 +16,8 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertTrue;
--- End diff --

static imports go last. We allow wildcard imports so this change isn't 
necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117658#comment-16117658
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798450
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/StrictXmlConfigTest.java 
---
@@ -16,6 +16,8 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117650#comment-16117650
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797060
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsOverrideTest.java
 ---
@@ -83,9 +83,9 @@ public void testLog() {
 final Logger logger = context.getLogger();
 final List events = listAppender.getEvents();
 assertThat(events, hasSize(0));
-logger.debug("Hello, {}", "World");
+logger.debug("Hello, {}", "World Debug");
 assertThat(events, hasSize(1));
-logger.log(warnLevel, "Hello DIAG");
+logger.log(warnLevel, "Hello World Warn");
--- End diff --

Why is the message being changed?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117660#comment-16117660
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798324
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/PatternSelectorTest.java 
---
@@ -16,6 +16,10 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117668#comment-16117668
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797894
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventFactoryTest.java 
---
@@ -87,7 +88,7 @@ public void before() {
 @Test
 public void testEvent() {
 final org.apache.logging.log4j.Logger logger = 
context.getLogger("org.apache.test.LogEventFactory");
-logger.error("error message");
+logger.error("Error message");
--- End diff --

Why does this message need to be changed?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117637#comment-16117637
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131796799
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/AppenderRefLevelJsonTest.java
 ---
@@ -16,19 +16,20 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.hamcrest.Matchers.hasSize;
+import static org.junit.Assert.assertThat;
--- End diff --

Static imports go last. This fix is incorrect.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117638#comment-16117638
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131796844
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/AppenderRefLevelTest.java
 ---
@@ -16,6 +16,8 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertEquals;
+
--- End diff --

Static imports go last. This fix is incorrect. We also allow wildcard 
static imports so this change isn't required.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117661#comment-16117661
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798408
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/PropertiesFileConfigTest.java
 ---
@@ -52,7 +53,7 @@ public void testReconfiguration() throws Exception {
 final File file = new File(CONFIG);
 final long orig = file.lastModified();
 final long newTime = orig + 1;
-assertTrue("setLastModified should have succeeded.", 
file.setLastModified(newTime));
+assertTrue("setLastModified() should have succeeded.", 
file.setLastModified(newTime));
--- End diff --

why do we need the parens?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117663#comment-16117663
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798421
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/ShutdownDisabledTest.java
 ---
@@ -16,13 +16,14 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117641#comment-16117641
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797196
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsWithFiltersTest.java
 ---
@@ -25,6 +25,7 @@
 import org.apache.logging.log4j.core.filter.CompositeFilter;
 import org.apache.logging.log4j.core.filter.ThresholdFilter;
 import org.apache.logging.log4j.junit.LoggerContextRule;
+
--- End diff --

We don't require whitespace here. We don't disallow it either.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117662#comment-16117662
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797963
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventTest.java ---
@@ -99,20 +100,20 @@ public void testNanoTimeIsNotSerialized1() throws 
Exception {
 final LogEvent actual = (LogEvent) ois.readObject();
 assertNotEquals("Different event: nanoTime", copy, actual);
 assertNotEquals("Different nanoTime", copy.getNanoTime(), 
actual.getNanoTime());
-assertEquals("deserialized nanoTime is zero", 0, 
actual.getNanoTime());
+assertEquals("Deserialized nanoTime is zero", 0, 
actual.getNanoTime());
--- End diff --

Why does this message need to be changed?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117667#comment-16117667
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798543
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/XmlEvents.java ---
@@ -23,6 +23,7 @@
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.message.AsynchronouslyFormattable;
 import org.apache.logging.log4j.message.StructuredDataMessage;
+
--- End diff --

We don't require whitespace here.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117647#comment-16117647
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r13179
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventFactoryTest.java 
---
@@ -34,6 +34,7 @@
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.message.Message;
 import org.apache.logging.log4j.test.appender.ListAppender;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117655#comment-16117655
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798314
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LookupTest.java ---
@@ -16,14 +16,15 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
--- End diff --

static imports go last. We allow wildcard static imports so this change 
isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117644#comment-16117644
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797217
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsTest.java ---
@@ -26,6 +26,7 @@
 import org.apache.logging.log4j.Level;
 import org.apache.logging.log4j.junit.LoggerContextRule;
 import org.apache.logging.log4j.test.appender.ListAppender;
+
--- End diff --

We don't require whitespace here. We don't disallow it either, but not sure 
what the point is.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117642#comment-16117642
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797360
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/GcFreeSynchronousLoggingTest.java
 ---
@@ -32,6 +32,7 @@ public void testNoAllocationDuringSteadyStateLogging() 
throws Throwable {
 
 /**
  * This code runs in a separate process, instrumented with the Google 
Allocation Instrumenter.
+ * First is the above spelled correctly, secondly where is the import 
then? (KM)
--- End diff --

Why is this in the patch? It should be a question on the dev list.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117657#comment-16117657
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131798369
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/PropertiesFileConfigTest.java
 ---
@@ -24,6 +24,7 @@
 
 import org.apache.logging.log4j.core.config.Configuration;
 import org.apache.logging.log4j.junit.LoggerContextRule;
+
--- End diff --

We don't require whitespace here.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117653#comment-16117653
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797743
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/LevelTest.java ---
@@ -16,6 +16,12 @@
  */
 package org.apache.logging.log4j.core;
 
+import static org.hamcrest.Matchers.hasSize;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertThat;
+
--- End diff --

We allow wildcards on static imports so this change isn't necessary.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117636#comment-16117636
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user rgoers commented on a diff in the pull request:

https://github.com/apache/logging-log4j2/pull/106#discussion_r131797005
  
--- Diff: 
log4j-core/src/test/java/org/apache/logging/log4j/core/CronRolloverApp.java ---
@@ -20,7 +20,7 @@
 import org.apache.logging.log4j.Logger;
 
 /**
- * Created by rgoers on 1/1/17.
+ * Created by Ralph Goers on 1/1/17.
--- End diff --

This line should be removed entirely. 


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-08-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114091#comment-16114091
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


GitHub user kpm1985 opened a pull request:

https://github.com/apache/logging-log4j2/pull/106

LOG4J2-1997 This cleans up the entire test package of import wildcards…

…, deprecated methods, typos and other trivial issues.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kpm1985/logging-log4j2 LOG4J2-1997

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/logging-log4j2/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #106


commit 86dabe57602743afc3fac3fd6e89301c9ae291a8
Author: Kenneth 
Date:   2017-08-04T07:59:12Z

LOG4J2-1997 This cleans up the entire test branch of import wildcards, 
deprecated methods, typos and other trivial issues.




> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-07-31 Thread kenneth mcfarland (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108338#comment-16108338
 ] 

kenneth mcfarland commented on LOG4J2-1997:
---

https://github.com/apache/logging-log4j2/pull/104 this pr uses try with 
resources as advised.


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-07-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108314#comment-16108314
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user kpm1985 closed the pull request at:

https://github.com/apache/logging-log4j2/pull/103


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-07-31 Thread kenneth mcfarland (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108267#comment-16108267
 ] 

kenneth mcfarland commented on LOG4J2-1997:
---

Great point, I'll clean it up after dinner Gary.




> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-07-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108260#comment-16108260
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


Github user garydgregory commented on the issue:

https://github.com/apache/logging-log4j2/pull/103
  
The resources are still leaking if the tests fail midway through a method. 
How about using try-with-resources clauses?


> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

2017-07-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108255#comment-16108255
 ] 

ASF GitHub Bot commented on LOG4J2-1997:


GitHub user kpm1985 opened a pull request:

https://github.com/apache/logging-log4j2/pull/103

LOG4J2-1997 Remove deprecated methods and close resource leaks.

This closes the jira.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kpm1985/logging-log4j2 mytestbranch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/logging-log4j2/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #103


commit ca46631fb4e3484641674763119cb1bbc3308821
Author: Kenneth McFarland 
Date:   2017-08-01T01:30:24Z

Remove deprecated methods and close resource leaks.




> Test classes do not close resources and use deprecated methods
> --
>
> Key: LOG4J2-1997
> URL: https://issues.apache.org/jira/browse/LOG4J2-1997
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.9
> Environment: Ubuntu Linux 16.04.2 x64 
> Oracle Java 8 with Hotspot
>Reporter: kenneth mcfarland
> Fix For: 2.9
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Some of the test classes are not closing resources and / or using deprecated 
> methods. I have modified a number of files to keep the test cases looking 
> clean. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)