[GitHub] [lucene-solr] mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-504617369 Merged into upstream master branch. Updated CHANGES: ``` +* LUCENE-8778: Define analyzer SPI names as static final fields and document the names in Javadocs. + (Tomoko Uchida, Uwe Schindler) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-504519715 Thanks, I will push it to master soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-504019096 Hi, just from curiosity I've googled for a while if we can handle case insensitive lookup with LinkedHashMap so that we don't need extra Set object for reference. There are (not very attractive) two options: 1. Create a special Map implementation which preserves insert order and also provides case insensitive lookup 2. Create a special class which holds a String (service name) and has case-insensitive hashCode() and equals() I think both are somewhat over-engineering for the use case here, so current implementation seems like an appropriate solution. Any comments? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-496878927 Hi @uschindler, this PR passed all tests & precommit. If the changes in `AnalysisSPILoader` looks fine for you, I will commit it to the ASF repo's master branch. (Maybe I will merge it to the master, but not to 8x?) Let me know if you find anything wrong, or of course you can directly modify the branch like the previous time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-496000812 Just a quick note: A few times I nearly committed the `__pycache__` directory, so I added this to the gitignore file. This does not work for python2. Please let me know if the python scripts could be run on python2 (depending on the system environments), I fixed the file again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-495680743 It is not related to this issue, but I'd like to add this line to the gitignore file. I occasionally see the python bytecode cache directory is created under `dev-tools/scripts`, though I've not figured out which ant task generates this... ``` diff --git a/.gitignore b/.gitignore index 4b947436dc..674ddd198f 100644 --- a/.gitignore +++ b/.gitignore @@ -26,3 +26,4 @@ pom.xml /nbproject /nb-build .pydevproject +__pycache__ ``` Alternatively, I think we can completely disable the cache (don't write .pyc or .pyo files) by `-B` option. https://stackoverflow.com/questions/16869024/what-is-pycache This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-494882383 "NAME" field and Javadoc tags were added to all tokenizers/filters so this passes unit tests. I will do regression test soon. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-489340583 I updated the branch: refine the catch clause and safety checks in the SPI loader; use camel casing for names. Remaining work: - Add the "NAME" field and Javadocs to all other analysis components - Write regression tests for all existing components - (Look for easier ways to do so...) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names
mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-486757857 To begin with, I only changed char filters for design review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
