[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r260701264 ## File path: solr/solr-ref-guide/src/indexing-nested-documents.adoc ## @@ -0,0 +1,137 @@ += Indexing Nested Child Documents +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +Solr supports indexing nested documents such as a blog post parent document and comments as child documents -- or products as parent documents and sizes, colors, or other variations as child documents. + +The parent with all children is referred to as a "block" and it explains some of the nomenclature of related features. +At query time, the <> can search these relationships, + and the `<>` Document Transformer can attach child documents to the result documents. +In terms of performance, indexing the relationships between documents usually yields much faster queries than an equivalent "query time join", + since the relationships are already stored in the index and do not need to be computed. +However, nested documents are less flexible than query time joins as it imposes rules that some applications may not be able to accept. +Nested documents may be indexed via either the XML or JSON data syntax, and is also supported by <> with javabin. + +[NOTE] + +A big limitation is that the whole block of parent-children documents must be updated or deleted together, not separately. +In other words, even if a single child document or the parent document is changed, the whole block of parent-child documents must be indexed together. +_Solr does not enforce this rule_; if it's violated, you may get sporadic query failures or incorrect results. + + Review comment: Added another sub-heading [Updating Nested Documents](https://github.com/apache/lucene-solr/pull/549/files#diff-4237153c1ae257b8102d28f63fe58019R142) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r260700838 ## File path: solr/solr-ref-guide/src/other-parsers.adoc ## @@ -24,7 +24,7 @@ Many of these parsers are expressed the same way as <>. +There are two query parsers that support block joins. These parsers allow indexing and searching for relational content that has been <>. Review comment: Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r260614769 ## File path: solr/solr-ref-guide/src/searching-nested-documents.adoc ## @@ -0,0 +1,202 @@ += Searching Nested Child Documents +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +This section exposes potential techniques which can be used for searching deeply nested documents, Review comment: There is a link to the indexing page in the following line. Would that be sufficient? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r256727353 ## File path: solr/solr-ref-guide/src/nested-documents.adoc ## @@ -0,0 +1,309 @@ += Nested Child Documents +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +Solr supports indexing nested documents such as a blog post parent document and comments as child documents -- or products as parent documents and sizes, colors, or other variations as child documents. +The parent with all children is referred to as a "block" and it explains some of the nomenclature of related features. +At query time, the <> can search these relationships, + and the `<>` Document Transformer can attach child documents to the result documents. +In terms of performance, indexing the relationships between documents usually yields much faster queries than an equivalent "query time join", + since the relationships are already stored in the index and do not need to be computed. +However, nested documents are less flexible than query time joins as it imposes rules that some applications may not be able to accept. + +.Note +[NOTE] + +A big limitation is that the whole block of parent-children documents must be updated or deleted together, not separately. +In other words, even if a single child document or the parent document is changed, the whole block of parent-child documents must be indexed together. +_Solr does not enforce this rule_; if it's violated, you may get sporadic query failures or incorrect results. + + +Nested documents may be indexed via either the XML or JSON data syntax, and is also supported by <> with javabin. + +=== Schema Notes + + * The schema must include indexed field `\_root_`. The value of that field is populated automatically and is the same for all documents in the block, regardless of the inheritance depth. The id of the top document in every nested hierarchy is populated in this field. + * `\_nest_path_` can be configured to store the path of the document in the hierarchy + * `\_nest_parent_` can be configured to store the `id` of the parent in the previous level + * Nested documents are very much documents in their own right even if certain nested documents hold different information from the parent. + Therefore: + ** the schema must be able to represent the fields of any document + ** it may be infeasible to use `required` + ** even child documents need a unique `id` + + +=== Rudimentary Root-only schemas + * These schemas do not contain any other nested related fields apart from `\_root_`. + + In this mode relationship types(field names) between parents and their children are not saved. + + In this case <> transformer returns all children under the `\_childDocuments_` field. + * The schema must include an indexed, non-stored field `\_root_`. The value of that field is populated automatically and is the same for all documents in the block, regardless of the inheritance depth. + * You must include a field that identifies the parent document as a parent; it can be any field that suits this purpose, and it will be used as input for the <>. + * If you associate a child document as a field (e.g., comment), that field need not be defined in the schema, and probably + shouldn't be as it would be confusing. There is no child document field type. + +=== XML Examples + +For example, here are two documents and their child documents. +It illustrates two styles of adding child documents; the first is associated via a field "comment" (preferred), +and the second is done in the classic way now referred to as an "anonymous" or "unlabelled" child document. +This field label relationship is available to the URP chain in Solr but is ultimately discarded. +Solr 8 will save the relationship. + +[source,xml] + + + +1 +Solr adds block join support +parentDocument + + +2 +SolrCloud supports it too! + + + + +3 +New Lucene and Solr release is out +parentDocument + + 4 + Lots of new features + + + + + +In this example, we have indexed the parent documents with the field
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r256257063 ## File path: solr/solr-ref-guide/src/nested-documents.adoc ## @@ -0,0 +1,309 @@ += Nested Child Documents +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +Solr supports indexing nested documents such as a blog post parent document and comments as child documents -- or products as parent documents and sizes, colors, or other variations as child documents. +The parent with all children is referred to as a "block" and it explains some of the nomenclature of related features. +At query time, the <> can search these relationships, + and the `<>` Document Transformer can attach child documents to the result documents. +In terms of performance, indexing the relationships between documents usually yields much faster queries than an equivalent "query time join", + since the relationships are already stored in the index and do not need to be computed. +However, nested documents are less flexible than query time joins as it imposes rules that some applications may not be able to accept. + +.Note +[NOTE] + +A big limitation is that the whole block of parent-children documents must be updated or deleted together, not separately. +In other words, even if a single child document or the parent document is changed, the whole block of parent-child documents must be indexed together. +_Solr does not enforce this rule_; if it's violated, you may get sporadic query failures or incorrect results. + + +Nested documents may be indexed via either the XML or JSON data syntax, and is also supported by <> with javabin. + +=== Schema Notes + + * The schema must include indexed field `\_root_`. The value of that field is populated automatically and is the same for all documents in the block, regardless of the inheritance depth. The id of the top document in every nested hierarchy is populated in this field. + * `\_nest_path_` can be configured to store the path of the document in the hierarchy + * `\_nest_parent_` can be configured to store the `id` of the parent in the previous level + * Nested documents are very much documents in their own right even if certain nested documents hold different information from the parent. + Therefore: + ** the schema must be able to represent the fields of any document + ** it may be infeasible to use `required` + ** even child documents need a unique `id` + + +=== Rudimentary Root-only schemas + * These schemas do not contain any other nested related fields apart from `\_root_`. + + In this mode relationship types(field names) between parents and their children are not saved. + + In this case <> transformer returns all children under the `\_childDocuments_` field. + * The schema must include an indexed, non-stored field `\_root_`. The value of that field is populated automatically and is the same for all documents in the block, regardless of the inheritance depth. + * You must include a field that identifies the parent document as a parent; it can be any field that suits this purpose, and it will be used as input for the <>. + * If you associate a child document as a field (e.g., comment), that field need not be defined in the schema, and probably + shouldn't be as it would be confusing. There is no child document field type. + +=== XML Examples + +For example, here are two documents and their child documents. +It illustrates two styles of adding child documents; the first is associated via a field "comment" (preferred), +and the second is done in the classic way now referred to as an "anonymous" or "unlabelled" child document. +This field label relationship is available to the URP chain in Solr but is ultimately discarded. +Solr 8 will save the relationship. + +[source,xml] + + + +1 +Solr adds block join support +parentDocument + + +2 +SolrCloud supports it too! + + + + +3 +New Lucene and Solr release is out +parentDocument + + 4 + Lots of new features + + + + + +In this example, we have indexed the parent documents with the field
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r254368025 ## File path: solr/solr-ref-guide/src/nested-documents.adoc ## @@ -0,0 +1,321 @@ += Nested Child Documents +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +Solr supports indexing nested documents such as a blog post parent document and comments as child documents -- or products as parent documents and sizes, colors, or other variations as child documents. +The parent with all children is referred to as a "block" and it explains some of the nomenclature of related features. +At query time, the <> can search these relationships, + and the `<>` Document Transformer can attach child documents to the result documents. +In terms of performance, indexing the relationships between documents usually yields much faster queries than an equivalent "query time join", + since the relationships are already stored in the index and do not need to be computed. +However, nested documents are less flexible than query time joins as it imposes rules that some applications may not be able to accept. + +.Note +[NOTE] + +A big limitation is that the whole block of parent-children documents must be updated or deleted together, not separately. +In other words, even if a single child document or the parent document is changed, the whole block of parent-child documents must be indexed together. +_Solr does not enforce this rule_; if it's violated, you may get sporadic query failures or incorrect results. + + +== Indexing Nested Documents + +Nested documents may be indexed via either the XML or JSON data syntax, and is also supported by <> with javabin. + +=== Schema Configuration + +{nbsp} + +*Fields:* + + * The schema must include indexed field `\_root_`. The value of that field is populated automatically and is the same for all documents in the block, regardless of the inheritance depth. The id of the top document in every nested hierarchy is populated in this field. + + `` + * `\_nest_path_` is used to store the path of the document in the hierarchy. This field is optional. + + ` + ` + * `\_nest_parent_` is used to store the `id` of the parent in the previous level. This field is optional. + + `` + * Nested documents are very much documents in their own right even if certain nested documents hold different information from the parent. + Therefore: + ** the schema must be able to represent the fields of any document + ** it may be infeasible to use `required` + ** even child documents need a unique `id` + * If you associate a child document as a field (e.g., comment), that field need not be defined in the schema, and probably +shouldn't be as it would be confusing. There is no child document field type. + +=== Rudimentary Root-only schemas + + * These schemas do not contain any other nested related fields apart from `\_root_`. + + In this mode relationship types(field names) between parents and their children are not saved. + + In this case <> transformer returns all children under the `\_childDocuments_` field. + * Typically you should have a field that differentiates a root doc from any nested children. However this isn't strictly necessary; so long as it's possible to write a query that can select only root documents somehow. Such a query is needed for the <> and <> doc transformer to function. + +=== XML Examples + +For example, here are two documents and their child documents. +It illustrates two styles of adding child documents; the first is associated via a field "comment" (preferred), +and the second is done in the classic way now referred to as an "anonymous" or "unlabelled" child document. +This field label relationship is available to the URP chain in Solr but is ultimately discarded. +Solr 8 will save the relationship. + +[source,xml] + + + +1 +Solr adds block join support +parentDocument + + +2 +SolrCloud supports it too! + + + + +3 +New Lucene and Solr release is out +parentDocument + + 4 + Lots of new features + + + + + +In this example, we have indexed
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r254355561 ## File path: solr/solr-ref-guide/src/index.adoc ## @@ -90,6 +90,27 @@ The *<>* section guides yo -- +[.row.match-my-cols] Review comment: Most of the additions concern with searching for nested documents. Would it still fit under indexing-and-basic-data-operations.adoc? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r253303258 ## File path: solr/solr-ref-guide/src/nested-documents.adoc ## @@ -264,11 +273,12 @@ For the upcoming examples, assume the following documents have been indexed: } - Combining Block Join Query Parser with Child Doc Transformer - * The combination of these two features enable seamless creation of powerful queries. + - For example, querying posts which are under a page tagged as a job, contain the words "Search Engineer". - The comments for matching posts can also be fetched, all done in a single Solr Query. - `q=+{!child of='-\_nest_path_:* *:*'}+tags:"jobs" =*,[child] + Combining Block Join Query Parsers with Child Doc Transformer +The combination of these two features enable seamless creation of powerful queries. + +For example, querying posts which are under a page tagged as a job, contain the words "Search Engineer". +The comments for matching posts can also be fetched, all done in a single Solr Query. + + * `q=+{!child of='-\_nest_path_:* *:*'}+tags:"jobs" =*,[child] Review comment: Yeah, I did test it manually and observed odd results. When using +{!child of='-\_nest_path_:*'}+tags:"jobs" no documents are found. This seems to be a problem with the way queries are optimized. When there is only a NOT clause in the "of" filter, the query is optimized to a MatchNoDocsQuery. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r253299278 ## File path: solr/solr-ref-guide/src/nested-documents.adoc ## @@ -36,17 +36,20 @@ Nested documents may be indexed via either the XML or JSON data syntax, and is a === Schema Notes - * The schema must include indexed fields field `\_root_`. The value of that field is populated automatically and is the same for all documents in the block, regardless of the inheritance depth. - Fields `\_nest_path_`, `\_nest_parent_` can be configured to store the path of the document in the hierarchy, and the unique `id` of the parent in the previous level. - These 2 fields will be used by NestedUpdateProcessor URP, which is implicitly configured under Solr 8, when `\_root_` field is defined. + * The schema must include indexed field `\_root_`. The value of that field is populated automatically and is the same for all documents in the block, regardless of the inheritance depth. The id of the top document in every nested hierarchy is populated in this field. + * `\_nest_path_` can be configured to store the path of the document in the hierarchy + * `\_nest_parent_` can be configured to store the `id` of the parent in the previous level * Nested documents are very much documents in their own right even if certain nested documents hold different information from the parent. Therefore: ** the schema must be able to represent the fields of any document ** it may be infeasible to use `required` ** even child documents need a unique `id` -=== Legacy Schema Notes +=== Rudimentary Root-only schemas + * These schemas do not contain any other nested related fields apart for `\_root_`. + + In this mode relationship types(field names) between parents and their children are not saved. + All children are indexed under the `\_childDocuments_` field. * The schema must include an indexed, non-stored field `\_root_`. The value of that field is populated automatically and is the same for all documents in the block, regardless of the inheritance depth. Review comment: It seems like it is not the case on master: **JsonLoader#isChildDoc:617** ```java private boolean isChildDoc(SolrInputDocument extendedFieldValue) { return extendedFieldValue.containsKey(req.getSchema().getUniqueKeyField().getName()); } ``` Perhaps we should file a new ticket for this one? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r253299278 ## File path: solr/solr-ref-guide/src/nested-documents.adoc ## @@ -36,17 +36,20 @@ Nested documents may be indexed via either the XML or JSON data syntax, and is a === Schema Notes - * The schema must include indexed fields field `\_root_`. The value of that field is populated automatically and is the same for all documents in the block, regardless of the inheritance depth. - Fields `\_nest_path_`, `\_nest_parent_` can be configured to store the path of the document in the hierarchy, and the unique `id` of the parent in the previous level. - These 2 fields will be used by NestedUpdateProcessor URP, which is implicitly configured under Solr 8, when `\_root_` field is defined. + * The schema must include indexed field `\_root_`. The value of that field is populated automatically and is the same for all documents in the block, regardless of the inheritance depth. The id of the top document in every nested hierarchy is populated in this field. + * `\_nest_path_` can be configured to store the path of the document in the hierarchy + * `\_nest_parent_` can be configured to store the `id` of the parent in the previous level * Nested documents are very much documents in their own right even if certain nested documents hold different information from the parent. Therefore: ** the schema must be able to represent the fields of any document ** it may be infeasible to use `required` ** even child documents need a unique `id` -=== Legacy Schema Notes +=== Rudimentary Root-only schemas + * These schemas do not contain any other nested related fields apart for `\_root_`. + + In this mode relationship types(field names) between parents and their children are not saved. + All children are indexed under the `\_childDocuments_` field. * The schema must include an indexed, non-stored field `\_root_`. The value of that field is populated automatically and is the same for all documents in the block, regardless of the inheritance depth. Review comment: It seems like this is not the case on master: **JsonLoader#isChildDoc:617** ```java private boolean isChildDoc(SolrInputDocument extendedFieldValue) { return extendedFieldValue.containsKey(req.getSchema().getUniqueKeyField().getName()); } ``` Perhaps we should file a new ticket for this one? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r253295498 ## File path: solr/solr-ref-guide/src/nested-documents.adoc ## @@ -36,17 +36,20 @@ Nested documents may be indexed via either the XML or JSON data syntax, and is a === Schema Notes - * The schema must include indexed fields field `\_root_`. The value of that field is populated automatically and is the same for all documents in the block, regardless of the inheritance depth. - Fields `\_nest_path_`, `\_nest_parent_` can be configured to store the path of the document in the hierarchy, and the unique `id` of the parent in the previous level. - These 2 fields will be used by NestedUpdateProcessor URP, which is implicitly configured under Solr 8, when `\_root_` field is defined. + * The schema must include indexed field `\_root_`. The value of that field is populated automatically and is the same for all documents in the block, regardless of the inheritance depth. The id of the top document in every nested hierarchy is populated in this field. + * `\_nest_path_` can be configured to store the path of the document in the hierarchy + * `\_nest_parent_` can be configured to store the `id` of the parent in the previous level * Nested documents are very much documents in their own right even if certain nested documents hold different information from the parent. Therefore: ** the schema must be able to represent the fields of any document ** it may be infeasible to use `required` ** even child documents need a unique `id` -=== Legacy Schema Notes +=== Rudimentary Root-only schemas + * These schemas do not contain any other nested related fields apart for `\_root_`. + + In this mode relationship types(field names) between parents and their children are not saved. + All children are indexed under the `\_childDocuments_` field. Review comment: Oops. My bad. I'll change it to returned. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r252301619 ## File path: solr/solr-ref-guide/src/json-facet-api.adoc ## @@ -664,7 +664,7 @@ NOTE: While a `query` domain can be combined with an additional domain `filter`, === Block Join Domain Changes -When a collection contains <>, the `blockChildren` or `blockParent` domain options can be used transform an existing domain containing one type of document, into a domain containing the documents with the specified relationship (child or parent of) to the documents from the original domain. Review comment: Would changing `blockChildren` and `blockParents` to nestedChildren and nestedParents also be in scope? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r252301619 ## File path: solr/solr-ref-guide/src/json-facet-api.adoc ## @@ -664,7 +664,7 @@ NOTE: While a `query` domain can be combined with an additional domain `filter`, === Block Join Domain Changes -When a collection contains <>, the `blockChildren` or `blockParent` domain options can be used transform an existing domain containing one type of document, into a domain containing the documents with the specified relationship (child or parent of) to the documents from the original domain. Review comment: Would changing blockChildren and blockParents to nestedChildren and nestedParents also be in scope? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r252299935 ## File path: solr/solr-ref-guide/src/nested-documents.adoc ## @@ -0,0 +1,299 @@ += Nested Child Documents +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +Solr supports indexing nested documents such as a blog post parent document and comments as child documents -- or products as parent documents and sizes, colors, or other variations as child documents. +The parent with all children is referred to as a "block" and it explains some of the nomenclature of related features. +At query time, the <> can search these relationships, Review comment: Since I did not explain how these parsers work under the hood, I thought I would link to that particular page. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r252299409 ## File path: solr/solr-ref-guide/src/nested-documents.adoc ## @@ -0,0 +1,299 @@ += Nested Child Documents +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +Solr supports indexing nested documents such as a blog post parent document and comments as child documents -- or products as parent documents and sizes, colors, or other variations as child documents. +The parent with all children is referred to as a "block" and it explains some of the nomenclature of related features. +At query time, the <> can search these relationships, Review comment: Oh I forgot to update this one. On it! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r252299409 ## File path: solr/solr-ref-guide/src/nested-documents.adoc ## @@ -0,0 +1,299 @@ += Nested Child Documents +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +Solr supports indexing nested documents such as a blog post parent document and comments as child documents -- or products as parent documents and sizes, colors, or other variations as child documents. +The parent with all children is referred to as a "block" and it explains some of the nomenclature of related features. +At query time, the <> can search these relationships, Review comment: Oh I forgot to update this one. On it! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] moshebla commented on a change in pull request #549: WIP:SOLR-13129
moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r252217037 ## File path: solr/solr-ref-guide/src/index.adoc ## @@ -90,6 +90,27 @@ The *<>* section guides yo -- +[.row.match-my-cols] Review comment: Yeah, I added Nested-Documents, since it did not have a separate entry This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org