[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011711#comment-13011711 ] Chris Male commented on LUCENE-2995: +1 > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011746#comment-13011746 ] Simon Willnauer commented on LUCENE-2995: - Robert, thanks for starting this and pushing up a patch. I think its a great start and we should try to let lots of other stuff follow ASAP. bq. Really any serious 'refactoring' e.g. perf improvements should be on followup issues I think. +1 > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011785#comment-13011785 ] Robert Muir commented on LUCENE-2995: - I think so? This issue just moves the code around, e.g. your FST-based Lookup impl would ultimately sit under modules/spellchecker instead of Solr, and lucene users would be able to use it, too. > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011792#comment-13011792 ] Michael McCandless commented on LUCENE-2995: This is awesome Robert! Spell checking is a hugely important feature... > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011835#comment-13011835 ] Dawid Weiss commented on LUCENE-2995: - Ok, great. I'll look into this this week. > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011836#comment-13011836 ] Robert Muir commented on LUCENE-2995: - well there's no rush on this issue, i just wanted to throw out the idea... I think it definitely makes sense if you are going to be implementing cool FST stuff for suggesting etc! i saw a lot of opportunities for refactoring just by combining the code in one place. > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012461#comment-13012461 ] Grant Ingersoll commented on LUCENE-2995: - See also SOLR-2080. Spell checking, suggestions and related searches are all part of what I would call a Suggester framework or a Discovery framework. Doesn't need to be done here, but I do think it's easy to have a common API for all of these "suggestions", especially if we can factor in user feedback into them, as right now, we only solve 1/2 of the problem. > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012473#comment-13012473 ] Robert Muir commented on LUCENE-2995: - Grant should we call the module suggestor or suggestions or something instead of spellcheck? I didnt spend a lot of time thinking about the name in the patch, but thats a good point. > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012476#comment-13012476 ] Andrzej Bialecki commented on LUCENE-2995: --- +1 for a "suggester" module. > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012524#comment-13012524 ] Grant Ingersoll commented on LUCENE-2995: - yeah, I like suggestions or suggester > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012569#comment-13012569 ] Hoss Man commented on LUCENE-2995: -- i don't really have any better suggestions (ack, i hate puns unintentional or otherwise) on the name, but the one word of caution i would put out there is that "suggestions" and "suggester" are vague about what they "suggest" people might confuse this with "morelikethis" or "recommendation engine" type stuff. if that's in the scope for what you guys have in mind for this module, go ahead. if not maybe "query-suggester" or "term-suggester" ? > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012577#comment-13012577 ] Steven Rowe commented on LUCENE-2995: - bq. maybe "query-suggester" or "term-suggester" ? Or maybe "reword" or "rephrase"? > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012596#comment-13012596 ] Steven Rowe commented on LUCENE-2995: - Or maybe "did-you-mean" or "instead"? > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012600#comment-13012600 ] Michael McCandless commented on LUCENE-2995: How about just "suggest"? I don't like suggester because I'm really not sure if it's spelled suggestor and I feel whatever name we choose here damned well better be easy to spell!! > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012609#comment-13012609 ] Grant Ingersoll commented on LUCENE-2995: - bq. if that's in the scope for what you guys have in mind for this module, go ahead. It's in the back of my head. I've got Mahout collab. filtering hooked up through Solr already and it would be dead simple to bring in here, too, but it would fit nicely in this framework. For instance, given a set of search results, it can go do Item-Item recommendations based on doc-ids. bq. suggest +1. Simple, to the point and has room to grow. > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024887#comment-13024887 ] Michael McCandless commented on LUCENE-2995: Is this ready to go in? > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025147#comment-13025147 ] Dawid Weiss commented on LUCENE-2995: - The patch probably won't apply after I added that automaton-based suggester to Solr, but I didn't have a chance to peek at it yet. > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025315#comment-13025315 ] Yonik Seeley commented on LUCENE-2995: -- -1 to this for now. The interpretation of what it means to be merged has taken a turn for the worse, with solr features being blocked (see SOLR-2272). I fear we may need to split Solr into it's own TLP, and hence we should be doing any further refactoring at this time since if Solr ends up as it's own project, it will want these files to remain under it's control. > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025421#comment-13025421 ] Greg Stein commented on LUCENE-2995: Yonik: that is an improper veto, and does not stand. > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025423#comment-13025423 ] Steven Rowe commented on LUCENE-2995: - bq. Yonik: that is an improper veto, and does not stand. Greg, could you please be more specific? Why is Yonik's veto improper? > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025427#comment-13025427 ] Yonik Seeley commented on LUCENE-2995: -- I understand Greg's objection - given that the projects are currently one, what I said was not a technical argument against the patch. If Lucene and Solr do end up splitting, Solr could always copy (or start at an earlier revision) any files that it needed more control over anyway. My -1 is rescinded. > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038096#comment-13038096 ] Robert Muir commented on LUCENE-2995: - these patches go completely out of date fast... (I had to redo the previous patch from scratch basically). I'd like to commit this one before this happens, and if anyone has concerns or objections I'll just revert and we can revisit. > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995-diff.patch, LUCENE-2995.patch, > LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038163#comment-13038163 ] Simon Willnauer commented on LUCENE-2995: - bq. I'd like to commit this one before this happens, and if anyone has concerns or objections I'll just revert and we can revisit. looks good after a quick scan... I think you should commit and we iterate on it once its in even if we need to revert. Reverting should not feel wrong so here is my +1 to commit > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995-diff.patch, LUCENE-2995.patch, > LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038170#comment-13038170 ] Greg Stein commented on LUCENE-2995: Or rather than revert... just iterate it forward until it satisfies everybody's concerns. Why keep moving backwards? > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995-diff.patch, LUCENE-2995.patch, > LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[ https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038198#comment-13038198 ] Robert Muir commented on LUCENE-2995: - I agree, I would much rather iterate forward if anyone has concerns. I will mark this issue resolved, we can open separate issues for any problems. I know of a few followup issues I will open myself. > factor out a shared spellchecking module > > > Key: LUCENE-2995 > URL: https://issues.apache.org/jira/browse/LUCENE-2995 > Project: Lucene - Java > Issue Type: Task >Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-2995-diff.patch, LUCENE-2995.patch, > LUCENE-2995.patch > > > In lucene's contrib we have spellchecking support (index-based spellchecker, > directspellchecker, etc). > we also have some things like pluggable comparators. > In solr we have auto-suggest support (with two implementations it looks > like), some good utilities like HighFrequencyDictionary, etc. > I think spellchecking is really important... google has upped the ante to > what users expect. > So I propose we combine all this stuff into a shared modules/spellchecker, > which will make it easier > to refactor and improve the quality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-2995) factor out a shared spellchecking module
[
https://issues.apache.org/jira/browse/LUCENE-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038205#comment-13038205
]
Mark Miller commented on LUCENE-2995:
-
{quote}Or rather than revert... just iterate it forward until it satisfies
everybody's concerns. Why keep moving backwards?{quote}
+1. Reverting itself should not feel wrong - asking others to revert should
IMO. The default mode should be moving forward, not backward. Everything is
open to change and improvement - asking for a revert from someone else will
always be considered a very big deal by me. Unless it's a special circumstance
I'm going to rant and rave about it every time myself.
> factor out a shared spellchecking module
>
>
> Key: LUCENE-2995
> URL: https://issues.apache.org/jira/browse/LUCENE-2995
> Project: Lucene - Java
> Issue Type: Task
>Reporter: Robert Muir
>Assignee: Robert Muir
> Fix For: 4.0
>
> Attachments: LUCENE-2995-diff.patch, LUCENE-2995.patch,
> LUCENE-2995.patch
>
>
> In lucene's contrib we have spellchecking support (index-based spellchecker,
> directspellchecker, etc).
> we also have some things like pluggable comparators.
> In solr we have auto-suggest support (with two implementations it looks
> like), some good utilities like HighFrequencyDictionary, etc.
> I think spellchecking is really important... google has upped the ante to
> what users expect.
> So I propose we combine all this stuff into a shared modules/spellchecker,
> which will make it easier
> to refactor and improve the quality.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
