[jira] [Commented] (LUCENE-3219) Change SortField types to an Enum
[ https://issues.apache.org/jira/browse/LUCENE-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052368#comment-13052368 ] Simon Willnauer commented on LUCENE-3219: - looks good to me. BTW. should we backport those changes? Change SortField types to an Enum - Key: LUCENE-3219 URL: https://issues.apache.org/jira/browse/LUCENE-3219 Project: Lucene - Java Issue Type: Improvement Components: core/search Reporter: Chris Male Assignee: Chris Male Priority: Minor Attachments: LUCENE-3219.patch, LUCENE-3219.patch, LUCENE-3219.patch, LUCENE-3219.patch When updating my SOLR-2533 patch, one issue was that the int value I had given my new type had been used by another change in the mean time. Since we don't use these fields in a bitset kind of way, we can convert them to an enum. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3219) Change SortField types to an Enum
[ https://issues.apache.org/jira/browse/LUCENE-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052377#comment-13052377 ] Chris Male commented on LUCENE-3219: You'll have to guide me on the backwards compat issue since this is a break due to the fields being public and some methods changing from returning int to returning SortField.Type. Change SortField types to an Enum - Key: LUCENE-3219 URL: https://issues.apache.org/jira/browse/LUCENE-3219 Project: Lucene - Java Issue Type: Improvement Components: core/search Reporter: Chris Male Assignee: Chris Male Priority: Minor Attachments: LUCENE-3219.patch, LUCENE-3219.patch, LUCENE-3219.patch, LUCENE-3219.patch When updating my SOLR-2533 patch, one issue was that the int value I had given my new type had been used by another change in the mean time. Since we don't use these fields in a bitset kind of way, we can convert them to an enum. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3219) Change SortField types to an Enum
[ https://issues.apache.org/jira/browse/LUCENE-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052390#comment-13052390 ] Uwe Schindler commented on LUCENE-3219: --- At the end of the day, I am sure I will vote to leave it as it is in 3.x! SortField is heavy-used in Lucene client code and the backwards breaks without very sophisticated backwards layers are horrible to handle. It can be done, but I dont think its worth the work just for code beauty. Change SortField types to an Enum - Key: LUCENE-3219 URL: https://issues.apache.org/jira/browse/LUCENE-3219 Project: Lucene - Java Issue Type: Improvement Components: core/search Reporter: Chris Male Assignee: Chris Male Priority: Minor Attachments: LUCENE-3219.patch, LUCENE-3219.patch, LUCENE-3219.patch, LUCENE-3219.patch When updating my SOLR-2533 patch, one issue was that the int value I had given my new type had been used by another change in the mean time. Since we don't use these fields in a bitset kind of way, we can convert them to an enum. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3219) Change SortField types to an Enum
[ https://issues.apache.org/jira/browse/LUCENE-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052402#comment-13052402 ] Chris Male commented on LUCENE-3219: For the reasons described above, I think its best we don't backport this change. Uwe, is the work here compatible with what you had planned in LUCENE-3192? If so, I'll go ahead and commit this. Change SortField types to an Enum - Key: LUCENE-3219 URL: https://issues.apache.org/jira/browse/LUCENE-3219 Project: Lucene - Java Issue Type: Improvement Components: core/search Reporter: Chris Male Assignee: Chris Male Priority: Minor Attachments: LUCENE-3219.patch, LUCENE-3219.patch, LUCENE-3219.patch, LUCENE-3219.patch When updating my SOLR-2533 patch, one issue was that the int value I had given my new type had been used by another change in the mean time. Since we don't use these fields in a bitset kind of way, we can convert them to an enum. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3219) Change SortField types to an Enum
[ https://issues.apache.org/jira/browse/LUCENE-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052404#comment-13052404 ] Uwe Schindler commented on LUCENE-3219: --- Just commit this, the other issue is quite unrelated, I just had same idea. Change SortField types to an Enum - Key: LUCENE-3219 URL: https://issues.apache.org/jira/browse/LUCENE-3219 Project: Lucene - Java Issue Type: Improvement Components: core/search Reporter: Chris Male Assignee: Chris Male Priority: Minor Attachments: LUCENE-3219.patch, LUCENE-3219.patch, LUCENE-3219.patch, LUCENE-3219.patch When updating my SOLR-2533 patch, one issue was that the int value I had given my new type had been used by another change in the mean time. Since we don't use these fields in a bitset kind of way, we can convert them to an enum. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3219) Change SortField types to an Enum
[ https://issues.apache.org/jira/browse/LUCENE-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13051856#comment-13051856 ] Simon Willnauer commented on LUCENE-3219: - +1 Change SortField types to an Enum - Key: LUCENE-3219 URL: https://issues.apache.org/jira/browse/LUCENE-3219 Project: Lucene - Java Issue Type: Improvement Components: core/search Reporter: Chris Male Priority: Minor When updating my SOLR-2533 patch, one issue was that the int value I had given my new type had been used by another change in the mean time. Since we don't use these fields in a bitset kind of way, we can convert them to an enum. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3219) Change SortField types to an Enum
[ https://issues.apache.org/jira/browse/LUCENE-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052137#comment-13052137 ] Simon Willnauer commented on LUCENE-3219: - chris, patch looks good... some minor comments: * I wonder if a parser could hold a Type so we could get rid of the if (parser instanceof FieldCache.$Parser) ? * in SearchWithSortTask I wonder if you could simply call Type.valueOf(typeString.toUpperCase()); - the less code the better :) overall looks good simon Change SortField types to an Enum - Key: LUCENE-3219 URL: https://issues.apache.org/jira/browse/LUCENE-3219 Project: Lucene - Java Issue Type: Improvement Components: core/search Reporter: Chris Male Priority: Minor Attachments: LUCENE-3219.patch, LUCENE-3219.patch, LUCENE-3219.patch When updating my SOLR-2533 patch, one issue was that the int value I had given my new type had been used by another change in the mean time. Since we don't use these fields in a bitset kind of way, we can convert them to an enum. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
