[jira] [Commented] (LUCENE-3260) need a test that uses termsenum.seekExact() (which returns true), then calls next()
[ https://issues.apache.org/jira/browse/LUCENE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057778#comment-13057778 ] Michael McCandless commented on LUCENE-3260: Thanks Shai! The 200+ iterations are exceptionally fast since they only do 1 TermsEnum op per iter (it's the indexing that'll be slow in this test -- for that I do numDocs = atLeast(10)). Also, this bug only happens when seekExact is followed by next, only on certain terms, and only on a multi-seg index. So it seems an OK investment of CPU for test coverage ;) need a test that uses termsenum.seekExact() (which returns true), then calls next() --- Key: LUCENE-3260 URL: https://issues.apache.org/jira/browse/LUCENE-3260 Project: Lucene - Java Issue Type: Bug Reporter: Robert Muir Assignee: Michael McCandless Attachments: LUCENE-3260.patch i tried to do some seekExact (where the result must exist) then next()ing in the faceting module, and it seems like there could be a bug here. I think we should add a test that mixes seekExact/seekCeil/next like this, to ensure that if seekExact returns true, that the enum is properly positioned. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3260) need a test that uses termsenum.seekExact() (which returns true), then calls next()
[ https://issues.apache.org/jira/browse/LUCENE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057896#comment-13057896 ] Shai Erera commented on LUCENE-3260: I see. Thanks for the clarification. +1 to commit. need a test that uses termsenum.seekExact() (which returns true), then calls next() --- Key: LUCENE-3260 URL: https://issues.apache.org/jira/browse/LUCENE-3260 Project: Lucene - Java Issue Type: Bug Reporter: Robert Muir Assignee: Michael McCandless Attachments: LUCENE-3260.patch i tried to do some seekExact (where the result must exist) then next()ing in the faceting module, and it seems like there could be a bug here. I think we should add a test that mixes seekExact/seekCeil/next like this, to ensure that if seekExact returns true, that the enum is properly positioned. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3260) need a test that uses termsenum.seekExact() (which returns true), then calls next()
[ https://issues.apache.org/jira/browse/LUCENE-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13057596#comment-13057596 ] Shai Erera commented on LUCENE-3260: Patch looks good Mike. One minor comment, atLeast(200) means we'll always run at least 200 iterations. Did you do it only for capturing the bug? Robert and Simon have done a great job at speeding up tests, so perhaps we should have a lower value, like 10 here? need a test that uses termsenum.seekExact() (which returns true), then calls next() --- Key: LUCENE-3260 URL: https://issues.apache.org/jira/browse/LUCENE-3260 Project: Lucene - Java Issue Type: Bug Reporter: Robert Muir Assignee: Michael McCandless Attachments: LUCENE-3260.patch i tried to do some seekExact (where the result must exist) then next()ing in the faceting module, and it seems like there could be a bug here. I think we should add a test that mixes seekExact/seekCeil/next like this, to ensure that if seekExact returns true, that the enum is properly positioned. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
