[jira] [Commented] (LUCENE-6367) Can PrefixQuery subclass AutomatonQuery?
[ https://issues.apache.org/jira/browse/LUCENE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383512#comment-14383512 ] ASF subversion and git services commented on LUCENE-6367: - Commit 1669522 from [~mikemccand] in branch 'dev/trunk' [ https://svn.apache.org/r1669522 ] LUCENE-6367: PrefixQuery now subclasses AutomatonQuery Can PrefixQuery subclass AutomatonQuery? Key: LUCENE-6367 URL: https://issues.apache.org/jira/browse/LUCENE-6367 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: Trunk, 5.1 Attachments: LUCENE-6367.patch, LUCENE-6367.patch Spinoff/blocker for LUCENE-5879. It seems like PrefixQuery should simply be an AutomatonQuery rather than specializing its own TermsEnum ... with maybe some performance improvements to ByteRunAutomaton.run to short-circuit once it's in a sink state, AutomatonTermsEnum could be just as fast as PrefixTermsEnum. If we can do this it will make LUCENE-5879 simpler. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6367) Can PrefixQuery subclass AutomatonQuery?
[ https://issues.apache.org/jira/browse/LUCENE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383528#comment-14383528 ] ASF subversion and git services commented on LUCENE-6367: - Commit 1669526 from [~mikemccand] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1669526 ] LUCENE-6367: PrefixQuery now subclasses AutomatonQuery Can PrefixQuery subclass AutomatonQuery? Key: LUCENE-6367 URL: https://issues.apache.org/jira/browse/LUCENE-6367 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: Trunk, 5.1 Attachments: LUCENE-6367.patch, LUCENE-6367.patch Spinoff/blocker for LUCENE-5879. It seems like PrefixQuery should simply be an AutomatonQuery rather than specializing its own TermsEnum ... with maybe some performance improvements to ByteRunAutomaton.run to short-circuit once it's in a sink state, AutomatonTermsEnum could be just as fast as PrefixTermsEnum. If we can do this it will make LUCENE-5879 simpler. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6367) Can PrefixQuery subclass AutomatonQuery?
[ https://issues.apache.org/jira/browse/LUCENE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383799#comment-14383799 ] ASF subversion and git services commented on LUCENE-6367: - Commit 1669578 from [~mikemccand] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1669578 ] LUCENE-6367: correct CHANGES entry: PrefixQuery already operated in binary term space Can PrefixQuery subclass AutomatonQuery? Key: LUCENE-6367 URL: https://issues.apache.org/jira/browse/LUCENE-6367 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: Trunk, 5.1 Attachments: LUCENE-6367.patch, LUCENE-6367.patch Spinoff/blocker for LUCENE-5879. It seems like PrefixQuery should simply be an AutomatonQuery rather than specializing its own TermsEnum ... with maybe some performance improvements to ByteRunAutomaton.run to short-circuit once it's in a sink state, AutomatonTermsEnum could be just as fast as PrefixTermsEnum. If we can do this it will make LUCENE-5879 simpler. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6367) Can PrefixQuery subclass AutomatonQuery?
[ https://issues.apache.org/jira/browse/LUCENE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383797#comment-14383797 ] ASF subversion and git services commented on LUCENE-6367: - Commit 1669577 from [~mikemccand] in branch 'dev/trunk' [ https://svn.apache.org/r1669577 ] LUCENE-6367: correct CHANGES entry: PrefixQuery already operated in binary term space Can PrefixQuery subclass AutomatonQuery? Key: LUCENE-6367 URL: https://issues.apache.org/jira/browse/LUCENE-6367 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: Trunk, 5.1 Attachments: LUCENE-6367.patch, LUCENE-6367.patch Spinoff/blocker for LUCENE-5879. It seems like PrefixQuery should simply be an AutomatonQuery rather than specializing its own TermsEnum ... with maybe some performance improvements to ByteRunAutomaton.run to short-circuit once it's in a sink state, AutomatonTermsEnum could be just as fast as PrefixTermsEnum. If we can do this it will make LUCENE-5879 simpler. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6367) Can PrefixQuery subclass AutomatonQuery?
[ https://issues.apache.org/jira/browse/LUCENE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375556#comment-14375556 ] Robert Muir commented on LUCENE-6367: - i think the boolean is fine. For the other subclasses, they are taking patterns and inspecting characters for that reason, so thats different. Can PrefixQuery subclass AutomatonQuery? Key: LUCENE-6367 URL: https://issues.apache.org/jira/browse/LUCENE-6367 Project: Lucene - Core Issue Type: Improvement Reporter: Michael McCandless Assignee: Michael McCandless Fix For: Trunk, 5.1 Attachments: LUCENE-6367.patch Spinoff/blocker for LUCENE-5879. It seems like PrefixQuery should simply be an AutomatonQuery rather than specializing its own TermsEnum ... with maybe some performance improvements to ByteRunAutomaton.run to short-circuit once it's in a sink state, AutomatonTermsEnum could be just as fast as PrefixTermsEnum. If we can do this it will make LUCENE-5879 simpler. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
