[jira] [Commented] (LUCENE-8272) Share internal DV update code between binary and numeric
[ https://issues.apache.org/jira/browse/LUCENE-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452251#comment-16452251 ] ASF subversion and git services commented on LUCENE-8272: - Commit 493e8fd31a6d27995e9964e4df83c63188870766 in lucene-solr's branch refs/heads/branch_7x from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=493e8fd ] LUCENE-8272: Share internal DV update code between binary and numeric Today we duplicate a fair portion of the internal logic to apply updates of binary and numeric doc values. This change refactors this non-trivial code to share the same code path and only differ in if we provide a binary or numeric instance. This also allows us to iterator over the updates only once rather than twice once for numeric and once for binary fields. This change also subclass DocValuesIterator from DocValuesFieldUpdates.Iterator which allows easier consumption down the road since it now shares most of it's interface with DocIdSetIterator which is the main interface for this in Lucene. > Share internal DV update code between binary and numeric > > > Key: LUCENE-8272 > URL: https://issues.apache.org/jira/browse/LUCENE-8272 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.4, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.4, master (8.0) > > Attachments: LUCENE-8272.patch > > > Today we duplicate a fair portion of the internal logic to > apply updates of binary and numeric doc values. This change refactors > this non-trivial code to share the same code path and only differ in > if we provide a binary or numeric instance. This also allows us to > iterator over the updates only once rather than twice once for numeric > and once for binary fields. > > This change also subclass DocValuesIterator from > DocValuesFieldUpdates.Iterator > which allows easier consumption down the road since it now shares most of > it's > interface with DocIdSetIterator which is the main interface for this in > Lucene. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8272) Share internal DV update code between binary and numeric
[ https://issues.apache.org/jira/browse/LUCENE-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452231#comment-16452231 ] ASF subversion and git services commented on LUCENE-8272: - Commit fbeef2f726f44f89a42af20eea8a1e0f4c8715f5 in lucene-solr's branch refs/heads/master from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fbeef2f ] LUCENE-8272: Share internal DV update code between binary and numeric Today we duplicate a fair portion of the internal logic to apply updates of binary and numeric doc values. This change refactors this non-trivial code to share the same code path and only differ in if we provide a binary or numeric instance. This also allows us to iterator over the updates only once rather than twice once for numeric and once for binary fields. This change also subclass DocValuesIterator from DocValuesFieldUpdates.Iterator which allows easier consumption down the road since it now shares most of it's interface with DocIdSetIterator which is the main interface for this in Lucene. > Share internal DV update code between binary and numeric > > > Key: LUCENE-8272 > URL: https://issues.apache.org/jira/browse/LUCENE-8272 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.4, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.4, master (8.0) > > Attachments: LUCENE-8272.patch > > > Today we duplicate a fair portion of the internal logic to > apply updates of binary and numeric doc values. This change refactors > this non-trivial code to share the same code path and only differ in > if we provide a binary or numeric instance. This also allows us to > iterator over the updates only once rather than twice once for numeric > and once for binary fields. > > This change also subclass DocValuesIterator from > DocValuesFieldUpdates.Iterator > which allows easier consumption down the road since it now shares most of > it's > interface with DocIdSetIterator which is the main interface for this in > Lucene. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8272) Share internal DV update code between binary and numeric
[ https://issues.apache.org/jira/browse/LUCENE-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450028#comment-16450028 ] Michael McCandless commented on LUCENE-8272: +1 > Share internal DV update code between binary and numeric > > > Key: LUCENE-8272 > URL: https://issues.apache.org/jira/browse/LUCENE-8272 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.4, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.4, master (8.0) > > Attachments: LUCENE-8272.patch > > > Today we duplicate a fair portion of the internal logic to > apply updates of binary and numeric doc values. This change refactors > this non-trivial code to share the same code path and only differ in > if we provide a binary or numeric instance. This also allows us to > iterator over the updates only once rather than twice once for numeric > and once for binary fields. > > This change also subclass DocValuesIterator from > DocValuesFieldUpdates.Iterator > which allows easier consumption down the road since it now shares most of > it's > interface with DocIdSetIterator which is the main interface for this in > Lucene. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8272) Share internal DV update code between binary and numeric
[ https://issues.apache.org/jira/browse/LUCENE-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449891#comment-16449891 ] Shai Erera commented on LUCENE-8272: I put some comments on the PR, but I don't see them mentioned here, so FYI. > Share internal DV update code between binary and numeric > > > Key: LUCENE-8272 > URL: https://issues.apache.org/jira/browse/LUCENE-8272 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.4, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.4, master (8.0) > > Attachments: LUCENE-8272.patch > > > Today we duplicate a fair portion of the internal logic to > apply updates of binary and numeric doc values. This change refactors > this non-trivial code to share the same code path and only differ in > if we provide a binary or numeric instance. This also allows us to > iterator over the updates only once rather than twice once for numeric > and once for binary fields. > > This change also subclass DocValuesIterator from > DocValuesFieldUpdates.Iterator > which allows easier consumption down the road since it now shares most of > it's > interface with DocIdSetIterator which is the main interface for this in > Lucene. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8272) Share internal DV update code between binary and numeric
[ https://issues.apache.org/jira/browse/LUCENE-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449856#comment-16449856 ] Simon Willnauer commented on LUCENE-8272: - [https://github.com/s1monw/lucene-solr/pull/15] /cc [~mikemccand] > Share internal DV update code between binary and numeric > > > Key: LUCENE-8272 > URL: https://issues.apache.org/jira/browse/LUCENE-8272 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.4, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.4, master (8.0) > > Attachments: LUCENE-8272.patch > > > Today we duplicate a fair portion of the internal logic to > apply updates of binary and numeric doc values. This change refactors > this non-trivial code to share the same code path and only differ in > if we provide a binary or numeric instance. This also allows us to > iterator over the updates only once rather than twice once for numeric > and once for binary fields. > > This change also subclass DocValuesIterator from > DocValuesFieldUpdates.Iterator > which allows easier consumption down the road since it now shares most of > it's > interface with DocIdSetIterator which is the main interface for this in > Lucene. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
