[jira] [Commented] (LUCENE-8282) Reduce boxing and unnecessary object creation in DV updates
[ https://issues.apache.org/jira/browse/LUCENE-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458437#comment-16458437 ] ASF subversion and git services commented on LUCENE-8282: - Commit 8f4cd091c23634f3c4e9bf711832e0a50db92ea3 in lucene-solr's branch refs/heads/branch_7x from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8f4cd09 ] LUCENE-8282: Reduce boxing and unnecessary object creation in DV updates DV updates used the boxed type Long to keep API generic. Yet, the missing type caused a lot of code duplication, boxing and unnecessary object creation. This change cuts over to type safe APIs using BytesRef and long (the primitive) In this change most of the code that is almost identical between binary and numeric is not shared reducing the maintenance overhead and likelihood of introducing bugs. > Reduce boxing and unnecessary object creation in DV updates > --- > > Key: LUCENE-8282 > URL: https://issues.apache.org/jira/browse/LUCENE-8282 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.4, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.4, master (8.0) > > Attachments: LUCENE-8282.patch > > > DV updates used the boxed type Long to keep API generic. Yet, the missing > type caused a lot of code duplication, boxing and unnecessary object creation. > This change cuts over to type safe APIs using BytesRef and long (the > primitive) > In this change most of the code that is almost identical between binary and > numeric > is not shared reducing the maintenance overhead and likelihood of introducing > bugs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8282) Reduce boxing and unnecessary object creation in DV updates
[ https://issues.apache.org/jira/browse/LUCENE-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458430#comment-16458430 ] ASF subversion and git services commented on LUCENE-8282: - Commit b43b09190d52a959b8d3b10fcadfabfa58691955 in lucene-solr's branch refs/heads/master from [~simonw] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b43b091 ] LUCENE-8282: Reduce boxing and unnecessary object creation in DV updates DV updates used the boxed type Long to keep API generic. Yet, the missing type caused a lot of code duplication, boxing and unnecessary object creation. This change cuts over to type safe APIs using BytesRef and long (the primitive) In this change most of the code that is almost identical between binary and numeric is not shared reducing the maintenance overhead and likelihood of introducing bugs. > Reduce boxing and unnecessary object creation in DV updates > --- > > Key: LUCENE-8282 > URL: https://issues.apache.org/jira/browse/LUCENE-8282 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.4, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.4, master (8.0) > > Attachments: LUCENE-8282.patch > > > DV updates used the boxed type Long to keep API generic. Yet, the missing > type caused a lot of code duplication, boxing and unnecessary object creation. > This change cuts over to type safe APIs using BytesRef and long (the > primitive) > In this change most of the code that is almost identical between binary and > numeric > is not shared reducing the maintenance overhead and likelihood of introducing > bugs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8282) Reduce boxing and unnecessary object creation in DV updates
[ https://issues.apache.org/jira/browse/LUCENE-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456093#comment-16456093 ] Simon Willnauer commented on LUCENE-8282: - https://github.com/s1monw/lucene-solr/pull/16 /cc [~mikemccand] [~shaie] [~dweiss] > Reduce boxing and unnecessary object creation in DV updates > --- > > Key: LUCENE-8282 > URL: https://issues.apache.org/jira/browse/LUCENE-8282 > Project: Lucene - Core > Issue Type: Improvement >Affects Versions: 7.4, master (8.0) >Reporter: Simon Willnauer >Priority: Major > Fix For: 7.4, master (8.0) > > Attachments: LUCENE-8282.patch > > > DV updates used the boxed type Long to keep API generic. Yet, the missing > type caused a lot of code duplication, boxing and unnecessary object creation. > This change cuts over to type safe APIs using BytesRef and long (the > primitive) > In this change most of the code that is almost identical between binary and > numeric > is not shared reducing the maintenance overhead and likelihood of introducing > bugs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
